chrome-devtools-frontend 1.0.1709383 → 1.0.1713292

package/.agents/skills/code-review/SKILL.md

@@ -10,17 +10,21 @@ Use it for self-review before upload and for reviewing other people's CLs.
 
 ## 1. Gather context
 
-- **Local change:** `git diff origin/main...HEAD` (or `git show HEAD` for a
-  single-commit branch). To learn about the branch and upload workflow, see the
-  `devtools-version-control` skill.
-- **Gerrit CL:** strip the leading `)]}'` line from each response to get JSON:
-  - Diff: `git cl diff` (for the current branch), or fetch the patch set.
-  - Inline comments:
-    `curl -s https://chromium-review.googlesource.com/changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/comments | tail -n +2`
-  - Messages:
-    `.../changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/messages`
-- Read the CL description first. Then check that the diff does what the
-  description says, and nothing else.
+- **Automated Review Agent (diff already in prompt):** Do not run shell
+  commands. Use `read_file` to inspect enclosing classes/functions/tests and
+  `search_files` to verify callers or conventions across the repository.
+- **Local CLI / Interactive session (no diff in prompt):**
+  - **Local change:** `git diff origin/main...HEAD` (or `git show HEAD` for a
+    single-commit branch). To learn about the branch and upload workflow, see the
+    `devtools-version-control` skill.
+  - **Gerrit CL:** strip the leading `)]}'` line from each response to get JSON:
+    - Diff: `git cl diff` (for the current branch), or fetch the patch set.
+    - Inline comments:
+      `curl -s https://chromium-review.googlesource.com/changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/comments | tail -n +2`
+    - Messages:
+      `.../changes/devtools%2Fdevtools-frontend~<CL_NUMBER>/messages`
+  - Read the CL description first. Then check that the diff does what the
+    description says, and nothing else.
 
 ## 2. Consult the specialized skills
 
@@ -29,7 +33,7 @@ Load the skill that matches what the diff touches, and apply its rules:
 | If the diff touches… | Use skill |
 | :--- | :--- |
 | Any `import` statement, or a new cross-module dependency | `devtools-imports` |
-| `UI.Widget`, lit-html views, components, CSS | `devtools-ui-widgets` |
+| `UI.Widget`, lit-html views, components, CSS | `ui-widgets` |
 | Migration of legacy imperative DOM to widgets or Lit | `ui-eng-vision-orchestrator` (and its sub-skills) |
 | New or changed tests: choosing unit, API, or E2E | `devtools-testing-guidance` |
 | Tests that use `describeWithEnvironment` or `describeWithMockConnection`, or foundation modules | `foundation-test-migration` |

package/AUTHORS

@@ -60,6 +60,7 @@ Jan Keitel <jan.keitel@gmail.com>
 Jeffrey Chen <jeffreyca16@gmail.com>
 Jerome Vouillon <jerome.vouillon@gmail.com>
 Jesper van den Ende <jespertheend@gmail.com>
+Jihyeon Lee <wlgus7464@gmail.com>
 Jithil p Ponnan <jithil.p@gmail.com>
 Joseph P <thepigrammer@gmail.com>
 Juba Borgohain <chromiumjuba@gmail.com>
@@ -107,6 +108,7 @@ Sergio Avalos <sergio.avalos@gmail.com>
 Shelley Vohr <shelley.vohr@gmail.com>
 Simon Siefke <simon.siefke@gmail.com>
 Stephen Tsoi-A-Sue <stsoiasue@gmail.com>
+Steve Harrison <steve@steveharrison.dev>
 Sunnylost <sunnylost@gmail.com>
 Suyoung Jung <tdhitbtd@gmail.com>
 TaegeonKim <aksen5240@gmail.com>

package/DIR_METADATA

@@ -2,3 +2,39 @@ team_email: "devtools-dev@chromium.org"
 buganizer_public: {
   component_id: 1457055
 }
+agentic_review: {
+  capability_groups: {
+    name: "core-review"
+    review_capability_skills: [".agents/skills/code-review/SKILL.md"]
+  }
+  capability_groups: {
+    name: "typescript-and-models"
+    path_expression: ["front_end/.*\\.ts", ".*BUILD\\.gn", ".*\\.gni"]
+    path_expression_exclusion: [".*\\.test\\.ts"]
+    review_capability_skills: [
+      ".agents/skills/devtools-imports/SKILL.md",
+      ".agents/skills/devtools-model-management/SKILL.md",
+      ".agents/skills/devtools-setting-migration/SKILL.md",
+      ".agents/skills/devtools-unicode-escaping/SKILL.md",
+      ".agents/skills/devtools-ux-writing-refactor/SKILL.md"
+    ]
+  }
+  capability_groups: {
+    name: "ui-and-widgets"
+    path_expression: ["front_end/(panels|ui)/.*\\.(ts|css)"]
+    path_expression_exclusion: [".*\\.test\\.ts"]
+    review_capability_skills: [
+      ".agents/skills/ui-widgets/SKILL.md",
+      ".agents/skills/ui-eng-vision-orchestrator/SKILL.md"
+    ]
+  }
+  capability_groups: {
+    name: "tests"
+    path_expression: [".*\\.test\\.ts", "test/.*\\.ts"]
+    review_capability_skills: [
+      ".agents/skills/devtools-testing-guidance/SKILL.md",
+      ".agents/skills/foundation-test-migration/SKILL.md",
+      ".agents/skills/fix-tests/SKILL.md"
+    ]
+  }
+}

package/front_end/core/common/ParsedURL.ts

@@ -57,26 +57,34 @@ const WEB_SAFE_SCHEMES = new Set([
   'data:',
 ]);
 
-/**
- * Returns true if the URL uses an unprivileged web-safe scheme (or is a `blob:` URL wrapping one).
- */
-export function hasWebSafeScheme(url: Platform.DevToolsPath.UrlString|URL|string): boolean {
+function parseUnwrappedURL(url: Platform.DevToolsPath.UrlString|URL|string): URL|null {
   try {
-    const parsed = new URL(url);
-    if (parsed.protocol === 'blob:') {
-      return hasWebSafeScheme(parsed.pathname);
+    let parsed = new URL(url);
+    // Iteratively unwrap nested `blob:` and `filesystem:` URLs (e.g. `blob:filesystem:https://...`)
+    // to inspect the underlying origin's protocol.
+    while (parsed.protocol === 'blob:' || parsed.protocol === 'filesystem:') {
+      parsed = new URL(parsed.href.slice(parsed.protocol.length));
     }
-    return WEB_SAFE_SCHEMES.has(parsed.protocol);
+    return parsed;
   } catch {
-    return false;
+    return null;
   }
 }
 
+/**
+ * Returns true if the URL uses an unprivileged web-safe scheme (or is a `blob:`/`filesystem:` URL wrapping one).
+ */
+export function hasWebSafeScheme(url: Platform.DevToolsPath.UrlString|URL|string): boolean {
+  const parsed = parseUnwrappedURL(url);
+  return parsed !== null && WEB_SAFE_SCHEMES.has(parsed.protocol);
+}
+
 /**
  * Privileged browser and local schemes that must not be opened via external/new-tab links by default.
  */
 const PRIVILEGED_SCHEMES = new Set([
   'chrome:',
+  'chrome-error:',
   'chrome-extension:',
   'chrome-search:',
   'chrome-untrusted:',
@@ -86,18 +94,11 @@ const PRIVILEGED_SCHEMES = new Set([
 ]);
 
 /**
- * Returns true if the URL uses a privileged scheme (or is a `blob:` URL wrapping one).
+ * Returns true if the URL uses a privileged scheme (or is a `blob:`/`filesystem:` URL wrapping one).
  */
 export function isPrivilegedScheme(url: Platform.DevToolsPath.UrlString|URL|string): boolean {
-  try {
-    const parsed = new URL(url);
-    if (parsed.protocol === 'blob:') {
-      return isPrivilegedScheme(parsed.pathname);
-    }
-    return PRIVILEGED_SCHEMES.has(parsed.protocol);
-  } catch {
-    return false;
-  }
+  const parsed = parseUnwrappedURL(url);
+  return parsed !== null && PRIVILEGED_SCHEMES.has(parsed.protocol);
 }
 
 /**

package/front_end/core/sdk/CSSStyleSheetHeader.ts

@@ -19,11 +19,11 @@ const UIStrings = {
   /**
    * @description Error message for when a CSS file can't be loaded.
    */
-  couldNotFindTheOriginalStyle: 'Could not find the original style sheet',
+  couldNotFindTheOriginalStyle: 'Couldn’t find the original style sheet',
   /**
    * @description Error message to display when a source CSS file could not be retrieved.
    */
-  couldNotRetrieveSourceStyles: 'Could not retrieve source styles',
+  couldNotRetrieveSourceStyles: 'Couldn’t retrieve source styles',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/CSSStyleSheetHeader.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

package/front_end/core/sdk/CompilerSourceMappingContentProvider.ts

@@ -15,7 +15,7 @@ const UIStrings = {
    * @example {https://example.com/sourcemap.map} PH1
    * @example {An error occurred} PH2
    */
-  couldNotLoadContentForSS: 'Could not load content for {PH1} ({PH2})',
+  couldNotLoadContentForSS: 'Couldn’t load content for {PH1} ({PH2})',
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('core/sdk/CompilerSourceMappingContentProvider.ts', UIStrings);

package/front_end/core/sdk/DOMModel.ts

@@ -1100,8 +1100,9 @@ export class DOMNode extends Common.ObjectWrapper.ObjectWrapper<DOMNodeEventType
    */
   async toggleHideElement(): Promise<void> {
     let pseudoElementName = this.pseudoType() ? this.nodeName() : null;
-    if (pseudoElementName && this.pseudoIdentifier()) {
-      pseudoElementName += `(${this.pseudoIdentifier()})`;
+    const pseudoIdentifier = this.pseudoIdentifier();
+    if (pseudoElementName && pseudoIdentifier) {
+      pseudoElementName += `(${cssEscape(pseudoIdentifier)})`;
     }
 
     let effectiveNode: DOMNode|null = this;
@@ -1358,8 +1359,9 @@ export class DOMNode extends Common.ObjectWrapper.ObjectWrapper<DOMNodeEventType
       const classList = classes.trim().split(/\s+/g);
       return (lowerCaseName === 'div' ? '' : lowerCaseName) + '.' + classList.map(cls => cssEscape(cls)).join('.');
     }
-    if (this.pseudoIdentifier()) {
-      return `${lowerCaseName}(${this.pseudoIdentifier()})`;
+    const pseudoIdentifier = this.pseudoIdentifier();
+    if (pseudoIdentifier) {
+      return `${lowerCaseName}(${cssEscape(pseudoIdentifier)})`;
     }
     return lowerCaseName;
   }

package/front_end/core/sdk/NetworkRequest.ts

@@ -30,11 +30,11 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  secureOnly: 'This cookie was blocked because it had the "`Secure`" attribute and the connection was not secure',
+  secureOnly: 'This cookie was blocked because it had the "`Secure`" attribute and the connection wasn’t secure',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  notOnPath: 'This cookie was blocked because its path was not an exact match for or a superdirectory of the request URL’s path',
+  notOnPath: 'This cookie was blocked because its path wasn’t an exact match for or a superdirectory of the request URL’s path',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
@@ -46,15 +46,15 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  sameSiteLax: 'This cookie was blocked because it had the "`SameSite=Lax`" attribute and the request was made from a different site and was not initiated by a top-level navigation',
+  sameSiteLax: 'This cookie was blocked because it had the "`SameSite=Lax`" attribute and the request was made from a different site and wasn’t initiated by a top-level navigation',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  sameSiteUnspecifiedTreatedAsLax: 'This cookie didn’t specify a "`SameSite`" attribute when it was stored and was defaulted to "`SameSite=Lax`", and was blocked because the request was made from a different site and was not initiated by a top-level navigation. The cookie had to have been set with "`SameSite=None`" to enable cross-site usage.',
+  sameSiteUnspecifiedTreatedAsLax: 'This cookie didn’t specify a "`SameSite`" attribute when it was stored and was defaulted to "`SameSite=Lax`", and was blocked because the request was made from a different site and wasn’t initiated by a top-level navigation. The cookie had to have been set with "`SameSite=None`" to enable cross-site usage.',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  sameSiteNoneInsecure: 'This cookie was blocked because it had the "`SameSite=None`" attribute but was not marked "`Secure`". Cookies without SameSite restrictions must be marked "`Secure`" and sent over a secure connection.',
+  sameSiteNoneInsecure: 'This cookie was blocked because it had the "`SameSite=None`" attribute but wasn’t marked "`Secure`". Cookies without SameSite restrictions must be marked "`Secure`" and sent over a secure connection.',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
@@ -90,7 +90,7 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
-  theSchemeOfThisConnectionIsNot: 'The scheme of this connection is not allowed to store cookies',
+  theSchemeOfThisConnectionIsNot: 'The scheme of this connection isn’t allowed to store cookies',
   /**
    * @description Tooltip to explain why a cookie was blocked.
    */
@@ -98,24 +98,24 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonSecureOnly: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`Secure`" attribute but was not received over a secure connection',
+  blockedReasonSecureOnly: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`Secure`" attribute but wasn’t received over a secure connection',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    * @example {SameSite=Strict} PH1
    */
-  blockedReasonSameSiteStrictLax: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "{PH1}" attribute but came from a cross-site response which was not the response to a top-level navigation',
+  blockedReasonSameSiteStrictLax: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "{PH1}" attribute but came from a cross-site response which wasn’t the response to a top-level navigation',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonSameSiteUnspecifiedTreatedAsLax: 'This "`Set-Cookie`" header didn’t specify a "`SameSite`" attribute and was defaulted to "`SameSite=Lax`", and was blocked because it came from a cross-site response which was not the response to a top-level navigation. The "`Set-Cookie`" header had to have been set with "`SameSite=None`" to enable cross-site usage.',
+  blockedReasonSameSiteUnspecifiedTreatedAsLax: 'This "`Set-Cookie`" header didn’t specify a "`SameSite`" attribute and was defaulted to "`SameSite=Lax`", and was blocked because it came from a cross-site response which wasn’t the response to a top-level navigation. The "`Set-Cookie`" header had to have been set with "`SameSite=None`" to enable cross-site usage.',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonSameSiteNoneInsecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`SameSite=None`" attribute but did not have the "`Secure`" attribute, which is required in order to use "`SameSite=None`"',
+  blockedReasonSameSiteNoneInsecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it had the "`SameSite=None`" attribute but didn’t have the "`Secure`" attribute, which is required in order to use "`SameSite=None`"',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */
-  blockedReasonOverwriteSecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it was not sent over a secure connection and would have overwritten a cookie with the "`Secure`" attribute',
+  blockedReasonOverwriteSecure: 'This attempt to set a cookie via a "`Set-Cookie`" header was blocked because it wasn’t sent over a secure connection and would have overwritten a cookie with the "`Secure`" attribute',
   /**
    * @description Tooltip to explain why an attempt to set a cookie via a `Set-Cookie` HTTP header on a request's response was blocked.
    */

package/front_end/core/sdk/PageFunctions.ts

@@ -109,7 +109,7 @@ export function toggleClassAndInjectStyleRule(this: Element, pseudoElementName:
   const classNamePrefix = '__web-inspector-hide';
   const classNameSuffix = '-shortcut__';
   const styleTagId = '__web-inspector-hide-shortcut-style__';
-  const pseudoElementNameEscaped = pseudoElementName ? pseudoElementName.replace(/[\(\)\:]/g, '_') : '';
+  const pseudoElementNameEscaped = pseudoElementName ? pseudoElementName.replace(/[^a-zA-Z0-9_-]/g, '_') : '';
   const className = classNamePrefix + pseudoElementNameEscaped + classNameSuffix;
   this.classList.toggle(className, hidden);
 

package/front_end/core/sdk/ResourceTreeModel.ts

@@ -291,6 +291,21 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
     this.dispatchEventToListeners(Events.FrameNavigatedWithinDocument, frame);
   }
 
+  frameStoppedLoading(frameId: Protocol.Page.FrameId): void {
+    const frame = this.framesInternal.get(frameId);
+    if (!frame) {
+      return;
+    }
+    // The renderer sends `Page.frameNavigated` before it tells the browser
+    // process about the commit, so the `Storage.getStorageKey` request issued
+    // from `ResourceTreeFrame.navigate()` may be answered for the previous
+    // document (and fails outright if that document had an opaque origin, e.g.
+    // the initial about:blank). `Page.frameStoppedLoading` comes from the
+    // browser process after the commit, so re-fetch the storage key here.
+    void frame.getStorageKey(/* forceFetch */ true);
+    void this.updateStorageKeys();
+  }
+
   frameDetached(frameId: Protocol.Page.FrameId, isSwap: boolean): void {
     // Do nothing unless cached resource tree is processed - it will overwrite everything.
     if (!this.#cachedResourcesProcessed) {
@@ -1145,7 +1160,8 @@ export class PageDispatcher implements ProtocolProxyApi.PageDispatcher {
   frameStartedLoading({}: Protocol.Page.FrameStartedLoadingEvent): void {
   }
 
-  frameStoppedLoading({}: Protocol.Page.FrameStoppedLoadingEvent): void {
+  frameStoppedLoading({frameId}: Protocol.Page.FrameStoppedLoadingEvent): void {
+    this.#resourceTreeModel.frameStoppedLoading(frameId);
   }
 
   frameRequestedNavigation({}: Protocol.Page.FrameRequestedNavigationEvent): void {

package/front_end/core/sdk/SourceMap.ts

@@ -905,6 +905,12 @@ export class SourceMap {
     return this.hasEncodedScopeInfo() && (this.#scopesInfo?.hasOutlinedFunctions() ?? false);
   }
 
+  /** See {@link SourceMapScopesInfo.outlinedFunctionRanges}. Empty without encoded scopes. */
+  outlinedFunctionRanges(generatedLine: number, generatedColumn: number): PositionRange[] {
+    return this.hasEncodedScopeInfo() ? this.#scopesInfo?.outlinedFunctionRanges(generatedLine, generatedColumn) ?? [] :
+                                        [];
+  }
+
   /** See {@link SourceMapScopesInfo.artificialFunctionRanges}. Empty without encoded scopes. */
   artificialFunctionRanges(): PositionRange[] {
     return this.hasEncodedScopeInfo() ? this.#scopesInfo?.artificialFunctionRanges() ?? [] : [];

package/front_end/core/sdk/SourceMapScopesInfo.ts

@@ -624,6 +624,31 @@ export class SourceMapScopesInfo {
     return hasOutlined(this.#generatedRanges);
   }
 
+  /**
+   * @returns the outlined parts of the authored function at the position: the hidden generated functions whose
+   *          original scope lies within that function's original scope (see {@link GeneratedFrameKind.OUTLINED}).
+   *          Includes the outlined part the position itself is in, if any. Sorted by start position.
+   */
+  outlinedFunctionRanges(generatedLine: number, generatedColumn: number): PositionRange[] {
+    const rangeChain = this.#findGeneratedRangeChain(generatedLine, generatedColumn);
+    const functionScope = this.#findFunctionScopeInOriginalScopeChain(rangeChain.at(-1)?.originalScope);
+    if (!functionScope) {
+      return [];
+    }
+    const isWithinFunction = (scope: ScopesCodec.OriginalScope|undefined): boolean =>
+        scope !== undefined && (scope === functionScope || isWithinFunction(scope.parent));
+    const result: PositionRange[] = [];
+    (function walk(ranges: ScopesCodec.GeneratedRange[]) {
+      for (const range of ranges) {
+        if (range.isStackFrame && range.isHidden && isWithinFunction(range.originalScope)) {
+          result.push({start: range.start, end: range.end});
+        }
+        walk(range.children);
+      }
+    })(this.#generatedRanges);
+    return result;
+  }
+
   /**
    * @returns the "artificial" generated functions (in the DWARF sense): functions that contain no authored code at all
    *          (no original scope anywhere in their subtree), e.g. compiler helpers. Sorted by start position,

package/front_end/entrypoints/inspector_main/inspector_main-meta.ts

@@ -39,7 +39,7 @@ const UIStrings = {
   /**
    * @description Title of an option under the Rendering category that can be invoked through the Command Menu.
    */
-  doNotHighlightAdFrames: 'Do not highlight ad frames',
+  doNotHighlightAdFrames: 'Don’t highlight ad frames',
   /**
    * @description Title of an option under the Rendering category that can be invoked through the Command Menu.
    */
@@ -71,11 +71,11 @@ const UIStrings = {
   /**
    * @description Title of a Rendering setting that can be invoked through the Command Menu.
    */
-  doNotEmulateAFocusedPage: 'Do not emulate a focused page',
+  doNotEmulateAFocusedPage: 'Don’t emulate a focused page',
   /**
    * @description Title of a setting under the Rendering category that can be invoked through the Command Menu.
    */
-  doNotEmulateCssMediaType: 'Do not emulate CSS media type',
+  doNotEmulateCssMediaType: 'Don’t emulate CSS media type',
   /**
    * @description A drop-down menu option to do not emulate css media type.
    */
@@ -108,7 +108,7 @@ const UIStrings = {
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    * @example {prefers-color-scheme} PH1
    */
-  doNotEmulateCss: 'Do not emulate CSS {PH1}',
+  doNotEmulateCss: 'Don’t emulate CSS {PH1}',
   /**
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    * @example {prefers-color-scheme: light} PH1
@@ -172,7 +172,7 @@ const UIStrings = {
   /**
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    */
-  doNotEmulateAnyVisionDeficiency: 'Do not emulate any vision deficiency',
+  doNotEmulateAnyVisionDeficiency: 'Don’t emulate any vision deficiency',
   /**
    * @description Title of a setting under the Rendering drawer that can be invoked through the Command Menu.
    */
@@ -232,7 +232,7 @@ const UIStrings = {
   /**
    * @description Title of a setting under the Rendering category that can be invoked through the Command Menu.
    */
-  doNotEmulateOsTextScale: 'Do not emulate OS text scale',
+  doNotEmulateOsTextScale: 'Don’t emulate OS text scale',
   /**
    * @description A drop-down menu option to not emulate OS text scale.
    */
@@ -340,7 +340,7 @@ const UIStrings = {
    * @description A command available in the command menu to stop automatically opening DevTools when
    * webpages create new popup windows.
    */
-  doNotAutoOpen: 'Do not auto-open DevTools for popups',
+  doNotAutoOpen: 'Don’t auto-open DevTools for popups',
   /**
    * @description Title of an action that toggles the "forces CSS prefers-color-scheme" media feature.
    */

package/front_end/generated/InspectorBackendCommands.ts

@@ -257,6 +257,7 @@ inspectorBackend.registerCommand("CSS.disable", [], [], "Disables the CSS agent
 inspectorBackend.registerCommand("CSS.enable", [], [], "Enables the CSS agent for the given page. Clients should not assume that the CSS agent has been enabled until the result of this command is received.");
 inspectorBackend.registerCommand("CSS.forcePseudoState", [{"name": "nodeId", "type": "number", "optional": false, "description": "The element id for which to force the pseudo state.", "typeRef": "DOM.NodeId"}, {"name": "forcedPseudoClasses", "type": "array", "optional": false, "description": "Element pseudo classes to force when computing the element's style.", "typeRef": "string"}], [], "Ensures that the given node will have specified pseudo-classes whenever its style is computed by the browser.");
 inspectorBackend.registerCommand("CSS.forceStartingStyle", [{"name": "nodeId", "type": "number", "optional": false, "description": "The element id for which to force the starting-style state.", "typeRef": "DOM.NodeId"}, {"name": "forced", "type": "boolean", "optional": false, "description": "Boolean indicating if this is on or off.", "typeRef": null}], [], "Ensures that the given node is in its starting-style state.");
+inspectorBackend.registerCommand("CSS.forcePositionTryOption", [{"name": "nodeId", "type": "number", "optional": false, "description": "The element id for which to force the position-try option.", "typeRef": "DOM.NodeId"}, {"name": "index", "type": "number", "optional": true, "description": "The 1-based index of the position-try fallback option, 0 for base position (no fallback), or omitted to clear the forced state.", "typeRef": null}], [], "Forces a position-try option for the given node.");
 inspectorBackend.registerCommand("CSS.getBackgroundColors", [{"name": "nodeId", "type": "number", "optional": false, "description": "Id of the node to get background colors for.", "typeRef": "DOM.NodeId"}], ["backgroundColors", "computedFontSize", "computedFontWeight"], "");
 inspectorBackend.registerCommand("CSS.getComputedStyleForNode", [{"name": "nodeId", "type": "number", "optional": false, "description": "", "typeRef": "DOM.NodeId"}], ["computedStyle", "extraFields"], "Returns the computed style for a DOM node identified by `nodeId`.");
 inspectorBackend.registerCommand("CSS.resolveValues", [{"name": "values", "type": "array", "optional": false, "description": "Cascade-dependent keywords (revert/revert-layer) do not work.", "typeRef": "string"}, {"name": "nodeId", "type": "number", "optional": false, "description": "Id of the node in whose context the expression is evaluated", "typeRef": "DOM.NodeId"}, {"name": "propertyName", "type": "string", "optional": true, "description": "Only longhands and custom property names are accepted.", "typeRef": null}, {"name": "pseudoType", "type": "string", "optional": true, "description": "Pseudo element type, only works for pseudo elements that generate elements in the tree, such as ::before and ::after.", "typeRef": "DOM.PseudoType"}, {"name": "pseudoIdentifier", "type": "string", "optional": true, "description": "Pseudo element custom ident.", "typeRef": null}], ["results"], "Resolve the specified values in the context of the provided element. For example, a value of '1em' is evaluated according to the computed 'font-size' of the element and a value 'calc(1px + 2px)' will be resolved to '3px'. If the `propertyName` was specified the `values` are resolved as if they were property's declaration. If a value cannot be parsed according to the provided property syntax, the value is parsed using combined syntax as if null `propertyName` was provided. If the value cannot be resolved even then, return the provided value without any changes. Note: this function currently does not resolve CSS random() function, it returns unmodified random() function parts.`");
@@ -1566,7 +1567,7 @@ inspectorBackend.registerCommand("Debugger.setSkipAllPauses", [{"name": "skip",
 inspectorBackend.registerCommand("Debugger.setVariableValue", [{"name": "scopeNumber", "type": "number", "optional": false, "description": "0-based number of scope as was listed in scope chain. Only 'local', 'closure' and 'catch' scope types are allowed. Other scopes could be manipulated manually.", "typeRef": null}, {"name": "variableName", "type": "string", "optional": false, "description": "Variable name.", "typeRef": null}, {"name": "newValue", "type": "object", "optional": false, "description": "New variable value.", "typeRef": "Runtime.CallArgument"}, {"name": "callFrameId", "type": "string", "optional": false, "description": "Id of callframe that holds variable.", "typeRef": "Debugger.CallFrameId"}], [], "Changes value of variable in a callframe. Object-based scopes are not supported and must be mutated manually.");
 inspectorBackend.registerCommand("Debugger.stepInto", [{"name": "breakOnAsyncCall", "type": "boolean", "optional": true, "description": "Debugger will pause on the execution of the first async task which was scheduled before next pause.", "typeRef": null}, {"name": "skipList", "type": "array", "optional": true, "description": "The skipList specifies location ranges that should be skipped on step into.", "typeRef": "Debugger.LocationRange"}], [], "Steps into the function call.");
 inspectorBackend.registerCommand("Debugger.stepOut", [], [], "Steps out of the function call.");
-inspectorBackend.registerCommand("Debugger.stepOver", [{"name": "skipList", "type": "array", "optional": true, "description": "The skipList specifies location ranges that should be skipped on step over.", "typeRef": "Debugger.LocationRange"}], [], "Steps over the statement.");
+inspectorBackend.registerCommand("Debugger.stepOver", [{"name": "skipList", "type": "array", "optional": true, "description": "The skipList specifies location ranges that should be skipped on step over.", "typeRef": "Debugger.LocationRange"}, {"name": "enterRanges", "type": "array", "optional": true, "description": "Functions whose source range lies within one of the enterRanges are entered as if by stepInto, even when they are called (directly or indirectly) from a call that is stepped over.", "typeRef": "Debugger.LocationRange"}], [], "Steps over the statement.");
 inspectorBackend.registerType("Debugger.Location", [{"name": "scriptId", "type": "string", "optional": false, "description": "Script identifier as reported in the `Debugger.scriptParsed`.", "typeRef": "Runtime.ScriptId"}, {"name": "lineNumber", "type": "number", "optional": false, "description": "Line number in the script (0-based).", "typeRef": null}, {"name": "columnNumber", "type": "number", "optional": true, "description": "Column number in the script (0-based).", "typeRef": null}]);
 inspectorBackend.registerType("Debugger.ScriptPosition", [{"name": "lineNumber", "type": "number", "optional": false, "description": "", "typeRef": null}, {"name": "columnNumber", "type": "number", "optional": false, "description": "", "typeRef": null}]);
 inspectorBackend.registerType("Debugger.LocationRange", [{"name": "scriptId", "type": "string", "optional": false, "description": "", "typeRef": "Runtime.ScriptId"}, {"name": "start", "type": "object", "optional": false, "description": "", "typeRef": "Debugger.ScriptPosition"}, {"name": "end", "type": "object", "optional": false, "description": "", "typeRef": "Debugger.ScriptPosition"}]);

package/front_end/generated/protocol-mapping.d.ts

@@ -1567,6 +1567,13 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.CSS.ForceStartingStyleRequest];
       returnType: void;
     };
+    /**
+     * Forces a position-try option for the given node.
+     */
+    'CSS.forcePositionTryOption': {
+      paramsType: [Protocol.CSS.ForcePositionTryOptionRequest];
+      returnType: void;
+    };
     'CSS.getBackgroundColors': {
       paramsType: [Protocol.CSS.GetBackgroundColorsRequest];
       returnType: Protocol.CSS.GetBackgroundColorsResponse;

package/front_end/generated/protocol-proxy-api.d.ts

@@ -796,6 +796,11 @@ declare namespace ProtocolProxyApi {
      */
     invoke_forceStartingStyle(params: Protocol.CSS.ForceStartingStyleRequest): Promise<Protocol.ProtocolResponseWithError>;
 
+    /**
+     * Forces a position-try option for the given node.
+     */
+    invoke_forcePositionTryOption(params: Protocol.CSS.ForcePositionTryOptionRequest): Promise<Protocol.ProtocolResponseWithError>;
+
     invoke_getBackgroundColors(params: Protocol.CSS.GetBackgroundColorsRequest): Promise<Protocol.CSS.GetBackgroundColorsResponse>;
 
     /**

package/front_end/generated/protocol.ts

@@ -4066,6 +4066,18 @@ export namespace CSS {
     forced: boolean;
   }
 
+  export interface ForcePositionTryOptionRequest {
+    /**
+     * The element id for which to force the position-try option.
+     */
+    nodeId: DOM.NodeId;
+    /**
+     * The 1-based index of the position-try fallback option, 0 for base position (no fallback),
+     * or omitted to clear the forced state.
+     */
+    index?: integer;
+  }
+
   export interface GetBackgroundColorsRequest {
     /**
      * Id of the node to get background colors for.
@@ -21393,6 +21405,12 @@ export namespace Debugger {
      * The skipList specifies location ranges that should be skipped on step over.
      */
     skipList?: LocationRange[];
+    /**
+     * Functions whose source range lies within one of the enterRanges are
+     * entered as if by stepInto, even when they are called (directly or
+     * indirectly) from a call that is stepped over.
+     */
+    enterRanges?: LocationRange[];
   }
 
   /**

package/front_end/models/ai_assistance/agents/AiAgent.ts

@@ -189,7 +189,7 @@ export interface ParsedAnswer {
 
 export type ParsedResponse = ParsedAnswer;
 
-export const MAX_STEPS = 10;
+export const MAX_STEPS = 20;
 
 export interface ConversationSuggestion {
   title: string;
@@ -519,8 +519,6 @@ class CrossOriginError extends Error {
  *
  * TODO: missing a test that action code is yielded before the
  * confirmation dialog.
- * TODO: missing a test for an error if it took
- * more than MAX_STEPS iterations.
  */
 export abstract class AiAgent<T> {
   /**
@@ -994,7 +992,12 @@ export abstract class AiAgent<T> {
           break;
         }
       } else {
-        yield this.#createErrorResponse(i - 1 === MAX_STEPS ? ErrorType.MAX_STEPS : ErrorType.UNKNOWN);
+        yield this.#createErrorResponse(ErrorType.UNKNOWN);
+        break;
+      }
+
+      if (i === MAX_STEPS - 1) {
+        yield this.#createErrorResponse(ErrorType.MAX_STEPS);
         break;
       }
     }

package/front_end/models/ai_assistance/agents/StylingAgent.ts

@@ -47,6 +47,7 @@ First, examine the provided context, then use the functions to gather additional
 * After applying a fix, please ask the user to confirm if the fix worked or not.
 * ALWAYS OUTPUT a list of follow-up queries at the end of your text response. The format is SUGGESTIONS: ["suggestion1", "suggestion2", "suggestion3"]. Make sure that the array and the \`SUGGESTIONS: \` text is in the same line. You're also capable of executing the fix for the issue user mentioned. Reflect this in your suggestions.
 * Use the precision of Strunk & White, the brevity of Hemingway, and the simple clarity of Vonnegut. Don't add repeated information, and keep the whole answer short.
+* If the target element is in a cross-origin iframe, stop and ask the user to select it in the Elements panel and start a new chat with that context.
 * **CRITICAL** NEVER write full Python programs - you should only write individual statements that invoke a single function from the provided library.
 * **CRITICAL** NEVER output text before a function call. Always do a function call first.
 * **CRITICAL** When answering questions about positioning or layout, ALWAYS inspect \`position\`, \`display\` and all other related properties. You MUST provide a specific list of CSS property names when calling functions to get styles. Do not use generic values like "all" or "*".

package/front_end/models/ai_assistance/contexts/LighthouseContext.snapshot.txt

@@ -34,6 +34,11 @@ Lighthouse Version: 1.0.0
 
 ## Category Scores
 - Accessibility: 50
+
+## Failing audits
+
+### Accessibility (categoryId: "accessibility")
+- Accessibility Audit: 50
 === end content
 
 Title: LighthouseContext with AI V2 architecture enabled returns the report summary as user facing details
@@ -41,7 +46,7 @@ Content:
 [
   {
     "title": "Lighthouse report",
-    "text": "# Lighthouse Report Summary\nURL: https://example.com\nFetch Time: 2026-03-12\nLighthouse Version: 1.0.0\n\n## Category Scores\n- Accessibility: 50"
+    "text": "# Lighthouse Report Summary\nURL: https://example.com\nFetch Time: 2026-03-12\nLighthouse Version: 1.0.0\n\n## Category Scores\n- Accessibility: 50\n\n## Failing audits\n\n### Accessibility (categoryId: \"accessibility\")\n- Accessibility Audit: 50"
   }
 ]
 === end content

package/front_end/models/ai_assistance/contexts/LighthouseContext.ts

@@ -58,8 +58,9 @@ export class LighthouseContext extends ConversationContext<LHModel.ReporterTypes
       this.#cachedPayload =
           '**CRITICAL**: The Lighthouse report failed to record or all category scores are error/unavailable (n/a). This indicates a failed run or missing data.';
     } else if (Root.Runtime.hostConfig.devToolsAiV2Architecture?.enabled) {
-      // AI V2 sends only the summary; the agent fetches category audits on demand via `getLighthouseAudits`.
-      this.#cachedPayload = formatter.summary(this.#lh);
+      // AI V2 sends failing audit titles without their details to keep the prompt small. The agent
+      // uses the category IDs in the list to fetch full details with `getLighthouseAudits`.
+      this.#cachedPayload = `${formatter.summary(this.#lh)}\n\n${formatter.failingAuditsSummary(this.#lh)}`;
     } else {
       // The V1 `AccessibilityAgent` expects the accessibility audits up front. Remove this branch with V1.
       this.#cachedPayload =

package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt

@@ -133,3 +133,14 @@ The following audits in this category have a score below 90 and may need attenti
       * **Resource Size**: 22.2 kB
       * **Est Savings**: 16.9 kB
 === end content
+
+Title: LighthouseFormatter lists failing audits grouped by category with the category ID
+Content:
+## Failing audits
+
+### Performance (categoryId: "performance")
+- First Audit: 80
+
+### Accessibility (categoryId: "accessibility")
+- No failing audits.
+=== end content