chrome-devtools-frontend 1.0.1706026 → 1.0.1708524

package/front_end/entrypoints/heap_snapshot_worker/ContextAnalyzer.ts

@@ -28,6 +28,11 @@ type ScopeInfoNodeIndex = Platform.Brand.Brand<number, 'ScopeInfoNodeIndex'>;
  */
 type ContextNodeIndex = Platform.Brand.Brand<number, 'ContextNodeIndex'>;
 
+/**
+ * Index of a `system / Map` node within the heap snapshot's node array.
+ */
+type MapNodeIndex = Platform.Brand.Brand<number, 'MapNodeIndex'>;
+
 /**
  * Values addressed by scope. Since a `ScopeId` is only unique within its
  * script, scopes are keyed by script first.
@@ -74,6 +79,8 @@ interface ScopeAccumulator {
 }
 
 interface LiveClosure {
+  // The JSFunction or generator object this entry was created for.
+  ownerNodeIndex: number;
   contextNodeIndex: ContextNodeIndex;
   scriptNodeIndex: ScriptNodeIndex;
   scopeId: ScopeId;
@@ -99,6 +106,8 @@ interface HeapScan {
   scripts: Map<ScriptNodeIndex, ScriptInfo>;
   contextNodes: ContextNodeInfo[];
   liveClosures: LiveClosure[];
+  // Top-level functions of modules that finished evaluating.
+  finishedModuleFunctionNodeIndexes: Set<number>;
   // Maps a ScopeInfo to the script it belongs to. A stored `undefined` is a memoized
   // failed lookup. It is therefore not the same as an absent entry, which merely means
   // "not resolved yet".
@@ -114,7 +123,7 @@ export function analyzeContexts(snapshot: HeapSnapshot): HeapSnapshotModel.HeapS
   const scan = scanHeap(snapshot);
 
   // (3) Group live closures by function scope and record the context chains they can reach.
-  const liveFunctionsByScript = buildLiveFunctions(snapshot, scan.liveClosures);
+  const liveFunctionsByScript = buildLiveFunctions(snapshot, scan.liveClosures, scan.finishedModuleFunctionNodeIndexes);
 
   // (4) Correlate contexts and their field values with embedded scopes.
   const {scopes, scriptsWithoutScopes} = correlateContextsWithScopes(snapshot, scan, scopesByScript);
@@ -240,6 +249,9 @@ function scanHeap(snapshot: HeapSnapshot): HeapScan {
   const scripts = new Map<ScriptNodeIndex, ScriptInfo>();
   const contextNodes: ContextNodeInfo[] = [];
   const liveClosures: LiveClosure[] = [];
+  const finishedModuleFunctionNodeIndexes = new Set<number>();
+  // Caches for each map whether it belongs to a generator object. See `isGeneratorObject`.
+  const generatorMapNodeIndexes = new Map<MapNodeIndex, boolean>();
   const scopeInfoScriptNodeIndexes = new Map<ScopeInfoNodeIndex, ScriptNodeIndex|undefined>();
   const node = snapshot.createNode();
   const nodes = snapshot.nodes;
@@ -257,10 +269,12 @@ function scanHeap(snapshot: HeapSnapshot): HeapScan {
       processContext(contextNodes, node);
     } else if (node.rawType() === nodeClosureType) {
       processClosure(liveClosures, node);
+    } else if (isGeneratorObject(generatorMapNodeIndexes, node)) {
+      processGeneratorObject(liveClosures, finishedModuleFunctionNodeIndexes, node);
     }
   }
 
-  return {scripts, contextNodes, liveClosures, scopeInfoScriptNodeIndexes};
+  return {scripts, contextNodes, liveClosures, finishedModuleFunctionNodeIndexes, scopeInfoScriptNodeIndexes};
 }
 
 function processScript(scripts: Map<ScriptNodeIndex, ScriptInfo>, node: HeapSnapshotNode): void {
@@ -426,6 +440,11 @@ function processClosure(liveClosures: LiveClosure[], node: HeapSnapshotNode): vo
   if (!sharedFunctionInfo || !closureContext) {
     return;
   }
+  addLiveClosure(liveClosures, node, sharedFunctionInfo, closureContext);
+}
+
+function addLiveClosure(liveClosures: LiveClosure[], ownerNode: HeapSnapshotNode, sharedFunctionInfo: HeapSnapshotNode,
+                        contextNode: HeapSnapshotNode): void {
   const script = sharedFunctionInfo.findInternalEdgeTarget('script');
   if (!script) {
     return;
@@ -433,18 +452,97 @@ function processClosure(liveClosures: LiveClosure[], node: HeapSnapshotNode): vo
   const scopeId = sharedFunctionInfo.findInternalEdgeTarget('scope_id')?.nodeValueAsInt() as ScopeId | undefined;
   if (scopeId !== undefined) {
     liveClosures.push({
-      contextNodeIndex: closureContext.nodeIndex as ContextNodeIndex,
+      ownerNodeIndex: ownerNode.nodeIndex,
+      contextNodeIndex: contextNode.nodeIndex as ContextNodeIndex,
       scriptNodeIndex: script.nodeIndex as ScriptNodeIndex,
       scopeId,
     });
   }
 }
 
-function buildLiveFunctions(snapshot: HeapSnapshot, liveClosures: LiveClosure[]): ByScope<LiveFunction> {
+// V8's `JSGeneratorObject::kGeneratorClosed`: the generator has finished and can't be resumed.
+const GENERATOR_CLOSED = -1;
+
+/**
+ * Handles generator objects, which V8 uses for generators, async functions, async generators and
+ * the top-level code of modules.
+ */
+function processGeneratorObject(liveClosures: LiveClosure[], finishedModuleFunctionNodeIndexes: Set<number>,
+                                node: HeapSnapshotNode): void {
+  const continuation = node.findInternalEdgeTarget('continuation')?.nodeValueAsInt();
+  const generatorFunction = node.findInternalEdgeTarget('function');
+  if (continuation === undefined || generatorFunction?.rawType() !== node.snapshot.nodeClosureType) {
+    return;
+  }
+  const sharedFunctionInfo = generatorFunction.findInternalEdgeTarget('shared');
+  if (!sharedFunctionInfo) {
+    return;
+  }
+  if (continuation === GENERATOR_CLOSED) {
+    const scopeId = sharedFunctionInfo.findInternalEdgeTarget('scope_id')?.nodeValueAsInt();
+
+    // Only the top-level code of a module is both a generator and a root scope.
+    if (scopeId !== undefined && isScriptRootScopeId(scopeId)) {
+      // A module stores a reference to its generator object. The generator object then
+      // references the top-level JSFunction. Once the generator object is finished its
+      // JSFunction can't run anymore and user code can't call it. Here we record such closures
+      // in order to skip them later in buildLiveFunctions().
+      finishedModuleFunctionNodeIndexes.add(generatorFunction.nodeIndex);
+    }
+
+    // A finished generator can't run again, so it doesn't get a LiveClosure. That way the fields
+    // of its context can be reported as dead.
+    return;
+  }
+  const generatorContext = node.findInternalEdgeTarget('context');
+  if (generatorContext) {
+    // The context of the generator's function is the one the function was created in. The body
+    // of the generator, however, runs in a context of its own, which only the generator object
+    // refers to. A generator therefore counts as a closure of its function with the context
+    // it resumes in.
+    addLiveClosure(liveClosures, node, sharedFunctionInfo, generatorContext);
+  }
+}
+
+// V8's instance types of `JSGeneratorObject` and its subclasses.
+const GENERATOR_INSTANCE_TYPE_NAMES = new Set([
+  'JS_GENERATOR_OBJECT_TYPE',
+  'JS_ASYNC_FUNCTION_OBJECT_TYPE',
+  'JS_ASYNC_GENERATOR_OBJECT_TYPE',
+]);
+
+/**
+ * Checks the instance type of the object's map, so that other objects with fields of the same name
+ * aren't mistaken for generator objects. The result is cached for each map.
+ */
+function isGeneratorObject(generatorMapNodeIndexes: Map<MapNodeIndex, boolean>, node: HeapSnapshotNode): boolean {
+  if (node.rawType() !== node.snapshot.nodeObjectType) {
+    return false;
+  }
+  const map = node.findInternalEdgeTarget('map');
+  if (!map) {
+    return false;
+  }
+  const mapNodeIndex = map.nodeIndex as MapNodeIndex;
+  let isGenerator = generatorMapNodeIndexes.get(mapNodeIndex);
+  if (isGenerator === undefined) {
+    const instanceTypeName = map.findInternalEdgeTarget('instance_type_name')?.rawName();
+    isGenerator = instanceTypeName !== undefined && GENERATOR_INSTANCE_TYPE_NAMES.has(instanceTypeName);
+    generatorMapNodeIndexes.set(mapNodeIndex, isGenerator);
+  }
+  return isGenerator;
+}
+
+function buildLiveFunctions(snapshot: HeapSnapshot, liveClosures: LiveClosure[],
+                            finishedModuleFunctionNodeIndexes: Set<number>): ByScope<LiveFunction> {
   const liveFunctionsByScript: ByScope<LiveFunction> = new Map();
   const node = snapshot.createNode();
 
   for (const closure of liveClosures) {
+    if (finishedModuleFunctionNodeIndexes.has(closure.ownerNodeIndex)) {
+      // The top-level code of this module has finished and can't run anymore.
+      continue;
+    }
     let scriptFunctions = liveFunctionsByScript.get(closure.scriptNodeIndex);
     if (!scriptFunctions) {
       scriptFunctions = new Map<ScopeId, LiveFunction>();

package/front_end/generated/InspectorBackendCommands.ts

@@ -663,6 +663,12 @@ inspectorBackend.registerType("FileSystem.File", [{"name": "name", "type": "stri
 inspectorBackend.registerType("FileSystem.Directory", [{"name": "name", "type": "string", "optional": false, "description": "", "typeRef": null}, {"name": "nestedDirectories", "type": "array", "optional": false, "description": "", "typeRef": "string"}, {"name": "nestedFiles", "type": "array", "optional": false, "description": "Files that are directly nested under this directory.", "typeRef": "FileSystem.File"}]);
 inspectorBackend.registerType("FileSystem.BucketFileSystemLocator", [{"name": "storageKey", "type": "string", "optional": false, "description": "Storage key", "typeRef": "Storage.SerializedStorageKey"}, {"name": "bucketName", "type": "string", "optional": true, "description": "Bucket name. Not passing a `bucketName` will retrieve the default Bucket. (https://developer.mozilla.org/en-US/docs/Web/API/Storage_API#storage_buckets)", "typeRef": null}, {"name": "pathComponents", "type": "array", "optional": false, "description": "Path to the directory using each path component as an array item.", "typeRef": "string"}]);
 
+// FindInPage.
+inspectorBackend.registerCommand("FindInPage.findFirst", [{"name": "query", "type": "string", "optional": false, "description": "", "typeRef": null}], [], "Forwards `query` to the find-in-page facility, starting a new find session. Where exactly the search starts from is implementation-specific.");
+inspectorBackend.registerCommand("FindInPage.findNext", [], [], "Moves to the next match for the query passed to the most recent findFirst() call.");
+inspectorBackend.registerCommand("FindInPage.findPrev", [], [], "Moves to the previous match for the query passed to the most recent findFirst() call.");
+inspectorBackend.registerCommand("FindInPage.stop", [], [], "Ends the current find session, if any, and clears its highlighting.");
+
 // HeadlessExperimental.
 inspectorBackend.registerEnum("HeadlessExperimental.ScreenshotParamsFormat", {Jpeg: "jpeg", Png: "png", Webp: "webp"});
 inspectorBackend.registerCommand("HeadlessExperimental.beginFrame", [{"name": "frameTimeTicks", "type": "number", "optional": true, "description": "Timestamp of this BeginFrame in Renderer TimeTicks (milliseconds of uptime). If not set, the current time will be used.", "typeRef": null}, {"name": "interval", "type": "number", "optional": true, "description": "The interval between BeginFrames that is reported to the compositor, in milliseconds. Defaults to a 60 frames/second interval, i.e. about 16.666 milliseconds.", "typeRef": null}, {"name": "noDisplayUpdates", "type": "boolean", "optional": true, "description": "Whether updates should not be committed and drawn onto the display. False by default. If true, only side effects of the BeginFrame will be run, such as layout and animations, but any visual updates may not be visible on the display or in screenshots.", "typeRef": null}, {"name": "screenshot", "type": "object", "optional": true, "description": "If set, a screenshot of the frame will be captured and returned in the response. Otherwise, no screenshot will be captured. Note that capturing a screenshot can fail, for example, during renderer initialization. In such a case, no screenshot data will be returned.", "typeRef": "HeadlessExperimental.ScreenshotParams"}], ["hasDamage", "screenshotData"], "Sends a BeginFrame to the target and returns when the frame was completed. Optionally captures a screenshot from the resulting frame. Requires that the target was created with enabled BeginFrameControl. Designed for use with --run-all-compositor-stages-before-draw, see also https://goo.gle/chrome-headless-rendering for more background.");
@@ -1052,7 +1058,7 @@ inspectorBackend.registerEnum("Page.AdFrameExplanation", {ParentIsAd: "ParentIsA
 inspectorBackend.registerEnum("Page.SecureContextType", {Secure: "Secure", SecureLocalhost: "SecureLocalhost", InsecureScheme: "InsecureScheme", InsecureAncestor: "InsecureAncestor"});
 inspectorBackend.registerEnum("Page.CrossOriginIsolatedContextType", {Isolated: "Isolated", NotIsolated: "NotIsolated", NotIsolatedFeatureDisabled: "NotIsolatedFeatureDisabled"});
 inspectorBackend.registerEnum("Page.GatedAPIFeatures", {SharedArrayBuffers: "SharedArrayBuffers", SharedArrayBuffersTransferAllowed: "SharedArrayBuffersTransferAllowed", PerformanceMeasureMemory: "PerformanceMeasureMemory", PerformanceProfile: "PerformanceProfile"});
-inspectorBackend.registerEnum("Page.PermissionsPolicyFeature", {Accelerometer: "accelerometer", AllScreensCapture: "all-screens-capture", AmbientLightSensor: "ambient-light-sensor", AriaNotify: "aria-notify", Autofill: "autofill", Autoplay: "autoplay", Bluetooth: "bluetooth", BrowsingTopics: "browsing-topics", Camera: "camera", CapturedSurfaceControl: "captured-surface-control", ChDpr: "ch-dpr", ChDeviceMemory: "ch-device-memory", ChDownlink: "ch-downlink", ChEct: "ch-ect", ChPrefersColorScheme: "ch-prefers-color-scheme", ChPrefersReducedMotion: "ch-prefers-reduced-motion", ChPrefersReducedTransparency: "ch-prefers-reduced-transparency", ChRtt: "ch-rtt", ChSaveData: "ch-save-data", ChUa: "ch-ua", ChUaArch: "ch-ua-arch", ChUaBitness: "ch-ua-bitness", ChUaHighEntropyValues: "ch-ua-high-entropy-values", ChUaPlatform: "ch-ua-platform", ChUaModel: "ch-ua-model", ChUaMobile: "ch-ua-mobile", ChUaFormFactors: "ch-ua-form-factors", ChUaFullVersion: "ch-ua-full-version", ChUaFullVersionList: "ch-ua-full-version-list", ChUaPlatformVersion: "ch-ua-platform-version", ChUaWow64: "ch-ua-wow64", ChViewportHeight: "ch-viewport-height", ChViewportWidth: "ch-viewport-width", ChWidth: "ch-width", ClipboardRead: "clipboard-read", ClipboardWrite: "clipboard-write", ComputePressure: "compute-pressure", ControlledFrame: "controlled-frame", CrossOriginIsolated: "cross-origin-isolated", DeferredFetch: "deferred-fetch", DeferredFetchMinimal: "deferred-fetch-minimal", DeviceAttributes: "device-attributes", DigitalCredentialsCreate: "digital-credentials-create", DigitalCredentialsGet: "digital-credentials-get", DirectSockets: "direct-sockets", DirectSocketsMulticast: "direct-sockets-multicast", DisplayCapture: "display-capture", DocumentDomain: "document-domain", EncryptedMedia: "encrypted-media", ExecutionWhileOutOfViewport: "execution-while-out-of-viewport", ExecutionWhileNotRendered: "execution-while-not-rendered", FocusWithoutUserActivation: "focus-without-user-activation", Fullscreen: "fullscreen", Frobulate: "frobulate", Gamepad: "gamepad", Geolocation: "geolocation", Gyroscope: "gyroscope", Haptics: "haptics", Hid: "hid", IdentityCredentialsGet: "identity-credentials-get", IdleDetection: "idle-detection", InterestCohort: "interest-cohort", KeyboardMap: "keyboard-map", LanguageDetector: "language-detector", LanguageModel: "language-model", LocalFonts: "local-fonts", LocalNetwork: "local-network", LocalNetworkAccess: "local-network-access", LoopbackNetwork: "loopback-network", Magnetometer: "magnetometer", ManualText: "manual-text", MediaPlaybackWhileNotVisible: "media-playback-while-not-visible", Microphone: "microphone", Midi: "midi", OnDeviceSpeechRecognition: "on-device-speech-recognition", OtpCredentials: "otp-credentials", Payment: "payment", PictureInPicture: "picture-in-picture", PrivateStateTokenIssuance: "private-state-token-issuance", PrivateStateTokenRedemption: "private-state-token-redemption", PublickeyCredentialsCreate: "publickey-credentials-create", PublickeyCredentialsGet: "publickey-credentials-get", Rewriter: "rewriter", ScreenWakeLock: "screen-wake-lock", Serial: "serial", SharedStorage: "shared-storage", SharedStorageSelectUrl: "shared-storage-select-url", SmartCard: "smart-card", SpeakerSelection: "speaker-selection", StorageAccess: "storage-access", SubApps: "sub-apps", Summarizer: "summarizer", SyncXhr: "sync-xhr", Tools: "tools", Translator: "translator", Unload: "unload", Usb: "usb", UsbUnrestricted: "usb-unrestricted", VerticalScroll: "vertical-scroll", WebAppInstallation: "web-app-installation", Webnn: "webnn", WebPrinting: "web-printing", WebShare: "web-share", WindowManagement: "window-management", Writer: "writer", XrSpatialTracking: "xr-spatial-tracking"});
+inspectorBackend.registerEnum("Page.PermissionsPolicyFeature", {Accelerometer: "accelerometer", AllScreensCapture: "all-screens-capture", AmbientLightSensor: "ambient-light-sensor", AriaNotify: "aria-notify", Autofill: "autofill", Autoplay: "autoplay", Bluetooth: "bluetooth", BrowsingTopics: "browsing-topics", Camera: "camera", CapturedSurfaceControl: "captured-surface-control", ChDpr: "ch-dpr", ChDeviceMemory: "ch-device-memory", ChDownlink: "ch-downlink", ChEct: "ch-ect", ChPrefersColorScheme: "ch-prefers-color-scheme", ChPrefersReducedMotion: "ch-prefers-reduced-motion", ChPrefersReducedTransparency: "ch-prefers-reduced-transparency", ChRtt: "ch-rtt", ChSaveData: "ch-save-data", ChUa: "ch-ua", ChUaArch: "ch-ua-arch", ChUaBitness: "ch-ua-bitness", ChUaHighEntropyValues: "ch-ua-high-entropy-values", ChUaPlatform: "ch-ua-platform", ChUaModel: "ch-ua-model", ChUaMobile: "ch-ua-mobile", ChUaFormFactors: "ch-ua-form-factors", ChUaFullVersion: "ch-ua-full-version", ChUaFullVersionList: "ch-ua-full-version-list", ChUaPlatformVersion: "ch-ua-platform-version", ChUaWow64: "ch-ua-wow64", ChViewportHeight: "ch-viewport-height", ChViewportWidth: "ch-viewport-width", ChWidth: "ch-width", ClipboardRead: "clipboard-read", ClipboardWrite: "clipboard-write", ComputePressure: "compute-pressure", ControlledFrame: "controlled-frame", CrossOriginIsolated: "cross-origin-isolated", DeferredFetch: "deferred-fetch", DeferredFetchMinimal: "deferred-fetch-minimal", DeviceAttributes: "device-attributes", DigitalCredentialsCreate: "digital-credentials-create", DigitalCredentialsGet: "digital-credentials-get", DirectSockets: "direct-sockets", DirectSocketsMulticast: "direct-sockets-multicast", DisplayCapture: "display-capture", DocumentDomain: "document-domain", EncryptedMedia: "encrypted-media", ExecutionWhileOutOfViewport: "execution-while-out-of-viewport", ExecutionWhileNotRendered: "execution-while-not-rendered", FocusWithoutUserActivation: "focus-without-user-activation", Fullscreen: "fullscreen", Frobulate: "frobulate", Gamepad: "gamepad", Geolocation: "geolocation", Gyroscope: "gyroscope", Haptics: "haptics", Hid: "hid", IdentityCredentialsGet: "identity-credentials-get", IdleDetection: "idle-detection", InterestCohort: "interest-cohort", KeyboardMap: "keyboard-map", LanguageDetector: "language-detector", LanguageModel: "language-model", LocalFonts: "local-fonts", LocalNetwork: "local-network", LocalNetworkAccess: "local-network-access", LoopbackNetwork: "loopback-network", Magnetometer: "magnetometer", ManualText: "manual-text", MediaPlaybackWhileNotVisible: "media-playback-while-not-visible", Microphone: "microphone", Midi: "midi", OnDeviceSpeechRecognition: "on-device-speech-recognition", OtpCredentials: "otp-credentials", Payment: "payment", PictureInPicture: "picture-in-picture", PrivateStateTokenIssuance: "private-state-token-issuance", PrivateStateTokenRedemption: "private-state-token-redemption", PublickeyCredentialsCreate: "publickey-credentials-create", PublickeyCredentialsGet: "publickey-credentials-get", PublickeyCredentialsRemoteClientDataJson: "publickey-credentials-remote-client-data-json", Rewriter: "rewriter", ScreenWakeLock: "screen-wake-lock", Serial: "serial", SharedStorage: "shared-storage", SharedStorageSelectUrl: "shared-storage-select-url", SmartCard: "smart-card", SpeakerSelection: "speaker-selection", StorageAccess: "storage-access", SubApps: "sub-apps", Summarizer: "summarizer", SyncXhr: "sync-xhr", Tools: "tools", Translator: "translator", Unload: "unload", Usb: "usb", UsbUnrestricted: "usb-unrestricted", VerticalScroll: "vertical-scroll", WebAppInstallation: "web-app-installation", Webnn: "webnn", WebPrinting: "web-printing", WebShare: "web-share", WindowManagement: "window-management", Writer: "writer", XrSpatialTracking: "xr-spatial-tracking"});
 inspectorBackend.registerEnum("Page.PermissionsPolicyBlockReason", {Header: "Header", IframeAttribute: "IframeAttribute", InFencedFrameTree: "InFencedFrameTree", InIsolatedApp: "InIsolatedApp"});
 inspectorBackend.registerEnum("Page.OriginTrialTokenStatus", {Success: "Success", NotSupported: "NotSupported", Insecure: "Insecure", Expired: "Expired", WrongOrigin: "WrongOrigin", InvalidSignature: "InvalidSignature", Malformed: "Malformed", WrongVersion: "WrongVersion", FeatureDisabled: "FeatureDisabled", TokenDisabled: "TokenDisabled", FeatureDisabledForUser: "FeatureDisabledForUser", UnknownTrial: "UnknownTrial"});
 inspectorBackend.registerEnum("Page.OriginTrialStatus", {Enabled: "Enabled", ValidTokenNotProvided: "ValidTokenNotProvided", OSNotSupported: "OSNotSupported", TrialNotAllowed: "TrialNotAllowed"});

package/front_end/generated/SupportedCSSProperties.ts

@@ -4603,8 +4603,16 @@ export const generatedProperties: CSSProperty[] = [
   "name": "position-try-order"
  },
  {
+  "devtools_keywords": [
+   "always",
+   "anchor-valid",
+   "anchor-visible",
+   "no-overflow"
+  ],
   "keywords": [
    "always",
+   "anchor-valid",
+   "anchor-visible",
    "anchors-visible",
    "no-overflow"
   ],
@@ -5482,7 +5490,7 @@ export const generatedProperties: CSSProperty[] = [
   ],
   "name": "text-decoration-inset",
   "runtime_flag": "CSSTextDecorationInset",
-  "runtime_flag_status": "experimental"
+  "runtime_flag_status": "stable"
  },
  {
   "keywords": [
@@ -8484,7 +8492,8 @@ export const generatedPropertyValues: Record<string, CSSPropertyValue> = {
  "position-visibility": {
   "values": [
    "always",
-   "anchors-visible",
+   "anchor-valid",
+   "anchor-visible",
    "no-overflow"
   ]
  },

package/front_end/generated/protocol-mapping.d.ts

@@ -3082,6 +3082,37 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.FileSystem.GetDirectoryRequest];
       returnType: Protocol.FileSystem.GetDirectoryResponse;
     };
+    /**
+     * Forwards `query` to the find-in-page facility, starting a new find session.
+     * Where exactly the search starts from is implementation-specific.
+     */
+    'FindInPage.findFirst': {
+      paramsType: [Protocol.FindInPage.FindFirstRequest];
+      returnType: void;
+    };
+    /**
+     * Moves to the next match for the query passed to the most recent
+     * findFirst() call.
+     */
+    'FindInPage.findNext': {
+      paramsType: [];
+      returnType: void;
+    };
+    /**
+     * Moves to the previous match for the query passed to the most recent
+     * findFirst() call.
+     */
+    'FindInPage.findPrev': {
+      paramsType: [];
+      returnType: void;
+    };
+    /**
+     * Ends the current find session, if any, and clears its highlighting.
+     */
+    'FindInPage.stop': {
+      paramsType: [];
+      returnType: void;
+    };
     /**
      * Sends a BeginFrame to the target and returns when the frame was completed. Optionally captures a
      * screenshot from the resulting frame. Requires that the target was created with enabled

package/front_end/generated/protocol-proxy-api.d.ts

@@ -68,6 +68,8 @@ declare namespace ProtocolProxyApi {
 
     FileSystem: FileSystemApi;
 
+    FindInPage: FindInPageApi;
+
     HeadlessExperimental: HeadlessExperimentalApi;
 
     IO: IOApi;
@@ -185,6 +187,8 @@ declare namespace ProtocolProxyApi {
 
     FileSystem: FileSystemDispatcher;
 
+    FindInPage: FindInPageDispatcher;
+
     HeadlessExperimental: HeadlessExperimentalDispatcher;
 
     IO: IODispatcher;
@@ -2181,6 +2185,34 @@ declare namespace ProtocolProxyApi {
   export interface FileSystemDispatcher {
   }
 
+  export interface FindInPageApi {
+    /**
+     * Forwards `query` to the find-in-page facility, starting a new find session.
+     * Where exactly the search starts from is implementation-specific.
+     */
+    invoke_findFirst(params: Protocol.FindInPage.FindFirstRequest): Promise<Protocol.ProtocolResponseWithError>;
+
+    /**
+     * Moves to the next match for the query passed to the most recent
+     * findFirst() call.
+     */
+    invoke_findNext(): Promise<Protocol.ProtocolResponseWithError>;
+
+    /**
+     * Moves to the previous match for the query passed to the most recent
+     * findFirst() call.
+     */
+    invoke_findPrev(): Promise<Protocol.ProtocolResponseWithError>;
+
+    /**
+     * Ends the current find session, if any, and clears its highlighting.
+     */
+    invoke_stop(): Promise<Protocol.ProtocolResponseWithError>;
+
+  }
+  export interface FindInPageDispatcher {
+  }
+
   export interface HeadlessExperimentalApi {
     /**
      * Sends a BeginFrame to the target and returns when the frame was completed. Optionally captures a

package/front_end/generated/protocol.ts

@@ -8702,6 +8702,16 @@ export namespace FileSystem {
   }
 }
 
+/**
+ * This domain provides commands to trigger the "Find in page" feature.
+ */
+export namespace FindInPage {
+
+  export interface FindFirstRequest {
+    query: string;
+  }
+}
+
 /**
  * This domain provides experimental commands only supported in headless mode.
  */
@@ -14808,6 +14818,7 @@ export namespace Page {
     PrivateStateTokenRedemption = 'private-state-token-redemption',
     PublickeyCredentialsCreate = 'publickey-credentials-create',
     PublickeyCredentialsGet = 'publickey-credentials-get',
+    PublickeyCredentialsRemoteClientDataJson = 'publickey-credentials-remote-client-data-json',
     Rewriter = 'rewriter',
     ScreenWakeLock = 'screen-wake-lock',
     Serial = 'serial',

package/front_end/models/ai_assistance/AiAgent2.ts

@@ -41,6 +41,7 @@ const SKILL_DISPLAY_NAMES: Record<SkillName, string> = {
   performance: 'Performance',
   storage: 'Storage',
   sources: 'Sources',
+  lighthouse: 'Lighthouse',
 };
 
 const preamble = `You are the most advanced unified AI assistant integrated into Chrome DevTools.

package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts

@@ -6,6 +6,12 @@ import type * as LHModel from '../../lighthouse/lighthouse.js';
 
 import {bytes, millis} from './UnitFormatters.js';
 
+/**
+ * Category argument for Lighthouse tools, accepting a specific category ID or `'all'`
+ * to target a full report across all standard categories.
+ */
+export type LighthouseCategoryArg = 'all'|LHModel.RunTypes.CategoryId;
+
 /**
  * A formatter that takes a raw Lighthouse report JSON and creates a markdown
  * summary for an AI Agent.
@@ -29,14 +35,31 @@ export class LighthouseFormatter {
     return lines.join('\n');
   }
 
+  /**
+   * Formats a Lighthouse report for an AI Agent. If categoryId is 'all', includes
+   * the overall summary followed by each category's audits. Otherwise, returns audits
+   * for the specified category.
+   */
+  formatReport(report: LHModel.ReporterTypes.ReportJSON, categoryId: LighthouseCategoryArg): string {
+    if (categoryId === 'all') {
+      const sections: string[] = [this.summary(report)];
+      for (const category of Object.values(report.categories)) {
+        sections.push(this.audits(report, category));
+      }
+      return sections.join('\n\n');
+    }
+    return this.audits(report, categoryId);
+  }
+
   /**
    * Returns a markdown list of all audits in a given category.
    * Highlight failing audits (score < 90).
    */
-  audits(report: LHModel.ReporterTypes.ReportJSON, categoryId: LHModel.RunTypes.CategoryId): string {
-    const category = report.categories[categoryId];
+  audits(report: LHModel.ReporterTypes.ReportJSON,
+         categoryOrId: LHModel.RunTypes.CategoryId|LHModel.ReporterTypes.CategoryJSON): string {
+    const category = typeof categoryOrId === 'string' ? report.categories[categoryOrId] : categoryOrId;
     if (!category) {
-      return `Category "${categoryId}" not found.`;
+      return `Category "${categoryOrId}" not found.`;
     }
 
     const lines: string[] = [];

package/front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.ts

@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import type * as Platform from '../../../core/platform/platform.js';
 import * as SDK from '../../../core/sdk/sdk.js';
 import * as TextUtils from '../../../core/text_utils/text_utils.js';
 import * as Protocol from '../../../generated/protocol.js';
@@ -122,14 +121,19 @@ export class NetworkRequestFormatter {
     return `${title}\n<binary data>`;
   }
 
+  /**
+   * Returns the URL of `initiator` if it is same-origin with `request`, or a redaction
+   * placeholder otherwise.
+   *
+   * Both sides use `requestURLSecurityOrigin()`, so imported HAR requests are compared
+   * using their `imported-har://` origins.
+   */
   static formatInitiatorUrl(
-      initiatorUrl: Platform.DevToolsPath.UrlString,
-      allowedOrigin: Platform.DevToolsPath.UrlString,
+      initiator: SDK.NetworkRequest.NetworkRequest,
+      request: SDK.NetworkRequest.NetworkRequest,
       ): string {
-    const initiatorOrigin = SDK.SecurityOrigin.SecurityOrigin.create(initiatorUrl);
-    const targetOrigin = SDK.SecurityOrigin.SecurityOrigin.create(allowedOrigin);
-    if (initiatorOrigin.isSameOriginWith(targetOrigin)) {
-      return initiatorUrl;
+    if (initiator.requestURLSecurityOrigin().isSameOriginWith(request.requestURLSecurityOrigin())) {
+      return initiator.url();
     }
     return '<redacted cross-origin initiator URL>';
   }
@@ -329,18 +333,15 @@ export function formatRequestInitiatorChain(
     request: SDK.NetworkRequest.NetworkRequest,
     networkLog: Logs.NetworkLog.NetworkLog,
     ): string {
-  const allowedOrigin = request.url();
   let initiatorChain = '';
   let lineStart = '- URL: ';
   const graph = networkLog.initiatorGraphForRequest(request);
 
   for (const initiator of Array.from(graph.initiators).reverse()) {
-    initiatorChain =
-        initiatorChain + lineStart + NetworkRequestFormatter.formatInitiatorUrl(initiator.url(), allowedOrigin) + '\n';
+    initiatorChain = initiatorChain + lineStart + NetworkRequestFormatter.formatInitiatorUrl(initiator, request) + '\n';
     lineStart = '\t' + lineStart;
     if (initiator === request) {
-      initiatorChain =
-          formatRequestInitiated(graph.initiated, request, request, initiatorChain, lineStart, allowedOrigin);
+      initiatorChain = formatRequestInitiated(graph.initiated, request, request, initiatorChain, lineStart);
     }
   }
 
@@ -353,7 +354,6 @@ function formatRequestInitiated(
     parentRequest: SDK.NetworkRequest.NetworkRequest,
     initiatorChain: string,
     lineStart: string,
-    allowedOrigin: Platform.DevToolsPath.UrlString,
     ): string {
   const visited = new Set<SDK.NetworkRequest.NetworkRequest>();
 
@@ -363,10 +363,9 @@ function formatRequestInitiated(
     if (initiatedRequest === parentRequest) {
       if (!visited.has(keyRequest)) {
         visited.add(keyRequest);
-        initiatorChain = initiatorChain + lineStart +
-            NetworkRequestFormatter.formatInitiatorUrl(keyRequest.url(), allowedOrigin) + '\n';
         initiatorChain =
-            formatRequestInitiated(initiated, rootRequest, keyRequest, initiatorChain, '\t' + lineStart, allowedOrigin);
+            initiatorChain + lineStart + NetworkRequestFormatter.formatInitiatorUrl(keyRequest, rootRequest) + '\n';
+        initiatorChain = formatRequestInitiated(initiated, rootRequest, keyRequest, initiatorChain, '\t' + lineStart);
       }
     }
   }

package/front_end/models/ai_assistance/skills/Skill.ts

@@ -2,8 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// This will become a union type as we add more skills (e.g. 'styling' | 'network').
-export type SkillName = 'styling'|'network'|'accessibility'|'performance'|'storage'|'sources';
+export type SkillName = 'styling'|'network'|'accessibility'|'performance'|'storage'|'sources'|'lighthouse';
 
 export interface Skill {
   name: SkillName;

package/front_end/models/ai_assistance/skills/SkillRegistry.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import {skill as accessibilitySkill} from './accessibility.skill.js';
+import {skill as lighthouseSkill} from './lighthouse.skill.js';
 import {skill as networkSkill} from './network.skill.js';
 import {skill as performanceSkill} from './performance.skill.js';
 import type {Skill, SkillName} from './Skill.js';
@@ -17,4 +18,5 @@ export const SKILLS: Record<SkillName, Skill> = {
   performance: performanceSkill,
   storage: storageSkill,
   sources: sourcesSkill,
+  lighthouse: lighthouseSkill,
 };

package/front_end/models/ai_assistance/skills/lighthouse.md

@@ -0,0 +1,33 @@
+---
+name: lighthouse
+description: Running Lighthouse reports and audits, full-page audits (performance, accessibility, best practices, Search Engine Optimization (SEO)), and inspecting Lighthouse scores.
+allowed-tools:
+  - runLighthouse
+  - getLighthouseAudits
+  - resolveDevtoolsNodePath
+---
+You are an expert web quality and audit assistant integrated into Chrome DevTools.
+Your role is to evaluate websites using Lighthouse audits across performance, accessibility, best practices, and SEO.
+
+# Tools & Workflow
+
+1. **Lighthouse Audits (`runLighthouse` & `getLighthouseAudits`)**:
+   - If an active Lighthouse report context already exists and no fresh audit is requested:
+     - To inspect the entire report or multiple categories, call `getLighthouseAudits` with `categoryId: 'all'`.
+     - For a specific category, call `getLighthouseAudits` with the corresponding category ID (e.g. `'performance'`, `'accessibility'`, `'best-practices'`, `'seo'`).
+   - If no active report exists or a fresh audit is requested, call `runLighthouse`:
+     - If the user asks for a general report or multiple categories, use `categoryId: 'all'`.
+     - For a single category, pass that category ID.
+     - Execution mode:
+       - Use `"navigation"` mode for full page-load audits (default for full site reviews).
+       - Use `"snapshot"` mode to re-evaluate live in-page DOM/CSS modifications without reloading.
+       - Use `"timespan"` mode for user interaction flows.
+       - Always honor explicit mode requests from the user.
+
+2. **Resolving Node References (`resolveDevtoolsNodePath`)**:
+   - When an audit references failing elements by DevTools node path (e.g. `"1,HTML,1,BODY,2,BUTTON"`), use `resolveDevtoolsNodePath` to resolve the path to a `backendNodeId` to identify the failing element (or inspect it using tools from other skills if active).
+
+# Considerations
+
+- Base all analysis on empirical Lighthouse audit data. Never fabricate audit scores or results.
+- When summarizing a full Lighthouse run, highlight overall category scores first, then detail failing audits (score < 90).

package/front_end/models/ai_assistance/tools/GetLighthouseAudits.ts

@@ -3,8 +3,7 @@
 // found in the LICENSE file.
 
 import * as Host from '../../../core/host/host.js';
-import type * as LHModel from '../../lighthouse/lighthouse.js';
-import {LighthouseFormatter} from '../data_formatters/LighthouseFormatter.js';
+import {type LighthouseCategoryArg, LighthouseFormatter} from '../data_formatters/LighthouseFormatter.js';
 
 import {
   type BaseToolCapability,
@@ -16,14 +15,14 @@ import {
 } from './Tool.js';
 
 export interface GetLighthouseAuditsArgs extends ToolArgs {
-  categoryId: LHModel.RunTypes.CategoryId;
+  categoryId: LighthouseCategoryArg;
 }
 
 export class GetLighthouseAuditsTool implements
     DataTool<GetLighthouseAuditsArgs, {audits: string}, BaseToolCapability&LighthouseReportCapability> {
   readonly name: ToolName = ToolName.GET_LIGHTHOUSE_AUDITS;
   readonly description: string =
-      'Retrieves audit results and diagnostic details from the active Lighthouse report for a specific category (e.g., \'accessibility\').';
+      'Retrieves audit results and diagnostic details from the active Lighthouse report for all categories (using categoryId: "all") or a specific category (e.g., \'accessibility\').';
 
   readonly parameters: Host.AidaClient.FunctionObjectParam<keyof GetLighthouseAuditsArgs> = {
     type: Host.AidaClient.ParametersTypes.OBJECT,
@@ -32,7 +31,8 @@ export class GetLighthouseAuditsTool implements
     properties: {
       categoryId: {
         type: Host.AidaClient.ParametersTypes.STRING,
-        description: 'The category of audits to retrieve. E.g. "accessibility".',
+        description:
+            'The category of audits to retrieve. Use "all" to retrieve the full report and all categories, or specify a category: "accessibility", "performance", "best-practices", "seo".',
         nullable: false,
       },
     },
@@ -52,7 +52,7 @@ export class GetLighthouseAuditsTool implements
     if (!report) {
       return {error: 'Error: Active context is not a Lighthouse report.'};
     }
-    const audits = new LighthouseFormatter().audits(report, params.categoryId);
+    const audits = new LighthouseFormatter().formatReport(report, params.categoryId);
     return {
       result: {audits},
       widgets: [{name: 'LIGHTHOUSE_REPORT', data: {report}}],