chrome-devtools-frontend 1.0.1701636 → 1.0.1702515

package/eslint.config.mjs

@@ -59,6 +59,7 @@ export default defineConfig([
     'scripts/migration/**/*.js',
     'scripts/protocol_typescript/*.js',
     'scripts/deps/tests/fixtures',
+    'scripts/gn_deps_verifier/tests/fixtures',
     'test/**/fixtures/',
     'test/e2e/**/*.js',
     'test/shared/**/*.js',
@@ -740,7 +741,8 @@ export default defineConfig([
       'front_end/**/*.docs.ts',
       'test/**/*.ts',
       '**/testing/*.ts',
-      'scripts/eslint_rules/test/**/*',
+      'scripts/eslint_rules/tests/**/*',
+      'scripts/gn_deps_verifier/tests/**/*',
       'extensions/cxx_debugging/e2e/**/*.ts',
       'extensions/cxx_debugging/tests/**/*.ts',
     ],

package/front_end/core/host/UserMetricsEnums.ts

@@ -498,10 +498,11 @@ export enum DevtoolsExperiments {
   'durable-messages' = 110,
   'jpeg-xl' = 111,
   'plus-button' = 112,
+  'source-map-scopes-in-sources-panel' = 113,
   /* eslint-enable @typescript-eslint/naming-convention */
 
   // Increment this when new experiments are added.
-  MAX_VALUE = 113,
+  MAX_VALUE = 114,
 }
 
 /** Update DevToolsIssuesPanelIssueExpanded from tools/metrics/histograms/enums.xml if new enum is added. **/

package/front_end/core/root/ExperimentNames.ts

@@ -9,6 +9,7 @@ export enum ExperimentName {
   DURABLE_MESSAGES = 'durable-messages',
   JPEG_XL = 'jpeg-xl',
   PLUS_BUTTON = 'plus-button',
+  SOURCE_MAP_SCOPES_IN_SOURCES_PANEL = 'source-map-scopes-in-sources-panel',
   // Adding or removing an entry from this enum?
   // You will need to update:
   // 1. DevToolsExperiments enum in host/UserMetrics.ts

package/front_end/core/sdk/CSSPropertyParserMatchers.ts

@@ -56,13 +56,8 @@ export class BaseVariableMatch implements Match {
   }
 }
 
-// TODO(b/533783988): Remove ValueName handling once https://code.haverbeke.berlin/lezer/css/issues/36 is fixed and rolled.
 function isVariableNameNode(node: CodeMirror.SyntaxNode|null|undefined, ast: SyntaxTree): boolean {
-  if (node?.name !== 'VariableName' && node?.name !== 'ValueName') {
-    return false;
-  }
-  const text = ast.text(node);
-  return text.length > 2 && text.startsWith('--');
+  return node?.name === 'VariableName' && ast.text(node).length > 2;
 }
 
 const BaseVariableMatcherBase: MatcherClass<BaseVariableMatch> = matcherBase(BaseVariableMatch);
@@ -1122,7 +1117,7 @@ export class CustomFunctionMatcher extends CustomFunctionMatcherBase {
     if (node.name !== 'CallExpression') {
       return null;
     }
-    const callee = matching.ast.text(node.getChild('VariableName') ?? node.getChild('Callee'));
+    const callee = matching.ast.text(node.getChild('VariableName'));
     if (!callee || callee.length <= 2 || !callee.startsWith('--')) {
       return null;
     }

package/front_end/devtools_compatibility.js

@@ -876,7 +876,8 @@
       'durable-messages': 110,
       'jpeg-xl': 111,
       'plus-button': 112,
-      MAX_VALUE: 113,
+      'source-map-scopes-in-sources-panel': 113,
+      MAX_VALUE: 114,
     },
     IssueExpanded: {
       CrossOriginEmbedderPolicy: 0,

package/front_end/entrypoints/main/MainImpl.ts

@@ -415,6 +415,14 @@ export class MainImpl {
       requiresChromeRestart: false,
     });
 
+    Root.Runtime.experiments.register({
+      name: Root.ExperimentNames.ExperimentName.SOURCE_MAP_SCOPES_IN_SOURCES_PANEL,
+      title: 'Source map scopes in the Sources panel',
+      aboutFlag: 'devtools-source-map-scopes-in-sources-panel',
+      isEnabled: Root.Runtime.hostConfig.devToolsSourceMapScopesInSourcesPanel?.enabled ?? false,
+      requiresChromeRestart: false,
+    });
+
     for (const experiment of Root.Runtime.experiments.allConfigurableExperiments()) {
       if (experiment.isEnabled()) {
         Host.userMetrics.experimentEnabledAtLaunch(experiment.name);

package/front_end/generated/InspectorBackendCommands.ts

@@ -73,7 +73,7 @@ inspectorBackend.registerType("Animation.KeyframesRule", [{"name": "name", "type
 inspectorBackend.registerType("Animation.KeyframeStyle", [{"name": "offset", "type": "string", "optional": false, "description": "Keyframe's time offset.", "typeRef": null}, {"name": "easing", "type": "string", "optional": false, "description": "`AnimationEffect`'s timing function.", "typeRef": null}]);
 
 // Audits.
-inspectorBackend.registerEnum("Audits.CookieExclusionReason", {ExcludeSameSiteUnspecifiedTreatedAsLax: "ExcludeSameSiteUnspecifiedTreatedAsLax", ExcludeSameSiteNoneInsecure: "ExcludeSameSiteNoneInsecure", ExcludeSameSiteLax: "ExcludeSameSiteLax", ExcludeSameSiteStrict: "ExcludeSameSiteStrict", ExcludeDomainNonASCII: "ExcludeDomainNonASCII", ExcludeThirdPartyCookieBlockedInFirstPartySet: "ExcludeThirdPartyCookieBlockedInFirstPartySet", ExcludeThirdPartyPhaseout: "ExcludeThirdPartyPhaseout", ExcludePortMismatch: "ExcludePortMismatch", ExcludeSchemeMismatch: "ExcludeSchemeMismatch"});
+inspectorBackend.registerEnum("Audits.CookieExclusionReason", {ExcludeSameSiteUnspecifiedTreatedAsLax: "ExcludeSameSiteUnspecifiedTreatedAsLax", ExcludeSameSiteNoneInsecure: "ExcludeSameSiteNoneInsecure", ExcludeSameSiteLax: "ExcludeSameSiteLax", ExcludeSameSiteStrict: "ExcludeSameSiteStrict", ExcludeDomainNonASCII: "ExcludeDomainNonASCII", ExcludeThirdPartyPhaseout: "ExcludeThirdPartyPhaseout", ExcludePortMismatch: "ExcludePortMismatch", ExcludeSchemeMismatch: "ExcludeSchemeMismatch"});
 inspectorBackend.registerEnum("Audits.CookieWarningReason", {WarnSameSiteUnspecifiedCrossSiteContext: "WarnSameSiteUnspecifiedCrossSiteContext", WarnSameSiteNoneInsecure: "WarnSameSiteNoneInsecure", WarnSameSiteUnspecifiedLaxAllowUnsafe: "WarnSameSiteUnspecifiedLaxAllowUnsafe", WarnSameSiteStrictLaxDowngradeStrict: "WarnSameSiteStrictLaxDowngradeStrict", WarnSameSiteStrictCrossDowngradeStrict: "WarnSameSiteStrictCrossDowngradeStrict", WarnSameSiteStrictCrossDowngradeLax: "WarnSameSiteStrictCrossDowngradeLax", WarnSameSiteLaxCrossDowngradeStrict: "WarnSameSiteLaxCrossDowngradeStrict", WarnSameSiteLaxCrossDowngradeLax: "WarnSameSiteLaxCrossDowngradeLax", WarnAttributeValueExceedsMaxSize: "WarnAttributeValueExceedsMaxSize", WarnDomainNonASCII: "WarnDomainNonASCII", WarnThirdPartyPhaseout: "WarnThirdPartyPhaseout", WarnCrossSiteRedirectDowngradeChangesInclusion: "WarnCrossSiteRedirectDowngradeChangesInclusion", WarnDeprecationTrialMetadata: "WarnDeprecationTrialMetadata", WarnThirdPartyCookieHeuristic: "WarnThirdPartyCookieHeuristic"});
 inspectorBackend.registerEnum("Audits.CookieOperation", {SetCookie: "SetCookie", ReadCookie: "ReadCookie"});
 inspectorBackend.registerEnum("Audits.InsightType", {GitHubResource: "GitHubResource", GracePeriod: "GracePeriod", Heuristics: "Heuristics"});
@@ -815,8 +815,8 @@ inspectorBackend.registerEnum("Network.TrustTokenOperationType", {Issuance: "Iss
 inspectorBackend.registerEnum("Network.AlternateProtocolUsage", {AlternativeJobWonWithoutRace: "alternativeJobWonWithoutRace", AlternativeJobWonRace: "alternativeJobWonRace", MainJobWonRace: "mainJobWonRace", MappingMissing: "mappingMissing", Broken: "broken", DnsAlpnH3JobWonWithoutRace: "dnsAlpnH3JobWonWithoutRace", DnsAlpnH3JobWonRace: "dnsAlpnH3JobWonRace", UnspecifiedReason: "unspecifiedReason"});
 inspectorBackend.registerEnum("Network.ServiceWorkerRouterSource", {Network: "network", Cache: "cache", FetchEvent: "fetch-event", RaceNetworkAndFetchHandler: "race-network-and-fetch-handler", RaceNetworkAndCache: "race-network-and-cache"});
 inspectorBackend.registerEnum("Network.InitiatorType", {Parser: "parser", Script: "script", Preload: "preload", SignedExchange: "SignedExchange", Preflight: "preflight", FedCM: "FedCM", Other: "other"});
-inspectorBackend.registerEnum("Network.SetCookieBlockedReason", {SecureOnly: "SecureOnly", SameSiteStrict: "SameSiteStrict", SameSiteLax: "SameSiteLax", SameSiteUnspecifiedTreatedAsLax: "SameSiteUnspecifiedTreatedAsLax", SameSiteNoneInsecure: "SameSiteNoneInsecure", UserPreferences: "UserPreferences", ThirdPartyPhaseout: "ThirdPartyPhaseout", ThirdPartyBlockedInFirstPartySet: "ThirdPartyBlockedInFirstPartySet", SyntaxError: "SyntaxError", SchemeNotSupported: "SchemeNotSupported", OverwriteSecure: "OverwriteSecure", InvalidDomain: "InvalidDomain", InvalidPrefix: "InvalidPrefix", UnknownError: "UnknownError", SchemefulSameSiteStrict: "SchemefulSameSiteStrict", SchemefulSameSiteLax: "SchemefulSameSiteLax", SchemefulSameSiteUnspecifiedTreatedAsLax: "SchemefulSameSiteUnspecifiedTreatedAsLax", NameValuePairExceedsMaxSize: "NameValuePairExceedsMaxSize", DisallowedCharacter: "DisallowedCharacter", NoCookieContent: "NoCookieContent"});
-inspectorBackend.registerEnum("Network.CookieBlockedReason", {SecureOnly: "SecureOnly", NotOnPath: "NotOnPath", DomainMismatch: "DomainMismatch", SameSiteStrict: "SameSiteStrict", SameSiteLax: "SameSiteLax", SameSiteUnspecifiedTreatedAsLax: "SameSiteUnspecifiedTreatedAsLax", SameSiteNoneInsecure: "SameSiteNoneInsecure", UserPreferences: "UserPreferences", ThirdPartyPhaseout: "ThirdPartyPhaseout", ThirdPartyBlockedInFirstPartySet: "ThirdPartyBlockedInFirstPartySet", UnknownError: "UnknownError", SchemefulSameSiteStrict: "SchemefulSameSiteStrict", SchemefulSameSiteLax: "SchemefulSameSiteLax", SchemefulSameSiteUnspecifiedTreatedAsLax: "SchemefulSameSiteUnspecifiedTreatedAsLax", NameValuePairExceedsMaxSize: "NameValuePairExceedsMaxSize", PortMismatch: "PortMismatch", SchemeMismatch: "SchemeMismatch", AnonymousContext: "AnonymousContext"});
+inspectorBackend.registerEnum("Network.SetCookieBlockedReason", {SecureOnly: "SecureOnly", SameSiteStrict: "SameSiteStrict", SameSiteLax: "SameSiteLax", SameSiteUnspecifiedTreatedAsLax: "SameSiteUnspecifiedTreatedAsLax", SameSiteNoneInsecure: "SameSiteNoneInsecure", UserPreferences: "UserPreferences", ThirdPartyPhaseout: "ThirdPartyPhaseout", SyntaxError: "SyntaxError", SchemeNotSupported: "SchemeNotSupported", OverwriteSecure: "OverwriteSecure", InvalidDomain: "InvalidDomain", InvalidPrefix: "InvalidPrefix", UnknownError: "UnknownError", SchemefulSameSiteStrict: "SchemefulSameSiteStrict", SchemefulSameSiteLax: "SchemefulSameSiteLax", SchemefulSameSiteUnspecifiedTreatedAsLax: "SchemefulSameSiteUnspecifiedTreatedAsLax", NameValuePairExceedsMaxSize: "NameValuePairExceedsMaxSize", DisallowedCharacter: "DisallowedCharacter", NoCookieContent: "NoCookieContent"});
+inspectorBackend.registerEnum("Network.CookieBlockedReason", {SecureOnly: "SecureOnly", NotOnPath: "NotOnPath", DomainMismatch: "DomainMismatch", SameSiteStrict: "SameSiteStrict", SameSiteLax: "SameSiteLax", SameSiteUnspecifiedTreatedAsLax: "SameSiteUnspecifiedTreatedAsLax", SameSiteNoneInsecure: "SameSiteNoneInsecure", UserPreferences: "UserPreferences", ThirdPartyPhaseout: "ThirdPartyPhaseout", UnknownError: "UnknownError", SchemefulSameSiteStrict: "SchemefulSameSiteStrict", SchemefulSameSiteLax: "SchemefulSameSiteLax", SchemefulSameSiteUnspecifiedTreatedAsLax: "SchemefulSameSiteUnspecifiedTreatedAsLax", NameValuePairExceedsMaxSize: "NameValuePairExceedsMaxSize", PortMismatch: "PortMismatch", SchemeMismatch: "SchemeMismatch", AnonymousContext: "AnonymousContext"});
 inspectorBackend.registerEnum("Network.CookieExemptionReason", {None: "None", UserSetting: "UserSetting", EnterprisePolicy: "EnterprisePolicy", StorageAccess: "StorageAccess", TopLevelStorageAccess: "TopLevelStorageAccess", Scheme: "Scheme", SameSiteNoneCookiesInSandbox: "SameSiteNoneCookiesInSandbox"});
 inspectorBackend.registerEnum("Network.AuthChallengeSource", {Server: "Server", Proxy: "Proxy"});
 inspectorBackend.registerEnum("Network.AuthChallengeResponseResponse", {Default: "Default", CancelAuth: "CancelAuth", ProvideCredentials: "ProvideCredentials"});

package/front_end/generated/protocol.ts

@@ -875,7 +875,6 @@ export namespace Audits {
     ExcludeSameSiteLax = 'ExcludeSameSiteLax',
     ExcludeSameSiteStrict = 'ExcludeSameSiteStrict',
     ExcludeDomainNonASCII = 'ExcludeDomainNonASCII',
-    ExcludeThirdPartyCookieBlockedInFirstPartySet = 'ExcludeThirdPartyCookieBlockedInFirstPartySet',
     ExcludeThirdPartyPhaseout = 'ExcludeThirdPartyPhaseout',
     ExcludePortMismatch = 'ExcludePortMismatch',
     ExcludeSchemeMismatch = 'ExcludeSchemeMismatch',
@@ -11318,7 +11317,6 @@ export namespace Network {
     SameSiteNoneInsecure = 'SameSiteNoneInsecure',
     UserPreferences = 'UserPreferences',
     ThirdPartyPhaseout = 'ThirdPartyPhaseout',
-    ThirdPartyBlockedInFirstPartySet = 'ThirdPartyBlockedInFirstPartySet',
     SyntaxError = 'SyntaxError',
     SchemeNotSupported = 'SchemeNotSupported',
     OverwriteSecure = 'OverwriteSecure',
@@ -11346,7 +11344,6 @@ export namespace Network {
     SameSiteNoneInsecure = 'SameSiteNoneInsecure',
     UserPreferences = 'UserPreferences',
     ThirdPartyPhaseout = 'ThirdPartyPhaseout',
-    ThirdPartyBlockedInFirstPartySet = 'ThirdPartyBlockedInFirstPartySet',
     UnknownError = 'UnknownError',
     SchemefulSameSiteStrict = 'SchemefulSameSiteStrict',
     SchemefulSameSiteLax = 'SchemefulSameSiteLax',

package/front_end/models/ai_assistance/AiAgent2.ts

@@ -141,7 +141,19 @@ export class AiAgent2 extends AiAgent<unknown> {
   readonly #declaredTools = new Set<string>();
 
   constructor(opts: AiAgent2Options) {
-    super(opts);
+    super({
+      ...opts,
+      allowedOrigin: opts.allowedOrigin ?? (() => {
+                       const lock = opts.originLock();
+                       if (lock.status === 'BLOCKED_BY_NAVIGATION') {
+                         return {blocked: true};
+                       }
+                       if (lock.status === 'ESTABLISHED_ORIGIN') {
+                         return {origin: lock.origin};
+                       }
+                       return {origin: undefined};
+                     }),
+    });
     this.#changes = opts.changeManager ?? new ChangeManager(opts.targetManager);
     this.#lighthouseRecording = opts.lighthouseRecording;
     this.#performanceRecordAndReload = opts.performanceRecordAndReload;

package/front_end/models/ai_assistance/AiConversation.ts

@@ -434,7 +434,7 @@ export class AiConversation {
           } = {},
           ): AsyncGenerator<ResponseData, void, void> {
     this.#navigationOccurredDuringRun = false;
-    const originAtRunStart = getPrimaryPageSecurityOrigin(this.#targetManager);
+    const originAtRunStart = this.#origin ?? getPrimaryPageSecurityOrigin(this.#targetManager);
     const listener = (): void => {
       // Prevent the agent from executing tools or reading data from an untrusted origin
       // if the page navigates unexpectedly during execution.

package/front_end/models/ai_assistance/agents/ContextSelectionAgent.ts

@@ -148,13 +148,12 @@ export class ContextSelectionAgent extends AiAgent<never> {
           };
         }
         const origin = allowedOriginResult.origin;
-        if (origin?.isOpaque()) {
+        if (!origin || origin.isOpaque()) {
           return {
             error: 'No requests recorded by DevTools',
           };
         }
 
-        const allowedSecurityOrigin = origin ?? null;
         let hasCrossOriginRequest = false;
         const requestsToShow: NetworkRequest[] = [];
         for (const request of this.#networkLog.requests()) {
@@ -166,7 +165,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
            * during the loading of the target page, and do not leak URLs from
            * other pages.
            */
-          if (allowedSecurityOrigin && !request.initiatorSecurityOrigin().isSameOriginWith(allowedSecurityOrigin)) {
+          if (!isOriginAllowedByLock({status: 'ESTABLISHED_ORIGIN', origin}, request.initiatorSecurityOrigin())) {
             hasCrossOriginRequest = true;
             continue;
           }
@@ -184,7 +183,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
         if (requests.length === 0) {
           return {
             error: hasCrossOriginRequest ?
-                `No requests showing with origin ${origin?.siteId() ?? ''}. Tell the user to start a new chat` :
+                `No requests showing with origin ${origin.siteId()}. Tell the user to start a new chat` :
                 'No requests recorded by DevTools',
           };
         }
@@ -231,18 +230,17 @@ export class ContextSelectionAgent extends AiAgent<never> {
           };
         }
         const origin = allowedOriginResult.origin;
-        if (origin?.isOpaque()) {
+        if (!origin || origin.isOpaque()) {
           return {
             error: 'No request found',
           };
         }
-        const allowedSecurityOrigin = origin ?? null;
         const request = this.#networkLog.requests().find(req => {
           if (req.requestId() !== id) {
             return false;
           }
 
-          return !allowedSecurityOrigin || req.initiatorSecurityOrigin().isSameOriginWith(allowedSecurityOrigin);
+          return isOriginAllowedByLock({status: 'ESTABLISHED_ORIGIN', origin}, req.initiatorSecurityOrigin());
         });
 
         if (request) {
@@ -288,13 +286,16 @@ export class ContextSelectionAgent extends AiAgent<never> {
           };
         }
         const origin = allowedOriginResult.origin;
+        if (!origin || origin.isOpaque()) {
+          return {
+            result: [],
+          };
+        }
 
         const files: Array<{file: string, id: number | undefined}> = [];
         const uiSourceCodes: Workspace.UISourceCode.UISourceCode[] = [];
         for (const file of ContextSelectionAgent.getUISourceCodes(this.#workspace)) {
-          const fileSecurityOrigin = file.securityOrigin();
-
-          if (origin && !fileSecurityOrigin.isSameOriginWith(origin)) {
+          if (!isOriginAllowedByLock({status: 'ESTABLISHED_ORIGIN', origin}, file.securityOrigin())) {
             continue;
           }
 
@@ -347,14 +348,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
           };
         }
         const origin = allowedOriginResult.origin;
-
-        const file = ContextSelectionAgent.getUISourceCodes(this.#workspace).find(file => {
-          if (ContextSelectionAgent.uiSourceCodeId.get(file) !== params.id) {
-            return false;
-          }
-          const fileSecurityOrigin = file.securityOrigin();
-          return !origin || fileSecurityOrigin.isSameOriginWith(origin);
-        });
+        const file = ContextSelectionAgent.getSourceById(params.id, origin, this.#workspace);
 
         if (!file) {
           return {
@@ -524,7 +518,7 @@ export class ContextSelectionAgent extends AiAgent<never> {
             };
           }
           const origin = allowedOriginResult.origin;
-          if (!origin) {
+          if (!origin || origin.isOpaque()) {
             return {
               error: 'Unable to find page storage.',
             };

package/front_end/models/change_tracker/ChangeTracker.ts

@@ -5,23 +5,11 @@
 import * as Root from '../../core/root/root.js';
 import type * as CommentManager from '../comment_manager/comment_manager.js';
 
-export type ChangeRecord = CommentManager.CommentManager.ChangeRecord;
-
-export const MAX_RECORDS = 1000;
-
 export class ChangeTracker {
-  readonly #records = new Map<string, ChangeRecord>();
   readonly #commentManager: CommentManager.CommentManager.CommentManager;
-  readonly #maxRecords: number;
-  #lastRecord?: ChangeRecord;
 
-  constructor(commentManager: CommentManager.CommentManager.CommentManager, maxRecords: number = MAX_RECORDS) {
+  constructor(commentManager: CommentManager.CommentManager.CommentManager) {
     this.#commentManager = commentManager;
-    this.#maxRecords = Math.max(1, maxRecords);
-  }
-
-  get maxRecords(): number {
-    return this.#maxRecords;
   }
 
   get isTracking(): boolean {
@@ -31,59 +19,12 @@ export class ChangeTracker {
   trackChange(
       description: string,
       anchor: CommentManager.CommentManager.CommentAnchorSignature,
-      ): ChangeRecord|null {
+      ): void {
     if (!this.isTracking) {
-      return null;
-    }
-    const record: ChangeRecord = {
-      id: crypto.randomUUID(),
-      description,
-      timestamp: Date.now(),
-    };
-    while (this.#records.size >= this.#maxRecords) {
-      this.#evictOldestRecord();
-    }
-
-    const thread = this.#commentManager.createCommentThread(anchor, undefined, undefined, [record]);
-    this.#records.set(thread.id, record);
-    this.#lastRecord = record;
-    return record;
-  }
-
-  #evictOldestRecord(): void {
-    // Delete the oldest record for which the comment thread has no user comments.
-    // If all comment threads have user comments, delete the oldest record.
-    for (const threadId of this.#records.keys()) {
-      const thread = this.#commentManager.getCommentThread(threadId);
-      if (!thread || thread.comments.length === 0) {
-        this.#commentManager.removeCommentThread(threadId);
-        this.#records.delete(threadId);
-        return;
-      }
+      return;
     }
 
-    const oldestThreadId = this.#records.keys().next().value;
-    if (oldestThreadId) {
-      this.#records.delete(oldestThreadId);
-    }
-  }
-
-  getChanges(): ChangeRecord[] {
-    return Array.from(this.#records.values());
-  }
-
-  getLastChange(): ChangeRecord|undefined {
-    return this.#lastRecord;
-  }
-
-  clear(): void {
-    for (const threadId of this.#records.keys()) {
-      const thread = this.#commentManager.getCommentThread(threadId);
-      if (!thread || thread.comments.length === 0) {
-        this.#commentManager.removeCommentThread(threadId);
-      }
-    }
-    this.#records.clear();
-    this.#lastRecord = undefined;
+    const thread = this.#commentManager.createCommentThread(anchor, description, 'DEVELOPER', true);
+    thread.save();
   }
 }

package/front_end/models/comment_manager/CommentManager.ts

@@ -5,7 +5,6 @@
 import * as Common from '../../core/common/common.js';
 
 import {
-  type ChangeRecord,
   type Comment,
   type CommentAnchorSignature,
   CommentThread,
@@ -18,7 +17,6 @@ import {
 } from './CommentThread.js';
 
 export {
-  type ChangeRecord,
   type Comment,
   type CommentAnchorSignature,
   CommentThread,
@@ -92,7 +90,7 @@ export class CommentManager extends Common.ObjectWrapper.ObjectWrapper<EventType
       anchor: CommentAnchorSignature,
       text?: string,
       author: 'DEVELOPER'|'AGENT' = 'DEVELOPER',
-      changes?: ChangeRecord[],
+      isGeneratedComment?: boolean,
       ): CommentThread {
     const comments: Comment[] = text ? [{
       author,
@@ -103,7 +101,7 @@ export class CommentManager extends Common.ObjectWrapper.ObjectWrapper<EventType
     const thread = new CommentThread({
       anchor,
       comments,
-      changes,
+      isGeneratedComment,
     });
     thread.addEventListener(CommentThreadEvents.CHANGED, this.#onThreadChanged, this);
 
@@ -123,7 +121,7 @@ export class CommentManager extends Common.ObjectWrapper.ObjectWrapper<EventType
   takeComments(): CommentThread[] {
     const threads: CommentThread[] = [];
     for (const thread of this.#commentThreads.values()) {
-      if (thread.status === 'ACTIVE' && !thread.transmitted) {
+      if (thread.status === 'SENT_TO_AGENT' && !thread.transmitted) {
         thread.transmitted = true;
         threads.push(thread);
       }

package/front_end/models/comment_manager/CommentThread.ts

@@ -58,13 +58,7 @@ export interface Comment {
   timestamp: number;
 }
 
-export interface ChangeRecord {
-  id: string;
-  description: string;
-  timestamp: number;
-}
-
-export type CommentThreadStatus = 'DRAFT'|'ACTIVE'|'RESOLVED';
+export type CommentThreadStatus = 'DRAFT'|'ACTIVE'|'SENT_TO_AGENT'|'RESOLVED';
 
 export const enum Events {
   CHANGED = 'Changed',
@@ -77,7 +71,8 @@ export interface EventTypes {
 export interface CommentThreadOptions {
   anchor: CommentAnchorSignature;
   comments?: Comment[];
-  changes?: ChangeRecord[];
+  /** True for comments generated from the change tracker. */
+  isGeneratedComment?: boolean;
 }
 
 export class CommentThread extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
@@ -89,33 +84,41 @@ export class CommentThread extends Common.ObjectWrapper.ObjectWrapper<EventTypes
 
   readonly id: string = crypto.randomUUID();
   readonly anchor: CommentAnchorSignature;
+  /** True for comments generated from the change tracker. */
+  readonly isGeneratedComment: boolean;
   #savedIndex?: number;
   comments: Comment[];
   status: CommentThreadStatus = 'DRAFT';
   transmitted: boolean = false;
-  changes?: ChangeRecord[];
 
   constructor(options: CommentThreadOptions) {
     super();
     this.anchor = options.anchor;
     this.comments = options.comments ?? [];
-    this.changes = options.changes;
+    this.isGeneratedComment = Boolean(options.isGeneratedComment);
   }
 
   get index(): number {
     return this.#savedIndex ?? CommentThread.#nextIndex;
   }
 
-  save(text?: string, author: 'DEVELOPER'|'AGENT' = 'DEVELOPER'): void {
-    let changed = false;
+  /**
+   * Returns whether it was changed.
+   */
+  #saveText(text?: string, author: 'DEVELOPER'|'AGENT' = 'DEVELOPER'): boolean {
     if (text && text.trim().length > 0) {
       this.comments.push({
         author,
         text: text.trim(),
         timestamp: Date.now(),
       });
-      changed = true;
+      return true;
     }
+    return false;
+  }
+
+  save(text?: string, author: 'DEVELOPER'|'AGENT' = 'DEVELOPER'): void {
+    let changed = this.#saveText(text, author);
     if (this.status === 'DRAFT') {
       if (this.#savedIndex === undefined) {
         this.#savedIndex = CommentThread.#nextIndex++;
@@ -128,6 +131,20 @@ export class CommentThread extends Common.ObjectWrapper.ObjectWrapper<EventTypes
     }
   }
 
+  sendToAgent(text?: string, author: 'DEVELOPER'|'AGENT' = 'DEVELOPER'): void {
+    let changed = this.#saveText(text, author);
+    if (this.status === 'DRAFT' || this.status === 'ACTIVE') {
+      if (this.#savedIndex === undefined) {
+        this.#savedIndex = CommentThread.#nextIndex++;
+      }
+      this.status = 'SENT_TO_AGENT';
+      changed = true;
+    }
+    if (changed) {
+      this.dispatchEventToListeners(Events.CHANGED);
+    }
+  }
+
   resolve(replyText?: string): void {
     if (replyText && replyText.trim().length > 0) {
       this.comments.push({

package/front_end/models/issues_manager/CookieDeprecationMetadataIssue.ts

@@ -33,20 +33,19 @@ export class CookieDeprecationMetadataIssue extends Issue<Protocol.Audits.Cookie
   }
 
   getDescription(): MarkdownIssueDescription {
-    const fileName =
+    let fileName =
         this.details().operation === 'SetCookie' ? 'cookieWarnMetadataGrantSet.md' : 'cookieWarnMetadataGrantRead.md';
 
-    let optOutText = '';
+    const substitutions = new Map<string, string>();
     if (this.details().isOptOutTopLevel) {
-      optOutText = '\n\n (Top level site opt-out: ' + this.details().optOutPercentage +
-          '% - [learn more](gracePeriodStagedControlExplainer))';
+      fileName = this.details().operation === 'SetCookie' ? 'cookieWarnMetadataGrantSetOptOut.md' :
+                                                            'cookieWarnMetadataGrantReadOptOut.md';
+      substitutions.set('PLACEHOLDER_optOutPercentage', String(this.details().optOutPercentage));
     }
 
     return {
       file: fileName,
-      substitutions: new Map([
-        ['PLACEHOLDER_topleveloptout', optOutText],
-      ]),
+      substitutions,
       links: [
         {
           link: 'https://goo.gle/changes-to-chrome-browsing',

package/front_end/models/issues_manager/DeprecationIssue.ts

@@ -71,8 +71,8 @@ export class DeprecationIssue extends Issue<Protocol.Audits.DeprecationIssueDeta
     }
     return resolveLazyDescription({
       file: 'deprecation.md',
+      title: i18nLazyString(UIStrings.title),
       substitutions: new Map([
-        ['PLACEHOLDER_title', i18nLazyString(UIStrings.title)],
         ['PLACEHOLDER_message', messageFunction],
       ]),
       links,

package/front_end/models/issues_manager/MarkdownIssueDescription.ts

@@ -13,12 +13,14 @@ import * as Marked from '../../third_party/marked/marked.js';
  */
 export interface MarkdownIssueDescription {
   file: string;
+  title?: string;
   substitutions?: Map<string, string>;
   links: Array<{link: string, linkTitle: string}>;
 }
 
 export interface LazyMarkdownIssueDescription {
   file: string;
+  title?: () => string;
   substitutions?: Map<string, () => string>;
   links: Array<{link: string, linkTitle: () => string}>;
 }
@@ -38,8 +40,9 @@ export function resolveLazyDescription(lazyDescription: LazyMarkdownIssueDescrip
     substitutionMap.set(key, value());
   });
 
-  const description = {
+  const description: MarkdownIssueDescription = {
     file: lazyDescription.file,
+    title: lazyDescription.title?.(),
     links: lazyDescription.links.map(linksMap),
     substitutions: substitutionMap,
   };
@@ -54,6 +57,7 @@ export interface IssueDescription {
   title: string;
   markdown: Marked.Marked.Token[];
   links: Array<{link: string, linkTitle: string}>;
+  substitutions?: Map<string, string>;
 }
 
 export async function getFileContent(url: URL): Promise<string> {
@@ -82,15 +86,16 @@ export async function createIssueDescriptionFromMarkdown(description: MarkdownIs
 export function createIssueDescriptionFromRawMarkdown(
     markdown: string, description: MarkdownIssueDescription): IssueDescription {
   const markdownAst = Marked.Marked.lexer(markdown);
-  const title = findTitleFromMarkdownAst(markdownAst);
-  if (!title) {
+  const markdownTitle = findTitleFromMarkdownAst(markdownAst);
+  if (!markdownTitle) {
     throw new Error('Markdown issue descriptions must start with a heading');
   }
 
   return {
-    title,
+    title: description.title ?? markdownTitle,
     markdown: markdownAst.slice(1),
     links: description.links,
+    substitutions: description.substitutions,
   };
 }
 
@@ -148,5 +153,9 @@ export async function getIssueTitleFromMarkdownDescription(description: Markdown
     Promise<string|null> {
   const rawMarkdown = await getMarkdownFileContent(description.file);
   const markdownAst = Marked.Marked.lexer(rawMarkdown);
-  return findTitleFromMarkdownAst(markdownAst);
+  const markdownTitle = findTitleFromMarkdownAst(markdownAst);
+  if (!markdownTitle) {
+    return null;
+  }
+  return description.title ?? markdownTitle;
 }

package/front_end/models/issues_manager/SRIMessageSignatureIssue.ts

@@ -77,10 +77,8 @@ export class SRIMessageSignatureIssue extends Issue<Protocol.Audits.SRIMessageSi
       description.substitutions?.set('PLACEHOLDER_signatureBase', () => details.signatureBase);
     }
     if (details.error === Protocol.Audits.SRIMessageSignatureError.ValidationFailedIntegrityMismatch) {
-      description.substitutions?.set('PLACEHOLDER_integrityAssertions', () => {
-        const prefix = '\n* ';
-        return prefix + this.details().integrityAssertions.join(prefix);
-      });
+      description.substitutions?.set('PLACEHOLDER_integrityAssertions',
+                                     () => this.details().integrityAssertions.join('\n'));
     }
     return resolveLazyDescription(description);
   }

package/front_end/models/issues_manager/descriptions/cookieWarnMetadataGrantRead.md

@@ -1,4 +1,3 @@
 # Third-party websites are allowed to read cookies on this page
 
 One or more websites are allowed to bypass user settings to read third-party cookies on this page. Web developers should take steps to remove these reads without disrupting user experience. To forcefully block these third-party cookies, update [user settings](manageCookiesHelpPage).
-{PLACEHOLDER_topleveloptout}

package/front_end/models/issues_manager/descriptions/cookieWarnMetadataGrantReadOptOut.md

@@ -0,0 +1,5 @@
+# Third-party websites are allowed to read cookies on this page
+
+One or more websites are allowed to bypass user settings to read third-party cookies on this page. Web developers should take steps to remove these reads without disrupting user experience. To forcefully block these third-party cookies, update [user settings](manageCookiesHelpPage).
+
+(Top level site opt-out: {PLACEHOLDER_optOutPercentage}% - [learn more](gracePeriodStagedControlExplainer))

package/front_end/models/issues_manager/descriptions/cookieWarnMetadataGrantSet.md

@@ -1,4 +1,3 @@
 # Third-party websites are allowed to set cookies on this page
 
 One or more websites are allowed to bypass user settings to set third-party cookies on this page. Web developers should take steps to remove these sets without disrupting user experience. To forcefully block these third-party cookies, update [user settings](manageCookiesHelpPage).
-{PLACEHOLDER_topleveloptout}

package/front_end/models/issues_manager/descriptions/cookieWarnMetadataGrantSetOptOut.md

@@ -0,0 +1,5 @@
+# Third-party websites are allowed to set cookies on this page
+
+One or more websites are allowed to bypass user settings to set third-party cookies on this page. Web developers should take steps to remove these sets without disrupting user experience. To forcefully block these third-party cookies, update [user settings](manageCookiesHelpPage).
+
+(Top level site opt-out: {PLACEHOLDER_optOutPercentage}% - [learn more](gracePeriodStagedControlExplainer))