chrome-devtools-frontend 1.0.1700561 → 1.0.1701636

package/front_end/panels/sensors/SensorsView.ts

@@ -12,6 +12,7 @@ import * as Geometry from '../../ui/geometry/geometry.js';
 import * as SettingsUI from '../../ui/legacy/components/settings_ui/settings_ui.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import {Directives, html, render} from '../../ui/lit/lit.js';
+import * as SettingUIRegistration from '../../ui/settings/settings.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 import * as MobileThrottling from '../mobile_throttling/mobile_throttling.js';
 
@@ -128,6 +129,15 @@ const UIStrings = {
    * @description Description of the Emulate Idle State select in the Sensors view.
    */
   forcesSelectedIdleStateEmulation: 'Forces selected idle state emulation',
+  /**
+   * @description Description of the Emulate CPU Performance Tier select in the Sensors view.
+   */
+  forcesSelectedCpuPerformanceTierEmulation: 'Forces CPU performance tier emulation',
+  /**
+   * @description Option value for no CPU Performance override with default value
+   * @example {Tier 3: HIGH} PH1
+   */
+  cpuPerformanceNoOverrideWithDefault: 'No override ({PH1})',
   /**
    * @description Description of the Emulate CPU Pressure State select in the Sensors view.
    */
@@ -206,6 +216,8 @@ export class SensorsView extends UI.Widget.VBox {
   private boxMatrix?: DOMMatrix;
   private mouseDownVector?: Geometry.Vector|null;
   private originalBoxMatrix?: DOMMatrix;
+  readonly #cpuThrottlingManager: SDK.CPUThrottlingManager.CPUThrottlingManager;
+  #cpuPerformanceNoOverrideOptionElement?: HTMLOptionElement;
 
   constructor() {
     super({
@@ -215,6 +227,8 @@ export class SensorsView extends UI.Widget.VBox {
     this.registerRequiredCSS(sensorsStyles);
     this.contentElement.classList.add('sensors-view');
 
+    this.#cpuThrottlingManager = SDK.CPUThrottlingManager.CPUThrottlingManager.instance();
+
     this.#locationSetting = Common.Settings.Settings.instance().createSetting('emulation.location-override', '');
     this.#location = SDK.EmulationModel.Location.parseSetting(this.#locationSetting.get());
     this.#locationOverrideEnabled = false;
@@ -251,6 +265,10 @@ export class SensorsView extends UI.Widget.VBox {
     this.createPressureSection();
 
     this.createPanelSeparator();
+
+    this.createCPUPerformanceSection();
+
+    this.createPanelSeparator();
   }
 
   private createPanelSeparator(): void {
@@ -734,6 +752,75 @@ export class SensorsView extends UI.Widget.VBox {
     }
   }
 
+  private createCPUPerformanceSection(): void {
+    const container = this.contentElement.createChild('div', 'cpu-performance-section');
+    const control = SettingsUI.SettingsUI.createControlForSetting(
+        Common.Settings.Settings.instance().resolve(SDK.SDKSettings.cpuPerformanceSettingDescriptor),
+        i18nString(UIStrings.forcesSelectedCpuPerformanceTierEmulation));
+
+    if (control) {
+      container.appendChild(control);
+      // The text of the "no override" option element needs to be updated dynamically.
+      const noOverrideOption = control.querySelector<HTMLOptionElement>('select option[value="no-override"]');
+      if (noOverrideOption) {
+        this.#cpuPerformanceNoOverrideOptionElement = noOverrideOption;
+        this.#updateCPUPerformanceNoOverrideLabel();
+      } else {
+        this.#cpuPerformanceNoOverrideOptionElement = undefined;
+      }
+    }
+  }
+
+  override wasShown(): void {
+    super.wasShown();
+    if (this.#cpuPerformanceNoOverrideOptionElement) {
+      this.#cpuThrottlingManager.addEventListener(SDK.CPUThrottlingManager.Events.CPU_PERFORMANCE_TIER_CHANGED,
+                                                  this.#updateCPUPerformanceNoOverrideLabel, this);
+      this.#cpuThrottlingManager.addEventListener(SDK.CPUThrottlingManager.Events.RATE_CHANGED,
+                                                  this.#updateCPUPerformanceNoOverrideLabel, this);
+      this.#updateCPUPerformanceNoOverrideLabel();
+    }
+  }
+
+  override willHide(): void {
+    super.willHide();
+    if (this.#cpuPerformanceNoOverrideOptionElement) {
+      this.#cpuThrottlingManager.removeEventListener(SDK.CPUThrottlingManager.Events.CPU_PERFORMANCE_TIER_CHANGED,
+                                                     this.#updateCPUPerformanceNoOverrideLabel, this);
+      this.#cpuThrottlingManager.removeEventListener(SDK.CPUThrottlingManager.Events.RATE_CHANGED,
+                                                     this.#updateCPUPerformanceNoOverrideLabel, this);
+    }
+  }
+
+  #updateCPUPerformanceNoOverrideLabel(): void {
+    if (!this.#cpuPerformanceNoOverrideOptionElement) {
+      return;
+    }
+    // Helper function to retrieve the tier labels (i18n) from the settings.
+    const options =
+        SettingUIRegistration.SettingUIRegistration.resolve(SDK.SDKSettings.cpuPerformanceSettingDescriptor).options;
+    const getOptionTitle = (value: string): string => {
+      const opt = options.find(o => o.value === value);
+      if (!opt) {
+        return '';
+      }
+      return opt.title;
+    };
+    // Helper function to return a fallback title, to be used if the above fails.
+    const getFallbackTitle = (tier: SDK.CPUThrottlingManager.CPUPerformanceTier): string => {
+      return `Tier ${SDK.CPUThrottlingManager.tierToNumber(tier)}: ${tier.toUpperCase()}`;
+    };
+    // Update the text of the "no-override" element using the calculated tier.
+    const calculatedTier = this.#cpuThrottlingManager.calculatedCPUPerformanceTier();
+    if (calculatedTier !== undefined) {
+      const tierTitle = getOptionTitle(calculatedTier) || getFallbackTitle(calculatedTier);
+      this.#cpuPerformanceNoOverrideOptionElement.text =
+          i18nString(UIStrings.cpuPerformanceNoOverrideWithDefault, {PH1: tierTitle});
+    } else {
+      this.#cpuPerformanceNoOverrideOptionElement.text = getOptionTitle('no-override') || 'No override';
+    }
+  }
+
   private enableOrientationFields(disable: boolean|null): void {
     if (disable) {
       this.deviceOrientationFieldset.disabled = true;

package/front_end/panels/sensors/sensors-meta.ts

@@ -119,6 +119,34 @@ const UIStrings = {
    * @description Command that shows the Locations settings tab.
    */
   showLocations: 'Show Locations',
+  /**
+   * @description Text for the CPU Performance Tier type to simulate on a device.
+   */
+  cpuPerformance: 'CPU Performance Tier',
+  /**
+   * @description Option value for no CPU Performance override
+   */
+  cpuPerformanceNoOverride: 'No override',
+  /**
+   * @description Label for Unknown CPU Performance tier
+   */
+  cpuPerformanceTierUnknown: 'Tier 0: UNKNOWN',
+  /**
+   * @description Label for Low CPU Performance tier
+   */
+  cpuPerformanceTierLow: 'Tier 1: LOW',
+  /**
+   * @description Label for Mid CPU Performance tier
+   */
+  cpuPerformanceTierMid: 'Tier 2: MID',
+  /**
+   * @description Label for High CPU Performance tier
+   */
+  cpuPerformanceTierHigh: 'Tier 3: HIGH',
+  /**
+   * @description Label for Ultra CPU Performance tier
+   */
+  cpuPerformanceTierUltra: 'Tier 4: ULTRA',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/sensors/sensors-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
@@ -140,7 +168,11 @@ UI.ViewManager.registerViewExtension({
   persistence: UI.ViewManager.ViewPersistence.CLOSEABLE,
   order: 100,
   async loadView() {
-    const Sensors = await loadEmulationModule();
+    const [Sensors] = await Promise.all([
+      loadEmulationModule(),
+      // Ensure that this is available when the sensors panel is constructed.
+      SDK.CPUThrottlingManager.CPUThrottlingManager.instance().updateHostDefaultCPUPerformanceTier(),
+    ]);
     return new Sensors.SensorsView.SensorsView();
   },
   tags: [
@@ -330,3 +362,39 @@ SettingsUI.SettingUIRegistration.register(SDK.SDKSettings.idleDetectionSettingDe
     },
   ],
 });
+
+SettingsUI.SettingUIRegistration.register(SDK.SDKSettings.cpuPerformanceSettingDescriptor, {
+  title: i18nLazyString(UIStrings.cpuPerformance),
+  options: [
+    {
+      value: 'no-override',
+      title: i18nLazyString(UIStrings.cpuPerformanceNoOverride),
+      text: i18nLazyString(UIStrings.cpuPerformanceNoOverride),
+    },
+    {
+      value: 'unknown',
+      title: i18nLazyString(UIStrings.cpuPerformanceTierUnknown),
+      text: i18nLazyString(UIStrings.cpuPerformanceTierUnknown),
+    },
+    {
+      value: 'low',
+      title: i18nLazyString(UIStrings.cpuPerformanceTierLow),
+      text: i18nLazyString(UIStrings.cpuPerformanceTierLow),
+    },
+    {
+      value: 'mid',
+      title: i18nLazyString(UIStrings.cpuPerformanceTierMid),
+      text: i18nLazyString(UIStrings.cpuPerformanceTierMid),
+    },
+    {
+      value: 'high',
+      title: i18nLazyString(UIStrings.cpuPerformanceTierHigh),
+      text: i18nLazyString(UIStrings.cpuPerformanceTierHigh),
+    },
+    {
+      value: 'ultra',
+      title: i18nLazyString(UIStrings.cpuPerformanceTierUltra),
+      text: i18nLazyString(UIStrings.cpuPerformanceTierUltra),
+    },
+  ],
+});

package/front_end/panels/settings/keybindsSettingsTab.css

@@ -81,7 +81,7 @@
 }
 
 .keybinds-list-item:not(.keybinds-editing):hover .keybinds-edit-button,
-.keybinds-list-item:not(.keybinds-editing):focus-within .keybinds-edit-button {
+.keybinds-list-item-wrapper:focus-within > .keybinds-list-item:not(.keybinds-editing) .keybinds-edit-button {
   display: inline-block;
 }
 

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: Internal
 Version: N/A
-Revision: 9d63ca908583451379cc48bc4e3cc2e5c7041395
+Revision: 06b292ff2ec4351e7347ab81ef96701be766e37b
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/ui/legacy/Treeoutline.ts

@@ -1676,7 +1676,8 @@ class TreeViewTreeElement extends TreeElement {
     this.#clonedClasses.clear();
     for (let i = 0; i < this.configElement.attributes.length; ++i) {
       const attribute = this.configElement.attributes.item(i);
-      if (attribute && attribute.name !== 'role' && TreeViewTreeElement.CLONED_ATTRIBUTES.has(attribute.name)) {
+      if (attribute && attribute.name !== 'role' &&
+          (TreeViewTreeElement.CLONED_ATTRIBUTES.has(attribute.name) || attribute.name.startsWith('data-'))) {
         this.listItemElement.setAttribute(attribute.name, attribute.value);
         this.#clonedAttributes.add(attribute.name);
       }

package/front_end/ui/legacy/components/data_grid/DataGridElement.ts

@@ -646,7 +646,7 @@ function nodeMixin<TBase extends Constructor<DataGridNode<any>>>(base: TBase) {
 
     override createElement(): HTMLElement {
       const element = super.createElement();
-      element.addEventListener('click', this.#onRowMouseEvent.bind(this));
+      element.addEventListener('click', this.#onRowMouseEvent.bind(this), {capture: true});
       element.addEventListener('mouseenter', this.#onRowMouseEvent.bind(this));
       element.addEventListener('mouseleave', this.#onRowMouseEvent.bind(this));
       if (this.#configElement.hasAttribute('style')) {

package/front_end/ui/legacy/treeoutline.css

@@ -35,7 +35,7 @@
   margin-left: -10000px;
 }
 
-.tree-outline:not(.hide-selection-when-blurred) li.selected {
+.tree-outline:not(.hide-selection-when-blurred, .elements-tree-outline) li.selected {
   color: var(--sys-color-on-surface-subtle);
 }
 
@@ -90,7 +90,7 @@ ol.tree-outline,
   min-height: var(--sys-size-8);
 }
 
-ol.tree-outline:not(.hide-selection-when-blurred) li.selected:focus {
+ol.tree-outline:not(.hide-selection-when-blurred, .elements-tree-outline) li.selected:focus {
   color: var(--sys-color-on-tonal-container);
 
   & ::selection {

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -287,6 +287,7 @@ export const knownContextValues: Set<string> = new Set([
   'accessibility-default',
   'accessibility-tree',
   'accessibility.clear-announcements',
+  'accessibility.export-csv',
   'accessibility.toggle-recording',
   'accessibility.view',
   'accuracy',
@@ -1632,6 +1633,7 @@ export const knownContextValues: Set<string> = new Set([
   'emulation.capture-full-height-screenshot',
   'emulation.capture-node-screenshot',
   'emulation.capture-screenshot',
+  'emulation.cpu-performance',
   'emulation.cpu-pressure',
   'emulation.device-height',
   'emulation.device-mode-value',
@@ -2060,6 +2062,7 @@ export const knownContextValues: Set<string> = new Set([
   'hide-network-messages',
   'hide-player',
   'hide-repeating-children',
+  'high',
   'highlight-node-on-hover-in-overlay',
   'history',
   'historyRedo',
@@ -2718,6 +2721,7 @@ export const knownContextValues: Set<string> = new Set([
   'long-tasks',
   'longitude',
   'lostpointercapture',
+  'low',
   'low-contrast-details',
   'low-end-mobile',
   'low-text-contrast',
@@ -2846,6 +2850,7 @@ export const knownContextValues: Set<string> = new Set([
   'microsoft-edge-edge-html-x-box',
   'microsoft-edge-i-pad',
   'microsoft-edge-i-phone',
+  'mid',
   'mid-tier-mobile',
   'min-block-size',
   'min-height',
@@ -4530,6 +4535,7 @@ export const knownContextValues: Set<string> = new Set([
   'ui-theme-system-preferred',
   'uiTheme',
   'uk',
+  'ultra',
   'unavailable',
   'unblock',
   'undefined',
@@ -4537,6 +4543,7 @@ export const knownContextValues: Set<string> = new Set([
   'unicode-bidi',
   'unicode-range',
   'unit',
+  'unknown',
   'unload',
   'unregister',
   'unset',

package/package.json

@@ -90,5 +90,5 @@
     "yargs": "18.1.0",
     "yargs-unparser": "2.0.0"
   },
-  "version": "1.0.1700561"
+  "version": "1.0.1701636"
 }