chrome-devtools-frontend 1.0.1697998 → 1.0.1699061

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (145) hide show
  1. package/.agents/skills/devtools-verification/SKILL.md +19 -0
  2. package/.agents/skills/{repro-flaky-tests → fix-tests}/SKILL.md +2 -2
  3. package/.agents/skills/version-control/SKILL.md +21 -9
  4. package/front_end/core/platform/HostRuntime.ts +12 -0
  5. package/front_end/core/platform/api/HostRuntime.ts +13 -0
  6. package/front_end/core/platform/browser/HostRuntime.ts +34 -0
  7. package/front_end/core/platform/node/HostRuntime.ts +40 -0
  8. package/front_end/core/sdk/AnimationModel.ts +12 -98
  9. package/front_end/core/sdk/CSSModel.ts +4 -2
  10. package/front_end/core/sdk/CSSPropertyParser.ts +4 -4
  11. package/front_end/core/sdk/CSSPropertyParserMatchers.ts +4 -44
  12. package/front_end/core/sdk/Connections.ts +6 -1
  13. package/front_end/core/sdk/ConsoleModel.ts +1 -12
  14. package/front_end/core/sdk/DOMModel.ts +6 -56
  15. package/front_end/core/sdk/DebuggerModel.ts +9 -8
  16. package/front_end/core/sdk/NetworkManager.ts +2 -2
  17. package/front_end/core/sdk/NetworkRequest.ts +1 -1
  18. package/front_end/core/sdk/OverlayModel.ts +11 -12
  19. package/front_end/core/sdk/PageFunctions.ts +187 -0
  20. package/front_end/core/sdk/Resource.ts +1 -1
  21. package/front_end/core/sdk/RuntimeModel.ts +1 -20
  22. package/front_end/core/sdk/Script.ts +21 -0
  23. package/front_end/core/sdk/SourceMap.ts +15 -2
  24. package/front_end/core/sdk/SourceMapCache.ts +13 -10
  25. package/front_end/core/sdk/SourceMapManager.ts +11 -9
  26. package/front_end/core/sdk/SourceMapScopeChainEntry.ts +109 -15
  27. package/front_end/core/sdk/SourceMapScopesInfo.ts +8 -2
  28. package/front_end/entrypoints/heap_snapshot_worker/ContextAnalyzer.ts +635 -0
  29. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts +26 -12
  30. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshotLoader.ts +16 -2
  31. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshotWorkerDispatcher.ts +4 -4
  32. package/front_end/entrypoints/heap_snapshot_worker/heap_snapshot_worker.ts +2 -0
  33. package/front_end/entrypoints/shell/shell.ts +1 -1
  34. package/front_end/models/ai_assistance/DOMHelpers.ts +95 -0
  35. package/front_end/models/ai_assistance/EvaluateAction.ts +5 -42
  36. package/front_end/models/ai_assistance/ExtensionScope.ts +2 -31
  37. package/front_end/models/ai_assistance/agents/AiAgent.ts +2 -1
  38. package/front_end/models/ai_assistance/agents/ContextSelectionAgent.ts +3 -4
  39. package/front_end/models/ai_assistance/ai_assistance.ts +2 -0
  40. package/front_end/models/ai_assistance/contexts/DOMNodeContext.ts +10 -7
  41. package/front_end/models/ai_assistance/contexts/FileContext.ts +2 -10
  42. package/front_end/models/ai_assistance/tools/GetSourceContent.ts +3 -2
  43. package/front_end/models/ai_assistance/tools/ListSources.ts +21 -14
  44. package/front_end/models/bindings/CompilerScriptMapping.ts +3 -10
  45. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +48 -17
  46. package/front_end/models/bindings/ResourceScriptMapping.ts +2 -2
  47. package/front_end/models/bindings/StylesSourceMapping.ts +1 -1
  48. package/front_end/models/comment_manager/CD4ABridge.ts +55 -12
  49. package/front_end/models/comment_manager/CommentManager.ts +46 -91
  50. package/front_end/models/comment_manager/CommentThread.ts +145 -0
  51. package/front_end/models/comment_manager/comment_manager.ts +2 -0
  52. package/front_end/models/emulation/DeviceModeModel.ts +54 -1
  53. package/front_end/models/extensions/ExtensionAPI.ts +8 -6
  54. package/front_end/models/extensions/ExtensionEndpoint.ts +11 -8
  55. package/front_end/models/extensions/HostUrlPattern.ts +4 -3
  56. package/front_end/models/extensions/LanguageExtensionEndpoint.ts +3 -2
  57. package/front_end/models/extensions/RecorderExtensionEndpoint.ts +2 -1
  58. package/front_end/models/formatter/FormatterWorkerPool.ts +4 -6
  59. package/front_end/models/heap_snapshot/HeapSnapshotModel.ts +55 -0
  60. package/front_end/models/heap_snapshot/HeapSnapshotProxy.ts +18 -14
  61. package/front_end/models/issues_manager/CookieIssue.ts +0 -13
  62. package/front_end/models/issues_manager/IssuesManager.ts +5 -0
  63. package/front_end/models/issues_manager/WebInstallIssue.ts +63 -0
  64. package/front_end/models/issues_manager/descriptions/webInstallManifestMissingId.md +3 -0
  65. package/front_end/models/issues_manager/descriptions/webInstallManifestMissingNameOrShortName.md +3 -0
  66. package/front_end/models/issues_manager/descriptions/webInstallManifestParsingOrNetworkError.md +3 -0
  67. package/front_end/models/issues_manager/descriptions/webInstallNoManifest.md +3 -0
  68. package/front_end/models/issues_manager/descriptions/webInstallStartUrlInvalid.md +3 -0
  69. package/front_end/models/issues_manager/issues_manager.ts +2 -0
  70. package/front_end/models/source_map_scopes/NamesResolver.ts +11 -3
  71. package/front_end/models/source_map_scopes/ScopeChainModel.ts +10 -6
  72. package/front_end/models/workspace/UISourceCode.ts +20 -0
  73. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +281 -3
  74. package/front_end/panels/accessibility/accessibilityAnnouncementRecordingView.css +85 -0
  75. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +5 -8
  76. package/front_end/panels/ai_assistance/components/AIv2MarkdownRenderer.ts +4 -10
  77. package/front_end/panels/animation/AnimationTimeline.ts +1 -1
  78. package/front_end/panels/application/CrashReportContextView.ts +1 -1
  79. package/front_end/panels/application/IndexedDBViews.ts +1 -1
  80. package/front_end/panels/application/KeyValueStorageItemsView.ts +1 -0
  81. package/front_end/panels/application/components/AdsView.ts +63 -1
  82. package/front_end/panels/application/components/adsView.css +11 -1
  83. package/front_end/{ui/comments → panels/common}/CommentThreadWidget.ts +5 -20
  84. package/front_end/{ui/comments → panels/common}/CommentsOverlayWidget.ts +39 -62
  85. package/front_end/{ui/comments → panels/common}/CommentsStatusBarPill.ts +5 -5
  86. package/front_end/panels/common/ExtensionServer.ts +2 -1
  87. package/front_end/{ui/comments → panels/common}/commentThreadWidget.css +0 -12
  88. package/front_end/{ui/comments → panels/common}/commentsOverlay.css +2 -1
  89. package/front_end/{ui/comments/comments-meta.ts → panels/common/common-meta.ts} +11 -11
  90. package/front_end/panels/common/common.ts +3 -0
  91. package/front_end/panels/elements/AdoptedStyleSheetTreeElement.ts +3 -3
  92. package/front_end/panels/elements/CSSRuleValidator.ts +1 -1
  93. package/front_end/panels/elements/ElementsPanel.ts +9 -5
  94. package/front_end/panels/elements/ElementsTreeElement.ts +11 -3
  95. package/front_end/panels/elements/ElementsTreeOutline.ts +69 -74
  96. package/front_end/panels/elements/PropertiesWidget.ts +11 -10
  97. package/front_end/panels/elements/PropertyRenderer.ts +29 -25
  98. package/front_end/panels/elements/StylePropertyTreeElement.ts +6 -6
  99. package/front_end/panels/elements/elementsTreeOutline.css +11 -5
  100. package/front_end/panels/emulation/DeviceModeToolbar.ts +2 -3
  101. package/front_end/panels/event_listeners/EventListenersView.ts +33 -44
  102. package/front_end/panels/lighthouse/LighthouseController.ts +1 -1
  103. package/front_end/panels/linear_memory_inspector/LinearMemoryInspectorController.ts +6 -7
  104. package/front_end/panels/linear_memory_inspector/components/linearMemoryInspector.css +5 -1
  105. package/front_end/panels/linear_memory_inspector/linear_memory_inspector-meta.ts +1 -1
  106. package/front_end/panels/mobile_throttling/NetworkPanelIndicator.ts +1 -1
  107. package/front_end/panels/mobile_throttling/ThrottlingManager.ts +1 -1
  108. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +1 -1
  109. package/front_end/panels/recorder/StepView.ts +19 -4
  110. package/front_end/panels/recorder/TimelineSection.ts +1 -1
  111. package/front_end/panels/recorder/stepView.css +1 -0
  112. package/front_end/panels/security/SecurityPanel.ts +5 -5
  113. package/front_end/panels/security/SecurityPanelSidebar.ts +2 -11
  114. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +2 -1
  115. package/front_end/panels/settings/EditFileSystemView.ts +1 -1
  116. package/front_end/panels/sources/CallStackSidebarPane.ts +1 -1
  117. package/front_end/panels/sources/DebuggerPlugin.ts +2 -2
  118. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +11 -16
  119. package/front_end/panels/sources/sources-meta.ts +1 -1
  120. package/front_end/panels/timeline/components/DetailsView.ts +3 -3
  121. package/front_end/panels/timeline/components/OriginMap.ts +1 -1
  122. package/front_end/panels/timeline/components/insights/BaseInsightComponent.ts +2 -3
  123. package/front_end/panels/timeline/overlays/OverlaysImpl.ts +0 -3
  124. package/front_end/third_party/chromium/README.chromium +1 -1
  125. package/front_end/ui/comments/CommentOverlayManager.ts +28 -110
  126. package/front_end/ui/comments/comments.ts +0 -6
  127. package/front_end/ui/components/buttons/Button.ts +19 -1
  128. package/front_end/ui/legacy/ContextMenu.ts +16 -1
  129. package/front_end/ui/legacy/PlusButton.ts +5 -6
  130. package/front_end/ui/legacy/Treeoutline.ts +6 -0
  131. package/front_end/ui/legacy/Widget.ts +33 -0
  132. package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts +3 -0
  133. package/front_end/ui/legacy/components/data_grid/DataGridElement.ts +14 -4
  134. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +36 -32
  135. package/front_end/ui/visual_logging/KnownContextValues.ts +4 -0
  136. package/package.json +1 -1
  137. package/.agents/skills/devtools-ci/SKILL.md +0 -65
  138. package/.agents/skills/evaluate-ai-css-completion/SKILL.md +0 -143
  139. package/.agents/skills/evaluate-ai-css-completion/scripts/evaluate.js +0 -104
  140. package/.agents/skills/fixing-skipped-tests/SKILL.md +0 -32
  141. package/.agents/skills/gerrit-cli/SKILL.md +0 -74
  142. package/.agents/skills/gerrit-cli/references/commands.md +0 -169
  143. package/.agents/skills/gerrit-cli/references/workflows.md +0 -63
  144. package/.agents/skills/gerrit-cli/scripts/import_upstream.py +0 -85
  145. package/front_end/models/issues_manager/descriptions/cookieExcludeBlockedWithinRelatedWebsiteSet.md +0 -4
@@ -21,13 +21,10 @@ export interface AIv2MarkdownRendererOptions {
21
21
  mainFrameId?: string;
22
22
  mainDocumentURL?: Platform.DevToolsPath.UrlString;
23
23
  /**
24
- * Retrieves the established origin locked for the active conversation.
24
+ * Retrieves the origin lock for the active conversation.
25
25
  * Required to authorize #file-<id> links and prevent cross-origin file leakage.
26
- *
27
- * TODO(crbug.com/559522248): Defer renderer instantiation until a conversation
28
- * starts so this origin can be passed as a mandatory, non-getter property.
29
26
  */
30
- getEstablishedOrigin?: () => SDK.SecurityOrigin.SecurityOrigin | undefined;
27
+ getOriginLock: () => AiAssistanceModel.Tool.OriginLockState;
31
28
  lookupTraceEvent?: (key: string) => Trace.Types.Events.Event | null;
32
29
  }
33
30
 
@@ -45,7 +42,7 @@ type ParsedLink = {
45
42
  * the only markdown renderer used by AI assistance.
46
43
  */
47
44
  export class AIv2MarkdownRenderer extends MarkdownView.MarkdownView.MarkdownInsightRenderer {
48
- constructor(private readonly options: AIv2MarkdownRendererOptions = {}) {
45
+ constructor(private readonly options: AIv2MarkdownRendererOptions) {
49
46
  super();
50
47
  }
51
48
 
@@ -119,10 +116,7 @@ export class AIv2MarkdownRenderer extends MarkdownView.MarkdownView.MarkdownInsi
119
116
  }
120
117
  if (href.startsWith('#file-')) {
121
118
  const fileId = Number(href.substring(6));
122
- const origin = this.options.getEstablishedOrigin?.();
123
- const file = (origin && Number.isInteger(fileId) && fileId > 0) ?
124
- AiAssistanceModel.ListSources.ListSourcesTool.getSourceById(fileId, origin) :
125
- undefined;
119
+ const file = AiAssistanceModel.ListSources.ListSourcesTool.getSourceById(fileId, this.options.getOriginLock());
126
120
 
127
121
  if (file) {
128
122
  return this.#revealableLink(file, file.name());
@@ -72,7 +72,7 @@ const UIStrings = {
72
72
  /**
73
73
  * @description Empty buffer hint text content in the animation timeline of the Animations panel that explains the panel.
74
74
  */
75
- animationDescription: 'On this page you can inspect and modify animations.',
75
+ animationDescription: 'On this page you can inspect and modify animations',
76
76
  /**
77
77
  * @description Tooltip text that appears when hovering over largeicon replay animation button in the animation timeline of the Animations panel.
78
78
  */
@@ -20,7 +20,7 @@ const UIStrings = {
20
20
  /**
21
21
  * @description Placeholder text when no context is detected.
22
22
  */
23
- noContext: 'No context entries detected across frames.',
23
+ noContext: 'No context entries detected across frames',
24
24
  /**
25
25
  * @description Fallback label when a frame has no URL.
26
26
  */
@@ -289,7 +289,7 @@ const populateContextMenu = (e: CustomEvent<UI.ContextMenu.ContextMenu>): void =
289
289
  const renderDataGrid = (input: IndexedDBDataViewInput): LitTemplate => {
290
290
  const keyPath = input.isIndex && input.index ? input.index.keyPath : input.objectStore.keyPath;
291
291
  // clang-format off
292
- return html`<devtools-data-grid row-height="auto" striped style="flex: auto;" name=${i18nString(UIStrings.indexedDb)} .template=${html`
292
+ return html`<devtools-data-grid row-height="auto" striped deletable style="flex: auto;" name=${i18nString(UIStrings.indexedDb)} .template=${html`
293
293
  <style>${indexedDBViewsStyles}</style>
294
294
  <table>
295
295
  <tr>
@@ -153,6 +153,7 @@ export abstract class KeyValueStorageItemsView extends UI.Widget.VBox {
153
153
  <devtools-data-grid
154
154
  .name=${`${id}-datagrid-with-preview`}
155
155
  striped
156
+ deletable
156
157
  style="flex: auto"
157
158
  @sort=${(e: CustomEvent<{columnId: string, ascending: boolean}>) => input.onSort(e.detail.ascending)}
158
159
  @refresh=${input.onRefresh}
@@ -23,6 +23,12 @@ const {html} = Lit;
23
23
  const {repeat} = Lit.Directives;
24
24
  const {bindToSetting} = UI.UIUtils;
25
25
 
26
+ const DENSITY_DOC_URL = 'https://developer.chrome.com/docs/ads/metrics/density';
27
+ const COUNT_DOC_URL = 'https://developer.chrome.com/docs/ads/metrics/count';
28
+ const CPU_USAGE_DOC_URL = 'https://developer.chrome.com/docs/ads/metrics/weight-cpu';
29
+ const NETWORK_USAGE_DOC_URL = 'https://developer.chrome.com/docs/ads/metrics/weight-network';
30
+ const AD_DETECTION_DOC_URL = 'https://developer.chrome.com/docs/ads/detection';
31
+
26
32
  const UIStrings = {
27
33
  /**
28
34
  * @description Title for the metrics table.
@@ -32,18 +38,34 @@ const UIStrings = {
32
38
  * @description Title for a metric showing the percentage of the viewport covered by ads.
33
39
  */
34
40
  viewportAdDensity: 'Viewport ad density',
41
+ /**
42
+ * @description Tooltip text explaining the viewport ad density metric in the ads view of the Application panel.
43
+ */
44
+ viewportAdDensityExplanation: 'Percentage of the viewport covered by ads',
35
45
  /**
36
46
  * @description Title for a metric showing the number of ads in the viewport.
37
47
  */
38
48
  viewportAdCount: 'Viewport ad count',
49
+ /**
50
+ * @description Tooltip text explaining the viewport ad count metric in the ads view of the Application panel.
51
+ */
52
+ viewportAdCountExplanation: 'Number of ads in the viewport',
39
53
  /**
40
54
  * @description Title for a metric showing the total CPU usage by ads.
41
55
  */
42
56
  totalCpuUsage: 'Total CPU usage by ads',
57
+ /**
58
+ * @description Tooltip text explaining the total CPU usage metric in the ads view of the Application panel.
59
+ */
60
+ totalCpuUsageExplanation: 'Total CPU time consumed by ads',
43
61
  /**
44
62
  * @description Title for a metric showing the total network usage by ads.
45
63
  */
46
64
  totalNetworkUsage: 'Total network usage by ads',
65
+ /**
66
+ * @description Tooltip text explaining the total network usage metric in the ads view of the Application panel.
67
+ */
68
+ totalNetworkUsageExplanation: 'Total network data consumed by ads',
47
69
  /**
48
70
  * @description Subtext showing the average value of a metric.
49
71
  * @example {5.00%} PH1
@@ -231,6 +253,26 @@ const DEFAULT_VIEW: View = (input, output, target) => {
231
253
  });
232
254
  };
233
255
 
256
+ const renderMetricTooltip = (tooltipId: string, explanation: string, url: string): Lit.LitTemplate => {
257
+ return html`
258
+ <devtools-icon
259
+ name="info"
260
+ class="small metric-info-icon"
261
+ tabindex="0"
262
+ role="button"
263
+ aria-details=${tooltipId}
264
+ aria-label=${explanation}
265
+ ></devtools-icon>
266
+ <devtools-tooltip id=${tooltipId} variant="rich" prefer-span-left @copy=${stopPropagation}>
267
+ <span>${explanation}</span>
268
+ &#32;
269
+ <devtools-link href=${url} jslogcontext="learn-more">
270
+ ${i18nString(UIStrings.learnMore)}
271
+ </devtools-link>
272
+ </devtools-tooltip>
273
+ `;
274
+ };
275
+
234
276
  // clang-format off
235
277
  Lit.render(html`
236
278
  <style>${adsViewStyles}</style>
@@ -245,6 +287,11 @@ const DEFAULT_VIEW: View = (input, output, target) => {
245
287
  PH1: formatAverage(metrics.averageViewportAdDensityByArea, true),
246
288
  })}</span>
247
289
  </dd>
290
+ ${renderMetricTooltip(
291
+ 'density-metric-tooltip',
292
+ i18nString(UIStrings.viewportAdDensityExplanation),
293
+ DENSITY_DOC_URL,
294
+ )}
248
295
  </div>
249
296
  <div class="metric-box">
250
297
  <dt class="metric-title">${i18nString(UIStrings.viewportAdCount)}</dt>
@@ -254,18 +301,33 @@ const DEFAULT_VIEW: View = (input, output, target) => {
254
301
  PH1: formatAverage(metrics.averageViewportAdCount, false),
255
302
  })}</span>
256
303
  </dd>
304
+ ${renderMetricTooltip(
305
+ 'count-metric-tooltip',
306
+ i18nString(UIStrings.viewportAdCountExplanation),
307
+ COUNT_DOC_URL,
308
+ )}
257
309
  </div>
258
310
  <div class="metric-box">
259
311
  <dt class="metric-title">${i18nString(UIStrings.totalCpuUsage)}</dt>
260
312
  <dd class="metric-value">
261
313
  <span>${formatCpu(metrics.totalAdCpuTime)}</span>
262
314
  </dd>
315
+ ${renderMetricTooltip(
316
+ 'cpu-metric-tooltip',
317
+ i18nString(UIStrings.totalCpuUsageExplanation),
318
+ CPU_USAGE_DOC_URL,
319
+ )}
263
320
  </div>
264
321
  <div class="metric-box">
265
322
  <dt class="metric-title">${i18nString(UIStrings.totalNetworkUsage)}</dt>
266
323
  <dd class="metric-value">
267
324
  <span>${formatNetwork(metrics.totalAdNetworkBytes)}</span>
268
325
  </dd>
326
+ ${renderMetricTooltip(
327
+ 'network-metric-tooltip',
328
+ i18nString(UIStrings.totalNetworkUsageExplanation),
329
+ NETWORK_USAGE_DOC_URL,
330
+ )}
269
331
  </div>
270
332
  </dl>
271
333
  <hr class="divider">
@@ -374,7 +436,7 @@ const DEFAULT_VIEW: View = (input, output, target) => {
374
436
  <span>
375
437
  ${i18nString(UIStrings.adDetectionMistakes)}
376
438
  &#32;
377
- <devtools-link class="link devtools-link" href="https://chromium.googlesource.com/chromium/src/+/main/docs/ad_tagging.md" jslogcontext="learn-more">
439
+ <devtools-link href=${AD_DETECTION_DOC_URL} jslogcontext="learn-more">
378
440
  ${i18nString(UIStrings.learnMore)}
379
441
  </devtools-link>
380
442
  </span>
@@ -29,17 +29,20 @@
29
29
 
30
30
  .metric-box {
31
31
  background-color: var(--sys-color-surface);
32
- padding: var(--sys-size-6);
32
+ padding: var(--sys-size-4);
33
33
  display: flex;
34
34
  flex-direction: column;
35
35
  align-items: center;
36
36
  justify-content: center;
37
+ position: relative;
37
38
  }
38
39
 
39
40
  .metric-title {
40
41
  font-size: var(--sys-typescale-body4-size);
41
42
  color: var(--sys-color-on-surface-subtle);
42
43
  margin: 0 0 var(--sys-size-3);
44
+ padding: 0 var(--sys-size-8);
45
+ text-align: center;
43
46
  }
44
47
 
45
48
  .metric-value {
@@ -59,6 +62,13 @@
59
62
  color: var(--sys-color-on-surface-subtle);
60
63
  }
61
64
 
65
+ .metric-info-icon {
66
+ position: absolute;
67
+ top: var(--sys-size-4);
68
+ right: var(--sys-size-4);
69
+ cursor: pointer;
70
+ }
71
+
62
72
  .metrics-title,
63
73
  .ad-frames-title,
64
74
  .ad-scripts-title,
@@ -2,24 +2,20 @@
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
4
 
5
- import '../components/tooltips/tooltips.js';
5
+ import '../../ui/components/tooltips/tooltips.js';
6
6
 
7
7
  import * as i18n from '../../core/i18n/i18n.js';
8
8
  import type * as CommentManager from '../../models/comment_manager/comment_manager.js';
9
+ import * as Input from '../../ui/components/input/input.js';
10
+ import * as MarkdownView from '../../ui/components/markdown_view/markdown_view.js';
9
11
  import * as UI from '../../ui/legacy/legacy.js';
10
12
  import * as Lit from '../../ui/lit/lit.js';
11
- import * as Input from '../components/input/input.js';
12
- import * as MarkdownView from '../components/markdown_view/markdown_view.js';
13
13
 
14
14
  import commentThreadWidgetStyles from './commentThreadWidget.css.js';
15
15
 
16
16
  const {html, render, Directives: {createRef, ref}} = Lit;
17
17
 
18
18
  const UIStrings = {
19
- /**
20
- * @description Link text in the info tooltip for learning more about comments sent to the agent.
21
- */
22
- learnMore: 'Learn more',
23
19
  /**
24
20
  * @description Text next to the checkmark in the comment thread header indicating that comments have been sent to
25
21
  * the agent.
@@ -49,10 +45,10 @@ const UIStringsNotTranslate = {
49
45
  * @description Disclaimer text in the comment thread info tooltip.
50
46
  */
51
47
  inputDisclaimer:
52
- 'Comment strings, DOM hierarchy snippets, tracked CSS and DOM changes, Visual Element (VE) paths and signatures, and tracked presenter changes are sent to the connected third-party agent to assist with debugging and code updates.',
48
+ 'Comment strings, DOM hierarchy snippets, tracked CSS and DOM changes, Visual Element (VE) paths and signatures, and tracked presenter changes are sent to the connected third-party agent to assist with debugging and code updates',
53
49
  } as const;
54
50
 
55
- const str_ = i18n.i18n.registerUIStrings('ui/comments/CommentThreadWidget.ts', UIStrings);
51
+ const str_ = i18n.i18n.registerUIStrings('panels/common/CommentThreadWidget.ts', UIStrings);
56
52
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
57
53
  const lockedString = i18n.i18n.lockedString;
58
54
 
@@ -61,7 +57,6 @@ export interface ViewInput {
61
57
  comments: CommentManager.CommentManager.Comment[];
62
58
  commentText: string;
63
59
  textAreaRef: Lit.Directives.Ref<HTMLTextAreaElement>;
64
- onLearnMoreClick: () => void;
65
60
  onAddComment: (text: string) => void;
66
61
  onCommentTextChange: (event: Event) => void;
67
62
  }
@@ -139,11 +134,6 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: ViewOutput, target: HTML
139
134
  >
140
135
  <div class="info-tooltip-container">
141
136
  ${lockedString(UIStringsNotTranslate.inputDisclaimer)}
142
- <button
143
- class="tooltip-link"
144
- role="link"
145
- @click=${input.onLearnMoreClick}
146
- >${i18nString(UIStrings.learnMore)}</button>
147
137
  </div>
148
138
  </devtools-tooltip>
149
139
  <devtools-button
@@ -187,10 +177,6 @@ export class CommentThreadWidget extends UI.Widget.Widget {
187
177
  this.requestUpdate();
188
178
  }
189
179
 
190
- #handleLearnMoreClick = (): void => {
191
- // TODO: wire up the learn more click
192
- };
193
-
194
180
  #handleAddComment = (text: string): void => {
195
181
  const commentText = text.trim();
196
182
  if (commentText && this.onAddComment) {
@@ -212,7 +198,6 @@ export class CommentThreadWidget extends UI.Widget.Widget {
212
198
  comments: this.#comments,
213
199
  commentText: this.#commentText,
214
200
  textAreaRef: this.#textAreaRef,
215
- onLearnMoreClick: this.#handleLearnMoreClick,
216
201
  onAddComment: this.#handleAddComment,
217
202
  onCommentTextChange: this.#handleCommentTextChange,
218
203
  };
@@ -5,18 +5,10 @@
5
5
  import type * as Common from '../../core/common/common.js';
6
6
  import * as Root from '../../core/root/root.js';
7
7
  import * as CommentManager from '../../models/comment_manager/comment_manager.js';
8
+ import * as Comments from '../../ui/comments/comments.js';
8
9
  import * as UI from '../../ui/legacy/legacy.js';
9
10
  import * as Lit from '../../ui/lit/lit.js';
10
11
 
11
- import {
12
- CommentOverlayManager,
13
- Events as CommentOverlayManagerEvents,
14
- type HighlightRectData,
15
- type HoverHighlightData,
16
- type PendingHighlightRectData,
17
- type PendingPinPositionData,
18
- type PinPositionData,
19
- } from './CommentOverlayManager.js';
20
12
  import commentsOverlayStyles from './commentsOverlay.css.js';
21
13
  import {CommentThreadWidget} from './CommentThreadWidget.js';
22
14
 
@@ -27,18 +19,14 @@ const {
27
19
  Directives: {repeat, styleMap},
28
20
  } = Lit;
29
21
 
30
- export type ViewHighlightRectData = HighlightRectData|PendingHighlightRectData;
31
-
32
22
  export interface ViewInput {
33
- pins: PinPositionData[];
34
- pendingPin: PendingPinPositionData|null;
35
- highlights: ViewHighlightRectData[];
36
- hoverHighlight: HoverHighlightData|null;
23
+ pins: Comments.CommentOverlayManager.PinPositionData[];
24
+ highlights: Comments.CommentOverlayManager.HighlightRectData[];
25
+ hoverHighlight: Comments.CommentOverlayManager.HoverHighlightData|null;
37
26
  commentMode: boolean;
38
27
  onPinClick: (threadId: string) => void;
39
28
  activeThread: CommentManager.CommentManager.CommentThread|null;
40
- activePin: PinPositionData|PendingPinPositionData|null;
41
- activeTargetKey: unknown;
29
+ activePin: Comments.CommentOverlayManager.PinPositionData|null;
42
30
  onAddComment: (text: string) => void;
43
31
  }
44
32
 
@@ -72,7 +60,6 @@ const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target: HTMLEl
72
60
  ${input.highlights.map(h => h.visible ? html`
73
61
  <div
74
62
  class="comment-anchor-highlight"
75
- data-comment-id=${('id' in h && h.id) || nothing}
76
63
  style=${styleMap({
77
64
  top: `${h.top}px`,
78
65
  left: `${h.left}px`,
@@ -81,20 +68,9 @@ const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target: HTMLEl
81
68
  })}>
82
69
  </div>
83
70
  ` : nothing)}
84
- ${input.pendingPin && input.pendingPin.visible ? html`
85
- <div
86
- class="comment-pin"
87
- style=${styleMap({
88
- top: `${input.pendingPin.top}px`,
89
- left: `${input.pendingPin.left}px`,
90
- })}>
91
- <div class="comment-cursor">${input.pendingPin.index}</div>
92
- </div>
93
- ` : nothing}
94
71
  ${input.pins.map(p => p.visible ? html`
95
72
  <div
96
73
  class="comment-pin"
97
- data-comment-id=${p.id}
98
74
  style=${styleMap({
99
75
  top: `${p.top}px`,
100
76
  left: `${p.left}px`,
@@ -103,9 +79,9 @@ const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target: HTMLEl
103
79
  <div class="comment-cursor">${p.index}</div>
104
80
  </div>
105
81
  ` : nothing)}
106
- ${input.activePin ? repeat(
107
- [{pin: input.activePin, key: input.activeTargetKey}],
108
- item => item.key,
82
+ ${input.activePin && input.activeThread ? repeat(
83
+ [{pin: input.activePin, thread: input.activeThread}],
84
+ item => item.thread.id,
109
85
  item => html`
110
86
  <div
111
87
  class="comment-popup-widget"
@@ -120,7 +96,7 @@ const DEFAULT_VIEW: View = (input: ViewInput, _output: undefined, target: HTMLEl
120
96
  )}px`,
121
97
  })}>
122
98
  ${UI.Widget.widget(CommentThreadWidget, {
123
- comments: input.activeThread ? [...input.activeThread.comments] : [],
99
+ comments: [...item.thread.comments],
124
100
  onAddComment: input.onAddComment,
125
101
  })}
126
102
  </div>
@@ -137,7 +113,7 @@ export class CommentsOverlayWidget extends UI.Widget.Widget {
137
113
 
138
114
  readonly #view: View;
139
115
  readonly #commentManager: CommentManager.CommentManager.CommentManager;
140
- #commentOverlayManager: CommentOverlayManager;
116
+ #commentOverlayManager: Comments.CommentOverlayManager.CommentOverlayManager;
141
117
  #activeThreadId: string|null = null;
142
118
 
143
119
  constructor(
@@ -148,12 +124,12 @@ export class CommentsOverlayWidget extends UI.Widget.Widget {
148
124
  super(element, {useShadowDom: false});
149
125
  this.#view = view;
150
126
  this.#commentManager = commentManager;
151
- this.#commentOverlayManager = new CommentOverlayManager(
127
+ this.#commentOverlayManager = new Comments.CommentOverlayManager.CommentOverlayManager(
152
128
  this.#commentManager,
153
129
  );
154
130
  }
155
131
 
156
- setOverlayManagerForTest(overlayManager: CommentOverlayManager): void {
132
+ setOverlayManagerForTest(overlayManager: Comments.CommentOverlayManager.CommentOverlayManager): void {
157
133
  this.#commentOverlayManager = overlayManager;
158
134
  }
159
135
 
@@ -161,12 +137,12 @@ export class CommentsOverlayWidget extends UI.Widget.Widget {
161
137
  super.wasShown();
162
138
  this.#commentOverlayManager.start();
163
139
  this.#commentOverlayManager.addEventListener(
164
- CommentOverlayManagerEvents.POSITIONS_UPDATED,
140
+ Comments.CommentOverlayManager.Events.POSITIONS_UPDATED,
165
141
  this.#onStateChanged,
166
142
  this,
167
143
  );
168
144
  this.#commentOverlayManager.addEventListener(
169
- CommentOverlayManagerEvents.HOVER_HIGHLIGHT_CHANGED,
145
+ Comments.CommentOverlayManager.Events.HOVER_HIGHLIGHT_CHANGED,
170
146
  this.#onStateChanged,
171
147
  this,
172
148
  );
@@ -188,12 +164,12 @@ export class CommentsOverlayWidget extends UI.Widget.Widget {
188
164
  override willHide(): void {
189
165
  this.#commentOverlayManager.stop();
190
166
  this.#commentOverlayManager.removeEventListener(
191
- CommentOverlayManagerEvents.POSITIONS_UPDATED,
167
+ Comments.CommentOverlayManager.Events.POSITIONS_UPDATED,
192
168
  this.#onStateChanged,
193
169
  this,
194
170
  );
195
171
  this.#commentOverlayManager.removeEventListener(
196
- CommentOverlayManagerEvents.HOVER_HIGHLIGHT_CHANGED,
172
+ Comments.CommentOverlayManager.Events.HOVER_HIGHLIGHT_CHANGED,
197
173
  this.#onStateChanged,
198
174
  this,
199
175
  );
@@ -217,6 +193,9 @@ export class CommentsOverlayWidget extends UI.Widget.Widget {
217
193
  CommentManager.CommentManager.EventTypes[CommentManager.CommentManager.Events.COMMENT_MODE_CHANGED]>,
218
194
  ): void {
219
195
  const isModeActive = event.data;
196
+ if (!isModeActive) {
197
+ this.#activeThreadId = null;
198
+ }
220
199
  const action = UI.ActionRegistry.ActionRegistry.instance().getAction(
221
200
  'comments.toggle-comment-mode',
222
201
  );
@@ -225,17 +204,24 @@ export class CommentsOverlayWidget extends UI.Widget.Widget {
225
204
  }
226
205
 
227
206
  #onStateChanged(): void {
228
- if (this.#commentOverlayManager.getPendingDraft()) {
207
+ const draftThread = this.#commentManager.getCommentThreads().find(t => t.status === 'DRAFT');
208
+ if (draftThread) {
209
+ this.#activeThreadId = draftThread.id;
210
+ } else if (this.#activeThreadId && !this.#commentManager.getCommentThread(this.#activeThreadId)) {
229
211
  this.#activeThreadId = null;
230
212
  }
231
213
  this.requestUpdate();
232
214
  }
233
215
 
234
216
  #handlePinClick = (threadId: string): void => {
235
- this.#commentOverlayManager.clearPendingAnchor();
217
+ const thread = this.#commentManager.getCommentThread(threadId);
236
218
  if (this.#activeThreadId === threadId) {
219
+ if (thread?.status === 'DRAFT') {
220
+ this.#commentOverlayManager.clearDraftThreads();
221
+ }
237
222
  this.#activeThreadId = null;
238
223
  } else {
224
+ this.#commentOverlayManager.clearDraftThreads();
239
225
  this.#activeThreadId = threadId;
240
226
  }
241
227
  this.requestUpdate();
@@ -243,41 +229,25 @@ export class CommentsOverlayWidget extends UI.Widget.Widget {
243
229
 
244
230
  override performUpdate(): void {
245
231
  const pins = this.#commentOverlayManager.getPinPositions();
246
- const draft = this.#commentOverlayManager.getPendingDraft();
247
- const pendingPin = draft?.pin ?? null;
248
- const highlights: ViewHighlightRectData[] = [
249
- ...this.#commentOverlayManager.getHighlightRects(),
250
- ];
251
-
252
- if (draft?.highlight) {
253
- highlights.push(draft.highlight);
254
- }
232
+ const highlights = this.#commentOverlayManager.getHighlightRects();
255
233
 
256
- let activePin: PinPositionData|PendingPinPositionData|null = null;
234
+ let activePin: Comments.CommentOverlayManager.PinPositionData|null = null;
257
235
  let activeThread: CommentManager.CommentManager.CommentThread|null = null;
258
- if (pendingPin) {
259
- activePin = pendingPin;
260
- } else if (this.#activeThreadId) {
236
+ if (this.#activeThreadId) {
261
237
  activePin = pins.find(p => p.id === this.#activeThreadId) ?? null;
262
238
  activeThread = this.#commentManager.getCommentThread(this.#activeThreadId) ?? null;
263
239
  }
264
240
 
265
241
  const viewInput: ViewInput = {
266
242
  pins,
267
- pendingPin,
268
243
  highlights,
269
244
  hoverHighlight: this.#commentOverlayManager.getHoverHighlight(),
270
245
  commentMode: this.#commentManager.isCommentMode(),
271
246
  onPinClick: this.#handlePinClick,
272
247
  activeThread,
273
248
  activePin,
274
- activeTargetKey: draft ?? activeThread,
275
249
  onAddComment: (text: string) => {
276
- const pendingDraft = this.#commentOverlayManager.getPendingDraft();
277
-
278
- if (pendingDraft) {
279
- this.#commentOverlayManager.createComment(pendingDraft.element, text, {pendingDraft});
280
- }
250
+ activeThread?.save(text);
281
251
  },
282
252
  };
283
253
  this.#view(viewInput, undefined, this.contentElement);
@@ -313,4 +283,11 @@ export class ActionDelegate implements UI.ActionRegistration.ActionDelegate {
313
283
  }
314
284
  return false;
315
285
  }
286
+
287
+ static resetForTest(): void {
288
+ if (widgetInstance) {
289
+ widgetInstance.detach();
290
+ widgetInstance = null;
291
+ }
292
+ }
316
293
  }
@@ -4,9 +4,9 @@
4
4
 
5
5
  import * as i18n from '../../core/i18n/i18n.js';
6
6
  import * as CommentManager from '../../models/comment_manager/comment_manager.js';
7
- import * as UI from '../legacy/legacy.js';
8
- import * as Lit from '../lit/lit.js';
9
- import * as VisualLogging from '../visual_logging/visual_logging.js';
7
+ import * as UI from '../../ui/legacy/legacy.js';
8
+ import * as Lit from '../../ui/lit/lit.js';
9
+ import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
10
10
 
11
11
  const UIStrings = {
12
12
  /**
@@ -15,7 +15,7 @@ const UIStrings = {
15
15
  */
16
16
  commentsCount: 'Comments ({PH1})',
17
17
  } as const;
18
- const str_ = i18n.i18n.registerUIStrings('ui/comments/CommentsStatusBarPill.ts', UIStrings);
18
+ const str_ = i18n.i18n.registerUIStrings('panels/common/CommentsStatusBarPill.ts', UIStrings);
19
19
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
20
20
 
21
21
  const {html, render} = Lit;
@@ -86,7 +86,7 @@ export class CommentsStatusBarPill extends UI.Widget.Widget {
86
86
 
87
87
  override performUpdate(): void {
88
88
  const viewInput: ViewInput = {
89
- threads: this.#commentManager.getCommentThreads(),
89
+ threads: this.#commentManager.getCommentThreads().filter(thread => thread.status !== 'DRAFT'),
90
90
  onPillClick: this.#handlePillClick,
91
91
  };
92
92
  this.#view(viewInput, undefined, this.contentElement);
@@ -1287,7 +1287,8 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
1287
1287
  if (scriptFiles.length > 0) {
1288
1288
  for (const script of scriptFiles) {
1289
1289
  const resourceFile = debuggerBindingsInstance.scriptFile(resource.uiSourceCode, script.debuggerModel);
1290
- resourceFile?.addSourceMapURL(message.sourceMapURL as Platform.DevToolsPath.UrlString);
1290
+ resourceFile?.addSourceMapURL(message.sourceMapURL as Platform.DevToolsPath.UrlString,
1291
+ SDK.SourceMap.SourceMapProvenance.EXTENSION);
1291
1292
  }
1292
1293
  }
1293
1294
 
@@ -153,18 +153,6 @@
153
153
  padding: var(--sys-size-4) var(--sys-size-5);
154
154
  }
155
155
 
156
- .tooltip-link {
157
- display: block;
158
- margin-top: var(--sys-size-4);
159
- color: var(--sys-color-primary);
160
- padding-left: 0;
161
- background: none;
162
- border: none;
163
- font: inherit;
164
- text-decoration: underline;
165
- cursor: pointer;
166
- }
167
-
168
156
  .selected-item-text {
169
157
  overflow: hidden;
170
158
  white-space: nowrap;
@@ -10,7 +10,8 @@
10
10
  position: fixed;
11
11
  inset: 0;
12
12
  pointer-events: none;
13
- /* Needs to be above regular panel widgets (e.g. flame chart at z-index 2000) but below floating glass panes (which start at z-index 3000). */
13
+ /* Needs to be above regular panel widgets (e.g. flame chart at z-index 2000)
14
+ but below floating glass panes (which start at z-index 3000). */
14
15
  z-index: 2500;
15
16
  overflow: hidden;
16
17
  width: 100vw;