chrome-devtools-frontend 1.0.1689415 → 1.0.1690531

package/front_end/core/sdk/SecurityOrigin.ts

@@ -2,47 +2,182 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as Common from '../common/common.js';
+import type * as Platform from '../platform/platform.js';
+
+/**
+ * Internal representation of a security origin:
+ * - `origin`: A comparable origin string (`<scheme>://<host>[:<port>]` or path-scoped `file://<host>/<path>`).
+ * - `opaque`: An isolated opaque origin uniquely identified by a UUID that never matches any other origin.
+ */
+type InternalOrigin =
+    |{readonly type: 'origin', readonly value: string}|{readonly type: 'opaque', readonly uuid: string};
+
+/** Exact string matches that represent an invalid or opaque origin. */
+const OPAQUE_EXACT_MATCHES = new Set([
+  '',
+  'null',
+  'undefined',
+  'data:',
+  'detached',
+]);
+
+/** String prefixes for origins that must be treated as opaque (e.g. `about:blank`, `blob:data`). */
+const OPAQUE_PREFIXES = [
+  'about:',
+  'blob:about',
+  'blob:data',
+  'blob:null',
+] as const;
+
+/**
+ * String prefixes for imported artifact schemes (e.g., HAR recordings, traces).
+ * Imported entities operate in an isolated origin domain (`imported-har://${domain}`)
+ * that never matches live web origins (`https://${domain}`).
+ */
+export const IMPORTED_ORIGIN_PREFIXES: ReadonlySet<string> = new Set([
+  'imported-har:',
+]);
+
+function isOpaqueUrlString(url: string): boolean {
+  const lower = url.trim().toLowerCase();
+  if (OPAQUE_EXACT_MATCHES.has(lower)) {
+    return true;
+  }
+  return OPAQUE_PREFIXES.some(prefix => lower.startsWith(prefix));
+}
+
+/**
+ * An immutable security origin for an entity in DevTools (such as a document,
+ * network request, or storage key).
+ *
+ * DevTools features that handle user data or execute commands on behalf of the user
+ * (such as DevTools AI Assistance and Extensions) must enforce strict origin boundaries
+ * to prevent prompt injection and cross-origin data exfiltration.
+ *
+ * This class serves as the single source of truth for origin comparison and classification:
+ *
+ * 1. **Standard Origins**: Web URLs (HTTP, HTTPS, WSS) resolve to `<scheme>://<host>[:<port>]`.
+ *    Two standard origins are same-origin if their scheme, host, and port match.
+ *
+ * 2. **File URLs (`file://`)**: In the WHATWG web security model, `file://` URLs are assigned
+ *    opaque origins. In DevTools, however, users frequently debug local files (`file:///path/index.html`).
+ *    Treating all `file://` URLs as opaque would block the user from inspecting elements or styles within
+ *    the same file. Conversely, treating all `file://` URLs as a single shared origin would allow a malicious
+ *    local file to traverse into other local files via iframes (b/524362513).
+ *    Therefore, DevTools treats `file://` URLs as **path-scoped origins** (`file://<authority><path>`).
+ *    `isOpaque()` returns `false` for `file://` URLs, and two `file://` URLs are considered same-origin
+ *    only if their full file path and host match exactly.
+ *
+ * 3. **Opaque Origins**: Opaque contexts (`data:`, `about:blank`, invalid URLs, or synthetic
+ *    opaque origins) are backed by unique UUIDs. An opaque origin never matches any other origin,
+ *    even another opaque origin created from the same URL string.
+ */
 export class SecurityOrigin {
-  #urlOrigin?: string;
-  #opaqueUuid?: string;
+  readonly #origin: InternalOrigin;
 
-  private constructor(urlOrigin?: string, opaqueUuid?: string) {
-    this.#urlOrigin = urlOrigin;
-    this.#opaqueUuid = opaqueUuid;
+  private constructor(origin: InternalOrigin) {
+    this.#origin = origin;
   }
 
-  static create(urlOrigin: string): SecurityOrigin {
-    return new SecurityOrigin(urlOrigin, undefined);
+  /**
+   * Creates a `SecurityOrigin` instance from a raw URL or origin string.
+   *
+   * - If the URL is determined to be opaque (e.g. `data:`, `about:blank`, empty, `null`),
+   *   a new unique opaque origin is returned.
+   * - If the URL is a `file://` URL, a path-scoped origin (`file://<authority><path>`) is returned.
+   * - Otherwise, the standard origin (`<scheme>://<host>[:<port>]`) is extracted and returned.
+   *
+   * @param rawUrl The raw URL or origin string to evaluate.
+   */
+  static create(rawUrl: string): SecurityOrigin {
+    if (isOpaqueUrlString(rawUrl)) {
+      return SecurityOrigin.createUniqueOpaque();
+    }
+
+    // Custom imported schemes (e.g. `imported-har:`) are not supported by standard URL parsers.
+    // We extract the host to construct a domain-scoped origin (`imported-har://${host}`).
+    // This isolates imported artifacts from live web pages (`imported-har://example.com` != `https://example.com`),
+    // while enabling same-origin comparison between requests within the same imported session domain.
+    for (const prefix of IMPORTED_ORIGIN_PREFIXES) {
+      if (rawUrl.toLowerCase().startsWith(prefix)) {
+        const afterScheme = rawUrl.substring(prefix.length).replace(/^\/+/, '');
+        const slashIndex = afterScheme.indexOf('/');
+        const host = slashIndex === -1 ? afterScheme : afterScheme.substring(0, slashIndex);
+        if (!host) {
+          return SecurityOrigin.createUniqueOpaque();
+        }
+        return new SecurityOrigin({type: 'origin', value: `${prefix}//${host.toLowerCase()}`});
+      }
+    }
+
+    if (rawUrl.toLowerCase().startsWith('file://')) {
+      const parsed = Common.ParsedURL.ParsedURL.fromString(rawUrl as Platform.DevToolsPath.UrlString);
+      if (!parsed) {
+        return SecurityOrigin.createUniqueOpaque();
+      }
+      const authority = parsed.host + (parsed.port ? ':' + parsed.port : '');
+      return new SecurityOrigin({type: 'origin', value: `file://${authority}${parsed.path}`});
+    }
+
+    const origin = Common.ParsedURL.ParsedURL.extractOrigin(rawUrl as Platform.DevToolsPath.UrlString);
+    if (!origin || isOpaqueUrlString(origin)) {
+      return SecurityOrigin.createUniqueOpaque();
+    }
+
+    return new SecurityOrigin({type: 'origin', value: origin});
   }
 
+  /**
+   * Creates a synthetic, unique opaque origin.
+   *
+   * Useful when an entity (like a sandboxed iframe or detached DOM tree) needs an
+   * isolated origin that will never match any other origin in the session.
+   */
   static createUniqueOpaque(): SecurityOrigin {
-    return new SecurityOrigin(undefined, crypto.randomUUID());
+    return new SecurityOrigin({type: 'opaque', uuid: crypto.randomUUID()});
   }
 
-  isSameOriginWith(other: SecurityOrigin): boolean {
-    if (this.#opaqueUuid || other.#opaqueUuid) {
-      return this.#opaqueUuid === other.#opaqueUuid;
-    }
-    if (this.isOpaque() || other.isOpaque()) {
+  /**
+   * Checks whether this security origin is equivalent to another security origin.
+   *
+   * - Standard origins return `true` if their scheme, host, and port match.
+   * - File origins return `true` if their full file path and host match.
+   * - Opaque origins return `true` only if both instances have identical UUIDs.
+   * - Passing `null` always returns `false`.
+   *
+   * @param other The other `SecurityOrigin` to compare with.
+   */
+  isSameOriginWith(other: SecurityOrigin|null): boolean {
+    if (!other) {
       return false;
     }
-    return this.#urlOrigin === other.#urlOrigin && this.#urlOrigin !== undefined;
+    if (this.#origin.type === 'opaque' || other.#origin.type === 'opaque') {
+      return this.#origin.type === 'opaque' && other.#origin.type === 'opaque' &&
+          this.#origin.uuid === other.#origin.uuid;
+    }
+    return this.#origin.value === other.#origin.value;
   }
 
+  /**
+   * Returns whether this origin is opaque.
+   *
+   * Opaque origins include `data:` URLs, `about:blank`, invalid URLs, and instances
+   * created via `createUniqueOpaque()`.
+   */
   isOpaque(): boolean {
-    if (this.#opaqueUuid !== undefined) {
-      return true;
-    }
-    if (this.#urlOrigin) {
-      const lower = this.#urlOrigin.toLowerCase();
-      return lower === '' || lower === 'null' || lower === 'data:' || lower.startsWith('about') ||
-          lower.startsWith('blob:about') || lower.startsWith('blob:data') || lower.startsWith('blob:null') ||
-          lower.startsWith('detached') || lower.startsWith('undefined');
-    }
-    return false;
+    return this.#origin.type === 'opaque';
   }
 
+  /**
+   * Returns a stable string representation of this origin for identification, storage keys,
+   * or debugging logs.
+   *
+   * - For standard origins, returns the serialized origin string (e.g. `https://example.com:8080`).
+   * - For file origins, returns the path-scoped origin (e.g. `file:///path/to/file.html`).
+   * - For opaque origins, returns the unique UUID string.
+   */
   siteId(): string {
-    return this.#opaqueUuid ?? (this.#urlOrigin ?? 'unknown-origin');
+    return this.#origin.type === 'opaque' ? this.#origin.uuid : this.#origin.value;
   }
 }

package/front_end/core/sdk/Target.ts

@@ -6,7 +6,6 @@ import type * as Protocol from '../../generated/protocol.js';
 import * as Common from '../common/common.js';
 import * as Platform from '../platform/platform.js';
 import * as ProtocolClient from '../protocol_client/protocol_client.js';
-import * as Root from '../root/root.js';
 
 import {SDKModel, type SDKModelConstructor} from './SDKModel.js';
 import type {TargetManager} from './TargetManager.js';
@@ -50,10 +49,7 @@ export class Target extends ProtocolClient.InspectorBackend.TargetBase {
         this.#capabilitiesMask = Capability.BROWSER | Capability.STORAGE | Capability.DOM | Capability.JS |
             Capability.LOG | Capability.NETWORK | Capability.TARGET | Capability.TRACING | Capability.EMULATION |
             Capability.INPUT | Capability.INSPECTOR | Capability.AUDITS | Capability.WEB_AUTHN | Capability.IO |
-            Capability.MEDIA | Capability.EVENT_BREAKPOINTS | Capability.DOM_STORAGE;
-        if (Root.Runtime.hostConfig.devToolsWebMCPSupport?.enabled) {
-          this.#capabilitiesMask |= Capability.WEB_MCP;
-        }
+            Capability.MEDIA | Capability.EVENT_BREAKPOINTS | Capability.DOM_STORAGE | Capability.WEB_MCP;
         if (parentTarget?.type() !== Type.FRAME) {
           // This matches backend exposing certain capabilities only for the main frame.
           this.#capabilitiesMask |=

package/front_end/core/sdk/sdk.ts

@@ -58,6 +58,7 @@ import * as LayerTreeBase from './LayerTreeBase.js';
 import * as LogModel from './LogModel.js';
 import * as NetworkManager from './NetworkManager.js';
 import * as NetworkRequest from './NetworkRequest.js';
+import * as NetworkRequestAccess from './NetworkRequestAccess.js';
 import * as OverlayColorGenerator from './OverlayColorGenerator.js';
 import * as OverlayModel from './OverlayModel.js';
 import * as OverlayPersistentHighlighter from './OverlayPersistentHighlighter.js';
@@ -146,6 +147,7 @@ export {
   LogModel,
   NetworkManager,
   NetworkRequest,
+  NetworkRequestAccess,
   OverlayColorGenerator,
   OverlayModel,
   OverlayPersistentHighlighter,

package/front_end/generated/SupportedCSSProperties.ts

@@ -3790,7 +3790,7 @@ export const generatedProperties: CSSProperty[] = [
  {
   "name": "margin-trim",
   "runtime_flag": "MarginTrim",
-  "runtime_flag_status": "experimental"
+  "runtime_flag_status": "stable"
  },
  {
   "inherited": true,

package/front_end/models/ai_assistance/AiAgent2.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as Host from '../../core/host/host.js';
+import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import type * as LHModel from '../lighthouse/lighthouse.js';
 import type * as Trace from '../trace/trace.js';
@@ -78,7 +79,9 @@ export class AiAgent2 extends AiAgent<unknown> {
   // TODO: The static preamble is a placeholder and will eventually live server-side.
   readonly preamble: string = preamble;
   readonly clientFeature: Host.AidaClient.ClientFeature = Host.AidaClient.ClientFeature.CHROME_DEVTOOLS_V2_AGENT;
-  readonly userTier: string = 'TESTERS';
+  get userTier(): string|undefined {
+    return Root.Runtime.hostConfig.devToolsAiV2Architecture?.userTier;
+  }
 
   #changes: ChangeManager;
   #execJs: typeof executeJsCode;

package/front_end/models/ai_assistance/AiConversation.ts

@@ -1,7 +1,6 @@
 // Copyright 2024 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
@@ -46,14 +45,13 @@ export const NOT_FOUND_IMAGE_DATA = '';
 export const CONTEXT_TITLE = 'Analyzing data';
 const MAX_TITLE_LENGTH = 80;
 /**
- * List of page navigations that are allowed during an AI agent run.
- * These are page navigations triggered by agents themselves:
- * - `about://` : Navigated to before initiating a trace recording to ensure a clean state.
- * - `chrome://terms`: Navigated to by Lighthouse during its Back-Forward Cache
- *    audit.
+ * Page URL prefixes permitted during an AI agent run.
+ * Agents trigger these navigations internally:
+ * - `about:blank`: Used before recording a performance trace to ensure a clean state.
+ * - `chrome://terms`: Used by Lighthouse during Back-Forward Cache audits.
  */
 export const ALLOWED_PAGE_NAVIGATIONS: Platform.DevToolsPath.UrlString[] = [
-  Platform.DevToolsPath.urlString`about://`,
+  Platform.DevToolsPath.urlString`about:blank`,
   Platform.DevToolsPath.urlString`chrome://terms`,
 ];
 
@@ -431,14 +429,17 @@ export class AiConversation {
           } = {},
           ): AsyncGenerator<ResponseData, void, void> {
     this.#navigationOccurredDuringRun = false;
-    const originAtRunStart = getPrimaryPageOrigin(this.#targetManager);
+    const originAtRunStart = getPrimaryPageSecurityOrigin(this.#targetManager);
     const listener = (): void => {
-      // If an unexpected navigation to a different origin occurred
-      // during processing the user's request, we don't want to allow
-      // the agent to run any function calls and retrieve data from the new origin.
-      // Performance agent and accessibility agent navigate to 'about://' or 'chrome://terms'
-      const newOrigin = getPrimaryPageOrigin(this.#targetManager);
-      if (originAtRunStart !== newOrigin && newOrigin && !ALLOWED_PAGE_NAVIGATIONS.includes(newOrigin)) {
+      // Prevent the agent from executing tools or reading data from an untrusted origin
+      // if the page navigates unexpectedly during execution.
+      const newInspectedURL = this.#targetManager.primaryPageTarget()?.inspectedURL();
+      const newOrigin = newInspectedURL ? SDK.SecurityOrigin.SecurityOrigin.create(newInspectedURL) : undefined;
+      const isSameOrigin = Boolean(originAtRunStart && newOrigin && originAtRunStart.isSameOriginWith(newOrigin));
+      const isAllowedNavigation =
+          Boolean(newInspectedURL && ALLOWED_PAGE_NAVIGATIONS.some(allowed => newInspectedURL.startsWith(allowed)));
+
+      if (!isSameOrigin && !isAllowedNavigation) {
         this.#navigationOccurredDuringRun = true;
       }
     };
@@ -551,6 +552,10 @@ export class AiConversation {
     return this.#type;
   }
 
+  /**
+   * Returns the permitted origin for agent tool execution, or blocks execution
+   * if an unapproved cross-origin navigation occurred during the current run.
+   */
   allowedOrigin = (): AllowedOriginResult => {
     if (this.#navigationOccurredDuringRun) {
       return {blocked: true};
@@ -558,7 +563,7 @@ export class AiConversation {
     if (this.#origin) {
       return {origin: this.origin};
     }
-    this.#origin = getPrimaryPageOrigin(this.#targetManager);
+    this.#origin = getPrimaryPageSecurityOrigin(this.#targetManager);
 
     return {origin: this.origin};
   };
@@ -574,10 +579,16 @@ function isAiAssistanceServerSideLoggingAllowed(): boolean {
   return !Root.Runtime.hostConfig.aidaAvailability?.disallowLogging;
 }
 
-function getPrimaryPageOrigin(
+/**
+ * Returns the security origin of the primary page target.
+ *
+ * @param targetManager Target manager used to locate the primary page target.
+ * @returns The parsed SecurityOrigin, or undefined if no target or inspected URL exists.
+ */
+function getPrimaryPageSecurityOrigin(
     targetManager: SDK.TargetManager.TargetManager,
-    ): Platform.DevToolsPath.UrlString|undefined {
+    ): SDK.SecurityOrigin.SecurityOrigin|undefined {
   const target = targetManager.primaryPageTarget();
   const inspectedURL = target?.inspectedURL();
-  return inspectedURL ? new Common.ParsedURL.ParsedURL(inspectedURL).securityOrigin() : undefined;
+  return inspectedURL ? SDK.SecurityOrigin.SecurityOrigin.create(inspectedURL) : undefined;
 }

package/front_end/models/ai_assistance/AiUtils.ts

@@ -5,7 +5,6 @@
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
-import type * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 
 import {debugLog} from './debug.js';
@@ -187,15 +186,6 @@ export function getIconName(): string {
   return isGeminiBranding() ? 'spark' : 'smart-assistant';
 }
 
-export function isSameOrigin(url1: Platform.DevToolsPath.UrlString, url2: Platform.DevToolsPath.UrlString): boolean {
-  if (url1.startsWith('data:') || url2.startsWith('data:')) {
-    return url1 === url2;
-  }
-  const origin1 = Common.ParsedURL.ParsedURL.extractOrigin(url1);
-  const origin2 = Common.ParsedURL.ParsedURL.extractOrigin(url2);
-  return origin1 !== '' && origin1 === origin2;
-}
-
 export interface OneShotPromptRequest {
   aidaClient: Host.AidaClient.AidaClient;
   preamble: string;

package/front_end/models/ai_assistance/agents/AccessibilityAgent.ts

@@ -4,11 +4,9 @@
 
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
 import type * as LHModel from '../../lighthouse/lighthouse.js';
-import {isSameOrigin} from '../AiUtils.js';
 import {ChangeManager} from '../ChangeManager.js';
 import {LighthouseFormatter} from '../data_formatters/LighthouseFormatter.js';
 import {debugLog} from '../debug.js';
@@ -155,11 +153,15 @@ export class AccessibilityAgent extends AiAgent<LHModel.ReporterTypes.ReportJSON
       return;
     }
 
-    const details = await lhr.getUserFacingDetails();
+    const [details, widgets] = await Promise.all([
+      lhr.getUserFacingDetails(),
+      lhr.getWidgets(),
+    ]);
     if (details) {
       yield {
         type: ResponseType.CONTEXT,
         details,
+        widgets,
       };
     }
   }
@@ -183,13 +185,7 @@ export class AccessibilityAgent extends AiAgent<LHModel.ReporterTypes.ReportJSON
     }
 
     const mainDocument = domModel.existingDocument();
-    if (!mainDocument) {
-      return null;
-    }
-    const mainDocumentURL = mainDocument.documentURL;
-    const nodeDocumentURL = node.ownerDocument?.documentURL ?? '' as Platform.DevToolsPath.UrlString;
-
-    if (!isSameOrigin(mainDocumentURL, nodeDocumentURL)) {
+    if (!mainDocument || !mainDocument.securityOrigin().isSameOriginWith(node.securityOrigin())) {
       return null;
     }
 

package/front_end/models/ai_assistance/agents/StylingAgent.ts

@@ -94,7 +94,6 @@ const MULTIMODAL_ENHANCEMENT_PROMPTS: Record<MultimodalInputType, string> = {
   [MultimodalInputType.UPLOADED_IMAGE]: promptForUploadedImage + considerationsForMultimodalInputEvaluation,
 };
 
-// eslint-disable-next-line @typescript-eslint/no-inferrable-types
 export const AI_ASSISTANCE_FILTER_REGEX: string = `\\.${AI_ASSISTANCE_CSS_CLASS_NAME}-.*&`;
 
 /**

package/front_end/models/ai_assistance/injected.ts

@@ -90,7 +90,6 @@ function freestylerBindingFunc(bindingName: string): void {
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-inferrable-types
 export const freestylerBinding: string = `(${String(freestylerBindingFunc)})('${FREESTYLER_BINDING_NAME}')`;
 
 export const PAGE_EXPOSED_FUNCTIONS: string[] = ['setElementStyles'];
@@ -172,5 +171,4 @@ const setupSetElementStyles = `function setupSetElementStyles(prefix) {
   global.setElementStyles = setElementStyles;
 }`;
 
-// eslint-disable-next-line @typescript-eslint/no-inferrable-types
 export const injectedFunctions: string = `(${setupSetElementStyles})('${AI_ASSISTANCE_CSS_CLASS_NAME}')`;

package/front_end/models/javascript_metadata/NativeFunctions.ts

@@ -7282,7 +7282,7 @@ export const NativeFunctions: readonly NativeFunctionValue[] = [
   },
   {
     name: "RTCDTMFToneChangeEvent",
-    signatures: [["type","eventInitDict"]]
+    signatures: [["type","?eventInitDict"]]
   },
   {
     name: "RTCEncodedAudioFrame",

package/front_end/models/trace/insights/CLSCulprits.ts

@@ -72,8 +72,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/CLSCulprits.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type CLSCulpritsInsightModel = InsightModel<typeof UIStrings, {
   animationFailures: readonly NoncompositedAnimationFailure[],

package/front_end/models/trace/insights/Cache.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
 import * as Protocol from '../../../generated/protocol.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
@@ -49,8 +48,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/Cache.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type CacheInsightModel = InsightModel<typeof UIStrings, {
   requests: Array<{

package/front_end/models/trace/insights/CharacterSet.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
 import type * as Handlers from '../handlers/handlers.js';
 import type * as Types from '../types/types.js';
 
@@ -54,8 +53,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/CharacterSet.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 const CHARSET_HTTP_REGEX = /charset\s*=\s*[a-zA-Z0-9\-_:.()]{2,}/i;
 

package/front_end/models/trace/insights/DOMSize.ts

@@ -4,7 +4,6 @@
 
 import type * as Common from '../../../core/common/common.js';
 import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
 import * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
@@ -73,8 +72,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/DOMSize.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 const DOM_SIZE_DURATION_THRESHOLD = Helpers.Timing.milliToMicro(Types.Timing.Milli(40));
 

package/front_end/models/trace/insights/DocumentLatency.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
@@ -72,8 +71,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/DocumentLatency.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 // Due to the way that DevTools throttling works we cannot see if server response took less than ~570ms.
 // We set our failure threshold to 600ms to avoid those false positives but we want devs to shoot for 100ms.

package/front_end/models/trace/insights/DuplicatedJavaScript.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
 import * as Extras from '../extras/extras.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
@@ -43,8 +42,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/DuplicatedJavaScript.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type DuplicatedJavaScriptInsightModel = InsightModel<typeof UIStrings, {
   duplication: Extras.ScriptDuplication.ScriptDuplication,

package/front_end/models/trace/insights/FontDisplay.ts

@@ -41,8 +41,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/FontDisplay.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export interface RemoteFont {
   name?: string;

package/front_end/models/trace/insights/ForcedReflow.ts

@@ -51,8 +51,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/ForcedReflow.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type ForcedReflowInsightModel = InsightModel<typeof UIStrings, {
   topLevelFunctionCallData: ForcedReflowAggregatedData | undefined,

package/front_end/models/trace/insights/INPBreakdown.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
 import * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import type * as Types from '../types/types.js';
@@ -55,8 +54,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/INPBreakdown.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type INPBreakdownInsightModel = InsightModel<typeof UIStrings, {
   longestInteractionEvent?: Types.Events.SyntheticInteractionPair,

package/front_end/models/trace/insights/ImageDelivery.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import type * as Types from '../types/types.js';
@@ -69,8 +68,7 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/ImageDelivery.ts', UIStrings);
-export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
-    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: i18n.LocalizeString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 /**
  * Even JPEGs with lots of detail can usually be compressed down to <1 byte per pixel