chrome-devtools-frontend 1.0.1683520 → 1.0.1684555

package/front_end/generated/protocol.ts

@@ -504,9 +504,32 @@ export namespace Ads {
     removeAdFrames: Page.FrameId[];
   }
 
+  /**
+   * An ad script.
+   * Note: when the script is a transitive ad script, we only fill in the
+   * immediate ancestor script in the provenance's adScriptAncestry field (as its
+   * first entry), rather than filling in the full ancestry. This saves work for
+   * the backend, and the frontend can reconstruct the full ancestry if
+   * necessary.
+   */
+  export interface AdScript {
+    /**
+     * The script ID.
+     */
+    scriptId: Runtime.ScriptId;
+    /**
+     * The ad provenance.
+     */
+    provenance: Network.AdProvenance;
+  }
+
   export interface GetAdMetricsResponse extends ProtocolResponseWithError {
     metrics: AdMetrics;
   }
+
+  export interface GetAdScriptsResponse extends ProtocolResponseWithError {
+    newScripts: AdScript[];
+  }
 }
 
 export namespace Animation {
@@ -11760,6 +11783,9 @@ export namespace Network {
     filterlistRule?: string;
     /**
      * The script ancestry that created the ad, if any.
+     * Note: depending on the context, this may represent the full ancestry up
+     * to the root script, or it may contain only one script representing the
+     * immediate ancestor.
      */
     adScriptAncestry?: AdAncestry;
   }
@@ -17712,6 +17738,62 @@ export namespace ServiceWorker {
     Redundant = 'redundant',
   }
 
+  /**
+   * Mostly corresponds to `RouterCondition` in ServiceWorker spec
+   * (https://www.w3.org/TR/service-workers/#dictdef-routercondition) while this
+   * currently lacks support for the nested conditions ("or" and "not").
+   * TODO(crbug.com/540469610): Support recursive conditions.
+   */
+  export interface ServiceWorkerRouterCondition {
+    /**
+     * Plain text, or JSON serialization of URLPatternInit or URLPattern
+     */
+    urlPattern?: string;
+    requestMethod?: string;
+    requestMode?: string;
+    requestDestination?: string;
+    runningStatus?: ServiceWorkerVersionRunningStatus;
+  }
+
+  export const enum ServiceWorkerRouterSourceType {
+    Cache = 'cache',
+    FetchEvent = 'fetchEvent',
+    Network = 'network',
+    RaceNetworkAndFetchHandler = 'raceNetworkAndFetchHandler',
+    RaceNetworkAndCache = 'raceNetworkAndCache',
+    SourceDict = 'sourceDict',
+  }
+
+  /**
+   * https://www.w3.org/TR/service-workers/#dictdef-routersourcedict
+   */
+  export interface ServiceWorkerRouterSourceDict {
+    cacheName: string;
+  }
+
+  /**
+   * Corresponds to `RouterSource` in the spec while the representation is different as follows.
+   * (https://www.w3.org/TR/service-workers/#typedefdef-routersource)
+   * - `RouterSourceEnum`: `type` equals `cache`, `sourceDict` is null.
+   * - `RouterSourceDict`: `type` equals `sourceDict`, `sourceDict` has valid value.
+   */
+  export interface ServiceWorkerRouterSource {
+    type: ServiceWorkerRouterSourceType;
+    /**
+     * Non-empty iff `type` equals "sourceDict".
+     */
+    sourceDict?: ServiceWorkerRouterSourceDict;
+  }
+
+  export interface ServiceWorkerRouterRule {
+    condition: ServiceWorkerRouterCondition;
+    source: ServiceWorkerRouterSource;
+    /**
+     * Rule ID assigned by the browser. Unique within each ServiceWorkerVersion.
+     */
+    id: integer;
+  }
+
   /**
    * ServiceWorker version.
    */
@@ -17732,7 +17814,13 @@ export namespace ServiceWorker {
     scriptResponseTime?: number;
     controlledClients?: Target.TargetID[];
     targetId?: Target.TargetID;
+    /**
+     * Migration to `typedRouterRules` is in progress. The browser sends either
+     * `routerRules` or `typedRouterRules`.
+     * TODO(crbug.com/540469610): Remove `routerRules` after the migration.
+     */
     routerRules?: string;
+    typedRouterRules?: ServiceWorkerRouterRule[];
   }
 
   /**
@@ -18179,7 +18267,6 @@ export namespace Storage {
     Websql = 'websql',
     Service_workers = 'service_workers',
     Cache_storage = 'cache_storage',
-    Shared_storage = 'shared_storage',
     Storage_buckets = 'storage_buckets',
     All = 'all',
     Other = 'other',
@@ -18208,217 +18295,6 @@ export namespace Storage {
     count: number;
   }
 
-  /**
-   * Enum of shared storage access scopes.
-   */
-  export const enum SharedStorageAccessScope {
-    Window = 'window',
-    SharedStorageWorklet = 'sharedStorageWorklet',
-    Header = 'header',
-  }
-
-  /**
-   * Enum of shared storage access methods.
-   */
-  export const enum SharedStorageAccessMethod {
-    AddModule = 'addModule',
-    CreateWorklet = 'createWorklet',
-    SelectURL = 'selectURL',
-    Run = 'run',
-    BatchUpdate = 'batchUpdate',
-    Set = 'set',
-    Append = 'append',
-    Delete = 'delete',
-    Clear = 'clear',
-    Get = 'get',
-    Keys = 'keys',
-    Values = 'values',
-    Entries = 'entries',
-    Length = 'length',
-    RemainingBudget = 'remainingBudget',
-  }
-
-  /**
-   * Struct for a single key-value pair in an origin's shared storage.
-   */
-  export interface SharedStorageEntry {
-    key: string;
-    value: string;
-  }
-
-  /**
-   * Details for an origin's shared storage.
-   */
-  export interface SharedStorageMetadata {
-    /**
-     * Time when the origin's shared storage was last created.
-     */
-    creationTime: Network.TimeSinceEpoch;
-    /**
-     * Number of key-value pairs stored in origin's shared storage.
-     */
-    length: integer;
-    /**
-     * Current amount of bits of entropy remaining in the navigation budget.
-     */
-    remainingBudget: number;
-    /**
-     * Total number of bytes stored as key-value pairs in origin's shared
-     * storage.
-     */
-    bytesUsed: integer;
-  }
-
-  /**
-   * Represents a dictionary object passed in as privateAggregationConfig to
-   * run or selectURL.
-   */
-  export interface SharedStoragePrivateAggregationConfig {
-    /**
-     * The chosen aggregation service deployment.
-     */
-    aggregationCoordinatorOrigin?: string;
-    /**
-     * The context ID provided.
-     */
-    contextId?: string;
-    /**
-     * Configures the maximum size allowed for filtering IDs.
-     */
-    filteringIdMaxBytes: integer;
-    /**
-     * The limit on the number of contributions in the final report.
-     */
-    maxContributions?: integer;
-  }
-
-  /**
-   * Pair of reporting metadata details for a candidate URL for `selectURL()`.
-   */
-  export interface SharedStorageReportingMetadata {
-    eventType: string;
-    reportingUrl: string;
-  }
-
-  /**
-   * Bundles a candidate URL with its reporting metadata.
-   */
-  export interface SharedStorageUrlWithMetadata {
-    /**
-     * Spec of candidate URL.
-     */
-    url: string;
-    /**
-     * Any associated reporting metadata.
-     */
-    reportingMetadata: SharedStorageReportingMetadata[];
-  }
-
-  /**
-   * Bundles the parameters for shared storage access events whose
-   * presence/absence can vary according to SharedStorageAccessType.
-   */
-  export interface SharedStorageAccessParams {
-    /**
-     * Spec of the module script URL.
-     * Present only for SharedStorageAccessMethods: addModule and
-     * createWorklet.
-     */
-    scriptSourceUrl?: string;
-    /**
-     * String denoting "context-origin", "script-origin", or a custom
-     * origin to be used as the worklet's data origin.
-     * Present only for SharedStorageAccessMethod: createWorklet.
-     */
-    dataOrigin?: string;
-    /**
-     * Name of the registered operation to be run.
-     * Present only for SharedStorageAccessMethods: run and selectURL.
-     */
-    operationName?: string;
-    /**
-     * ID of the operation call.
-     * Present only for SharedStorageAccessMethods: run and selectURL.
-     */
-    operationId?: string;
-    /**
-     * Whether or not to keep the worket alive for future run or selectURL
-     * calls.
-     * Present only for SharedStorageAccessMethods: run and selectURL.
-     */
-    keepAlive?: boolean;
-    /**
-     * Configures the private aggregation options.
-     * Present only for SharedStorageAccessMethods: run and selectURL.
-     */
-    privateAggregationConfig?: SharedStoragePrivateAggregationConfig;
-    /**
-     * The operation's serialized data in bytes (converted to a string).
-     * Present only for SharedStorageAccessMethods: run and selectURL.
-     * TODO(crbug.com/401011862): Consider updating this parameter to binary.
-     */
-    serializedData?: string;
-    /**
-     * Array of candidate URLs' specs, along with any associated metadata.
-     * Present only for SharedStorageAccessMethod: selectURL.
-     */
-    urlsWithMetadata?: SharedStorageUrlWithMetadata[];
-    /**
-     * Spec of the URN:UUID generated for a selectURL call.
-     * Present only for SharedStorageAccessMethod: selectURL.
-     */
-    urnUuid?: string;
-    /**
-     * Key for a specific entry in an origin's shared storage.
-     * Present only for SharedStorageAccessMethods: set, append, delete, and
-     * get.
-     */
-    key?: string;
-    /**
-     * Value for a specific entry in an origin's shared storage.
-     * Present only for SharedStorageAccessMethods: set and append.
-     */
-    value?: string;
-    /**
-     * Whether or not to set an entry for a key if that key is already present.
-     * Present only for SharedStorageAccessMethod: set.
-     */
-    ignoreIfPresent?: boolean;
-    /**
-     * A number denoting the (0-based) order of the worklet's
-     * creation relative to all other shared storage worklets created by
-     * documents using the current storage partition.
-     * Present only for SharedStorageAccessMethods: addModule, createWorklet.
-     */
-    workletOrdinal?: integer;
-    /**
-     * Hex representation of the DevTools token used as the TargetID for the
-     * associated shared storage worklet.
-     * Present only for SharedStorageAccessMethods: addModule, createWorklet,
-     * run, selectURL, and any other SharedStorageAccessMethod when the
-     * SharedStorageAccessScope is sharedStorageWorklet.
-     */
-    workletTargetId?: Target.TargetID;
-    /**
-     * Name of the lock to be acquired, if present.
-     * Optionally present only for SharedStorageAccessMethods: batchUpdate,
-     * set, append, delete, and clear.
-     */
-    withLock?: string;
-    /**
-     * If the method has been called as part of a batchUpdate, then this
-     * number identifies the batch to which it belongs.
-     * Optionally present only for SharedStorageAccessMethods:
-     * batchUpdate (required), set, append, delete, and clear.
-     */
-    batchUpdateId?: string;
-    /**
-     * Number of modifier methods sent in batch.
-     * Present only for SharedStorageAccessMethod: batchUpdate.
-     */
-    batchSize?: integer;
-  }
-
   export const enum StorageBucketsDurability {
     Relaxed = 'relaxed',
     Strict = 'strict',
@@ -18646,50 +18522,6 @@ export namespace Storage {
     didDeleteTokens: boolean;
   }
 
-  export interface GetSharedStorageMetadataRequest {
-    ownerOrigin: string;
-  }
-
-  export interface GetSharedStorageMetadataResponse extends ProtocolResponseWithError {
-    metadata: SharedStorageMetadata;
-  }
-
-  export interface GetSharedStorageEntriesRequest {
-    ownerOrigin: string;
-  }
-
-  export interface GetSharedStorageEntriesResponse extends ProtocolResponseWithError {
-    entries: SharedStorageEntry[];
-  }
-
-  export interface SetSharedStorageEntryRequest {
-    ownerOrigin: string;
-    key: string;
-    value: string;
-    /**
-     * If `ignoreIfPresent` is included and true, then only sets the entry if
-     * `key` doesn't already exist.
-     */
-    ignoreIfPresent?: boolean;
-  }
-
-  export interface DeleteSharedStorageEntryRequest {
-    ownerOrigin: string;
-    key: string;
-  }
-
-  export interface ClearSharedStorageEntriesRequest {
-    ownerOrigin: string;
-  }
-
-  export interface ResetSharedStorageBudgetRequest {
-    ownerOrigin: string;
-  }
-
-  export interface SetSharedStorageTrackingRequest {
-    enable: boolean;
-  }
-
   export interface SetStorageBucketTrackingRequest {
     storageKey: string;
     enable: boolean;
@@ -18791,79 +18623,6 @@ export namespace Storage {
     bucketId: string;
   }
 
-  /**
-   * Shared storage was accessed by the associated page.
-   * The following parameters are included in all events.
-   */
-  export interface SharedStorageAccessedEvent {
-    /**
-     * Time of the access.
-     */
-    accessTime: Network.TimeSinceEpoch;
-    /**
-     * Enum value indicating the access scope.
-     */
-    scope: SharedStorageAccessScope;
-    /**
-     * Enum value indicating the Shared Storage API method invoked.
-     */
-    method: SharedStorageAccessMethod;
-    /**
-     * DevTools Frame Token for the primary frame tree's root.
-     */
-    mainFrameId: Page.FrameId;
-    /**
-     * Serialization of the origin owning the Shared Storage data.
-     */
-    ownerOrigin: string;
-    /**
-     * Serialization of the site owning the Shared Storage data.
-     */
-    ownerSite: string;
-    /**
-     * The sub-parameters wrapped by `params` are all optional and their
-     * presence/absence depends on `type`.
-     */
-    params: SharedStorageAccessParams;
-  }
-
-  /**
-   * A shared storage run or selectURL operation finished its execution.
-   * The following parameters are included in all events.
-   */
-  export interface SharedStorageWorkletOperationExecutionFinishedEvent {
-    /**
-     * Time that the operation finished.
-     */
-    finishedTime: Network.TimeSinceEpoch;
-    /**
-     * Time, in microseconds, from start of shared storage JS API call until
-     * end of operation execution in the worklet.
-     */
-    executionTime: integer;
-    /**
-     * Enum value indicating the Shared Storage API method invoked.
-     */
-    method: SharedStorageAccessMethod;
-    /**
-     * ID of the operation call.
-     */
-    operationId: string;
-    /**
-     * Hex representation of the DevTools token used as the TargetID for the
-     * associated shared storage worklet.
-     */
-    workletTargetId: Target.TargetID;
-    /**
-     * DevTools Frame Token for the primary frame tree's root.
-     */
-    mainFrameId: Page.FrameId;
-    /**
-     * Serialization of the origin owning the Shared Storage data.
-     */
-    ownerOrigin: string;
-  }
-
   export interface StorageBucketCreatedOrUpdatedEvent {
     bucketInfo: StorageBucketInfo;
   }
@@ -20438,6 +20197,10 @@ export namespace WebMCP {
      * A hint indicating that the tool output may contain untrusted content, ex: UGC, 3rd party data.
      */
     untrustedContent?: boolean;
+    /**
+     * A hint indicating that executing the tool will result in consequential actions, ex: booking a flight, transferring money.
+     */
+    consequential?: boolean;
     /**
      * If the declarative tool was declared with the autosubmit attribute.
      */

package/front_end/models/ai_assistance/AiAgent2.ts

@@ -18,6 +18,7 @@ import {
 } from './agents/AiAgent.js';
 import {type ExecuteJsAgentOptions, executeJsCode} from './agents/ExecuteJavascript.js';
 import {ChangeManager} from './ChangeManager.js';
+import {AccessibilityContext} from './contexts/AccessibilityContext.js';
 import {DOMNodeContext} from './contexts/DOMNodeContext.js';
 import {debugLog} from './debug.js';
 import {ExtensionScope} from './ExtensionScope.js';
@@ -85,9 +86,12 @@ export class AiAgent2 extends AiAgent<unknown> {
   }
 
   protected override async preRun(): Promise<void> {
+    // One-way latch: once sensitive data enters the conversation history,
+    // logging must remain disabled for the lifetime of this agent instance.
     if (this.context && !this.context.isLoggingEnabled()) {
-      this.setServerSideLoggingActive(false);
+      this.disableServerSideLogging();
     }
+
     const target = this.targetManager.primaryPageTarget();
     const domModel = target?.model(SDK.DOMModel.DOMModel);
     // Ensure the DOM document is requested and cached in DOMModel so that
@@ -183,6 +187,9 @@ QUERY: ${query}`;
       return enhancedQuery;
     }
 
+    // Note: Test assertion helpers in front_end/testing/AiAssistanceHelpers.ts (assertSkillLoaded,
+    // assertSkillNotLoaded) rely on this formatting (`Available skills that are not yet loaded:`
+    // and `- ${name}: ${skill.description}`). If this format is updated, update those helpers too.
     const skillsManifest = unloadedSkills.map(([name, skill]) => `- ${name}: ${skill.description}`).join('\n');
     return `Available skills that are not yet loaded:
 ${skillsManifest}
@@ -274,10 +281,11 @@ User query: ${enhancedQuery}`;
               (this.context instanceof DOMNodeContext ? this.context.getItem() : this.#getDocumentBodyNode()),
           getTarget: () => this.targetManager.primaryPageTarget(),
           getEstablishedOrigin: () => this.#getConversationOrigin(),
-          lighthouseRecording: this.#lighthouseRecording,
+          getLighthouseReport: () => (this.context instanceof AccessibilityContext ? this.context.getItem() : null),
+          runLighthouse: async overrides => await (this.#lighthouseRecording?.(overrides) ?? null),
           performanceRecordAndReload: this.#performanceRecordAndReload,
-          setLoggingEnabled: (enabled: boolean) => {
-            this.setServerSideLoggingActive(enabled);
+          disableLogging: () => {
+            this.disableServerSideLogging();
           },
         };
         return tool.handler(args, context, options);

package/front_end/models/ai_assistance/AiConversation.ts

@@ -189,7 +189,7 @@ export class AiConversation {
   setContext(updateContext: ConversationContext<unknown>|null): void {
     if (!updateContext) {
       this.#contexts = [];
-      if (isAiAssistanceContextSelectionAgentEnabled()) {
+      if (isAiAssistanceContextSelectionEnabled()) {
         this.#updateAgent(ConversationType.NONE);
       }
 
@@ -198,7 +198,7 @@ export class AiConversation {
 
     this.#contexts = [updateContext];
 
-    if (isAiAssistanceContextSelectionAgentEnabled()) {
+    if (isAiAssistanceContextSelectionEnabled()) {
       if (updateContext instanceof FileContext) {
         this.#updateAgent(ConversationType.FILE);
       } else if (updateContext instanceof DOMNodeContext) {
@@ -365,11 +365,23 @@ export class AiConversation {
       return;
     }
 
-    const isTransitioningFromStorage = this.#type === ConversationType.STORAGE && type !== ConversationType.STORAGE;
-    const history = isTransitioningFromStorage ? [] : this.#filterHistoryForNewAgent();
-
+    const previousType = this.#type;
     this.#type = type;
 
+    // In AI Architecture V2, DevTools uses a single unified agent (AiAgent2) that
+    // dynamically loads skills on demand. Reusing the existing agent instance across
+    // context changes preserves its loaded activeSkills and declared tools so the model
+    // does not need to re-learn skills it already acquired earlier in the conversation.
+    if (Root.Runtime.hostConfig.devToolsAiV2Architecture?.enabled && this.#agent instanceof AiAgent2) {
+      return;
+    }
+
+    // In legacy V1 architecture, agents are recreated when switching conversation types.
+    // Discard conversation history when transitioning away from Storage to prevent
+    // sensitive data (e.g. cookies or storage items) from leaking into subsequent agent queries.
+    const isTransitioningFromStorage = previousType === ConversationType.STORAGE && type !== ConversationType.STORAGE;
+    const history = isTransitioningFromStorage ? [] : this.#filterHistoryForNewAgent();
+
     const options = {
       aidaClient: this.#aidaClient,
       serverSideLoggingAllowed: isAiAssistanceServerSideLoggingAllowed(),
@@ -561,8 +573,14 @@ function isAiAssistanceServerSideLoggingAllowed(): boolean {
   return !Root.Runtime.hostConfig.aidaAvailability?.disallowLogging;
 }
 
-function isAiAssistanceContextSelectionAgentEnabled(): boolean {
-  return Boolean(Root.Runtime.hostConfig.devToolsAiAssistanceContextSelectionAgent?.enabled);
+/**
+ * Returns true if context changes should dynamically update the conversation's
+ * agent/type state. Enabled for both the legacy V1 selection agent and the
+ * unified V2 architecture.
+ */
+function isAiAssistanceContextSelectionEnabled(): boolean {
+  return Boolean(Root.Runtime.hostConfig.devToolsAiAssistanceContextSelectionAgent?.enabled) ||
+      Boolean(Root.Runtime.hostConfig.devToolsAiV2Architecture?.enabled);
 }
 
 function getPrimaryPageOrigin(

package/front_end/models/ai_assistance/agents/AiAgent.ts

@@ -505,14 +505,9 @@ export abstract class AiAgent<T> {
 
   readonly #sessionId: string;
   readonly #aidaClient: Host.AidaClient.AidaClient;
-  /**
-   * Whether server-side logging is permitted by the system policy (based on
-   * user preferences, feature flags, or branding configurations).
-   */
-  readonly #serverSideLoggingAllowed: boolean;
   /**
    * Tracks the dynamic runtime state of logging. Even if logging is allowed
-   * by policy, tools can temporarily deactivate this to avoid logging sensitive data.
+   * by policy, tools or sensitive contexts can deactivate this to avoid logging sensitive data.
    */
   #serverSideLoggingActive: boolean;
   readonly confirmSideEffect: typeof Promise.withResolvers;
@@ -548,7 +543,6 @@ export abstract class AiAgent<T> {
     if (Root.Runtime.hostConfig.devToolsGeminiRebranding?.enabled) {
       serverSideLoggingAllowed = false;
     }
-    this.#serverSideLoggingAllowed = serverSideLoggingAllowed;
     this.#serverSideLoggingActive = serverSideLoggingAllowed;
     this.#sessionId = opts.sessionId ?? crypto.randomUUID();
     this.confirmSideEffect = opts.confirmSideEffectForTest ?? (() => Promise.withResolvers());
@@ -603,16 +597,14 @@ export abstract class AiAgent<T> {
   }
 
   /**
-   * Toggles whether server-side logging is active.
-   * Note that logging can only be activated if it was allowed by policy/configuration
-   * at startup (i.e., `#serverSideLoggingAllowed` is true).
+   * Disables server-side logging for the remainder of this agent instance's lifetime.
+   *
+   * Logging deactivation is irreversible for the session. Conversation history
+   * accumulates across turns; re-enabling logging later would leak sensitive
+   * data from prior turns to AIDA.
    */
-  protected setServerSideLoggingActive(active: boolean): void {
-    if (active && this.#serverSideLoggingAllowed) {
-      this.#serverSideLoggingActive = true;
-    } else {
-      this.#serverSideLoggingActive = false;
-    }
+  protected disableServerSideLogging(): void {
+    this.#serverSideLoggingActive = false;
   }
 
   popPendingMultimodalInput(): MultimodalInput|undefined {
@@ -794,9 +786,9 @@ export abstract class AiAgent<T> {
           multimodalInput?: MultimodalInput,
           ): AsyncGenerator<ResponseData, void, void> {
     await options.selected?.refresh();
-    if (options.selected) {
-      this.context = options.selected;
-    }
+    // Reset context on each run so cleared selections (`null`) do not leave
+    // stale context references on long-lived agent instances (e.g. `AiAgent2`).
+    this.context = options.selected ?? undefined;
     await this.preRun();
 
     const enhancedQuery = await this.enhanceQuery(initialQuery, options.selected, multimodalInput?.type);