chrome-devtools-frontend 1.0.1681498 → 1.0.1682249

package/eslint.config.mjs

@@ -3,14 +3,14 @@
 // found in the LICENSE file.
 
 import stylisticPlugin from '@stylistic/eslint-plugin';
-import { defineConfig, globalIgnores } from 'eslint/config';
+import {defineConfig, globalIgnores} from 'eslint/config';
 import eslintPlugin from 'eslint-plugin-eslint-plugin';
 import importPlugin from 'eslint-plugin-import';
 import jsdocPlugin from 'eslint-plugin-jsdoc';
 import litPlugin from 'eslint-plugin-lit';
 import mochaPlugin from 'eslint-plugin-mocha';
 import globals from 'globals';
-import { join } from 'node:path';
+import {join} from 'node:path';
 import typescriptEslint from 'typescript-eslint';
 
 import devToolsPlugin from './scripts/eslint_rules/plugin.mjs';
@@ -731,8 +731,10 @@ export default defineConfig([
     name: 'TypeScript test files',
     files: [
       '*.test.ts',
+      '*.docs.ts',
       // This makes the specificity greater than the front-end ts files
       'front_end/**/*.test.ts',
+      'front_end/**/*.docs.ts',
       'test/**/*.ts',
       '**/testing/*.ts',
       'scripts/eslint_rules/test/**/*',
@@ -870,7 +872,10 @@ export default defineConfig([
   {
     name: 'Keep models/trace isolated',
     files: ['front_end/models/trace/**/*.ts'],
-    ignores: ['front_end/models/trace/**/*.test.ts'],
+    ignores: [
+      'front_end/models/trace/**/*.test.ts',
+      'front_end/models/trace/**/*.docs.ts',
+    ],
     rules: {
       '@devtools/no-imports-in-directory': [
         'error',

package/front_end/core/sdk/ConsoleModel.ts

@@ -145,7 +145,7 @@ export class ConsoleModel extends SDKModel<EventTypes> {
   async evaluateCommandInConsole(
       executionContext: ExecutionContext, originatingMessage: ConsoleMessage, expression: string,
       useCommandLineAPI: boolean): Promise<void> {
-    const result = await executionContext.evaluate(
+    const result = await executionContext.evaluateWithSelectedFrameFallback(
         {
           expression,
           objectGroup: 'console',

package/front_end/core/sdk/PreloadingModel.ts

@@ -4,8 +4,7 @@
 
 import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 import * as Protocol from '../../generated/protocol.js';
-import type * as Common from '../common/common.js';
-import {MapWithDefault} from '../common/MapWithDefault.js';
+import * as Common from '../common/common.js';
 import {assertNotNullOrUndefined} from '../platform/platform.js';
 
 import {
@@ -652,12 +651,15 @@ class PreloadingAttemptRegistry {
   private map: Map<PreloadingAttemptId, PreloadingAttemptInternal> =
       new Map<PreloadingAttemptId, PreloadingAttemptInternal>();
   private pipelines:
-      MapWithDefault<Protocol.Preload.PreloadPipelineId, Map<Protocol.Preload.SpeculationAction, PreloadingAttemptId>> =
-          new MapWithDefault<
-              Protocol.Preload.PreloadPipelineId, Map<Protocol.Preload.SpeculationAction, PreloadingAttemptId>>();
-
-  private enrich(attempt: PreloadingAttemptInternal, source: Protocol.Preload.PreloadingAttemptSource|null):
-      PreloadingAttempt {
+      Common.MapWithDefault.MapWithDefault<Protocol.Preload.PreloadPipelineId,
+                                           Map<Protocol.Preload.SpeculationAction, PreloadingAttemptId>> =
+      new Common.MapWithDefault.MapWithDefault<Protocol.Preload.PreloadPipelineId,
+                                               Map<Protocol.Preload.SpeculationAction, PreloadingAttemptId>>();
+
+  private enrich(
+      attempt: PreloadingAttemptInternal,
+      source: Protocol.Preload.PreloadingAttemptSource|null,
+      ): PreloadingAttempt {
     let ruleSetIds: Protocol.Preload.RuleSetId[] = [];
     let nodeIds: Protocol.DOM.BackendNodeId[] = [];
     if (source !== null) {
@@ -706,12 +708,17 @@ class PreloadingAttemptRegistry {
     if (pipeline.size === 0) {
       throw new Error('unreachable');
     }
-    return [...pipeline.keys()].every(action => getSortKey(action) <= getSortKey(attempt.action));
+    return [...pipeline.keys()].every(
+        action => getSortKey(action) <= getSortKey(attempt.action),
+    );
   }
 
   // Returns reference. Don't save returned values.
   // Returned values may or may not be updated as the time grows.
-  getById(id: PreloadingAttemptId, sources: SourceRegistry): PreloadingAttempt|null {
+  getById(
+      id: PreloadingAttemptId,
+      sources: SourceRegistry,
+      ): PreloadingAttempt|null {
     const attempt = this.map.get(id) || null;
     if (attempt === null) {
       return null;
@@ -725,16 +732,23 @@ class PreloadingAttemptRegistry {
   //
   // Returns reference. Don't save returned values.
   // Returned values may or may not be updated as the time grows.
-  getAllRepresentative(ruleSetId: Protocol.Preload.RuleSetId|null, sources: SourceRegistry):
-      Array<WithId<PreloadingAttemptId, PreloadingAttempt>> {
+  getAllRepresentative(
+      ruleSetId: Protocol.Preload.RuleSetId|null,
+      sources: SourceRegistry,
+      ): Array<WithId<PreloadingAttemptId, PreloadingAttempt>> {
     return [...this.map.entries()]
-        .map(([id, value]) => ({id, value: this.enrich(value, sources.getById(id))}))
+        .map(([id, value]) => ({
+               id,
+               value: this.enrich(value, sources.getById(id)),
+             }))
         .filter(({value}) => !ruleSetId || value.ruleSetIds.includes(ruleSetId))
         .filter(({value}) => this.isAttemptRepresentative(value));
   }
 
-  getPipeline(pipelineId: Protocol.Preload.PreloadPipelineId, sources: SourceRegistry):
-      Map<Protocol.Preload.SpeculationAction, PreloadingAttempt>|null {
+  getPipeline(
+      pipelineId: Protocol.Preload.PreloadPipelineId,
+      sources: SourceRegistry,
+      ): Map<Protocol.Preload.SpeculationAction, PreloadingAttempt>|null {
     const pipeline = this.pipelines.get(pipelineId);
 
     if (pipeline === undefined || pipeline.size === 0) {
@@ -745,11 +759,13 @@ class PreloadingAttemptRegistry {
     for (const [id, attempt] of this.map.entries()) {
       map[id] = attempt;
     }
-    return new Map(pipeline.entries().map(([action, id]) => {
-      const attempt = this.getById(id, sources);
-      assertNotNullOrUndefined(attempt);
-      return [action, attempt];
-    }));
+    return new Map(
+        pipeline.entries().map(([action, id]) => {
+          const attempt = this.getById(id, sources);
+          assertNotNullOrUndefined(attempt);
+          return [action, attempt];
+        }),
+    );
   }
 
   upsert(attempt: PreloadingAttemptInternal): void {
@@ -770,7 +786,10 @@ class PreloadingAttemptRegistry {
         continue;
       }
 
-      const pipeline = this.pipelines.getOrInsertComputed(attempt.pipelineId, () => new Map());
+      const pipeline = this.pipelines.getOrInsertComputed(
+          attempt.pipelineId,
+          () => new Map(),
+      );
       pipeline.set(attempt.action, id);
     }
   }
@@ -830,7 +849,10 @@ class PreloadingAttemptRegistry {
   // Removes keys in `this.map` that are not in `sources`. This is used to
   // remove attempts that no longer have a matching speculation rule.
   cleanUpRemovedAttempts(sources: SourceRegistry): void {
-    const keysToRemove = Array.from(this.map.keys()).filter(key => !sources.getById(key));
+    const keysToRemove = Array.from(this.map.keys())
+                             .filter(
+                                 key => !sources.getById(key),
+                             );
     for (const key of keysToRemove) {
       this.map.delete(key);
     }

package/front_end/core/sdk/RemoteObject.ts

@@ -4,11 +4,14 @@
 
 import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 import * as Protocol from '../../generated/protocol.js';
-import type {DOMPinnedWebIDLProp, DOMPinnedWebIDLType} from '../common/JavaScriptMetaData.js';
+import type * as Common from '../common/common.js';
 
 import type {DebuggerModel, FunctionDetails} from './DebuggerModel.js';
 import type {RuntimeModel} from './RuntimeModel.js';
 
+type DOMPinnedWebIDLProp = Common.JavaScriptMetaData.DOMPinnedWebIDLProp;
+type DOMPinnedWebIDLType = Common.JavaScriptMetaData.DOMPinnedWebIDLType;
+
 /** This cannot be an interface due to "instanceof RemoteObject" checks in the code. **/
 export abstract class RemoteObject {
   static fromLocalObject(value: unknown): RemoteObject {

package/front_end/core/sdk/RuntimeModel.ts

@@ -589,12 +589,13 @@ export class ExecutionContext {
     return a.name.localeCompare(b.name);
   }
 
-  async evaluate(options: EvaluationOptions, userGesture: boolean, awaitPromise: boolean): Promise<EvaluationResult> {
+  async evaluateWithSelectedFrameFallback(options: EvaluationOptions, userGesture: boolean,
+                                          awaitPromise: boolean): Promise<EvaluationResult> {
     // FIXME: It will be moved to separate ExecutionContext.
     if (this.debuggerModel.selectedCallFrame()) {
       return await this.debuggerModel.evaluateOnSelectedCallFrame(options);
     }
-    return await this.evaluateGlobal(options, userGesture, awaitPromise);
+    return await this.evaluate(options, userGesture, awaitPromise);
   }
 
   globalObject(objectGroup: string, generatePreview: boolean): Promise<EvaluationResult> {
@@ -606,7 +607,7 @@ export class ExecutionContext {
       returnByValue: false,
       generatePreview,
     };
-    return this.evaluateGlobal((evaluationOptions as EvaluationOptions), false, false);
+    return this.evaluate((evaluationOptions as EvaluationOptions), false, false);
   }
 
   async callFunctionOn(options: CallFunctionOptions): Promise<EvaluationResult> {
@@ -629,8 +630,7 @@ export class ExecutionContext {
     return {object: this.runtimeModel.createRemoteObject(response.result), exceptionDetails: response.exceptionDetails};
   }
 
-  private async evaluateGlobal(options: EvaluationOptions, userGesture: boolean, awaitPromise: boolean):
-      Promise<EvaluationResult> {
+  async evaluate(options: EvaluationOptions, userGesture: boolean, awaitPromise: boolean): Promise<EvaluationResult> {
     if (!options.expression) {
       // There is no expression, so the completion should happen against global properties.
       options.expression = 'this';

package/front_end/core/sdk/sdk.ts

@@ -67,6 +67,7 @@ import * as PaintProfiler from './PaintProfiler.js';
 import * as PerformanceMetricsModel from './PerformanceMetricsModel.js';
 import * as PreloadingModel from './PreloadingModel.js';
 import * as RehydratingConnection from './RehydratingConnection.js';
+import * as RehydratingObject from './RehydratingObject.js';
 import * as RemoteObject from './RemoteObject.js';
 import * as Resource from './Resource.js';
 import * as ResourceTreeModel from './ResourceTreeModel.js';
@@ -153,6 +154,7 @@ export {
   PerformanceMetricsModel,
   PreloadingModel,
   RehydratingConnection,  // TODO(crbug.com/444191656): Exported for tests.
+  RehydratingObject,
   RemoteObject,
   Resource,
   ResourceTreeModel,

package/front_end/entrypoints/formatter_worker/FormatterWorker.ts

@@ -6,7 +6,7 @@ import * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 // This file is required to bring some types into scope, even though it
 // is not used.
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+// eslint-disable-next-line @typescript-eslint/no-unused-vars, @devtools/es-modules-import
 import type * as CodeMirrorModule from '../../third_party/codemirror/codemirror-legacy.js';
 
 import {CSSFormatter} from './CSSFormatter.js';

package/front_end/entrypoints/inspector_main/InspectorMain.ts

@@ -12,6 +12,7 @@ import * as MobileThrottling from '../../panels/mobile_throttling/mobile_throttl
 import * as Components from '../../ui/legacy/components/utils/utils.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Lit from '../../ui/lit/lit.js';
+import * as SettingsUI from '../../ui/settings/settings.js';
 
 import nodeIconStyles from './nodeIcon.css.js';
 
@@ -251,7 +252,8 @@ export class BackendSettingsSync implements SDK.TargetManager.Observer {
     this.#autoAttachSetting.addChangeListener(this.#updateAutoAttach, this);
     this.#updateAutoAttach();
 
-    this.#adBlockEnabledSetting = Common.Settings.Settings.instance().moduleSetting('network.ad-blocking-enabled');
+    this.#adBlockEnabledSetting = Common.Settings.Settings.instance().resolve(
+        SettingsUI.InspectorMainSettings.adBlockingEnabledSettingDescriptor);
     this.#adBlockEnabledSetting.addChangeListener(this.#update, this);
 
     this.#emulatePageFocusSetting =

package/front_end/entrypoints/inspector_main/inspector_main-meta.ts

@@ -447,13 +447,9 @@ UI.ActionRegistration.registerActionExtension({
   },
 });
 
-Common.Settings.registerSettingExtension({
+SettingsUI.SettingUIRegistration.register(SettingsUI.InspectorMainSettings.adBlockingEnabledSettingDescriptor, {
   category: Common.Settings.SettingCategory.NETWORK,
   title: i18nLazyString(UIStrings.forceAdBlocking),
-  settingName: 'network.ad-blocking-enabled',
-  settingType: Common.Settings.SettingType.BOOLEAN,
-  storageType: Common.Settings.SettingStorageType.SESSION,
-  defaultValue: false,
   options: [
     {
       value: true,

package/front_end/entrypoints/main/MainImpl.ts

@@ -595,16 +595,15 @@ export class MainImpl {
           if (event.data.payload === 'true' || event.data.payload === 'false') {
             VisualLogging.setVeDebuggingEnabled(event.data.payload === 'true', (query: string) => {
               VisualLogging.setVeDebuggingEnabled(false);
-              void runtimeModel?.defaultExecutionContext()?.evaluate(
-                  {
-                    expression: `window.inspect(${JSON.stringify(query)})`,
-                    includeCommandLineAPI: false,
-                    silent: true,
-                    returnByValue: false,
-                    generatePreview: false,
-                  },
-                  /* userGesture */ false,
-                  /* awaitPromise */ false);
+              void runtimeModel?.defaultExecutionContext()?.evaluateWithSelectedFrameFallback({
+                expression: `window.inspect(${JSON.stringify(query)})`,
+                includeCommandLineAPI: false,
+                silent: true,
+                returnByValue: false,
+                generatePreview: false,
+              },
+                                                                                              /* userGesture */ false,
+                                                                                              /* awaitPromise */ false);
             });
           } else {
             VisualLogging.setHighlightedVe(event.data.payload === 'null' ? null : event.data.payload);

package/front_end/entrypoints/shell/shell.ts

@@ -16,11 +16,9 @@ import '../../panels/changes/changes-meta.js';
 import '../../panels/linear_memory_inspector/linear_memory_inspector-meta.js';
 import '../../panels/settings/settings-meta.js';
 import '../../panels/protocol_monitor/protocol_monitor-meta.js';
-import '../../models/logs/logs-meta.js';
 import '../main/main-meta.js';
 import '../../ui/legacy/components/perf_ui/perf_ui-meta.js';
 import '../../ui/legacy/components/quick_open/quick_open-meta.js';
-import '../../models/workspace/workspace-meta.js';
 import '../../ui/legacy/components/source_frame/source_frame-meta.js';
 import '../../panels/console_counters/console_counters-meta.js';
 import '../../panels/explain/explain-meta.js';

package/front_end/entrypoints/trace_app/trace_app.ts

@@ -4,13 +4,11 @@
 // found in the LICENSE file.
 import '../main/main-meta.js';
 import '../inspector_main/inspector_main-meta.js';
-import '../../models/workspace/workspace-meta.js';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore: tsc 6.0 does not support side-effect imports without a type definition.
 // We cannot use `@ts-expect-error` here because the import is correctly resolved
 // when bundling the application (which doesn't error) and only errors in unbundled builds.
 import '../../Images/Images.js';
-import '../../models/logs/logs-meta.js';
 import '../../panels/browser_debugger/browser_debugger-meta.js';
 import '../../panels/developer_resources/developer_resources-meta.js';
 // panels/timeline depends on mobile_throttling for settings UI

package/front_end/generated/InspectorBackendCommands.ts

@@ -226,6 +226,8 @@ inspectorBackend.registerCommand("Browser.setContentsSize", [{"name": "windowId"
 inspectorBackend.registerCommand("Browser.setDockTile", [{"name": "badgeLabel", "type": "string", "optional": true, "description": "", "typeRef": null}, {"name": "image", "type": "string", "optional": true, "description": "Png encoded image.", "typeRef": null}], [], "Set dock tile details, platform-specific.");
 inspectorBackend.registerCommand("Browser.executeBrowserCommand", [{"name": "commandId", "type": "string", "optional": false, "description": "", "typeRef": "Browser.BrowserCommandId"}], [], "Invoke custom browser commands used by telemetry.");
 inspectorBackend.registerCommand("Browser.addPrivacySandboxEnrollmentOverride", [{"name": "url", "type": "string", "optional": false, "description": "", "typeRef": null}], [], "Allows a site to use privacy sandbox features that require enrollment without the site actually being enrolled. Only supported on page targets.");
+inspectorBackend.registerCommand("Browser.getGlobalPrivacyControl", [], ["gpc"], "Gets the current globally-applied privacy control status See https://www.w3.org/TR/gpc/#get-global-privacy-control");
+inspectorBackend.registerCommand("Browser.setGlobalPrivacyControl", [{"name": "gpc", "type": "boolean", "optional": false, "description": "", "typeRef": null}], ["gpc"], "Sets and then gets the current globally-applied privacy control status See https://www.w3.org/TR/gpc/#set-global-privacy-control");
 inspectorBackend.registerType("Browser.Bounds", [{"name": "left", "type": "number", "optional": true, "description": "The offset from the left edge of the screen to the window in pixels.", "typeRef": null}, {"name": "top", "type": "number", "optional": true, "description": "The offset from the top edge of the screen to the window in pixels.", "typeRef": null}, {"name": "width", "type": "number", "optional": true, "description": "The window width in pixels.", "typeRef": null}, {"name": "height", "type": "number", "optional": true, "description": "The window height in pixels.", "typeRef": null}, {"name": "windowState", "type": "string", "optional": true, "description": "The window state. Default to normal.", "typeRef": "Browser.WindowState"}]);
 inspectorBackend.registerType("Browser.PermissionDescriptor", [{"name": "name", "type": "string", "optional": false, "description": "Name of permission. See https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/permissions/permission_descriptor.idl for valid permission names.", "typeRef": null}, {"name": "sysex", "type": "boolean", "optional": true, "description": "For \\\"midi\\\" permission, may also specify sysex control.", "typeRef": null}, {"name": "userVisibleOnly", "type": "boolean", "optional": true, "description": "For \\\"push\\\" permission, may specify userVisibleOnly. Note that userVisibleOnly = true is the only currently supported type.", "typeRef": null}, {"name": "allowWithoutSanitization", "type": "boolean", "optional": true, "description": "For \\\"clipboard\\\" permission, may specify allowWithoutSanitization.", "typeRef": null}, {"name": "allowWithoutGesture", "type": "boolean", "optional": true, "description": "For \\\"fullscreen\\\" permission, must specify allowWithoutGesture:true.", "typeRef": null}, {"name": "panTiltZoom", "type": "boolean", "optional": true, "description": "For \\\"camera\\\" permission, may specify panTiltZoom.", "typeRef": null}]);
 inspectorBackend.registerType("Browser.Bucket", [{"name": "low", "type": "number", "optional": false, "description": "Minimum value (inclusive).", "typeRef": null}, {"name": "high", "type": "number", "optional": false, "description": "Maximum value (exclusive).", "typeRef": null}, {"name": "count", "type": "number", "optional": false, "description": "Number of samples.", "typeRef": null}]);

package/front_end/generated/protocol-mapping.d.ts

@@ -1487,6 +1487,22 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.Browser.AddPrivacySandboxEnrollmentOverrideRequest];
       returnType: void;
     };
+    /**
+     * Gets the current globally-applied privacy control status
+     * See https://www.w3.org/TR/gpc/#get-global-privacy-control
+     */
+    'Browser.getGlobalPrivacyControl': {
+      paramsType: [];
+      returnType: Protocol.Browser.GetGlobalPrivacyControlResponse;
+    };
+    /**
+     * Sets and then gets the current globally-applied privacy control status
+     * See https://www.w3.org/TR/gpc/#set-global-privacy-control
+     */
+    'Browser.setGlobalPrivacyControl': {
+      paramsType: [Protocol.Browser.SetGlobalPrivacyControlRequest];
+      returnType: Protocol.Browser.SetGlobalPrivacyControlResponse;
+    };
     /**
      * Inserts a new rule with the given `ruleText` in a stylesheet with given `styleSheetId`, at the
      * position specified by `location`.

package/front_end/generated/protocol-proxy-api.d.ts

@@ -713,6 +713,18 @@ declare namespace ProtocolProxyApi {
      */
     invoke_addPrivacySandboxEnrollmentOverride(params: Protocol.Browser.AddPrivacySandboxEnrollmentOverrideRequest): Promise<Protocol.ProtocolResponseWithError>;
 
+    /**
+     * Gets the current globally-applied privacy control status
+     * See https://www.w3.org/TR/gpc/#get-global-privacy-control
+     */
+    invoke_getGlobalPrivacyControl(): Promise<Protocol.Browser.GetGlobalPrivacyControlResponse>;
+
+    /**
+     * Sets and then gets the current globally-applied privacy control status
+     * See https://www.w3.org/TR/gpc/#set-global-privacy-control
+     */
+    invoke_setGlobalPrivacyControl(params: Protocol.Browser.SetGlobalPrivacyControlRequest): Promise<Protocol.Browser.SetGlobalPrivacyControlResponse>;
+
   }
   export interface BrowserDispatcher {
     /**

package/front_end/generated/protocol.ts

@@ -2744,6 +2744,18 @@ export namespace Browser {
     url: string;
   }
 
+  export interface GetGlobalPrivacyControlResponse extends ProtocolResponseWithError {
+    gpc: boolean;
+  }
+
+  export interface SetGlobalPrivacyControlRequest {
+    gpc: boolean;
+  }
+
+  export interface SetGlobalPrivacyControlResponse extends ProtocolResponseWithError {
+    gpc: boolean;
+  }
+
   /**
    * Fired when page is about to start a download.
    */

package/front_end/models/ai_assistance/ExtensionScope.ts

@@ -100,18 +100,17 @@ export class ExtensionScope {
       ): Promise<{
     object: SDK.RemoteObject.RemoteObject,
   }> {
-    const response = await context.evaluate(
-        {
-          expression,
-          replMode: true,
-          includeCommandLineAPI: false,
-          returnByValue,
-          silent: false,
-          generatePreview: false,
-          allowUnsafeEvalBlockedByCSP: true,
-          throwOnSideEffect: false,
-        },
-        /* userGesture */ false, /* awaitPromise */ true);
+    const response = await context.evaluateWithSelectedFrameFallback({
+      expression,
+      replMode: true,
+      includeCommandLineAPI: false,
+      returnByValue,
+      silent: false,
+      generatePreview: false,
+      allowUnsafeEvalBlockedByCSP: true,
+      throwOnSideEffect: false,
+    },
+                                                                     /* userGesture */ false, /* awaitPromise */ true);
 
     if (!response) {
       throw new Error('Response is not found');

package/front_end/models/ai_assistance/agents/AiAgent.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as Host from '../../../core/host/host.js';
-import type {UrlString} from '../../../core/platform/DevToolsPath.js';
 import type * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
@@ -16,6 +15,7 @@ import {areOriginsEquivalent, extractContextOrigin, isOpaqueOrigin} from '../AiO
 import {debugLog, isStructuredLogEnabled} from '../debug.js';
 import type {ContextHandlerResult, DataHandlerResult} from '../tools/Tool.js';
 
+type UrlString = Platform.DevToolsPath.UrlString;
 const MAX_SUGGESTION_LENGTH = 200;
 
 export const enum ResponseType {

package/front_end/models/ai_assistance/agents/ContextSelectionAgent.ts

@@ -6,7 +6,6 @@ import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Root from '../../../core/root/root.js';
-import type {NetworkRequest} from '../../../core/sdk/NetworkRequest.js';
 import type * as SDK from '../../../core/sdk/sdk.js';
 import type * as LHModel from '../../lighthouse/lighthouse.js';
 import * as Logs from '../../logs/logs.js';
@@ -32,6 +31,8 @@ import {
   type RequestOptions,
 } from './AiAgent.js';
 
+type NetworkRequest = SDK.NetworkRequest.NetworkRequest;
+
 const lockedString = i18n.i18n.lockedString;
 /**
  * WARNING: preamble defined in code is only used when userTier is

package/front_end/models/ai_assistance/agents/PerformanceAgent.snapshot.txt

@@ -38,7 +38,7 @@ Content:
     "details": [
       {
         "title": "Trace details",
-        "text": "Trace summary:\nURL: https://chromedevtools.github.io/performance-stories/lcp-large-image/index.html\nTrace bounds: {min: 658799706428µs, max: 658804825864µs}\nCPU throttling: 1x\nNetwork throttling: No throttling\n\n# Available insight sets\n\nThe following is a list of insight sets. An insight set covers a specific part of the trace, split by navigations. The insights within each insight set are specific to that part of the trace. Be sure to consider the insight set id and bounds when calling functions. If no specific insight set or navigation is mentioned, assume the user is referring to the first one.\n\n## insight set id: NAVIGATION_0\n\nURL: https://chromedevtools.github.io/performance-stories/lcp-large-image/index.html\nBounds: {min: 658799738257µs, max: 658804825864µs}\nMetrics (lab / observed):\n  - LCP: 110 ms, event: (eventKey: r-2399, ts: 658799847880), nodeId: 10\n  - LCP breakdown:\n    - TTFB: 7 ms, bounds: {min: 658799738257µs, max: 658799745193µs}\n    - Load delay: 34 ms, bounds: {min: 658799745193µs, max: 658799778937µs}\n    - Load duration: 12 ms, bounds: {min: 658799778937µs, max: 658799791032µs}\n    - Render delay: 57 ms, bounds: {min: 658799791032µs, max: 658799847880µs}\n  - CLS: 0.00\nMetrics (field / real users): n/a – no data for this page in CrUX\nAvailable insights:\n  - insight name: LCPBreakdown\n    description: Each [subpart has specific improvement strategies](https://developer.chrome.com/docs/performance/insights/lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.\n    relevant trace bounds: {min: 658799738257µs, max: 658799847880µs}\n    example question: Help me optimize my LCP score\n    example question: Which LCP subpart was most problematic?\n    example question: What can I do to reduce the LCP time for this page load?\n  - insight name: LCPDiscovery\n    description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading\n    relevant trace bounds: {min: 658799745193µs, max: 658799793683µs}\n    example question: Suggest fixes to reduce my LCP\n    example question: What can I do to reduce my LCP discovery time?\n    example question: Why is LCP discovery time important?\n  - insight name: RenderBlocking\n    description: Requests are blocking the page’s initial render, which may delay LCP. [Deferring or inlining](https://developer.chrome.com/docs/performance/insights/render-blocking) can move these network requests out of the critical path.\n    relevant trace bounds: {min: 658799775876µs, max: 658799791419µs}\n    example question: Show me the most impactful render-blocking requests that I should focus on\n    example question: How can I reduce the number of render-blocking requests?\n  - insight name: Cache\n    description: A long cache lifetime can speed up repeat visits to your page. [Learn more about caching](https://developer.chrome.com/docs/performance/insights/cache).\n    relevant trace bounds: {min: 658799777502µs, max: 658799791419µs}\n    example question: What caching strategies can I apply to improve my page performance?\n# Critical network requests\n\nnone\n\n# Main thread bottom-up summary\n\nThis is the bottom-up summary for the entire trace. Only the top 10 activities (sorted by self time) are shown. An activity is all the aggregated time spent on the same type of work. For example, it can be all the time spent in a specific JavaScript function, or all the time spent in a specific browser rendering stage (like layout, v8 compile, parsing html). \"Self time\" represents the aggregated time spent directly in an activity, across all occurrences. \"Total time\" represents the aggregated time spent in an activity or any of its children.\n\n- self: 57 ms, total: 79 ms, source: Task\n- self: 5 ms, total: 5 ms, source: Layout\n- self: 4 ms, total: 4 ms, source: Major GC\n- self: 3 ms, total: 3 ms, source: Parse HTML\n- self: 2 ms, total: 2 ms, source: Recalculate style\n- self: 2 ms, total: 2 ms, source: Commit\n- self: 1 ms, total: 1 ms, source: C++ GC\n- self: 1 ms, total: 1 ms, source: Paint\n\n# 3rd party summary\n\n- name: GitHub, main thread time: 3 ms, network transfer size: 0 B\n\n# Longest tasks\n\n- total time: 23 ms, event: (eventKey: r-617, ts: 658799757023)\n- total time: 12 ms, event: (eventKey: r-1571, ts: 658799793885)\n- total time: 11 ms, event: (eventKey: r-1891, ts: 658799811130)\n\nUser selected the LCPBreakdown insight.\n\n\n# User query\n\ntest"
+        "text": "Trace summary:\nURL: https://chromedevtools.github.io/performance-stories/lcp-large-image/index.html\nTrace bounds: {min: 658799706428µs, max: 658804825864µs}\nCPU throttling: 1x\nNetwork throttling: No throttling\n\n# Available insight sets\n\nThe following is a list of insight sets. An insight set covers a specific part of the trace, split by navigations. The insights within each insight set are specific to that part of the trace. Be sure to consider the insight set id and bounds when calling functions. If no specific insight set or navigation is mentioned, assume the user is referring to the first one.\n\n## insight set id: NAVIGATION_0\n\nURL: https://chromedevtools.github.io/performance-stories/lcp-large-image/index.html\nBounds: {min: 658799738257µs, max: 658804825864µs}\nMetrics (lab / observed):\n  - LCP: 110 ms, event: (eventKey: r-2399, ts: 658799847880), nodeId: 10\n  - LCP breakdown:\n    - TTFB: 7 ms, bounds: {min: 658799738257µs, max: 658799745193µs}\n    - Load delay: 34 ms, bounds: {min: 658799745193µs, max: 658799778937µs}\n    - Load duration: 12 ms, bounds: {min: 658799778937µs, max: 658799791032µs}\n    - Render delay: 57 ms, bounds: {min: 658799791032µs, max: 658799847880µs}\n  - CLS: 0.00\nMetrics (field / real users): n/a – no data for this page in CrUX\nAvailable insights:\n  - insight name: LCPBreakdown\n    description: Each [subpart has specific improvement strategies](https://developer.chrome.com/docs/performance/insights/lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.\n    relevant trace bounds: {min: 658799738257µs, max: 658799847880µs}\n    example question: Help me optimize my LCP score\n    example question: Which LCP subpart was most problematic?\n    example question: What can I do to reduce the LCP time for this page load?\n  - insight name: LCPDiscovery\n    description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading.\n    relevant trace bounds: {min: 658799745193µs, max: 658799793683µs}\n    example question: Suggest fixes to reduce my LCP\n    example question: What can I do to reduce my LCP discovery time?\n    example question: Why is LCP discovery time important?\n  - insight name: RenderBlocking\n    description: Requests are blocking the page’s initial render, which may delay LCP. [Deferring or inlining](https://developer.chrome.com/docs/performance/insights/render-blocking) can move these network requests out of the critical path.\n    relevant trace bounds: {min: 658799775876µs, max: 658799791419µs}\n    example question: Show me the most impactful render-blocking requests that I should focus on\n    example question: How can I reduce the number of render-blocking requests?\n  - insight name: Cache\n    description: A long cache lifetime can speed up repeat visits to your page. [Learn more about caching](https://developer.chrome.com/docs/performance/insights/cache).\n    relevant trace bounds: {min: 658799777502µs, max: 658799791419µs}\n    example question: What caching strategies can I apply to improve my page performance?\n# Critical network requests\n\nnone\n\n# Main thread bottom-up summary\n\nThis is the bottom-up summary for the entire trace. Only the top 10 activities (sorted by self time) are shown. An activity is all the aggregated time spent on the same type of work. For example, it can be all the time spent in a specific JavaScript function, or all the time spent in a specific browser rendering stage (like layout, v8 compile, parsing html). \"Self time\" represents the aggregated time spent directly in an activity, across all occurrences. \"Total time\" represents the aggregated time spent in an activity or any of its children.\n\n- self: 57 ms, total: 79 ms, source: Task\n- self: 5 ms, total: 5 ms, source: Layout\n- self: 4 ms, total: 4 ms, source: Major GC\n- self: 3 ms, total: 3 ms, source: Parse HTML\n- self: 2 ms, total: 2 ms, source: Recalculate style\n- self: 2 ms, total: 2 ms, source: Commit\n- self: 1 ms, total: 1 ms, source: C++ GC\n- self: 1 ms, total: 1 ms, source: Paint\n\n# 3rd party summary\n\n- name: GitHub, main thread time: 3 ms, network transfer size: 0 B\n\n# Longest tasks\n\n- total time: 23 ms, event: (eventKey: r-617, ts: 658799757023)\n- total time: 12 ms, event: (eventKey: r-1571, ts: 658799793885)\n- total time: 11 ms, event: (eventKey: r-1891, ts: 658799811130)\n\nUser selected the LCPBreakdown insight.\n\n\n# User query\n\ntest"
       }
     ],
     "widgets": [

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -5,7 +5,6 @@
 import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
-import type {UrlString} from '../../../core/platform/DevToolsPath.js';
 import type * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
@@ -36,6 +35,8 @@ import {
   type ToolResult,
 } from './AiAgent.js';
 
+type UrlString = Platform.DevToolsPath.UrlString;
+
 const UIStringsNotTranslated = {
   /**
    * @description Shown when the agent is investigating network activity

package/front_end/models/ai_assistance/contexts/PerformanceTraceContext.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as Common from '../../../core/common/common.js';
-import type {UrlString} from '../../../core/platform/DevToolsPath.js';
 import type * as Platform from '../../../core/platform/platform.js';
 import * as SDK from '../../../core/sdk/sdk.js';
 import * as Tracing from '../../../services/tracing/tracing.js';
@@ -24,6 +23,8 @@ import {PerformanceTraceFormatter} from '../data_formatters/PerformanceTraceForm
 import type {AICallTree} from '../performance/AICallTree.js';
 import {AgentFocus} from '../performance/AIContext.js';
 
+type UrlString = Platform.DevToolsPath.UrlString;
+
 /**
  * Labels used to identify specific periods or categories in the trace for getting main thread summary.
  * Supports hardcoded phases, dynamic navigation IDs (`NAVIGATION_X`), and insight models.

package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.snapshot.txt

@@ -226,7 +226,7 @@ Response headers
 
 The result of the checks for this insight are:
 - fetchpriority=high should be applied: FAILED
-- LCP resources should not use loading=lazy: PASSED
+- LCP resources shouldn’t use loading=lazy: PASSED
 - Request is discoverable in initial document: PASSED
 
 ## Estimated savings: none
@@ -1052,7 +1052,7 @@ The network dependency tree checks revealed no problems, but optimization sugges
 
 No rendering tasks impacted by network dependencies.
 
-no origins were preconnected.
+No origins were preconnected.
 
 ## Estimated savings: none
 
@@ -1085,7 +1085,7 @@ The following is the critical request chain:
   - http://localhost:8787/lcp-iframes/app.js (eventKey: s-7225, ts: 566782574106) (5,015 ms) (longest chain)
   - http://localhost:8787/lcp-iframes/app.css (eventKey: s-7213, ts: 566782573909) (5,010 ms)
 
-no origins were preconnected.
+No origins were preconnected.
 
 ## Estimated savings: none
 
@@ -1097,13 +1097,13 @@ no origins were preconnected.
 
 Title: PerformanceInsightFormatter SlowCssSelector serializes correctly when there are no results
 Content:
-## Insight Title: CSS Selector costs
+## Insight Title: CSS selector costs
 
 ## Insight Summary:
 This insight identifies CSS selectors that are slowing down your page's rendering performance.
 
 ## Detailed analysis:
-No CSS selector data was found. CSS selector stats need to be enabled in the performance panel settings.
+No CSS selector data was found. CSS selector stats need to be enabled in the Performance panel settings.
 
 ## Estimated savings: none
 
@@ -1114,7 +1114,7 @@ No CSS selector data was found. CSS selector stats need to be enabled in the per
 
 Title: PerformanceInsightFormatter SlowCssSelector serializes the correct details when CSS selectors are found
 Content:
-## Insight Title: CSS Selector costs
+## Insight Title: CSS selector costs
 
 ## Insight Summary:
 This insight identifies CSS selectors that are slowing down your page's rendering performance.
@@ -1130,7 +1130,7 @@ Elapsed time: 0 ms
 Match attempts: 2444
 Match count: 465
 
-If Recalculate Style costs remain high, selector optimization can reduce them. [Optimize the selectors](https://developer.chrome.com/docs/performance/insights/slow-css-selector) with both high elapsed time and high slow-path %. Simpler selectors, fewer selectors, a smaller DOM, and a shallower DOM will all reduce matching costs.
+If recalculate style costs remain high, selector optimization can reduce them. [Optimize the selectors](https://developer.chrome.com/docs/performance/insights/slow-css-selector) with both high elapsed time and high slow-path %. Simpler selectors, fewer selectors, a smaller DOM, and a shallower DOM will all reduce matching costs.
 
 ## Estimated savings: none
 
@@ -1258,7 +1258,7 @@ The webpage is not optimized for mobile viewing.
 
 The viewport meta tag is missing.
 
-Tap interactions may be [delayed by up to 300 ms](https://developer.chrome.com/docs/performance/insights/viewport) if the viewport is not optimized for mobile.
+Tap interactions may be [delayed by up to 300 ms](https://developer.chrome.com/docs/performance/insights/viewport) if the viewport isn’t optimized for mobile.
 
 ## Estimated savings: none