chrome-devtools-frontend 1.0.1681091 → 1.0.1682249

package/front_end/generated/protocol.ts

@@ -2744,6 +2744,18 @@ export namespace Browser {
     url: string;
   }
 
+  export interface GetGlobalPrivacyControlResponse extends ProtocolResponseWithError {
+    gpc: boolean;
+  }
+
+  export interface SetGlobalPrivacyControlRequest {
+    gpc: boolean;
+  }
+
+  export interface SetGlobalPrivacyControlResponse extends ProtocolResponseWithError {
+    gpc: boolean;
+  }
+
   /**
    * Fired when page is about to start a download.
    */

package/front_end/models/ai_assistance/ExtensionScope.ts

@@ -100,18 +100,17 @@ export class ExtensionScope {
       ): Promise<{
     object: SDK.RemoteObject.RemoteObject,
   }> {
-    const response = await context.evaluate(
-        {
-          expression,
-          replMode: true,
-          includeCommandLineAPI: false,
-          returnByValue,
-          silent: false,
-          generatePreview: false,
-          allowUnsafeEvalBlockedByCSP: true,
-          throwOnSideEffect: false,
-        },
-        /* userGesture */ false, /* awaitPromise */ true);
+    const response = await context.evaluateWithSelectedFrameFallback({
+      expression,
+      replMode: true,
+      includeCommandLineAPI: false,
+      returnByValue,
+      silent: false,
+      generatePreview: false,
+      allowUnsafeEvalBlockedByCSP: true,
+      throwOnSideEffect: false,
+    },
+                                                                     /* userGesture */ false, /* awaitPromise */ true);
 
     if (!response) {
       throw new Error('Response is not found');

package/front_end/models/ai_assistance/agents/AiAgent.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as Host from '../../../core/host/host.js';
-import type {UrlString} from '../../../core/platform/DevToolsPath.js';
 import type * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
@@ -16,6 +15,7 @@ import {areOriginsEquivalent, extractContextOrigin, isOpaqueOrigin} from '../AiO
 import {debugLog, isStructuredLogEnabled} from '../debug.js';
 import type {ContextHandlerResult, DataHandlerResult} from '../tools/Tool.js';
 
+type UrlString = Platform.DevToolsPath.UrlString;
 const MAX_SUGGESTION_LENGTH = 200;
 
 export const enum ResponseType {

package/front_end/models/ai_assistance/agents/ContextSelectionAgent.ts

@@ -6,7 +6,6 @@ import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Root from '../../../core/root/root.js';
-import type {NetworkRequest} from '../../../core/sdk/NetworkRequest.js';
 import type * as SDK from '../../../core/sdk/sdk.js';
 import type * as LHModel from '../../lighthouse/lighthouse.js';
 import * as Logs from '../../logs/logs.js';
@@ -32,6 +31,8 @@ import {
   type RequestOptions,
 } from './AiAgent.js';
 
+type NetworkRequest = SDK.NetworkRequest.NetworkRequest;
+
 const lockedString = i18n.i18n.lockedString;
 /**
  * WARNING: preamble defined in code is only used when userTier is

package/front_end/models/ai_assistance/agents/PerformanceAgent.snapshot.txt

@@ -38,7 +38,7 @@ Content:
     "details": [
       {
         "title": "Trace details",
-        "text": "Trace summary:\nURL: https://chromedevtools.github.io/performance-stories/lcp-large-image/index.html\nTrace bounds: {min: 658799706428µs, max: 658804825864µs}\nCPU throttling: 1x\nNetwork throttling: No throttling\n\n# Available insight sets\n\nThe following is a list of insight sets. An insight set covers a specific part of the trace, split by navigations. The insights within each insight set are specific to that part of the trace. Be sure to consider the insight set id and bounds when calling functions. If no specific insight set or navigation is mentioned, assume the user is referring to the first one.\n\n## insight set id: NAVIGATION_0\n\nURL: https://chromedevtools.github.io/performance-stories/lcp-large-image/index.html\nBounds: {min: 658799738257µs, max: 658804825864µs}\nMetrics (lab / observed):\n  - LCP: 110 ms, event: (eventKey: r-2399, ts: 658799847880), nodeId: 10\n  - LCP breakdown:\n    - TTFB: 7 ms, bounds: {min: 658799738257µs, max: 658799745193µs}\n    - Load delay: 34 ms, bounds: {min: 658799745193µs, max: 658799778937µs}\n    - Load duration: 12 ms, bounds: {min: 658799778937µs, max: 658799791032µs}\n    - Render delay: 57 ms, bounds: {min: 658799791032µs, max: 658799847880µs}\n  - CLS: 0.00\nMetrics (field / real users): n/a – no data for this page in CrUX\nAvailable insights:\n  - insight name: LCPBreakdown\n    description: Each [subpart has specific improvement strategies](https://developer.chrome.com/docs/performance/insights/lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.\n    relevant trace bounds: {min: 658799738257µs, max: 658799847880µs}\n    example question: Help me optimize my LCP score\n    example question: Which LCP subpart was most problematic?\n    example question: What can I do to reduce the LCP time for this page load?\n  - insight name: LCPDiscovery\n    description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading\n    relevant trace bounds: {min: 658799745193µs, max: 658799793683µs}\n    example question: Suggest fixes to reduce my LCP\n    example question: What can I do to reduce my LCP discovery time?\n    example question: Why is LCP discovery time important?\n  - insight name: RenderBlocking\n    description: Requests are blocking the page’s initial render, which may delay LCP. [Deferring or inlining](https://developer.chrome.com/docs/performance/insights/render-blocking) can move these network requests out of the critical path.\n    relevant trace bounds: {min: 658799775876µs, max: 658799791419µs}\n    example question: Show me the most impactful render-blocking requests that I should focus on\n    example question: How can I reduce the number of render-blocking requests?\n  - insight name: Cache\n    description: A long cache lifetime can speed up repeat visits to your page. [Learn more about caching](https://developer.chrome.com/docs/performance/insights/cache).\n    relevant trace bounds: {min: 658799777502µs, max: 658799791419µs}\n    example question: What caching strategies can I apply to improve my page performance?\n# Critical network requests\n\nnone\n\n# Main thread bottom-up summary\n\nThis is the bottom-up summary for the entire trace. Only the top 10 activities (sorted by self time) are shown. An activity is all the aggregated time spent on the same type of work. For example, it can be all the time spent in a specific JavaScript function, or all the time spent in a specific browser rendering stage (like layout, v8 compile, parsing html). \"Self time\" represents the aggregated time spent directly in an activity, across all occurrences. \"Total time\" represents the aggregated time spent in an activity or any of its children.\n\n- self: 57 ms, total: 79 ms, source: Task\n- self: 5 ms, total: 5 ms, source: Layout\n- self: 4 ms, total: 4 ms, source: Major GC\n- self: 3 ms, total: 3 ms, source: Parse HTML\n- self: 2 ms, total: 2 ms, source: Recalculate style\n- self: 2 ms, total: 2 ms, source: Commit\n- self: 1 ms, total: 1 ms, source: C++ GC\n- self: 1 ms, total: 1 ms, source: Paint\n\n# 3rd party summary\n\n- name: GitHub, main thread time: 3 ms, network transfer size: 0 B\n\n# Longest tasks\n\n- total time: 23 ms, event: (eventKey: r-617, ts: 658799757023)\n- total time: 12 ms, event: (eventKey: r-1571, ts: 658799793885)\n- total time: 11 ms, event: (eventKey: r-1891, ts: 658799811130)\n\nUser selected the LCPBreakdown insight.\n\n\n# User query\n\ntest"
+        "text": "Trace summary:\nURL: https://chromedevtools.github.io/performance-stories/lcp-large-image/index.html\nTrace bounds: {min: 658799706428µs, max: 658804825864µs}\nCPU throttling: 1x\nNetwork throttling: No throttling\n\n# Available insight sets\n\nThe following is a list of insight sets. An insight set covers a specific part of the trace, split by navigations. The insights within each insight set are specific to that part of the trace. Be sure to consider the insight set id and bounds when calling functions. If no specific insight set or navigation is mentioned, assume the user is referring to the first one.\n\n## insight set id: NAVIGATION_0\n\nURL: https://chromedevtools.github.io/performance-stories/lcp-large-image/index.html\nBounds: {min: 658799738257µs, max: 658804825864µs}\nMetrics (lab / observed):\n  - LCP: 110 ms, event: (eventKey: r-2399, ts: 658799847880), nodeId: 10\n  - LCP breakdown:\n    - TTFB: 7 ms, bounds: {min: 658799738257µs, max: 658799745193µs}\n    - Load delay: 34 ms, bounds: {min: 658799745193µs, max: 658799778937µs}\n    - Load duration: 12 ms, bounds: {min: 658799778937µs, max: 658799791032µs}\n    - Render delay: 57 ms, bounds: {min: 658799791032µs, max: 658799847880µs}\n  - CLS: 0.00\nMetrics (field / real users): n/a – no data for this page in CrUX\nAvailable insights:\n  - insight name: LCPBreakdown\n    description: Each [subpart has specific improvement strategies](https://developer.chrome.com/docs/performance/insights/lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.\n    relevant trace bounds: {min: 658799738257µs, max: 658799847880µs}\n    example question: Help me optimize my LCP score\n    example question: Which LCP subpart was most problematic?\n    example question: What can I do to reduce the LCP time for this page load?\n  - insight name: LCPDiscovery\n    description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading.\n    relevant trace bounds: {min: 658799745193µs, max: 658799793683µs}\n    example question: Suggest fixes to reduce my LCP\n    example question: What can I do to reduce my LCP discovery time?\n    example question: Why is LCP discovery time important?\n  - insight name: RenderBlocking\n    description: Requests are blocking the page’s initial render, which may delay LCP. [Deferring or inlining](https://developer.chrome.com/docs/performance/insights/render-blocking) can move these network requests out of the critical path.\n    relevant trace bounds: {min: 658799775876µs, max: 658799791419µs}\n    example question: Show me the most impactful render-blocking requests that I should focus on\n    example question: How can I reduce the number of render-blocking requests?\n  - insight name: Cache\n    description: A long cache lifetime can speed up repeat visits to your page. [Learn more about caching](https://developer.chrome.com/docs/performance/insights/cache).\n    relevant trace bounds: {min: 658799777502µs, max: 658799791419µs}\n    example question: What caching strategies can I apply to improve my page performance?\n# Critical network requests\n\nnone\n\n# Main thread bottom-up summary\n\nThis is the bottom-up summary for the entire trace. Only the top 10 activities (sorted by self time) are shown. An activity is all the aggregated time spent on the same type of work. For example, it can be all the time spent in a specific JavaScript function, or all the time spent in a specific browser rendering stage (like layout, v8 compile, parsing html). \"Self time\" represents the aggregated time spent directly in an activity, across all occurrences. \"Total time\" represents the aggregated time spent in an activity or any of its children.\n\n- self: 57 ms, total: 79 ms, source: Task\n- self: 5 ms, total: 5 ms, source: Layout\n- self: 4 ms, total: 4 ms, source: Major GC\n- self: 3 ms, total: 3 ms, source: Parse HTML\n- self: 2 ms, total: 2 ms, source: Recalculate style\n- self: 2 ms, total: 2 ms, source: Commit\n- self: 1 ms, total: 1 ms, source: C++ GC\n- self: 1 ms, total: 1 ms, source: Paint\n\n# 3rd party summary\n\n- name: GitHub, main thread time: 3 ms, network transfer size: 0 B\n\n# Longest tasks\n\n- total time: 23 ms, event: (eventKey: r-617, ts: 658799757023)\n- total time: 12 ms, event: (eventKey: r-1571, ts: 658799793885)\n- total time: 11 ms, event: (eventKey: r-1891, ts: 658799811130)\n\nUser selected the LCPBreakdown insight.\n\n\n# User query\n\ntest"
       }
     ],
     "widgets": [

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -5,7 +5,6 @@
 import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
-import type {UrlString} from '../../../core/platform/DevToolsPath.js';
 import type * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
@@ -36,6 +35,8 @@ import {
   type ToolResult,
 } from './AiAgent.js';
 
+type UrlString = Platform.DevToolsPath.UrlString;
+
 const UIStringsNotTranslated = {
   /**
    * @description Shown when the agent is investigating network activity

package/front_end/models/ai_assistance/contexts/PerformanceTraceContext.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as Common from '../../../core/common/common.js';
-import type {UrlString} from '../../../core/platform/DevToolsPath.js';
 import type * as Platform from '../../../core/platform/platform.js';
 import * as SDK from '../../../core/sdk/sdk.js';
 import * as Tracing from '../../../services/tracing/tracing.js';
@@ -24,6 +23,8 @@ import {PerformanceTraceFormatter} from '../data_formatters/PerformanceTraceForm
 import type {AICallTree} from '../performance/AICallTree.js';
 import {AgentFocus} from '../performance/AIContext.js';
 
+type UrlString = Platform.DevToolsPath.UrlString;
+
 /**
  * Labels used to identify specific periods or categories in the trace for getting main thread summary.
  * Supports hardcoded phases, dynamic navigation IDs (`NAVIGATION_X`), and insight models.

package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.snapshot.txt

@@ -226,7 +226,7 @@ Response headers
 
 The result of the checks for this insight are:
 - fetchpriority=high should be applied: FAILED
-- LCP resources should not use loading=lazy: PASSED
+- LCP resources shouldn’t use loading=lazy: PASSED
 - Request is discoverable in initial document: PASSED
 
 ## Estimated savings: none
@@ -1052,7 +1052,7 @@ The network dependency tree checks revealed no problems, but optimization sugges
 
 No rendering tasks impacted by network dependencies.
 
-no origins were preconnected.
+No origins were preconnected.
 
 ## Estimated savings: none
 
@@ -1085,7 +1085,7 @@ The following is the critical request chain:
   - http://localhost:8787/lcp-iframes/app.js (eventKey: s-7225, ts: 566782574106) (5,015 ms) (longest chain)
   - http://localhost:8787/lcp-iframes/app.css (eventKey: s-7213, ts: 566782573909) (5,010 ms)
 
-no origins were preconnected.
+No origins were preconnected.
 
 ## Estimated savings: none
 
@@ -1097,13 +1097,13 @@ no origins were preconnected.
 
 Title: PerformanceInsightFormatter SlowCssSelector serializes correctly when there are no results
 Content:
-## Insight Title: CSS Selector costs
+## Insight Title: CSS selector costs
 
 ## Insight Summary:
 This insight identifies CSS selectors that are slowing down your page's rendering performance.
 
 ## Detailed analysis:
-No CSS selector data was found. CSS selector stats need to be enabled in the performance panel settings.
+No CSS selector data was found. CSS selector stats need to be enabled in the Performance panel settings.
 
 ## Estimated savings: none
 
@@ -1114,7 +1114,7 @@ No CSS selector data was found. CSS selector stats need to be enabled in the per
 
 Title: PerformanceInsightFormatter SlowCssSelector serializes the correct details when CSS selectors are found
 Content:
-## Insight Title: CSS Selector costs
+## Insight Title: CSS selector costs
 
 ## Insight Summary:
 This insight identifies CSS selectors that are slowing down your page's rendering performance.
@@ -1130,7 +1130,7 @@ Elapsed time: 0 ms
 Match attempts: 2444
 Match count: 465
 
-If Recalculate Style costs remain high, selector optimization can reduce them. [Optimize the selectors](https://developer.chrome.com/docs/performance/insights/slow-css-selector) with both high elapsed time and high slow-path %. Simpler selectors, fewer selectors, a smaller DOM, and a shallower DOM will all reduce matching costs.
+If recalculate style costs remain high, selector optimization can reduce them. [Optimize the selectors](https://developer.chrome.com/docs/performance/insights/slow-css-selector) with both high elapsed time and high slow-path %. Simpler selectors, fewer selectors, a smaller DOM, and a shallower DOM will all reduce matching costs.
 
 ## Estimated savings: none
 
@@ -1258,7 +1258,7 @@ The webpage is not optimized for mobile viewing.
 
 The viewport meta tag is missing.
 
-Tap interactions may be [delayed by up to 300 ms](https://developer.chrome.com/docs/performance/insights/viewport) if the viewport is not optimized for mobile.
+Tap interactions may be [delayed by up to 300 ms](https://developer.chrome.com/docs/performance/insights/viewport) if the viewport isn’t optimized for mobile.
 
 ## Estimated savings: none
 

package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.snapshot.txt

@@ -530,7 +530,7 @@ Available insights:
     relevant trace bounds: {min: 157423489126µs, max: 157426527569µs}
     example question: How do I optimize my network dependency tree?
   - insight name: ImageDelivery
-    description: Reducing the download time of images can improve the perceived load time of the page and LCP. [Learn more about optimizing image size](https://developer.chrome.com/docs/performance/insights/image-delivery)
+    description: Reducing the download time of images can improve the perceived load time of the page and LCP. [Learn more about optimizing image size](https://developer.chrome.com/docs/performance/insights/image-delivery).
     relevant trace bounds: {min: 157423794709µs, max: 157424082831µs}
     estimated metric savings: FCP 0 ms, LCP 0 ms
     estimated wasted bytes: 97.8 kB
@@ -552,7 +552,7 @@ Available insights:
     estimated wasted bytes: 847.4 kB
     example question: What caching strategies can I apply to improve my page performance?
   - insight name: LegacyJavaScript
-    description: Polyfills and transforms enable older browsers to use new JavaScript features. However, many aren’t necessary for modern browsers. Consider modifying your JavaScript build process to not transpile [Baseline](https://web.dev/articles/baseline-and-polyfills) features, unless you know you must support older browsers. [Learn why most sites can deploy ES6+ code without transpiling](https://developer.chrome.com/docs/performance/insights/legacy-javascript)
+    description: Polyfills and transforms enable older browsers to use new JavaScript features. However, many aren’t necessary for modern browsers. Consider modifying your JavaScript build process to not transpile [Baseline](https://web.dev/articles/baseline-and-polyfills) features, unless you know you must support older browsers. [Learn why most sites can deploy ES6+ code without transpiling](https://developer.chrome.com/docs/performance/insights/legacy-javascript).
     relevant trace bounds: {min: 157423489126µs, max: 157426132225µs}
     estimated metric savings: FCP 0 ms, LCP 0 ms
     estimated wasted bytes: 126.9 kB
@@ -660,7 +660,7 @@ Available insights:
     estimated wasted bytes: 971.5 kB
     example question: What caching strategies can I apply to improve my page performance?
   - insight name: ImageDelivery
-    description: Reducing the download time of images can improve the perceived load time of the page and LCP. [Learn more about optimizing image size](https://developer.chrome.com/docs/performance/insights/image-delivery)
+    description: Reducing the download time of images can improve the perceived load time of the page and LCP. [Learn more about optimizing image size](https://developer.chrome.com/docs/performance/insights/image-delivery).
     relevant trace bounds: {min: 59728701403µs, max: 59729395208µs}
     estimated metric savings: FCP 0 ms, LCP 100 ms
     estimated wasted bytes: 2 MB
@@ -673,7 +673,7 @@ Available insights:
     example question: Which LCP subpart was most problematic?
     example question: What can I do to reduce the LCP time for this page load?
   - insight name: LCPDiscovery
-    description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading
+    description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading.
     relevant trace bounds: {min: 59728656735µs, max: 59729209036µs}
     example question: Suggest fixes to reduce my LCP
     example question: What can I do to reduce my LCP discovery time?
@@ -691,7 +691,7 @@ Available insights:
     example question: How do I decrease the initial loading time of my page?
     example question: Did anything slow down the request for this document?
   - insight name: Viewport
-    description: Tap interactions may be [delayed by up to 300 ms](https://developer.chrome.com/docs/performance/insights/viewport) if the viewport is not optimized for mobile.
+    description: Tap interactions may be [delayed by up to 300 ms](https://developer.chrome.com/docs/performance/insights/viewport) if the viewport isn’t optimized for mobile.
     relevant trace bounds: {min: 59728649746µs, max: 59734400108µs}
     estimated metric savings: INP 0 ms
     example question: How do I make sure my page is optimized for mobile viewing?
@@ -744,7 +744,7 @@ Available insights:
     estimated wasted bytes: 971.5 kB
     example question: What caching strategies can I apply to improve my page performance?
   - insight name: ImageDelivery
-    description: Reducing the download time of images can improve the perceived load time of the page and LCP. [Learn more about optimizing image size](https://developer.chrome.com/docs/performance/insights/image-delivery)
+    description: Reducing the download time of images can improve the perceived load time of the page and LCP. [Learn more about optimizing image size](https://developer.chrome.com/docs/performance/insights/image-delivery).
     relevant trace bounds: {min: 59728701403µs, max: 59729395208µs}
     estimated metric savings: FCP 0 ms, LCP 100 ms
     estimated wasted bytes: 2 MB
@@ -757,7 +757,7 @@ Available insights:
     example question: Which LCP subpart was most problematic?
     example question: What can I do to reduce the LCP time for this page load?
   - insight name: LCPDiscovery
-    description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading
+    description: [Optimize LCP](https://developer.chrome.com/docs/performance/insights/lcp-discovery) by making the LCP image discoverable from the HTML immediately, and avoiding lazy-loading.
     relevant trace bounds: {min: 59728656735µs, max: 59729209036µs}
     example question: Suggest fixes to reduce my LCP
     example question: What can I do to reduce my LCP discovery time?
@@ -775,7 +775,7 @@ Available insights:
     example question: How do I decrease the initial loading time of my page?
     example question: Did anything slow down the request for this document?
   - insight name: Viewport
-    description: Tap interactions may be [delayed by up to 300 ms](https://developer.chrome.com/docs/performance/insights/viewport) if the viewport is not optimized for mobile.
+    description: Tap interactions may be [delayed by up to 300 ms](https://developer.chrome.com/docs/performance/insights/viewport) if the viewport isn’t optimized for mobile.
     relevant trace bounds: {min: 59728649746µs, max: 59734400108µs}
     estimated metric savings: INP 0 ms
     example question: How do I make sure my page is optimized for mobile viewing?

package/front_end/models/ai_code_completion/debug.ts

@@ -6,8 +6,10 @@
  * @file Local debugging utilities.
  */
 
+import * as Platform from '../../core/platform/platform.js';
+
 export function isDebugMode(): boolean {
-  return Boolean(localStorage.getItem('debugAiCodeCompletionEnabled'));
+  return Boolean(Platform.HostRuntime.HOST_RUNTIME.getLocalStorage()?.getItem('debugAiCodeCompletionEnabled'));
 }
 
 export function debugLog(...log: unknown[]): void {
@@ -20,10 +22,11 @@ export function debugLog(...log: unknown[]): void {
 }
 
 function setDebugAiCodeCompletionEnabled(enabled: boolean): void {
+  const localStorage = Platform.HostRuntime.HOST_RUNTIME.getLocalStorage();
   if (enabled) {
-    localStorage.setItem('debugAiCodeCompletionEnabled', 'true');
+    localStorage?.setItem('debugAiCodeCompletionEnabled', 'true');
   } else {
-    localStorage.removeItem('debugAiCodeCompletionEnabled');
+    localStorage?.removeItem('debugAiCodeCompletionEnabled');
   }
 }
 // @ts-expect-error

package/front_end/models/ai_code_generation/debug.ts

@@ -6,8 +6,10 @@
  * @file Local debugging utilities.
  */
 
+import * as Platform from '../../core/platform/platform.js';
+
 export function isDebugMode(): boolean {
-  return Boolean(localStorage.getItem('debugAiCodeGenerationEnabled'));
+  return Boolean(Platform.HostRuntime.HOST_RUNTIME.getLocalStorage()?.getItem('debugAiCodeGenerationEnabled'));
 }
 
 export function debugLog(...log: unknown[]): void {
@@ -20,10 +22,11 @@ export function debugLog(...log: unknown[]): void {
 }
 
 function setDebugAiCodeGenerationEnabled(enabled: boolean): void {
+  const localStorage = Platform.HostRuntime.HOST_RUNTIME.getLocalStorage();
   if (enabled) {
-    localStorage.setItem('debugAiCodeGenerationEnabled', 'true');
+    localStorage?.setItem('debugAiCodeGenerationEnabled', 'true');
   } else {
-    localStorage.removeItem('debugAiCodeGenerationEnabled');
+    localStorage?.removeItem('debugAiCodeGenerationEnabled');
   }
 }
 // @ts-expect-error

package/front_end/models/badges/UserBadges.ts

@@ -13,6 +13,13 @@ import {DOMDetectiveBadge} from './DOMDetectiveBadge.js';
 import {SpeedsterBadge} from './SpeedsterBadge.js';
 import {StarterBadge} from './StarterBadge.js';
 
+export const receiveGdpBadgesSettingDescriptor: Common.Settings.SettingDescriptor<boolean> = {
+  name: 'receive-gdp-badges',
+  type: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: false,
+  storageType: Common.Settings.SettingStorageType.SYNCED,
+};
+
 type BadgeClass = new (badgeContext: BadgeContext) => Badge;
 
 export const enum BadgeTriggerReason {
@@ -36,7 +43,7 @@ const DELAY_BEFORE_TRIGGER = 1500;
 export class UserBadges extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   readonly #badgeActionEventTarget = new Common.ObjectWrapper.ObjectWrapper<BadgeActionEvents>();
 
-  #receiveBadgesSetting: Common.Settings.Setting<Boolean>;
+  #receiveBadgesSetting: Common.Settings.Setting<boolean>;
   #allBadges: Badge[];
 
   #starterBadgeSnoozeCount: Common.Settings.Setting<number>;
@@ -66,7 +73,7 @@ export class UserBadges extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
     this.#gdpClient = gdpClient;
     this.#inspectorFrontendHost = inspectorFrontendHost;
 
-    this.#receiveBadgesSetting = this.#settings.moduleSetting('receive-gdp-badges');
+    this.#receiveBadgesSetting = this.#settings.resolve(receiveGdpBadgesSettingDescriptor);
     if (!Host.GdpClient.isBadgesEnabled()) {
       this.#receiveBadgesSetting.set(false);
     }

package/front_end/models/bindings/DebuggerLanguagePlugins.ts

@@ -11,6 +11,7 @@ import * as SDK from '../../core/sdk/sdk.js';
 import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as Protocol from '../../generated/protocol.js';
 import * as StackTrace from '../stack_trace/stack_trace.js';
+// eslint-disable-next-line @devtools/es-modules-import
 import type * as StackTraceImpl from '../stack_trace/stack_trace_impl.js';
 import * as Workspace from '../workspace/workspace.js';
 

package/front_end/models/emulation/DeviceModeModel.ts

@@ -317,7 +317,7 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
   #updateFitScale(): void {
     if (this.#type === Type.Device && this.#device && this.#mode) {
       const orientation = this.#device.orientationByName(this.#mode.orientation);
-      this.#scaleSetting.set(this.calculateFitScale(orientation.width, orientation.height, this.currentInsets()));
+      this.#scaleSetting.set(this.calculateFitScale(orientation.width, orientation.height));
     }
   }
 
@@ -595,13 +595,6 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     return Math.floor(this.#preferredSize.height / (this.#scaleSetting.get() || 1));
   }
 
-  private currentInsets(): Insets {
-    if (this.#type !== Type.Device || !this.#mode) {
-      return new Insets(0, 0, 0, 0);
-    }
-    return this.#mode.insets;
-  }
-
   private currentSafeAreaInsets(): Insets|null {
     if (!Root.Runtime.hostConfig.devToolsMobileSafeAreaEmulation?.enabled) {
       return null;
@@ -650,22 +643,21 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     }
     if (this.#type === Type.Device && this.#device && this.#mode) {
       const orientation = this.#device.orientationByName(this.#mode.orientation);
-      const insets = this.currentInsets();
-      this.#fitScale = this.calculateFitScale(orientation.width, orientation.height, insets);
+      this.#fitScale = this.calculateFitScale(orientation.width, orientation.height);
       if (mobile) {
         this.#appliedUserAgentType = this.#device.touch() ? UA.MOBILE : UA.MOBILE_NO_TOUCH;
       } else {
         this.#appliedUserAgentType = this.#device.touch() ? UA.DESKTOP_TOUCH : UA.DESKTOP;
       }
-      this.applyDeviceMetrics(new Geometry.Size(orientation.width, orientation.height), insets,
-                              this.#scaleSetting.get(), this.#device.deviceScaleFactor, mobile,
-                              this.getScreenOrientationType(), resetPageScaleFactor);
+      this.applyDeviceMetrics(new Geometry.Size(orientation.width, orientation.height), this.#scaleSetting.get(),
+                              this.#device.deviceScaleFactor, mobile, this.getScreenOrientationType(),
+                              resetPageScaleFactor);
       this.applyUserAgent(this.#device.userAgent, this.#device.userAgentMetadata);
       this.applyTouch(this.#device.touch(), mobile);
     } else if (this.#type === Type.None) {
       this.#fitScale = this.calculateFitScale(this.#availableSize.width, this.#availableSize.height);
       this.#appliedUserAgentType = UA.DESKTOP;
-      this.applyDeviceMetrics(this.#availableSize, new Insets(0, 0, 0, 0), 1, 0, mobile, null, resetPageScaleFactor);
+      this.applyDeviceMetrics(this.#availableSize, 1, 0, mobile, null, resetPageScaleFactor);
       this.applyUserAgent('', null);
       this.applyTouch(false, false);
     } else if (this.#type === Type.Responsive) {
@@ -680,8 +672,7 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
       const defaultDeviceScaleFactor = mobile ? defaultMobileScaleFactor : 0;
       this.#fitScale = this.calculateFitScale(this.#widthSetting.get(), this.#heightSetting.get());
       this.#appliedUserAgentType = this.#uaSetting.get();
-      this.applyDeviceMetrics(new Geometry.Size(screenWidth, screenHeight), new Insets(0, 0, 0, 0),
-                              this.#scaleSetting.get(),
+      this.applyDeviceMetrics(new Geometry.Size(screenWidth, screenHeight), this.#scaleSetting.get(),
                               this.#deviceScaleFactorSetting.get() || defaultDeviceScaleFactor, mobile,
                               screenHeight >= screenWidth ? Protocol.Emulation.ScreenOrientationType.PortraitPrimary :
                                                             Protocol.Emulation.ScreenOrientationType.LandscapePrimary,
@@ -701,9 +692,7 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     this.dispatchEventToListeners(Events.UPDATED);
   }
 
-  private calculateFitScale(screenWidth: number, screenHeight: number, insets?: Insets): number {
-    const insetsWidth = insets ? insets.left + insets.right : 0;
-    const insetsHeight = insets ? insets.top + insets.bottom : 0;
+  private calculateFitScale(screenWidth: number, screenHeight: number): number {
     let scale = Math.min(screenWidth ? this.#preferredSize.width / screenWidth : 1,
                          screenHeight ? this.#preferredSize.height / screenHeight : 1);
     scale = Math.min(Math.floor(scale * 100), 100);
@@ -712,10 +701,10 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     while (sharpScale > scale * 0.7) {
       let sharp = true;
       if (screenWidth) {
-        sharp = sharp && Number.isInteger((screenWidth - insetsWidth) * sharpScale / 100);
+        sharp = sharp && Number.isInteger(screenWidth * sharpScale / 100);
       }
       if (screenHeight) {
-        sharp = sharp && Number.isInteger((screenHeight - insetsHeight) * sharpScale / 100);
+        sharp = sharp && Number.isInteger(screenHeight * sharpScale / 100);
       }
       if (sharp) {
         return sharpScale / 100;
@@ -738,17 +727,17 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     this.#multitargetNetworkManager.setUserAgentOverride(userAgent, userAgent ? userAgentMetadata : null);
   }
 
-  private applyDeviceMetrics(screenSize: Geometry.Size, insets: Insets, scale: number, deviceScaleFactor: number,
-                             mobile: boolean, screenOrientation: Protocol.Emulation.ScreenOrientationType|null,
+  private applyDeviceMetrics(screenSize: Geometry.Size, scale: number, deviceScaleFactor: number, mobile: boolean,
+                             screenOrientation: Protocol.Emulation.ScreenOrientationType|null,
                              resetPageScaleFactor: boolean): void {
     screenSize.width = Math.max(1, Math.floor(screenSize.width));
     screenSize.height = Math.max(1, Math.floor(screenSize.height));
 
-    let pageWidth: 0|number = screenSize.width - insets.left - insets.right;
-    let pageHeight: 0|number = screenSize.height - insets.top - insets.bottom;
+    let pageWidth: 0|number = screenSize.width;
+    let pageHeight: 0|number = screenSize.height;
 
-    const positionX = insets.left;
-    const positionY = insets.top;
+    const positionX = 0;
+    const positionY = 0;
     const screenOrientationAngle =
         screenOrientation === Protocol.Emulation.ScreenOrientationType.LandscapePrimary ? 90 : 0;