chrome-devtools-frontend 1.0.1679704 → 1.0.1681498
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/AUTHORS +1 -0
- package/front_end/core/platform/TypescriptUtilities.ts +0 -9
- package/front_end/core/platform/platform.ts +1 -1
- package/front_end/core/sdk/ConsoleModel.ts +6 -3
- package/front_end/core/sdk/DOMModel.ts +110 -0
- package/front_end/core/sdk/EmulationModel.ts +4 -2
- package/front_end/core/sdk/NetworkManager.ts +15 -9
- package/front_end/core/sdk/OverlayModel.ts +3 -2
- package/front_end/core/sdk/PageResourceLoader.ts +4 -3
- package/front_end/core/sdk/RuntimeModel.ts +5 -3
- package/front_end/core/sdk/SDKSettings.ts +66 -0
- package/front_end/entrypoints/inspector_main/RenderingOptions.ts +4 -2
- package/front_end/entrypoints/inspector_main/inspector_main-meta.ts +32 -0
- package/front_end/entrypoints/main/MainImpl.ts +1 -1
- package/front_end/entrypoints/main/main-meta.ts +82 -0
- package/front_end/entrypoints/shell/shell.ts +0 -3
- package/front_end/entrypoints/trace_app/trace_app.ts +0 -3
- package/front_end/generated/InspectorBackendCommands.ts +3 -1
- package/front_end/generated/SupportedCSSProperties.ts +20 -0
- package/front_end/generated/protocol-mapping.d.ts +7 -0
- package/front_end/generated/protocol-proxy-api.d.ts +5 -0
- package/front_end/generated/protocol.ts +15 -3
- package/front_end/models/ai_code_completion/debug.ts +6 -3
- package/front_end/models/ai_code_generation/debug.ts +6 -3
- package/front_end/models/badges/UserBadges.ts +9 -2
- package/front_end/models/emulation/DeviceModeModel.ts +16 -27
- package/front_end/models/emulation/EmulatedDevices.ts +30 -125
- package/front_end/models/extensions/ExtensionAPI.ts +34 -23
- package/front_end/models/logs/NetworkLog.ts +3 -3
- package/front_end/models/logs/logs-meta.ts +0 -60
- package/front_end/models/persistence/NetworkPersistenceManager.ts +7 -1
- package/front_end/panels/application/ServiceWorkersView.ts +1 -1
- package/front_end/panels/application/StorageView.ts +2 -0
- package/front_end/panels/common/BadgeNotification.ts +1 -1
- package/front_end/panels/common/ExtensionPanel.ts +12 -7
- package/front_end/panels/common/ExtensionServer.ts +76 -16
- package/front_end/panels/common/GdpSignUpDialog.ts +1 -1
- package/front_end/panels/console/ConsoleView.ts +4 -2
- package/front_end/panels/console/ConsoleViewMessage.ts +3 -2
- package/front_end/panels/console/console-meta.ts +19 -5
- package/front_end/panels/elements/CSSRuleValidator.ts +12 -12
- package/front_end/panels/elements/CSSSpecificityBreakdown.ts +1 -1
- package/front_end/panels/elements/ClassesPaneWidget.ts +6 -6
- package/front_end/panels/elements/ColorSwatchPopoverIcon.ts +1 -1
- package/front_end/panels/elements/ComputedStyleWidget.ts +4 -5
- package/front_end/panels/elements/DOMTreeContextMenu.ts +538 -0
- package/front_end/panels/elements/ElementIssueUtils.ts +20 -20
- package/front_end/panels/elements/ElementStatePaneWidget.ts +6 -6
- package/front_end/panels/elements/ElementsPanel.ts +10 -10
- package/front_end/panels/elements/ElementsTreeElement.ts +47 -514
- package/front_end/panels/elements/ElementsTreeOutline.ts +168 -297
- package/front_end/panels/elements/EventListenersWidget.ts +8 -8
- package/front_end/panels/elements/LayersWidget.ts +4 -4
- package/front_end/panels/elements/LayoutPane.ts +11 -11
- package/front_end/panels/elements/MarkerDecorator.ts +3 -3
- package/front_end/panels/elements/PlatformFontsWidget.ts +8 -8
- package/front_end/panels/elements/PropertiesWidget.ts +4 -4
- package/front_end/panels/elements/PropertyRenderer.ts +2 -2
- package/front_end/panels/elements/ShortcutTreeElement.ts +1 -1
- package/front_end/panels/elements/StylePropertiesSection.ts +14 -14
- package/front_end/panels/elements/StylePropertyTreeElement.ts +21 -21
- package/front_end/panels/elements/StylesSidebarPane.ts +14 -14
- package/front_end/panels/elements/components/AccessibilityTreeNode.ts +1 -1
- package/front_end/panels/elements/components/CSSHintDetailsView.ts +1 -1
- package/front_end/panels/elements/components/CSSVariableValueView.ts +3 -3
- package/front_end/panels/elements/components/ElementsBreadcrumbsUtils.ts +2 -2
- package/front_end/panels/elements/components/ElementsTreeExpandButton.ts +1 -1
- package/front_end/panels/elements/elements-meta.ts +13 -13
- package/front_end/panels/elements/elements.ts +3 -0
- package/front_end/panels/issues/AffectedCookiesView.ts +2 -0
- package/front_end/panels/issues/AffectedElementsView.ts +5 -0
- package/front_end/panels/issues/CorsIssueDetailsView.ts +13 -9
- package/front_end/panels/issues/IssueView.ts +7 -2
- package/front_end/panels/layer_viewer/LayerDetailsView.ts +11 -7
- package/front_end/panels/layer_viewer/LayerTreeOutline.ts +2 -0
- package/front_end/panels/mobile_throttling/NetworkPanelIndicator.ts +3 -1
- package/front_end/panels/network/NetworkConfigView.ts +2 -1
- package/front_end/panels/network/NetworkLogView.ts +5 -2
- package/front_end/panels/network/NetworkOverview.ts +11 -5
- package/front_end/panels/network/NetworkPanel.ts +3 -2
- package/front_end/panels/network/NetworkWaterfallColumn.ts +16 -3
- package/front_end/panels/network/RequestHeadersView.ts +4 -4
- package/front_end/panels/network/components/ResponseHeaderSection.ts +6 -2
- package/front_end/panels/network/network-meta.ts +117 -0
- package/front_end/panels/profiler/HeapDetachedElementsDataGrid.ts +2 -1
- package/front_end/panels/profiler/ProfileLauncherView.ts +19 -16
- package/front_end/panels/profiler/ProfileSidebarTreeElement.ts +1 -1
- package/front_end/panels/security/security.ts +6 -0
- package/front_end/panels/settings/components/SyncSection.ts +1 -1
- package/front_end/panels/settings/emulation/DevicesSettingsTab.ts +0 -3
- package/front_end/panels/sources/NavigatorView.ts +6 -2
- package/front_end/panels/sources/SourcesNavigator.ts +8 -4
- package/front_end/panels/sources/SourcesPanel.ts +4 -2
- package/front_end/panels/sources/SourcesSearchScope.ts +3 -1
- package/front_end/panels/sources/SourcesView.ts +8 -107
- package/front_end/panels/sources/TabbedEditorContainer.ts +110 -7
- package/front_end/panels/sources/UISourceCodeFrame.ts +2 -2
- package/front_end/panels/sources/sources-meta.ts +16 -0
- package/front_end/panels/timeline/TimelineLoader.ts +1 -1
- package/front_end/panels/timeline/TimelineUIUtils.ts +6 -0
- package/front_end/panels/timeline/components/LayoutShiftDetails.ts +4 -3
- package/front_end/panels/timeline/components/LiveMetricsView.ts +1 -1
- package/front_end/panels/timeline/components/MetricCard.ts +4 -3
- package/front_end/panels/timeline/components/NetworkRequestDetails.ts +5 -2
- package/front_end/panels/timeline/components/TimelineRangeSummaryView.ts +1 -1
- package/front_end/panels/timeline/components/TimelineSummary.ts +8 -5
- package/front_end/panels/web_audio/WebAudioView.ts +8 -0
- package/front_end/third_party/chromium/README.chromium +1 -1
- package/front_end/third_party/web-vitals/rebuild.sh +1 -1
- package/front_end/ui/legacy/TabbedPane.ts +34 -2
- package/front_end/ui/legacy/components/color_picker/ContrastDetails.ts +11 -11
- package/front_end/ui/legacy/components/color_picker/FormatPickerContextMenu.ts +1 -1
- package/front_end/ui/legacy/components/color_picker/Spectrum.ts +19 -20
- package/front_end/ui/legacy/components/object_ui/ObjectPopoverHelper.ts +2 -2
- package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +164 -325
- package/front_end/ui/legacy/components/quick_open/CommandMenu.ts +5 -5
- package/front_end/ui/legacy/components/quick_open/FilteredListWidget.ts +7 -7
- package/front_end/ui/legacy/components/quick_open/QuickOpen.ts +1 -1
- package/front_end/ui/legacy/components/quick_open/quick_open-meta.ts +2 -2
- package/front_end/ui/visual_logging/KnownContextValues.ts +40 -0
- package/mcp/mcp.ts +0 -3
- package/package.json +1 -1
- package/front_end/core/sdk/sdk-meta.ts +0 -178
- package/front_end/models/badges/badges-meta.ts +0 -27
- package/front_end/models/persistence/persistence-meta.ts +0 -69
|
@@ -49,8 +49,8 @@ import {html, nothing, render} from '../../ui/lit/lit.js';
|
|
|
49
49
|
import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
|
|
50
50
|
|
|
51
51
|
import {AdoptedStyleSheetSetTreeElement, AdoptedStyleSheetTreeElement} from './AdoptedStyleSheetTreeElement.js';
|
|
52
|
+
import {showContextMenu} from './DOMTreeContextMenu.js';
|
|
52
53
|
import {getElementIssueDetails} from './ElementIssueUtils.js';
|
|
53
|
-
import {ElementsPanel} from './ElementsPanel.js';
|
|
54
54
|
import {ElementsTreeElement, InitialChildrenLimit, isOpeningTag} from './ElementsTreeElement.js';
|
|
55
55
|
import elementsTreeOutlineStyles from './elementsTreeOutline.css.js';
|
|
56
56
|
import {ImagePreviewPopover} from './ImagePreviewPopover.js';
|
|
@@ -60,15 +60,11 @@ import {TopLayerContainer} from './TopLayerContainer.js';
|
|
|
60
60
|
|
|
61
61
|
const UIStrings = {
|
|
62
62
|
/**
|
|
63
|
-
* @description ARIA accessible name in
|
|
63
|
+
* @description ARIA accessible name in the DOM tree outline of the Elements panel.
|
|
64
64
|
*/
|
|
65
65
|
pageDom: 'Page DOM',
|
|
66
66
|
/**
|
|
67
|
-
* @description
|
|
68
|
-
*/
|
|
69
|
-
storeAsGlobalVariable: 'Store as global variable',
|
|
70
|
-
/**
|
|
71
|
-
* @description Tree element expand all button element button text content in Elements Tree Outline of the Elements panel
|
|
67
|
+
* @description Text for the button to expand all tree nodes in the DOM tree outline of the Elements panel.
|
|
72
68
|
* @example {3} PH1
|
|
73
69
|
*/
|
|
74
70
|
showAllNodesDMore: 'Show all nodes ({PH1} more)',
|
|
@@ -78,9 +74,9 @@ const UIStrings = {
|
|
|
78
74
|
*/
|
|
79
75
|
showAllLines: 'Show all ({PH1} lines)',
|
|
80
76
|
/**
|
|
81
|
-
* @description Text for popover that directs to Issues panel
|
|
77
|
+
* @description Text for popover that directs to the Issues panel.
|
|
82
78
|
*/
|
|
83
|
-
viewIssue: 'View
|
|
79
|
+
viewIssue: 'View issue:',
|
|
84
80
|
} as const;
|
|
85
81
|
const str_ = i18n.i18n.registerUIStrings('panels/elements/ElementsTreeOutline.ts', UIStrings);
|
|
86
82
|
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
|
|
@@ -121,6 +117,7 @@ interface ViewInput {
|
|
|
121
117
|
|
|
122
118
|
interface ViewOutput {
|
|
123
119
|
elementsTreeOutline?: ElementsTreeOutline;
|
|
120
|
+
imagePreviewPopover?: ImagePreviewPopover;
|
|
124
121
|
highlightedTreeElement: ElementsTreeElement|null;
|
|
125
122
|
isUpdatingHighlights: boolean;
|
|
126
123
|
alreadyExpandedParentTreeElement: ElementsTreeElement|null;
|
|
@@ -131,27 +128,102 @@ export const DEFAULT_VIEW = (input: ViewInput, output: ViewOutput, target: HTMLE
|
|
|
131
128
|
// FIXME: this is basically a ref to existing imperative
|
|
132
129
|
// implementation. Once this is declarative the ref should not be
|
|
133
130
|
// needed.
|
|
134
|
-
|
|
135
|
-
|
|
136
|
-
|
|
137
|
-
output.elementsTreeOutline
|
|
138
|
-
|
|
139
|
-
|
|
140
|
-
|
|
141
|
-
|
|
142
|
-
|
|
143
|
-
|
|
144
|
-
|
|
131
|
+
const elementsTreeOutline = new ElementsTreeOutline(input.omitRootDOMNode, input.selectEnabled, input.hideGutter,
|
|
132
|
+
input.maxTreeDepth, input.enableContextMenu, input.showComments,
|
|
133
|
+
input.showAIButton, input.disableEdits, input.expandRoot);
|
|
134
|
+
output.elementsTreeOutline = elementsTreeOutline;
|
|
135
|
+
elementsTreeOutline.addEventListener(ElementsTreeOutline.Events.SelectedNodeChanged, input.onSelectedNodeChanged,
|
|
136
|
+
this);
|
|
137
|
+
elementsTreeOutline.addEventListener(ElementsTreeOutline.Events.ElementsTreeUpdated, input.onElementsTreeUpdated,
|
|
138
|
+
this);
|
|
139
|
+
elementsTreeOutline.addEventListener(UI.TreeOutline.Events.ElementExpanded, input.onElementExpanded, this);
|
|
140
|
+
elementsTreeOutline.addEventListener(UI.TreeOutline.Events.ElementCollapsed, input.onElementCollapsed, this);
|
|
141
|
+
elementsTreeOutline.addEventListener(ElementsTreeOutline.Events.ShowAllRows, () => {
|
|
142
|
+
if (elementsTreeOutline.maxRowsShown) {
|
|
145
143
|
// Set max to undefined to show all rows
|
|
146
|
-
|
|
144
|
+
elementsTreeOutline.maxRowsShown = undefined;
|
|
147
145
|
}
|
|
148
146
|
}, this);
|
|
149
|
-
|
|
147
|
+
elementsTreeOutline.elementInternal.addEventListener('contextmenu', (event: MouseEvent) => {
|
|
148
|
+
const treeElement = elementsTreeOutline.treeElementFromEventInternal(event);
|
|
149
|
+
if (treeElement instanceof ElementsTreeElement) {
|
|
150
|
+
output.elementsTreeOutline?.showContextMenu(treeElement, event);
|
|
151
|
+
}
|
|
152
|
+
}, false);
|
|
153
|
+
output.imagePreviewPopover = new ImagePreviewPopover(
|
|
154
|
+
elementsTreeOutline.contentElement,
|
|
155
|
+
event => {
|
|
156
|
+
let link: (Element|null) = (event.target as Element | null);
|
|
157
|
+
while (link && !ImagePreviewPopover.getImageURL(link)) {
|
|
158
|
+
link = link.parentElementOrShadowHost();
|
|
159
|
+
}
|
|
160
|
+
return link;
|
|
161
|
+
},
|
|
162
|
+
async link => {
|
|
163
|
+
const listItem = UI.UIUtils.enclosingNodeOrSelfWithNodeName(link, 'li');
|
|
164
|
+
if (!listItem) {
|
|
165
|
+
return undefined;
|
|
166
|
+
}
|
|
167
|
+
|
|
168
|
+
const treeElement =
|
|
169
|
+
(UI.TreeOutline.TreeElement.getTreeElementBylistItemNode(listItem) as ElementsTreeElement | undefined);
|
|
170
|
+
return await UIComponentUtils.ImagePreview.loadPrecomputedFeatures(treeElement?.node());
|
|
171
|
+
});
|
|
172
|
+
// TODO(changhaohan): refactor the popover to use tooltip component.
|
|
173
|
+
const popupHelper = new UI.PopoverHelper.PopoverHelper(elementsTreeOutline.elementInternal, event => {
|
|
174
|
+
const hoveredNode = event.composedPath()[0];
|
|
175
|
+
if (!(hoveredNode instanceof Element) || !hoveredNode.matches('.violating-element')) {
|
|
176
|
+
return null;
|
|
177
|
+
}
|
|
178
|
+
|
|
179
|
+
const issues = elementsTreeOutline.issuesByNodeElement(hoveredNode);
|
|
180
|
+
if (!issues) {
|
|
181
|
+
return null;
|
|
182
|
+
}
|
|
183
|
+
|
|
184
|
+
return {
|
|
185
|
+
box: hoveredNode.boxInWindow(),
|
|
186
|
+
show: async (popover: UI.GlassPane.GlassPane) => {
|
|
187
|
+
popover.setIgnoreLeftMargin(true);
|
|
188
|
+
// clang-format off
|
|
189
|
+
render(html`
|
|
190
|
+
<div class="squiggles-content">
|
|
191
|
+
${issues.map(issue => {
|
|
192
|
+
const elementIssueDetails = getElementIssueDetails(issue);
|
|
193
|
+
if (!elementIssueDetails) {
|
|
194
|
+
// This shouldn't happen, but add this if check to pass ts check.
|
|
195
|
+
return nothing;
|
|
196
|
+
}
|
|
197
|
+
const issueKindIconName = IssueCounter.IssueCounter.getIssueKindIconName(issue.getKind());
|
|
198
|
+
const openIssueEvent = (): Promise<void> => Common.Revealer.reveal(issue);
|
|
199
|
+
return html`
|
|
200
|
+
<div class="squiggles-content-item">
|
|
201
|
+
<devtools-icon .name=${issueKindIconName} @click=${openIssueEvent}></devtools-icon>
|
|
202
|
+
<devtools-link class="link" @click=${openIssueEvent}>${i18nString(UIStrings.viewIssue)}</devtools-link>
|
|
203
|
+
<span>${elementIssueDetails.tooltip}</span>
|
|
204
|
+
</div>`;
|
|
205
|
+
})}
|
|
206
|
+
</div>`, popover.contentElement);
|
|
207
|
+
// clang-format on
|
|
208
|
+
return true;
|
|
209
|
+
},
|
|
210
|
+
};
|
|
211
|
+
}, 'elements.issue');
|
|
212
|
+
popupHelper.setTimeout(300);
|
|
213
|
+
target.appendChild(elementsTreeOutline.element);
|
|
150
214
|
}
|
|
151
215
|
|
|
152
216
|
output.elementsTreeOutline.maxTreeDepth = input.maxTreeDepth;
|
|
153
217
|
output.elementsTreeOutline.enableContextMenu = input.enableContextMenu ?? true;
|
|
154
|
-
output.elementsTreeOutline.
|
|
218
|
+
output.elementsTreeOutline.showContextMenu = (treeElement, event) => {
|
|
219
|
+
void showContextMenu(treeElement, event);
|
|
220
|
+
};
|
|
221
|
+
let needsUpdate = false;
|
|
222
|
+
const showComments = input.showComments ?? true;
|
|
223
|
+
if (output.elementsTreeOutline.showComments !== showComments) {
|
|
224
|
+
output.elementsTreeOutline.showComments = showComments;
|
|
225
|
+
needsUpdate = true;
|
|
226
|
+
}
|
|
155
227
|
output.elementsTreeOutline.showAIButton = input.showAIButton ?? true;
|
|
156
228
|
output.elementsTreeOutline.disableEdits = input.disableEdits ?? false;
|
|
157
229
|
output.elementsTreeOutline.expandRoot = input.expandRoot ?? false;
|
|
@@ -161,6 +233,9 @@ export const DEFAULT_VIEW = (input: ViewInput, output: ViewOutput, target: HTMLE
|
|
|
161
233
|
}
|
|
162
234
|
if (input.visible !== undefined) {
|
|
163
235
|
output.elementsTreeOutline.setVisible(input.visible);
|
|
236
|
+
if (!input.visible) {
|
|
237
|
+
output.imagePreviewPopover?.hide();
|
|
238
|
+
}
|
|
164
239
|
}
|
|
165
240
|
output.elementsTreeOutline.maxRowsShown = input.maxRowsShown;
|
|
166
241
|
output.elementsTreeOutline.setWordWrap(input.wrap);
|
|
@@ -168,6 +243,9 @@ export const DEFAULT_VIEW = (input: ViewInput, output: ViewOutput, target: HTMLE
|
|
|
168
243
|
if (input.deindentSingleNode) {
|
|
169
244
|
output.elementsTreeOutline.deindentSingleNode();
|
|
170
245
|
}
|
|
246
|
+
if (needsUpdate) {
|
|
247
|
+
output.elementsTreeOutline.update();
|
|
248
|
+
}
|
|
171
249
|
// Node highlighting logic. FIXME: express as a lit template.
|
|
172
250
|
const previousHighlightedNode = output.highlightedTreeElement?.node() ?? null;
|
|
173
251
|
if (previousHighlightedNode !== input.currentHighlightedNode) {
|
|
@@ -238,7 +316,8 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
238
316
|
|
|
239
317
|
#maxTreeDepth?: number;
|
|
240
318
|
#enableContextMenu = true;
|
|
241
|
-
#
|
|
319
|
+
#showHTMLCommentsSetting = Common.Settings.Settings.instance().moduleSetting('show-html-comments');
|
|
320
|
+
#showComments = this.#showHTMLCommentsSetting.get();
|
|
242
321
|
#showAIButton = true;
|
|
243
322
|
#disableEdits = false;
|
|
244
323
|
#expandRoot = false;
|
|
@@ -346,6 +425,7 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
346
425
|
delegatesFocus: false,
|
|
347
426
|
});
|
|
348
427
|
this.#view = view ?? DEFAULT_VIEW;
|
|
428
|
+
this.#showHTMLCommentsSetting.addChangeListener(this.#onShowHTMLCommentsChange, this);
|
|
349
429
|
if (Common.Settings.Settings.instance().moduleSetting('highlight-node-on-hover-in-overlay').get()) {
|
|
350
430
|
SDK.TargetManager.TargetManager.instance().addModelListener(
|
|
351
431
|
SDK.OverlayModel.OverlayModel, SDK.OverlayModel.Events.HIGHLIGHT_NODE_REQUESTED, this.#highlightNode, this,
|
|
@@ -356,6 +436,15 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
356
436
|
}
|
|
357
437
|
}
|
|
358
438
|
|
|
439
|
+
#onShowHTMLCommentsChange(): void {
|
|
440
|
+
this.#showComments = this.#showHTMLCommentsSetting.get();
|
|
441
|
+
const selectedNode = this.selectedDOMNode();
|
|
442
|
+
if (selectedNode && selectedNode.nodeType() === Node.COMMENT_NODE && !this.#showComments) {
|
|
443
|
+
this.selectDOMNode(selectedNode.parentNode);
|
|
444
|
+
}
|
|
445
|
+
this.performUpdate();
|
|
446
|
+
}
|
|
447
|
+
|
|
359
448
|
#highlightNode(event: Common.EventTarget.EventTargetEvent<SDK.DOMModel.DOMNode>): void {
|
|
360
449
|
void this.#highlightThrottler.schedule(() => {
|
|
361
450
|
this.#currentHighlightedNode = event.data;
|
|
@@ -425,40 +514,39 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
425
514
|
|
|
426
515
|
override performUpdate(): void {
|
|
427
516
|
const firstRender = !this.#viewOutput.elementsTreeOutline;
|
|
428
|
-
this.#view(
|
|
429
|
-
|
|
430
|
-
|
|
431
|
-
|
|
432
|
-
|
|
433
|
-
|
|
434
|
-
|
|
435
|
-
|
|
436
|
-
|
|
437
|
-
|
|
438
|
-
|
|
439
|
-
|
|
440
|
-
|
|
441
|
-
|
|
442
|
-
|
|
443
|
-
|
|
444
|
-
|
|
445
|
-
|
|
446
|
-
|
|
447
|
-
|
|
448
|
-
|
|
449
|
-
|
|
450
|
-
|
|
451
|
-
|
|
452
|
-
|
|
453
|
-
|
|
454
|
-
|
|
455
|
-
|
|
456
|
-
|
|
457
|
-
|
|
458
|
-
|
|
459
|
-
|
|
460
|
-
|
|
461
|
-
this.#viewOutput, this.contentElement);
|
|
517
|
+
this.#view({
|
|
518
|
+
omitRootDOMNode: this.omitRootDOMNode,
|
|
519
|
+
selectEnabled: this.selectEnabled,
|
|
520
|
+
hideGutter: this.hideGutter,
|
|
521
|
+
maxTreeDepth: this.#maxTreeDepth,
|
|
522
|
+
enableContextMenu: this.#enableContextMenu,
|
|
523
|
+
showComments: this.#showComments,
|
|
524
|
+
showAIButton: this.#showAIButton,
|
|
525
|
+
disableEdits: this.#disableEdits,
|
|
526
|
+
expandRoot: this.#expandRoot,
|
|
527
|
+
visibleWidth: this.#visibleWidth,
|
|
528
|
+
visible: this.#visible,
|
|
529
|
+
wrap: this.#wrap,
|
|
530
|
+
maxRowsShown: this.#maxRows,
|
|
531
|
+
showSelectionOnKeyboardFocus: this.showSelectionOnKeyboardFocus,
|
|
532
|
+
preventTabOrder: this.preventTabOrder,
|
|
533
|
+
deindentSingleNode: this.deindentSingleNode,
|
|
534
|
+
|
|
535
|
+
currentHighlightedNode: this.#currentHighlightedNode,
|
|
536
|
+
selectedNode: this.selectedDOMNode(),
|
|
537
|
+
onElementsTreeUpdated: this.onElementsTreeUpdated.bind(this),
|
|
538
|
+
onSelectedNodeChanged: event => {
|
|
539
|
+
this.#clearHighlightedNode();
|
|
540
|
+
this.onSelectedNodeChanged(event);
|
|
541
|
+
},
|
|
542
|
+
onElementCollapsed: () => {
|
|
543
|
+
this.#clearHighlightedNode();
|
|
544
|
+
},
|
|
545
|
+
onElementExpanded: () => {
|
|
546
|
+
this.#clearHighlightedNode();
|
|
547
|
+
},
|
|
548
|
+
},
|
|
549
|
+
this.#viewOutput, this.contentElement);
|
|
462
550
|
if (firstRender && this.#viewOutput.elementsTreeOutline) {
|
|
463
551
|
this.#viewOutput.elementsTreeOutline.addEventListener(ElementsTreeOutline.Events.ShowAllRows, () => {
|
|
464
552
|
this.maxRows = undefined;
|
|
@@ -529,7 +617,11 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
529
617
|
}
|
|
530
618
|
|
|
531
619
|
toggleHideElement(node: SDK.DOMModel.DOMNode): void {
|
|
532
|
-
void
|
|
620
|
+
void node.toggleHideElement();
|
|
621
|
+
}
|
|
622
|
+
|
|
623
|
+
isToggledToHidden(node: SDK.DOMModel.DOMNode): boolean {
|
|
624
|
+
return node.isToggledToHidden();
|
|
533
625
|
}
|
|
534
626
|
|
|
535
627
|
toggleEditAsHTML(node: SDK.DOMModel.DOMNode): void {
|
|
@@ -537,7 +629,7 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
537
629
|
}
|
|
538
630
|
|
|
539
631
|
duplicateNode(node: SDK.DOMModel.DOMNode): void {
|
|
540
|
-
|
|
632
|
+
node.duplicate();
|
|
541
633
|
}
|
|
542
634
|
|
|
543
635
|
copyStyles(node: SDK.DOMModel.DOMNode): void {
|
|
@@ -563,9 +655,18 @@ export class DOMTreeWidget extends UI.Widget.Widget {
|
|
|
563
655
|
this.performUpdate();
|
|
564
656
|
}
|
|
565
657
|
|
|
658
|
+
override wasHidden(): void {
|
|
659
|
+
super.wasHidden();
|
|
660
|
+
this.#visible = false;
|
|
661
|
+
this.#viewOutput.imagePreviewPopover?.hide();
|
|
662
|
+
this.performUpdate();
|
|
663
|
+
}
|
|
664
|
+
|
|
566
665
|
override detach(overrideHideOnDetach?: boolean): void {
|
|
567
666
|
super.detach(overrideHideOnDetach);
|
|
568
667
|
this.#visible = false;
|
|
668
|
+
this.#showHTMLCommentsSetting.removeChangeListener(this.#onShowHTMLCommentsChange, this);
|
|
669
|
+
this.#viewOutput.imagePreviewPopover?.hide();
|
|
569
670
|
this.performUpdate();
|
|
570
671
|
}
|
|
571
672
|
|
|
@@ -600,11 +701,9 @@ export class ElementsTreeOutline extends
|
|
|
600
701
|
private rootDOMNodeInternal: SDK.DOMModel.DOMNode|null;
|
|
601
702
|
selectedDOMNodeInternal: SDK.DOMModel.DOMNode|null;
|
|
602
703
|
private visible: boolean;
|
|
603
|
-
private readonly imagePreviewPopover: ImagePreviewPopover;
|
|
604
704
|
private updateRecords: Map<SDK.DOMModel.DOMNode, Elements.ElementUpdateRecord.ElementUpdateRecord>;
|
|
605
705
|
private treeElementsBeingUpdated: Set<ElementsTreeElement>;
|
|
606
706
|
decoratorExtensions: MarkerDecoratorRegistration[]|null;
|
|
607
|
-
private showHTMLCommentsSetting: Common.Settings.Setting<boolean>;
|
|
608
707
|
private multilineEditing?: MultilineEditorController|null;
|
|
609
708
|
private visibleWidthInternal?: number;
|
|
610
709
|
private clipboardNodeData?: ClipboardData;
|
|
@@ -616,7 +715,6 @@ export class ElementsTreeOutline extends
|
|
|
616
715
|
private updateModifiedNodesTimeout?: number;
|
|
617
716
|
#topLayerContainerByDocument = new WeakMap<SDK.DOMModel.DOMDocument, TopLayerContainer>();
|
|
618
717
|
#issuesManager?: IssuesManager.IssuesManager.IssuesManager;
|
|
619
|
-
#popupHelper?: UI.PopoverHelper.PopoverHelper;
|
|
620
718
|
#nodeElementToIssues = new Map<Element, IssuesManager.Issue.Issue[]>();
|
|
621
719
|
maxTreeDepth?: number;
|
|
622
720
|
enableContextMenu: boolean;
|
|
@@ -671,9 +769,6 @@ export class ElementsTreeOutline extends
|
|
|
671
769
|
this.elementInternal.addEventListener('clipboard-cut', this.onCopyOrCut.bind(this, true), false);
|
|
672
770
|
this.elementInternal.addEventListener('clipboard-paste', this.onPaste.bind(this), false);
|
|
673
771
|
}
|
|
674
|
-
if (this.enableContextMenu) {
|
|
675
|
-
this.elementInternal.addEventListener('contextmenu', this.contextMenuEventFired.bind(this), false);
|
|
676
|
-
}
|
|
677
772
|
|
|
678
773
|
outlineDisclosureElement.appendChild(this.elementInternal);
|
|
679
774
|
this.element = shadowContainer;
|
|
@@ -686,82 +781,11 @@ export class ElementsTreeOutline extends
|
|
|
686
781
|
|
|
687
782
|
this.visible = false;
|
|
688
783
|
|
|
689
|
-
this.imagePreviewPopover = new ImagePreviewPopover(
|
|
690
|
-
this.contentElement,
|
|
691
|
-
event => {
|
|
692
|
-
let link: (Element|null) = (event.target as Element | null);
|
|
693
|
-
while (link && !ImagePreviewPopover.getImageURL(link)) {
|
|
694
|
-
link = link.parentElementOrShadowHost();
|
|
695
|
-
}
|
|
696
|
-
return link;
|
|
697
|
-
},
|
|
698
|
-
async link => {
|
|
699
|
-
const listItem = UI.UIUtils.enclosingNodeOrSelfWithNodeName(link, 'li');
|
|
700
|
-
if (!listItem) {
|
|
701
|
-
return undefined;
|
|
702
|
-
}
|
|
703
|
-
|
|
704
|
-
const treeElement =
|
|
705
|
-
(UI.TreeOutline.TreeElement.getTreeElementBylistItemNode(listItem) as ElementsTreeElement | undefined);
|
|
706
|
-
return await UIComponentUtils.ImagePreview.loadPrecomputedFeatures(treeElement?.node());
|
|
707
|
-
});
|
|
708
|
-
|
|
709
784
|
this.updateRecords = new Map();
|
|
710
785
|
this.treeElementsBeingUpdated = new Set();
|
|
711
786
|
|
|
712
787
|
this.decoratorExtensions = null;
|
|
713
|
-
if (this.showComments) {
|
|
714
|
-
this.showHTMLCommentsSetting = Common.Settings.Settings.instance().moduleSetting('show-html-comments');
|
|
715
|
-
this.showHTMLCommentsSetting.addChangeListener(this.onShowHTMLCommentsChange.bind(this));
|
|
716
|
-
} else {
|
|
717
|
-
this.showHTMLCommentsSetting = {
|
|
718
|
-
get: () => false,
|
|
719
|
-
addChangeListener: () => {},
|
|
720
|
-
removeChangeListener: () => {},
|
|
721
|
-
} as unknown as Common.Settings.Setting<boolean>;
|
|
722
|
-
}
|
|
723
788
|
this.setUseLightSelectionColor(true);
|
|
724
|
-
// TODO(changhaohan): refactor the popover to use tooltip component.
|
|
725
|
-
this.#popupHelper = new UI.PopoverHelper.PopoverHelper(this.elementInternal, event => {
|
|
726
|
-
const hoveredNode = event.composedPath()[0] as Element;
|
|
727
|
-
if (!hoveredNode?.matches('.violating-element')) {
|
|
728
|
-
return null;
|
|
729
|
-
}
|
|
730
|
-
|
|
731
|
-
const issues = this.#nodeElementToIssues.get(hoveredNode);
|
|
732
|
-
if (!issues) {
|
|
733
|
-
return null;
|
|
734
|
-
}
|
|
735
|
-
|
|
736
|
-
return {
|
|
737
|
-
box: hoveredNode.boxInWindow(),
|
|
738
|
-
show: async (popover: UI.GlassPane.GlassPane) => {
|
|
739
|
-
popover.setIgnoreLeftMargin(true);
|
|
740
|
-
// clang-format off
|
|
741
|
-
render(html`
|
|
742
|
-
<div class="squiggles-content">
|
|
743
|
-
${issues.map(issue => {
|
|
744
|
-
const elementIssueDetails = getElementIssueDetails(issue);
|
|
745
|
-
if (!elementIssueDetails) {
|
|
746
|
-
// This shouldn't happen, but add this if check to pass ts check.
|
|
747
|
-
return nothing;
|
|
748
|
-
}
|
|
749
|
-
const issueKindIconName = IssueCounter.IssueCounter.getIssueKindIconName(issue.getKind());
|
|
750
|
-
const openIssueEvent = (): Promise<void> => Common.Revealer.reveal(issue);
|
|
751
|
-
return html`
|
|
752
|
-
<div class="squiggles-content-item">
|
|
753
|
-
<devtools-icon .name=${issueKindIconName} @click=${openIssueEvent}></devtools-icon>
|
|
754
|
-
<devtools-link class="link" @click=${openIssueEvent}>${i18nString(UIStrings.viewIssue)}</devtools-link>
|
|
755
|
-
<span>${elementIssueDetails.tooltip}</span>
|
|
756
|
-
</div>`;
|
|
757
|
-
})}
|
|
758
|
-
</div>`, popover.contentElement);
|
|
759
|
-
// clang-format on
|
|
760
|
-
return true;
|
|
761
|
-
},
|
|
762
|
-
};
|
|
763
|
-
}, 'elements.issue');
|
|
764
|
-
this.#popupHelper.setTimeout(300);
|
|
765
789
|
}
|
|
766
790
|
|
|
767
791
|
static forDOMModel(domModel: SDK.DOMModel.DOMModel): ElementsTreeOutline|null {
|
|
@@ -863,12 +887,8 @@ export class ElementsTreeOutline extends
|
|
|
863
887
|
this.#nodeElementToIssues.set(element, issues);
|
|
864
888
|
}
|
|
865
889
|
|
|
866
|
-
|
|
867
|
-
|
|
868
|
-
if (selectedNode && selectedNode.nodeType() === Node.COMMENT_NODE && !this.showHTMLCommentsSetting.get()) {
|
|
869
|
-
this.selectDOMNode(selectedNode.parentNode);
|
|
870
|
-
}
|
|
871
|
-
this.update();
|
|
890
|
+
issuesByNodeElement(element: Element): IssuesManager.Issue.Issue[]|undefined {
|
|
891
|
+
return this.#nodeElementToIssues.get(element);
|
|
872
892
|
}
|
|
873
893
|
|
|
874
894
|
setWordWrap(wrap: boolean): void {
|
|
@@ -993,7 +1013,7 @@ export class ElementsTreeOutline extends
|
|
|
993
1013
|
}
|
|
994
1014
|
|
|
995
1015
|
duplicateNode(targetNode: SDK.DOMModel.DOMNode): void {
|
|
996
|
-
|
|
1016
|
+
targetNode.duplicate();
|
|
997
1017
|
}
|
|
998
1018
|
|
|
999
1019
|
private onPaste(event: Event): void {
|
|
@@ -1031,26 +1051,12 @@ export class ElementsTreeOutline extends
|
|
|
1031
1051
|
}
|
|
1032
1052
|
}
|
|
1033
1053
|
|
|
1034
|
-
private performDuplicate(targetNode: SDK.DOMModel.DOMNode): void {
|
|
1035
|
-
if (targetNode.isInShadowTree()) {
|
|
1036
|
-
return;
|
|
1037
|
-
}
|
|
1038
|
-
|
|
1039
|
-
const parentNode = targetNode.parentNode ? targetNode.parentNode : targetNode;
|
|
1040
|
-
if (parentNode.nodeName() === '#document') {
|
|
1041
|
-
return;
|
|
1042
|
-
}
|
|
1043
|
-
|
|
1044
|
-
targetNode.copyTo(parentNode, targetNode.nextSibling);
|
|
1045
|
-
}
|
|
1046
|
-
|
|
1047
1054
|
setVisible(visible: boolean): void {
|
|
1048
1055
|
if (visible === this.visible) {
|
|
1049
1056
|
return;
|
|
1050
1057
|
}
|
|
1051
1058
|
this.visible = visible;
|
|
1052
1059
|
if (!this.visible) {
|
|
1053
|
-
this.imagePreviewPopover.hide();
|
|
1054
1060
|
if (this.multilineEditing) {
|
|
1055
1061
|
this.multilineEditing.cancel();
|
|
1056
1062
|
}
|
|
@@ -1534,65 +1540,7 @@ export class ElementsTreeOutline extends
|
|
|
1534
1540
|
}
|
|
1535
1541
|
}
|
|
1536
1542
|
|
|
1537
|
-
|
|
1538
|
-
const treeElement = this.treeElementFromEventInternal(event);
|
|
1539
|
-
if (treeElement instanceof ElementsTreeElement) {
|
|
1540
|
-
void this.showContextMenu(treeElement, event);
|
|
1541
|
-
}
|
|
1542
|
-
}
|
|
1543
|
-
|
|
1544
|
-
async showContextMenu(treeElement: ElementsTreeElement, event: Event): Promise<void> {
|
|
1545
|
-
if (UI.UIUtils.isEditing() || !this.enableContextMenu) {
|
|
1546
|
-
return;
|
|
1547
|
-
}
|
|
1548
|
-
|
|
1549
|
-
const node = (event.target as Node | null);
|
|
1550
|
-
if (!node) {
|
|
1551
|
-
return;
|
|
1552
|
-
}
|
|
1553
|
-
|
|
1554
|
-
// The context menu construction may be async. In order to
|
|
1555
|
-
// make sure that no other (default) context menu shows up, we need
|
|
1556
|
-
// to stop propagating and prevent the default action.
|
|
1557
|
-
event.stopPropagation();
|
|
1558
|
-
event.preventDefault();
|
|
1559
|
-
|
|
1560
|
-
const contextMenu = new UI.ContextMenu.ContextMenu(event);
|
|
1561
|
-
const isPseudoElement = Boolean(treeElement.node().pseudoType());
|
|
1562
|
-
const isTag = treeElement.node().nodeType() === Node.ELEMENT_NODE && !isPseudoElement;
|
|
1563
|
-
|
|
1564
|
-
let textNode: Element|null = node.enclosingNodeOrSelfWithClass('webkit-html-text-node');
|
|
1565
|
-
if (textNode?.classList.contains('bogus')) {
|
|
1566
|
-
textNode = null;
|
|
1567
|
-
}
|
|
1568
|
-
const commentNode = node.enclosingNodeOrSelfWithClass('webkit-html-comment');
|
|
1569
|
-
contextMenu.saveSection().appendItem(
|
|
1570
|
-
i18nString(UIStrings.storeAsGlobalVariable), this.saveNodeToTempVariable.bind(this, treeElement.node()),
|
|
1571
|
-
{jslogContext: 'store-as-global-variable'});
|
|
1572
|
-
if (textNode) {
|
|
1573
|
-
await treeElement.populateTextContextMenu(contextMenu, textNode);
|
|
1574
|
-
} else if (isTag) {
|
|
1575
|
-
await treeElement.populateTagContextMenu(contextMenu, event);
|
|
1576
|
-
} else if (commentNode) {
|
|
1577
|
-
await treeElement.populateNodeContextMenu(contextMenu);
|
|
1578
|
-
} else if (isPseudoElement) {
|
|
1579
|
-
treeElement.populatePseudoElementContextMenu(contextMenu);
|
|
1580
|
-
} else if (treeElement.node().nodeType() === Node.PROCESSING_INSTRUCTION_NODE) {
|
|
1581
|
-
await treeElement.populateProcessingElementContextMenu(contextMenu);
|
|
1582
|
-
}
|
|
1583
|
-
|
|
1584
|
-
ElementsPanel.instance().populateAdornerSettingsContextMenu(contextMenu);
|
|
1585
|
-
|
|
1586
|
-
contextMenu.appendApplicableItems(treeElement.node());
|
|
1587
|
-
void contextMenu.show();
|
|
1588
|
-
}
|
|
1589
|
-
|
|
1590
|
-
private async saveNodeToTempVariable(node: SDK.DOMModel.DOMNode): Promise<void> {
|
|
1591
|
-
const remoteObjectForConsole = await node.resolveToObject();
|
|
1592
|
-
const consoleModel = remoteObjectForConsole?.runtimeModel().target()?.model(SDK.ConsoleModel.ConsoleModel);
|
|
1593
|
-
await consoleModel?.saveToTempVariable(
|
|
1594
|
-
UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext), remoteObjectForConsole);
|
|
1595
|
-
}
|
|
1543
|
+
showContextMenu: (treeElement: ElementsTreeElement, event: Event) => void = () => {};
|
|
1596
1544
|
|
|
1597
1545
|
runPendingUpdates(): void {
|
|
1598
1546
|
this.updateModifiedNodes();
|
|
@@ -1701,94 +1649,17 @@ export class ElementsTreeOutline extends
|
|
|
1701
1649
|
return newTreeItem;
|
|
1702
1650
|
}
|
|
1703
1651
|
|
|
1704
|
-
/**
|
|
1705
|
-
* Runs a script on the node's remote object that toggles a class name on
|
|
1706
|
-
* the node and injects a stylesheet into the head of the node's document
|
|
1707
|
-
* containing a rule to set "visibility: hidden" on the class and all it's
|
|
1708
|
-
* ancestors.
|
|
1709
|
-
*/
|
|
1710
1652
|
async toggleHideElement(node: SDK.DOMModel.DOMNode): Promise<void> {
|
|
1711
|
-
|
|
1712
|
-
if (pseudoElementName && node.pseudoIdentifier()) {
|
|
1713
|
-
pseudoElementName += `(${node.pseudoIdentifier()})`;
|
|
1714
|
-
}
|
|
1715
|
-
|
|
1716
|
-
let effectiveNode: SDK.DOMModel.DOMNode|null = node;
|
|
1717
|
-
while (effectiveNode?.pseudoType()) {
|
|
1718
|
-
if (effectiveNode !== node && effectiveNode.pseudoType() === 'column') {
|
|
1719
|
-
// Ideally we would select the specific column pseudo element, but
|
|
1720
|
-
// we don't have a way to do that at the moment.
|
|
1721
|
-
pseudoElementName = '::column' + pseudoElementName;
|
|
1722
|
-
}
|
|
1723
|
-
effectiveNode = effectiveNode.parentNode;
|
|
1724
|
-
}
|
|
1725
|
-
if (!effectiveNode) {
|
|
1726
|
-
return;
|
|
1727
|
-
}
|
|
1728
|
-
|
|
1729
|
-
const hidden = node.marker('hidden-marker');
|
|
1730
|
-
const object = await effectiveNode.resolveToObject('');
|
|
1731
|
-
|
|
1732
|
-
if (!object) {
|
|
1733
|
-
return;
|
|
1734
|
-
}
|
|
1735
|
-
|
|
1736
|
-
await object.callFunction(
|
|
1737
|
-
(toggleClassAndInjectStyleRule as (this: Object, ...arg1: unknown[]) => void),
|
|
1738
|
-
[{value: pseudoElementName}, {value: !hidden}]);
|
|
1739
|
-
object.release();
|
|
1740
|
-
node.setMarker('hidden-marker', hidden ? null : true);
|
|
1741
|
-
|
|
1742
|
-
function toggleClassAndInjectStyleRule(this: Element, pseudoElementName: string|null, hidden: boolean): void {
|
|
1743
|
-
const classNamePrefix = '__web-inspector-hide';
|
|
1744
|
-
const classNameSuffix = '-shortcut__';
|
|
1745
|
-
const styleTagId = '__web-inspector-hide-shortcut-style__';
|
|
1746
|
-
const pseudoElementNameEscaped = pseudoElementName ? pseudoElementName.replace(/[\(\)\:]/g, '_') : '';
|
|
1747
|
-
const className = classNamePrefix + pseudoElementNameEscaped + classNameSuffix;
|
|
1748
|
-
this.classList.toggle(className, hidden);
|
|
1749
|
-
|
|
1750
|
-
let localRoot: Element|HTMLHeadElement = this;
|
|
1751
|
-
while (localRoot.parentNode) {
|
|
1752
|
-
localRoot = (localRoot.parentNode as Element);
|
|
1753
|
-
}
|
|
1754
|
-
if (localRoot.nodeType === Node.DOCUMENT_NODE) {
|
|
1755
|
-
localRoot = document.head;
|
|
1756
|
-
}
|
|
1757
|
-
|
|
1758
|
-
let style = localRoot.querySelector('style#' + styleTagId);
|
|
1759
|
-
if (!style) {
|
|
1760
|
-
const selectors = [];
|
|
1761
|
-
selectors.push('.__web-inspector-hide-shortcut__');
|
|
1762
|
-
selectors.push('.__web-inspector-hide-shortcut__ *');
|
|
1763
|
-
const selector = selectors.join(', ');
|
|
1764
|
-
const ruleBody = ' visibility: hidden !important;';
|
|
1765
|
-
const rule = '\n' + selector + '\n{\n' + ruleBody + '\n}\n';
|
|
1766
|
-
|
|
1767
|
-
style = document.createElement('style');
|
|
1768
|
-
style.id = styleTagId;
|
|
1769
|
-
style.textContent = rule;
|
|
1770
|
-
|
|
1771
|
-
localRoot.appendChild(style);
|
|
1772
|
-
}
|
|
1773
|
-
|
|
1774
|
-
// In addition to putting them on the element we want to hide, we will
|
|
1775
|
-
// also add pseudo element classes to the style element to keep track of
|
|
1776
|
-
// which pseudo elements we have style rules for.
|
|
1777
|
-
if (pseudoElementName && !style.classList.contains(className)) {
|
|
1778
|
-
style.classList.add(className);
|
|
1779
|
-
style.textContent = `.${className}${pseudoElementName}, ${style.textContent}`;
|
|
1780
|
-
}
|
|
1781
|
-
}
|
|
1653
|
+
await node.toggleHideElement();
|
|
1782
1654
|
}
|
|
1783
1655
|
|
|
1784
1656
|
isToggledToHidden(node: SDK.DOMModel.DOMNode): boolean {
|
|
1785
|
-
return
|
|
1657
|
+
return node.isToggledToHidden();
|
|
1786
1658
|
}
|
|
1787
1659
|
|
|
1788
1660
|
private reset(): void {
|
|
1789
1661
|
this.rootDOMNode = null;
|
|
1790
1662
|
this.selectDOMNode(null, false);
|
|
1791
|
-
this.imagePreviewPopover.hide();
|
|
1792
1663
|
delete this.clipboardNodeData;
|
|
1793
1664
|
SDK.OverlayModel.OverlayModel.hideDOMNodeHighlight(SDK.TargetManager.TargetManager.instance());
|
|
1794
1665
|
this.updateRecords.clear();
|
|
@@ -2117,7 +1988,7 @@ export class ElementsTreeOutline extends
|
|
|
2117
1988
|
if (node.childNodeCount()) {
|
|
2118
1989
|
// Children may be stale when the outline is not wired to receive DOMModel updates.
|
|
2119
1990
|
let children: SDK.DOMModel.DOMNode[] = node.children() || [];
|
|
2120
|
-
if (!this.
|
|
1991
|
+
if (!this.showComments) {
|
|
2121
1992
|
children = children.filter(n => n.nodeType() !== Node.COMMENT_NODE);
|
|
2122
1993
|
}
|
|
2123
1994
|
visibleChildren.push(...children);
|