chrome-devtools-frontend 1.0.1675430 → 1.0.1678416

package/AUTHORS

@@ -112,6 +112,7 @@ Varun Varada <varuncvarada@gmail.com>
 Vishwa Kalubowila <vishwa.kalubowila@codimite.com>
 Vitali Zaidman <vzaidman@gmail.com>
 Will Hernandez <w.hernandez.code@gmail.com>
+Yao Wu <ywu16212@gmail.com>
 Yeol Park <peary2@gmail.com>
 Yisi(一丝) <yiorsi@gmail.com>
 Yoichiro Hibara <hibarayoichiro871@gmail.com>

package/WATCHLISTS

@@ -13,9 +13,6 @@
     'all': {
       'filepath': '.',
     },
-    'chromedriver': {
-      'filepath': 'front_end/emulated_devices/',
-    },
     'lighthouse': {
       'filepath': '[Ll]ighthouse',
     },
@@ -26,7 +23,6 @@
 
   'WATCHLISTS': {
     'all': ['devtools-reviews+devtools@chromium.org'],
-    'chromedriver': [],
     'lighthouse': ['lighthouse-eng+devtools-cl@google.com'],
     'third_party': ['devtools-reviews+third_party@chromium.org'],
   },

package/front_end/core/common/EventTarget.ts

@@ -40,11 +40,6 @@ export interface EventTarget<Events> {
       ...[eventData]: EventPayloadToRestParameters<Events, T>): void;
 }
 
-export function fireEvent(name: string, detail: unknown = {}, target: HTMLElement|Window = window): void {
-  const evt = new CustomEvent(name, {bubbles: true, cancelable: true, detail});
-  target.dispatchEvent(evt);
-}
-
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export interface EventTargetEvent<T, Events = any> {
   data: T;

package/front_end/core/common/Settings.ts

@@ -10,7 +10,6 @@ import type {EventDescriptor, EventTargetEvent, GenericEvents} from './EventTarg
 import {ObjectWrapper} from './Object.js';
 import {
   getLocalizedSettingsCategory,
-  type LearnMore,
   maybeRemoveSettingExtension,
   type RegExpSettingItem,
   registerSettingExtension,
@@ -518,13 +517,6 @@ export class Setting<V> {
     this.eventSupport.removeEventListener(this.name, listener, thisObject);
   }
 
-  title(): Platform.UIString.LocalizedString {
-    if (this.#registration?.title) {
-      return this.#registration.title();
-    }
-    return '' as Platform.UIString.LocalizedString;
-  }
-
   setRequiresUserAction(requiresUserAction: boolean): void {
     this.#requiresUserAction = requiresUserAction;
   }
@@ -624,57 +616,6 @@ export class Setting<V> {
     return this.#type ?? this.#registration?.settingType ?? null;
   }
 
-  options(): SimpleSettingOption[] {
-    if (this.#registration && this.#registration.options) {
-      return this.#registration.options.map(opt => {
-        const {value, title, text, raw} = opt;
-        return {
-          value,
-          title: title(),
-          text: typeof text === 'function' ? text() : text,
-          raw,
-        };
-      });
-    }
-    return [];
-  }
-
-  reloadRequired(): boolean|null {
-    if (this.#registration) {
-      return this.#registration.reloadRequired || null;
-    }
-    return null;
-  }
-
-  category(): SettingCategory|null {
-    if (this.#registration) {
-      return this.#registration.category || null;
-    }
-    return null;
-  }
-
-  tags(): string|null {
-    if (this.#registration && this.#registration.tags) {
-      // Get localized keys and separate by null character to prevent fuzzy matching from matching across them.
-      return this.#registration.tags.map(tag => tag()).join('\0');
-    }
-    return null;
-  }
-
-  order(): number|null {
-    if (this.#registration) {
-      return this.#registration.order || null;
-    }
-    return null;
-  }
-
-  /**
-   * See {@link LearnMore} for more info
-   */
-  learnMore(): LearnMore|null {
-    return this.#registration?.learnMore ?? null;
-  }
-
   private printSettingsSavingError(message: string, value: string): void {
     const errorMessage =
         'Error saving setting with name: ' + this.name + ', value length: ' + value.length + '. Error: ' + message;
@@ -766,10 +707,3 @@ export {
   SettingRegistration,
   SettingType,
 };
-
-export interface SimpleSettingOption {
-  value: string|boolean;
-  title: string;
-  text?: string;
-  raw?: boolean;
-}

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -557,5 +557,6 @@ export const enum EnumeratedHistogram {
   SwatchActivated = 'DevTools.SwatchActivated',
   BuiltInAiAvailability = 'DevTools.BuiltInAiAvailability',
   ResendRequest = 'DevTools.ResendRequest',
+  EditResendRequest = 'DevTools.EditResendRequest',
   // LINT.ThenChange(/front_end/devtools_compatibility.js:EnumeratedHistogram)
 }

package/front_end/core/host/UserMetrics.ts

@@ -36,6 +36,11 @@ export class UserMetrics {
                                                             ResendRequestType.MAX_VALUE);
   }
 
+  editResendRequest(type: ResendRequestType): void {
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.EditResendRequest, type,
+                                                            ResendRequestType.MAX_VALUE);
+  }
+
   keybindSetSettingChanged(keybindSet: string): void {
     const value = KeybindSetSettings[keybindSet as keyof typeof KeybindSetSettings] || 0;
     InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.KeybindSetSettingChanged, value,

package/front_end/core/root/Runtime.ts

@@ -484,10 +484,6 @@ interface GdpProfilesAvailability {
   enterprisePolicyValue: GdpProfilesEnterprisePolicyValue;
 }
 
-interface LiveEdit {
-  enabled: boolean;
-}
-
 interface ExtensionsOnChromeUrls {
   enabled: boolean;
 }
@@ -544,6 +540,10 @@ interface HostConfigDevToolsComments {
   enabled: boolean;
 }
 
+interface DevToolsAriaLiveRecording {
+  enabled: boolean;
+}
+
 /**
  * The host configuration that we expect from the DevTools back-end.
  *
@@ -588,7 +588,6 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsGlobalAiButton: GlobalAiButton,
   devToolsGdpProfiles: GdpProfiles,
   devToolsGdpProfilesAvailability: GdpProfilesAvailability,
-  devToolsLiveEdit: LiveEdit,
   devToolsFlexibleLayout: DevToolsFlexibleLayout,
   deviceBoundSessionsDebugging: DeviceBoundSessionsDebugging,
   devToolsEnableDurableMessages: DevToolsEnableDurableMessages,
@@ -600,6 +599,7 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsAdsPanel: DevToolsAdsPanel,
   devToolsUseGcaApi: UseGcaApi,
   devToolsPlusButton: DevToolsPlusButton,
+  devToolsAriaLiveRecording: DevToolsAriaLiveRecording,
   devToolsInstrumentationBreakpoints: DevToolsInstrumentationBreakpoints,
   extensionsOnChromeUrls: ExtensionsOnChromeUrls,
   devToolsComments: HostConfigDevToolsComments,

package/front_end/core/sdk/CSSMetadata.ts

@@ -64,9 +64,6 @@ export class CSSMetadata {
       if (Boolean(runtimeFlagStatus) && runtimeFlagStatus !== 'stable') {
         continue;
       }
-      if (!CSS.supports(propertyName, 'initial')) {
-        continue;
-      }
       this.#values.push(propertyName);
 
       if (property.inherited) {
@@ -113,7 +110,7 @@ export class CSSMetadata {
     for (const propertyName of this.#longhands.keys()) {
       // skip "all" because it is a CSS-wide keyword
       // skip shorthands that are defined in generatedPropertyValues because they have their own value sets
-      if (propertyName === 'all' || propertyValueSets.has(propertyName)) {
+      if (propertyName === 'all' || propertyName in SupportedCSSProperties.generatedPropertyValues) {
         continue;
       }
       const longhands = this.#longhands.get(propertyName);
@@ -121,6 +118,10 @@ export class CSSMetadata {
         continue;
       }
       const values = new Array<string>();
+      const propertyValueSet = propertyValueSets.get(propertyName);
+      if (propertyValueSet) {
+        values.push(...propertyValueSet);
+      }
       for (const longhand of longhands) {
         const longhandValues = propertyValueSets.get(longhand);
         if (!longhandValues) {
@@ -143,11 +144,6 @@ export class CSSMetadata {
           }
         }
       }
-      for (const commonKeyword of CommonKeywords) {
-        if (!values.has(commonKeyword) && CSS.supports(propertyName, commonKeyword)) {
-          values.add(commonKeyword);
-        }
-      }
 
       this.#propertyValues.set(propertyName, [...values]);
     }

package/front_end/core/sdk/CSSPropertyParserMatchers.ts

@@ -156,42 +156,22 @@ export class VariableNameMatcher extends matcherBase(VariableNameMatch) {
   }
 
   override matches(node: CodeMirror.SyntaxNode, matching: BottomUpTreeMatching): VariableNameMatch|null {
-    if (node.name !== 'VariableName' && node.name !== 'FeatureName' && node.name !== 'KeywordQuery') {
-      // TODO(b/484268589): The result shouldn't be KeywordQuery, but currently
-      // sometimes Lezer parses it that way. Fix this when Lezer is fixed.
+    if (!node.parent) {
       return null;
     }
-    const rawText = matching.ast.text(node);
-    if (!rawText.startsWith('--')) {
+    // TODO(b/484268589): When the misspelling is removed from Lezer we can remove that case.
+    if (node.name !== 'FeatureName' && node.name !== 'PropertyName' && node.name !== 'ProperyName') {
       return null;
     }
-
-    let cur: CodeMirror.SyntaxNode|null = node.parent;
-    let foundStyleCall: CodeMirror.SyntaxNode|null = null;
-    while (cur) {
-      if (cur.name === 'CallExpression') {
-        return null;
-      }
-      if (cur.name === 'CallQuery') {
-        const callee = cur.getChild('QueryCallee');
-        if (callee && matching.ast.text(callee) === 'style') {
-          foundStyleCall = cur;
-          break;
-        }
-        return null;
-      }
-      cur = cur.parent;
+    if (node.parent.name !== 'StyleFeature' && node.parent.name !== 'StyleRange') {
+      return null;
     }
-
-    if (!foundStyleCall) {
+    const rawText = matching.ast.text(node);
+    if (!rawText.startsWith('--')) {
       return null;
     }
 
-    // When parsing style(--foo > 10px), Lezer thinks it is a KeywordQuery and
-    // includes the > in the token with --foo. We need to strip it.
-    const text = node.name === 'KeywordQuery' ? rawText.split(/\s|[>!=<:]/)[0] : rawText;
-
-    return new VariableNameMatch(node, text, this.matchedStyles, this.style);
+    return new VariableNameMatch(node, rawText, this.matchedStyles, this.style);
   }
 }
 
@@ -476,13 +456,14 @@ export class ColorMixMatcher extends matcherBase(ColorMixMatch) {
       return null;
     }
     const computedValueArgs = ASTUtils.callArgs(value);
-    if (computedValueArgs.length !== 3) {
+    if (computedValueArgs.length !== 2 && computedValueArgs.length !== 3) {
       return null;
     }
 
-    const [space, color1, color2] = computedValueArgs;
-    // Verify that all arguments are there, and that the space starts with a literal `in`.
-    if (space.length < 2 || computedValueTree.text(ASTUtils.stripComments(space).next().value) !== 'in' ||
+    const [space, color1, color2] = computedValueArgs.length === 3 ? computedValueArgs : [[], ...computedValueArgs];
+    // Verify that all arguments are there, and that an optional interpolation method starts with a literal `in`.
+    if ((space.length > 0 &&
+         (space.length < 2 || computedValueTree.text(ASTUtils.stripComments(space).next().value) !== 'in')) ||
         color1.length < 1 || color2.length < 1) {
       return null;
     }
@@ -503,10 +484,11 @@ export class ColorMixMatcher extends matcherBase(ColorMixMatch) {
     }
 
     const args = ASTUtils.callArgs(node);
-    if (args.length !== 3) {
+    if (args.length !== computedValueArgs.length) {
       return null;
     }
-    return new ColorMixMatch(matching.ast.text(node), node, args[0], args[1], args[2]);
+    const [authoredSpace, authoredColor1, authoredColor2] = args.length === 3 ? args : [[], ...args];
+    return new ColorMixMatch(matching.ast.text(node), node, authoredSpace, authoredColor1, authoredColor2);
   }
 }
 

package/front_end/core/sdk/DebuggerModel.ts

@@ -16,9 +16,12 @@ import {type EvaluationOptions, type EvaluationResult, type ExecutionContext, Ru
 import {Script} from './Script.js';
 import {SDKModel} from './SDKModel.js';
 import {
+  breakpointsActiveSettingDescriptor,
+  disableAsyncStackTracesSettingDescriptor,
   jsSourceMapsEnabledSettingDescriptor,
   pauseOnCaughtExceptionSettingDescriptor,
   pauseOnExceptionEnabledSettingDescriptor,
+  pauseOnUncaughtExceptionSettingDescriptor,
 } from './SDKSettings.js';
 import {SourceMap} from './SourceMap.js';
 import {SourceMapManager} from './SourceMapManager.js';
@@ -137,6 +140,12 @@ export const WASM_SYMBOLS_PRIORITY = [
   Protocol.Debugger.DebugSymbolsType.SourceMap,
 ];
 
+export const skipAllPausesSettingDescriptor: Common.Settings.SettingDescriptor<boolean> = {
+  name: 'skip-all-pauses',
+  type: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: false,
+};
+
 export class DebuggerModel extends SDKModel<EventTypes> {
   readonly agent: ProtocolProxyApi.DebuggerApi;
   #runtimeModel: RuntimeModel;
@@ -149,6 +158,13 @@ export class DebuggerModel extends SDKModel<EventTypes> {
   #selectedCallFrame: CallFrame|null = null;
   #debuggerEnabled = false;
   #debuggerId: string|null = null;
+  readonly #pauseOnExceptionEnabledSetting: Common.Settings.Setting<boolean>;
+  readonly #pauseOnCaughtExceptionSetting: Common.Settings.Setting<boolean>;
+  readonly #pauseOnUncaughtExceptionSetting: Common.Settings.Setting<boolean>;
+  readonly #disableAsyncStackTracesSetting: Common.Settings.Setting<boolean>;
+  readonly #breakpointsActiveSetting: Common.Settings.Setting<boolean>;
+  readonly #jsSourceMapsEnabledSetting: Common.Settings.Setting<boolean>;
+  readonly #skipAllPausesSetting: Common.Settings.Setting<boolean>;
   #skipAllPausesTimeout?: ReturnType<typeof setTimeout>;
   #beforePausedCallback: ((arg0: DebuggerPausedDetails, stepOver: Location|null) => Promise<boolean>)|null = null;
   #computeAutoStepRangesCallback: ((arg0: StepMode, arg1: CallFrame) => Promise<Array<{
@@ -179,22 +195,27 @@ export class DebuggerModel extends SDKModel<EventTypes> {
                                  compiledURL, sourceMappingURL, payload, target.targetManager().getConsole(), script));
 
     const settings = this.target().targetManager().settings;
-    settings.resolve(pauseOnExceptionEnabledSettingDescriptor)
-        .addChangeListener(this.pauseOnExceptionStateChanged, this);
-    settings.resolve(pauseOnCaughtExceptionSettingDescriptor)
-        .addChangeListener(this.pauseOnExceptionStateChanged, this);
-    settings.moduleSetting('pause-on-uncaught-exception').addChangeListener(this.pauseOnExceptionStateChanged, this);
-    settings.moduleSetting('disable-async-stack-traces').addChangeListener(this.asyncStackTracesStateChanged, this);
-    settings.moduleSetting('breakpoints-active').addChangeListener(this.breakpointsActiveChanged, this);
+    this.#pauseOnExceptionEnabledSetting = settings.resolve(pauseOnExceptionEnabledSettingDescriptor);
+    this.#pauseOnExceptionEnabledSetting.addChangeListener(this.pauseOnExceptionStateChanged, this);
+    this.#pauseOnCaughtExceptionSetting = settings.resolve(pauseOnCaughtExceptionSettingDescriptor);
+    this.#pauseOnCaughtExceptionSetting.addChangeListener(this.pauseOnExceptionStateChanged, this);
+    this.#pauseOnUncaughtExceptionSetting = settings.resolve(pauseOnUncaughtExceptionSettingDescriptor);
+    this.#pauseOnUncaughtExceptionSetting.addChangeListener(this.pauseOnExceptionStateChanged, this);
+    this.#disableAsyncStackTracesSetting = settings.resolve(disableAsyncStackTracesSettingDescriptor);
+    this.#disableAsyncStackTracesSetting.addChangeListener(this.asyncStackTracesStateChanged, this);
+    this.#breakpointsActiveSetting = settings.resolve(breakpointsActiveSettingDescriptor);
+    this.#breakpointsActiveSetting.addChangeListener(this.breakpointsActiveChanged, this);
+    this.#skipAllPausesSetting = settings.resolve(skipAllPausesSettingDescriptor);
+    this.#skipAllPausesSetting.addChangeListener(this.skipAllPausesChanged, this);
+
+    this.#jsSourceMapsEnabledSetting = settings.resolve(jsSourceMapsEnabledSettingDescriptor);
+    this.#jsSourceMapsEnabledSetting.addChangeListener(this.jsSourceMapsStateChanged, this);
+    this.#sourceMapManager.setEnabled(this.#jsSourceMapsEnabledSetting.get());
 
     if (!target.suspended()) {
       void this.enableDebugger();
     }
 
-    this.#sourceMapManager.setEnabled(settings.resolve(jsSourceMapsEnabledSettingDescriptor).get());
-    settings.resolve(jsSourceMapsEnabledSettingDescriptor)
-        .addChangeListener(event => this.#sourceMapManager.setEnabled((event.data as boolean)));
-
     const resourceTreeModel = (target.model(ResourceTreeModel) as ResourceTreeModel);
     if (resourceTreeModel) {
       resourceTreeModel.addEventListener(ResourceTreeModelEvents.FrameNavigated, this.onFrameNavigated, this);
@@ -256,6 +277,11 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     }
     this.#debuggerEnabled = true;
 
+    let skipAllPausesPromise: Promise<Protocol.ProtocolResponseWithError>|undefined;
+    if (this.#skipAllPausesSetting.get()) {
+      skipAllPausesPromise = this.agent.invoke_setSkipAllPauses({skip: true});
+    }
+
     // Set a limit for the total size of collected script sources retained by debugger.
     // 10MB for remote frontends, 100MB for others.
     const isRemoteFrontend = Root.Runtime.Runtime.queryParam('remoteFrontend') || Root.Runtime.Runtime.queryParam('ws');
@@ -269,12 +295,11 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     }
     this.pauseOnExceptionStateChanged();
     void this.asyncStackTracesStateChanged();
-    const settings = this.target().targetManager().settings;
-    if (!settings.moduleSetting('breakpoints-active').get()) {
+    if (!this.#breakpointsActiveSetting.get()) {
       this.breakpointsActiveChanged();
     }
     this.dispatchEventToListeners(Events.DebuggerWasEnabled, this);
-    const [enableResult] = await Promise.all([enablePromise, instrumentationPromise]);
+    const [enableResult] = await Promise.all([enablePromise, instrumentationPromise, skipAllPausesPromise]);
     this.registerDebugger(enableResult);
   }
 
@@ -344,12 +369,24 @@ export class DebuggerModel extends SDKModel<EventTypes> {
   }
 
   private skipAllPauses(skip: boolean): void {
+    if (this.#skipAllPausesSetting.get()) {
+      return;
+    }
     clearTimeout(this.#skipAllPausesTimeout);
 
     void this.agent.invoke_setSkipAllPauses({skip});
   }
 
+  private skipAllPausesChanged(): void {
+    const skip = this.#skipAllPausesSetting.get();
+    clearTimeout(this.#skipAllPausesTimeout);
+    void this.agent.invoke_setSkipAllPauses({skip});
+  }
+
   skipAllPausesUntilReloadOrTimeout(timeout: number): void {
+    if (this.#skipAllPausesSetting.get()) {
+      return;
+    }
     clearTimeout(this.#skipAllPausesTimeout);
 
     void this.agent.invoke_setSkipAllPauses({skip: true});
@@ -360,12 +397,15 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     );
   }
 
+  private jsSourceMapsStateChanged(): void {
+    this.#sourceMapManager.setEnabled(this.#jsSourceMapsEnabledSetting.get());
+  }
+
   private pauseOnExceptionStateChanged(): void {
-    const settings = this.target().targetManager().settings;
-    const pauseOnCaughtEnabled = settings.resolve(pauseOnCaughtExceptionSettingDescriptor).get();
+    const pauseOnCaughtEnabled = this.#pauseOnCaughtExceptionSetting.get();
     let state: Protocol.Debugger.SetPauseOnExceptionsRequestState;
 
-    const pauseOnUncaughtEnabled = settings.moduleSetting('pause-on-uncaught-exception').get();
+    const pauseOnUncaughtEnabled = this.#pauseOnUncaughtExceptionSetting.get();
     if (pauseOnCaughtEnabled && pauseOnUncaughtEnabled) {
       state = Protocol.Debugger.SetPauseOnExceptionsRequestState.All;
     } else if (pauseOnCaughtEnabled) {
@@ -380,15 +420,13 @@ export class DebuggerModel extends SDKModel<EventTypes> {
 
   private asyncStackTracesStateChanged(): Promise<Protocol.ProtocolResponseWithError> {
     const maxAsyncStackChainDepth = 32;
-    const settings = this.target().targetManager().settings;
-    const enabled = !settings.moduleSetting('disable-async-stack-traces').get() && this.#debuggerEnabled;
+    const enabled = !this.#disableAsyncStackTracesSetting.get() && this.#debuggerEnabled;
     const maxDepth = enabled ? maxAsyncStackChainDepth : 0;
     return this.agent.invoke_setAsyncCallStackDepth({maxDepth});
   }
 
   private breakpointsActiveChanged(): void {
-    const settings = this.target().targetManager().settings;
-    void this.agent.invoke_setBreakpointsActive({active: settings.moduleSetting('breakpoints-active').get()});
+    void this.agent.invoke_setBreakpointsActive({active: this.#breakpointsActiveSetting.get()});
   }
 
   setComputeAutoStepRangesCallback(callback: ((arg0: StepMode, arg1: CallFrame) => Promise<LocationRange[]>)|null):
@@ -622,6 +660,11 @@ export class DebuggerModel extends SDKModel<EventTypes> {
       return;
     }
 
+    if (this.#skipAllPausesSetting.get()) {
+      this.resume();
+      return;
+    }
+
     const pausedDetails =
         new DebuggerPausedDetails(this, callFrames, reason, auxData, breakpointIds, asyncStackTrace, asyncStackTraceId);
 
@@ -639,8 +682,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
       } else {
         void this.stepInto();
       }
-    } else {
-      Common.EventTarget.fireEvent('DevTools.DebuggerPaused');
     }
   }
 
@@ -649,16 +690,16 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     this.dispatchEventToListeners(Events.DebuggerResumed, this);
   }
 
-  parsedScriptSource(
-      scriptId: Protocol.Runtime.ScriptId, sourceURL: Platform.DevToolsPath.UrlString, startLine: number,
-      startColumn: number, endLine: number, endColumn: number,
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      executionContextId: number, hash: string, executionContextAuxData: any, isLiveEdit: boolean,
-      sourceMapURL: string|undefined, hasSourceURLComment: boolean, hasSyntaxError: boolean, length: number,
-      isModule: boolean|null, originStackTrace: Protocol.Runtime.StackTrace|null, codeOffset: number|null,
-      scriptLanguage: string|null, debugSymbols: Protocol.Debugger.DebugSymbols[]|null,
-      embedderName: Platform.DevToolsPath.UrlString|null, buildId: string|null): Script {
+  parsedScriptSource(scriptId: Protocol.Runtime.ScriptId, sourceURL: Platform.DevToolsPath.UrlString, startLine: number,
+                     startColumn: number, endLine: number, endColumn: number,
+                     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
+                     // eslint-disable-next-line @typescript-eslint/no-explicit-any
+                     executionContextId: number, hash: string, executionContextAuxData: any,
+                     sourceMapURL: string|undefined, hasSourceURLComment: boolean, hasSyntaxError: boolean,
+                     length: number, isModule: boolean|null, originStackTrace: Protocol.Runtime.StackTrace|null,
+                     codeOffset: number|null, scriptLanguage: string|null,
+                     debugSymbols: Protocol.Debugger.DebugSymbols[]|null,
+                     embedderName: Platform.DevToolsPath.UrlString|null, buildId: string|null): Script {
     const knownScript = this.#scripts.get(scriptId);
     if (knownScript) {
       return knownScript;
@@ -670,10 +711,9 @@ export class DebuggerModel extends SDKModel<EventTypes> {
 
     const selectedDebugSymbol =
         DebuggerModel.selectSymbolSource(debugSymbols, this.target().targetManager().getConsole());
-    const script = new Script(
-        this, scriptId, sourceURL, startLine, startColumn, endLine, endColumn, executionContextId, hash,
-        isContentScript, isLiveEdit, sourceMapURL, hasSourceURLComment, length, isModule, originStackTrace, codeOffset,
-        scriptLanguage, selectedDebugSymbol, embedderName, buildId);
+    const script = new Script(this, scriptId, sourceURL, startLine, startColumn, endLine, endColumn, executionContextId,
+                              hash, isContentScript, sourceMapURL, hasSourceURLComment, length, isModule,
+                              originStackTrace, codeOffset, scriptLanguage, selectedDebugSymbol, embedderName, buildId);
     this.registerScript(script);
     this.dispatchEventToListeners(Events.ParsedScriptSource, script);
 
@@ -873,12 +913,13 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     if (this.#debuggerId) {
       debuggerIdToModel.delete(this.#debuggerId);
     }
-    const settings = this.target().targetManager().settings;
-    settings.resolve(pauseOnExceptionEnabledSettingDescriptor)
-        .removeChangeListener(this.pauseOnExceptionStateChanged, this);
-    settings.resolve(pauseOnCaughtExceptionSettingDescriptor)
-        .removeChangeListener(this.pauseOnExceptionStateChanged, this);
-    settings.moduleSetting('disable-async-stack-traces').removeChangeListener(this.asyncStackTracesStateChanged, this);
+    this.#pauseOnExceptionEnabledSetting.removeChangeListener(this.pauseOnExceptionStateChanged, this);
+    this.#pauseOnCaughtExceptionSetting.removeChangeListener(this.pauseOnExceptionStateChanged, this);
+    this.#skipAllPausesSetting.removeChangeListener(this.skipAllPausesChanged, this);
+    this.#pauseOnUncaughtExceptionSetting.removeChangeListener(this.pauseOnExceptionStateChanged, this);
+    this.#disableAsyncStackTracesSetting.removeChangeListener(this.asyncStackTracesStateChanged, this);
+    this.#breakpointsActiveSetting.removeChangeListener(this.breakpointsActiveChanged, this);
+    this.#jsSourceMapsEnabledSetting.removeChangeListener(this.jsSourceMapsStateChanged, this);
   }
 
   override async suspendModel(): Promise<void> {
@@ -972,7 +1013,6 @@ export enum Events {
   GlobalObjectCleared = 'GlobalObjectCleared',
   CallFrameSelected = 'CallFrameSelected',
   DebuggerIsReadyToPause = 'DebuggerIsReadyToPause',
-  ScriptSourceWasEdited = 'ScriptSourceWasEdited',
   /* eslint-enable @typescript-eslint/naming-convention */
 }
 
@@ -987,10 +1027,6 @@ export interface EventTypes {
   [Events.CallFrameSelected]: DebuggerModel;
   [Events.DebuggerIsReadyToPause]: DebuggerModel;
   [Events.DebugInfoAttached]: Script;
-  [Events.ScriptSourceWasEdited]: {
-    script: Script,
-    status: Protocol.Debugger.SetScriptSourceResponseStatus,
-  };
 }
 
 class DebuggerDispatcher implements ProtocolProxyApi.DebuggerDispatcher {
@@ -1026,7 +1062,6 @@ class DebuggerDispatcher implements ProtocolProxyApi.DebuggerDispatcher {
     executionContextId,
     hash,
     executionContextAuxData,
-    isLiveEdit,
     sourceMapURL,
     hasSourceURL,
     length,
@@ -1043,9 +1078,9 @@ class DebuggerDispatcher implements ProtocolProxyApi.DebuggerDispatcher {
     }
     this.#debuggerModel.parsedScriptSource(
         scriptId, url as Platform.DevToolsPath.UrlString, startLine, startColumn, endLine, endColumn,
-        executionContextId, hash, executionContextAuxData, Boolean(isLiveEdit), sourceMapURL, Boolean(hasSourceURL),
-        false, length || 0, isModule || null, stackTrace || null, codeOffset || null, scriptLanguage || null,
-        debugSymbols || null, embedderName as Platform.DevToolsPath.UrlString || null, buildId || null);
+        executionContextId, hash, executionContextAuxData, sourceMapURL, Boolean(hasSourceURL), false, length || 0,
+        isModule || null, stackTrace || null, codeOffset || null, scriptLanguage || null, debugSymbols || null,
+        embedderName as Platform.DevToolsPath.UrlString || null, buildId || null);
   }
 
   scriptFailedToParse({
@@ -1071,11 +1106,11 @@ class DebuggerDispatcher implements ProtocolProxyApi.DebuggerDispatcher {
     if (!this.#debuggerModel.debuggerEnabled()) {
       return;
     }
-    this.#debuggerModel.parsedScriptSource(
-        scriptId, url as Platform.DevToolsPath.UrlString, startLine, startColumn, endLine, endColumn,
-        executionContextId, hash, executionContextAuxData, false, sourceMapURL, Boolean(hasSourceURL), true,
-        length || 0, isModule || null, stackTrace || null, codeOffset || null, scriptLanguage || null, null,
-        embedderName as Platform.DevToolsPath.UrlString || null, buildId || null);
+    this.#debuggerModel.parsedScriptSource(scriptId, url as Platform.DevToolsPath.UrlString, startLine, startColumn,
+                                           endLine, endColumn, executionContextId, hash, executionContextAuxData,
+                                           sourceMapURL, Boolean(hasSourceURL), true, length || 0, isModule || null,
+                                           stackTrace || null, codeOffset || null, scriptLanguage || null, null,
+                                           embedderName as Platform.DevToolsPath.UrlString || null, buildId || null);
   }
 
   breakpointResolved({breakpointId, location}: Protocol.Debugger.BreakpointResolvedEvent): void {

package/front_end/core/sdk/EmulationModel.ts

@@ -9,6 +9,7 @@ import {CSSModel} from './CSSModel.js';
 import type {MultitargetNetworkManager} from './NetworkManager.js';
 import {Events, OverlayModel} from './OverlayModel.js';
 import {SDKModel} from './SDKModel.js';
+import {javaScriptDisabledSettingDescriptor} from './SDKSettings.js';
 import {Capability, type Target} from './Target.js';
 
 export const enum DataSaverOverride {
@@ -52,7 +53,7 @@ export class EmulationModel extends SDKModel<EmulationModelEventTypes> implement
     }
 
     const settings = this.target().targetManager().settings;
-    const disableJavascriptSetting = settings.moduleSetting('java-script-disabled');
+    const disableJavascriptSetting = settings.resolve(javaScriptDisabledSettingDescriptor);
     disableJavascriptSetting.addChangeListener(
         async () =>
             await this.#emulationAgent.invoke_setScriptExecutionDisabled({value: disableJavascriptSetting.get()}));