chrome-devtools-frontend 1.0.1674545 → 1.0.1675430

package/front_end/panels/elements/ElementsTreeOutline.ts

@@ -1188,7 +1188,7 @@ export class ElementsTreeOutline extends
     if (!treeElement) {
       return false;
     }
-    return treeElement.isEditing() || false;
+    return treeElement.isEditing || false;
   }
 
   update(): void {

package/front_end/panels/js_timeline/js_timeline-meta.ts

@@ -9,35 +9,35 @@ import type * as Timeline from '../timeline/timeline.js';
 
 const UIStrings = {
   /**
-   * @description Text for the performance of something
+   * @description Title of the Performance panel.
    */
   performance: 'Performance',
   /**
-   * @description Command for showing the 'Performance' tool
+   * @description Command for showing the Performance panel.
    */
   showPerformance: 'Show Performance',
   /**
-   * @description Title of an action in the timeline tool to show history
+   * @description Title of an action in the Performance panel to show history.
    */
   showRecentTimelineSessions: 'Show recent timeline sessions',
   /**
-   * @description Text to record a series of actions for analysis
+   * @description Text to record a series of actions for analysis.
    */
   record: 'Record',
   /**
-   * @description Text of an item that stops the running task
+   * @description Text of an item that stops the running task.
    */
   stop: 'Stop',
   /**
-   * @description Title of an action in the timeline tool to record a reload of the current page
+   * @description Title of an action in the Performance panel to record a reload of the current page.
    */
   recordAndReload: 'Record and reload',
   /**
-   * @description Title of a setting under the Performance category in Settings
+   * @description Title of a setting under the Performance category in Settings.
    */
   timelineShowAllEvents: 'Show all events',
   /**
-   * @description Title of a setting under the Performance category in Settings
+   * @description Title of a setting under the Performance category in Settings.
    */
   timelineDebugMode: 'Timeline debug mode (trace event details, etc.)',
 } as const;

package/front_end/panels/layer_viewer/LayerDetailsView.ts

@@ -24,15 +24,15 @@ const {widget} = UI.Widget;
 
 const UIStrings = {
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
   selectALayerToSeeItsDetails: 'Select a layer to see its details',
   /**
-   * @description Text in Layer Details View of the Layers panel if no layer is selected for viewing its content
+   * @description Text in layer details view of the Layers panel if no layer is selected for viewing its content.
    */
   noLayerSelected: 'No layer selected',
   /**
-   * @description Element text content in Layer Details View of the Layers panel
+   * @description Element text content in layer details view of the Layers panel.
    * @example {Touch event handler} PH1
    * @example {10} PH2
    * @example {10} PH3
@@ -41,46 +41,46 @@ const UIStrings = {
    */
   scrollRectangleDimensions: '{PH1} {PH2} × {PH3} (at {PH4}, {PH5})',
   /**
-   * @description Text in Layer Details View of the Layers panel. Used to indicate that a particular
+   * @description Text in layer details view of the Layers panel. Used to indicate that a particular
    * layer of the website is unnamed (was not given a name/doesn't have one).
    */
   unnamed: '<unnamed>',
   /**
-   * @description Text in Layer Details View of the Layers panel
-   * @example {Nearest Layer Shifting Sticky Box} PH1
+   * @description Text in layer details view of the Layers panel.
+   * @example {Nearest layer shifting sticky box} PH1
    * @example {&lt;unnamed&gt;} PH2
    * @example {5} PH3
    */
   stickyAncestorLayersS: '{PH1}: {PH2} ({PH3})',
   /**
-   * @description Sticky box rect element text content in Layer Details View of the Layers panel
+   * @description Sticky box rect element text content in layer details view of the Layers panel.
    * @example {10} PH1
    * @example {10} PH2
    * @example {10} PH3
    * @example {10} PH4
    */
-  stickyBoxRectangleDimensions: 'Sticky Box {PH1} × {PH2} (at {PH3}, {PH4})',
+  stickyBoxRectangleDimensions: 'Sticky box {PH1} × {PH2} (at {PH3}, {PH4})',
   /**
-   * @description Containing block rect element text content in Layer Details View of the Layers panel.
-   * The placeholder are width, height, x position, and y position respectively.
+   * @description Containing block rect element text content in layer details view of the Layers panel.
+   * The placeholders are width, height, x position, and y position respectively.
    * @example {10} PH1
    * @example {10} PH2
    * @example {10} PH3
    * @example {10} PH4
    */
-  containingBlocRectangleDimensions: 'Containing Block {PH1} × {PH2} (at {PH3}, {PH4})',
+  containingBlocRectangleDimensions: 'Containing block {PH1} × {PH2} (at {PH3}, {PH4})',
   /**
-   * @description Text in Layer Details View of the Layers panel. This also means "The nearest sticky
+   * @description Text in layer details view of the Layers panel. This also means "The nearest sticky
    * box that causes a layer shift".
    */
-  nearestLayerShiftingStickyBox: 'Nearest Layer Shifting Sticky Box',
+  nearestLayerShiftingStickyBox: 'Nearest layer shifting sticky box',
   /**
-   * @description Text in Layer Details View of the Layers panel. This also means "The nearest block
+   * @description Text in layer details view of the Layers panel. This also means "The nearest block
    * that causes a layer shift".
    */
-  nearestLayerShiftingContaining: 'Nearest Layer Shifting Containing Block',
+  nearestLayerShiftingContaining: 'Nearest layer shifting containing block',
   /**
-   * @description Size cell text content in Layer Details View of the Layers panel
+   * @description Size cell text content in layer details view of the Layers panel.
    * @example {10} PH1
    * @example {10} PH2
    * @example {10} PH3
@@ -88,53 +88,53 @@ const UIStrings = {
    */
   updateRectangleDimensions: '{PH1} × {PH2} (at {PH3}, {PH4})',
   /**
-   * @description Text for the size of something
+   * @description Text for the size of something.
    */
   size: 'Size',
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
-  compositingReasons: 'Compositing Reasons',
+  compositingReasons: 'Compositing reasons',
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
   memoryEstimate: 'Memory estimate',
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
   paintCount: 'Paint count',
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
   slowScrollRegions: 'Slow scroll regions',
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
   stickyPositionConstraint: 'Sticky position constraint',
   /**
-   * @description Title of the paint profiler, old name of the performance pane
+   * @description Label for button to open the paint profiler in the layer details view of the Layers panel.
    */
-  paintProfiler: 'Paint Profiler',
+  paintProfiler: 'Paint profiler',
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
   nonFastScrollable: 'Non fast scrollable',
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
   touchEventHandler: 'Touch event handler',
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
   wheelEventHandler: 'Wheel event handler',
   /**
-   * @description Text in Layer Details View of the Layers panel. Means that this rectangle needs to
+   * @description Text in layer details view of the Layers panel. Means that this rectangle needs to
    * be repainted when the webpage is scrolled. 'repaints' means that the browser engine needs to
    * draw the pixels for this rectangle to the user's monitor again.
    */
   repaintsOnScroll: 'Repaints on scroll',
   /**
-   * @description Text in Layer Details View of the Layers panel
+   * @description Text in layer details view of the Layers panel.
    */
   mainThreadScrollingReason: 'Main thread scrolling reason',
 } as const;

package/front_end/panels/layer_viewer/LayerTreeOutline.ts

@@ -20,20 +20,20 @@ import {
 
 const UIStrings = {
   /**
-   * @description A count of the number of rendering layers in Layer Tree Outline of the Layers panel
+   * @description A count of the number of rendering layers in layer tree outline of the Layers panel.
    * @example {10} PH1
    */
   layerCount: '{PH1} layers',
   /**
-   * @description Label for layers sidepanel tree
+   * @description Label for layers sidebar tree.
    */
-  layersTreePane: 'Layers Tree Pane',
+  layersTreePane: 'Layers tree',
   /**
-   * @description A context menu item in the DView of the Layers panel
+   * @description Context menu item in the 3D view of the Layers panel.
    */
-  showPaintProfiler: 'Show Paint Profiler',
+  showPaintProfiler: 'Show paint profiler',
   /**
-   * @description Details text content in Layer Tree Outline of the Layers panel
+   * @description Details text content in layer tree outline of the Layers panel.
    * @example {10} PH1
    * @example {10} PH2
    */

package/front_end/panels/layer_viewer/LayerViewHost.ts

@@ -9,7 +9,7 @@ import type * as UI from '../../ui/legacy/legacy.js';
 
 const UIStrings = {
   /**
-   * @description Text in Layer View Host of the Layers panel
+   * @description Text in layer view host of the Layers panel.
    */
   showInternalLayers: 'Show internal layers',
 } as const;

package/front_end/panels/layer_viewer/Layers3DView.ts

@@ -31,38 +31,38 @@ const {widget} = UI.Widget;
 
 const UIStrings = {
   /**
-   * @description Text of a DOM element in DView of the Layers panel
+   * @description Text of a DOM element in 3D view of the Layers panel.
    */
   noLayerInformation: 'No layers detected yet',
   /**
-   * @description Text of a DOM element in DView of the Layers panel that explains the panel
+   * @description Text of a DOM element in 3D view of the Layers panel that explains the panel.
    */
   layerExplanation: 'On this page you will be able to view and inspect document layers.',
   /**
-   * @description Accessibility label for canvas view in Layers tool
+   * @description Accessibility label for canvas view in Layers panel.
    */
-  dLayersView: '3D Layers View',
+  dLayersView: '3D layers view',
   /**
-   * @description Text in DView of the Layers panel
+   * @description Text in 3D view of the Layers panel.
    */
   cantDisplayLayers: 'Can’t display layers',
   /**
-   * @description Text in DView of the Layers panel
+   * @description Text in 3D view of the Layers panel.
    */
   webglSupportIsDisabledInYour: 'WebGL support is disabled in your browser.',
   /**
-   * @description Text in DView of the Layers panel
+   * @description Text in 3D view of the Layers panel.
    * @example {about:gpu} PH1
    */
   checkSForPossibleReasons: 'Check {PH1} for possible reasons.',
   /**
-   * @description A context menu item in the DView of the Layers panel
+   * @description Context menu item in the 3D view of the Layers panel.
    */
-  resetView: 'Reset View',
+  resetView: 'Reset view',
   /**
-   * @description A context menu item in the DView of the Layers panel
+   * @description Context menu item in the 3D view of the Layers panel.
    */
-  showPaintProfiler: 'Show Paint Profiler',
+  showPaintProfiler: 'Show paint profiler',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/layer_viewer/Layers3DView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

package/front_end/panels/layer_viewer/PaintProfilerView.ts

@@ -18,33 +18,33 @@ const {ref} = Lit.Directives;
 
 const UIStrings = {
   /**
-   * @description Text to indicate the progress of a profile
+   * @description Text to indicate the progress of a profile.
    */
   profiling: 'Profiling…',
   /**
-   * @description Text in Paint Profiler View of the Layers panel
+   * @description Text in paint profiler view of the Layers panel.
    */
   shapes: 'Shapes',
   /**
-   * @description Text in Paint Profiler View of the Layers panel
+   * @description Text in paint profiler view of the Layers panel.
    */
   bitmap: 'Bitmap',
   /**
-   * @description Generic label for any text
+   * @description Generic label for any text.
    */
   text: 'Text',
   /**
-   * @description Text in Paint Profiler View of the Layers panel
+   * @description Text in paint profiler view of the Layers panel.
    */
   misc: 'Misc',
   /**
-   * @description ARIA label for a pie chart that shows the results of the paint profiler
+   * @description ARIA label for a pie chart that shows the results of the paint profiler.
    */
   profilingResults: 'Profiling results',
   /**
-   * @description Label for command log tree in the Profiler tab
+   * @description Label for command log tree in the paint profiler.
    */
-  commandLog: 'Command Log',
+  commandLog: 'Command log',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/layer_viewer/PaintProfilerView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

package/front_end/panels/layer_viewer/TransformController.ts

@@ -13,15 +13,15 @@ import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
 const UIStrings = {
   /**
-   * @description Tooltip text that appears when hovering over largeicon pan button in Transform Controller of the Layers panel
+   * @description Tooltip text that appears when hovering over largeicon pan button in transform controller of the Layers panel.
    */
   panModeX: 'Pan mode (X)',
   /**
-   * @description Tooltip text that appears when hovering over largeicon rotate button in Transform Controller of the Layers panel
+   * @description Tooltip text that appears when hovering over largeicon rotate button in transform controller of the Layers panel.
    */
   rotateModeV: 'Rotate mode (V)',
   /**
-   * @description Tooltip text that appears when hovering over the largeicon center button in the Transform Controller of the Layers panel
+   * @description Tooltip text that appears when hovering over the largeicon center button in the transform controller of the Layers panel.
    */
   resetTransform: 'Reset transform (0)',
 } as const;

package/front_end/panels/layer_viewer/layer_viewer-meta.ts

@@ -8,47 +8,47 @@ import * as UI from '../../ui/legacy/legacy.js';
 
 const UIStrings = {
   /**
-   * @description Title of a setting in Layer Viewer.
+   * @description Title of a setting in layer viewer.
    */
   paints: 'Paints',
   /**
-   * @description Title of a setting in Layer Viewer.
+   * @description Title of a setting in layer viewer.
    */
   slowScrollRects: 'Slow scroll rects',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (reset view in Layers Panel)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (reset view in Layers panel).
    */
   resetView: 'Reset view',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (switch to pan in Layers Panel)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (switch to pan in Layers panel).
    */
   switchToPanMode: 'Switch to pan mode',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (switch to rotate mode in Layers Panel)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (switch to rotate mode in Layers panel).
    */
   switchToRotateMode: 'Switch to rotate mode',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (zoom in)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (zoom in).
    */
   zoomIn: 'Zoom in',
   /**
-   * @description Text in the Shortcuts page to explain a keyboard shortcut (zoom out)
+   * @description Text in the Shortcuts page to explain a keyboard shortcut (zoom out).
    */
   zoomOut: 'Zoom out',
   /**
-   * @description Description of a shortcut that pans or rotates the layer viewer up
+   * @description Description of a shortcut that pans or rotates the layer viewer up.
    */
   panOrRotateUp: 'Pan or rotate up',
   /**
-   * @description Description of a shortcut that pans or rotates the layer viewer down
+   * @description Description of a shortcut that pans or rotates the layer viewer down.
    */
   panOrRotateDown: 'Pan or rotate down',
   /**
-   * @description Description of a shortcut that pans or rotates the layer viewer left
+   * @description Description of a shortcut that pans or rotates the layer viewer left.
    */
   panOrRotateLeft: 'Pan or rotate left',
   /**
-   * @description Description of a shortcut that pans or rotates the layer viewer right
+   * @description Description of a shortcut that pans or rotates the layer viewer right.
    */
   panOrRotateRight: 'Pan or rotate right',
 } as const;

package/front_end/panels/mobile_throttling/ThrottlingManager.ts

@@ -13,13 +13,7 @@ import {html, render} from '../../ui/lit/lit.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 import * as PanelsCommon from '../common/common.js';
 
-import {MobileThrottlingSelector} from './MobileThrottlingSelector.js';
-import {
-  type Conditions,
-  type ConditionsList,
-  type MobileThrottlingConditionsGroup,
-  ThrottlingPresets,
-} from './ThrottlingPresets.js';
+import {ThrottlingPresets} from './ThrottlingPresets.js';
 
 export interface CPUThrottlingSelectorWrapper {
   control: UI.Toolbar.ToolbarComboBox;
@@ -35,10 +29,6 @@ const UIStrings = {
    * @description Text in throttling manager of the Network panel.
    */
   forceDisconnectedFromNetwork: 'Force disconnected from network',
-  /**
-   * @description Text for throttling the network.
-   */
-  throttling: 'Throttling',
   /**
    * @description Icon title in throttling manager of the Network panel.
    */
@@ -206,53 +196,6 @@ export class ThrottlingManager extends Common.ObjectWrapper.ObjectWrapper<Thrott
     return checkbox;
   }
 
-  createMobileThrottlingButton(): UI.Toolbar.ToolbarMenuButton {
-    const button = new UI.Toolbar.ToolbarMenuButton(appendItems, undefined, undefined, 'mobile-throttling');
-    button.setTitle(i18nString(UIStrings.throttling));
-    button.setDarkText();
-
-    let options: ConditionsList = [];
-    let selectedIndex = -1;
-    const selector = new MobileThrottlingSelector(populate, select);
-    return button;
-
-    function appendItems(contextMenu: UI.ContextMenu.ContextMenu): void {
-      for (let index = 0; index < options.length; ++index) {
-        const conditions = options[index];
-        if (!conditions) {
-          continue;
-        }
-        if (conditions.title === ThrottlingPresets.getCustomConditions().title &&
-            conditions.description === ThrottlingPresets.getCustomConditions().description) {
-          continue;
-        }
-        contextMenu.defaultSection().appendCheckboxItem(
-            conditions.title, selector.optionSelected.bind(selector, conditions as Conditions),
-            {checked: selectedIndex === index, jslogContext: conditions.jslogContext});
-      }
-    }
-
-    function populate(groups: MobileThrottlingConditionsGroup[]): ConditionsList {
-      options = [];
-      for (const group of groups) {
-        for (const conditions of group.items) {
-          options.push(conditions);
-        }
-        options.push(null);
-      }
-      return options;
-    }
-
-    function select(index: number): void {
-      selectedIndex = index;
-      const option = options[index];
-      if (option) {
-        button.setText(option.title);
-        button.setTitle(`${option.title}: ${option.description}`);
-      }
-    }
-  }
-
   private updatePanelIcon(): void {
     const warnings = [];
     if (this.cpuThrottlingManager.cpuThrottlingRate() !==

package/front_end/panels/mobile_throttling/mobile_throttling.ts

@@ -2,16 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import './ThrottlingPresets.js';
-import './MobileThrottlingSelector.js';
-import './NetworkPanelIndicator.js';
-import './NetworkThrottlingSelector.js';
-import './CPUThrottlingSelector.js';
-import './ThrottlingSettingsTab.js';
-import './ThrottlingManager.js';
-
 import * as CPUThrottlingSelector from './CPUThrottlingSelector.js';
-import * as MobileThrottlingSelector from './MobileThrottlingSelector.js';
 import * as NetworkPanelIndicator from './NetworkPanelIndicator.js';
 import * as NetworkThrottlingSelector from './NetworkThrottlingSelector.js';
 import * as ThrottlingManager from './ThrottlingManager.js';
@@ -20,7 +11,6 @@ import * as ThrottlingSettingsTab from './ThrottlingSettingsTab.js';
 
 export {
   CPUThrottlingSelector,
-  MobileThrottlingSelector,
   NetworkPanelIndicator,
   NetworkThrottlingSelector,
   ThrottlingManager,

package/front_end/panels/protocol_monitor/ProtocolMonitor.ts

@@ -5,6 +5,7 @@
 import '../../ui/legacy/legacy.js';
 import '../../ui/legacy/components/data_grid/data_grid.js';
 
+import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as ProtocolClient from '../../core/protocol_client/protocol_client.js';
@@ -24,6 +25,7 @@ import protocolMonitorStyles from './protocolMonitor.css.js';
 
 const {styleMap} = Directives;
 const {widget, widgetRef} = UI.Widget;
+
 const UIStrings = {
   /**
    * @description Table column header in the Protocol monitor data grid that displays the CDP method name (for example, Page.navigate or Network.enable).
@@ -180,6 +182,7 @@ export interface ViewInput {
   onTargetChange: (targetId: string) => void;
   onToggleSidebar: () => void;
   onEditorSubmit: (command: string, parameters: Record<string, unknown>, targetId?: string) => void;
+  columnsVisibilitySetting: Common.Settings.Setting<Record<string, {visible: boolean}>>;
   targets: SDK.Target.Target[];
   selectedTargetId: string;
 }
@@ -239,6 +242,7 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
               <devtools-data-grid
                   striped
                   slot="main"
+                  .columnsVisibilitySetting=${input.columnsVisibilitySetting}
                   .filters=${input.parseFilter(input.filter)}>
                 <table>
                     <tr>
@@ -372,6 +376,8 @@ export class ProtocolMonitorImpl extends UI.Panel.Panel implements SDK.TargetMan
   #filter = '';
   #editorWidget!: JSONEditor;
   #targetsBySessionId = new Map<string, SDK.Target.Target>();
+  #columnsVisibilitySetting = Common.Settings.Settings.instance().createSetting<Record<string, {visible: boolean}>>(
+      'protocol-monitor-columns', {});
   constructor(view: View = DEFAULT_VIEW) {
     super('protocol-monitor', true);
     this.#view = view;
@@ -469,6 +475,7 @@ export class ProtocolMonitorImpl extends UI.Panel.Panel implements SDK.TargetMan
       onEditorSubmit: (command: string, parameters: Record<string, unknown>, targetId?: string) => {
         this.onCommandSend(command, parameters, targetId);
       },
+      columnsVisibilitySetting: this.#columnsVisibilitySetting,
       targets: SDK.TargetManager.TargetManager.instance().targets(),
       selectedTargetId: this.#selectedTargetId,
     };

package/front_end/panels/settings/emulation/DevicesSettingsTab.ts

@@ -438,7 +438,6 @@ export class DevicesSettingsTab extends UI.Widget.VBox implements
       title: '',
       orientation: EmulationModel.EmulatedDevices.Vertical,
       insets: new EmulationModel.DeviceModeModel.Insets(0, 0, 0, 0),
-      image: null,
     };
     const safeAreaInsets = this.safeAreaInsetsFromEditor(editor);
     if (safeAreaInsets) {
@@ -453,7 +452,7 @@ export class DevicesSettingsTab extends UI.Widget.VBox implements
       title: '',
       orientation: EmulationModel.EmulatedDevices.Horizontal,
       insets: new EmulationModel.DeviceModeModel.Insets(0, 0, 0, 0),
-      image: null,
+
     };
     const landscapeSafeAreaInsets = this.safeAreaInsetsFromEditor(editor, 'landscape-');
     if (landscapeSafeAreaInsets) {

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: Internal
 Version: N/A
-Revision: 1b1cf0f7236a27d60a4a348433bdd531893796c7
+Revision: cd73d963934f9330aa868dcc05bbce063513294b
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE