chrome-devtools-frontend 1.0.1667564 → 1.0.1669021

package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts

@@ -57,7 +57,7 @@ export interface ViewInput {
   renderInline?: boolean;
   portBindingEnabled?: boolean;
   schemeBindingEnabled?: boolean;
-  onEdit: (data: CookieData, columnId: string, valueBeforeEditing: string, newText: string) => void;
+  onEdit: (data: CookieData, columnId: string, valueBeforeEditing: string|boolean, newText: string|boolean) => void;
   onCreate: (data: CookieData) => void;
   onRefresh: () => void;
   onDelete: (data: CookieData) => void;
@@ -71,18 +71,21 @@ type ViewFunction = (input: ViewInput, output: object, target: HTMLElement) => v
 type AttributeWithIcon = SDK.Cookie.Attribute.NAME|SDK.Cookie.Attribute.VALUE|SDK.Cookie.Attribute.DOMAIN|
                          SDK.Cookie.Attribute.PATH|SDK.Cookie.Attribute.SECURE|SDK.Cookie.Attribute.SAME_SITE;
 
-type CookieData = Partial<Record<SDK.Cookie.Attribute, string>>&{
-  name: string,
-  value: string,
-}&{
-  key?: string,
-  flagged?: boolean,
-  icons?: Partial<Record<AttributeWithIcon, Icon>>,
-  priorityValue?: number,
-  expiresTooltip?: string,
-  dirty?: boolean,
-  inactive?: boolean,
-};
+type BooleanAttributes =
+    SDK.Cookie.Attribute.HTTP_ONLY|SDK.Cookie.Attribute.SECURE|SDK.Cookie.Attribute.HAS_CROSS_SITE_ANCESTOR;
+type CookieData = Partial<Record<Exclude<SDK.Cookie.Attribute, BooleanAttributes>, string>>&
+    Partial<Record<BooleanAttributes, string|boolean>>&{
+      name: string,
+      value: string,
+    }&{
+      key?: string,
+      flagged?: boolean,
+      icons?: Partial<Record<AttributeWithIcon, Icon>>,
+      priorityValue?: number,
+      expiresTooltip?: string,
+      dirty?: boolean,
+      inactive?: boolean,
+    };
 
 const {repeat, ifDefined} = Directives;
 
@@ -185,6 +188,10 @@ const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined
 
 const expiresSessionValue = i18nLazyString(UIStrings.session);
 
+function isFlagAttribute(attribute: SDK.Cookie.Attribute): attribute is BooleanAttributes {
+  return attribute === SDK.Cookie.Attribute.HTTP_ONLY || attribute === SDK.Cookie.Attribute.SECURE;
+}
+
 export interface CookiesTableData {
   cookies: SDK.Cookie.Cookie[];
   cookieToBlockedReasons?: ReadonlyMap<SDK.Cookie.Cookie, SDK.CookieModel.BlockedReason[]>;
@@ -280,13 +287,13 @@ export class CookiesTable extends UI.Widget.VBox {
                 </th>` : ''}
               </tr>
               ${repeat(this.data, cookie => cookie.key, cookie => {
-                const isHttpOnly = cookie['http-only'] === 'true';
+                const isHttpOnly = Boolean(cookie['http-only']);
                 return html`
                 <tr ?selected=${cookie.key === input.selectedKey}
                     ?inactive=${cookie.inactive}
                     ?dirty=${cookie.dirty}
                     ?highlighted=${cookie.flagged}
-                    @edit=${(e: CustomEvent<{columnId: string, valueBeforeEditing: string, newText: string}>) =>
+                    @edit=${(e: CustomEvent<{columnId: string, valueBeforeEditing: string|boolean, newText: string|boolean}>) =>
                        input.onEdit(cookie, e.detail.columnId, e.detail.valueBeforeEditing, e.detail.newText)}
                     @delete=${()=> input.onDelete(cookie)}
                     @contextmenu=${(e: CustomEvent<UI.ContextMenu.ContextMenu>) => input.onContextMenu(cookie, e.detail)}
@@ -479,7 +486,8 @@ export class CookiesTable extends UI.Widget.VBox {
     }
   }
 
-  private onUpdateCookie(oldData: CookieData, columnIdentifier: string, _oldText: string, newText: string): void {
+  private onUpdateCookie(oldData: CookieData, columnIdentifier: string, _oldText: string|boolean,
+                         newText: string|boolean): void {
     const oldCookie = this.cookies.find(cookie => cookie.key() === oldData.key);
     if (!oldCookie) {
       return;
@@ -547,7 +555,14 @@ export class CookiesTable extends UI.Widget.VBox {
              of [SDK.Cookie.Attribute.DOMAIN, SDK.Cookie.Attribute.PATH, SDK.Cookie.Attribute.HTTP_ONLY,
                  SDK.Cookie.Attribute.SECURE, SDK.Cookie.Attribute.SAME_SITE, SDK.Cookie.Attribute.SOURCE_SCHEME]) {
       if (attribute in data) {
-        cookie.addAttribute(attribute, data[attribute]);
+        const value = data[attribute];
+        if (isFlagAttribute(attribute)) {
+          if (value === true) {
+            cookie.addAttribute(attribute);
+          }
+        } else {
+          cookie.addAttribute(attribute, value);
+        }
       }
     }
     if (data.expires && data.expires !== expiresSessionValue()) {
@@ -559,11 +574,8 @@ export class CookiesTable extends UI.Widget.VBox {
           Number.parseInt(data[SDK.Cookie.Attribute.SOURCE_PORT] || '', 10) || undefined);
     }
     if (data[SDK.Cookie.Attribute.PARTITION_KEY_SITE]) {
-      cookie.setPartitionKey(
-          data[SDK.Cookie.Attribute.PARTITION_KEY_SITE],
-          Boolean(
-              data[SDK.Cookie.Attribute.HAS_CROSS_SITE_ANCESTOR] ? data[SDK.Cookie.Attribute.HAS_CROSS_SITE_ANCESTOR] :
-                                                                   false));
+      cookie.setPartitionKey(data[SDK.Cookie.Attribute.PARTITION_KEY_SITE],
+                             data[SDK.Cookie.Attribute.HAS_CROSS_SITE_ANCESTOR] === true);
     }
     cookie.setSize(data[SDK.Cookie.Attribute.NAME].length + data[SDK.Cookie.Attribute.VALUE].length);
     return cookie;
@@ -578,7 +590,11 @@ export class CookiesTable extends UI.Widget.VBox {
              of [SDK.Cookie.Attribute.HTTP_ONLY, SDK.Cookie.Attribute.SECURE, SDK.Cookie.Attribute.SAME_SITE,
                  SDK.Cookie.Attribute.SOURCE_SCHEME, SDK.Cookie.Attribute.SOURCE_PORT]) {
       if (cookie.hasAttribute(attribute)) {
-        data[attribute] = String(cookie.getAttribute(attribute) ?? true);
+        if (isFlagAttribute(attribute)) {
+          data[attribute] = true;
+        } else {
+          data[attribute] = String(cookie.getAttribute(attribute) ?? true);
+        }
       }
     }
     data[SDK.Cookie.Attribute.DOMAIN] = cookie.domain() || (isRequest ? i18nString(UIStrings.na) : '');
@@ -596,7 +612,7 @@ export class CookiesTable extends UI.Widget.VBox {
     }
     data[SDK.Cookie.Attribute.PARTITION_KEY_SITE] =
         cookie.partitionKeyOpaque() ? i18nString(UIStrings.opaquePartitionKey).toString() : cookie.topLevelSite();
-    data[SDK.Cookie.Attribute.HAS_CROSS_SITE_ANCESTOR] = cookie.hasCrossSiteAncestor() ? 'true' : '';
+    data[SDK.Cookie.Attribute.HAS_CROSS_SITE_ANCESTOR] = cookie.hasCrossSiteAncestor();
     data[SDK.Cookie.Attribute.SIZE] = String(cookie.size());
     data[SDK.Cookie.Attribute.PRIORITY] = cookie.priority();
     data.priorityValue = ['Low', 'Medium', 'High'].indexOf(cookie.priority());

package/front_end/ui/legacy/components/data_grid/DataGrid.ts

@@ -1719,6 +1719,7 @@ export const enum Align {
 export const enum DataType {
   STRING = 'String',
   BOOLEAN = 'Boolean',
+  NUMBER = 'Number',
 }
 
 export const ColumnResizePadding = 30;

package/front_end/ui/legacy/components/data_grid/DataGridElement.ts

@@ -285,7 +285,9 @@ export class DataGridElement extends UI.UIUtils.HTMLElementWithLightDOMTemplate
       if (align !== Align.CENTER && align !== Align.RIGHT) {
         align = undefined;
       }
-      const dataType = column.getAttribute('type') === 'boolean' ? DataType.BOOLEAN : DataType.STRING;
+      const typeAttr = column.getAttribute('type');
+      const dataType =
+          typeAttr === 'boolean' ? DataType.BOOLEAN : (typeAttr === 'numeric' ? DataType.NUMBER : DataType.STRING);
       const weight = parseFloat(column.getAttribute('weight') || '') ?? undefined;
       const editable = column.hasAttribute('editable');
       if (editable) {
@@ -318,7 +320,6 @@ export class DataGridElement extends UI.UIUtils.HTMLElementWithLightDOMTemplate
     const visibleColumns = new Set(this.#columns.map(({id}) => id).filter(id => !this.#hiddenColumns.has(id)));
     this.#dataGrid.setColumnsVisibility(visibleColumns);
     this.#dataGrid.setEditCallback(hasEditableColumn ? this.#editCallback.bind(this) : undefined, INTERNAL_TOKEN);
-    this.#dataGrid.deleteCallback = this.#deleteCallback.bind(this);
   }
 
   #needUpdateColumns(mutationList: MutationRecord[]): boolean {
@@ -509,8 +510,8 @@ export class DataGridElement extends UI.UIUtils.HTMLElementWithLightDOMTemplate
     }
   }
 
-  #editCallback(node: DataGridElementNode, columnId: string, valueBeforeEditing: string, newText: string,
-                moveDirection?: string): void {
+  #editCallback(node: DataGridElementNode, columnId: string, valueBeforeEditing: string|boolean,
+                newText: string|boolean, moveDirection?: string): void {
     if (node.isCreationNode) {
       this.#usedCreationNode = node;
       let hasNextEditableColumn = false;
@@ -543,6 +544,9 @@ export class DataGridElement extends UI.UIUtils.HTMLElementWithLightDOMTemplate
     if (args[0] === 'refresh') {
       this.#dataGrid.refreshCallback = this.#refreshCallback.bind(this);
     }
+    if (args[0] === 'delete') {
+      this.#dataGrid.deleteCallback = this.#deleteCallback.bind(this);
+    }
   }
 
   #refreshCallback(): void {

package/front_end/ui/legacy/components/perf_ui/FlameChart.ts

@@ -12,7 +12,7 @@ import type * as NetworkTimeCalculator from '../../../../models/network_time_cal
 import * as Trace from '../../../../models/trace/trace.js';
 import * as VisualLogging from '../../../../ui/visual_logging/visual_logging.js';
 import * as Buttons from '../../../components/buttons/buttons.js';
-import {html, render, type TemplateResult} from '../../../lit/lit.js';
+import {html, nothing, render, type TemplateResult} from '../../../lit/lit.js';
 import * as UI from '../../legacy.js';
 import * as ThemeSupport from '../../theme_support/theme_support.js';
 
@@ -621,7 +621,7 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
 
   hideHighlight(): void {
     if (this.#searchResultEntryIndex === null) {
-      this.popoverElement.removeChildren();
+      this.#renderPopover(nothing);
       this.lastPopoverState = {
         entryIndex: -1,
         groupIndex: -1,
@@ -794,7 +794,7 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
         this.viewportElement.style.cursor = 'pointer';
         const iconTooltipElement = this.#prepareIconInfo(groupIndex, hoverType);
         if (iconTooltipElement) {
-          this.popoverElement.appendChild(iconTooltipElement);
+          this.#renderPopover(iconTooltipElement);
           this.updatePopoverOffset();
         }
         return;
@@ -923,9 +923,13 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
     };
   }
 
-  updatePopoverContents(popoverElement: Element|TemplateResult): void {
+  #renderPopover(content: Element|TemplateResult|string|typeof nothing): void {
     // eslint-disable-next-line @devtools/no-lit-render-outside-of-view
-    render(html`${popoverElement}`, this.popoverElement);
+    render(html`${content}`, this.popoverElement);
+  }
+
+  updatePopoverContents(popoverElement: Element|TemplateResult): void {
+    this.#renderPopover(popoverElement);
     // Must update the offset AFTER the new content has been added.
     this.updatePopoverOffset();
     this.lastPopoverState.entryIndex = -1;
@@ -941,13 +945,14 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
     if (groupIndex === this.lastPopoverState.groupIndex) {
       return this.updatePopoverOffset();
     }
-    this.popoverElement.removeChildren();
     const data = this.timelineData();
     if (!data) {
+      this.#renderPopover(nothing);
       return;
     }
     const group = data.groups.at(groupIndex);
     if (!group) {
+      this.#renderPopover(nothing);
       return;
     }
     // Only show a popover tooltip if the group has a pre-defined `fullTrackName`
@@ -956,8 +961,10 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
     const fullTrackName = group.fullTrackName;
 
     if (fullTrackName) {
-      this.popoverElement.innerText = fullTrackName;
+      this.#renderPopover(fullTrackName);
       this.updatePopoverOffset();
+    } else {
+      this.#renderPopover(nothing);
     }
     this.lastPopoverState = {
       groupIndex,

package/front_end/ui/legacy/components/quick_open/CommandMenu.ts

@@ -228,7 +228,17 @@ export class CommandMenu {
       if (!options || !registeredSettingUI.uiDescriptor.category) {
         continue;
       }
-      const setting = Common.Settings.Settings.instance().resolve(registeredSettingUI.descriptor);
+      let setting: Common.Settings.Setting<unknown>;
+      if ('isAvailable' in registeredSettingUI.descriptor) {
+        const settingResult = Common.Settings.Settings.instance().maybeResolve(
+            registeredSettingUI.descriptor as Common.Settings.ConditionalSettingDescriptor<unknown, unknown>);
+        if (!('setting' in settingResult)) {
+          continue;
+        }
+        setting = settingResult.setting;
+      } else {
+        setting = Common.Settings.Settings.instance().resolve(registeredSettingUI.descriptor);
+      }
       for (const pair of options) {
         this.#commands.push(
             CommandMenu.createSettingCommand(setting, pair.title(), pair.value, registeredSettingUI.uiDescriptor));

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -2601,6 +2601,7 @@ export const knownContextValues = new Set([
   'lmi-interpreter-settings',
   'lo',
   'load',
+  'load-cpu-profile-confirmation',
   'load-through-target',
   'loadeddata',
   'loadedmetadata',
@@ -2614,6 +2615,7 @@ export const knownContextValues = new Set([
   'local-storage-for-domain',
   'locale',
   'location',
+  'location-dialog',
   'log-level',
   'logpoint',
   'long',
@@ -2861,6 +2863,7 @@ export const knownContextValues = new Set([
   'network.add-network-request-blocking-pattern',
   'network.blocked-urls',
   'network.clear',
+  'network.clear-all',
   'network.config',
   'network.enable-remote-file-loading',
   'network.enable-remote-file-loading-documentation',

package/package.json

@@ -91,5 +91,5 @@
     "webidl2": "24.5.0",
     "yargs": "17.7.2"
   },
-  "version": "1.0.1667564"
+  "version": "1.0.1669021"
 }

package/front_end/panels/sources/AiWarningInfobarPlugin.ts

@@ -1,78 +0,0 @@
-// Copyright 2025 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as i18n from '../../core/i18n/i18n.js';
-import * as Workspace from '../../models/workspace/workspace.js';
-import type * as TextEditor from '../../ui/components/text_editor/text_editor.js';
-import * as SourceFrame from '../../ui/legacy/components/source_frame/source_frame.js';
-import * as UI from '../../ui/legacy/legacy.js';
-
-import {Plugin} from './Plugin.js';
-
-const UIStrings = {
-  /**
-   * @description Infobar text announcing that the file contents have been changed by AI
-   */
-  aiContentWarning: 'This file contains AI-generated content',
-} as const;
-const str_ = i18n.i18n.registerUIStrings('panels/sources/AiWarningInfobarPlugin.ts', UIStrings);
-const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
-
-export class AiWarningInfobarPlugin extends Plugin {
-  #editor: TextEditor.TextEditor.TextEditor|undefined = undefined;
-  #aiWarningInfobar: UI.Infobar.Infobar|null = null;
-
-  constructor(uiSourceCode: Workspace.UISourceCode.UISourceCode) {
-    super(uiSourceCode);
-    this.uiSourceCode.addEventListener(
-        Workspace.UISourceCode.Events.WorkingCopyCommitted, this.#onWorkingCopyCommitted, this);
-  }
-
-  override dispose(): void {
-    this.#aiWarningInfobar?.dispose();
-    this.#aiWarningInfobar = null;
-    this.uiSourceCode.removeEventListener(
-        Workspace.UISourceCode.Events.WorkingCopyCommitted, this.#onWorkingCopyCommitted, this);
-    super.dispose();
-  }
-
-  static override accepts(uiSourceCode: Workspace.UISourceCode.UISourceCode): boolean {
-    return uiSourceCode.contentType().hasScripts() || uiSourceCode.contentType().hasStyleSheets();
-  }
-
-  override editorInitialized(editor: TextEditor.TextEditor.TextEditor): void {
-    this.#editor = editor;
-    if (this.uiSourceCode.containsAiChanges()) {
-      this.#showAiWarningInfobar();
-    }
-  }
-
-  #onWorkingCopyCommitted(): void {
-    if (!this.uiSourceCode.containsAiChanges()) {
-      this.#aiWarningInfobar?.dispose();
-      this.#aiWarningInfobar = null;
-    }
-  }
-
-  #showAiWarningInfobar(): void {
-    const infobar = new UI.Infobar.Infobar(
-        UI.Infobar.Type.WARNING, i18nString(UIStrings.aiContentWarning), undefined, undefined,
-        'contains-ai-content-warning');
-    this.#aiWarningInfobar = infobar;
-    infobar.setCloseCallback(() => this.removeInfobar(this.#aiWarningInfobar));
-    this.attachInfobar(this.#aiWarningInfobar);
-  }
-
-  attachInfobar(bar: UI.Infobar.Infobar): void {
-    if (this.#editor) {
-      this.#editor.dispatch({effects: SourceFrame.SourceFrame.addSourceFrameInfobar.of({element: bar.element})});
-    }
-  }
-
-  removeInfobar(bar: UI.Infobar.Infobar|null): void {
-    if (this.#editor && bar) {
-      this.#editor.dispatch({effects: SourceFrame.SourceFrame.removeSourceFrameInfobar.of({element: bar.element})});
-    }
-  }
-}