chrome-devtools-frontend 1.0.1665921 → 1.0.1667564

package/front_end/ui/components/text_editor/AiCodeGenerationProvider.ts

@@ -67,7 +67,16 @@ export class AiCodeGenerationProvider {
   #aiCodeGenerationCitations: Host.AidaClient.Citation[] = [];
 
   #aidaClient: Host.AidaClient.AidaClient = new Host.AidaClient.AidaClient();
-  #boundOnUpdateAiCodeGenerationState = this.#updateAiCodeGenerationState.bind(this);
+  #boundOnAidaAvailabilityChange =
+      (ev: Common.EventTarget.EventTargetEvent<Host.AidaClient.AidaAccessPreconditions>): void => {
+        void this.#updateAiCodeGenerationStateWithAvailability(ev.data);
+      };
+  #boundOnSettingChange = (): void => {
+    const aidaAvailability = Host.AidaClient.HostConfigTracker.instance().aidaAvailability;
+    if (aidaAvailability !== undefined) {
+      void this.#updateAiCodeGenerationStateWithAvailability(aidaAvailability);
+    }
+  };
   #controller = new AbortController();
 
   private constructor(aiCodeGenerationConfig: AiCodeGenerationConfig) {
@@ -100,17 +109,20 @@ export class AiCodeGenerationProvider {
   dispose(): void {
     this.#controller.abort();
     this.#cleanupAiCodeGeneration();
-    this.#aiCodeGenerationEnabledSetting.removeChangeListener(this.#boundOnUpdateAiCodeGenerationState);
-    Host.AidaClient.HostConfigTracker.instance().removeEventListener(
-        Host.AidaClient.Events.AIDA_AVAILABILITY_CHANGED, this.#boundOnUpdateAiCodeGenerationState);
+    this.#aiCodeGenerationEnabledSetting.removeChangeListener(this.#boundOnSettingChange);
+    Host.AidaClient.HostConfigTracker.instance().removeEventListener(Host.AidaClient.Events.AIDA_AVAILABILITY_CHANGED,
+                                                                     this.#boundOnAidaAvailabilityChange);
   }
 
   editorInitialized(editor: TextEditor): void {
     this.#editor = editor;
-    Host.AidaClient.HostConfigTracker.instance().addEventListener(
-        Host.AidaClient.Events.AIDA_AVAILABILITY_CHANGED, this.#boundOnUpdateAiCodeGenerationState);
-    this.#aiCodeGenerationEnabledSetting.addChangeListener(this.#boundOnUpdateAiCodeGenerationState);
-    void this.#updateAiCodeGenerationState();
+    Host.AidaClient.HostConfigTracker.instance().addEventListener(Host.AidaClient.Events.AIDA_AVAILABILITY_CHANGED,
+                                                                  this.#boundOnAidaAvailabilityChange);
+    this.#aiCodeGenerationEnabledSetting.addChangeListener(this.#boundOnSettingChange);
+    const initialAvailability = Host.AidaClient.HostConfigTracker.instance().aidaAvailability;
+    if (initialAvailability !== undefined) {
+      void this.#updateAiCodeGenerationStateWithAvailability(initialAvailability);
+    }
   }
 
   async #setupAiCodeGeneration(): Promise<void> {
@@ -137,8 +149,8 @@ export class AiCodeGenerationProvider {
     });
   }
 
-  async #updateAiCodeGenerationState(): Promise<void> {
-    const aidaAvailability = await Host.AidaClient.AidaClient.checkAccessPreconditions();
+  async #updateAiCodeGenerationStateWithAvailability(aidaAvailability: Host.AidaClient.AidaAccessPreconditions):
+      Promise<void> {
     const isAvailable = aidaAvailability === Host.AidaClient.AidaAccessPreconditions.AVAILABLE;
     const devtoolsLocale = i18n.DevToolsLocale.DevToolsLocale.instance().locale;
     const aiCodeGenerationEnabled =
@@ -384,8 +396,7 @@ export class AiCodeGenerationProvider {
       this.#aiCodeGenerationConfig.onResponseReceived();
       return;
     } catch (e) {
-      if (e instanceof Host.DispatchHttpRequestClient.DispatchHttpRequestError &&
-          e.type === Host.DispatchHttpRequestClient.ErrorType.ABORT) {
+      if (e instanceof Host.AidaClient.AidaAbortError) {
         return;
       }
       AiCodeGeneration.debugLog('Error while fetching code generation suggestions from AIDA', e);

package/front_end/ui/components/text_editor/config.ts

@@ -411,6 +411,13 @@ function getTooltipHost(): ShadowRoot {
   return tooltipHost;
 }
 
+export function removeTooltipHost(): void {
+  if (tooltipHost) {
+    tooltipHost.host.remove();
+    tooltipHost = null;
+  }
+}
+
 class CompletionHint extends CM.WidgetType {
   constructor(readonly text: string) {
     super();

package/front_end/ui/legacy/AppProvider.ts

@@ -3,11 +3,12 @@
 // found in the LICENSE file.
 
 import * as Root from '../../core/root/root.js';
+import type * as Foundation from '../../foundation/foundation.js';
 
 import type {App} from './App.js';
 
 export interface AppProvider {
-  createApp(): App;
+  createApp(universe: Foundation.Universe.Universe): App;
 }
 
 const registeredAppProvider: AppProviderRegistration[] = [];

package/front_end/ui/legacy/RootView.ts

@@ -3,18 +3,25 @@
 // found in the LICENSE file.
 /* eslint-disable @devtools/no-imperative-dom-api */
 
+import type * as Foundation from '../../foundation/foundation.js';
+
 import rootViewStyles from './rootView.css.js';
+import {UniverseRequestEvent} from './UniverseRequestEvent.js';
 import {VBox} from './Widget.js';
 import {ZoomManager} from './ZoomManager.js';
 
 export class RootView extends VBox {
   private window?: (Window&typeof globalThis)|null;
-  constructor() {
+  constructor(universe: Foundation.Universe.Universe) {
     super();
     this.markAsRoot();
     this.element.classList.add('root-view');
     this.registerRequiredCSS(rootViewStyles);
     this.element.setAttribute('spellcheck', 'false');
+    this.element.addEventListener(UniverseRequestEvent.eventName, (event: UniverseRequestEvent) => {
+      event.universe = universe;
+      event.stopPropagation();
+    });
   }
 
   attachToDocument(document: Document): void {

package/front_end/ui/legacy/UniverseRequestEvent.ts

@@ -0,0 +1,19 @@
+// Copyright 2026 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import type * as Foundation from '../../foundation/foundation.js';
+
+export class UniverseRequestEvent extends Event {
+  static readonly eventName = 'universerequest';
+
+  /**
+   * The `Universe` will be filled in by the `RootView` in the event handler.
+   * Widget.ts dispatches a new UniverseRequestEvent, and retrieves the Universe from the event right after.
+   */
+  universe?: Foundation.Universe.Universe;
+
+  constructor() {
+    super(UniverseRequestEvent.eventName, {bubbles: true, composed: true});
+  }
+}

package/front_end/ui/legacy/Widget.ts

@@ -32,14 +32,36 @@
 import '../dom_extension/dom_extension.js';
 
 import * as Platform from '../../core/platform/platform.js';
+import type * as Root from '../../core/root/root.js';
+import type * as Foundation from '../../foundation/foundation.js';
 import * as Geometry from '../../models/geometry/geometry.js';
 import * as Lit from '../../ui/lit/lit.js';
 
 import {appendStyle, deepActiveElement} from './DOMUtilities.js';
 import {cloneCustomElement, createShadowRootWithCoreStyles} from './UIUtils.js';
+import {UniverseRequestEvent} from './UniverseRequestEvent.js';
+
+// eslint-disable-next-line @typescript-eslint/naming-convention
+type InjectReturn<T> = T extends {INJECT: infer I} ? I :
+                                                     // eslint-disable-next-line @typescript-eslint/naming-convention
+                                                     T extends {constructor: {INJECT: infer I}} ? I : [];
+
+type MapConstructors<T> = {
+  [K in keyof T]: T[K] extends Root.DevToolsContext.ConstructorT<infer Instance>?
+      Instance :
+      T[K] extends new (...args: any[]) => infer Instance ? Instance : never;
+};
+
+export type WidgetDependencies<T> = MapConstructors<InjectReturn<T>>;
 
 const {html} = Lit;
 
+export function lookupUniverseForElement(element: HTMLElement): Foundation.Universe.Universe|undefined {
+  const event = new UniverseRequestEvent();
+  element.dispatchEvent(event);
+  return event.universe;
+}
+
 // Remember the original DOM mutation methods here, since we
 // will override them below to sanity check the Widget system.
 const originalAppendChild = Node.prototype.appendChild;
@@ -55,8 +77,9 @@ function assert(condition: unknown, message: string): void {
 
 export type AnyWidget = Widget<HTMLElement|DocumentFragment>;
 
-type WidgetConstructor<WidgetT extends AnyWidget> = new (element: HTMLElement) => WidgetT;
-type WidgetProducer<WidgetT extends AnyWidget> = (element: HTMLElement) => WidgetT;
+type WidgetConstructor<WidgetT extends AnyWidget> = new (element: HTMLElement, ...args: any[]) => WidgetT;
+type WidgetProducer<WidgetT extends AnyWidget> = (element: HTMLElement, universe?: Foundation.Universe.Universe) =>
+    WidgetT;
 type WidgetFactory<WidgetT extends AnyWidget> = WidgetConstructor<WidgetT>|WidgetProducer<WidgetT>;
 type InferWidgetTFromFactory<F> = F extends WidgetFactory<infer WidgetT>? WidgetT : never;
 
@@ -199,8 +222,8 @@ export function registerWidgetConfig<WidgetT extends AnyWidget>(element: HTMLEle
   widgetConfigs.set(element, config);
 }
 
-function instantiateWidget<WidgetT extends AnyWidget>(element: HTMLElement,
-                                                      widgetConfig: WidgetConfig<WidgetT>): WidgetT {
+export function instantiateWidget<WidgetT extends AnyWidget>(element: HTMLElement,
+                                                             widgetConfig: WidgetConfig<WidgetT>): WidgetT {
   if (!widgetConfig.widgetClass) {
     throw new Error('No widgetClass defined');
   }
@@ -208,10 +231,21 @@ function instantiateWidget<WidgetT extends AnyWidget>(element: HTMLElement,
   let newWidget: WidgetT;
   if (Widget.isPrototypeOf(widgetConfig.widgetClass)) {
     const ctor = widgetConfig.widgetClass as WidgetConstructor<WidgetT>;
-    newWidget = new ctor(element);
+    const depsCtors = (ctor as unknown as typeof Widget).INJECT;
+    if (depsCtors && depsCtors.length > 0) {
+      const universe = lookupUniverseForElement(element);
+      if (!universe) {
+        throw new Error(`No Universe found for widget ${ctor.name} requesting dependencies via INJECT.`);
+      }
+      const deps = depsCtors.map(depCtor => universe.get(depCtor));
+      newWidget = new ctor(element, deps);
+    } else {
+      newWidget = new ctor(element);
+    }
   } else {
     const factory = widgetConfig.widgetClass as WidgetProducer<WidgetT>;
-    newWidget = factory(element);
+    const universe = lookupUniverseForElement(element);
+    newWidget = factory(element, universe);
   }
 
   if (widgetConfig.widgetParams) {
@@ -573,6 +607,15 @@ export class Widget<ContentTypeT extends HTMLElement|DocumentFragment = HTMLElem
     widgetMap.set(this.element, this);
   }
 
+  /**
+   * An array of dependency constructors that this widget class expects to receive as an array
+   * in the second positional argument to its constructor during `instantiateWidget`:
+   * `constructor(element: HTMLElement, deps: WidgetDependencies<typeof MyWidget>)`
+   *
+   * Override this static field in sub-classes to specify dependency constructors to be retrieved from `Universe`.
+   */
+  static readonly INJECT: ReadonlyArray<Root.DevToolsContext.ConstructorT<unknown>> = [];
+
   /**
    * Returns the {@link Widget} whose element is the given `node`, or `undefined`
    * if the `node` is not an element for a widget.

package/front_end/ui/legacy/inspectorCommon.css

@@ -558,7 +558,7 @@ dt-icon-label {
   padding: 1px 3px;
   margin: 0 2px;
   font-size: 11px;
-  font-family: sans-serif;
+  font-family: inherit;
   white-space: nowrap;
   display: inline-block;
 }

package/front_end/ui/legacy/legacy.ts

@@ -51,6 +51,7 @@ import * as Tooltip from './Tooltip.js';
 import * as TreeOutline from './Treeoutline.js';
 import * as UIUserMetrics from './UIUserMetrics.js';
 import * as UIUtils from './UIUtils.js';
+import * as UniverseRequestEvent from './UniverseRequestEvent.js';
 import * as View from './View.js';
 import * as ViewManager from './ViewManager.js';
 import * as Widget from './Widget.js';
@@ -106,6 +107,7 @@ export {
   TreeOutline,
   UIUserMetrics,
   UIUtils,
+  UniverseRequestEvent,
   View,
   ViewManager,
   Widget,

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -3351,6 +3351,7 @@ export const knownContextValues = new Set([
   'request-payload',
   'request-types',
   'required',
+  'resend',
   'reset',
   'reset-children',
   'reset-columns',
@@ -4081,6 +4082,7 @@ export const knownContextValues = new Set([
   'timeline-dim-third-parties',
   'timeline-dim-unrelated-events',
   'timeline-disable-js-sampling',
+  'timeline-enable-soft-navigations',
   'timeline-enhanced-traces',
   'timeline-event-summary-widget',
   'timeline-experimental-insights',

package/package.json

@@ -27,7 +27,6 @@
     "lint": "vpython3 third_party/node/node.py --output scripts/test/run_lint_check.mjs",
     "prebuild": "gn gen out/Default",
     "rdb": "rdb stream -new -realm chromium:public --",
-    "rdb-exonerate": "npm run rdb -- vpython3 third_party/node/node.py --output scripts/run_on_target.mjs gen/test/exonerate.js",
     "start": "vpython3 third_party/node/node.py --output scripts/run_start.mjs",
     "webtest": "vpython3 third_party/node/node.py --output scripts/npm_test.js",
     "watch": "npm run build -- --watch",
@@ -92,5 +91,5 @@
     "webidl2": "24.5.0",
     "yargs": "17.7.2"
   },
-  "version": "1.0.1665921"
+  "version": "1.0.1667564"
 }

package/front_end/models/issues_manager/descriptions/SameSiteExcludeContextDowngradeRead.md

@@ -1,8 +0,0 @@
-# Migrate entirely to HTTPS to have cookies sent to same-site subresources
-
-A cookie was not sent to {PLACEHOLDER_destination} origin from {PLACEHOLDER_origin} context.
-Because this cookie would have been sent across schemes on the same site, it was not sent.
-This behavior enhances the `SameSite` attribute’s protection of user data from request forgery by network attackers.
-
-Resolve this issue by migrating your site (as defined by the eTLD+1) entirely to HTTPS.
-It is also recommended to mark the cookie with the `Secure` attribute if that is not already the case.

package/front_end/models/issues_manager/descriptions/SameSiteExcludeContextDowngradeSet.md

@@ -1,8 +0,0 @@
-# Migrate entirely to HTTPS to allow cookies to be set by same-site subresources
-
-A cookie was not set by {PLACEHOLDER_origin} origin in {PLACEHOLDER_destination} context.
-Because this cookie would have been set across schemes on the same site, it was blocked.
-This behavior enhances the `SameSite` attribute’s protection of user data from request forgery by network attackers.
-
-Resolve this issue by migrating your site (as defined by the eTLD+1) entirely to HTTPS.
-It is also recommended to mark the cookie with the `Secure` attribute if that is not already the case.

package/front_end/models/issues_manager/descriptions/SameSiteExcludeNavigationContextDowngrade.md

@@ -1,8 +0,0 @@
-# Migrate entirely to HTTPS to have cookies sent on same-site requests
-
-A cookie was not sent to {PLACEHOLDER_destination} origin from {PLACEHOLDER_origin} context on a navigation.
-Because this cookie would have been sent across schemes on the same site, it was not sent.
-This behavior enhances the `SameSite` attribute’s protection of user data from request forgery by network attackers.
-
-Resolve this issue by migrating your site (as defined by the eTLD+1) entirely to HTTPS.
-It is also recommended to mark the cookie with the `Secure` attribute if that is not already the case.

package/front_end/models/issues_manager/descriptions/SameSiteWarnCrossDowngradeRead.md

@@ -1,8 +0,0 @@
-# Migrate entirely to HTTPS to continue having cookies sent to same-site subresources
-
-A cookie is being sent to {PLACEHOLDER_destination} origin from {PLACEHOLDER_origin} context.
-Because this cookie is being sent across schemes on the same site, it will not be sent in a future version of Chrome.
-This behavior enhances the `SameSite` attribute’s protection of user data from request forgery by network attackers.
-
-Resolve this issue by migrating your site (as defined by the eTLD+1) entirely to HTTPS.
-It is also recommended to mark the cookie with the `Secure` attribute if that is not already the case.

package/front_end/models/issues_manager/descriptions/SameSiteWarnCrossDowngradeSet.md

@@ -1,8 +0,0 @@
-# Migrate entirely to HTTPS to continue allowing cookies to be set by same-site subresources
-
-A cookie is being set by {PLACEHOLDER_origin} origin in {PLACEHOLDER_destination} context.
-Because this cookie is being set across schemes on the same site, it will be blocked in a future version of Chrome.
-This behavior enhances the `SameSite` attribute’s protection of user data from request forgery by network attackers.
-
-Resolve this issue by migrating your site (as defined by the eTLD+1) entirely to HTTPS.
-It is also recommended to mark the cookie with the `Secure` attribute if that is not already the case.

package/front_end/models/issues_manager/descriptions/SameSiteWarnStrictLaxDowngradeStrict.md

@@ -1,8 +0,0 @@
-# Migrate entirely to HTTPS to continue having cookies sent on same-site requests
-
-A cookie is being sent to {PLACEHOLDER_destination} origin from {PLACEHOLDER_origin} context on a navigation.
-Because this cookie is being sent across schemes on the same site, it will not be sent in a future version of Chrome.
-This behavior enhances the `SameSite` attribute’s protection of user data from request forgery by network attackers.
-
-Resolve this issue by migrating your site (as defined by the eTLD+1) entirely to HTTPS.
-It is also recommended to mark the cookie with the `Secure` attribute if that is not already the case.