chrome-devtools-frontend 1.0.1662965 → 1.0.1664496

package/front_end/panels/elements/StylesAiCodeCompletionProvider.ts

@@ -7,8 +7,8 @@ import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import type * as SDK from '../../core/sdk/sdk.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as AiCodeCompletion from '../../models/ai_code_completion/ai_code_completion.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
 import * as TextEditor from '../../ui/components/text_editor/text_editor.js';
 
 export class StylesAiCodeCompletionProvider {

package/front_end/panels/elements/StylesContainer.ts

@@ -3,8 +3,8 @@
 // found in the LICENSE file.
 
 import type * as SDK from '../../core/sdk/sdk.js';
+import type * as TextUtils from '../../core/text_utils/text_utils.js';
 import type * as ComputedStyle from '../../models/computed_style/computed_style.js';
-import type * as TextUtils from '../../models/text_utils/text_utils.js';
 import type * as InlineEditor from '../../ui/legacy/components/inline_editor/inline_editor.js';
 import type * as Components from '../../ui/legacy/components/utils/utils.js';
 

package/front_end/panels/elements/StylesSidebarPane.ts

@@ -42,11 +42,11 @@ import * as Platform from '../../core/platform/platform.js';
 import {assertNotNullOrUndefined} from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as Protocol from '../../generated/protocol.js';
 import * as AiCodeCompletion from '../../models/ai_code_completion/ai_code_completion.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import type * as ComputedStyle from '../../models/computed_style/computed_style.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
 import * as CodeMirror from '../../third_party/codemirror.next/codemirror.next.js';
 import * as TextEditor from '../../ui/components/text_editor/text_editor.js';
 import {createIcon, Icon} from '../../ui/kit/kit.js';

package/front_end/panels/elements/components/CSSPropertyDocsView.ts

@@ -22,7 +22,7 @@ const UIStrings = {
   /**
    * @description Text for a checkbox to turn off the CSS property documentation.
    */
-  dontShow: 'Don\'t show',
+  dontShow: 'Don’t show',
   /**
    * @description Text indicating that the CSS property has limited availability across major browsers.
    */

package/front_end/panels/explain/components/ConsoleInsight.ts

@@ -90,9 +90,9 @@ const UIStrings = {
    */
   learnMore: 'Learn more',
   /**
-   * @description The error message when the user is not logged in into Chrome.
+   * @description The error message when the user is not logged in to Chrome.
    */
-  notLoggedIn: 'This feature is only available when you sign into Chrome with your Google account.',
+  notLoggedIn: 'This feature is only available when you sign in to Chrome with your Google account.',
   /**
    * @description The title of a button which opens the Chrome SignIn page.
    */

package/front_end/panels/issues/AffectedLazyLoadImagesView.ts

@@ -0,0 +1,76 @@
+// Copyright 2026 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as i18n from '../../core/i18n/i18n.js';
+import type * as Platform from '../../core/platform/platform.js';
+import type * as IssuesManager from '../../models/issues_manager/issues_manager.js';
+import {html, render} from '../../ui/lit/lit.js';
+
+import {AffectedResourcesView} from './AffectedResourcesView.js';
+import type {IssueView} from './IssueView.js';
+
+const UIStrings = {
+  /**
+   * @description Noun for singular or plural number of affected element resource indication in issue view.
+   */
+  nElements: '{n, plural, =1 {# element} other {# elements}}',
+} as const;
+const str_ = i18n.i18n.registerUIStrings('panels/issues/AffectedLazyLoadImagesView.ts', UIStrings);
+const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+
+export interface ViewInput {
+  issues: Iterable<IssuesManager.LazyLoadImageIssue.LazyLoadImageIssue>;
+  issueCategory: IssuesManager.Issue.IssueCategory;
+  createElementCell: (element: IssuesManager.Issue.AffectedElement,
+                      category: IssuesManager.Issue.IssueCategory) => Promise<Element>;
+}
+
+export type View = (input: ViewInput, output: object, target: HTMLElement) => Promise<void>;
+
+export const DEFAULT_VIEW: View = async (input, _output, target) => {
+  const templates = [];
+  for (const issue of input.issues) {
+    for (const element of issue.elements()) {
+      templates.push(html`<tr>
+        ${await input.createElementCell(element, input.issueCategory)}
+      </tr>`);
+    }
+  }
+  render(html`${templates}`, target);
+};
+
+export class AffectedLazyLoadImagesView extends AffectedResourcesView {
+  readonly #view: View;
+
+  constructor(parent: IssueView, issue: IssuesManager.IssueAggregator.AggregatedIssue, jslogContext: string,
+              view = DEFAULT_VIEW) {
+    super(parent, issue, jslogContext);
+    this.#view = view;
+  }
+
+  override update(): void {
+    this.requestResolver.clear();
+    void this.#render();
+  }
+
+  protected override getResourceNameWithCount(count: number): Platform.UIString.LocalizedString {
+    return i18nString(UIStrings.nElements, {n: count});
+  }
+
+  async #render(): Promise<void> {
+    const issues = this.issue.getLazyLoadImageIssues();
+    let count = 0;
+    for (const issue of issues) {
+      count += issue.elementCount();
+    }
+    this.updateAffectedResourceCount(count);
+
+    const input = {
+      issues,
+      issueCategory: this.issue.getCategory(),
+      createElementCell: this.createElementCell.bind(this),
+    };
+    await this.#view(input, {}, this.affectedResources);
+  }
+}

package/front_end/panels/issues/AffectedResourcesView.ts

@@ -31,7 +31,7 @@ const UIStrings = {
   /**
    * @description Tooltip for button linking to the Elements panel
    */
-  clickToRevealTheFramesDomNodeIn: 'Click to reveal the frame\'s DOM node in the Elements panel',
+  clickToRevealTheFramesDomNodeIn: 'Click to reveal the frame’s DOM node in the Elements panel',
   /**
    * @description Replacement text for a link to an HTML element which is not available (anymore).
    */

package/front_end/panels/issues/CorsIssueDetailsView.ts

@@ -93,7 +93,7 @@ const UIStrings = {
   /**
    * @description Content for the problem column in the affected resources table for a CORS issue that indicates that the HTTP status the preflight request was not successful.
    */
-  preflightInvalidStatus: 'HTTP status of preflight request didn\'t indicate success',
+  preflightInvalidStatus: 'HTTP status of preflight request didn’t indicate success',
   /**
    * @description Title for a column in the affected resources for a CORS issue showing the origin that was allowed according to CORS headers.
    */

package/front_end/panels/issues/IssueView.ts

@@ -25,6 +25,7 @@ import {AffectedDirectivesView} from './AffectedDirectivesView.js';
 import {AffectedDocumentsInQuirksModeView} from './AffectedDocumentsInQuirksModeView.js';
 import {AffectedElementsView} from './AffectedElementsView.js';
 import {AffectedHeavyAdView} from './AffectedHeavyAdView.js';
+import {AffectedLazyLoadImagesView} from './AffectedLazyLoadImagesView.js';
 import {AffectedMetadataAllowedSitesView} from './AffectedMetadataAllowedSitesView.js';
 import {AffectedPartitioningBlobURLView} from './AffectedPartitioningBlobURLView.js';
 import {AffectedPermissionElementsView} from './AffectedPermissionElementsView.js';
@@ -259,6 +260,7 @@ export class IssueView extends UI.TreeOutline.TreeElement {
       new AffectedDescendantsWithinSelectElementView(this, this.#issue, 'disallowed-select-descendants-details'),
       new AffectedPartitioningBlobURLView(this, this.#issue, 'partitioning-blob-url-details'),
       new AffectedPermissionElementsView(this, this.#issue, 'permission-element-elements'),
+      new AffectedLazyLoadImagesView(this, this.#issue, 'lazy-load-image-details'),
       new AffectedSelectivePermissionsInterventionView(this, this.#issue, 'selective-permissions-intervention-details'),
     ];
     this.#hiddenIssuesMenu = new Components.HideIssuesMenu.HideIssuesMenu();

package/front_end/panels/issues/issues.ts

@@ -2,12 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as AffectedLazyLoadImagesView from './AffectedLazyLoadImagesView.js';
 import * as AffectedSelectivePermissionsInterventionView from './AffectedSelectivePermissionsInterventionView.js';
 import * as IssueRevealer from './IssueRevealer.js';
 import * as IssuesPane from './IssuesPane.js';
 import * as IssueView from './IssueView.js';
 
 export {
+  AffectedLazyLoadImagesView,
   AffectedSelectivePermissionsInterventionView,
   IssueRevealer,
   IssuesPane,

package/front_end/panels/layer_viewer/Layers3DView.ts

@@ -45,7 +45,7 @@ const UIStrings = {
   /**
    * @description Text in DView of the Layers panel
    */
-  cantDisplayLayers: 'Can\'t display layers',
+  cantDisplayLayers: 'Can’t display layers',
   /**
    * @description Text in DView of the Layers panel
    */

package/front_end/panels/lighthouse/LighthouseController.ts

@@ -900,3 +900,8 @@ export interface EventTypes {
   [Events.PageWarningsChanged]: PageWarningsChangedEvent;
   [Events.AuditProgressChanged]: AuditProgressChangedEvent;
 }
+
+export function clearSettingsCacheForTest(): void {
+  runtimeSettings = null;
+  presets = null;
+}

package/front_end/panels/lighthouse/LighthouseReportRenderer.ts

@@ -7,8 +7,8 @@ import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import type * as LighthouseModel from '../../models/lighthouse/lighthouse.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as LighthouseReport from '../../third_party/lighthouse/report/report.js';
 import * as Components from '../../ui/legacy/components/utils/utils.js';

package/front_end/panels/network/BinaryResourceView.ts

@@ -9,7 +9,7 @@ import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
-import type * as TextUtils from '../../models/text_utils/text_utils.js';
+import type * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as SourceFrame from '../../ui/legacy/components/source_frame/source_frame.js';
 import * as UI from '../../ui/legacy/legacy.js';
 

package/front_end/panels/network/NetworkDataGridNode.ts

@@ -108,7 +108,7 @@ const UIStrings = {
   /**
    * @description Reason why a request was blocked shown in the Network panel
    */
-  coopSandboxedIframeCannotNavigateToCoopPage: 'Sandboxed iframe\'s popup cannot navigate to COOP page',
+  coopSandboxedIframeCannotNavigateToCoopPage: 'Sandboxed iframe’s popup cannot navigate to COOP page',
   /**
    * @description Reason why a request was blocked shown in the Network panel
    */
@@ -610,6 +610,27 @@ export const _backgroundColors: Record<string, string> = {
   FromFrame: '--network-grid-from-frame-color',
 };
 
+// name/path/url are the primary cells that own the request icon, the Ask AI
+// button and the row click handlers. The first visible one is decorated, which
+// is not necessarily visible index 0 (the pinned request-number column can come
+// first).
+const PRIMARY_COLUMNS = new Set(['name', 'path', 'url']);
+
+function firstPrimaryColumn(dataGrid: DataGrid.DataGrid.DataGridImpl<unknown>|null): DataGrid.DataGrid.ColumnDescriptor|
+    undefined {
+  return dataGrid?.visibleColumnsArray.find(column => PRIMARY_COLUMNS.has(column.id));
+}
+
+function isFirstPrimaryColumn(dataGrid: DataGrid.DataGrid.DataGridImpl<unknown>|null, columnId: string): boolean {
+  const firstPrimary = firstPrimaryColumn(dataGrid);
+  // When the node is not attached to a grid yet there are no visible columns to
+  // inspect, so fall back to treating any primary column as the first one.
+  if (!firstPrimary) {
+    return PRIMARY_COLUMNS.has(columnId);
+  }
+  return firstPrimary.id === columnId;
+}
+
 export class NetworkRequestNode extends NetworkNode {
   private initiatorCell: Element|null;
   private requestInternal: SDK.NetworkRequest.NetworkRequest;
@@ -1351,9 +1372,8 @@ export class NetworkRequestNode extends NetworkNode {
   }
 
   private renderPrimaryCell(cell: HTMLElement, columnId: string, text?: string): void {
-    const columnIndex = (this.dataGrid as DataGrid.DataGrid.DataGridImpl<unknown>)?.indexOfVisibleColumn(columnId) | 0;
-    const isFirstCell = (columnIndex === 0);
-    if (isFirstCell) {
+    const dataGrid = this.dataGrid as DataGrid.DataGrid.DataGridImpl<unknown>| null;
+    if (isFirstPrimaryColumn(dataGrid, columnId)) {
       const leftPadding = this.leftPadding ? this.leftPadding + 'px' : '';
       cell.style.setProperty('padding-left', leftPadding);
       cell.tabIndex = -1;
@@ -1814,7 +1834,8 @@ export class NetworkRequestNode extends NetworkNode {
 export class NetworkGroupNode extends NetworkNode {
   override createCells(element: Element): void {
     super.createCells(element);
-    const primaryColumn = (this.dataGrid as DataGrid.DataGrid.DataGridImpl<unknown>).visibleColumnsArray[0];
+    const dataGrid = this.dataGrid as DataGrid.DataGrid.DataGridImpl<unknown>;
+    const primaryColumn = firstPrimaryColumn(dataGrid) ?? dataGrid.visibleColumnsArray[0];
     const localizedTitle = `${primaryColumn.title}`;
     const localizedLevel = i18nString(UIStrings.level);
     this.nodeAccessibleText =
@@ -1822,8 +1843,9 @@ export class NetworkGroupNode extends NetworkNode {
   }
 
   override renderCell(c: Element, columnId: string): void {
-    const columnIndex = (this.dataGrid as DataGrid.DataGrid.DataGridImpl<unknown>).indexOfVisibleColumn(columnId);
-    if (columnIndex === 0) {
+    const dataGrid = this.dataGrid as DataGrid.DataGrid.DataGridImpl<unknown>;
+    const primaryColumn = firstPrimaryColumn(dataGrid) ?? dataGrid.visibleColumnsArray[0];
+    if (primaryColumn.id === columnId) {
       const cell = (c as HTMLElement);
       const leftPadding = this.leftPadding ? this.leftPadding + 'px' : '';
       cell.style.setProperty('padding-left', leftPadding);

package/front_end/panels/network/NetworkLogView.ts

@@ -40,13 +40,13 @@ import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as Protocol from '../../generated/protocol.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import * as HAR from '../../models/har/har.js';
 import * as Logs from '../../models/logs/logs.js';
 import * as NetworkTimeCalculator from '../../models/network_time_calculator/network_time_calculator.js';
 import * as Persistence from '../../models/persistence/persistence.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as NetworkForward from '../../panels/network/forward/forward.js';
 import * as Sources from '../../panels/sources/sources.js';

package/front_end/panels/network/NetworkLogViewColumns.ts

@@ -980,6 +980,12 @@ const DEFAULT_COLUMN_CONFIG = {
 };
 
 const DEFAULT_COLUMNS = [
+  {
+    id: 'request-number',
+    title: i18nLazyString(UIStrings.requestNumber),
+    align: DataGrid.DataGrid.Align.RIGHT,
+    sortingFunction: NetworkRequestNode.RequestNumberComparator,
+  },
   {
     id: 'name',
     title: i18nLazyString(UIStrings.name),
@@ -1004,12 +1010,6 @@ const DEFAULT_COLUMNS = [
     hideableGroup: 'path',
     sortingFunction: NetworkRequestNode.RequestURLComparator,
   },
-  {
-    id: 'request-number',
-    title: i18nLazyString(UIStrings.requestNumber),
-    align: DataGrid.DataGrid.Align.RIGHT,
-    sortingFunction: NetworkRequestNode.RequestNumberComparator,
-  },
   {
     id: 'method',
     title: i18nLazyString(UIStrings.method),

package/front_end/panels/network/NetworkPanel.ts

@@ -71,13 +71,13 @@ const UIStrings = {
    */
   search: 'Search',
   /**
-   * @description Tooltip text that appears on the setting to preserve log when hovering over the item
+   * @description Tooltip text that appears on the setting to keep log when hovering over the item.
    */
-  doNotClearLogOnPageReload: 'Do not clear log on page reload / navigation',
+  doNotClearLogOnPageReload: 'Don’t clear log on page reload / navigation',
   /**
-   * @description Text to preserve the log after refreshing
+   * @description Text to keep the log after refreshing.
    */
-  preserveLog: 'Preserve log',
+  preserveLog: 'Keep log',
   /**
    * @description Text to disable cache while DevTools is open
    */

package/front_end/panels/network/NetworkSearchScope.ts

@@ -6,8 +6,8 @@ import type * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import type * as SDK from '../../core/sdk/sdk.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import type * as Logs from '../../models/logs/logs.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
 import type * as Workspace from '../../models/workspace/workspace.js';
 import * as NetworkForward from '../../panels/network/forward/forward.js';
 import type * as Search from '../search/search.js';

package/front_end/panels/network/RequestConditionsDrawer.ts

@@ -46,7 +46,7 @@ const UIStrings = {
    * @example {Learn more} PH1
    */
   noThrottlingOrBlockingPattern:
-      `To throttle or block a network request, add a rule here manually or via the network panel's context menu. {PH1}`,
+      `To throttle or block a network request, add a rule here manually or via the network panel’s context menu. {PH1}`,
   /**
    * @description Text in Blocked URLs Pane of the Network panel
    * @example {4} PH1

package/front_end/panels/network/RequestHTMLView.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import type * as TextUtils from '../../models/text_utils/text_utils.js';
+import type * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import {html, nothing, render} from '../../ui/lit/lit.js';
 

package/front_end/panels/network/RequestPayloadView.ts

@@ -37,7 +37,7 @@ import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as ObjectUI from '../../ui/legacy/components/object_ui/object_ui.js';
 // eslint-disable-next-line @devtools/es-modules-import

package/front_end/panels/network/RequestPreviewView.ts

@@ -7,7 +7,7 @@ import '../../ui/legacy/legacy.js';
 
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as SDK from '../../core/sdk/sdk.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as SourceFrame from '../../ui/legacy/components/source_frame/source_frame.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import {render} from '../../ui/lit/lit.js';

package/front_end/panels/network/RequestResponseView.ts

@@ -6,7 +6,7 @@ import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as SDK from '../../core/sdk/sdk.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as SourceFrame from '../../ui/legacy/components/source_frame/source_frame.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Lit from '../../ui/lit/lit.js';

package/front_end/panels/network/ResourceChunkView.ts

@@ -9,7 +9,7 @@ import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import type * as SDK from '../../core/sdk/sdk.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as DataGrid from '../../ui/legacy/components/data_grid/data_grid.js';
 import * as SourceFrame from '../../ui/legacy/components/source_frame/source_frame.js';
 import * as UI from '../../ui/legacy/legacy.js';

package/front_end/panels/network/ResourceDirectSocketChunkView.ts

@@ -7,7 +7,7 @@ import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as DataGrid from '../../ui/legacy/components/data_grid/data_grid.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';

package/front_end/panels/network/ResourceWebSocketFrameView.ts

@@ -25,7 +25,7 @@ import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 

package/front_end/panels/network/components/ResponseHeaderSection.ts

@@ -9,10 +9,10 @@ import * as i18n from '../../../core/i18n/i18n.js';
 import * as Platform from '../../../core/platform/platform.js';
 import type {NameValue} from '../../../core/sdk/NetworkRequest.js';
 import type * as SDK from '../../../core/sdk/sdk.js';
+import * as TextUtils from '../../../core/text_utils/text_utils.js';
 import * as Protocol from '../../../generated/protocol.js';
 import * as IssuesManager from '../../../models/issues_manager/issues_manager.js';
 import * as Persistence from '../../../models/persistence/persistence.js';
-import * as TextUtils from '../../../models/text_utils/text_utils.js';
 import type * as Workspace from '../../../models/workspace/workspace.js';
 import * as NetworkForward from '../../../panels/network/forward/forward.js';
 import * as Sources from '../../../panels/sources/sources.js';

package/front_end/panels/network/forward/UIRequestLocation.ts

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 import type * as SDK from '../../../core/sdk/sdk.js';
-import type * as TextUtils from '../../../models/text_utils/text_utils.js';
+import type * as TextUtils from '../../../core/text_utils/text_utils.js';
 
 export const enum UIHeaderSection {
   GENERAL = 'General',

package/front_end/panels/network/network-meta.ts

@@ -110,7 +110,7 @@ const UIStrings = {
   /**
    * @description Title of a setting under the Network category that can be invoked through the Command Menu
    */
-  dontGroupNetworkLogItemsByFrame: 'Don\'t group network log items by frame',
+  dontGroupNetworkLogItemsByFrame: 'Don’t group network log items by frame',
   /**
    * @description Title of a button for clearing the network log
    */
@@ -132,13 +132,13 @@ const UIStrings = {
    * @description Title of an action in the Network panel that disables options in the UI to copy or export
    *              HAR (not translatable) with sensitive data.
    */
-  dontAllowToGenerateHarWithSensitiveData: 'Don\'t allow to generate `HAR` with sensitive data',
+  dontAllowToGenerateHarWithSensitiveData: 'Don’t allow to generate `HAR` with sensitive data',
   /**
    * @description Tooltip shown as documentation when hovering the (?) icon next to the "Allow to generate
    *              HAR with sensitive data" option in the Settings panel.
    */
   allowToGenerateHarWithSensitiveDataDocumentation:
-      'By default generated HAR logs are sanitized and don\'t include `Cookie`, `Set-Cookie`, or `Authorization` HTTP headers. When this setting is enabled, options to export/copy HAR with sensitive data are provided.',
+      'By default generated HAR logs are sanitized and don’t include `Cookie`, `Set-Cookie`, or `Authorization` HTTP headers. When this setting is enabled, options to export/copy HAR with sensitive data are provided.',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/network/network-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);

package/front_end/panels/profiler/HeapProfileView.ts

@@ -210,7 +210,7 @@ export class HeapProfileView extends UI.View.SimpleView implements UI.Searchable
   #selectedNode: ProfileDataGridNode|null = null;
 
   readonly linkifierInternal: Components.Linkifier.Linkifier = new Components.Linkifier.Linkifier(maxLinkLength);
-  nodeFormatter!: Formatter;
+  nodeFormatter!: NodeFormatter;
   viewType!: Common.Settings.Setting<ViewTypes>;
   bottomUpProfileDataGridTree?: BottomUpProfileDataGridTree|null;
   topDownProfileDataGridTree?: TopDownProfileDataGridTree|null;
@@ -344,16 +344,16 @@ export class HeapProfileView extends UI.View.SimpleView implements UI.Searchable
       <tr data-uid=${node.callUID} ?selected=${this.#selectedNode === node} ?expanded=${node.expanded} @select=${onSelect}
           @contextmenu=${onContextMenu} @expand=${onExpand} @collapse=${onCollapse}>
         <td data-value=${node.self} class="numeric-column ${node.searchMatchedSelfColumn ? 'highlight' : ''}"
-            aria-label=${`${this.nodeFormatter.formatValueAccessibleText(node.self, node)}, ${this.nodeFormatter.formatPercent(node.selfPercent, node)}`}>
+            aria-label=${`${this.nodeFormatter.formatValueAccessibleText(node.self)}, ${this.nodeFormatter.formatPercent(node.selfPercent, node)}`}>
           <div class="profile-multiple-values">
-            <span>${this.nodeFormatter.formatValue(node.self, node)}</span>
+            <span>${this.nodeFormatter.formatValue(node.self)}</span>
             <span class="percent-column">${this.nodeFormatter.formatPercent(node.selfPercent, node)}</span>
           </div>
         </td>
         <td data-value=${node.total} class="numeric-column ${node.searchMatchedTotalColumn ? 'highlight' : ''}"
-            aria-label=${`${this.nodeFormatter.formatValueAccessibleText(node.total, node)}, ${this.nodeFormatter.formatPercent(node.totalPercent, node)}`}>
+            aria-label=${`${this.nodeFormatter.formatValueAccessibleText(node.total)}, ${this.nodeFormatter.formatPercent(node.totalPercent, node)}`}>
           <div class="profile-multiple-values">
-            <span>${this.nodeFormatter.formatValue(node.total, node)}</span>
+            <span>${this.nodeFormatter.formatValue(node.total)}</span>
             <span class="percent-column">${this.nodeFormatter.formatPercent(node.totalPercent, node)}</span>
           </div>
         </td>
@@ -525,7 +525,7 @@ export class HeapProfileView extends UI.View.SimpleView implements UI.Searchable
     return this.profileInternal;
   }
 
-  initialize(nodeFormatter: Formatter): void {
+  initialize(nodeFormatter: NodeFormatter): void {
     this.nodeFormatter = nodeFormatter;
 
     this.viewType = Common.Settings.Settings.instance().createSetting('profile-view', ViewTypes.HEAVY);

package/front_end/panels/profiler/HeapSnapshotView.ts

@@ -277,7 +277,7 @@ const UIStrings = {
    * @description Text of a DOM element in Heap Snapshot View of a profiler tool
    */
   stackWasNotRecordedForThisObject:
-      'Stack wasn\'t recorded for this object because it had been allocated before this profile recording started.',
+      'Stack wasn’t recorded for this object because it had been allocated before this profile recording started.',
   /**
    * @description Text in Heap Snapshot View of a profiler tool.
    * This text is on a button to undo all previous "Ignore this retainer" actions.

package/front_end/panels/profiler/ProfileDataGrid.ts

@@ -590,16 +590,20 @@ export class ProfileDataGridTree implements UI.SearchableView.Searchable {
 
     this.searchResults = [];
     const deepSearch = this.deepSearch;
-    let current: DataGrid.DataGrid.DataGridNode<unknown>|null;
-    for (current = this.children[0]; current; current = current.traverseNextNode(!deepSearch, null, !deepSearch)) {
-      const item = (current as ProfileDataGridNode | null);
-      if (!item) {
-        break;
-      }
 
-      if (matchesQuery(item)) {
-        this.searchResults.push({profileNode: item});
+    const walk = (node: ProfileDataGridNode): void => {
+      if (matchesQuery(node)) {
+        this.searchResults.push({profileNode: node});
+      }
+      if (deepSearch || node.expanded) {
+        for (const child of node.children as ProfileDataGridNode[]) {
+          walk(child);
+        }
       }
+    };
+
+    for (const child of this.children as ProfileDataGridNode[]) {
+      walk(child);
     }
     this.searchResultIndex = jumpBackwards ? 0 : this.searchResults.length - 1;
     this.searchableView.updateSearchMatchesCount(this.searchResults.length);

package/front_end/panels/protocol_monitor/ProtocolMonitor.ts

@@ -9,8 +9,8 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as ProtocolClient from '../../core/protocol_client/protocol_client.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as TextUtils from '../../core/text_utils/text_utils.js';
 import * as Bindings from '../../models/bindings/bindings.js';
-import * as TextUtils from '../../models/text_utils/text_utils.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as UIHelpers from '../../ui/helpers/helpers.js';