chrome-devtools-frontend 1.0.1661063 → 1.0.1662289

package/front_end/models/persistence/AutomaticFileSystemWorkspaceBinding.ts

@@ -6,7 +6,6 @@ import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import type * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
-import type * as SDK from '../../core/sdk/sdk.js';
 import type {ContentDataOrError} from '../text_utils/ContentData.js';
 import type {SearchMatch} from '../text_utils/ContentProvider.js';
 import * as Workspace from '../workspace/workspace.js';
@@ -169,10 +168,6 @@ export class FileSystem implements Workspace.Workspace.Project {
   uiSourceCodes(): Iterable<Workspace.UISourceCode.UISourceCode> {
     return [];
   }
-
-  target(): SDK.Target.Target|null {
-    return null;
-  }
 }
 
 /**

package/front_end/models/source_map_scopes/FunctionCodeResolver.ts

@@ -226,7 +226,7 @@ export async function getFunctionCodeFromLocation(
   const debuggerWorkspaceBinding = Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance();
   const projects = debuggerWorkspaceBinding.workspace.projectsForType(Workspace.Workspace.projectTypes.Network);
   for (const project of projects) {
-    if (project.target() !== target) {
+    if (Bindings.NetworkProject.NetworkProject.getTargetForProject(project) !== target) {
       continue;
     }
     uiSourceCode = project.uiSourceCodeForURL(url);

package/front_end/models/trace/handlers/FramesHandler.ts

@@ -6,7 +6,6 @@ import * as Platform from '../../../core/platform/platform.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 
-import {type AuctionWorkletsData, data as auctionWorkletsData} from './AuctionWorkletsHandler.js';
 import {data as layerTreeHandlerData, type LayerTreeData} from './LayerTreeHandler.js';
 import {data as metaHandlerData, type MetaHandlerData} from './MetaHandler.js';
 import {data as rendererHandlerData, type RendererHandlerData} from './RendererHandler.js';
@@ -81,7 +80,6 @@ export async function finalize(): Promise<void> {
   const modelForTrace = new TimelineFrameModel(
       relevantFrameEvents,
       rendererHandlerData(),
-      auctionWorkletsData(),
       metaHandlerData(),
       layerTreeHandlerData(),
   );
@@ -101,7 +99,7 @@ export function data(): FramesData {
 }
 
 export function deps(): HandlerName[] {
-  return ['Meta', 'Renderer', 'AuctionWorklets', 'LayerTree'];
+  return ['Meta', 'Renderer', 'LayerTree'];
 }
 
 export class TimelineFrameModel {
@@ -122,13 +120,12 @@ export class TimelineFrameModel {
   #activeThreadId: Types.Events.ThreadID|null = null;
   #layerTreeData: LayerTreeData;
 
-  constructor(
-      allEvents: readonly Types.Events.Event[], rendererData: RendererHandlerData,
-      auctionWorkletsData: AuctionWorkletsData, metaData: MetaHandlerData, layerTreeData: LayerTreeData) {
+  constructor(allEvents: readonly Types.Events.Event[], rendererData: RendererHandlerData, metaData: MetaHandlerData,
+              layerTreeData: LayerTreeData) {
     // We only care about getting threads from the Renderer, not Samples,
     // because Frames don't exist in a CPU Profile (which won't have Renderer
     // threads.)
-    const mainThreads = Threads.threadsInRenderer(rendererData, auctionWorkletsData).filter(thread => {
+    const mainThreads = Threads.threadsInRenderer(rendererData).filter(thread => {
       return thread.type === Threads.ThreadType.MAIN_THREAD && thread.processIsOnMainFrame;
     });
     const threadData = mainThreads.map(thread => {

package/front_end/models/trace/handlers/ModelHandlers.ts

@@ -5,7 +5,6 @@
 export * as AnimationFrames from './AnimationFramesHandler.js';
 export * as Animations from './AnimationHandler.js';
 export * as AsyncJSCalls from './AsyncJSCallsHandler.js';
-export * as AuctionWorklets from './AuctionWorkletsHandler.js';
 export * as DOMStats from './DOMStatsHandler.js';
 export * as ExtensionTraceData from './ExtensionTraceDataHandler.js';
 export * as Flows from './FlowsHandler.js';

package/front_end/models/trace/handlers/RendererHandler.ts

@@ -6,7 +6,6 @@ import * as Platform from '../../../core/platform/platform.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 
-import {data as auctionWorkletsData} from './AuctionWorkletsHandler.js';
 import * as HandlerHelpers from './helpers.js';
 import {data as metaHandlerData, type FrameProcessData} from './MetaHandler.js';
 import {data as networkRequestHandlerData} from './NetworkRequestsHandler.js';
@@ -248,7 +247,6 @@ export function assignThreadName(
  *  - Deletes processes with an unknown origin.
  */
 export function sanitizeProcesses(processes: Map<Types.Events.ProcessID, RendererProcess>): void {
-  const auctionWorklets = auctionWorkletsData().worklets;
   const metaData = metaHandlerData();
   if (metaData.traceIsGeneric) {
     return;
@@ -258,19 +256,8 @@ export function sanitizeProcesses(processes: Map<Types.Events.ProcessID, Rendere
     // parsed for some reason, or if it's an "about:" origin, delete it.
     // This is done because we don't really care about processes for which we
     // can't provide actionable insights to the user (e.g. about:blank pages).
-    //
-    // There is one exception; AuctionWorklet processes get parsed in a
-    // separate handler, so at this point we check to see if the process has
-    // been found by the AuctionWorkletsHandler, and if so we update the URL.
-    // This ensures that we keep this process around and do not drop it due to
-    // the lack of a URL.
     if (process.url === null) {
-      const maybeWorklet = auctionWorklets.get(pid);
-      if (maybeWorklet) {
-        process.url = maybeWorklet.host;
-      } else {
-        processes.delete(pid);
-      }
+      processes.delete(pid);
       continue;
     }
   }
@@ -392,7 +379,7 @@ export function makeCompleteEvent(event: Types.Events.Begin|Types.Events.End): T
 }
 
 export function deps(): HandlerName[] {
-  return ['Meta', 'Samples', 'AuctionWorklets', 'NetworkRequests'];
+  return ['Meta', 'Samples', 'NetworkRequests'];
 }
 
 export interface RendererHandlerData {

package/front_end/models/trace/handlers/Threads.ts

@@ -5,7 +5,6 @@
 import type * as Helpers from '../helpers/helpers.js';
 import type * as Types from '../types/types.js';
 
-import type {AuctionWorkletsData} from './AuctionWorkletsHandler.js';
 import type * as Renderer from './RendererHandler.js';
 import type {HandlerData} from './types.js';
 
@@ -24,15 +23,12 @@ export const enum ThreadType {
   MAIN_THREAD = 'MAIN_THREAD',
   WORKER = 'WORKER',
   RASTERIZER = 'RASTERIZER',
-  AUCTION_WORKLET = 'AUCTION_WORKLET',
   OTHER = 'OTHER',
   CPU_PROFILE = 'CPU_PROFILE',
   THREAD_POOL = 'THREAD_POOL',
 }
 
-function getThreadTypeForRendererThread(
-    pid: Types.Events.ProcessID, thread: Renderer.RendererThread,
-    auctionWorkletsData: AuctionWorkletsData): ThreadType {
+function getThreadTypeForRendererThread(pid: Types.Events.ProcessID, thread: Renderer.RendererThread): ThreadType {
   let threadType = ThreadType.OTHER;
   if (thread.name === 'CrRendererMain') {
     threadType = ThreadType.MAIN_THREAD;
@@ -40,8 +36,6 @@ function getThreadTypeForRendererThread(
     threadType = ThreadType.WORKER;
   } else if (thread.name?.startsWith('CompositorTileWorker')) {
     threadType = ThreadType.RASTERIZER;
-  } else if (auctionWorkletsData.worklets.has(pid)) {
-    threadType = ThreadType.AUCTION_WORKLET;
   } else if (thread.name?.startsWith('ThreadPool')) {
     // TODO(paulirish): perhaps exclude ThreadPoolServiceThread entirely
     threadType = ThreadType.THREAD_POOL;
@@ -49,8 +43,7 @@ function getThreadTypeForRendererThread(
   return threadType;
 }
 
-export function threadsInRenderer(
-    rendererData: Renderer.RendererHandlerData, auctionWorkletsData: AuctionWorkletsData): readonly ThreadData[] {
+export function threadsInRenderer(rendererData: Renderer.RendererHandlerData): readonly ThreadData[] {
   const foundThreads: ThreadData[] = [];
   // If we have Renderer threads, we prefer to use those. In the event that a
   // trace is a CPU Profile trace, we will never have Renderer threads, so we
@@ -65,7 +58,7 @@ export function threadsInRenderer(
           // filtering we need.
           continue;
         }
-        const threadType = getThreadTypeForRendererThread(pid, thread, auctionWorkletsData);
+        const threadType = getThreadTypeForRendererThread(pid, thread);
         foundThreads.push({
           name: thread.name,
           pid,
@@ -99,7 +92,7 @@ export function threadsInTrace(handlerData: HandlerData): readonly ThreadData[]
   }
 
   // If we have Renderer threads, we prefer to use those.
-  const threadsFromRenderer = threadsInRenderer(handlerData.Renderer, handlerData.AuctionWorklets);
+  const threadsFromRenderer = threadsInRenderer(handlerData.Renderer);
   if (threadsFromRenderer.length) {
     threadsInHandlerDataCache.set(handlerData, threadsFromRenderer);
     return threadsFromRenderer;

package/front_end/models/trace/insights/DOMSize.ts

@@ -117,7 +117,7 @@ export function generateInsight(data: Handlers.Types.HandlerData, context: Insig
   const largeLayoutUpdates: Types.Events.Layout[] = [];
   const largeStyleRecalcs: Types.Events.RecalcStyle[] = [];
 
-  const threads = Handlers.Threads.threadsInRenderer(data.Renderer, data.AuctionWorklets);
+  const threads = Handlers.Threads.threadsInRenderer(data.Renderer);
   for (const thread of threads) {
     if (thread.type !== Handlers.Threads.ThreadType.MAIN_THREAD) {
       continue;

package/front_end/models/workspace/WorkspaceImpl.ts

@@ -5,7 +5,6 @@
 import * as Common from '../../core/common/common.js';
 import type * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
-import type * as SDK from '../../core/sdk/sdk.js';
 import type * as TextUtils from '../text_utils/text_utils.js';
 
 import type {SearchConfig} from './SearchConfig.js';
@@ -55,7 +54,6 @@ export interface Project {
    * @returns an iterator for the sources provided by this project.
    */
   uiSourceCodes(): Iterable<UISourceCode>;
-  target(): SDK.Target.Target|null;
 }
 
 /* eslint-disable @typescript-eslint/naming-convention -- Used by web_tests. */
@@ -76,15 +74,12 @@ export abstract class ProjectStore implements Project {
   readonly #type: projectTypes;
   readonly #displayName: string;
   readonly #uiSourceCodes = new Map<Platform.DevToolsPath.UrlString, UISourceCode>();
-  readonly #target: SDK.Target.Target|null = null;
 
-  constructor(workspace: WorkspaceImpl, id: string, type: projectTypes, displayName: string,
-              target: SDK.Target.Target|null = null) {
+  constructor(workspace: WorkspaceImpl, id: string, type: projectTypes, displayName: string) {
     this.#workspace = workspace;
     this.#id = id;
     this.#type = type;
     this.#displayName = displayName;
-    this.#target = target;
   }
 
   id(): string {
@@ -140,10 +135,6 @@ export abstract class ProjectStore implements Project {
     return this.#uiSourceCodes.values();
   }
 
-  target(): SDK.Target.Target|null {
-    return this.#target;
-  }
-
   renameUISourceCode(uiSourceCode: UISourceCode, newName: string): void {
     const oldPath = uiSourceCode.url();
     const newPath = uiSourceCode.parentURL() ?

package/front_end/panels/application/ApplicationPanelSidebar.ts

@@ -70,8 +70,6 @@ import {
   type ObjectStore,
 } from './IndexedDBModel.js';
 import {IDBDatabaseView, IDBDataView} from './IndexedDBViews.js';
-import {Events as InterestGroupModelEvents, InterestGroupStorageModel} from './InterestGroupStorageModel.js';
-import {InterestGroupTreeElement} from './InterestGroupTreeElement.js';
 import {OpenedWindowDetailsView, WorkerDetailsView} from './OpenedWindowDetailsView.js';
 import type * as PreloadingHelper from './preloading/helper/helper.js';
 import {
@@ -347,7 +345,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
   sessionStorageListTreeElement: ExpandableApplicationPanelTreeElement;
   extensionStorageListTreeElement: ExpandableApplicationPanelTreeElement;
   indexedDBListTreeElement: IndexedDBTreeElement;
-  interestGroupTreeElement: InterestGroupTreeElement;
   cookieListTreeElement: ExpandableApplicationPanelTreeElement;
   trustTokensTreeElement: TrustTokensTreeElement;
   cacheStorageListTreeElement: ServiceWorkerCacheTreeElement;
@@ -484,9 +481,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
     this.trustTokensTreeElement = new TrustTokensTreeElement(panel);
     storageTreeElement.appendChild(this.trustTokensTreeElement);
 
-    this.interestGroupTreeElement = new InterestGroupTreeElement(panel);
-    storageTreeElement.appendChild(this.interestGroupTreeElement);
-
     this.sharedStorageListTreeElement = new SharedStorageListTreeElement(panel);
     storageTreeElement.appendChild(this.sharedStorageListTreeElement);
 
@@ -582,12 +576,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
           modelRemoved: (model: IndexedDBModel) => this.indexedDBModelRemoved(model),
         },
         {scoped: true});
-    SDK.TargetManager.TargetManager.instance().observeModels(
-        InterestGroupStorageModel, {
-          modelAdded: (model: InterestGroupStorageModel) => this.interestGroupModelAdded(model),
-          modelRemoved: (model: InterestGroupStorageModel) => this.interestGroupModelRemoved(model),
-        },
-        {scoped: true});
     SDK.TargetManager.TargetManager.instance().observeModels(
         SharedStorageModel, {
           modelAdded: (model: SharedStorageModel) => this.sharedStorageModelAdded(model).catch(err => {
@@ -627,12 +615,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
 
     this.target = target;
 
-    const interestGroupModel = target.model(InterestGroupStorageModel);
-    if (interestGroupModel) {
-      interestGroupModel.addEventListener(
-          InterestGroupModelEvents.INTEREST_GROUP_ACCESS, this.interestGroupAccess, this);
-    }
-
     const resourceTreeModel = target.model(SDK.ResourceTreeModel.ResourceTreeModel);
     if (!resourceTreeModel) {
       return;
@@ -660,12 +642,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
           SDK.ResourceTreeModel.Events.WillLoadCachedResources, this.resetWithFrames, this);
     }
 
-    const interestGroupModel = target.model(InterestGroupStorageModel);
-    if (interestGroupModel) {
-      interestGroupModel.removeEventListener(
-          InterestGroupModelEvents.INTEREST_GROUP_ACCESS, this.interestGroupAccess, this);
-    }
-
     this.resetWithFrames();
   }
 
@@ -678,10 +654,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
                                                                        SDK.TargetManager.TargetManager.instance())) {
       this.addCookieDocument(frame);
     }
-    const interestGroupModel = this.target?.model(InterestGroupStorageModel);
-    if (interestGroupModel) {
-      interestGroupModel.enable();
-    }
 
     this.cacheStorageListTreeElement.initialize();
     const backgroundServiceModel = this.target?.model(BackgroundServiceModel) || null;
@@ -738,16 +710,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
     this.indexedDBListTreeElement.removeIndexedDBForModel(model);
   }
 
-  private interestGroupModelAdded(model: InterestGroupStorageModel): void {
-    model.enable();
-    model.addEventListener(InterestGroupModelEvents.INTEREST_GROUP_ACCESS, this.interestGroupAccess, this);
-  }
-
-  private interestGroupModelRemoved(model: InterestGroupStorageModel): void {
-    model.disable();
-    model.removeEventListener(InterestGroupModelEvents.INTEREST_GROUP_ACCESS, this.interestGroupAccess, this);
-  }
-
   private async sharedStorageModelAdded(model: SharedStorageModel): Promise<void> {
     await model.enable();
     for (const storage of model.storages()) {
@@ -817,7 +779,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
   private reset(): void {
     this.domains = {};
     this.cookieListTreeElement.removeChildren();
-    this.interestGroupTreeElement.clearEvents();
     this.deviceBoundSessionsModel?.clearVisibleSites();
     this.deviceBoundSessionsModel?.clearEvents();
   }
@@ -831,11 +792,6 @@ export class ApplicationPanelSidebar extends UI.Widget.VBox implements SDK.Targe
     this.addCookieDocument(frame);
   }
 
-  private interestGroupAccess(event: Common.EventTarget.EventTargetEvent<Protocol.Storage.InterestGroupAccessedEvent>):
-      void {
-    this.interestGroupTreeElement.addEvent(event.data);
-  }
-
   private addCookieDocument(frame: SDK.ResourceTreeModel.ResourceTreeFrame): void {
     // In case the current frame was unreachable, show its cookies
     // instead of the error interstitials because they might help to

package/front_end/panels/application/CookieItemsView.ts

@@ -402,7 +402,7 @@ export class CookieItemsView extends UI.Widget.VBox {
         return true;
       }
       if (object instanceof SDK.Cookie.Cookie) {
-        return IssuesManager.RelatedIssue.hasIssues(object);
+        return IssuesManager.RelatedIssue.hasIssues(object, IssuesManager.IssuesManager.IssuesManager.instance());
       }
       return false;
     };

package/front_end/panels/application/FrameDetailsView.ts

@@ -932,7 +932,7 @@ export class FrameDetailsReportView extends UI.Widget.Widget {
 
   #uiSourceCodeForFrame(frame: SDK.ResourceTreeModel.ResourceTreeFrame): Workspace.UISourceCode.UISourceCode|null {
     for (const project of Workspace.Workspace.WorkspaceImpl.instance().projects()) {
-      const projectTarget = project.target();
+      const projectTarget = Bindings.NetworkProject.NetworkProject.getTargetForProject(project);
       if (projectTarget && projectTarget === frame.resourceTreeModel().target()) {
         const uiSourceCode = project.uiSourceCodeForURL(frame.url);
         if (uiSourceCode) {