chrome-devtools-frontend 1.0.1657855 → 1.0.1661063

package/front_end/models/ai_assistance/AiHistoryStorage.ts

@@ -21,7 +21,6 @@ export interface SerializedConversation {
   id: string;
   type: ConversationType;
   history: SerializedResponseData[];
-  isExternal: boolean;
 }
 
 export interface SerializedImage {
@@ -38,6 +37,7 @@ let instance: AiHistoryStorage|null = null;
 
 const DEFAULT_MAX_STORAGE_SIZE = 50 * 1024 * 1024;
 export const MAX_RECENT_PROMPTS_COUNT = 20;
+export const MAX_CONVERSATIONS_COUNT = 50;
 export const RECENT_PROMPTS_SIZE_LIMIT = 100 * 1024;
 
 export const enum Events {
@@ -105,6 +105,15 @@ export class AiHistoryStorage extends Common.ObjectWrapper.ObjectWrapper<EventTy
     return structuredClone(this.#recentPromptsSetting.get());
   }
 
+  #getImageIdsFromHistory(history: SerializedResponseData[]): string[] {
+    return history.flatMap(item => {
+      if (item.type === ResponseType.USER_QUERY && item.imageId) {
+        return [item.imageId];
+      }
+      return [];
+    });
+  }
+
   async upsertHistoryEntry(agentEntry: SerializedConversation): Promise<void> {
     const release = await this.#mutex.acquire();
     try {
@@ -115,6 +124,24 @@ export class AiHistoryStorage extends Common.ObjectWrapper.ObjectWrapper<EventTy
       } else {
         history.push(agentEntry);
       }
+
+      // Using a while loop to ensure that if the history size exceeds the maximum limit
+      // (e.g. if the limit was reduced or settings contain legacy entries), we prune
+      // all extra entries at once. We also collect and batch image deletion to avoid
+      // multiple settings writes.
+      const imageIdsForDeletion: string[] = [];
+      while (history.length > MAX_CONVERSATIONS_COUNT) {
+        const evicted = history.shift();
+        if (evicted) {
+          imageIdsForDeletion.push(...this.#getImageIdsFromHistory(evicted.history));
+        }
+      }
+
+      if (imageIdsForDeletion.length > 0) {
+        const images = structuredClone(await this.#imageHistorySettings.forceGet());
+        this.#imageHistorySettings.set(images.filter(entry => !imageIdsForDeletion.includes(entry.id)));
+      }
+
       this.#historySetting.set(history);
     } finally {
       release();
@@ -157,22 +184,18 @@ export class AiHistoryStorage extends Common.ObjectWrapper.ObjectWrapper<EventTy
     const release = await this.#mutex.acquire();
     try {
       const history = structuredClone(await this.#historySetting.forceGet());
-      const imageIdsForDeletion = history.find(entry => entry.id === id)
-                                      ?.history
-                                      .map(item => {
-                                        if (item.type === ResponseType.USER_QUERY && item.imageId) {
-                                          return item.imageId;
-                                        }
-                                        return undefined;
-                                      })
-                                      .filter(item => !!item);
+      const conversation = history.find(entry => entry.id === id);
+      if (!conversation) {
+        return;
+      }
+      const imageIdsForDeletion = this.#getImageIdsFromHistory(conversation.history);
       this.#historySetting.set(
           history.filter(entry => entry.id !== id),
       );
-      const images = structuredClone(await this.#imageHistorySettings.forceGet());
-      this.#imageHistorySettings.set(
-          // Filter images for which ids are not present in deletion list
-          images.filter(entry => !Boolean(imageIdsForDeletion?.find(id => id === entry.id))));
+      if (imageIdsForDeletion.length > 0) {
+        const images = structuredClone(await this.#imageHistorySettings.forceGet());
+        this.#imageHistorySettings.set(images.filter(entry => !imageIdsForDeletion.includes(entry.id)));
+      }
     } finally {
       release();
     }

package/front_end/models/ai_assistance/AiUtils.ts

@@ -4,56 +4,52 @@
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
-import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 
 import {debugLog} from './debug.js';
 
-const UIStrings = {
-  /**
-   * @description Message shown to the user if the age check isn’t successful.
-   */
-  ageRestricted: 'This feature is only available to users 18 years or older.',
-  /**
-   * @description The error message when the user isn’t logged in to Chrome.
-   */
-  notLoggedIn: 'This feature is only available when you sign in to Chrome with your Google account.',
-  /**
-   * @description Message shown when the user is offline.
-   */
-  offline: 'This feature is only available with an active internet connection.',
-  /**
-   * @description Text informing the user that AI assistance isn’t available in Incognito mode or Guest mode.
-   */
-  notAvailableInIncognitoMode: 'AI assistance isn’t available in Incognito mode or Guest mode.',
-} as const;
-const str_ = i18n.i18n.registerUIStrings('models/ai_assistance/AiUtils.ts', UIStrings);
-const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
-
-export function getDisabledReasons(aidaAvailability: Host.AidaClient.AidaAccessPreconditions):
-    Platform.UIString.LocalizedString[] {
-  const reasons: Platform.UIString.LocalizedString[] = [];
+/**
+ * Preconditions determined entirely on the DevTools frontend side (e.g. Incognito
+ * mode or age restrictions) that prevent AI assistance features from running.
+ * These are evaluated independently of AIDA service-level availability.
+ */
+export const enum FrontendAccessPrecondition {
+  IS_OFF_THE_RECORD = 'is-off-the-record',
+  AGE_RESTRICTED = 'age-restricted',
+}
+
+/**
+ * The unified set of preconditions that can disable AI assistance.
+ * This is a union of low-level AIDA service availability preconditions
+ * and DevTools frontend-specific preconditions.
+ */
+export type AccessPrecondition =
+    Exclude<Host.AidaClient.AidaAccessPreconditions, Host.AidaClient.AidaAccessPreconditions.AVAILABLE>|
+    FrontendAccessPrecondition;
+
+/**
+ * Returns the list of active preconditions currently preventing AI assistance from being enabled.
+ * Checks local frontend constraints (e.g. incognito, age check) and combines them with the
+ * provided AIDA service availability status.
+ */
+export function getDisabledReasons(aidaAvailability: Host.AidaClient.AidaAccessPreconditions): AccessPrecondition[] {
+  const reasons: AccessPrecondition[] = [];
   if (Root.Runtime.hostConfig.isOffTheRecord) {
-    reasons.push(i18nString(UIStrings.notAvailableInIncognitoMode));
+    reasons.push(FrontendAccessPrecondition.IS_OFF_THE_RECORD);
   }
-  switch (aidaAvailability) {
-    case Host.AidaClient.AidaAccessPreconditions.NO_ACCOUNT_EMAIL:
-    case Host.AidaClient.AidaAccessPreconditions.SYNC_IS_PAUSED:
-      reasons.push(i18nString(UIStrings.notLoggedIn));
-      break;
-    // @ts-expect-error
-    case Host.AidaClient.AidaAccessPreconditions.NO_INTERNET:  // fallthrough
-      reasons.push(i18nString(UIStrings.offline));
-    case Host.AidaClient.AidaAccessPreconditions.AVAILABLE: {
-      // No age check if there is no logged in user. Age check would always fail in that case.
-      if (Root.Runtime.hostConfig?.aidaAvailability?.blockedByAge === true) {
-        reasons.push(i18nString(UIStrings.ageRestricted));
-      }
-    }
+
+  if (aidaAvailability !== Host.AidaClient.AidaAccessPreconditions.AVAILABLE) {
+    reasons.push(aidaAvailability);
+  }
+
+  // No age check if there is no logged in user. Age check would always fail in that case.
+  if ((aidaAvailability === Host.AidaClient.AidaAccessPreconditions.AVAILABLE ||
+       aidaAvailability === Host.AidaClient.AidaAccessPreconditions.NO_INTERNET) &&
+      Root.Runtime.hostConfig?.aidaAvailability?.blockedByAge === true) {
+    reasons.push(FrontendAccessPrecondition.AGE_RESTRICTED);
   }
-  // The `console-insights-enabled` setting and the `ai-assistance-enabled` setting both have the same `disabledReasons`.
-  reasons.push(...Common.Settings.Settings.instance().moduleSetting('ai-assistance-enabled').disabledReasons());
+
   return reasons;
 }
 

package/front_end/models/ai_assistance/agents/AiAgent.ts

@@ -36,7 +36,8 @@ export const enum ErrorType {
   ABORT = 'abort',
   MAX_STEPS = 'max-steps',
   BLOCK = 'block',
-  CROSS_ORIGIN = 'cross-origin'
+  CROSS_ORIGIN = 'cross-origin',
+  QUOTA = 'quota',
 }
 
 export const enum MultimodalInputType {
@@ -795,6 +796,9 @@ export abstract class AiAgent<T> {
           error = ErrorType.ABORT;
         } else if (err instanceof Host.AidaClient.AidaBlockError) {
           error = ErrorType.BLOCK;
+        } else if (err instanceof Host.AidaClient.AidaQuotaError ||
+                   (err instanceof Error && err.message.toLowerCase().includes('quota'))) {
+          error = ErrorType.QUOTA;
         }
         yield this.#createErrorResponse(error);
 

package/front_end/models/ai_assistance/agents/ContextSelectionAgent.ts

@@ -19,6 +19,7 @@ import {DOMNodeContext} from '../contexts/DOMNodeContext.js';
 import {FileContext} from '../contexts/FileContext.js';
 import {PerformanceTraceContext} from '../contexts/PerformanceTraceContext.js';
 import {getRequestContextOrigin, RequestContext} from '../contexts/RequestContext.js';
+import {formatBytesToKb, seconds} from '../data_formatters/UnitFormatters.js';
 import {debugLog} from '../debug.js';
 import {StorageItem} from '../StorageItem.js';
 
@@ -164,8 +165,8 @@ export class ContextSelectionAgent extends AiAgent<never> {
             id: request.requestId(),
             url: request.url(),
             statusCode: request.statusCode,
-            duration: i18n.TimeUtilities.secondsToString(request.duration),
-            transferSize: i18n.ByteUtilities.formatBytesToKb(request.transferSize),
+            duration: seconds(request.duration),
+            transferSize: formatBytesToKb(request.transferSize),
           });
           requestsToShow.push(request);
         }

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -1225,7 +1225,8 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
         if (script?.content !== undefined) {
           content = script.content;
         } else if (isFresh || isTraceApp) {
-          const resource = SDK.ResourceTreeModel.ResourceTreeModel.resourceForURL(url);
+          const resource =
+              SDK.ResourceTreeModel.ResourceTreeModel.resourceForURL(SDK.TargetManager.TargetManager.instance(), url);
           if (!resource) {
             return {error: 'Resource not found'};
           }

package/front_end/models/ai_assistance/agents/StorageAgent.ts

@@ -7,6 +7,7 @@ import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
+import {bytes} from '../data_formatters/UnitFormatters.js';
 import {CookieItem, DOMStorageItem, type StorageItem} from '../StorageItem.js';
 
 import {
@@ -204,7 +205,8 @@ export class StorageAgent extends AiAgent<StorageItem> {
         }
 
         const origins = new Set<string>();
-        for (const frame of SDK.ResourceTreeModel.ResourceTreeModel.frames()) {
+        for (const frame of SDK.ResourceTreeModel.ResourceTreeModel.frames(
+                 SDK.TargetManager.TargetManager.instance())) {
           if (!isSamePageOrigin(frame.resourceTreeModel().target().outermostTarget(), this.context)) {
             continue;
           }
@@ -565,13 +567,13 @@ export class StorageAgent extends AiAgent<StorageItem> {
                                    .sort((a, b) => b.usage - a.usage)
                                    .map(entry => ({
                                           storageType: entry.storageType as string,
-                                          usage: i18n.ByteUtilities.bytesToString(entry.usage),
+                                          usage: bytes(entry.usage),
                                         }));
 
         return {
           result: {
-            totalUsage: i18n.ByteUtilities.bytesToString(response.usage),
-            totalQuota: i18n.ByteUtilities.bytesToString(response.quota),
+            totalUsage: bytes(response.usage),
+            totalQuota: bytes(response.quota),
             usageBreakdown,
           },
         };
@@ -657,7 +659,7 @@ export async function getCookiesForDomain(
 
 export function findFrameForOrigin(
     context: ConversationContext<StorageItem>|undefined, origin: string): SDK.ResourceTreeModel.ResourceTreeFrame|null {
-  for (const frame of SDK.ResourceTreeModel.ResourceTreeModel.frames()) {
+  for (const frame of SDK.ResourceTreeModel.ResourceTreeModel.frames(SDK.TargetManager.TargetManager.instance())) {
     if (frame.securityOrigin === origin) {
       const target = frame.resourceTreeModel().target();
       if (isSamePageOrigin(target.outermostTarget(), context)) {