chrome-devtools-frontend 1.0.1656897 → 1.0.1657855

package/.agents/skills/devtools-ux-writing-refactor/SKILL.md

@@ -0,0 +1,125 @@
+---
+name: devtools-ux-writing-refactor
+description: >-
+  Refactor user-facing UIStrings and localization comments in a DevTools module folder according to UX writing guidelines (child task of b/40799900). Use when simplifying wording, checking sentence case, or improving L10n comments in UIStrings for a specific folder or issue. Don’t use for general code changes or non-UIStrings files.
+---
+
+# DevTools UX writing refactoring workflow
+
+Use this skill when addressing a single UX writing refactoring task (one module folder or child issue under tracking bug [b/40799900](https://crbug.com/40799900)).
+
+## 0. Environment setup (avoid PATH errors)
+
+In DevTools Linux workspaces, `depot_tools` and `node`/`npm` may not be in `PATH` in non-interactive agent shells. Before you run Git, `gclient`, `npm`, or `git cl` commands, ensure that your environment is set up:
+```bash
+export PATH=$HOME/depot_tools:$PATH
+source ~/.nvm/nvm.sh  # Or export PATH=$(pwd)/third_party/node/linux/node-linux-x64/bin:$PATH
+```
+
+## 1. Pre-flight issue check and target scope
+
+Before you write code or modify files, check the status of the associated Buganizer issue:
+```bash
+$ISSUES render <issue_number>  # Or use buganizer MCP tools: render_issue / render_issue_with_external
+```
+* **Why?** Multiple developers and agents work on child tasks under `b/40799900`.
+* **Action required:** If the issue is marked as `FIXED`, `VERIFIED`, or `CLOSED`, is assigned to another active developer, or has an attached Change List (CL), **stop immediately and verify whether you need to address it**. Ask the user for confirmation before you override existing work.
+* **Identify target files:** If `render_issue` returns an external redaction notice, use `render_issue_with_external` to view the full bug description. The bug description typically lists the exact **Target Files** to refactor for this child task. Focus exclusively on those target files.
+
+## 2. Create a branch
+
+Create a branch dedicated to this issue from the latest `origin/main` (after you run `gclient sync`) using the DevTools version control tool:
+```bash
+git fetch origin
+git checkout origin/main
+gclient sync
+git new-branch fix-<issue_number>
+```
+* **Why?** In Chrome DevTools, don’t use standard Git commands such as `git checkout -b` or `git switch -c`. Always use `git new-branch` so that `depot_tools` and Gerrit configure tracking information correctly.
+* **Naming:** Always include the issue number in the branch name (for example, `fix-531625399`).
+
+## 3. Refactor UIStrings and localization comments
+
+Locate all TypeScript files in the target folder that define `const UIStrings = { ... }` and apply the **8-point UX writing checklist** (cross-check with official DevTools documentation at https://developer.chrome.com/docs/devtools).
+
+> [!IMPORTANT]
+> **Ignore non-localized or experimental strings:** Don’t modify strings in `const UIStringsNotTranslate = { ... }`, `lockedString`, or `i18n.i18n.lockedString`. These strings are for early-stage or experimental features that you mustn’t localize or alter during UX refactoring.
+
+### The 8-point checklist
+1. **Brevity and short synonyms:** Replace formal or lengthy words:
+   * `preserve` -> `keep` | `additional` -> `more` | `prevent` -> `stop` | `receive` -> `get`
+   * `submit` -> `send` | `modification` -> `change` | `create` -> `add` | `suitable` -> `fit`
+   * *Check sibling references:* If you change a setting name or label (for example, changing “Preserve log” to “Keep log”), search sibling files in the folder for explanatory text or status strings that reference the old name in quotes (for example, “console.clear() was prevented due to ‘Preserve log’”), and update them to match.
+2. **Cut unnecessary words:** Eliminate politeness (`please`, `sorry`), filler (`very`, `strongly`, `there is` or `there are`), and marketing fluff (`seamless`, `awesome`, `fast`, `quick`).
+3. **Contractions:** Use contractions (`don’t`, `can’t`, `isn’t`, `won’t`) instead of formal spellings (`do not`, `cannot`, `is not`, `will not`).
+4. **Curly apostrophes, quotation marks, and ellipses:** Use curly apostrophes (`’`) and quotation marks (`“ ”`) for improved readability. Use the ellipsis character (`…`) instead of three periods (`...`). Use prime (`′`) and double prime (`″`) symbols as needed for measurements like length or coordinates.
+5. **Sentence case and capitalization:** Use sentence case for headings, labels, and UI element names. Capitalize only the first word, proper nouns, product names (`Chrome DevTools`), and web APIs (`Background Fetch API`).
+   * Don’t capitalize feature names (for example, `conditional breakpoint` or `command menu`).
+   * Capitalize panel names and UX elements that are named after panels (for example, `Show Application`, `Toggle Console`, `Console sidebar`, or `Styles`).
+   * For panel names that consist of two words, capitalize only the first word (for example, `Developer resources panel`).
+   * When you use the panel name in combination with another word, capitalize the panel name but not the other word, unless it is a proper noun (for example, `Console view` or `DevTools Console`).
+   * In some cases, ambiguity exists whether a word refers to a UX element in DevTools (such as a panel name) or a concept (such as developer terminology). For example, this occurs with `console`, `issue`, or `network`. Decide based on the surrounding context and code (for example, `Console view`, `Console sidebar`, and `Console prompt` versus `console message`, `console warning`, `console log`, `copy console`, `clear console`, and `console history`; `Show Network` versus `network log` and `network filter`).
+6. **Punctuation and actionability:** Remove trailing periods from single-sentence labels or titles. Ensure that error messages instruct the user how to recover (for example, `Shorten filename to 64 characters or less` instead of `Invalid filename`). Ensure that ARIA labels and multi-sentence tooltips have consistent terminal punctuation.
+7. **Terminology (glossary):** Strictly follow standard DevTools UI terminology and letter casing (`panel`, `tab`, `drawer`, `sidebar`, `datagrid` or `table`, `action bar`, `status bar`, and `live expressions section`). Never use `pane` or call tabs `panes` in UI strings or localization (L10n) comments.
+8. **Localization (L10n) comments:** Ensure that every string in `UIStrings` has a preceding `@description` comment that explains where and when it appears. This information is used for translators who need to understand the context in which the string is used.
+   * Use precise terminology and correct letter casing (see rule 7). Ensure that the description is easy to understand and provides enough context for translators. For descriptions that are underspecified or
+   ambiguous, figure out the context by looking at the use site of the
+   string and come up with a better description.
+   * You must explicitly document all standard placeholders (`{PH1}`, `{url}`, `{index}`) with runtime data examples (for example, `@example {https://example.com} url`).
+   * *ICU plural variables:* The i18n tool automatically parses variables in ICU plural format (such as `n` in `{n, plural, =0 {No issues} ...}`) as numeric counts, so they don’t require an `@example` tag in the `@description` comment.
+   * *Terminal punctuation:* Every `@description` comment must end with a period (`.`), even if it is a single phrase or sentence.
+
+## 4. Chrome writing style guide
+
+Also consult the style guides at `google3/experimental/users/rachelandrew/tools/chrome_writing/knowledge/style/` for applicable guidelines.
+
+## 5. Pause for confirmation
+
+Ask the user for a preliminary review of the proposed changes before proceeding. If the user has feedback, address feedback and pause again for confirmation.
+
+## 6. Mandatory verification and testing
+
+Don’t finish an edit without running the linter and test suite. In DevTools, i18n placeholder changes or string edits can easily break tests or linter rules.
+
+1. **Update sibling unit tests**
+   Unit test files (`*.test.ts`) alongside the implementation often assert exact UIString values (such as error messages or warnings). When you refactor a string, check sibling `*.test.ts` files for assertions that match the old string value, and update them to prevent test failures.
+2. **Run the linter and auto-fix errors**
+   ```bash
+   npm run lint -- <folder_path>
+   ```
+3. **Run unit tests**
+   Run unit tests for the target folder first for fast feedback. Then, run the full test suite to verify that no cross-module regressions or snapshot failures occurred:
+   ```bash
+   npm run test -- <folder_path>
+   npm run test
+   ```
+4. **Run presubmit checks**
+   Ensure that you commit or stage all changes before you run presubmit checks:
+   ```bash
+   git cl presubmit -u
+   ```
+
+## 7. Summarize changes and upload the CL
+
+When all tests and presubmit checks pass, commit your changes and upload the CL to Gerrit. Don’t use `[uxw]` as a prefix.
+
+1. **Stage and commit changes**
+   ```bash
+   git add <modified_files>
+   git commit -m "Ensure consistent UI Strings in <folder_path>"
+   ```
+   *(If you update an existing commit on this branch, use `git commit --amend`).*
+
+2. **Upload the CL to Gerrit**
+   Upload the CL using `git cl upload`. Provide a dynamic summary of changes (depending on the actual content of the change) and the bug trailer:
+   ```bash
+   git cl upload -d --commit-description="Ensure consistent UI Strings in <folder_path>
+
+   Summary of changes:
+   - <dynamically list specific words replaced, contractions adopted, or sentence case fixes>
+
+   Fixed: <issue_number>"
+   ```
+   * **Formatting rules:**
+     * Keep line length below 72 characters.
+     * Include `Fixed: <issue_number>` on a separate line at the bottom of the description so that automation closes the issue.

package/.agents/skills/repro-flaky-tests/SKILL.md

@@ -0,0 +1,53 @@
+---
+name: repro-flaky-test
+description: Reproduce and investigate flakiness in a test.
+---
+
+# Fixing flaky Tests
+
+This skill outlines the workflow for reproducing and fixing a flaky test in the DevTools codebase.
+
+## Workflow
+
+- You will be given as input, either a Chromium bug link (e.g. `crbug.com/1234567`), or a name of a test file and (optionally) the test name.
+- For example: e2e/extensions/debugger-language-plugins.test.ts and "The Debugger Language Plugins/shows sensible error messages".
+- If nothing is provided, as the user which test you should run.
+- Find the test in the codebase and look at its implementation.
+- Run the test three times to note how long the test runs (on average) per minute.
+
+## Reproduction
+
+- Run the test enough times for a full test run to take one minute. For example, if a test takes a second to run, set it to repeat 60 times. If a test takes 5 seconds to run, run it 12 times.
+- Start with one minute and, if the failure does not repeat, try again and increase the time by a minute (up to a maximum of 5 minutes per run).
+- Use `npm run test -- path/to/foo.test.ts --grep "<test name>" --repeat <count>` to run the tests repeatedly.
+- Be sure to keep track of the cumulative count of how often you run the test and how often they fail, so that you can calculate a 'flaky percentage' before and after making a fix.
+
+After every round, display the *cumulative* results in a table:
+
+```
+Test:                                                 Runs  Time   Failures
+"Recorder/should be able to start a replay..."         30    60s   0 (0.00%)
+"The Debugger Language Plugins/shows sensible..."      60    60s   1 (1.67%)
+```
+
+Once you have one or more failures, show the error message and ask the user if they want to:
+
+1) Start investigating the test failures.
+2) Continue running all the tests.
+3) Run only the failed tests (to get a clearer indication of their failure rate).
+4) Run only the tests that haven't failed (to attempt to get a reproduction).
+
+## Investigation
+
+- Create a branch flaky_tests and append a datestamp, such as _2026_07_04_14h16m.
+- Ensure you use the instructions from the `devtools-version-control` skill to create and switch branches appropriately.
+- Investigate each test failure and propose a fix.
+- Don't commit the changes to the branch.
+
+## Results
+
+- Before finishing, run the full verification process (TypeScript checks, and linters) as required by the repository best practices.
+- Request to run the test again for as long as you think it would take to be sure the problem is gone, but get permission from the user before starting very long runs (anything over 4 minutes).
+- For things that have a 33% failure rate before fixing (for example), only a handful of runs are needed to verify, but tests with lower failure rate need more.
+- NOTE: If the test fails again with the same error as before, you don't need to finish the test run but instead you should augment or replace your fix with a better one.
+- At the end, list the tests, state briefly why each test was failing and how the fix addresses the issue along with the failure rate before and after.

package/AUTHORS

@@ -24,6 +24,7 @@ Anna Agoha <annaagoha@gmail.com>
 Anthony Xie <anthonyxie64@gmail.com>
 Axel Chong <haxatron1@gmail.com>
 Anton Bershanskyi <bershanskyi@gmail.com>
+Aviv Keller <me@aviv.sh>
 Biboswan Roy <biboswan98@gmail.com>
 Boris Verkhovskiy <boris.verk@gmail.com>
 Carl Espe <carl@cpespe.com>
@@ -62,6 +63,7 @@ Juba Borgohain <chromiumjuba@gmail.com>
 Julian Geppert <spctstr@gmail.com>
 Junseo Yoo <joon.yoo181@berkeley.edu>
 Kanishk Ranjan <kanishkranjan17@gmail.com>
+Karim El Harim <karimelharim@gmail.com>
 Karntino Areros <karntino.c.areros@gmail.com>
 Kohei Ueno <kohei.ueno119@gmail.com>
 Krishnal Ciccolella <ciccolella.krishnal@gmail.com>

package/docs/get_the_code.md

@@ -53,10 +53,10 @@ a build time cost. If you want an even fast fast build, you might want to opt
 out of bundling by setting `devtools_bundle` to `false`
 
 ```bash
-gn gen out/fast-build --args="devtools_skip_typecheck=true devtools_bundle=false"
+gn gen out/Fast --args="devtools_skip_typecheck=true devtools_bundle=false"
 ```
 
-and use `npm run build -- -t fast-build` to build this target.
+and use `npm run build -- -t Fast` to build this target.
 
 ### Rebuilding automatically
 
@@ -111,10 +111,10 @@ The `.env.template` file lists all supported variables. Copy it to `.env` to get
 cp .env.template .env
 ```
 
-As mentioned earlier, you might create a fast build target. Instead of always typing `npm run build -- -t fast-build`, to remove the flag repetition you simple run `npm run build` you can set the following variable in your `.env` file:
+As mentioned earlier, you might create a fast build target. Instead of always typing `npm run build -- -t Fast`, to remove the flag repetition you simple run `npm run build` you can set the following variable in your `.env` file:
 
 ```shell
-DEVTOOLS_TARGET=fast-build
+DEVTOOLS_TARGET=Fast
 ```
 
 Another example - by default running `npm start` auto-opens DevTools for new Tabs.
@@ -468,8 +468,8 @@ In the `custom_deps` section, insert this line:
 "src/third_party/devtools-frontend/src": None,
 ```
 
-For the integrated checkout, create a single gclient project that automatically gclient sync's all dependencies for both
-repositories. After checking out chromium, modify the .gclient file for `chromium/src` to add the DevTools project:
+For the integrated checkout, create a single gclient project that automatically `gclient sync`s all dependencies for both
+repositories. After checking out chromium, modify the `.gclient` file for `chromium/src` to add the DevTools project:
 
 ```python
 solutions = [

package/front_end/Images/src/ads.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" height="20px" viewBox="0 -960 960 960" width="20px" fill="#000000"><path d="M288-384h48v-48h48v48h48v-168q0-10.2-6.9-17.1-6.9-6.9-17.1-6.9h-96q-10.2 0-17.1 6.9-6.9 6.9-6.9 17.1v168Zm48-96v-48h48v48h-48Zm192 96h96q20.4 0 34.2-13.8Q672-411.6 672-432v-96q0-20.4-13.8-34.2Q644.4-576 624-576h-96v192Zm48-48v-96h48v96h-48ZM168-192q-29.7 0-50.85-21.16Q96-234.32 96-264.04v-432.24Q96-726 117.15-747T168-768h624q29.7 0 50.85 21.16Q864-725.68 864-695.96v432.24Q864-234 842.85-213T792-192H168Zm0-72h624v-432H168v432Zm0 0v-432 432Z"/></svg>

package/front_end/Tests.js

@@ -761,7 +761,7 @@
       this.releaseControl();
     });
 
-    Common.Settings.moduleSetting('active-keybind-set').set('vsCode');
+    Common.Settings.Settings.instance().moduleSetting('active-keybind-set').set('vsCode');
   };
 
   TestSuite.prototype.testDispatchKeyEventDoesNotCrash = function() {

package/front_end/core/common/ResourceType.ts

@@ -38,7 +38,7 @@ import {ParsedURL} from './ParsedURL.js';
 
 const UIStrings = {
   /**
-   * @description Text that appears in a tooltip the fetch and xhr resource types filter.
+   * @description Text that appears in a tooltip for the Fetch and XHR resource types filter.
    */
   fetchAndXHR: '`Fetch` and `XHR`',
   /**
@@ -50,7 +50,7 @@ const UIStrings = {
    */
   js: 'JS',
   /**
-   * @description Text that appears on a button for the css resource type filter.
+   * @description Text that appears on a button for the CSS resource type filter.
    */
   css: 'CSS',
   /**
@@ -70,7 +70,7 @@ const UIStrings = {
    */
   doc: 'Doc',
   /**
-   * @description Text that appears on a button for the websocket, webtransport, directsocket resource type filter.
+   * @description Text that appears on a button for the WebSocket, WebTransport, and DirectSocket resource type filter.
    */
   socketShort: 'Socket',
   /**
@@ -86,67 +86,67 @@ const UIStrings = {
    */
   manifest: 'Manifest',
   /**
-   * @description Text for other types of items
+   * @description Text for other types of items.
    */
   other: 'Other',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   document: 'Document',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   stylesheet: 'Stylesheet',
   /**
-   * @description Text in Image View of the Sources panel
+   * @description Text in Image view of the Sources panel.
    */
   image: 'Image',
   /**
-   * @description Label for a group of JavaScript files
+   * @description Label for a group of JavaScript files.
    */
   script: 'Script',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   texttrack: 'TextTrack',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   fetch: 'Fetch',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   eventsource: 'EventSource',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   websocket: 'WebSocket',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   webtransport: 'WebTransport',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   directsocket: 'DirectSocket',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   signedexchange: 'SignedExchange',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   ping: 'Ping',
   /**
-   * @description Name of a network resource type
+   * @description Name of a network resource type.
    */
   cspviolationreport: 'CSPViolationReport',
   /**
-   * @description Name of a network initiator type
+   * @description Name of a network initiator type.
    */
   preflight: 'Preflight',
   /**
-   * @description Name of a network initiator type for FedCM requests
+   * @description Name of a network initiator type for FedCM requests.
    */
   fedcm: 'FedCM',
 } as const;

package/front_end/core/common/Revealer.ts

@@ -7,55 +7,55 @@ import type * as Platform from '../platform/platform.js';
 
 const UIStrings = {
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
   elementsPanel: 'Elements panel',
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
-  stylesSidebar: 'styles sidebar',
+  stylesSidebar: 'Styles sidebar',
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
   changesDrawer: 'Changes drawer',
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
   issuesView: 'Issues view',
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
   networkPanel: 'Network panel',
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
   requestConditionsDrawer: 'Request conditions drawer',
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
   applicationPanel: 'Application panel',
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
   sourcesPanel: 'Sources panel',
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
   timelinePanel: 'Performance panel',
   /**
-   * @description The UI destination when right clicking an item that can be revealed
+   * @description The UI destination when right-clicking an item that can be revealed.
    */
   memoryInspectorPanel: 'Memory inspector panel',
   /**
-   * @description The UI destination when revealing loaded resources through the Developer Resources Panel
+   * @description The UI destination when revealing loaded resources through the Developer resources panel.
    */
-  developerResourcesPanel: 'Developer Resources panel',
+  developerResourcesPanel: 'Developer resources panel',
   /**
-   * @description The UI destination when revealing loaded resources through the Animations panel
+   * @description The UI destination when revealing loaded resources through the Animations panel.
    */
   animationsPanel: 'Animations panel',
   /**
-   * @description The UI destination when revealing an item in the Lighthouse panel
+   * @description The UI destination when revealing an item in the Lighthouse panel.
    */
   lighthousePanel: 'Lighthouse panel',
 } as const;

package/front_end/core/common/SettingRegistration.ts

@@ -10,76 +10,76 @@ import type {SettingStorageType} from './Settings.js';
 
 const UIStrings = {
   /**
-   * @description Title of the Elements Panel
+   * @description Title of the Elements panel.
    */
   elements: 'Elements',
   /**
-   * @description Text for DevTools AI
+   * @description Text for DevTools AI.
    */
   ai: 'AI',
   /**
-   * @description Text for DevTools appearance
+   * @description Text for DevTools appearance.
    */
   appearance: 'Appearance',
   /**
-   * @description Name of the Sources panel
+   * @description Title of the Sources panel.
    */
   sources: 'Sources',
   /**
-   * @description Title of the Network tool
+   * @description Title of the Network panel.
    */
   network: 'Network',
   /**
-   * @description Text for the performance of something
+   * @description Title of the Performance panel.
    */
   performance: 'Performance',
   /**
-   * @description Title of the Console tool
+   * @description Title of the Console panel.
    */
   console: 'Console',
   /**
-   * @description A title of the 'Persistence' setting category
+   * @description Title of the Persistence setting category.
    */
   persistence: 'Persistence',
   /**
-   * @description Text that refers to the debugger
+   * @description Title of the Debugger setting category.
    */
   debugger: 'Debugger',
   /**
-   * @description Text describing global shortcuts and settings that are available throughout the DevTools
+   * @description Title of the Global setting category for shortcuts and settings available throughout DevTools.
    */
   global: 'Global',
   /**
-   * @description Title of the Rendering tool
+   * @description Title of the Rendering tool.
    */
   rendering: 'Rendering',
   /**
-   * @description Title of a section on CSS Grid tooling
+   * @description Title of the Grid setting category for CSS Grid tooling.
    */
   grid: 'Grid',
   /**
-   * @description Text for the mobile platform, as opposed to desktop
+   * @description Title of the Mobile setting category.
    */
   mobile: 'Mobile',
   /**
-   * @description Text for the memory of the page
+   * @description Title of the Memory panel setting category.
    */
   memory: 'Memory',
   /**
-   * @description Text for the extension of the page
+   * @description Title of the Extension setting category.
    */
   extension: 'Extension',
   /**
-   * @description Text for the adorner of the page
+   * @description Title of the Adorner setting category.
    */
   adorner: 'Adorner',
   /**
-   * @description Header for the "Account" section in the settings UI. The "Account"
-   * section allows users see their signed in account and configure which DevTools data is synced via Chrome Sync.
+   * @description Header for the Account section in the settings UI. The Account
+   * section allows users to see their signed-in account and configure which DevTools data is synced via Chrome Sync.
    */
   account: 'Account',
   /**
-   * @description Text for the privacy section of the page.
+   * @description Title of the Privacy setting category.
    */
   privacy: 'Privacy',
 } as const;

package/front_end/core/common/Settings.ts

@@ -715,14 +715,6 @@ export const enum SettingStorageType {
   SESSION = 'Session',
 }
 
-export function moduleSetting(settingName: string): Setting<unknown> {
-  return Settings.instance().moduleSetting(settingName);
-}
-
-export function settingForTest(settingName: string): Setting<unknown> {
-  return Settings.instance().settingForTest(settingName);
-}
-
 export {
   getLocalizedSettingsCategory,
   maybeRemoveSettingExtension,

package/front_end/core/host/Platform.ts

@@ -65,3 +65,7 @@ export function fontFamily(): string {
   }
   return _fontFamily;
 }
+
+export function setFontFamilyForTests(family: string): void {
+  _fontFamily = family;
+}