chrome-devtools-frontend 1.0.1656291 → 1.0.1657110

package/front_end/panels/emulation/DeviceModeToolbar.ts

@@ -506,22 +506,24 @@ export class DeviceModeToolbar extends UI.Widget.Widget {
 
     const device = this.model.device();
 
-    if (this.model.type() === EmulationModel.DeviceModeModel.Type.Device && device) {
-      this.lastMode.set(device, (this.model.mode() as EmulationModel.EmulatedDevices.Mode));
-    }
+    if (this.model.type() !== EmulationModel.DeviceModeModel.Type.None) {
+      if (this.model.type() === EmulationModel.DeviceModeModel.Type.Device && device) {
+        this.lastMode.set(device, (this.model.mode() as EmulationModel.EmulatedDevices.Mode));
+      }
 
-    const value = this.persistenceSetting.get();
-    const currentMode = this.model.mode();
-    if (device) {
-      value.device = device.title;
-      value.orientation = currentMode ? currentMode.orientation : '';
-      value.mode = currentMode ? currentMode.title : '';
-    } else {
-      value.device = '';
-      value.orientation = '';
-      value.mode = '';
+      const value = this.persistenceSetting.get();
+      const currentMode = this.model.mode();
+      if (device) {
+        value.device = device.title;
+        value.orientation = currentMode ? currentMode.orientation : '';
+        value.mode = currentMode ? currentMode.title : '';
+      } else {
+        value.device = '';
+        value.orientation = '';
+        value.mode = '';
+      }
+      this.persistenceSetting.set(value);
     }
-    this.persistenceSetting.set(value);
 
     let modeButtonTitle = i18nString(UIStrings.rotate);
     let modeButtonDisabled = false;
@@ -760,10 +762,8 @@ export class DeviceModeToolbar extends UI.Widget.Widget {
 
   private appendOptionsMenuItems(contextMenu: UI.ContextMenu.ContextMenu): void {
     const model = this.model;
-    appendToggleItem(
-        contextMenu.headerSection(), this.deviceOutlineSetting, i18nString(UIStrings.hideDeviceFrame),
-        i18nString(UIStrings.showDeviceFrame), model.type() !== EmulationModel.DeviceModeModel.Type.Device,
-        'device-frame');
+    appendToggleItem(contextMenu.headerSection(), this.deviceOutlineSetting, i18nString(UIStrings.hideDeviceFrame),
+                     i18nString(UIStrings.showDeviceFrame), !model.canShowDeviceFrame(), 'device-frame');
     appendToggleItem(
         contextMenu.headerSection(), this.showMediaInspectorSetting, i18nString(UIStrings.hideMediaQueries),
         i18nString(UIStrings.showMediaQueries), undefined, 'media-queries');
@@ -792,7 +792,7 @@ export class DeviceModeToolbar extends UI.Widget.Widget {
         disabled = model.type() === EmulationModel.DeviceModeModel.Type.None;
       }
 
-      const isEnabled = setting.get();
+      const isEnabled = Boolean(setting.get() && !disabled);
       const jslogContext = `${context}-${isEnabled ? 'disable' : 'enable'}`;
       section.appendItem(
           isEnabled ? title1 : title2, setting.set.bind(setting, !setting.get()), {disabled, jslogContext});

package/front_end/panels/explain/components/ConsoleInsight.ts

@@ -861,7 +861,8 @@ export class ConsoleInsight extends UI.Widget.Widget {
   // on -> entrypoints are shown, and console insights can be generated
   #getConsoleInsightsEnabledSetting(): Common.Settings.Setting<boolean>|undefined {
     try {
-      return Common.Settings.moduleSetting('console-insights-enabled') as Common.Settings.Setting<boolean>;
+      return Common.Settings.Settings.instance().moduleSetting('console-insights-enabled') as
+          Common.Settings.Setting<boolean>;
     } catch {
       return;
     }

package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts

@@ -167,6 +167,7 @@ export interface EventTypes {
 
 export class NetworkThrottlingSelect extends Common.ObjectWrapper.eventMixin<EventTypes, typeof UI.Widget.Widget>(
     UI.Widget.Widget) {
+  readonly #settings: Common.Settings.Settings;
   #recommendedConditions: SDK.NetworkManager.Conditions|null = null;
   #jslogContext?: string;
   #currentConditions: SDK.NetworkManager.ThrottlingConditions|undefined;
@@ -185,16 +186,16 @@ export class NetworkThrottlingSelect extends Common.ObjectWrapper.eventMixin<Eve
     return select;
   }
 
-  constructor(
-      element?: HTMLElement, options: {
-        title?: string,
-        jslogContext?: string,
-        currentConditions?: SDK.NetworkManager.Conditions,
-        includeBlocking?: true,
-      } = {},
-      view = DEFAULT_VIEW) {
+  constructor(element?: HTMLElement, options: {
+    title?: string,
+    jslogContext?: string,
+    currentConditions?: SDK.NetworkManager.Conditions,
+    includeBlocking?: true,
+  } = {},
+              settings = Common.Settings.Settings.instance(), view = DEFAULT_VIEW) {
     super(element);
-    SDK.NetworkManager.customUserNetworkConditionsSetting().addChangeListener(this.requestUpdate, this);
+    this.#settings = settings;
+    SDK.NetworkManager.customUserNetworkConditionsSetting(settings).addChangeListener(this.requestUpdate, this);
     this.#jslogContext = options.jslogContext;
     this.#currentConditions = options.currentConditions;
     this.#title = options.title;
@@ -258,7 +259,7 @@ export class NetworkThrottlingSelect extends Common.ObjectWrapper.eventMixin<Eve
     const multitargetNetworkManager = SDK.NetworkManager.MultitargetNetworkManager.instance();
 
     if (bind) {
-      this.#jslogContext = SDK.NetworkManager.activeNetworkThrottlingKeySetting().name;
+      this.#jslogContext = SDK.NetworkManager.activeNetworkThrottlingKeySetting(this.#settings).name;
       ThrottlingManager.instance();  // Instantiate the throttling manager to connect network manager with the setting
       this.#currentConditions = multitargetNetworkManager.networkConditions();
 
@@ -298,10 +299,10 @@ export class NetworkThrottlingSelect extends Common.ObjectWrapper.eventMixin<Eve
   }
 
   override performUpdate(): void {
-    const customNetworkConditionsSetting = SDK.NetworkManager.customUserNetworkConditionsSetting();
+    const customNetworkConditionsSetting = SDK.NetworkManager.customUserNetworkConditionsSetting(this.#settings);
     const customNetworkConditions = customNetworkConditionsSetting.get();
     const onAddCustomConditions = (): void => {
-      void Common.Revealer.reveal(SDK.NetworkManager.customUserNetworkConditionsSetting());
+      void Common.Revealer.reveal(customNetworkConditionsSetting);
     };
 
     const onSelect = (conditions: SDK.NetworkManager.ThrottlingConditions): void => {

package/front_end/panels/mobile_throttling/ThrottlingManager.ts

@@ -126,7 +126,7 @@ export class ThrottlingManager extends Common.ObjectWrapper.ObjectWrapper<Thrott
     return this.#hardwareConcurrencyOverrideEnabled;
   }
 
-  private constructor() {
+  private constructor(settings: Common.Settings.Settings) {
     super();
     this.cpuThrottlingManager = SDK.CPUThrottlingManager.CPUThrottlingManager.instance();
     this.cpuThrottlingManager.addEventListener(
@@ -134,12 +134,12 @@ export class ThrottlingManager extends Common.ObjectWrapper.ObjectWrapper<Thrott
         (event: Common.EventTarget.EventTargetEvent<number>) => this.onCPUThrottlingRateChangedOnSDK(event.data));
     this.cpuThrottlingControls = new Set();
     this.cpuThrottlingOptions = ThrottlingPresets.cpuThrottlingPresets;
-    this.customNetworkConditionsSetting = SDK.NetworkManager.customUserNetworkConditionsSetting();
+    this.customNetworkConditionsSetting = SDK.NetworkManager.customUserNetworkConditionsSetting(settings);
 
-    this.currentNetworkThrottlingConditionKeySetting = SDK.NetworkManager.activeNetworkThrottlingKeySetting();
+    this.currentNetworkThrottlingConditionKeySetting = SDK.NetworkManager.activeNetworkThrottlingKeySetting(settings);
 
     this.calibratedCpuThrottlingSetting =
-        Common.Settings.Settings.instance().createSetting<PanelsCommon.CPUThrottlingOption.CalibratedCPUThrottling>(
+        settings.createSetting<PanelsCommon.CPUThrottlingOption.CalibratedCPUThrottling>(
             'calibrated-cpu-throttling', {}, Common.Settings.SettingStorageType.GLOBAL);
     this.calibratedCpuThrottlingSetting.addChangeListener(this.onCalibratedSettingChanged, this);
 
@@ -168,10 +168,11 @@ export class ThrottlingManager extends Common.ObjectWrapper.ObjectWrapper<Thrott
     return custom ?? SDK.NetworkManager.NoThrottlingConditions;
   }
 
-  static instance(opts: {forceNew: boolean|null} = {forceNew: null}): ThrottlingManager {
-    const {forceNew} = opts;
+  static instance(opts: {forceNew: boolean|null, settings?: Common.Settings.Settings} = {forceNew: null}):
+      ThrottlingManager {
+    const {forceNew, settings} = opts;
     if (!throttlingManagerInstance || forceNew) {
-      throttlingManagerInstance = new ThrottlingManager();
+      throttlingManagerInstance = new ThrottlingManager(settings ?? Common.Settings.Settings.instance());
     }
 
     return throttlingManagerInstance;

package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts

@@ -230,10 +230,9 @@ export class CPUThrottlingCard {
   private state: 'cta'|'prompting'|'calibrating' = 'cta';
   private warnings: string[] = [];
 
-  constructor() {
-    this.setting =
-        Common.Settings.Settings.instance().createSetting<PanelsCommon.CPUThrottlingOption.CalibratedCPUThrottling>(
-            'calibrated-cpu-throttling', {}, Common.Settings.SettingStorageType.GLOBAL);
+  constructor(settings: Common.Settings.Settings) {
+    this.setting = settings.createSetting<PanelsCommon.CPUThrottlingOption.CalibratedCPUThrottling>(
+        'calibrated-cpu-throttling', {}, Common.Settings.SettingStorageType.GLOBAL);
 
     this.element = document.createElement('devtools-card');
     this.element.heading = i18nString(UIStrings.cpuThrottlingPresets);
@@ -475,7 +474,7 @@ export class ThrottlingSettingsTab extends UI.Widget.VBox implements
    */
   #customUserConditionsCount: number;
 
-  constructor() {
+  constructor(settings: Common.Settings.Settings) {
     super({
       jslog: `${VisualLogging.pane('throttling-conditions')}`,
       useShadowDom: true,
@@ -486,7 +485,7 @@ export class ThrottlingSettingsTab extends UI.Widget.VBox implements
         this.contentElement.createChild('div', 'settings-card-container-wrapper').createChild('div');
     settingsContent.classList.add('settings-card-container', 'throttling-conditions-settings');
 
-    this.cpuThrottlingCard = new CPUThrottlingCard();
+    this.cpuThrottlingCard = new CPUThrottlingCard(settings);
     settingsContent.append(this.cpuThrottlingCard.element);
 
     const addButton = new Buttons.Button.Button();
@@ -512,7 +511,7 @@ export class ThrottlingSettingsTab extends UI.Widget.VBox implements
     const customContainer = createProfilesCard(i18nString(UIStrings.customProfiles), this.customList, settingsContent);
     customContainer.appendChild(addButton);
 
-    this.customUserConditions = SDK.NetworkManager.customUserNetworkConditionsSetting();
+    this.customUserConditions = SDK.NetworkManager.customUserNetworkConditionsSetting(settings);
     this.customUserConditions.addChangeListener(this.conditionsUpdated, this);
 
     const customConditions = this.customUserConditions.get();

package/front_end/panels/mobile_throttling/mobile_throttling-meta.ts

@@ -62,9 +62,10 @@ UI.ViewManager.registerViewExtension({
   title: i18nLazyString(UIStrings.throttling),
   commandPrompt: i18nLazyString(UIStrings.showThrottling),
   order: 35,
-  async loadView() {
+  async loadView(universe) {
     const MobileThrottling = await loadMobileThrottlingModule();
-    return new MobileThrottling.ThrottlingSettingsTab.ThrottlingSettingsTab();
+    const {settings} = universe;
+    return new MobileThrottling.ThrottlingSettingsTab.ThrottlingSettingsTab(settings);
   },
   settings: [
     'custom-network-conditions',

package/front_end/panels/settings/components/SyncSection.ts

@@ -276,7 +276,8 @@ export class SyncSection extends UI.Widget.Widget {
     super(element);
     this.#view = view;
     this.#receiveBadgesSetting = Common.Settings.Settings.instance().moduleSetting('receive-gdp-badges');
-    this.#syncSetting = Common.Settings.moduleSetting('sync-preferences') as Common.Settings.Setting<boolean>;
+    this.#syncSetting =
+        Common.Settings.Settings.instance().moduleSetting('sync-preferences') as Common.Settings.Setting<boolean>;
   }
 
   override wasShown(): void {

package/front_end/panels/timeline/AppenderUtils.ts

@@ -56,13 +56,15 @@ export function buildGroupStyle(extra?: Partial<PerfUI.FlameChart.GroupStyle>):
  * @param style the GroupStyle for the track header.
  * @param selectable if the track is selectable.
  * @param expanded if the track is expanded.
- * @param track this is set only when `selectable` is true, and it is used for selecting a track in the details panel.
  * @param showStackContextMenu whether menu with options to merge/collapse entries in track is shown.
+ * @param fullTrackName a full, non-truncated description of the track to be shown in the tooltip on hover.
+ * @param url the raw URL of the track, if applicable, used for right-click copy actions.
  * @returns the group that built from the give data
  */
-export function buildTrackHeader(
-    jslogContext: VisualLoggingTrackName|null, startLevel: number, name: string, style: PerfUI.FlameChart.GroupStyle,
-    selectable: boolean, expanded?: boolean, showStackContextMenu?: boolean): PerfUI.FlameChart.Group {
+export function buildTrackHeader(jslogContext: VisualLoggingTrackName|null, startLevel: number, name: string,
+                                 style: PerfUI.FlameChart.GroupStyle, selectable: boolean, expanded?: boolean,
+                                 showStackContextMenu?: boolean, fullTrackName?: string,
+                                 url?: string): PerfUI.FlameChart.Group {
   const group: PerfUI.FlameChart.Group = {
     startLevel,
     name: name as Common.UIString.LocalizedString,
@@ -74,6 +76,12 @@ export function buildTrackHeader(
   if (jslogContext !== null) {
     group.jslogContext = jslogContext;
   }
+  if (fullTrackName !== undefined) {
+    group.fullTrackName = fullTrackName;
+  }
+  if (url !== undefined) {
+    group.url = url;
+  }
   return group;
 }
 

package/front_end/panels/timeline/ThreadAppender.ts

@@ -265,9 +265,9 @@ export class ThreadAppender implements TrackAppender {
       style.nestingLevel = this.#headerNestingLevel;
     }
     const visualLoggingName = this.#visualLoggingNameForThread();
-    const group = buildTrackHeader(
-        visualLoggingName, currentLevel, this.trackName(), style, /* selectable= */ true, this.#expanded,
-        /* showStackContextMenu= */ true);
+    const group = buildTrackHeader(visualLoggingName, currentLevel, this.trackName(), style, /* selectable= */ true,
+                                   this.#expanded,
+                                   /* showStackContextMenu= */ true, this.trackName(), this.#url || undefined);
     this.#compatibilityBuilder.registerTrackForGroup(group, this);
   }
 

package/front_end/panels/timeline/TimelinePanel.ts

@@ -1162,7 +1162,7 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
   }
 
   #setupNavigationSetting(): HTMLElement {
-    const currentNavSetting = Common.Settings.moduleSetting('flamechart-selected-navigation').get();
+    const currentNavSetting = Common.Settings.Settings.instance().moduleSetting('flamechart-selected-navigation').get();
     const hideTheDialogForTests: string|null = localStorage.getItem('hide-shortcuts-dialog-for-test');
     const userHadShortcutsDialogOpenedOnce = this.#userHadShortcutsDialogOpenedOnce.get();
 
@@ -1189,11 +1189,11 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
     // Change EventListener is only triggered when the radio button is selected
     this.#modernNavRadioButton.radio.addEventListener('change', () => {
       this.#shortcutsDialog.data = {shortcuts: this.#getShortcutsInfo(/* isNavClassic */ false)};
-      Common.Settings.moduleSetting('flamechart-selected-navigation').set('modern');
+      Common.Settings.Settings.instance().moduleSetting('flamechart-selected-navigation').set('modern');
     });
     this.#classicNavRadioButton.radio.addEventListener('change', () => {
       this.#shortcutsDialog.data = {shortcuts: this.#getShortcutsInfo(/* isNavClassic */ true)};
-      Common.Settings.moduleSetting('flamechart-selected-navigation').set('classic');
+      Common.Settings.Settings.instance().moduleSetting('flamechart-selected-navigation').set('classic');
     });
 
     this.#navigationRadioButtons.appendChild(this.#modernNavRadioButton.label);
@@ -1204,7 +1204,7 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
   }
 
   #updateNavigationSettingSelection(): void {
-    const currentNavSetting = Common.Settings.moduleSetting('flamechart-selected-navigation').get();
+    const currentNavSetting = Common.Settings.Settings.instance().moduleSetting('flamechart-selected-navigation').get();
     if (currentNavSetting === 'classic') {
       this.#classicNavRadioButton.radio.checked = true;
       Host.userMetrics.navigationSettingAtFirstTimelineLoad(
@@ -2237,7 +2237,7 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
     // Logging the setting on the first timeline load will allow us to get an estimate number of people using each option.
     if (this.#traceEngineModel.size() === 1) {
       this.#setupNavigationSetting();
-      if (Common.Settings.moduleSetting('flamechart-selected-navigation').get() === 'classic') {
+      if (Common.Settings.Settings.instance().moduleSetting('flamechart-selected-navigation').get() === 'classic') {
         Host.userMetrics.navigationSettingAtFirstTimelineLoad(
             Host.UserMetrics.TimelineNavigationSetting.CLASSIC_AT_SESSION_FIRST_TRACE);
       } else {

package/front_end/panels/timeline/timelineFlameChartView.css

@@ -146,7 +146,8 @@
   pointer-events: none;
   padding: var(--sys-size-3) var(--sys-size-4);
   border-radius: var(--sys-shape-corner-extra-small);
-  white-space: nowrap;
+  white-space: pre-wrap;
+  word-break: break-all;
   max-width: 80%;
   box-shadow: var(--sys-elevation-level2);
 }

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: Internal
 Version: N/A
-Revision: 0ace4caef4948b4cbf54725b4133cb02bd286e24
+Revision: 5b4c0fb18c574481d5449ad96d165caf343e8be8
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE