chrome-devtools-frontend 1.0.1650100 → 1.0.1650232

package/front_end/core/host/UserMetrics.ts

@@ -204,21 +204,6 @@ export class UserMetrics {
     InspectorFrontendHostInstance.recordCountHistogram('DevTools.Freestyler.EvalResponseSize', bytes, 0, 100_000, 100);
   }
 
-  performanceAINetworkSummaryResponseSize(bytes: number): void {
-    InspectorFrontendHostInstance.recordCountHistogram(
-        'DevTools.PerformanceAI.NetworkSummaryResponseSize', bytes, 0, 100_000, 100);
-  }
-
-  performanceAINetworkRequestDetailResponseSize(bytes: number): void {
-    InspectorFrontendHostInstance.recordCountHistogram(
-        'DevTools.PerformanceAI.NetworkRequestDetailResponseSize', bytes, 0, 100_000, 100);
-  }
-
-  performanceAIMainThreadActivityResponseSize(bytes: number): void {
-    InspectorFrontendHostInstance.recordCountHistogram(
-        'DevTools.PerformanceAI.MainThreadActivityResponseSize', bytes, 0, 100_000, 100);
-  }
-
   builtInAiAvailability(availability: BuiltInAiAvailability): void {
     InspectorFrontendHostInstance.recordEnumeratedHistogram(
         EnumeratedHistogram.BuiltInAiAvailability, availability, BuiltInAiAvailability.MAX_VALUE);

package/front_end/core/sdk/CSSMetadata.ts

@@ -138,6 +138,9 @@ export class CSSMetadata {
                            if (preset && preset !== value) {
                              return false;
                            }
+                           if (partialValueKeywordsNoPresets.get(name)?.has(value)) {
+                             return false;
+                           }
                            return CSS.supports(name, value);
                          })
                          .sort(CSSMetadata.sortPrefixesAndCSSWideKeywordsToEnd);
@@ -517,9 +520,78 @@ const valuePresets = new Map([
       ['ornaments', 'ornaments(||)'],
       ['annotation', 'annotation(||)'],
     ]),
+  ],
+  [
+    'clip-path', new Map([
+      ['inset', 'inset(|10px|)'],
+      ['circle', 'circle(|100px|)'],
+      ['ellipse', 'ellipse(|100px 100px|)'],
+      ['polygon', 'polygon(|50px 0px, 100px 100px, 0px 100px|)'],
+      ['url', 'url(||)'],
+    ])
+  ],
+  [
+    'transition-timing-function', new Map([
+      ['steps', 'steps(|5, end|)'],
+      ['cubic-bezier', 'cubic-bezier(|0.25, 0.1, 0.25, 1|)'],
+    ])
+  ],
+  [
+    'animation-timing-function', new Map([
+      ['steps', 'steps(|5, end|)'],
+      ['cubic-bezier', 'cubic-bezier(|0.25, 0.1, 0.25, 1|)'],
+    ])
+  ],
+  [
+    'box-shadow',
+    new Map([
+      ['inset', 'inset |0 0 10px black|'],
+    ]),
+  ],
+  [
+    'font-size-adjust',
+    new Map([
+      ['ex-height', 'ex-height |0.5|'],
+      ['cap-height', 'cap-height |0.5|'],
+      ['ch-width', 'ch-width |0.5|'],
+      ['ic-width', 'ic-width |0.5|'],
+      ['ic-height', 'ic-height |0.5|'],
+    ]),
+  ],
+  [
+    'initial-letter',
+    new Map([
+      ['drop', 'drop |2|'],
+      ['raise', 'raise |2|'],
+    ]),
+  ],
+  [
+    'text-box-edge', new Map([
+      ['cap', 'cap alphabetic'],
+      ['ex', 'ex alphabetic'],
+    ])
   ]
 ]);
 
+const partialValueKeywordsNoPresets = new Map<string, Set<string>>([
+  ['scroll-snap-type', new Set(['mandatory', 'proximity'])],
+  ['scrollbar-gutter', new Set(['both-edges'])],
+  ['animation-timing-function', new Set(['jump-both', 'jump-end', 'jump-none', 'jump-start'])],
+  ['transition-timing-function', new Set(['jump-both', 'jump-end', 'jump-none', 'jump-start'])],
+  [
+    'animation-trigger', new Set([
+      'play',
+      'pause',
+      'play-once',
+      'play-alternate',
+      'play-forwards',
+      'play-backwards',
+      'play-pause',
+      'replay',
+    ])
+  ],
+]);
+
 const distanceProperties = new Set<string>([
   'background-position',
   'border-spacing',

package/front_end/models/ai_assistance/agents/ExecuteJavascript.ts

@@ -179,7 +179,11 @@ export class JavascriptExecutor {
     return error;
   }
 }`;
+    const timeoutSentinel = Symbol('timeout');
+    const {promise: timeoutPromise, resolve: resolveTimeout} = Promise.withResolvers<typeof timeoutSentinel>();
+    let timeoutId: ReturnType<typeof setTimeout>|undefined;
     try {
+      timeoutId = setTimeout(() => resolveTimeout(timeoutSentinel), OBSERVATION_TIMEOUT);
       const result = await Promise.race([
         this.#execJs(
             functionDeclaration,
@@ -188,11 +192,11 @@ export class JavascriptExecutor {
               contextNode: this.#options.getContextNode(),
             },
             ),
-        new Promise<never>((_, reject) => {
-          setTimeout(
-              () => reject(new Error('Script execution exceeded the maximum allowed time.')), OBSERVATION_TIMEOUT);
-        }),
+        timeoutPromise,
       ]);
+      if (result === timeoutSentinel) {
+        throw new Error('Script execution exceeded the maximum allowed time.');
+      }
       const byteCount = Platform.StringUtilities.countWtf8Bytes(result);
       Host.userMetrics.freestylerEvalResponseSize(byteCount);
       if (byteCount > MAX_OBSERVATION_BYTE_LENGTH) {
@@ -217,6 +221,11 @@ export class JavascriptExecutor {
         sideEffect: false,
         canceled: false,
       };
+    } finally {
+      if (timeoutId !== undefined) {
+        clearTimeout(timeoutId);
+      }
+      resolveTimeout(timeoutSentinel);
     }
   }
 }

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -6,7 +6,7 @@ import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
 import type {UrlString} from '../../../core/platform/DevToolsPath.js';
-import * as Platform from '../../../core/platform/platform.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
 import * as Tracing from '../../../services/tracing/tracing.js';
@@ -936,9 +936,6 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       };
     }
 
-    const byteCount = Platform.StringUtilities.countWtf8Bytes(summary);
-    Host.userMetrics.performanceAIMainThreadActivityResponseSize(byteCount);
-
     this.#cacheFunctionResult(focus, cacheKey, summary);
     const widgets: AiWidget[] = [];
     widgets.push({
@@ -1225,9 +1222,6 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
           };
         }
 
-        const byteCount = Platform.StringUtilities.countWtf8Bytes(summary);
-        Host.userMetrics.performanceAINetworkSummaryResponseSize(byteCount);
-
         const key = `getNetworkTrackSummary({min: ${bounds.min}, max: ${bounds.max}})`;
         this.#cacheFunctionResult(focus, key, summary);
         return {