chrome-devtools-frontend 1.0.1645245 → 1.0.1646286

package/front_end/models/ai_assistance/agents/NetworkAgent.ts

@@ -2,21 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
-import * as i18n from '../../../core/i18n/i18n.js';
-import type * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import type * as SDK from '../../../core/sdk/sdk.js';
-import type * as NetworkTimeCalculator from '../../network_time_calculator/network_time_calculator.js';
-import {extractContextOrigin} from '../AiOrigins.js';
-import {NetworkRequestFormatter} from '../data_formatters/NetworkRequestFormatter.js';
+import type {RequestContext} from '../contexts/RequestContext.js';
 
 import {
   AiAgent,
-  type ContextDetail,
   type ContextResponse,
-  ConversationContext,
   type RequestOptions,
   ResponseType,
 } from './AiAgent.js';
@@ -73,90 +66,6 @@ This request aims to retrieve a list of products matching the search query "lapt
 `;
 /* clang-format on */
 
-/*
-* Strings that don't need to be translated at this time.
-*/
-const UIStringsNotTranslate = {
-  /**
-   * @description Heading text for the block that shows the network request details.
-   */
-  request: 'Request',
-  /**
-   * @description Heading text for the block that shows the network response details.
-   */
-  response: 'Response',
-  /**
-   * @description Prefix text for request URL.
-   */
-  requestUrl: 'Request URL',
-  /**
-   * @description Title text for request timing details.
-   */
-  timing: 'Timing',
-  /**
-   * @description Title text for request initiator chain.
-   */
-  requestInitiatorChain: 'Request initiator chain',
-} as const;
-
-const lockedString = i18n.i18n.lockedString;
-
-/**
- * Returns the origin for a network request in the AI context.
- *
- * To prevent cross-origin prompt injection attacks, HAR-imported requests
- * are isolated from live pages. We assign them a virtual origin
- * (`imported-har://${domain}`) so they do not share the origin of live pages
- * (e.g., `https://${domain}`). This forces a conversation reset when transitioning
- * between imported HAR data and live pages.
- */
-export function getRequestContextOrigin(request: SDK.NetworkRequest.NetworkRequest): string {
-  const origin = extractContextOrigin(request.documentURL);
-  if (request.isImportedHar()) {
-    const parsed = Common.ParsedURL.ParsedURL.fromString(origin as Platform.DevToolsPath.UrlString);
-    return `imported-har://${parsed ? parsed.domain() : origin}`;
-  }
-  return origin;
-}
-
-export class RequestContext extends ConversationContext<SDK.NetworkRequest.NetworkRequest> {
-  #request: SDK.NetworkRequest.NetworkRequest;
-  #calculator: NetworkTimeCalculator.NetworkTransferTimeCalculator;
-
-  constructor(
-      request: SDK.NetworkRequest.NetworkRequest, calculator: NetworkTimeCalculator.NetworkTransferTimeCalculator) {
-    super();
-    this.#request = request;
-    this.#calculator = calculator;
-  }
-
-  /**
-   * Note: this is not the literal origin of the network request. This URL
-   * is used to determine when we should force the user to start a new AI
-   * conversation when the context changes. We allow a single AI conversation to
-   * inspect all network requests that were made for that given target URL.
-   */
-  override getURL(): string {
-    return this.#request.documentURL;
-  }
-
-  override getOrigin(): string {
-    return getRequestContextOrigin(this.#request);
-  }
-
-  override getItem(): SDK.NetworkRequest.NetworkRequest {
-    return this.#request;
-  }
-
-  get calculator(): NetworkTimeCalculator.NetworkTimeCalculator {
-    return this.#calculator;
-  }
-
-  override getTitle(): string {
-    return this.#request.name();
-  }
-}
-
 /**
  * One agent instance handles one conversation. Create a new agent
  * instance for a new conversation.
@@ -183,9 +92,14 @@ export class NetworkAgent extends AiAgent<SDK.NetworkRequest.NetworkRequest> {
       return;
     }
 
+    const details = await selectedNetworkRequest.getUserFacingDetails();
+    if (!details) {
+      return;
+    }
+
     yield {
       type: ResponseType.CONTEXT,
-      details: await createContextDetailsForNetworkAgent(selectedNetworkRequest),
+      details,
       widgets: [{
         name: 'NETWORK_REQUEST_GENERAL_HEADERS',
         data: {
@@ -196,46 +110,8 @@ export class NetworkAgent extends AiAgent<SDK.NetworkRequest.NetworkRequest> {
   }
 
   override async enhanceQuery(query: string, selectedNetworkRequest: RequestContext|null): Promise<string> {
-    const networkEnchantmentQuery = selectedNetworkRequest ?
-        `# Selected network request \n${
-            await (new NetworkRequestFormatter(selectedNetworkRequest.getItem(), selectedNetworkRequest.calculator)
-                       .formatNetworkRequest())}\n\n# User request\n\n` :
-        '';
+    const promptDetails = selectedNetworkRequest ? await selectedNetworkRequest.getPromptDetails() : null;
+    const networkEnchantmentQuery = promptDetails ? `${promptDetails}\n\n# User request\n\n` : '';
     return `${networkEnchantmentQuery}${query}`;
   }
 }
-
-async function createContextDetailsForNetworkAgent(
-    selectedNetworkRequest: RequestContext,
-    ): Promise<[ContextDetail, ...ContextDetail[]]> {
-  const request = selectedNetworkRequest.getItem();
-  const formatter = new NetworkRequestFormatter(request, selectedNetworkRequest.calculator);
-  const requestContextDetail: ContextDetail = {
-    title: lockedString(UIStringsNotTranslate.request),
-    text: lockedString(UIStringsNotTranslate.requestUrl) + ': ' + request.url() + '\n\n' +
-        formatter.formatRequestHeaders(),
-  };
-  const responseBody = await formatter.formatResponseBody();
-  const responseBodyString = responseBody ? `\n\n${responseBody}` : '';
-
-  const responseContextDetail: ContextDetail = {
-    title: lockedString(UIStringsNotTranslate.response),
-    text: formatter.formatResponseHeaders() + responseBodyString +
-        `\n\n${formatter.formatStatus()}${formatter.formatFailureReasons()}`,
-  };
-  const timingContextDetail: ContextDetail = {
-    title: lockedString(UIStringsNotTranslate.timing),
-    text: formatter.formatNetworkRequestTiming(),
-  };
-  const initiatorChainContextDetail: ContextDetail = {
-    title: lockedString(UIStringsNotTranslate.requestInitiatorChain),
-    text: formatter.formatRequestInitiatorChain(),
-  };
-
-  return [
-    requestContextDetail,
-    responseContextDetail,
-    timingContextDetail,
-    initiatorChainContextDetail,
-  ];
-}

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -15,7 +15,7 @@ import * as Logs from '../../logs/logs.js';
 import * as SourceMapScopes from '../../source_map_scopes/source_map_scopes.js';
 import * as TextUtils from '../../text_utils/text_utils.js';
 import * as Trace from '../../trace/trace.js';
-import {extractContextOrigin} from '../AiOrigins.js';
+import {canResourceContentsBeReadForTrace, extractContextOrigin} from '../AiOrigins.js';
 import {sanitizeHeaders} from '../data_formatters/NetworkRequestFormatter.js';
 import {
   PerformanceInsightFormatter,
@@ -1472,8 +1472,16 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       },
       handler: async args => {
         debugLog('Function call: getResourceContent');
+        if (!isFresh) {
+          return {error: 'Cannot use this tool on an imported file.'};
+        }
+
+        const url = args.url;
+        const allowedOrigin = context.getOrigin();
+        if (!canResourceContentsBeReadForTrace(url, allowedOrigin)) {
+          return {error: 'Resource not found'};
+        }
 
-        const url = args.url as Platform.DevToolsPath.UrlString;
         let content: string|undefined;
 
         // First check parsedTrace.data.Scripts.

package/front_end/models/ai_assistance/agents/README.md

@@ -31,6 +31,13 @@ Example from `PerformanceAgent`:
   }
 ```
 
+### Origin Validation (`isOriginAllowed`)
+
+Before running an execution loop, the system validates the context's origin:
+*   **Opaque Origin Rejection**: Opaque origins are rejected immediately, blocking conversations on untrusted/opaque contexts (like `about:blank`, `data:` URLs, or opaque blob URLs).
+*   **Origin Lock Integrity**: If the conversation is already locked to an origin, the new context's origin must be equivalent (as defined by `areOriginsEquivalent()`) to the locked origin.
+*   **Safety Termination**: If validation fails, a cross-origin error is yielded and execution stops.
+
 ## Performance Agent
 
 The `PerformanceAgent` analyzes performance traces. This documentation details the specific data provided to the agent and the data it can retrieve via functions.

package/front_end/models/ai_assistance/ai_assistance.ts

@@ -23,6 +23,8 @@ import * as AiUtils from './AiUtils.js';
 import * as BuiltInAi from './BuiltInAi.js';
 import * as ChangeManager from './ChangeManager.js';
 import * as DOMNodeContext from './contexts/DOMNodeContext.js';
+import * as FileContext from './contexts/FileContext.js';
+import * as RequestContext from './contexts/RequestContext.js';
 import * as ConversationSummary from './ConversationSummary.js';
 import * as FileFormatter from './data_formatters/FileFormatter.js';
 import * as LighthouseFormatter from './data_formatters/LighthouseFormatter.js';
@@ -66,6 +68,7 @@ export {
   ExecuteJavaScript,
   ExtensionScope,
   FileAgent,
+  FileContext,
   FileFormatter,
   GetStyles,
   GreenDevAgent,
@@ -80,6 +83,7 @@ export {
   PerformanceAnnotations,
   PerformanceInsightFormatter,
   PerformanceTraceFormatter,
+  RequestContext,
   StorageAgent,
   StorageItem,
   StylingAgent,

package/front_end/models/ai_assistance/contexts/FileContext.ts

@@ -0,0 +1,45 @@
+// Copyright 2026 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import type * as Workspace from '../../workspace/workspace.js';
+import {type ContextDetail, ConversationContext} from '../agents/AiAgent.js';
+import {FileFormatter} from '../data_formatters/FileFormatter.js';
+
+export class FileContext extends ConversationContext<Workspace.UISourceCode.UISourceCode> {
+  #file: Workspace.UISourceCode.UISourceCode;
+
+  constructor(file: Workspace.UISourceCode.UISourceCode) {
+    super();
+    this.#file = file;
+  }
+
+  override getURL(): string {
+    return this.#file.url();
+  }
+
+  override getItem(): Workspace.UISourceCode.UISourceCode {
+    return this.#file;
+  }
+
+  override getTitle(): string {
+    return this.#file.displayName();
+  }
+
+  override async getPromptDetails(): Promise<string|null> {
+    return `# Selected file\n${new FileFormatter(this.#file).formatFile()}`;
+  }
+
+  override async getUserFacingDetails(): Promise<[ContextDetail, ...ContextDetail[]]|null> {
+    return [
+      {
+        title: 'Selected file',
+        text: new FileFormatter(this.#file).formatFile(),
+      },
+    ];
+  }
+
+  override async refresh(): Promise<void> {
+    await this.#file.requestContentData();
+  }
+}

package/front_end/models/ai_assistance/contexts/RequestContext.snapshot.txt

@@ -0,0 +1,48 @@
+Title: RequestContext getPromptDetails describes the network request correctly
+Content:
+# Selected network request
+Request: https://www.example.com/api/users
+
+Request headers:
+Accept: application/json
+
+Response headers:
+Content-Type: application/json
+
+Response body:
+{}
+
+Response status: 200
+Network request status: pending
+
+Request timing:
+Queued at (timestamp): 0 s
+Started at (timestamp): 0 s
+Connection start (stalled) (duration): -
+Duration (duration): -
+
+Request initiator chain:
+- URL: https://www.example.com/api/users
+=== end content
+
+Title: RequestContext getUserFacingDetails returns details correctly
+Content:
+[
+  {
+    "title": "Request",
+    "text": "Request URL: https://www.example.com/api/users\n\nRequest headers:\nAccept: application/json"
+  },
+  {
+    "title": "Response",
+    "text": "Response headers:\nContent-Type: application/json\n\nResponse body:\n{}\n\nResponse status: 200\nNetwork request status: pending\n"
+  },
+  {
+    "title": "Timing",
+    "text": "Queued at (timestamp): 0 s\nStarted at (timestamp): 0 s\nConnection start (stalled) (duration): -\nDuration (duration): -"
+  },
+  {
+    "title": "Request initiator chain",
+    "text": "- URL: https://www.example.com/api/users"
+  }
+]
+=== end content

package/front_end/models/ai_assistance/contexts/RequestContext.ts

@@ -0,0 +1,116 @@
+// Copyright 2026 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as Common from '../../../core/common/common.js';
+import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
+import type * as SDK from '../../../core/sdk/sdk.js';
+import type * as NetworkTimeCalculator from '../../network_time_calculator/network_time_calculator.js';
+import {
+  type ContextDetail,
+  ConversationContext,
+} from '../agents/AiAgent.js';
+import {extractContextOrigin} from '../AiOrigins.js';
+import {NetworkRequestFormatter} from '../data_formatters/NetworkRequestFormatter.js';
+
+const UIStringsNotTranslate = {
+  request: 'Request',
+  response: 'Response',
+  requestUrl: 'Request URL',
+  timing: 'Timing',
+  requestInitiatorChain: 'Request initiator chain',
+} as const;
+
+const lockedString = i18n.i18n.lockedString;
+
+/**
+ * Returns the origin for a network request in the AI context.
+ *
+ * To prevent cross-origin prompt injection attacks, HAR-imported requests
+ * are isolated from live pages. We assign them a virtual origin
+ * (`imported-har://${domain}`) so they do not share the origin of live pages
+ * (e.g., `https://${domain}`). This forces a conversation reset when transitioning
+ * between imported HAR data and live pages.
+ */
+export function getRequestContextOrigin(request: SDK.NetworkRequest.NetworkRequest): string {
+  const origin = extractContextOrigin(request.documentURL);
+  if (request.isImportedHar()) {
+    const parsed = Common.ParsedURL.ParsedURL.fromString(origin as Platform.DevToolsPath.UrlString);
+    return `imported-har://${parsed ? parsed.domain() : origin}`;
+  }
+  return origin;
+}
+
+export class RequestContext extends ConversationContext<SDK.NetworkRequest.NetworkRequest> {
+  #request: SDK.NetworkRequest.NetworkRequest;
+  #calculator: NetworkTimeCalculator.NetworkTransferTimeCalculator;
+
+  constructor(
+      request: SDK.NetworkRequest.NetworkRequest,
+      calculator: NetworkTimeCalculator.NetworkTransferTimeCalculator,
+  ) {
+    super();
+    this.#request = request;
+    this.#calculator = calculator;
+  }
+
+  /**
+   * Note: this is not the literal origin of the network request. This URL
+   * is used to determine when we should force the user to start a new AI
+   * conversation when the context changes. We allow a single AI conversation to
+   * inspect all network requests that were made for that given target URL.
+   */
+  override getURL(): string {
+    return this.#request.documentURL;
+  }
+
+  override getOrigin(): string {
+    return getRequestContextOrigin(this.#request);
+  }
+
+  override getItem(): SDK.NetworkRequest.NetworkRequest {
+    return this.#request;
+  }
+
+  override getTitle(): string {
+    return this.#request.name();
+  }
+
+  override async getPromptDetails(): Promise<string|null> {
+    const formatter = new NetworkRequestFormatter(this.#request, this.#calculator);
+    return `# Selected network request\n${await formatter.formatNetworkRequest()}`;
+  }
+
+  override async getUserFacingDetails(): Promise<[ContextDetail, ...ContextDetail[]]|null> {
+    const formatter = new NetworkRequestFormatter(this.#request, this.#calculator);
+    const requestContextDetail: ContextDetail = {
+      title: lockedString(UIStringsNotTranslate.request),
+      text: lockedString(UIStringsNotTranslate.requestUrl) + ': ' + this.#request.url() + '\n\n' +
+          formatter.formatRequestHeaders(),
+    };
+    const responseBody = await formatter.formatResponseBody();
+    const responseBodyString = responseBody ? `\n\n${responseBody}` : '';
+
+    const responseContextDetail: ContextDetail = {
+      title: lockedString(UIStringsNotTranslate.response),
+      text: formatter.formatResponseHeaders() + responseBodyString +
+          `\n\n${formatter.formatStatus()}${formatter.formatFailureReasons()}`,
+    };
+    const timingContextDetail: ContextDetail = {
+      title: lockedString(UIStringsNotTranslate.timing),
+      text: formatter.formatNetworkRequestTiming(),
+    };
+    const initiatorChainContextDetail: ContextDetail = {
+      title: lockedString(UIStringsNotTranslate.requestInitiatorChain),
+      text: formatter.formatRequestInitiatorChain(),
+    };
+
+    return [
+      requestContextDetail,
+      responseContextDetail,
+      timingContextDetail,
+      initiatorChainContextDetail,
+    ];
+  }
+}

package/front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.ts

@@ -92,7 +92,8 @@ export class NetworkRequestFormatter {
   }): string {
     let responseStatus = '';
     if (status.statusCode) {
-      responseStatus = `Response status: ${status.statusCode} ${status.statusText}\n`;
+      const statusText = status.statusText ? ` ${status.statusText}` : '';
+      responseStatus = `Response status: ${status.statusCode}${statusText}\n`;
     }
     const flags = [];
     flags.push(status.finished ? 'finished' : 'pending');

package/front_end/models/ai_assistance/tools/README.md

@@ -17,7 +17,7 @@ Instead of passing a monolithic "grab-bag" context object to all tool handlers,
 - `PageExecutionCapability`: For tools executing JavaScript code on the inspected page.
 - `StyleMutationCapability`: For tools managing and applying style mutations via a `ChangeManager`.
 - `TargetCapability`: For tools requiring access to the page's current SDK `Target`.
-- `OriginLockCapability`: For tools enforcing cross-origin security via origin locks.
+- `OriginLockCapability`: For tools enforcing cross-origin security via origin locks. Tools that fetch resources or state from the inspected page (such as styling or source code) must use this capability to verify that the target resource matches the conversation's established origin. This prevents the LLM from executing tools against out-of-origin elements or documents.
 
 ### Unified Context
 

package/front_end/models/trace/handlers/NetworkRequestsHandler.ts

@@ -213,6 +213,14 @@ export function handleEvent(event: Types.Events.Event): void {
 
 export async function finalize(): Promise<void> {
   const {rendererProcessesByFrame} = metaHandlerData();
+
+  const allowedProtocols = [
+    'blob:',
+    'file:',
+    'filesystem:',
+    'http:',
+    'https:',
+  ];
   for (const [requestId, request] of requestMap.entries()) {
     // If we have an incomplete set of events here, we choose to drop the network
     // request rather than attempt to synthesize the missing data.
@@ -248,7 +256,7 @@ export async function finalize(): Promise<void> {
       }
 
       redirects.push({
-        url: sendRequest.args.data.url,
+        url: allowedProtocols.some(p => sendRequest.args.data.url.startsWith(p)) ? sendRequest.args.data.url : '',
         priority: sendRequest.args.data.priority,
         requestMethod: sendRequest.args.data.requestMethod,
         ts,
@@ -360,15 +368,7 @@ export async function finalize(): Promise<void> {
       }
     }
 
-    // TODO: consider allowing chrome / about.
-    const allowedProtocols = [
-      'blob:',
-      'file:',
-      'filesystem:',
-      'http:',
-      'https:',
-    ];
-    if (!allowedProtocols.some(p => firstSendRequest.args.data.url.startsWith(p))) {
+    if (!allowedProtocols.some(p => finalSendRequest.args.data.url.startsWith(p))) {
       continue;
     }
 
@@ -572,7 +572,11 @@ export async function finalize(): Promise<void> {
               responseHeaders: request.receiveResponse?.args.data.headers ?? null,
               fetchPriorityHint: finalSendRequest.args.data.fetchPriorityHint ?? 'auto',
               initiator: finalSendRequest.args.data.initiator,
-              stackTrace: finalSendRequest.args.data.stackTrace,
+              stackTrace: finalSendRequest.args.data.stackTrace?.map(
+                  frame => ({
+                    ...frame,
+                    url: allowedProtocols.some(p => frame.url.startsWith(p)) ? frame.url : '',
+                  })),
               timing,
               lrServerResponseTime,
               url,

package/front_end/models/web_mcp/WebMCPModel.ts

@@ -9,7 +9,7 @@ import * as SDK from '../../core/sdk/sdk.js';
 import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as Bindings from '../bindings/bindings.js';
-import * as StackTrace from '../stack_trace/stack_trace.js';
+import type * as StackTrace from '../stack_trace/stack_trace.js';
 
 export const enum Events {
   TOOLS_ADDED = 'ToolsAdded',
@@ -18,20 +18,13 @@ export const enum Events {
   TOOL_RESPONDED = 'ToolResponded',
 }
 
-export interface ExceptionDetails {
-  readonly error: SDK.RemoteObject.RemoteObject;
-  readonly description: string;
-  readonly frames: StackTrace.ErrorStackParser.ParsedErrorFrame[];
-  readonly cause?: ExceptionDetails;
-}
-
 export class Result {
   readonly status: Protocol.WebMCP.InvocationStatus;
   readonly output?: unknown;
   readonly errorText?: string;
   // TODO(crbug.com/494516094) Clean this up if the target disappears?
   readonly #exception?: SDK.RemoteObject.RemoteObject;
-  #exceptionDetails?: Promise<ExceptionDetails|undefined>;
+  #symbolizedError?: Promise<Bindings.SymbolizedError.SymbolizedError|null>;
 
   constructor(
       status: Protocol.WebMCP.InvocationStatus, output: unknown|undefined, errorText: string|undefined,
@@ -42,46 +35,13 @@ export class Result {
     this.output = output;
   }
 
-  get exceptionDetails(): Promise<ExceptionDetails|undefined>|undefined {
-    if (!this.#exceptionDetails) {
-      this.#exceptionDetails = this.#resolveExceptionDetails(this.#exception);
-    }
-    return this.#exceptionDetails;
-  }
-
-  async #resolveExceptionDetails(errorObj: SDK.RemoteObject.RemoteObject|undefined):
-      Promise<ExceptionDetails|undefined> {
-    if (!errorObj) {
-      return undefined;
-    }
-    const error = SDK.RemoteObject.RemoteError.objectAsError(errorObj);
-    const [details, cause] = await Promise.all([error.exceptionDetails(), error.cause()]);
-    const description = error.errorStack;
-
-    const frames =
-        StackTrace.ErrorStackParser.parseSourcePositionsFromErrorStack(errorObj.runtimeModel(), error.errorStack) || [];
-    if (details?.stackTrace) {
-      StackTrace.ErrorStackParser.augmentErrorStackWithScriptIds(frames, details.stackTrace);
+  get symbolizedError(): Promise<Bindings.SymbolizedError.SymbolizedError|null>|undefined {
+    if (!this.#symbolizedError) {
+      this.#symbolizedError = this.#exception ?
+          Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance().createSymbolizedError(this.#exception) :
+          Promise.resolve(null);
     }
-
-    if (cause?.subtype === 'error') {
-      return {error: errorObj, description, frames, cause: await this.#resolveExceptionDetails(cause)};
-    }
-
-    if (cause?.type === 'string') {
-      return {
-        error: errorObj,
-        description,
-        frames,
-        cause: {
-          error: cause,
-          description: cause.value as string,
-          frames: [],
-        }
-      };
-    }
-
-    return {error: errorObj, description, frames};
+    return this.#symbolizedError;
   }
 }