chrome-devtools-frontend 1.0.1642899 → 1.0.1643855

package/front_end/panels/application/components/components.ts

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as AdsView from './AdsView.js';
 import * as BackForwardCacheView from './BackForwardCacheView.js';
 import * as BounceTrackingMitigationsView from './BounceTrackingMitigationsView.js';
 import * as CrashReportContextGrid from './CrashReportContextGrid.js';
@@ -17,6 +18,7 @@ import * as StorageMetadataView from './StorageMetadataView.js';
 import * as TrustTokensView from './TrustTokensView.js';
 
 export {
+  AdsView,
   BackForwardCacheView,
   BounceTrackingMitigationsView,
   CrashReportContextGrid,

package/front_end/panels/application/resourcesSidebar.css

@@ -64,3 +64,14 @@ devtools-icon.navigator-font-tree-item {
 .no-device-bound-session {
   font-style: italic;
 }
+
+.ai-button-container {
+  display: none;
+  position: absolute;
+  z-index: 999;
+  right: var(--sys-size-3);
+}
+
+.tree-outline li:hover .ai-button-container {
+  display: inline-flex;
+}

package/front_end/panels/console/SymbolizedErrorWidget.ts

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import type * as Platform from '../../core/platform/platform.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import type * as StackTrace from '../../models/stack_trace/stack_trace.js';
 import type * as Workspace from '../../models/workspace/workspace.js';
@@ -9,6 +10,8 @@ import * as Components from '../../ui/legacy/components/utils/utils.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Lit from '../../ui/lit/lit.js';
 
+import {ConsoleViewMessage} from './ConsoleViewMessage.js';
+
 const {html, render} = Lit;
 
 export interface ViewInput {
@@ -24,20 +27,64 @@ function renderHeader(content: Lit.LitTemplate|Node|UI.Widget.Widget, isCause: b
   return html`<span class="error-message-text">${content}</span>`;
 }
 
-function renderFramePrefix(
-    frame: StackTrace.StackTrace.ParsedErrorStackFrame,
-    _options: Components.Linkifier.LinkifyOptions): Lit.LitTemplate {
+function formatName(frame: StackTrace.StackTrace.ParsedErrorStackFrame): string {
+  const isInline = frame.isInline;
+  let name = isInline ? (frame.name || '') : (frame.rawName || frame.name || '');
+  const shouldAppendMethodAlias = !isInline && frame.methodName && name && name !== frame.methodName &&
+      !name.endsWith('.' + frame.methodName) && !name.endsWith(' ' + frame.methodName);
+  if (shouldAppendMethodAlias) {
+    name += ` [as ${frame.methodName}]`;
+  }
+  return name;
+}
+
+function renderLinkElement(frame: StackTrace.StackTrace.ParsedErrorStackFrame,
+                           options: Components.Linkifier.LinkifyOptions): HTMLElement|Lit.LitTemplate {
+  if (frame.url || frame.uiSourceCode) {
+    const link = Components.Linkifier.Linkifier.linkifyStackTraceFrame(frame, options);
+    link.tabIndex = -1;
+    return link;
+  }
+  return html`<span>&lt;anonymous&gt;</span>`;
+}
+
+function renderEvalOrigin(frame: StackTrace.StackTrace.ParsedErrorStackFrame,
+                          options: Components.Linkifier.LinkifyOptions): Lit.LitTemplate {
+  const name = formatName(frame);
+  const linkElement = renderLinkElement(frame, options);
+
+  const asyncPrefix = frame.isAsync ? 'async ' : '';
+  const constructorPrefix = frame.isConstructor ? 'new ' : '';
+
+  if (frame.isEval) {
+    const evalOrigin = frame.evalOrigin ? renderEvalOrigin(frame.evalOrigin, options) : '<anonymous>';
+    if (name) {
+      return html`${asyncPrefix}${constructorPrefix}eval at ${name} (${evalOrigin})`;
+    }
+    return html`${asyncPrefix}${constructorPrefix}eval at ${evalOrigin}`;
+  }
+  if (name) {
+    return html`${asyncPrefix}${constructorPrefix}eval at ${name} (${linkElement})`;
+  }
+  return html`${asyncPrefix}${constructorPrefix}eval at ${linkElement}`;
+}
+
+function renderFramePrefix(frame: StackTrace.StackTrace.ParsedErrorStackFrame,
+                           options: Components.Linkifier.LinkifyOptions): Lit.LitTemplate {
   const asyncPrefix = frame.isAsync ? 'async ' : '';
   if (frame.promiseIndex !== undefined) {
     const name = frame.name || 'Promise.all';
     return html`${asyncPrefix}${name} (index ${frame.promiseIndex})`;
   }
   const constructorPrefix = frame.isConstructor ? 'new ' : '';
-  let name = frame.name || '';
-  const isInline = Boolean(frame.rawName) && frame.name !== frame.rawName;
-  if (!isInline && frame.methodName && name && name !== frame.methodName && !name.endsWith('.' + frame.methodName) &&
-      !name.endsWith(' ' + frame.methodName)) {
-    name += ` [as ${frame.methodName}]`;
+  const name = formatName(frame);
+
+  if (frame.isEval) {
+    const evalOrigin = frame.evalOrigin ? renderEvalOrigin(frame.evalOrigin, options) : '<anonymous>';
+    if (name) {
+      return html`${asyncPrefix}${constructorPrefix}${name} (${evalOrigin}, `;
+    }
+    return html`${asyncPrefix}${constructorPrefix}${evalOrigin}, `;
   }
 
   if (name) {
@@ -58,36 +105,43 @@ function renderFrameSuffix(frame: StackTrace.StackTrace.ParsedErrorStackFrame):
 
 const DEFAULT_VIEW = (input: ViewInput, _output: object, target: HTMLElement): void => {
   const renderError = (error: Bindings.SymbolizedError.SymbolizedError, isCause: boolean): Lit.LitTemplate => {
-    if (!(error instanceof Bindings.SymbolizedError.SymbolizedErrorObject)) {
-      console.error('SymbolizedErrorWidget received an unsupported error type:', error);
-      return Lit.nothing;
+    if (error instanceof Bindings.SymbolizedError.UnparsableError) {
+      const fragment = ConsoleViewMessage.linkifyWithCustomLinkifier(
+          error.errorStack,
+          (text: string, url: Platform.DevToolsPath.UrlString, lineNumber?: number, columnNumber?: number) => {
+            const options = {text, lineNumber, columnNumber, ignoreListManager: input.ignoreListManager};
+            const linkElement = Components.Linkifier.Linkifier.linkifyURL(url, options);
+            linkElement.tabIndex = -1;
+            return linkElement;
+          });
+      const header = renderHeader(fragment, isCause);
+      return html`
+        <span class=${isCause ? 'console-message-stack-trace-wrapper' : ''}>${header}</span>
+      `;
     }
+
     const linkOptions: Components.Linkifier.LinkifyOptions = {
       showColumnNumber: true,
       inlineFrameIndex: 0,
       maxLength: UI.UIUtils.MaxLengthForDisplayedURLsInConsole,
       ignoreListManager: input.ignoreListManager,
     };
-    const headerContent = html`${error.message}`;
+
+    let headerContent = html`${error.message}`;
+    if (error.syntaxErrorLocation) {
+      const linkElement = Components.Linkifier.Linkifier.linkifyUILocation(error.syntaxErrorLocation, linkOptions);
+      linkElement.tabIndex = -1;
+      headerContent = html`${error.message} (at ${linkElement})`;
+    }
+
     const header = renderHeader(headerContent, isCause);
     const syncFrames = error.stackTrace.syncFragment.frames;
     // clang-format off
     return html`
       <span class=${isCause ? 'console-message-stack-trace-wrapper' : ''}
       >${header}${syncFrames.length > 0 ? '\n' : ''}${syncFrames.map((frame: StackTrace.StackTrace.ParsedErrorStackFrame, i: number) => {
-          let linkElement: HTMLElement|Lit.LitTemplate = Lit.nothing;
-          let isBuiltin = false;
-          if (frame.promiseIndex !== undefined) {
-            // Promise.all doesn't have a linkable location.
-            isBuiltin = true;
-          } else if (frame.url || frame.uiSourceCode) {
-            const link = Components.Linkifier.Linkifier.linkifyStackTraceFrame(frame, linkOptions);
-            link.tabIndex = -1;
-            linkElement = link;
-          } else {
-            linkElement = html`<span>&lt;anonymous&gt;</span>`;
-            isBuiltin = true;
-          }
+          const isBuiltin = frame.promiseIndex !== undefined || (!frame.url && !frame.uiSourceCode);
+          const linkElement = frame.promiseIndex !== undefined ? Lit.nothing : renderLinkElement(frame, linkOptions);
 
           const newline = i < error.stackTrace.syncFragment.frames.length - 1 ? '\n' : '';
           const frameClass = isBuiltin ? 'formatted-builtin-stack-frame' : 'formatted-stack-frame';

package/front_end/panels/network/NetworkLogView.ts

@@ -2507,7 +2507,11 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
     // (it may be different from the inspected page platform).
     const escapeString = platform === 'win' ? escapeStringWin : escapeStringPosix;
 
-    command.push(escapeString(request.url()).replace(/[[{}\]]/g, '\\$&'));
+    // The shell escaping above protects the *shell* parser, but not curl's own
+    // argv parser: if the (HAR-imported) URL begins with '-', curl will parse
+    // it as an option (e.g. "-K//host/share/file" -> --config UNC path).
+    // Passing the URL via --url forces curl to treat it as a URL operand.
+    command.push('--url ' + escapeString(request.url()).replace(/[[{}\]]/g, '\\$&'));
 
     let inferredMethod = 'GET';
     const data = [];

package/front_end/panels/settings/emulation/DevicesSettingsTab.ts

@@ -177,6 +177,7 @@ export class DevicesSettingsTab extends UI.Widget.VBox implements
     device.horizontal.height = 400;
     device.vertical.width = 400;
     device.vertical.height = 700;
+    device.userAgent = navigator.userAgent;
     this.#customDeviceList.addNewItem(this.emulatedDevicesList.custom().length, device);
   }
 

package/front_end/panels/sources/SourcesPanel.ts

@@ -221,7 +221,7 @@ export class SourcesPanel extends UI.Panel.Panel implements
   #paused?: boolean;
   private switchToPausedTargetTimeout?: number;
   private executionLineLocation?: Bindings.DebuggerWorkspaceBinding.Location|null;
-  private sidebarPaneStack?: UI.View.ViewLocation;
+  private sidebarPaneStack?: UI.ViewManager.StackLocation;
   private tabbedLocationHeader?: Element|null;
   private extensionSidebarPanesContainer?: UI.View.ViewLocation;
   sidebarPaneView?: UI.Widget.VBox|UI.SplitWidget.SplitWidget;
@@ -477,6 +477,7 @@ export class SourcesPanel extends UI.Panel.Panel implements
 
   toggleDebuggerSidebar(): void {
     this.splitWidget.toggleSidebar();
+    this.sidebarPaneStack?.notifyVisibilityChanged(this.splitWidget.sidebarIsShowing());
   }
 
   private debuggerPaused(event: Common.EventTarget.EventTargetEvent<SDK.DebuggerModel.DebuggerModel>): void {

package/front_end/panels/timeline/overlays/components/EntryLabelOverlay.ts

@@ -194,7 +194,7 @@ export class EntryLabelOverlay extends HTMLElement {
   #callTree: AiAssistanceModels.AICallTree.AICallTree|null = null;
   // Creates or gets the setting if it exists.
   #aiAnnotationsEnabledSetting = Common.Settings.Settings.instance().createSetting('ai-annotations-enabled', false);
-  #agent = new AiAssistanceModels.PerformanceAnnotationsAgent.PerformanceAnnotationsAgent({
+  #performanceAnnotations = new AiAssistanceModels.PerformanceAnnotations.PerformanceAnnotations({
     aidaClient: new Host.AidaClient.AidaClient(),
     serverSideLoggingEnabled: isAiAssistanceServerSideLoggingEnabled(),
   });
@@ -254,8 +254,9 @@ export class EntryLabelOverlay extends HTMLElement {
   /**
    * So we can provide a mocked agent in tests. Do not call this method outside of a test!
    */
-  overrideAIAgentForTest(agent: AiAssistanceModels.PerformanceAnnotationsAgent.PerformanceAnnotationsAgent): void {
-    this.#agent = agent;
+  overridePerformanceAnnotationsForTest(performanceAnnotations:
+                                            AiAssistanceModels.PerformanceAnnotations.PerformanceAnnotations): void {
+    this.#performanceAnnotations = performanceAnnotations;
   }
 
   entryHighlightWrapper(): HTMLElement|null {
@@ -534,7 +535,7 @@ export class EntryLabelOverlay extends HTMLElement {
         this.#focusInputBox();
         void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#render);
 
-        this.#label = await this.#agent.generateAIEntryLabel(this.#callTree);
+        this.#label = await this.#performanceAnnotations.generateAIEntryLabel(this.#callTree);
         this.dispatchEvent(new EntryLabelChangeEvent(this.#label));
         this.#inputField.innerText = this.#label;
         this.#placeCursorAtInputEnd();

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: Internal
 Version: N/A
-Revision: 2d046db188ecad76b2859f8baeb9685cb8fe9c08
+Revision: e1605f15bac37245745e5fb8327995ededbe2337
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/third_party/lighthouse/README.chromium

@@ -1,7 +1,7 @@
 Name: Lighthouse
 Short Name: lighthouse
-Version: 13.3.0
-Revision: 7d8dcf5004950cad3faa20664e4a7cf2817bd653
+Version: 13.4.0
+Revision: cb79bea56c4668fd7a338f2f421f87754ee927a2
 Update Mechanism: Manual
 URL: https://github.com/GoogleChrome/lighthouse
 License: Apache-2.0