chrome-devtools-frontend 1.0.1636056 → 1.0.1640418

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -5,6 +5,7 @@
 import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
+import type {UrlString} from '../../../core/platform/DevToolsPath.js';
 import * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
@@ -245,10 +246,11 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
     this.#focus = focus;
   }
 
-  override getOrigin(): string {
+  override getURL(): string {
+    const url = this.#focus.parsedTrace.data.Meta.mainFrameURL;
     try {
-      const url = new URL(this.#focus.parsedTrace.data.Meta.mainFrameURL);
-      return url.origin;
+      new URL(url);
+      return url;
     } catch {
       const {min, max} = this.#focus.parsedTrace.data.Meta.traceBounds;
       return `trace-${min}-${max}`;
@@ -609,7 +611,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
           return `[${linkText}](#${eventKey})`;
         }
 
-        const event = focus.lookupEvent(linkDest as Trace.Types.File.SerializableKey);
+        const event = focus.lookupEvent(linkDest);
         if (event) {
           return `[${linkText}](#${linkDest})`;
         }
@@ -727,6 +729,13 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
     yield* super.run(initialQuery, options);
   }
 
+  override clearCache(): void {
+    // Clear the function call cache to prevent stashed tool execution results
+    // (which might contain cross-origin resource content fetched before navigation
+    // was detected) from being replayed as facts in subsequent runs.
+    this.#functionCallCacheForFocus.clear();
+  }
+
   #createFactForTraceSummary(): void {
     if (!this.#formatter) {
       return;
@@ -1055,7 +1064,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       },
       handler: async params => {
         debugLog('Function call: getEventByKey', params);
-        const event = focus.lookupEvent(params.eventKey as Trace.Types.File.SerializableKey);
+        const event = focus.lookupEvent(params.eventKey);
         if (!event) {
           return {error: 'Invalid eventKey'};
         }
@@ -1245,7 +1254,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
           throw new Error('missing formatter');
         }
 
-        const event = focus.lookupEvent(args.eventKey as Trace.Types.File.SerializableKey);
+        const event = focus.lookupEvent(args.eventKey);
         if (!event) {
           return {error: 'Invalid eventKey'};
         }
@@ -1350,7 +1359,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       });
     }
 
-    this.declareFunction<{scriptUrl: string, line: number, column: number}, {result: string}>('getFunctionCode', {
+    this.declareFunction<{scriptUrl: UrlString, line: number, column: number}, {result: string}>('getFunctionCode', {
       description:
           'Returns the code for a function defined at the given location. The result is annotated with the runtime performance of each line of code.',
       parameters: {
@@ -1412,14 +1421,25 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
 
         const key = `getFunctionCode('${args.scriptUrl}', ${args.line}, ${args.column})`;
         this.#cacheFunctionResult(focus, key, result);
-        return {result: {result}};
+        return {
+          result: {result},
+          widgets: [{
+            name: 'SOURCE_CODE',
+            data: {
+              url: args.scriptUrl,
+              line: args.line,
+              column: args.column,
+              code: code.code,
+            },
+          }],
+        };
       },
     });
 
     const isFresh = Tracing.FreshRecording.Tracker.instance().recordingIsFresh(parsedTrace);
     const isTraceApp = Root.Runtime.Runtime.isTraceApp();
 
-    this.declareFunction<{url: string}, {content: string}>('getResourceContent', {
+    this.declareFunction<{url: UrlString}, {content: string}>('getResourceContent', {
       description:
           'Returns the content of the resource with the given url. Only use this for text resource types. This function is helpful for getting script contents in order to further analyze main thread activity and suggest code improvements. When analyzing the main thread activity, always call this function to get more detail. Always call this function when asked to provide specifics about what is happening in the code. Never ask permission to call this function, just do it.',
       parameters: {
@@ -1469,7 +1489,16 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
 
         const key = `getResourceContent(${args.url})`;
         this.#cacheFunctionResult(focus, key, content);
-        return {result: {content}};
+        return {
+          result: {content},
+          widgets: [{
+            name: 'SOURCE_CODE',
+            data: {
+              url: args.url,
+              code: content,
+            },
+          }],
+        };
       },
     });
 
@@ -1495,7 +1524,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
         },
         handler: async params => {
           debugLog('Function call: selectEventByKey', params);
-          const event = focus.lookupEvent(params.eventKey as Trace.Types.File.SerializableKey);
+          const event = focus.lookupEvent(params.eventKey);
           if (!event) {
             return {error: 'Invalid eventKey'};
           }
@@ -1605,7 +1634,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
     let requestId = undefined;
     const focus = this.context?.getItem();
     if (focus) {
-      const event = focus.lookupEvent(eventKey as Trace.Types.File.SerializableKey);
+      const event = focus.lookupEvent(eventKey);
       if (event && Trace.Types.Events.isSyntheticNetworkRequest(event)) {
         requestId = event.args.data.requestId;
       }