chrome-devtools-frontend 1.0.1635876 → 1.0.1636056

package/.agents/skills/verification/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: devtools-verification
-description: MANDATORY: Activate this skill ANY TIME you need to build the project, run tests, or verify code health in DevTools. You MUST use this skill before executing commands like npm test, npm run build, autoninja, or linters, as it contains critical, repository-specific instructions on how to correctly format these commands, filter test runs, and interpret failures.
+description: "MANDATORY: Activate this skill ANY TIME you need to build the project, run tests, or verify code health in DevTools. You MUST use this skill before executing commands like npm test, npm run build, autoninja, or linters, as it contains critical, repository-specific instructions on how to correctly format these commands, filter test runs, and interpret failures."
 ---
 
 # Instructions on how to verify your changes

package/front_end/core/i18n/collect-ui-strings.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import glob from 'glob';
+import {globSync} from 'node:fs';
 import * as path from 'node:path';
 import yargs from 'yargs';
 import {hideBin} from 'yargs/helpers';
@@ -68,9 +68,9 @@ for (const directory of inputDirectories) {
     ...collectAllStringsInDir(directory),
   };
 
-  const fs = glob.sync('**/*.{js,ts,gn}', {
+  const fs = globSync('**/*.{js,ts,gn}', {
     cwd: directory,
-    ignore: IGNORED_PATH_COMPONENTS,
+    exclude: IGNORED_PATH_COMPONENTS,
   });
   files.push(...fs.map(f => path.join(directory, f)));
 }

package/front_end/core/root/Runtime.ts

@@ -625,6 +625,10 @@ interface UseGcaApi {
   enabled: boolean;
 }
 
+interface DevToolsAIV2Architecture {
+  enabled: boolean;
+}
+
 interface DevToolsProtocolMonitor {
   enabled: boolean;
 }
@@ -663,6 +667,7 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsAiAssistanceAccessibilityAgent: HostConfigAiAssistanceAccessibilityAgent,
   devToolsAiAssistanceStorageAgent: HostConfigAiAssistanceStorageAgent,
   devToolsAiAssistanceV2: HostConfigAiAssistanceV2,
+  devToolsAIV2Architecture: DevToolsAIV2Architecture,
   devToolsAiCodeCompletion: HostConfigAiCodeCompletion,
   devToolsAiCodeGeneration: HostConfigAiCodeGeneration,
   devToolsAiCodeCompletionStyles: HostConfigAiCodeCompletionStyles,

package/front_end/models/ai_assistance/agents/AccessibilityAgent.ts

@@ -29,25 +29,6 @@ import {
   JavascriptExecutor
 } from './ExecuteJavascript.js';
 
-/**
- * The subset of computed CSS properties relevant to accessibility audits.
- * These are used to filter the Computed Styles widget in the AI Chat panel to keep it focused and minimal.
- */
-const ACCESSIBILITY_CSS_PROPERTIES = [
-  'color',
-  'background-color',
-  'display',
-  'visibility',
-  'opacity',
-  'clip',
-  'clip-path',
-  'font-size',
-  'font-weight',
-  'line-height',
-  'letter-spacing',
-  'text-transform',
-];
-
 /**
  * WARNING: preamble defined in code is only used when userTier is
  * TESTERS. Otherwise, a server-side preamble is used (see
@@ -486,20 +467,13 @@ export class AccessibilityAgent extends AiAgent<LHModel.ReporterTypes.ReportJSON
         };
 
         const widgets: AiWidget[] = [];
-        const cssModel = node.domModel().cssModel();
-        const styles = await cssModel.getComputedStyle(node.id);
-        const matchedStyles = await cssModel.getMatchedStyles(node.id);
-        if (styles && matchedStyles) {
-          widgets.push({
-            name: 'COMPUTED_STYLES',
-            data: {
-              computedStyles: styles,
-              backendNodeId: node.backendNodeId(),
-              matchedCascade: matchedStyles,
-              properties: ACCESSIBILITY_CSS_PROPERTIES,
-            },
-          });
-        }
+        const snapshot = await node.takeSnapshot();
+        widgets.push({
+          name: 'DOM_TREE',
+          data: {
+            root: snapshot,
+          },
+        });
 
         return {
           result: JSON.stringify(result, null, 2),

package/front_end/models/ai_assistance/agents/AiAgent.ts

@@ -330,10 +330,17 @@ export interface LighthouseReportAiWidget {
   };
 }
 
-// This type will grow as we add more widgets.
-export type AiWidget =
-    ComputedStyleAiWidget|CoreVitalsAiWidget|StylePropertiesAiWidget|DomTreeAiWidget|PerformanceTraceAiWidget|
-    PerfInsightAiWidget|TimelineRangeSummaryAiWidget|BottomUpTreeAiWidget|SourceFileAiWidget|LighthouseReportAiWidget;
+export interface TimelineEventSummaryAiWidget {
+  name: 'TIMELINE_EVENT_SUMMARY';
+  data: {
+    event: Trace.Types.Events.Event,
+    parsedTrace: Trace.TraceModel.ParsedTrace,
+  };
+}
+
+export type AiWidget = ComputedStyleAiWidget|CoreVitalsAiWidget|StylePropertiesAiWidget|DomTreeAiWidget|
+    PerformanceTraceAiWidget|PerfInsightAiWidget|TimelineRangeSummaryAiWidget|BottomUpTreeAiWidget|SourceFileAiWidget|
+    LighthouseReportAiWidget|TimelineEventSummaryAiWidget;
 
 export type FunctionCallHandlerResult<Result> = {
   requiresApproval: true,

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -1093,7 +1093,16 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
 
         const key = `getEventByKey('${params.eventKey}')`;
         this.#cacheFunctionResult(focus, key, details);
-        return {result: {details}};
+        return {
+          result: {details},
+          widgets: [{
+            name: 'TIMELINE_EVENT_SUMMARY',
+            data: {
+              event,
+              parsedTrace,
+            },
+          }],
+        };
       },
     });
 
@@ -1493,7 +1502,16 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
 
           const revealable = new SDK.TraceObject.RevealableEvent(event);
           await Common.Revealer.reveal(revealable);
-          return {result: {success: true}};
+          return {
+            result: {success: true},
+            widgets: [{
+              name: 'TIMELINE_EVENT_SUMMARY',
+              data: {
+                event,
+                parsedTrace,
+              },
+            }],
+          };
         },
       });
     }

package/front_end/panels/ai_assistance/components/ChatMessage.ts

@@ -15,7 +15,7 @@ import type * as Protocol from '../../../generated/protocol.js';
 import type {
   AiWidget, BottomUpTreeAiWidget, ComputedStyleAiWidget, CoreVitalsAiWidget, DomTreeAiWidget, LighthouseReportAiWidget,
   PerfInsightAiWidget, PerformanceTraceAiWidget, SourceFileAiWidget, StylePropertiesAiWidget,
-  TimelineRangeSummaryAiWidget} from '../../../models/ai_assistance/agents/AiAgent.js';
+  TimelineEventSummaryAiWidget, TimelineRangeSummaryAiWidget} from '../../../models/ai_assistance/agents/AiAgent.js';
 import * as AiAssistanceModel from '../../../models/ai_assistance/ai_assistance.js';
 import * as ComputedStyle from '../../../models/computed_style/computed_style.js';
 import * as Trace from '../../../models/trace/trace.js';
@@ -248,6 +248,14 @@ const UIStringsNotTranslate = {
    * @description Accessible label for the reveal button in the Lighthouse report widget.
    */
   revealLighthouse: 'Reveal Lighthouse report',
+  /**
+   * @description Title for the Timeline event summary widget.
+   */
+  timelineEventSummary: 'Event summary',
+  /**
+   * @description Accessible label for the reveal button in the Timeline event summary widget.
+   */
+  revealTimelineEventSummary: 'Reveal event',
   /**
    * @description Title for the LCP breakdown widget.
    */
@@ -1454,6 +1462,8 @@ export function getWidgetSignature(widget: AiWidget): string {
       return `${widget.name}:${widget.data.uiSourceCode.url()}`;
     case 'LIGHTHOUSE_REPORT':
       return `${widget.name}:${widget.data.report.fetchTime}`;
+    case 'TIMELINE_EVENT_SUMMARY':
+      return `${widget.name}:${widget.data.event.ts}:${widget.data.event.name}`;
     default:
       Platform.assertNever(widget, 'Unknown AiWidget name');
   }
@@ -1543,6 +1553,9 @@ async function renderWidgets(
       case 'LIGHTHOUSE_REPORT':
         response = await makeLighthouseReportWidget(widgetData);
         break;
+      case 'TIMELINE_EVENT_SUMMARY':
+        response = await makeTimelineEventSummaryWidget(widgetData);
+        break;
       default:
         Platform.assertNever(widgetData, 'Unknown AiWidget name');
     }
@@ -2100,3 +2113,21 @@ async function makeLighthouseReportWidget(widgetData: LighthouseReportAiWidget):
     jslogContext: snapshotReport ? 'lighthouse-snapshot-report-widget' : 'lighthouse-report-widget',
   };
 }
+
+async function makeTimelineEventSummaryWidget(widgetData: TimelineEventSummaryAiWidget):
+    Promise<WidgetMakerResponse|null> {
+  const renderedWidget = html`<devtools-widget class="timeline-event-summary-widget" ${widget(() => {
+    return Timeline.TimelineDetailsView.TimelineDetailsPane.makeEventWidget(
+        widgetData.data.event,
+        widgetData.data.parsedTrace,
+    );
+  })}></devtools-widget>`;
+
+  return {
+    renderedWidget,
+    revealable: new SDK.TraceObject.RevealableEvent(widgetData.data.event),
+    accessibleRevealLabel: lockedString(UIStringsNotTranslate.revealTimelineEventSummary),
+    title: lockedString(UIStringsNotTranslate.timelineEventSummary),
+    jslogContext: 'timeline-event-summary-widget',
+  };
+}

package/front_end/panels/network/NetworkLogView.ts

@@ -2534,7 +2534,10 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
         // value tells curl to not set the header at all. To post an empty
         // header, you have to terminate it with a semicolon.
         command.push('-H ' + escapeString(name + ';'));
-      } else if (name.toLowerCase() === 'cookie') {
+      } else if (name.toLowerCase() === 'cookie' && value.includes('=')) {
+        // If value contains no '=', curl treats it as a filename to read
+        // cookies from, which would be a security risk. Fall back to -H in
+        // that case.
         command.push('-b ' + escapeString(value));
       } else {
         command.push('-H ' + escapeString(name + ': ' + value));

package/front_end/panels/sources/PersistenceActions.ts

@@ -115,14 +115,28 @@ export class ContextMenuProvider implements
     const networkPersistenceManager = Persistence.NetworkPersistenceManager.NetworkPersistenceManager.instance();
 
     const binding = uiSourceCode && Persistence.Persistence.PersistenceImpl.instance().binding(uiSourceCode);
-    const fileURL = binding ? binding.fileSystem.contentURL() : contentProvider.contentURL();
+    // If contentProvider is already a FileSystem UISourceCode, there's a small chance that uiSourceCodeForURL
+    // might return a Network UISourceCode instead (e.g. if they share the same URL but aren't currently bound
+    // and the Network project represents the URL first in the lookup list).
+    // In this case, the binding will be null. To ensure "Open in containing folder" is still appended when
+    // right-clicking the FileSystem file in the Workspace tree, we fall back to contentProvider.
+    const fileSystemUISourceCode = binding ?
+        binding.fileSystem :
+        (contentProvider instanceof Workspace.UISourceCode.UISourceCode &&
+                 contentProvider.project().type() === Workspace.Workspace.projectTypes.FileSystem ?
+             contentProvider :
+             uiSourceCode);
 
-    if (Common.ParsedURL.schemeIs(fileURL, 'file:')) {
-      const path = Common.ParsedURL.ParsedURL.urlToRawPathString(fileURL, Host.Platform.isWin());
-      contextMenu.revealSection().appendItem(
-          i18nString(UIStrings.openInContainingFolder),
-          () => Host.InspectorFrontendHost.InspectorFrontendHostInstance.showItemInFolder(path),
-          {jslogContext: 'open-in-containing-folder'});
+    if (fileSystemUISourceCode &&
+        fileSystemUISourceCode.project().type() === Workspace.Workspace.projectTypes.FileSystem) {
+      const fileURL = fileSystemUISourceCode.contentURL();
+      if (Common.ParsedURL.schemeIs(fileURL, 'file:')) {
+        const path = Common.ParsedURL.ParsedURL.urlToRawPathString(fileURL, Host.Platform.isWin());
+        contextMenu.revealSection().appendItem(
+            i18nString(UIStrings.openInContainingFolder),
+            () => Host.InspectorFrontendHost.InspectorFrontendHostInstance.showItemInFolder(path),
+            {jslogContext: 'open-in-containing-folder'});
+      }
     }
 
     if (contentProvider instanceof Workspace.UISourceCode.UISourceCode &&

package/front_end/panels/timeline/TimelineDetailsView.ts

@@ -93,6 +93,38 @@ export class TimelineDetailsPane extends
   #onTraceBoundsChangeBound = this.#onTraceBoundsChange.bind(this);
   #entityMapper: Trace.EntityMapper.EntityMapper|null = null;
 
+  static makeEventWidget(
+      event: Trace.Types.Events.Event,
+      parsedTrace: Trace.TraceModel.ParsedTrace,
+      ): TimelineDetailsPane {
+    // Provide a mock delegate to satisfy the constructor requirements.
+    // These delegate interactions are not relevant for an AI assistant widget.
+    const mockDelegate = {
+      select: () => {},
+      zoomEvent: () => {},
+      element: document.createElement('div'),
+      set3PCheckboxDisabled: () => {},
+      selectEntryAtTime: () => {},
+      highlightEvent: () => {},
+    };
+    const pane = new TimelineDetailsPane(mockDelegate);
+    pane.hideHeader();
+    const entityMapper = new Trace.EntityMapper.EntityMapper(parsedTrace);
+    void pane
+        .setModel({
+          parsedTrace,
+          selectedEvents: [event],
+          eventToRelatedInsightsMap: null,
+          entityMapper,
+        })
+        .then(() => {
+          void pane.setSelection({
+            event,
+          });
+        });
+    return pane;
+  }
+
   constructor(delegate: TimelineModeViewDelegate) {
     super();
     this.registerRequiredCSS(detailsViewStyles);
@@ -343,6 +375,10 @@ export class TimelineDetailsPane extends
     return this.tabbedPane.headerElement();
   }
 
+  hideHeader(): void {
+    this.tabbedPane.headerElement().classList.add('hidden');
+  }
+
   setPreferredTab(tabId: string): void {
     this.preferredTabId = tabId;
   }

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: Internal
 Version: N/A
-Revision: 268971579b74f0369f828111e6c8f5bafbacd5ee
+Revision: 59215b2081aea1f087ea0f9e9d428c2eb9b41876
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/ui/legacy/Dialog.ts

@@ -130,6 +130,7 @@ export class Dialog extends Common.ObjectWrapper.eventMixin<EventTypes, typeof G
       iconName: 'cross',
       accessibleLabel: i18nString(UIStrings.close),
       jslogContext: 'dialog-close',
+      title: i18nString(UIStrings.close),
     };
     button.classList.add('dialog-close-button');
     button.addEventListener('click', this.hide.bind(this));

package/front_end/ui/legacy/UIUtils.ts

@@ -382,6 +382,10 @@ export function markBeingEdited(element: Element, value: boolean): boolean {
   return true;
 }
 
+export function resetElementsBeingEditedForTest(): void {
+  elementsBeingEdited.clear();
+}
+
 const elementsBeingEdited = new Set<Element>();
 
 // Avoids Infinity, NaN, and scientific notation (e.g. 1e20), see crbug.com/81165.

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -4037,6 +4037,7 @@ export const knownContextValues = new Set([
   'timeline-dim-unrelated-events',
   'timeline-disable-js-sampling',
   'timeline-enhanced-traces',
+  'timeline-event-summary-widget',
   'timeline-experimental-insights',
   'timeline-flamechart-main-view-group-expansion',
   'timeline-flamechart-network-view-group-expansion',

package/package.json

@@ -41,7 +41,6 @@
     "@types/emscripten": "1.39.4",
     "@types/estree": "1.0.8",
     "@types/filesystem": "0.0.36",
-    "@types/glob": "7.2.0",
     "@types/karma-chai-sinon": "0.1.20",
     "@types/mocha": "10.0.10",
     "@types/node": "24.10.0",
@@ -62,7 +61,6 @@
     "eslint-plugin-jsdoc": "61.2.1",
     "eslint-plugin-lit": "2.1.1",
     "eslint-plugin-mocha": "10.5.0",
-    "glob": "7.1.7",
     "globals": "16.5.0",
     "js-yaml": "4.1.1",
     "karma": "6.4.4",
@@ -96,5 +94,5 @@
     "yargs": "17.7.2",
     "js-rouge": "3.2.0"
   },
-  "version": "1.0.1635876"
+  "version": "1.0.1636056"
 }