chrome-devtools-frontend 1.0.1632065 → 1.0.1635876

package/front_end/generated/SupportedCSSProperties.js

@@ -667,6 +667,7 @@ export const generatedProperties = [
    "rx",
    "ry",
    "scale",
+   "scroll-axis-lock",
    "scroll-behavior",
    "scroll-initial-target",
    "scroll-margin-block-end",
@@ -1967,6 +1968,18 @@ export const generatedProperties = [
   ],
   "name": "corner"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-end-start-radius",
+   "corner-end-start-shape",
+   "border-end-end-radius",
+   "corner-end-end-shape"
+  ],
+  "name": "corner-block-end"
+ },
  {
   "longhands": [
    "corner-end-start-shape",
@@ -1974,6 +1987,18 @@ export const generatedProperties = [
   ],
   "name": "corner-block-end-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-start-radius",
+   "corner-start-start-shape",
+   "border-start-end-radius",
+   "corner-start-end-shape"
+  ],
+  "name": "corner-block-start"
+ },
  {
   "longhands": [
    "corner-start-start-shape",
@@ -1981,6 +2006,28 @@ export const generatedProperties = [
   ],
   "name": "corner-block-start-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-bottom-left-radius",
+   "corner-bottom-left-shape",
+   "border-bottom-right-radius",
+   "corner-bottom-right-shape"
+  ],
+  "name": "corner-bottom"
+ },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-bottom-left-radius",
+   "corner-bottom-left-shape"
+  ],
+  "name": "corner-bottom-left"
+ },
  {
   "keywords": [
    "notch",
@@ -1992,6 +2039,16 @@ export const generatedProperties = [
   ],
   "name": "corner-bottom-left-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-bottom-right-radius",
+   "corner-bottom-right-shape"
+  ],
+  "name": "corner-bottom-right"
+ },
  {
   "keywords": [
    "notch",
@@ -2010,12 +2067,44 @@ export const generatedProperties = [
   ],
   "name": "corner-bottom-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-end-end-radius",
+   "corner-end-end-shape"
+  ],
+  "name": "corner-end-end"
+ },
  {
   "name": "corner-end-end-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-end-start-radius",
+   "corner-end-start-shape"
+  ],
+  "name": "corner-end-start"
+ },
  {
   "name": "corner-end-start-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-end-radius",
+   "corner-start-end-shape",
+   "border-end-end-radius",
+   "corner-end-end-shape"
+  ],
+  "name": "corner-inline-end"
+ },
  {
   "longhands": [
    "corner-start-end-shape",
@@ -2023,6 +2112,18 @@ export const generatedProperties = [
   ],
   "name": "corner-inline-end-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-start-radius",
+   "corner-start-start-shape",
+   "border-end-start-radius",
+   "corner-end-start-shape"
+  ],
+  "name": "corner-inline-start"
+ },
  {
   "longhands": [
    "corner-start-start-shape",
@@ -2030,6 +2131,18 @@ export const generatedProperties = [
   ],
   "name": "corner-inline-start-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-left-radius",
+   "corner-top-left-shape",
+   "border-bottom-left-radius",
+   "corner-bottom-left-shape"
+  ],
+  "name": "corner-left"
+ },
  {
   "longhands": [
    "corner-top-left-shape",
@@ -2037,6 +2150,18 @@ export const generatedProperties = [
   ],
   "name": "corner-left-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-right-radius",
+   "corner-top-right-shape",
+   "border-bottom-right-radius",
+   "corner-bottom-right-shape"
+  ],
+  "name": "corner-right"
+ },
  {
   "longhands": [
    "corner-top-right-shape",
@@ -2053,12 +2178,54 @@ export const generatedProperties = [
   ],
   "name": "corner-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-end-radius",
+   "corner-start-end-shape"
+  ],
+  "name": "corner-start-end"
+ },
  {
   "name": "corner-start-end-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-start-radius",
+   "corner-start-start-shape"
+  ],
+  "name": "corner-start-start"
+ },
  {
   "name": "corner-start-start-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-left-radius",
+   "corner-top-left-shape",
+   "border-top-right-radius",
+   "corner-top-right-shape"
+  ],
+  "name": "corner-top"
+ },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-left-radius",
+   "corner-top-left-shape"
+  ],
+  "name": "corner-top-left"
+ },
  {
   "keywords": [
    "notch",
@@ -2070,6 +2237,16 @@ export const generatedProperties = [
   ],
   "name": "corner-top-left-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-right-radius",
+   "corner-top-right-shape"
+  ],
+  "name": "corner-top-right"
+ },
  {
   "keywords": [
    "notch",
@@ -3246,7 +3423,7 @@ export const generatedProperties = [
  },
  {
   "keywords": [
-   "none"
+   "auto"
   ],
   "name": "max-lines"
  },
@@ -4080,6 +4257,13 @@ export const generatedProperties = [
  {
   "name": "scale"
  },
+ {
+  "keywords": [
+   "auto",
+   "none"
+  ],
+  "name": "scroll-axis-lock"
+ },
  {
   "keywords": [
    "auto",
@@ -5777,6 +5961,26 @@ export const generatedPropertyValues = {
    "normal"
   ]
  },
+ "corner-block-end": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-block-start": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-bottom": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-bottom-left": {
+  "values": [
+   "normal"
+  ]
+ },
  "corner-bottom-left-shape": {
   "values": [
    "notch",
@@ -5787,6 +5991,11 @@ export const generatedPropertyValues = {
    "square"
   ]
  },
+ "corner-bottom-right": {
+  "values": [
+   "normal"
+  ]
+ },
  "corner-bottom-right-shape": {
   "values": [
    "notch",
@@ -5797,6 +6006,56 @@ export const generatedPropertyValues = {
    "square"
   ]
  },
+ "corner-end-end": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-end-start": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-inline-end": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-inline-start": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-left": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-right": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-start-end": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-start-start": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-top": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-top-left": {
+  "values": [
+   "normal"
+  ]
+ },
  "corner-top-left-shape": {
   "values": [
    "notch",
@@ -5807,6 +6066,11 @@ export const generatedPropertyValues = {
    "square"
   ]
  },
+ "corner-top-right": {
+  "values": [
+   "normal"
+  ]
+ },
  "corner-top-right-shape": {
   "values": [
    "notch",
@@ -6505,7 +6769,7 @@ export const generatedPropertyValues = {
  },
  "max-lines": {
   "values": [
-   "none"
+   "auto"
   ]
  },
  "max-width": {
@@ -6910,6 +7174,12 @@ export const generatedPropertyValues = {
    "auto"
   ]
  },
+ "scroll-axis-lock": {
+  "values": [
+   "auto",
+   "none"
+  ]
+ },
  "scroll-behavior": {
   "values": [
    "auto",

package/front_end/generated/protocol-mapping.d.ts

@@ -2660,7 +2660,6 @@ export namespace ProtocolMapping {
       returnType: void;
     };
     /**
-     * TODO: OBSOLETE: To remove when setPressureDataOverride is merged.
      * Provides a given pressure state that will be processed and eventually be
      * delivered to PressureObserver users. |source| must have been previously
      * overridden by setPressureSourceOverrideEnabled.
@@ -2669,15 +2668,6 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.Emulation.SetPressureStateOverrideRequest];
       returnType: void;
     };
-    /**
-     * Provides a given pressure data set that will be processed and eventually be
-     * delivered to PressureObserver users. |source| must have been previously
-     * overridden by setPressureSourceOverrideEnabled.
-     */
-    'Emulation.setPressureDataOverride': {
-      paramsType: [Protocol.Emulation.SetPressureDataOverrideRequest];
-      returnType: void;
-    };
     /**
      * Overrides the Idle state.
      */

package/front_end/generated/protocol-proxy-api.d.ts

@@ -1762,20 +1762,12 @@ declare namespace ProtocolProxyApi {
     invoke_setPressureSourceOverrideEnabled(params: Protocol.Emulation.SetPressureSourceOverrideEnabledRequest): Promise<Protocol.ProtocolResponseWithError>;
 
     /**
-     * TODO: OBSOLETE: To remove when setPressureDataOverride is merged.
      * Provides a given pressure state that will be processed and eventually be
      * delivered to PressureObserver users. |source| must have been previously
      * overridden by setPressureSourceOverrideEnabled.
      */
     invoke_setPressureStateOverride(params: Protocol.Emulation.SetPressureStateOverrideRequest): Promise<Protocol.ProtocolResponseWithError>;
 
-    /**
-     * Provides a given pressure data set that will be processed and eventually be
-     * delivered to PressureObserver users. |source| must have been previously
-     * overridden by setPressureSourceOverrideEnabled.
-     */
-    invoke_setPressureDataOverride(params: Protocol.Emulation.SetPressureDataOverrideRequest): Promise<Protocol.ProtocolResponseWithError>;
-
     /**
      * Overrides the Idle state.
      */

package/front_end/generated/protocol.ts

@@ -7395,12 +7395,6 @@ export namespace Emulation {
     state: PressureState;
   }
 
-  export interface SetPressureDataOverrideRequest {
-    source: PressureSource;
-    state: PressureState;
-    ownContributionEstimate?: number;
-  }
-
   export interface SetIdleOverrideRequest {
     /**
      * Mock isUserActive
@@ -17136,7 +17130,6 @@ export namespace Preload {
     PrefetchResponseUsed = 'PrefetchResponseUsed',
     PrefetchSuccessfulButNotUsed = 'PrefetchSuccessfulButNotUsed',
     PrefetchNotUsedProbeFailed = 'PrefetchNotUsedProbeFailed',
-    PrefetchCancelledOnUserNavigation = 'PrefetchCancelledOnUserNavigation',
   }
 
   /**
@@ -19100,6 +19093,11 @@ export namespace Target {
      * the type of "page", this may be set to "prerender".
      */
     subtype?: string;
+    /**
+     * Embedder-specific target metadata. This is only set for targets of
+     * type "tab".
+     */
+    embedderData?: any;
   }
 
   /**

package/front_end/models/ai_assistance/AiConversation.ts

@@ -429,16 +429,7 @@ export class AiConversation {
         throw new Error('cross-origin context data should not be included');
       }
 
-      const userQuery: UserQuery = {
-        type: ResponseType.USER_QUERY,
-        query: initialQuery,
-        imageInput: options.multimodalInput?.input,
-        imageId: options.multimodalInput?.id,
-      };
-      void this.addHistoryItem(userQuery);
-      yield userQuery;
-
-      yield* this.#runAgent(initialQuery, options);
+      yield* this.#runAgent(initialQuery, options, {isInitialCall: true});
     } finally {
       targetManager.removeModelListener(
           SDK.ResourceTreeModel.ResourceTreeModel, SDK.ResourceTreeModel.Events.PrimaryPageChanged, listener, this);
@@ -456,6 +447,7 @@ export class AiConversation {
             signal?: AbortSignal,
             multimodalInput?: MultimodalInput,
           } = {},
+          runOptions: {isInitialCall?: boolean} = {},
           ): AsyncGenerator<ResponseData, void, void> {
     this.#setOriginIfEmpty(this.selectedContext?.getOrigin());
     if (this.isBlockedByOrigin) {
@@ -466,6 +458,17 @@ export class AiConversation {
       return;
     }
 
+    if (runOptions.isInitialCall) {
+      const userQuery: UserQuery = {
+        type: ResponseType.USER_QUERY,
+        query: initialQuery,
+        imageInput: options.multimodalInput?.input,
+        imageId: options.multimodalInput?.id,
+      };
+      void this.addHistoryItem(userQuery);
+      yield userQuery;
+    }
+
     function shouldAddToHistory(data: ResponseData): boolean {
       if (data.type === ResponseType.CONTEXT_CHANGE) {
         return false;
@@ -499,7 +502,9 @@ export class AiConversation {
       // requery with the specialized agent.
       if (data.type === ResponseType.CONTEXT_CHANGE) {
         this.setContext(data.context);
-        yield* this.#runAgent(this.#getQueryAfterSelection(initialQuery, data.description), options);
+        yield*
+            this.#runAgent(
+                this.#getQueryAfterSelection(initialQuery, data.description), options, {isInitialCall: false});
         return;
       }
     }

package/front_end/models/ai_assistance/agents/AccessibilityAgent.ts

@@ -236,7 +236,18 @@ export class AccessibilityAgent extends AiAgent<LHModel.ReporterTypes.ReportJSON
     if (!nodeId) {
       return null;
     }
-    return domModel.nodeForId(nodeId);
+    const node = domModel.nodeForId(nodeId);
+    if (!node) {
+      return null;
+    }
+
+    const resourceTreeModel = target.model(SDK.ResourceTreeModel.ResourceTreeModel);
+    const mainFrameId = resourceTreeModel?.mainFrame?.id;
+    if (node.frameId() !== mainFrameId) {
+      return null;
+    }
+
+    return node;
   }
 
   #declareFunctions(): void {
@@ -281,7 +292,7 @@ export class AccessibilityAgent extends AiAgent<LHModel.ReporterTypes.ReportJSON
         const audits = new LighthouseFormatter().audits(report, 'accessibility');
         return {
           result: {audits},
-          widgets: [{name: 'LIGHTHOUSE_REPORT', data: {report}}],
+          widgets: [{name: 'LIGHTHOUSE_REPORT', data: {report, snapshotReport: true}}],
         };
       }
     });

package/front_end/models/ai_assistance/agents/AiAgent.ts

@@ -13,6 +13,8 @@ import type * as Trace from '../../trace/trace.js';
 import type * as Workspace from '../../workspace/workspace.js';
 import {debugLog, isStructuredLogEnabled} from '../debug.js';
 
+const MAX_SUGGESTION_LENGTH = 200;
+
 export const enum ResponseType {
   CONTEXT = 'context',
   TITLE = 'title',
@@ -35,6 +37,21 @@ export const enum ErrorType {
   CROSS_ORIGIN = 'cross-origin'
 }
 
+/**
+ * Returns true if the origin is considered opaque and should be blocked from
+ * AI assistance to prevent potential data leakage.
+ *
+ * @see https://crbug.com/513732588
+ */
+export function isOpaqueOrigin(origin: string): boolean {
+  /**
+   * Origins starting with 'about' (like about:blank or about:srcdoc) are
+   * considered opaque. 'about://' is the sentinel used by DevTools
+   * ParsedURL.securityOrigin() for these.
+   */
+  return origin === 'null' || origin === 'data:' || origin.startsWith('about') || origin.startsWith('detached');
+}
+
 export const enum MultimodalInputType {
   SCREENSHOT = 'screenshot',
   UPLOADED_IMAGE = 'uploaded-image',
@@ -185,15 +202,30 @@ export abstract class ConversationContext<T> {
   abstract getItem(): T;
   abstract getTitle(): string;
 
-  isOriginAllowed(agentOrigin: string|undefined): boolean {
-    if (!agentOrigin) {
+  /**
+   * Returns true if this data context (e.g., a DOM node or Network Request) is
+   * allowed to be included in a conversation that is locked to the provided
+   * `establishedOrigin`.
+   *
+   * A conversation is "locked" to an origin once the first query is made.
+   * This method ensures that we don't mix data from different origins in the
+   * same conversation.
+   *
+   * @param establishedOrigin The origin that the current conversation is locked to.
+   * If undefined, the conversation has not yet been locked to an origin.
+   */
+  isOriginAllowed(establishedOrigin: string|undefined): boolean {
+    const dataOrigin = this.getOrigin();
+    // Opaque origins are never allowed to be used as context.
+    if (isOpaqueOrigin(dataOrigin)) {
+      return false;
+    }
+    // If no origin is established yet, this context will be the one to lock the conversation.
+    if (!establishedOrigin) {
       return true;
     }
-    // Currently does not handle opaque origins because they
-    // are not available to DevTools, instead checks
-    // that serialization of the origin is the same
-    // https://html.spec.whatwg.org/#ascii-serialisation-of-an-origin.
-    return this.getOrigin() === agentOrigin;
+    // Only allow data that matches the origin the conversation is already locked to.
+    return dataOrigin === establishedOrigin;
   }
 
   /**
@@ -294,6 +326,7 @@ export interface LighthouseReportAiWidget {
   name: 'LIGHTHOUSE_REPORT';
   data: {
     report: LHModel.ReporterTypes.ReportJSON,
+    snapshotReport?: boolean,
   };
 }
 
@@ -545,8 +578,7 @@ export abstract class AiAgent<T> {
       const trimmed = line.trim();
       if (trimmed.startsWith('SUGGESTIONS:')) {
         try {
-          // TODO: Do basic validation this is an array with strings
-          suggestions = JSON.parse(trimmed.substring('SUGGESTIONS:'.length).trim());
+          suggestions = sanitizeSuggestions(trimmed.substring('SUGGESTIONS:'.length).trim());
         } catch {
         }
       } else {
@@ -559,8 +591,7 @@ export abstract class AiAgent<T> {
     if (!suggestions && answerLines.at(-1)?.includes('SUGGESTIONS:')) {
       const [answer, suggestionsText] = answerLines[answerLines.length - 1].split('SUGGESTIONS:', 2);
       try {
-        // TODO: Do basic validation this is an array with strings
-        suggestions = JSON.parse(suggestionsText.trim().substring('SUGGESTIONS:'.length).trim());
+        suggestions = sanitizeSuggestions(suggestionsText.trim());
       } catch {
       }
       answerLines[answerLines.length - 1] = answer;
@@ -967,3 +998,26 @@ export abstract class AiAgent<T> {
     };
   }
 }
+
+function sanitizeSuggestions(suggestions: string): [string, ...string[]]|undefined {
+  const parsed = JSON.parse(suggestions);
+  if (!Array.isArray(parsed)) {
+    return undefined;
+  }
+  const sanitized: string[] = [];
+  for (const item of parsed) {
+    if (typeof item !== 'string') {
+      continue;
+    }
+    // Collapse multiple whitespace/newlines into a single space.
+    const noExtraWhitespace = item.replace(/\s+/g, ' ').trim();
+    if (noExtraWhitespace.length === 0) {
+      continue;
+    }
+    sanitized.push(noExtraWhitespace.substring(0, MAX_SUGGESTION_LENGTH));
+  }
+  if (sanitized.length === 0) {
+    return undefined;
+  }
+  return sanitized as [string, ...string[]];
+}