chrome-devtools-frontend 1.0.1631386 → 1.0.1635648

package/front_end/generated/SupportedCSSProperties.js

@@ -667,6 +667,7 @@ export const generatedProperties = [
    "rx",
    "ry",
    "scale",
+   "scroll-axis-lock",
    "scroll-behavior",
    "scroll-initial-target",
    "scroll-margin-block-end",
@@ -1967,6 +1968,18 @@ export const generatedProperties = [
   ],
   "name": "corner"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-end-start-radius",
+   "corner-end-start-shape",
+   "border-end-end-radius",
+   "corner-end-end-shape"
+  ],
+  "name": "corner-block-end"
+ },
  {
   "longhands": [
    "corner-end-start-shape",
@@ -1974,6 +1987,18 @@ export const generatedProperties = [
   ],
   "name": "corner-block-end-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-start-radius",
+   "corner-start-start-shape",
+   "border-start-end-radius",
+   "corner-start-end-shape"
+  ],
+  "name": "corner-block-start"
+ },
  {
   "longhands": [
    "corner-start-start-shape",
@@ -1981,6 +2006,28 @@ export const generatedProperties = [
   ],
   "name": "corner-block-start-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-bottom-left-radius",
+   "corner-bottom-left-shape",
+   "border-bottom-right-radius",
+   "corner-bottom-right-shape"
+  ],
+  "name": "corner-bottom"
+ },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-bottom-left-radius",
+   "corner-bottom-left-shape"
+  ],
+  "name": "corner-bottom-left"
+ },
  {
   "keywords": [
    "notch",
@@ -1992,6 +2039,16 @@ export const generatedProperties = [
   ],
   "name": "corner-bottom-left-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-bottom-right-radius",
+   "corner-bottom-right-shape"
+  ],
+  "name": "corner-bottom-right"
+ },
  {
   "keywords": [
    "notch",
@@ -2010,12 +2067,44 @@ export const generatedProperties = [
   ],
   "name": "corner-bottom-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-end-end-radius",
+   "corner-end-end-shape"
+  ],
+  "name": "corner-end-end"
+ },
  {
   "name": "corner-end-end-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-end-start-radius",
+   "corner-end-start-shape"
+  ],
+  "name": "corner-end-start"
+ },
  {
   "name": "corner-end-start-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-end-radius",
+   "corner-start-end-shape",
+   "border-end-end-radius",
+   "corner-end-end-shape"
+  ],
+  "name": "corner-inline-end"
+ },
  {
   "longhands": [
    "corner-start-end-shape",
@@ -2023,6 +2112,18 @@ export const generatedProperties = [
   ],
   "name": "corner-inline-end-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-start-radius",
+   "corner-start-start-shape",
+   "border-end-start-radius",
+   "corner-end-start-shape"
+  ],
+  "name": "corner-inline-start"
+ },
  {
   "longhands": [
    "corner-start-start-shape",
@@ -2030,6 +2131,18 @@ export const generatedProperties = [
   ],
   "name": "corner-inline-start-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-left-radius",
+   "corner-top-left-shape",
+   "border-bottom-left-radius",
+   "corner-bottom-left-shape"
+  ],
+  "name": "corner-left"
+ },
  {
   "longhands": [
    "corner-top-left-shape",
@@ -2037,6 +2150,18 @@ export const generatedProperties = [
   ],
   "name": "corner-left-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-right-radius",
+   "corner-top-right-shape",
+   "border-bottom-right-radius",
+   "corner-bottom-right-shape"
+  ],
+  "name": "corner-right"
+ },
  {
   "longhands": [
    "corner-top-right-shape",
@@ -2053,12 +2178,54 @@ export const generatedProperties = [
   ],
   "name": "corner-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-end-radius",
+   "corner-start-end-shape"
+  ],
+  "name": "corner-start-end"
+ },
  {
   "name": "corner-start-end-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-start-start-radius",
+   "corner-start-start-shape"
+  ],
+  "name": "corner-start-start"
+ },
  {
   "name": "corner-start-start-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-left-radius",
+   "corner-top-left-shape",
+   "border-top-right-radius",
+   "corner-top-right-shape"
+  ],
+  "name": "corner-top"
+ },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-left-radius",
+   "corner-top-left-shape"
+  ],
+  "name": "corner-top-left"
+ },
  {
   "keywords": [
    "notch",
@@ -2070,6 +2237,16 @@ export const generatedProperties = [
   ],
   "name": "corner-top-left-shape"
  },
+ {
+  "keywords": [
+   "normal"
+  ],
+  "longhands": [
+   "border-top-right-radius",
+   "corner-top-right-shape"
+  ],
+  "name": "corner-top-right"
+ },
  {
   "keywords": [
    "notch",
@@ -3246,7 +3423,7 @@ export const generatedProperties = [
  },
  {
   "keywords": [
-   "none"
+   "auto"
   ],
   "name": "max-lines"
  },
@@ -4080,6 +4257,13 @@ export const generatedProperties = [
  {
   "name": "scale"
  },
+ {
+  "keywords": [
+   "auto",
+   "none"
+  ],
+  "name": "scroll-axis-lock"
+ },
  {
   "keywords": [
    "auto",
@@ -5777,6 +5961,26 @@ export const generatedPropertyValues = {
    "normal"
   ]
  },
+ "corner-block-end": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-block-start": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-bottom": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-bottom-left": {
+  "values": [
+   "normal"
+  ]
+ },
  "corner-bottom-left-shape": {
   "values": [
    "notch",
@@ -5787,6 +5991,11 @@ export const generatedPropertyValues = {
    "square"
   ]
  },
+ "corner-bottom-right": {
+  "values": [
+   "normal"
+  ]
+ },
  "corner-bottom-right-shape": {
   "values": [
    "notch",
@@ -5797,6 +6006,56 @@ export const generatedPropertyValues = {
    "square"
   ]
  },
+ "corner-end-end": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-end-start": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-inline-end": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-inline-start": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-left": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-right": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-start-end": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-start-start": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-top": {
+  "values": [
+   "normal"
+  ]
+ },
+ "corner-top-left": {
+  "values": [
+   "normal"
+  ]
+ },
  "corner-top-left-shape": {
   "values": [
    "notch",
@@ -5807,6 +6066,11 @@ export const generatedPropertyValues = {
    "square"
   ]
  },
+ "corner-top-right": {
+  "values": [
+   "normal"
+  ]
+ },
  "corner-top-right-shape": {
   "values": [
    "notch",
@@ -6505,7 +6769,7 @@ export const generatedPropertyValues = {
  },
  "max-lines": {
   "values": [
-   "none"
+   "auto"
   ]
  },
  "max-width": {
@@ -6910,6 +7174,12 @@ export const generatedPropertyValues = {
    "auto"
   ]
  },
+ "scroll-axis-lock": {
+  "values": [
+   "auto",
+   "none"
+  ]
+ },
  "scroll-behavior": {
   "values": [
    "auto",

package/front_end/generated/protocol-mapping.d.ts

@@ -2660,7 +2660,6 @@ export namespace ProtocolMapping {
       returnType: void;
     };
     /**
-     * TODO: OBSOLETE: To remove when setPressureDataOverride is merged.
      * Provides a given pressure state that will be processed and eventually be
      * delivered to PressureObserver users. |source| must have been previously
      * overridden by setPressureSourceOverrideEnabled.
@@ -2669,15 +2668,6 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.Emulation.SetPressureStateOverrideRequest];
       returnType: void;
     };
-    /**
-     * Provides a given pressure data set that will be processed and eventually be
-     * delivered to PressureObserver users. |source| must have been previously
-     * overridden by setPressureSourceOverrideEnabled.
-     */
-    'Emulation.setPressureDataOverride': {
-      paramsType: [Protocol.Emulation.SetPressureDataOverrideRequest];
-      returnType: void;
-    };
     /**
      * Overrides the Idle state.
      */

package/front_end/generated/protocol-proxy-api.d.ts

@@ -1762,20 +1762,12 @@ declare namespace ProtocolProxyApi {
     invoke_setPressureSourceOverrideEnabled(params: Protocol.Emulation.SetPressureSourceOverrideEnabledRequest): Promise<Protocol.ProtocolResponseWithError>;
 
     /**
-     * TODO: OBSOLETE: To remove when setPressureDataOverride is merged.
      * Provides a given pressure state that will be processed and eventually be
      * delivered to PressureObserver users. |source| must have been previously
      * overridden by setPressureSourceOverrideEnabled.
      */
     invoke_setPressureStateOverride(params: Protocol.Emulation.SetPressureStateOverrideRequest): Promise<Protocol.ProtocolResponseWithError>;
 
-    /**
-     * Provides a given pressure data set that will be processed and eventually be
-     * delivered to PressureObserver users. |source| must have been previously
-     * overridden by setPressureSourceOverrideEnabled.
-     */
-    invoke_setPressureDataOverride(params: Protocol.Emulation.SetPressureDataOverrideRequest): Promise<Protocol.ProtocolResponseWithError>;
-
     /**
      * Overrides the Idle state.
      */

package/front_end/generated/protocol.ts

@@ -7395,12 +7395,6 @@ export namespace Emulation {
     state: PressureState;
   }
 
-  export interface SetPressureDataOverrideRequest {
-    source: PressureSource;
-    state: PressureState;
-    ownContributionEstimate?: number;
-  }
-
   export interface SetIdleOverrideRequest {
     /**
      * Mock isUserActive
@@ -19099,6 +19093,11 @@ export namespace Target {
      * the type of "page", this may be set to "prerender".
      */
     subtype?: string;
+    /**
+     * Embedder-specific target metadata. This is only set for targets of
+     * type "tab".
+     */
+    embedderData?: any;
   }
 
   /**

package/front_end/models/ai_assistance/AiConversation.ts

@@ -14,6 +14,7 @@ import type * as NetworkTimeCalculator from '../network_time_calculator/network_
 import {AccessibilityAgent, AccessibilityContext} from './agents/AccessibilityAgent.js';
 import {
   type AiAgent,
+  type AllowedOriginResult,
   type ContextDetail,
   type ConversationContext,
   ErrorType,
@@ -27,6 +28,7 @@ import {ContextSelectionAgent} from './agents/ContextSelectionAgent.js';
 import {FileAgent, FileContext} from './agents/FileAgent.js';
 import {NetworkAgent, RequestContext} from './agents/NetworkAgent.js';
 import {PerformanceAgent, PerformanceTraceContext} from './agents/PerformanceAgent.js';
+import {StorageAgent, StorageContext} from './agents/StorageAgent.js';
 import {NodeContext, StylingAgent} from './agents/StylingAgent.js';
 import {AiHistoryStorage, ConversationType, type SerializedConversation} from './AiHistoryStorage.js';
 import type {ChangeManager} from './ChangeManager.js';
@@ -34,6 +36,17 @@ import type {ChangeManager} from './ChangeManager.js';
 export const NOT_FOUND_IMAGE_DATA = '';
 export const CONTEXT_TITLE = 'Analyzing data';
 const MAX_TITLE_LENGTH = 80;
+/**
+ * List of page navigations that are allowed during an AI agent run.
+ * These are page navigations triggered by agents themselves:
+ * - `about://` : Navigated to before initiating a trace recording to ensure a clean state.
+ * - `chrome://terms`: Navigated to by Lighthouse during its Back-Forward Cache
+ *    audit.
+ */
+export const ALLOWED_PAGE_NAVIGATIONS: Platform.DevToolsPath.UrlString[] = [
+  Platform.DevToolsPath.urlString`about://`,
+  Platform.DevToolsPath.urlString`chrome://terms`,
+];
 
 export function generateContextDetailsMarkdown(details: ContextDetail[]): string {
   const detailsMarkdown: string[] = [];
@@ -87,6 +100,7 @@ export class AiConversation {
   #aidaClient: Host.AidaClient.AidaClient;
   #changeManager: ChangeManager|undefined;
   #origin?: string;
+  #navigationOccurredDuringRun = false;
 
   #contexts: Array<ConversationContext<unknown>> = [];
 
@@ -175,6 +189,8 @@ export class AiConversation {
         this.#updateAgent(ConversationType.PERFORMANCE);
       } else if (updateContext instanceof AccessibilityContext) {
         this.#updateAgent(ConversationType.ACCESSIBILITY);
+      } else if (updateContext instanceof StorageContext) {
+        this.#updateAgent(ConversationType.STORAGE);
       }
     }
   }
@@ -369,6 +385,10 @@ export class AiConversation {
         this.#agent = new AccessibilityAgent(options);
         break;
       }
+      case ConversationType.STORAGE: {
+        this.#agent = new StorageAgent(options);
+        break;
+      }
       case ConversationType.NONE: {
         this.#agent = new ContextSelectionAgent(options);
         break;
@@ -386,22 +406,34 @@ export class AiConversation {
             multimodalInput?: MultimodalInput,
           } = {},
           ): AsyncGenerator<ResponseData, void, void> {
-    if (this.isBlockedByOrigin) {
-      // This error should not be reached. If it happens, some
-      // invariants do not hold anymore.
-      throw new Error('cross-origin context data should not be included');
-    }
-
-    const userQuery: UserQuery = {
-      type: ResponseType.USER_QUERY,
-      query: initialQuery,
-      imageInput: options.multimodalInput?.input,
-      imageId: options.multimodalInput?.id,
+    this.#navigationOccurredDuringRun = false;
+    const originAtRunStart = getPrimaryPageOrigin();
+    const listener = (): void => {
+      // If an unexpected navigation to a different origin occurred
+      // during processing the user's request, we don't want to allow
+      // the agent to run any function calls and retrieve data from the new origin.
+      // Performance agent and accessibility agent navigate to 'about://' or 'chrome://terms'
+      const newOrigin = getPrimaryPageOrigin();
+      if (originAtRunStart !== newOrigin && newOrigin && !ALLOWED_PAGE_NAVIGATIONS.includes(newOrigin)) {
+        this.#navigationOccurredDuringRun = true;
+      }
     };
-    void this.addHistoryItem(userQuery);
-    yield userQuery;
+    const targetManager = SDK.TargetManager.TargetManager.instance();
+    targetManager.addModelListener(
+        SDK.ResourceTreeModel.ResourceTreeModel, SDK.ResourceTreeModel.Events.PrimaryPageChanged, listener, this);
+
+    try {
+      if (this.isBlockedByOrigin) {
+        // This error should not be reached. If it happens, some
+        // invariants do not hold anymore.
+        throw new Error('cross-origin context data should not be included');
+      }
 
-    yield* this.#runAgent(initialQuery, options);
+      yield* this.#runAgent(initialQuery, options, {isInitialCall: true});
+    } finally {
+      targetManager.removeModelListener(
+          SDK.ResourceTreeModel.ResourceTreeModel, SDK.ResourceTreeModel.Events.PrimaryPageChanged, listener, this);
+    }
   }
 
   #getQueryAfterSelection(initialQuery: string, selection: string): string {
@@ -415,6 +447,7 @@ export class AiConversation {
             signal?: AbortSignal,
             multimodalInput?: MultimodalInput,
           } = {},
+          runOptions: {isInitialCall?: boolean} = {},
           ): AsyncGenerator<ResponseData, void, void> {
     this.#setOriginIfEmpty(this.selectedContext?.getOrigin());
     if (this.isBlockedByOrigin) {
@@ -425,6 +458,17 @@ export class AiConversation {
       return;
     }
 
+    if (runOptions.isInitialCall) {
+      const userQuery: UserQuery = {
+        type: ResponseType.USER_QUERY,
+        query: initialQuery,
+        imageInput: options.multimodalInput?.input,
+        imageId: options.multimodalInput?.id,
+      };
+      void this.addHistoryItem(userQuery);
+      yield userQuery;
+    }
+
     function shouldAddToHistory(data: ResponseData): boolean {
       if (data.type === ResponseType.CONTEXT_CHANGE) {
         return false;
@@ -458,7 +502,9 @@ export class AiConversation {
       // requery with the specialized agent.
       if (data.type === ResponseType.CONTEXT_CHANGE) {
         this.setContext(data.context);
-        yield* this.#runAgent(this.#getQueryAfterSelection(initialQuery, data.description), options);
+        yield*
+            this.#runAgent(
+                this.#getQueryAfterSelection(initialQuery, data.description), options, {isInitialCall: false});
         return;
       }
     }
@@ -481,15 +527,16 @@ export class AiConversation {
     return this.#type;
   }
 
-  allowedOrigin = (): string|undefined => {
+  allowedOrigin = (): AllowedOriginResult => {
+    if (this.#navigationOccurredDuringRun) {
+      return {blocked: true};
+    }
     if (this.#origin) {
-      return this.#origin;
+      return {origin: this.#origin};
     }
-    const target = SDK.TargetManager.TargetManager.instance().primaryPageTarget();
-    const inspectedURL = target?.inspectedURL();
-    this.#origin = inspectedURL ? new Common.ParsedURL.ParsedURL(inspectedURL).securityOrigin() : undefined;
+    this.#origin = getPrimaryPageOrigin();
 
-    return this.#origin;
+    return {origin: this.#origin};
   };
 }
 
@@ -500,3 +547,9 @@ function isAiAssistanceServerSideLoggingEnabled(): boolean {
 function isAiAssistanceContextSelectionAgentEnabled(): boolean {
   return Boolean(Root.Runtime.hostConfig.devToolsAiAssistanceContextSelectionAgent?.enabled);
 }
+
+function getPrimaryPageOrigin(): Platform.DevToolsPath.UrlString|undefined {
+  const target = SDK.TargetManager.TargetManager.instance().primaryPageTarget();
+  const inspectedURL = target?.inspectedURL();
+  return inspectedURL ? new Common.ParsedURL.ParsedURL(inspectedURL).securityOrigin() : undefined;
+}

package/front_end/models/ai_assistance/AiHistoryStorage.ts

@@ -15,6 +15,7 @@ export const enum ConversationType {
   PERFORMANCE = 'drjones-performance-full',
   BREAKPOINT = 'breakpoint',
   ACCESSIBILITY = 'accessibility',
+  STORAGE = 'storage',
 }
 
 export interface SerializedConversation {

package/front_end/models/ai_assistance/EvaluateAction.ts

@@ -19,12 +19,13 @@ export interface GetErrorStackOutput {
 
 /* istanbul ignore next */
 export function getErrorStackOnThePage(this: Error): GetErrorStackOutput {
-  return {stack: this.stack, message: this.message};
+  // Using this.stack causes side effect checks to throw.
+  return {stack: '', message: this.message};
 }
 
 /* istanbul ignore next */
 export function stringifyObjectOnThePage(this: unknown): string {
-  const seenBefore = new WeakMap();
+  const seenBefore = new Map();
   return JSON.stringify(this, function replacer(this: unknown, key: string, value: unknown) {
     if (typeof value === 'object' && value !== null) {
       if (seenBefore.has(value)) {
@@ -70,7 +71,7 @@ export async function stringifyRemoteObject(
       return `${object.description}`;
     case Protocol.Runtime.RemoteObjectType.Object: {
       if (object.subtype === 'error') {
-        const res = await object.callFunctionJSON(getErrorStackOnThePage, []);
+        const res = await object.callFunctionJSON(getErrorStackOnThePage, [], {throwOnSideEffect: true});
 
         if (!res) {
           throw new Error('Could not stringify the object' + object);
@@ -78,8 +79,9 @@ export async function stringifyRemoteObject(
 
         return EvaluateAction.stringifyError(res, functionDeclaration);
       }
-      const res = await object.callFunction(stringifyObjectOnThePage);
-
+      const res = await object.callFunction(stringifyObjectOnThePage, undefined, {
+        throwOnSideEffect: true,
+      });
       if (!res.object || res.object.type !== Protocol.Runtime.RemoteObjectType.String) {
         throw new Error('Could not stringify the object' + object);
       }