chrome-devtools-frontend 1.0.1630574 → 1.0.1632065

package/front_end/third_party/puppeteer/package/src/cdp/Input.ts

@@ -437,20 +437,20 @@ export class CdpMouse extends Mouse {
     y: number,
     options: Readonly<MouseClickOptions> = {},
   ): Promise<void> {
-    const {delay, count = 1, clickCount = count} = options;
+    const {delay, count = 1} = options;
     if (count < 1) {
       throw new Error('Click must occur a positive number of times.');
     }
     const actions: Array<Promise<void>> = [this.move(x, y)];
-    if (clickCount === count) {
-      for (let i = 1; i < count; ++i) {
-        actions.push(
-          this.down({...options, clickCount: i}),
-          this.up({...options, clickCount: i}),
-        );
-      }
+
+    for (let i = 1; i < count; ++i) {
+      actions.push(
+        this.down({...options, clickCount: i}),
+        this.up({...options, clickCount: i}),
+      );
     }
-    actions.push(this.down({...options, clickCount}));
+
+    actions.push(this.down({...options, clickCount: count}));
     if (typeof delay === 'number') {
       await Promise.all(actions);
       actions.length = 0;
@@ -458,7 +458,7 @@ export class CdpMouse extends Mouse {
         setTimeout(resolve, delay);
       });
     }
-    actions.push(this.up({...options, clickCount}));
+    actions.push(this.up({...options, clickCount: count}));
     await Promise.all(actions);
   }
 

package/front_end/third_party/puppeteer/package/src/cdp/Page.ts

@@ -707,8 +707,6 @@ export class CdpPage extends Page {
         partitionKey: cookie.partitionKey
           ? cookie.partitionKey.topLevelSite
           : undefined,
-        // TODO: remove sameParty as it is removed from Chrome.
-        sameParty: false,
       };
     });
   }

package/front_end/third_party/puppeteer/package/src/cdp/WebMCP.ts

@@ -46,7 +46,10 @@ export interface WebMCPAnnotation {
  */
 export type WebMCPInvocationStatus = 'Completed' | 'Canceled' | 'Error';
 
-interface ProtocolWebMCPTool {
+/**
+ * @internal
+ */
+export interface ProtocolWebMCPTool {
   name: string;
   description: string;
   inputSchema?: object;

package/front_end/third_party/puppeteer/package/src/common/BrowserWebSocketTransport.ts

@@ -4,6 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 import type {ConnectionTransport} from './ConnectionTransport.js';
+import {debugError} from './util.js';
 
 /**
  * @internal
@@ -36,8 +37,8 @@ export class BrowserWebSocketTransport implements ConnectionTransport {
         this.onclose.call(null);
       }
     });
-    // Silently ignore all errors - we don't know what to do with them.
-    this.#ws.addEventListener('error', () => {});
+    // Silently log all errors - we don't know what to do with them.
+    this.#ws.addEventListener('error', debugError);
   }
 
   send(message: string): void {

package/front_end/third_party/puppeteer/package/src/common/CallbackRegistry.ts

@@ -24,6 +24,10 @@ export class CallbackRegistry {
     this.#idGenerator = idGenerator;
   }
 
+  has(id: number): boolean {
+    return this.#callbacks.has(id);
+  }
+
   create(
     label: string,
     timeout: number | undefined,

package/front_end/third_party/puppeteer/package/src/common/Cookie.ts

@@ -132,10 +132,6 @@ export interface CookieParam {
    * Cookie Priority. Supported only in Chrome.
    */
   priority?: CookiePriority;
-  /**
-   * @deprecated Always ignored.
-   */
-  sameParty?: boolean;
   /**
    * Cookie source scheme type. Supported only in Chrome.
    */
@@ -192,10 +188,6 @@ export interface CookieData {
    * Cookie Priority. Supported only in Chrome.
    */
   priority?: CookiePriority;
-  /**
-   * @deprecated Always set to false. Supported only in Chrome.
-   */
-  sameParty?: boolean;
   /**
    * Cookie source scheme type. Supported only in Chrome.
    */

package/front_end/third_party/puppeteer/package/src/node/BrowserLauncher.ts

@@ -241,8 +241,7 @@ export abstract class BrowserLauncher {
         logs.includes(
           'Failed to create a ProcessSingleton for your profile directory',
         ) ||
-        // On Windows we will not get logs due to the singleton process
-        // handover. See
+        // On Windows we will not get logs due to the singleton process handover. See
         // https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/process_singleton_win.cc;l=46;drc=fc7952f0422b5073515a205a04ec9c3a1ae81658
         (process.platform === 'win32' &&
           existsSync(join(launchArgs.userDataDir, 'lockfile')))
@@ -286,7 +285,7 @@ export abstract class BrowserLauncher {
   abstract executablePath(
     channel?: ChromeReleaseChannel,
     validatePath?: boolean,
-  ): string;
+  ): Promise<string>;
 
   abstract defaultArgs(object: LaunchOptions): string[];
 
@@ -488,9 +487,10 @@ export abstract class BrowserLauncher {
   /**
    * @internal
    */
-  protected getProfilePath(): string {
+  protected async getProfilePath(): Promise<string> {
+    const config = await this.puppeteer.configuration();
     return join(
-      this.puppeteer.configuration.temporaryDirectory ?? tmpdir(),
+      config.temporaryDirectory ?? tmpdir(),
       `puppeteer_dev_${this.browser}_profile-`,
     );
   }
@@ -498,11 +498,12 @@ export abstract class BrowserLauncher {
   /**
    * @internal
    */
-  resolveExecutablePath(
+  async resolveExecutablePath(
     headless?: boolean | 'shell',
     validatePath = true,
-  ): string {
-    let executablePath = this.puppeteer.configuration.executablePath;
+  ): Promise<string> {
+    const config = await this.puppeteer.configuration();
+    let executablePath = config.executablePath;
     if (executablePath) {
       if (validatePath && !existsSync(executablePath)) {
         throw new Error(
@@ -533,15 +534,17 @@ export abstract class BrowserLauncher {
       headless,
     );
 
+    const defaultDownloadPath = await this.puppeteer.defaultDownloadPath();
+    const browserVersion = await this.puppeteer.browserVersion();
+
     executablePath = computeExecutablePath({
-      cacheDir: this.puppeteer.defaultDownloadPath!,
+      cacheDir: defaultDownloadPath!,
       browser: browserType,
-      buildId: this.puppeteer.browserVersion,
+      buildId: browserVersion,
     });
 
     if (validatePath && !existsSync(executablePath)) {
-      const configVersion =
-        this.puppeteer.configuration?.[this.browser]?.version;
+      const configVersion = config?.[this.browser]?.version;
       if (configVersion) {
         throw new Error(
           `Tried to find the browser at the configured path (${executablePath}) for version ${configVersion}, but no executable was found.`,
@@ -550,16 +553,16 @@ export abstract class BrowserLauncher {
       switch (this.browser) {
         case 'chrome':
           throw new Error(
-            `Could not find Chrome (ver. ${this.puppeteer.browserVersion}). This can occur if either\n` +
+            `Could not find Chrome (ver. ${browserVersion}). This can occur if either\n` +
               ` 1. you did not perform an installation before running the script (e.g. \`npx puppeteer browsers install ${browserType}\`) or\n` +
-              ` 2. your cache path is incorrectly configured (which is: ${this.puppeteer.configuration.cacheDirectory}).\n` +
+              ` 2. your cache path is incorrectly configured (which is: ${config.cacheDirectory}).\n` +
               'For (2), check out our guide on configuring puppeteer at https://pptr.dev/guides/configuration.',
           );
         case 'firefox':
           throw new Error(
-            `Could not find Firefox (rev. ${this.puppeteer.browserVersion}). This can occur if either\n` +
+            `Could not find Firefox (rev. ${browserVersion}). This can occur if either\n` +
               ' 1. you did not perform an installation for Firefox before running the script (e.g. `npx puppeteer browsers install firefox`) or\n' +
-              ` 2. your cache path is incorrectly configured (which is: ${this.puppeteer.configuration.cacheDirectory}).\n` +
+              ` 2. your cache path is incorrectly configured (which is: ${config.cacheDirectory}).\n` +
               'For (2), check out our guide on configuring puppeteer at https://pptr.dev/guides/configuration.',
           );
       }

package/front_end/third_party/puppeteer/package/src/node/ChromeLauncher.ts

@@ -34,9 +34,10 @@ export class ChromeLauncher extends BrowserLauncher {
     super(puppeteer, 'chrome');
   }
 
-  override launch(options: LaunchOptions = {}): Promise<Browser> {
+  override async launch(options: LaunchOptions = {}): Promise<Browser> {
+    const config = await this.puppeteer.configuration();
     if (
-      this.puppeteer.configuration.logLevel === 'warn' &&
+      config.logLevel === 'warn' &&
       process.platform === 'darwin' &&
       process.arch === 'x64'
     ) {
@@ -55,7 +56,7 @@ export class ChromeLauncher extends BrowserLauncher {
       }
     }
 
-    return super.launch(options);
+    return await super.launch(options);
   }
 
   /**
@@ -112,7 +113,7 @@ export class ChromeLauncher extends BrowserLauncher {
     if (userDataDirIndex < 0) {
       isTempUserDataDir = true;
       chromeArguments.push(
-        `--user-data-dir=${await mkdtemp(this.getProfilePath())}`,
+        `--user-data-dir=${await mkdtemp(await this.getProfilePath())}`,
       );
       userDataDirIndex = chromeArguments.length - 1;
     }
@@ -127,8 +128,8 @@ export class ChromeLauncher extends BrowserLauncher {
         `An \`executablePath\` or \`channel\` must be specified for \`puppeteer-core\``,
       );
       chromeExecutable = channel
-        ? this.executablePath(channel)
-        : this.resolveExecutablePath(options.headless ?? true);
+        ? await this.executablePath(channel)
+        : await this.resolveExecutablePath(options.headless ?? true);
     }
 
     return {
@@ -170,6 +171,20 @@ export class ChromeLauncher extends BrowserLauncher {
     const turnOnExperimentalFeaturesForTesting =
       process.env['PUPPETEER_TEST_EXPERIMENTAL_CHROME_FEATURES'] === 'true';
 
+    const userEnabledFeatures = getFeatures('--enable-features', options.args);
+    if (options.args && userEnabledFeatures.length > 0) {
+      removeMatchingFlags(options.args, '--enable-features');
+    }
+
+    // Merge default enabled features with user-provided ones, if any.
+    const enabledFeatures = [
+      'PdfOopif',
+      // Add features to enable by default here.
+      ...userEnabledFeatures,
+    ].filter(feature => {
+      return feature !== '';
+    });
+
     // Merge default disabled features with user-provided ones, if any.
     const disabledFeatures = [
       'Translate',
@@ -187,23 +202,13 @@ export class ChromeLauncher extends BrowserLauncher {
             'IsolateSandboxedIframes',
           ]),
       ...userDisabledFeatures,
-    ].filter(feature => {
-      return feature !== '';
-    });
-
-    const userEnabledFeatures = getFeatures('--enable-features', options.args);
-    if (options.args && userEnabledFeatures.length > 0) {
-      removeMatchingFlags(options.args, '--enable-features');
-    }
-
-    // Merge default enabled features with user-provided ones, if any.
-    const enabledFeatures = [
-      'PdfOopif',
-      // Add features to enable by default here.
-      ...userEnabledFeatures,
-    ].filter(feature => {
-      return feature !== '';
-    });
+    ]
+      .filter(feature => {
+        return feature !== '';
+      })
+      .filter(disabledFeature => {
+        return !enabledFeatures.includes(disabledFeature);
+      });
 
     const chromeArguments = [
       '--allow-pre-commit-input',
@@ -284,17 +289,17 @@ export class ChromeLauncher extends BrowserLauncher {
     return chromeArguments;
   }
 
-  override executablePath(
+  override async executablePath(
     channel?: ChromeReleaseChannel,
     validatePath = true,
-  ): string {
+  ): Promise<string> {
     if (channel) {
       return computeSystemExecutablePath({
         browser: SupportedBrowsers.CHROME,
         channel: convertPuppeteerChannelToBrowsersChannel(channel),
       });
     } else {
-      return this.resolveExecutablePath(undefined, validatePath);
+      return await this.resolveExecutablePath(undefined, validatePath);
     }
   }
 }
@@ -312,16 +317,23 @@ export class ChromeLauncher extends BrowserLauncher {
  * @internal
  */
 export function getFeatures(flag: string, options: string[] = []): string[] {
+  const prefix = flag.endsWith('=') ? flag : `${flag}=`;
   return options
     .filter(s => {
-      return s.startsWith(flag.endsWith('=') ? flag : `${flag}=`);
+      return s.startsWith(prefix);
     })
-    .map(s => {
-      return s.split(new RegExp(`${flag}=\\s*`))[1]?.trim();
+    .flatMap(s => {
+      return s
+        .substring(s.indexOf('=') + 1)
+        .trim()
+        .split(',')
+        .map(feature => {
+          return feature.trim();
+        });
     })
     .filter(s => {
       return s;
-    }) as string[];
+    });
 }
 
 /**
@@ -331,10 +343,10 @@ export function getFeatures(flag: string, options: string[] = []): string[] {
  * @internal
  */
 export function removeMatchingFlags(array: string[], flag: string): string[] {
-  const regex = new RegExp(`^${flag}=.*`);
+  const prefix = flag.endsWith('=') ? flag : `${flag}=`;
   let i = 0;
   while (i < array.length) {
-    if (regex.test(array[i]!)) {
+    if (array[i]!.startsWith(prefix)) {
       array.splice(i, 1);
     } else {
       i++;

package/front_end/third_party/puppeteer/package/src/node/FirefoxLauncher.ts

@@ -100,7 +100,8 @@ export class FirefoxLauncher extends BrowserLauncher {
       // with required preferences.
       isTempUserDataDir = false;
     } else {
-      userDataDir = await mkdtemp(this.getProfilePath());
+      const profilePath = await this.getProfilePath();
+      userDataDir = await mkdtemp(profilePath);
       firefoxArguments.push('--profile');
       firefoxArguments.push(userDataDir);
     }
@@ -118,7 +119,7 @@ export class FirefoxLauncher extends BrowserLauncher {
       );
       firefoxExecutable = executablePath;
     } else {
-      firefoxExecutable = this.executablePath(undefined);
+      firefoxExecutable = await this.executablePath(undefined);
     }
 
     return {
@@ -169,8 +170,11 @@ export class FirefoxLauncher extends BrowserLauncher {
     }
   }
 
-  override executablePath(_: unknown, validatePath = true): string {
-    return this.resolveExecutablePath(
+  override async executablePath(
+    _: unknown,
+    validatePath = true,
+  ): Promise<string> {
+    return await this.resolveExecutablePath(
       undefined,
       /* validatePath=*/ validatePath,
     );

package/front_end/third_party/puppeteer/package/src/node/NodeWebSocketTransport.ts

@@ -6,6 +6,7 @@
 import NodeWebSocket from 'ws';
 
 import type {ConnectionTransport} from '../common/ConnectionTransport.js';
+import {debugError} from '../common/util.js';
 import {packageVersion} from '../util/version.js';
 
 /**
@@ -51,8 +52,8 @@ export class NodeWebSocketTransport implements ConnectionTransport {
         this.onclose.call(null);
       }
     });
-    // Silently ignore all errors - we don't know what to do with them.
-    this.#ws.addEventListener('error', () => {});
+    // Silently log all errors - we don't know what to do with them.
+    this.#ws.addEventListener('error', debugError);
   }
 
   send(message: string): void {

package/front_end/third_party/puppeteer/package/src/node/PuppeteerNode.ts

@@ -60,38 +60,24 @@ import type {ChromeReleaseChannel, LaunchOptions} from './LaunchOptions.js';
 export class PuppeteerNode extends Puppeteer {
   #launcher?: BrowserLauncher;
   #lastLaunchedBrowser?: SupportedBrowser;
-
-  /**
-   * @internal
-   */
-  defaultBrowserRevision: string;
-
-  /**
-   * @internal
-   */
-  configuration: Configuration = {};
+  configuration: () => Promise<Configuration>;
 
   /**
    * @internal
    */
   constructor(
     settings: {
-      configuration?: Configuration;
+      configuration?: () => Promise<Configuration>;
     } & CommonPuppeteerSettings,
   ) {
     const {configuration, ...commonSettings} = settings;
     super(commonSettings);
     if (configuration) {
       this.configuration = configuration;
-    }
-    switch (this.configuration.defaultBrowser) {
-      case 'firefox':
-        this.defaultBrowserRevision = PUPPETEER_REVISIONS.firefox;
-        break;
-      default:
-        this.configuration.defaultBrowser = 'chrome';
-        this.defaultBrowserRevision = PUPPETEER_REVISIONS.chrome;
-        break;
+    } else {
+      this.configuration = () => {
+        return Promise.resolve({});
+      };
     }
 
     this.connect = this.connect.bind(this);
@@ -147,21 +133,14 @@ export class PuppeteerNode extends Puppeteer {
    *
    * @param options - Options to configure launching behavior.
    */
-  launch(options: LaunchOptions = {}): Promise<Browser> {
-    const {browser = this.defaultBrowser} = options;
+  async launch(options: LaunchOptions = {}): Promise<Browser> {
+    const {browser = await this.defaultBrowser()} = options;
     this.#lastLaunchedBrowser = browser;
-    switch (browser) {
-      case 'chrome':
-        this.defaultBrowserRevision = PUPPETEER_REVISIONS.chrome;
-        break;
-      case 'firefox':
-        this.defaultBrowserRevision = PUPPETEER_REVISIONS.firefox;
-        break;
-      default:
-        throw new Error(`Unknown product: ${browser}`);
+    if (!['chrome', 'firefox'].includes(browser)) {
+      throw new Error(`Unknown product: ${browser}`);
     }
     this.#launcher = this.#getLauncher(browser);
-    return this.#launcher.launch(options);
+    return await this.#launcher.launch(options);
   }
 
   /**
@@ -184,41 +163,41 @@ export class PuppeteerNode extends Puppeteer {
   /**
    * The default executable path for a given ChromeReleaseChannel.
    */
-  executablePath(channel: ChromeReleaseChannel): string;
+  executablePath(channel: ChromeReleaseChannel): Promise<string>;
   /**
    * The default executable path given LaunchOptions.
    */
-  executablePath(options: LaunchOptions): string;
+  executablePath(options: LaunchOptions): Promise<string>;
   /**
    * The default executable path.
    */
-  executablePath(): string;
-  executablePath(optsOrChannel?: ChromeReleaseChannel | LaunchOptions): string {
+  executablePath(): Promise<string>;
+  async executablePath(
+    optsOrChannel?: ChromeReleaseChannel | LaunchOptions,
+  ): Promise<string> {
     if (optsOrChannel === undefined) {
-      return this.#getLauncher(this.lastLaunchedBrowser).executablePath(
-        undefined,
-        /* validatePath= */ false,
-      );
+      return await this.#getLauncher(
+        await this.lastLaunchedBrowser(),
+      ).executablePath(undefined, /* validatePath= */ false);
     }
     if (typeof optsOrChannel === 'string') {
-      return this.#getLauncher('chrome').executablePath(
+      return await this.#getLauncher('chrome').executablePath(
         optsOrChannel,
         /* validatePath= */ false,
       );
     }
-    return this.#getLauncher(
-      optsOrChannel.browser ?? this.lastLaunchedBrowser,
+    return await this.#getLauncher(
+      optsOrChannel.browser ?? (await this.lastLaunchedBrowser()),
     ).resolveExecutablePath(optsOrChannel.headless, /* validatePath= */ false);
   }
 
   /**
    * @internal
    */
-  get browserVersion(): string {
-    return (
-      this.configuration?.[this.lastLaunchedBrowser]?.version ??
-      this.defaultBrowserRevision!
-    );
+  async browserVersion(): Promise<string> {
+    const config = await this.configuration();
+    const lastLaunched = await this.lastLaunchedBrowser();
+    return config?.[lastLaunched]?.version ?? PUPPETEER_REVISIONS[lastLaunched];
   }
 
   /**
@@ -227,15 +206,16 @@ export class PuppeteerNode extends Puppeteer {
    *
    * @internal
    */
-  get defaultDownloadPath(): string | undefined {
-    return this.configuration.cacheDirectory;
+  async defaultDownloadPath(): Promise<string | undefined> {
+    const config = await this.configuration();
+    return config.cacheDirectory;
   }
 
   /**
    * The name of the browser that was last launched.
    */
-  get lastLaunchedBrowser(): SupportedBrowser {
-    return this.#lastLaunchedBrowser ?? this.defaultBrowser;
+  async lastLaunchedBrowser(): Promise<SupportedBrowser> {
+    return this.#lastLaunchedBrowser ?? (await this.defaultBrowser());
   }
 
   /**
@@ -243,20 +223,9 @@ export class PuppeteerNode extends Puppeteer {
    * `puppeteer`, this is influenced by your configuration. Otherwise, it's
    * `chrome`.
    */
-  get defaultBrowser(): SupportedBrowser {
-    return this.configuration.defaultBrowser ?? 'chrome';
-  }
-
-  /**
-   * @deprecated Do not use as this field as it does not take into account
-   * multiple browsers of different types. Use
-   * {@link PuppeteerNode.defaultBrowser | defaultBrowser} or
-   * {@link PuppeteerNode.lastLaunchedBrowser | lastLaunchedBrowser}.
-   *
-   * @returns The name of the browser that is under automation.
-   */
-  get product(): string {
-    return this.lastLaunchedBrowser;
+  async defaultBrowser(): Promise<SupportedBrowser> {
+    const config = await this.configuration();
+    return config.defaultBrowser ?? 'chrome';
   }
 
   /**
@@ -264,9 +233,9 @@ export class PuppeteerNode extends Puppeteer {
    *
    * @returns The default arguments that the browser will be launched with.
    */
-  defaultArgs(options: LaunchOptions = {}): string[] {
+  async defaultArgs(options: LaunchOptions = {}): Promise<string[]> {
     return this.#getLauncher(
-      options.browser ?? this.lastLaunchedBrowser,
+      options.browser ?? (await this.lastLaunchedBrowser()),
     ).defaultArgs(options);
   }
 
@@ -290,7 +259,8 @@ export class PuppeteerNode extends Puppeteer {
       throw new Error('The current platform is not supported.');
     }
 
-    const cacheDir = this.configuration.cacheDirectory!;
+    const config = await this.configuration();
+    const cacheDir = config.cacheDirectory!;
     const installedBrowsers = await getInstalledBrowsers({
       cacheDir,
     });
@@ -316,8 +286,7 @@ export class PuppeteerNode extends Puppeteer {
     await Promise.all(
       puppeteerBrowsers.map(async item => {
         const tag =
-          this.configuration?.[item.product]?.version ??
-          PUPPETEER_REVISIONS[item.product];
+          config?.[item.product]?.version ?? PUPPETEER_REVISIONS[item.product];
 
         item.currentBuildId = await resolveBuildId(item.browser, platform, tag);
       }),

package/front_end/third_party/puppeteer/package/src/node/ScreenRecorder.ts

@@ -11,8 +11,6 @@ import os from 'node:os';
 import {dirname} from 'node:path';
 import {PassThrough} from 'node:stream';
 
-import debug from 'debug';
-
 import type {OperatorFunction} from '../../third_party/rxjs/rxjs.js';
 import {
   bufferCount,
@@ -28,6 +26,7 @@ import {
 import {CDPSessionEvent} from '../api/CDPSession.js';
 import type {BoundingBox} from '../api/ElementHandle.js';
 import type {Page, VideoFormat} from '../api/Page.js';
+import {debug} from '../common/Debug.js';
 import {debugError, fromEmitterEvent} from '../common/util.js';
 import {guarded} from '../util/decorators.js';
 import {asyncDisposeSymbol} from '../util/disposable.js';

package/front_end/third_party/puppeteer/package/src/revisions.ts

@@ -8,7 +8,7 @@
  * @internal
  */
 export const PUPPETEER_REVISIONS = Object.freeze({
-  chrome: '148.0.7778.97',
-  'chrome-headless-shell': '148.0.7778.97',
-  firefox: 'stable_150.0.2',
+  chrome: '148.0.7778.167',
+  'chrome-headless-shell': '148.0.7778.167',
+  firefox: 'stable_150.0.3',
 });

package/front_end/third_party/puppeteer/package/src/util/httpUtils.ts

@@ -0,0 +1,25 @@
+/**
+ * @license
+ * Copyright 2025 Google Inc.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+/**
+ * Normalizes HTTP header values by handling multiline values.
+ * Multiline header values are joined with commas according to HTTP/1.1 spec.
+ *
+ * @internal
+ */
+export function normalizeHeaderValue(header: string): string {
+  if (!header.includes('\n')) {
+    return header;
+  }
+
+  return header
+    .split('\n')
+    .map(v => {
+      return v.trim();
+    })
+    .filter(Boolean)
+    .join(', ');
+}