chrome-devtools-frontend 1.0.1626437 → 1.0.1628368

package/front_end/third_party/puppeteer/package/src/cdp/Frame.ts

@@ -9,7 +9,7 @@ import type {Protocol} from 'devtools-protocol';
 import type {CDPSession} from '../api/CDPSession.js';
 import type {DeviceRequestPrompt} from '../api/DeviceRequestPrompt.js';
 import type {ElementHandle} from '../api/ElementHandle.js';
-import type {WaitForOptions} from '../api/Frame.js';
+import type {SetContentWaitForOptions, WaitForOptions} from '../api/Frame.js';
 import {Frame, FrameEvent, throwIfDetached} from '../api/Frame.js';
 import type {HTTPResponse} from '../api/HTTPResponse.js';
 import type {WaitTimeoutOptions} from '../api/Page.js';
@@ -145,6 +145,12 @@ export class CdpFrame extends Frame {
       waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[];
     } = {},
   ): Promise<HTTPResponse | null> {
+    if (!this.page()._isUrlAllowed(url)) {
+      throw new Error(
+        `Navigation to ${url} is blocked by blocklist/allowlist rules`,
+      );
+    }
+
     const {
       referer = this._frameManager.networkManager.extraHTTPHeaders()['referer'],
       referrerPolicy = this._frameManager.networkManager.extraHTTPHeaders()[
@@ -273,10 +279,7 @@ export class CdpFrame extends Frame {
   @throwIfDetached
   override async setContent(
     html: string,
-    options: {
-      timeout?: number;
-      waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[];
-    } = {},
+    options: SetContentWaitForOptions = {},
   ): Promise<void> {
     const {
       waitUntil = ['load'],
@@ -420,6 +423,7 @@ export class CdpFrame extends Frame {
     for (const extensionWorld of Object.values(this.extensionWorlds)) {
       extensionWorld[disposeSymbol]();
     }
+    super[disposeSymbol]();
   }
 
   exposeFunction(): never {

package/front_end/third_party/puppeteer/package/src/cdp/FrameManager.ts

@@ -615,9 +615,11 @@ export class FrameManager extends EventEmitter<FrameManagerEvents> {
     for (const child of frame.childFrames()) {
       this.#removeFramesRecursively(child);
     }
-    frame[disposeSymbol]();
     this._frameTree.removeFrame(frame);
     this.emit(FrameManagerEvent.FrameDetached, frame);
     frame.emit(FrameEvent.FrameDetached, frame);
+    // Needs to be last to ensure events
+    // sent before handlers are cleared.
+    frame[disposeSymbol]();
   }
 }

package/front_end/third_party/puppeteer/package/src/cdp/IsolatedWorld.ts

@@ -266,8 +266,8 @@ export class IsolatedWorld extends Realm {
   override [disposeSymbol](): void {
     this.#context?.[disposeSymbol]();
     this.#emitter.emit('disposed', undefined);
-    super[disposeSymbol]();
     this.#emitter.removeAllListeners();
+    super[disposeSymbol]();
   }
 
   override get origin(): string | undefined {

package/front_end/third_party/puppeteer/package/src/cdp/Page.ts

@@ -458,6 +458,10 @@ export class CdpPage extends Page {
     return this.#primaryTargetClient;
   }
 
+  _isUrlAllowed(url: string): boolean {
+    return this.#targetManager.isUrlAllowed(url);
+  }
+
   override isServiceWorkerBypassed(): boolean {
     return this.#serviceWorkerBypassed;
   }

package/front_end/third_party/puppeteer/package/src/cdp/TargetManager.ts

@@ -347,7 +347,7 @@ export class TargetManager
 
     // If we connect to a browser that is already open,
     // immediately detach from any tab that is on the blocklist.
-    if (!this.#initialAttachDone && !this.#isUrlAllowed(targetInfo.url)) {
+    if (!this.#initialAttachDone && !this.isUrlAllowed(targetInfo.url)) {
       await this.#silentDetach(session, parentSession);
       return;
     }
@@ -476,7 +476,7 @@ export class TargetManager
   /**
    * Helper to validate URL against blocklist patterns
    */
-  #isUrlAllowed = (url: string): boolean => {
+  isUrlAllowed = (url: string): boolean => {
     if (this.#blocklist.length === 0 && this.#allowlist.length === 0) {
       return true;
     }

package/front_end/third_party/puppeteer/package/src/common/BrowserConnector.ts

@@ -27,12 +27,28 @@ const getWebSocketTransportClass = async () => {
  *
  * @internal
  */
-export async function _connectToBrowser(
-  options: ConnectOptions,
-): Promise<Browser> {
+export function assertSupportedUrlRestrictions(options: {
+  allowlist?: string[];
+  blocklist?: string[];
+  protocol?: string;
+}): void {
   if (options.blocklist && options.allowlist) {
     throw new Error('Cannot specify both blocklist and allowlist');
   }
+  if (
+    options.protocol === 'webDriverBiDi' &&
+    (options.blocklist || options.allowlist)
+  ) {
+    throw new Error(
+      'blocklist and allowlist are only supported with the CDP protocol',
+    );
+  }
+}
+
+export async function _connectToBrowser(
+  options: ConnectOptions,
+): Promise<Browser> {
+  assertSupportedUrlRestrictions(options);
   const {connectionTransport, endpointUrl} =
     await getConnectionTransport(options);
 

package/front_end/third_party/puppeteer/package/src/common/EventEmitter.ts

@@ -5,7 +5,9 @@
  */
 
 import mitt, {type Emitter} from '../../third_party/mitt/mitt.js';
-import {disposeSymbol} from '../util/disposable.js';
+import {asyncDisposeSymbol, disposeSymbol} from '../util/disposable.js';
+
+import {debugError} from './util.js';
 
 /**
  * @public
@@ -183,6 +185,13 @@ export class EventEmitter<
    * @internal
    */
   [disposeSymbol](): void {
+    return void this[asyncDisposeSymbol]().catch(debugError);
+  }
+
+  /**
+   * @internal
+   */
+  async [asyncDisposeSymbol](): Promise<void> {
     for (const [type, handlers] of this.#handlers) {
       for (const handler of handlers) {
         this.#emitter.off(type, handler);

package/front_end/third_party/puppeteer/package/src/node/BrowserLauncher.ts

@@ -26,6 +26,7 @@ import {
 import type {Browser, BrowserCloseCallback} from '../api/Browser.js';
 import {CdpBrowser} from '../cdp/Browser.js';
 import {Connection} from '../cdp/Connection.js';
+import {assertSupportedUrlRestrictions} from '../common/BrowserConnector.js';
 import {TimeoutError} from '../common/Errors.js';
 import type {SupportedBrowser} from '../common/SupportedBrowser.js';
 import {debugError, DEFAULT_VIEWPORT} from '../common/util.js';
@@ -76,9 +77,6 @@ export abstract class BrowserLauncher {
   }
 
   async launch(options: LaunchOptions = {}): Promise<Browser> {
-    if (options.blocklist && options.allowlist) {
-      throw new Error('Cannot specify both blocklist and allowlist');
-    }
     const {
       dumpio = false,
       enableExtensions = false,
@@ -108,6 +106,12 @@ export abstract class BrowserLauncher {
       protocol = 'webDriverBiDi';
     }
 
+    assertSupportedUrlRestrictions({
+      allowlist,
+      blocklist,
+      protocol,
+    });
+
     if (this.#browser === 'firefox' && protocol === 'cdp') {
       throw new Error('Connecting to Firefox using CDP is no longer supported');
     }

package/front_end/third_party/puppeteer/package/src/node/ScreenRecorder.ts

@@ -346,5 +346,6 @@ export class ScreenRecorder extends PassThrough {
    */
   override async [asyncDisposeSymbol](): Promise<void> {
     await this.stop();
+    await super[asyncDisposeSymbol]();
   }
 }

package/front_end/third_party/puppeteer/package/src/revisions.ts

@@ -10,5 +10,5 @@
 export const PUPPETEER_REVISIONS = Object.freeze({
   chrome: '148.0.7778.97',
   'chrome-headless-shell': '148.0.7778.97',
-  firefox: 'stable_150.0.1',
+  firefox: 'stable_150.0.2',
 });

package/front_end/third_party/puppeteer/package/src/util/version.ts

@@ -6,5 +6,5 @@
 
 // If moved update release-please config
 // x-release-please-start-version
-export const packageVersion = '24.43.0';
+export const packageVersion = '24.43.1';
 // x-release-please-end

package/front_end/ui/components/text_editor/AiCodeCompletionProvider.ts

@@ -134,6 +134,7 @@ export class AiCodeCompletionProvider {
     if (!this.#aiCodeCompletionSetting.get() && !this.#aiCodeCompletionTeaserDismissedSetting.get()) {
       this.#teaser = new PanelCommon.AiCodeCompletionTeaser({
         onDetach: () => this.#detachTeaser.bind(this),
+        panel: this.#aiCodeCompletionConfig?.panel,
       });
       this.#editor.editor.dispatch(
           {effects: this.#teaserCompartment.reconfigure([aiCodeCompletionTeaserExtension(this.#teaser)])});
@@ -320,7 +321,12 @@ export class AiCodeCompletionProvider {
     const startTime = performance.now();
     this.#aiCodeCompletionConfig?.onRequestTriggered();
     // Registering AiCodeCompletionRequestTriggered metric even if the request is served from cache
-    Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiCodeCompletionRequestTriggered);
+    const panel = this.#aiCodeCompletionConfig?.panel;
+    if (panel === AiCodeCompletion.AiCodeCompletion.ContextFlavor.CONSOLE) {
+      Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiCodeCompletionRequestTriggeredFromConsole);
+    } else if (panel === AiCodeCompletion.AiCodeCompletion.ContextFlavor.SOURCES) {
+      Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiCodeCompletionRequestTriggeredFromSources);
+    }
 
     try {
       const completionResponse = await this.#aiCodeCompletion.completeCode(

package/front_end/ui/components/text_editor/AiCodeGenerationProvider.ts

@@ -6,7 +6,7 @@ import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Root from '../../../core/root/root.js';
-import type * as AiCodeCompletion from '../../../models/ai_code_completion/ai_code_completion.js';
+import * as AiCodeCompletion from '../../../models/ai_code_completion/ai_code_completion.js';
 import * as AiCodeGeneration from '../../../models/ai_code_generation/ai_code_generation.js';
 import * as PanelCommon from '../../../panels/common/common.js';
 import * as CodeMirror from '../../../third_party/codemirror.next/codemirror.next.js';
@@ -220,6 +220,13 @@ export class AiCodeGenerationProvider {
     }
 
     void VisualLogging.logKeyDown(event.currentTarget, event, 'ai-code-generation.triggered');
+    if (this.#aiCodeGenerationConfig?.panel === AiCodeCompletion.AiCodeCompletion.ContextFlavor.CONSOLE) {
+      Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiCodeGenerationRequestTriggeredFromConsole);
+      void VisualLogging.logKeyDown(event.currentTarget, event, 'ai-code-generation.triggered-from-console');
+    } else if (this.#aiCodeGenerationConfig?.panel === AiCodeCompletion.AiCodeCompletion.ContextFlavor.SOURCES) {
+      Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiCodeGenerationRequestTriggeredFromSources);
+      void VisualLogging.logKeyDown(event.currentTarget, event, 'ai-code-generation.triggered-from-sources');
+    }
     void this.#triggerAiCodeGeneration({signal: this.#controller.signal});
   }
 

package/front_end/ui/legacy/components/perf_ui/LineLevelProfile.ts

@@ -102,62 +102,6 @@ export class Performance {
   }
 }
 
-let memoryInstance: Memory;
-
-// Note: this is used only by LiveHeapProfile (a drawer panel) if the experiment is enabled.
-export class Memory {
-  private readonly helper: Helper;
-  private constructor() {
-    this.helper = new Helper(Workspace.UISourceCode.DecoratorType.MEMORY);
-  }
-
-  static instance(opts: {
-    forceNew: boolean|null,
-  } = {forceNew: null}): Memory {
-    const {forceNew} = opts;
-    if (!memoryInstance || forceNew) {
-      memoryInstance = new Memory();
-    }
-
-    return memoryInstance;
-  }
-
-  reset(): void {
-    this.helper.reset();
-    void this.helper.update();
-  }
-
-  initialize(profilesAndTargets: Array<{
-    profile: Protocol.HeapProfiler.SamplingHeapProfile,
-    target: SDK.Target.Target,
-  }>): void {
-    this.helper.reset();
-    for (const {profile, target} of profilesAndTargets) {
-      this.appendHeapProfile(profile, target);
-    }
-    void this.helper.update();
-  }
-
-  private appendHeapProfile(profile: Protocol.HeapProfiler.SamplingHeapProfile, target: SDK.Target.Target|null): void {
-    const helper = this.helper;
-    processNode(profile.head);
-
-    function processNode(node: Protocol.HeapProfiler.SamplingHeapProfileNode): void {
-      node.children.forEach(processNode);
-      if (!node.selfSize) {
-        return;
-      }
-      const script = Number(node.callFrame.scriptId) || node.callFrame.url as Platform.DevToolsPath.UrlString;
-      if (!script) {
-        return;
-      }
-      const line = node.callFrame.lineNumber + 1;
-      const column = node.callFrame.columnNumber + 1;
-      helper.addLocationData(target, script, {line, column}, node.selfSize);
-    }
-  }
-}
-
 export class Helper {
   private readonly type: Workspace.UISourceCode.DecoratorType;
   private readonly locationPool = new Bindings.LiveLocation.LiveLocationPool();

package/front_end/ui/legacy/components/perf_ui/perf_ui-meta.ts

@@ -4,7 +4,6 @@
 
 import * as Common from '../../../../core/common/common.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
-import * as Root from '../../../../core/root/root.js';
 import * as UI from '../../legacy.js';
 
 import type * as PerfUI from './perf_ui.js';
@@ -24,21 +23,6 @@ const UIStrings = {
    * @description Classic navigation option in the Performance Panel.
    */
   classic: 'Classic',
-  /**
-   * @description Title of a setting under the Memory category in Settings. Live memory is memory
-   * that is still in-use by the program (not dead). Allocation of live memory is when the program
-   * creates new memory. This is a setting that turns on extra annotations in the UI to mark these
-   * allocations.
-   */
-  liveMemoryAllocationAnnotations: 'Live memory allocation annotations',
-  /**
-   * @description Title of a setting under the Memory category that can be invoked through the Command Menu
-   */
-  showLiveMemoryAllocation: 'Show live memory allocation annotations',
-  /**
-   * @description Title of a setting under the Memory category that can be invoked through the Command Menu
-   */
-  hideLiveMemoryAllocation: 'Hide live memory allocation annotations',
   /**
    * @description Title of an action in the components tool to collect garbage
    */
@@ -88,22 +72,3 @@ Common.Settings.registerSettingExtension({
     },
   ],
 });
-
-Common.Settings.registerSettingExtension({
-  category: Common.Settings.SettingCategory.MEMORY,
-  experiment: Root.ExperimentNames.ExperimentName.LIVE_HEAP_PROFILE,
-  title: i18nLazyString(UIStrings.liveMemoryAllocationAnnotations),
-  settingName: 'memory-live-heap-profile',
-  settingType: Common.Settings.SettingType.BOOLEAN,
-  defaultValue: false,
-  options: [
-    {
-      value: true,
-      title: i18nLazyString(UIStrings.showLiveMemoryAllocation),
-    },
-    {
-      value: false,
-      title: i18nLazyString(UIStrings.hideLiveMemoryAllocation),
-    },
-  ],
-});

package/front_end/ui/legacy/components/perf_ui/perf_ui.ts

@@ -9,7 +9,6 @@ import * as FlameChart from './FlameChart.js';
 import * as Font from './Font.js';
 import * as GCActionDelegate from './GCActionDelegate.js';
 import * as LineLevelProfile from './LineLevelProfile.js';
-import * as LiveHeapProfile from './LiveHeapProfile.js';
 import * as NetworkPriorities from './NetworkPriorities.js';
 import * as OverviewGrid from './OverviewGrid.js';
 import * as PieChart from './PieChart.js';
@@ -25,7 +24,6 @@ export {
   Font,
   GCActionDelegate,
   LineLevelProfile,
-  LiveHeapProfile,
   NetworkPriorities,
   OverviewGrid,
   PieChart,

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -2504,6 +2504,7 @@ export const knownContextValues = new Set([
   'lighthouse.audit.work-during-interaction',
   'lighthouse.cancel',
   'lighthouse.cat-a11y',
+  'lighthouse.cat-agentic-browsing',
   'lighthouse.cat-best-practices',
   'lighthouse.cat-perf',
   'lighthouse.cat-seo',

package/package.json

@@ -105,5 +105,5 @@
     "ip-address": "10.1.0",
     "basic-ftp": "5.2.2"
   },
-  "version": "1.0.1626437"
+  "version": "1.0.1628368"
 }