chrome-devtools-frontend 1.0.1622369 → 1.0.1624583

package/front_end/ui/components/text_editor/AiCodeCompletionProvider.ts

@@ -5,6 +5,7 @@
 import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
+import * as Root from '../../../core/root/root.js';
 import * as AiCodeCompletion from '../../../models/ai_code_completion/ai_code_completion.js';
 import * as AiCodeGeneration from '../../../models/ai_code_generation/ai_code_generation.js';
 import * as PanelCommon from '../../../panels/common/common.js';
@@ -158,8 +159,11 @@ export class AiCodeCompletionProvider {
       return;
     }
     this.#aiCodeCompletion = new AiCodeCompletion.AiCodeCompletion.AiCodeCompletion(
-        {aidaClient: this.#aidaClient}, this.#aiCodeCompletionConfig.panel, undefined,
-        this.#aiCodeCompletionConfig.completionContext.stopSequences);
+        {
+          aidaClient: this.#aidaClient,
+          serverSideLoggingEnabled: !Root.Runtime.hostConfig.aidaAvailability?.disallowLogging,
+        },
+        this.#aiCodeCompletionConfig.panel, undefined, this.#aiCodeCompletionConfig.completionContext.stopSequences);
     this.#aiCodeCompletionConfig.onFeatureEnabled();
   }
 

package/front_end/ui/components/text_editor/AiCodeGenerationProvider.ts

@@ -119,7 +119,10 @@ export class AiCodeGenerationProvider {
     if (this.#aiCodeGeneration) {
       return;
     }
-    this.#aiCodeGeneration = new AiCodeGeneration.AiCodeGeneration.AiCodeGeneration({aidaClient: this.#aidaClient});
+    this.#aiCodeGeneration = new AiCodeGeneration.AiCodeGeneration.AiCodeGeneration({
+      aidaClient: this.#aidaClient,
+      serverSideLoggingEnabled: !Root.Runtime.hostConfig.aidaAvailability?.disallowLogging,
+    });
     this.#editor?.dispatch({
       effects:
           [this.#generationTeaserCompartment.reconfigure([aiCodeGenerationTeaserExtension(this.#generationTeaser)])],

package/front_end/ui/legacy/SuggestBox.ts

@@ -345,6 +345,7 @@ export interface Suggestion {
   };
   hideGhostText?: boolean;
   iconElement?: HTMLElement;
+  disableAcceptSuggestionOnStopCharacters?: boolean;
 }
 
 export type Suggestions = Suggestion[];

package/front_end/ui/legacy/TextPrompt.ts

@@ -598,7 +598,8 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
 
   private acceptSuggestionOnStopCharacters(key: string): boolean {
     if (!this.currentSuggestion || !this.queryRange || key.length !== 1 ||
-        !this.completionStopCharacters?.includes(key)) {
+        !this.completionStopCharacters?.includes(key) ||
+        this.currentSuggestion.disableAcceptSuggestionOnStopCharacters) {
       return false;
     }
 

package/front_end/ui/legacy/UIUtils.ts

@@ -2285,7 +2285,6 @@ export const bindToSetting =
         }
       }
 
-      const jslogBuilder = jslog ? VisualLogging.toggle(setting.name).track({change: true}) : null;
       // We can't use `setValue` as the change listener directly, otherwise we won't
       // be able to remove it again.
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -2295,22 +2294,45 @@ export const bindToSetting =
       }
 
       if (setting.type() === Common.Settings.SettingType.BOOLEAN || typeof setting.defaultValue === 'boolean') {
+        let attachedButton: Buttons.Button.Button|undefined;
+        let clickListener: (() => void)|undefined;
+
         return Directives.ref(e => {
           if (e === undefined) {
             setting.removeChangeListener(settingChanged);
+            if (attachedButton && clickListener) {
+              attachedButton.removeEventListener('click', clickListener);
+              attachedButton = undefined;
+            }
             return;
           }
-          if (jslogBuilder) {
+          if (jslog) {
+            const isButton = e instanceof Buttons.Button.Button;
+            const jslogBuilder = VisualLogging.toggle(setting.name).track(isButton ? {click: true} : {change: true});
             e.setAttribute('jslog', jslogBuilder.toString());
           }
 
           setting.addChangeListener(settingChanged);
-          setValue =
-              bindCheckboxImpl(e as CheckboxLabel, (setting as Common.Settings.Setting<boolean>).set.bind(setting));
+
+          if (e instanceof Buttons.Button.Button) {
+            attachedButton = e;
+            clickListener = (): void => {
+              (setting as Common.Settings.Setting<boolean>).set(!setting.get());
+            };
+            e.addEventListener('click', clickListener);
+            setValue = (value: boolean): void => {
+              e.toggled = value;
+            };
+          } else {
+            setValue =
+                bindCheckboxImpl(e as CheckboxLabel, (setting as Common.Settings.Setting<boolean>).set.bind(setting));
+          }
           setValue(setting.get());
         });
       }
 
+      const jslogBuilder = jslog ? VisualLogging.toggle(setting.name).track({change: true}) : null;
+
       if (setting.type() === Common.Settings.SettingType.REGEX || setting instanceof Common.Settings.RegExpSetting) {
         return Directives.ref(e => {
           if (e === undefined) {

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -722,6 +722,7 @@ export const knownContextValues = new Set([
   'cache-storage-view-tab',
   'cache-storage.delete-selected',
   'cache-storage.refresh',
+  'cache-widget',
   'calibrated-cpu-throttling',
   'call-tree',
   'cancel',
@@ -744,6 +745,7 @@ export const knownContextValues = new Set([
   'changes',
   'changes.changes',
   'changes.reveal-source',
+  'character-set-widget',
   'checkbox-item',
   'checked',
   'chevron-left',
@@ -935,6 +937,7 @@ export const knownContextValues = new Set([
   'console-view',
   'console.clear',
   'console.clear.history',
+  'console.collapse-all',
   'console.create-pin',
   'console.sidebar-selected-filter',
   'console.text-filter',
@@ -1369,6 +1372,7 @@ export const knownContextValues = new Set([
   'distance',
   'dock-side',
   'document',
+  'document-latency-widget',
   'document.write',
   'documentation',
   'documents',
@@ -1384,6 +1388,7 @@ export const knownContextValues = new Set([
   'dom-node-inserted-into-document',
   'dom-node-removed',
   'dom-node-removed-from-document',
+  'dom-size-widget',
   'dom-snapshot',
   'dom-subtree-modified',
   'dom-window.close',
@@ -1422,6 +1427,7 @@ export const knownContextValues = new Set([
   'drjones.sources-panel-context.performance',
   'drjones.sources-panel-context.script',
   'drop',
+  'duplicate-javascript-widget',
   'durable-messages',
   'duration',
   'durationchange',
@@ -1705,6 +1711,7 @@ export const knownContextValues = new Set([
   'folder',
   'font',
   'font-display',
+  'font-display-widget',
   'font-editor',
   'font-editor-documentation',
   'font-family',
@@ -1744,6 +1751,7 @@ export const knownContextValues = new Set([
   'force-state',
   'forced-color-adjust',
   'forced-reflow',
+  'forced-reflow-widget',
   'form-data',
   'form-factors',
   'fourth',
@@ -1973,6 +1981,7 @@ export const knownContextValues = new Set([
   'ignore-this-retainer',
   'image',
   'image-animation',
+  'image-delivery-widget',
   'image-orientation',
   'image-rendering',
   'image-url',
@@ -2011,6 +2020,7 @@ export const knownContextValues = new Set([
   'inline-size',
   'inline-variable-values',
   'inline-variable-values-false',
+  'inp-breakdown-widget',
   'input',
   'insertCompositionText',
   'insertFromDrop',
@@ -2275,6 +2285,7 @@ export const knownContextValues = new Set([
   'layout-count',
   'layout-shifts',
   'lcp-breakdown',
+  'lcp-breakdown-widget',
   'lcp-discovery-widget',
   'learn-more',
   'learn-more.ai-annotations',
@@ -2290,6 +2301,7 @@ export const knownContextValues = new Set([
   'learn-more.origin-trials',
   'leavepictureinpicture',
   'left',
+  'legacy-javascript-widget',
   'legend',
   'length',
   'length-popover',
@@ -2328,6 +2340,7 @@ export const knownContextValues = new Set([
   'lighthouse.audit.aria-treeitem-name',
   'lighthouse.audit.aria-valid-attr',
   'lighthouse.audit.aria-valid-attr-value',
+  'lighthouse.audit.autocomplete-valid',
   'lighthouse.audit.baseline',
   'lighthouse.audit.bf-cache',
   'lighthouse.audit.bootup-time',
@@ -2435,6 +2448,7 @@ export const knownContextValues = new Set([
   'lighthouse.audit.offscreen-images',
   'lighthouse.audit.origin-isolation',
   'lighthouse.audit.paste-preventing-inputs',
+  'lighthouse.audit.presentation-role-conflict',
   'lighthouse.audit.prioritize-lcp-image',
   'lighthouse.audit.redirects',
   'lighthouse.audit.redirects-http',
@@ -2449,6 +2463,7 @@ export const knownContextValues = new Set([
   'lighthouse.audit.skip-link',
   'lighthouse.audit.speed-index',
   'lighthouse.audit.structured-data',
+  'lighthouse.audit.svg-img-alt',
   'lighthouse.audit.tabindex',
   'lighthouse.audit.table-duplicate-name',
   'lighthouse.audit.table-fake-caption',
@@ -2700,6 +2715,7 @@ export const knownContextValues = new Set([
   'mobile-throttling',
   'model',
   'modern',
+  'modern-http-widget',
   'monitoring-xhr-enabled',
   'monspace',
   'more',
@@ -2758,6 +2774,7 @@ export const knownContextValues = new Set([
   'network-conditions.network-offline',
   'network-conditions.network-online',
   'network-default',
+  'network-dependency-tree-widget',
   'network-direct-socket-message-filter',
   'network-event-source-message-filter',
   'network-film-strip',
@@ -3715,6 +3732,7 @@ export const knownContextValues = new Set([
   'slot',
   'slow',
   'slow-4g',
+  'slow-css-selector-widget',
   'sm-script',
   'sm-stylesheet',
   'small',
@@ -3965,6 +3983,7 @@ export const knownContextValues = new Set([
   'th',
   'third',
   'third-parties',
+  'third-parties-widget',
   'third-party-tree',
   'third-property',
   'this-origin',
@@ -4345,6 +4364,7 @@ export const knownContextValues = new Set([
   'view-transition-group',
   'view-transition-name',
   'view-transition-scope',
+  'viewport-widget',
   'views-location-override',
   'virtual-authenticators',
   'visibility',

package/package.json

@@ -79,7 +79,7 @@
     "mocha": "11.7.5",
     "ora": "9.0.0",
     "postcss": "8.5.6",
-    "puppeteer-core": "24.30.0",
+    "puppeteer-core": "24.42.0",
     "rollup": "4.22.4",
     "rollup-plugin-sourcemaps2": "0.5.4",
     "sinon": "21.0.0",
@@ -97,12 +97,13 @@
     "js-rouge": "3.2.0"
   },
   "overrides": {
-    "baseline-browser-mapping": "2.8.25",
-    "electron-to-chromium": "1.5.248",
-    "caniuse-lite": "1.0.30001754",
-    "stylelint": {
-      "flat-cache": "6.1.12"
-    }
+    "electron-to-chromium": "1.5.335",
+    "bare-os": "3.9.0",
+    "bare-stream": "2.13.0",
+    "tar-stream": "3.1.5",
+    "socks": "2.8.7",
+    "ip-address": "10.1.0",
+    "basic-ftp": "5.2.2"
   },
-  "version": "1.0.1622369"
+  "version": "1.0.1624583"
 }

package/front_end/panels/emulation/components/DeviceSizeInputElement.ts

@@ -1,134 +0,0 @@
-// Copyright 2021 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-/* eslint-disable @devtools/no-lit-render-outside-of-view */
-
-import type * as Platform from '../../../core/platform/platform.js';
-import * as EmulationModel from '../../../models/emulation/emulation.js';
-import * as UILegacy from '../../../ui/legacy/legacy.js';
-import {html, render} from '../../../ui/lit/lit.js';
-import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
-
-class SizeChangedEvent extends Event {
-  static readonly eventName = 'sizechanged';
-  constructor(public size: number) {
-    super(SizeChangedEvent.eventName);
-  }
-}
-
-function getInputValue(event: Event): number {
-  return Number((event.target as HTMLInputElement).value);
-}
-
-export class SizeInputElement extends HTMLElement {
-  #root = this.attachShadow({mode: 'open'});
-  #disabled = false;
-  #size = '0';
-  #placeholder = '';
-  #title: Platform.UIString.LocalizedString;
-  #jslogContext: string;
-
-  constructor(title: Platform.UIString.LocalizedString, {jslogContext}: {jslogContext: string}) {
-    super();
-    this.#title = title;
-    this.#jslogContext = jslogContext;
-  }
-
-  connectedCallback(): void {
-    this.render();
-  }
-
-  set disabled(disabled: boolean) {
-    this.#disabled = disabled;
-    this.render();
-  }
-
-  set size(size: string) {
-    this.#size = size;
-    this.render();
-  }
-
-  set placeholder(placeholder: string) {
-    this.#placeholder = placeholder;
-    this.render();
-  }
-
-  render(): void {
-    render(
-        // Since the emulation code runs in a different frame, we can't
-        // use constructed stylesheets (they are disallowed cross-frame).
-        // For now, use an inline style tag and later we can refactor this
-        // to use proper constructed stylesheets, when the code runs
-        // in the correct frame context.
-        html`
-      <style>
-        input {
-          /*
-           * 4 characters for the maximum size of the value,
-           * 2 characters for the width of the step-buttons,
-           * 2 pixels padding between the characters and the
-           * step-buttons.
-           */
-          width: calc(4ch + 2ch + 2px);
-          max-height: 18px;
-          border: var(--sys-color-neutral-outline);
-          border-radius: 4px;
-          margin: 0 2px;
-          text-align: center;
-          font-size: inherit;
-          font-family: inherit;
-        }
-
-        input:disabled {
-          user-select: none;
-        }
-
-        input:focus::-webkit-input-placeholder {
-          color: transparent;
-        }
-      </style>
-      <input type="number"
-             max=${EmulationModel.DeviceModeModel.MaxDeviceSize}
-             min=${EmulationModel.DeviceModeModel.MinDeviceSize}
-             jslog=${VisualLogging.textField().track({change: true}).context(this.#jslogContext)}
-             maxlength="4"
-             title=${this.#title}
-             placeholder=${this.#placeholder}
-             ?disabled=${this.#disabled}
-             .value=${this.#size}
-             @change=${this.#fireSizeChange}
-             @keydown=${this.#handleModifierKeys} />
-    `,
-        this.#root, {host: this});
-  }
-
-  #fireSizeChange(event: Event): void {
-    this.dispatchEvent(new SizeChangedEvent(getInputValue(event)));
-  }
-
-  #handleModifierKeys(event: Event): void {
-    let modifiedValue = UILegacy.UIUtils.modifiedFloatNumber(getInputValue(event), event);
-    if (modifiedValue === null) {
-      return;
-    }
-
-    modifiedValue = Math.min(modifiedValue, EmulationModel.DeviceModeModel.MaxDeviceSize);
-    modifiedValue = Math.max(modifiedValue, EmulationModel.DeviceModeModel.MinDeviceSize);
-
-    event.preventDefault();
-    (event.target as HTMLInputElement).value = String(modifiedValue);
-    this.dispatchEvent(new SizeChangedEvent(modifiedValue));
-  }
-}
-
-// eslint-disable-next-line @devtools/enforce-custom-element-prefix
-customElements.define('device-mode-emulation-size-input', SizeInputElement);
-
-declare global {
-  interface HTMLElementTagNameMap {
-    'device-mode-emulation-size-input': SizeInputElement;
-  }
-  interface HTMLElementEventMap {
-    sizechanged: SizeChangedEvent;
-  }
-}

package/front_end/panels/emulation/components/components.ts

@@ -1,9 +0,0 @@
-// Copyright 2021 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as DeviceSizeInputElement from './DeviceSizeInputElement.js';
-
-export {
-  DeviceSizeInputElement,
-};