chrome-devtools-frontend 1.0.1621678 → 1.0.1624409

package/.agents/skills/foundation-test-migration/SKILL.md

@@ -0,0 +1,171 @@
+---
+name: foundation-test-migration
+description: Migrating unit tests to foundation unit tests using TestUniverse and devtools_foundation_module. Use when moving tests away from DOM-heavy helpers like describeWithEnvironment or describeWithMockConnection.
+---
+
+# Foundation Test Migration
+
+This skill provides guidance on migrating DevTools unit tests to the "foundation" pattern, which is lighter, avoids global singletons, and is compatible with both Node and Browser runtimes (Isomorphic).
+
+## Core Concepts
+
+### devtools_foundation_module (BUILD.gn)
+Use this template for modules that should be platform-agnostic.
+- **Enforcement**: It type-checks the code against both Browser and Node APIs.
+- **Constraint**: Avoid direct DOM access (like `FileReader` or layout metrics) or heavy DevTools dependencies. Use `Universe` to access services.
+
+### TestUniverse
+`TestUniverse` is the preferred way to setup a DevTools-like environment for tests without global singletons.
+- **Lazy**: Dependencies (targetManager, settings, workspace, etc.) are only created when accessed via getters.
+- **Scoped**: Does not install instances as globals (avoids `Common.Settings.Settings.instance()`).
+- **Explicit**: Uses `DevToolsContext` to manage dependencies.
+
+## Migration Guide
+
+### 1. Replace Heavy Helpers
+Avoid `describeWithEnvironment` or `describeWithMockConnection`.
+
+Instead, use standard `describe` and initialize environment hooks at the top-level `describe` block. **Crucial:** Without `setupRuntimeHooks`, tests creating SDK models will crash due to uninitialized experiments (e.g. `capture-node-creation-stacks`).
+
+```ts
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
+import {setupSettingsHooks} from '../../testing/SettingsHelpers.js';
+import {setupRuntimeHooks} from '../../testing/RuntimeHelpers.js';
+import {TestUniverse} from '../../testing/TestUniverse.js';
+
+describe('MyComponent', () => {
+  setupLocaleHooks();
+  setupSettingsHooks();
+  setupRuntimeHooks();
+
+  let universe: TestUniverse;
+
+  beforeEach(() => {
+    universe = new TestUniverse();
+  });
+});
+```
+
+### 2. Access Dependencies via Universe
+Instead of using `SDK.TargetManager.TargetManager.instance()`, use `universe.targetManager`. Use `universe.createTarget()` instead of the global `createTarget`.
+
+```ts
+// OLD
+const target = createTarget();
+const targetManager = SDK.TargetManager.TargetManager.instance();
+
+// NEW
+const target = universe.createTarget({url: urlString`http://example.com/`});
+const targetManager = universe.targetManager;
+```
+
+#### Mocking CDP Traffic
+If the test used `describeWithMockConnection` and global `setMockConnectionResponseHandler` to stub CDP traffic, you can migrate this by passing a `MockCDPConnection` to `universe.createTarget()`. This allows stubbing out CDP traffic scoped to a specific target tree rather than globally.
+
+```ts
+import {MockCDPConnection} from '../../testing/MockCDPConnection.js';
+
+const cdpConnection = new MockCDPConnection([
+  {
+    method: 'Network.getResponseBody',
+    response: () => ({body: 'mocked body', base64Encoded: false}),
+  }
+]);
+
+const target = universe.createTarget({connection: cdpConnection});
+```
+
+> [!TIP]
+> **Legacy Target URLs**: `EnvironmentHelpers.createTarget()` defaults to `http://example.com/`. `TestUniverse.createTarget()` defaults to `about:blank`. If your test asserts against specific URLs, remember to pass the URL explicitly.
+
+### 3. Dealing with Legacy Singletons & Helpers
+
+For large integration tests, you may encounter code that strictly calls `SomeModule.instance()` or uses complex legacy helpers (like `createWorkspaceProject`).
+
+**Do not use `setUpEnvironment()`** as it will create disconnected singletons. Instead, wire the singletons to your `TestUniverse` and stub the globals to bridge legacy helpers:
+
+```ts
+beforeEach(async () => {
+  universe = new TestUniverse();
+  const {targetManager, workspace, settings} = universe;
+
+  // 1. Stub globals so legacy helpers use TestUniverse components
+  sinon.stub(Workspace.Workspace.WorkspaceImpl, 'instance').returns(workspace);
+  sinon.stub(SDK.TargetManager.TargetManager, 'instance').returns(targetManager);
+  sinon.stub(Common.Settings.Settings, 'instance').returns(settings);
+
+  // 2. Initialize interdependent singletons in the correct order
+  SDK.NetworkManager.MultitargetNetworkManager.instance({forceNew: true, targetManager});
+
+  // 3. Now safe to use legacy helpers that rely on the above instances
+  await createWorkspaceProject(urlString`file:///path/to/overrides`, [...]);
+});
+```
+
+## Pitfalls & Troubleshooting
+
+### Strict Equality in Protocol Responses (`assert.deepEqual`)
+Protocol requests/responses dynamically generated by Chrome (like Network conditions) can vary slightly (e.g., adding `connectionType`, `urlPattern`).
+- **Problem**: `assert.deepEqual(rules, [{...}])` will flake if unrequested fields are present.
+- **Solution**: Use `sinon.spy()` for handlers and assert with `sinon.assert.calledOnceWithMatch`:
+
+```ts
+const emulateSpy = sinon.spy();
+connection.setHandler('Network.emulateNetworkConditionsByRule', request => {
+  emulateSpy(request);
+  return {result: {ruleIds: []}};
+});
+
+// Matches only the fields you care about, ignoring extra protocol fields
+sinon.assert.calledOnceWithMatch(emulateSpy, {
+  offline: false,
+  matchedNetworkConditions: [sinon.match({ downloadThroughput: 1000 })],
+});
+```
+
+### DOM Globals (`ReferenceError: FileReader is not defined`)
+Foundation tests run in Node.js where `window`, `FileReader`, and certain DOM string encodings don't exist.
+- **Fix**: Use isomorphic equivalents (e.g. `btoa()`, `Uint8Array`).
+- **Last Resort**: Skip the test with `it.skip()` if it explicitly tests browser quirks (e.g. legacy charset decoding).
+
+### Initialization Order Lockups
+If a test times out (5000ms exceeded), it is usually an unhandled promise caused by a missing singleton. Double-check the constructor of the failing manager to see which `instance()` it listens to, and ensure that dependent singleton was created *first*.
+
+## BUILD.gn Changes
+
+When a module and its tests are ready, update `BUILD.gn`:
+
+1.  Change `devtools_module` to `devtools_foundation_module` for both the module and its unittests.
+2.  Ensure the tests are grouped under a `foundation_unittests` target in the parent `BUILD.gn`.
+
+```gn
+# front_end/my_module/BUILD.gn
+
+devtools_foundation_module("my_module") {
+  sources = [ "MyModule.ts" ]
+  deps = [ "../../core/common:bundle" ]
+}
+
+devtools_foundation_module("unittests") {
+  testonly = true
+  sources = [ "MyModule.test.ts" ]
+  deps = [
+    ":my_module",
+    "../../testing",
+  ]
+}
+```
+
+## Verification
+
+Foundation tests must pass in both Node.js and Browser runtimes.
+
+### Run in Node.js
+```bash
+npm test -- front_end/core/sdk/NetworkManager.test.ts --node-unit-tests
+```
+
+### Run in Browser
+```bash
+npm test -- front_end/core/sdk/NetworkManager.test.ts
+```

package/.agents/skills/verification/SKILL.md

@@ -13,25 +13,16 @@ description: MANDATORY: Activate this skill ANY TIME you need to build the proje
 
 ## Building & compiling
 
-- Check for TypeScript or dependency issues in the build system by running `autoninja -C out/Default`.
-
-## Fast builds
-
-- If the `out/Fast` or `out/fast-build` directory exists, this means that a build that does not execute TypeScript is available to you which greatly decreases build time.
-- To use the fast build for tests, pass the `--target=Fast` (adjust the value based on the name of the directory) argument to `npm run test`.
+- Check for build issues by running `autoninja -C out/Default`.
 
 ## Linting
 
 - `npm run lint` will execute ESLint and StyleLint. It will report any violations and automatically fix them where possible.
 - To run the linter on a specific file or directory, you can run `npm run lint -- <PATH>` where `PATH` is a path to a file or directory. This will also automatically fix violations where possible.
 
-## Presubmit
-
-- `git cl presubmit -u` will check if the current change is ready for upload. It will also format and lint the change.
-
 ## Best practices
 
 - Run tests often to verify your changes.
 - Prefer using a fast build, if it exists, to keep the feedback loop shorter.
-- Periodically compile with TypeScript to check for type errors.
+- Periodically build to check for errors.
 - Run `git cl presubmit -u` at the end of your code changes.

package/front_end/Images/src/expand.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" height="20" viewBox="0 -960 960 960" width="20"><path d="M192-96v-72h576v72H192Zm288-144L336-384l51-51 57 57v-204l-57 57-51-51 144-144 144 144-51 51-57-57v204l57-57 51 51-144 144ZM192-792v-72h576v72H192Z"/></svg>

package/front_end/core/common/Base64.ts

@@ -36,8 +36,18 @@ export function decode(input: string): Uint8Array<ArrayBuffer> {
  * Note: if input can be very large (larger than the max string size), callers should
  * expect this to throw an error.
  */
-export function encode(input: BlobPart): Promise<string> {
-  return new Promise((resolve, reject) => {
+export async function encode(input: BlobPart): Promise<string> {
+  // Node.js environment (for foundation unit tests)
+  if (typeof FileReader === 'undefined') {
+    const blob = new Blob([input]);
+    const arrayBuffer = await blob.arrayBuffer();
+    // Use globalThis.Buffer to avoid TypeScript errors if Node types are not included.
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    return (globalThis as any).Buffer.from(arrayBuffer).toString('base64');
+  }
+
+  // Browser environment
+  return await new Promise((resolve, reject) => {
     const reader = new FileReader();
     reader.onerror = () => reject(new Error('failed to convert to base64: internal error'));
     reader.onload = () => {

package/front_end/core/i18n/i18nImpl.ts

@@ -64,10 +64,14 @@ function getLocaleFetchUrl(locale: Intl.UnicodeBCP47LocaleIdentifier, location:
  * fetched locally or remotely.
  */
 export async function fetchAndRegisterLocaleData(
-    locale: Intl.UnicodeBCP47LocaleIdentifier, location = self.location.toString()): Promise<void> {
-  const localeDataTextPromise = fetch(getLocaleFetchUrl(locale, location)).then(result => result.json());
-  const timeoutPromise =
-      new Promise<never>((_, reject) => window.setTimeout(() => reject(new Error('timed out fetching locale')), 5000));
+    locale: Intl.UnicodeBCP47LocaleIdentifier,
+    // Type issue with universal types.
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    location = (globalThis as any).location?.toString() ?? ''): Promise<void> {
+  const localeDataTextPromise =
+      fetch(getLocaleFetchUrl(locale, location)).then(result => result.json()) as Promise<I18n.I18n.LocalizedMessages>;
+  const timeoutPromise = new Promise<never>(
+      (_, reject) => globalThis.setTimeout(() => reject(new Error('timed out fetching locale')), 5000));
   const localeData = await Promise.race([timeoutPromise, localeDataTextPromise]);
   i18nInstance.registerLocaleData(locale, localeData);
 }

package/front_end/core/root/Runtime.ts

@@ -12,12 +12,27 @@ let runtimeInstance: Runtime|undefined;
 let isNode: boolean|undefined;
 let isTraceAppEntry: boolean|undefined;
 
+interface Global {
+  location?: {
+    toString(): string,
+    pathname: string,
+    search: string,
+  };
+  navigator?: {
+    userAgent: string,
+  };
+  localStorage?: Storage;
+  self?: Global;
+}
+
+const globalObject = (globalThis as unknown as Global);
+
 /**
  * Returns the base URL (similar to `<base>`).
  * Used to resolve the relative URLs of any additional DevTools files (locale strings, etc) needed.
  * See: https://cs.chromium.org/remoteBase+f:devtools_window
  */
-export function getRemoteBase(location: string = self.location.toString()): {
+export function getRemoteBase(location: string = globalObject.self?.location?.toString() ?? ''): {
   base: string,
   version: string,
 }|null {
@@ -36,7 +51,7 @@ export function getRemoteBase(location: string = self.location.toString()): {
 }
 
 export function getPathName(): string {
-  return window.location.pathname;
+  return globalObject.location?.pathname ?? '';
 }
 
 export function isNodeEntry(pathname: string): boolean {
@@ -46,7 +61,7 @@ export function isNodeEntry(pathname: string): boolean {
 
 export const getChromeVersion = (): string => {
   const chromeRegex = /(?:^|\W)(?:Chrome|HeadlessChrome)\/(\S+)/;
-  const chromeMatch = navigator.userAgent.match(chromeRegex);
+  const chromeMatch = globalObject.navigator?.userAgent?.match(chromeRegex);
   if (chromeMatch && chromeMatch.length > 1) {
     return chromeMatch[1];
   }
@@ -75,9 +90,8 @@ export class Runtime {
   static #queryParamsObject: URLSearchParams;
 
   static #getSearchParams(): URLSearchParams|null {
-    // TODO(crbug.com/451502260): Find a more explicit way to support running in Node.js
-    if (!Runtime.#queryParamsObject && 'location' in globalThis) {
-      Runtime.#queryParamsObject = new URLSearchParams(location.search);
+    if (!Runtime.#queryParamsObject && globalObject.location) {
+      Runtime.#queryParamsObject = new URLSearchParams(globalObject.location.search);
     }
     return Runtime.#queryParamsObject;
   }
@@ -297,13 +311,13 @@ export class ExperimentsSupport {
   }
 }
 
-/** Manages the 'experiments' dictionary in self.localStorage */
+/** Manages the 'experiments' dictionary in globalThis.localStorage */
 class ExperimentStorage {
   readonly #experiments: Record<string, boolean|undefined> = {};
 
   constructor() {
     try {
-      const storedExperiments = self.localStorage?.getItem('experiments');
+      const storedExperiments = globalObject.localStorage?.getItem('experiments');
       if (storedExperiments) {
         this.#experiments = JSON.parse(storedExperiments);
       }
@@ -337,7 +351,7 @@ class ExperimentStorage {
   }
 
   #syncToLocalStorage(): void {
-    self.localStorage?.setItem('experiments', JSON.stringify(this.#experiments));
+    globalObject.localStorage?.setItem('experiments', JSON.stringify(this.#experiments));
   }
 }
 
@@ -480,6 +494,10 @@ export interface HostConfigAiAssistanceAccessibilityAgent {
   enabled: boolean;
 }
 
+export interface HostConfigAiAssistanceStorageAgent {
+  enabled: boolean;
+}
+
 export interface HostConfigAiCodeCompletion {
   modelId: string;
   temperature: number;
@@ -638,6 +656,7 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsAiAssistanceFileAgent: HostConfigAiAssistanceFileAgent,
   devToolsAiAssistancePerformanceAgent: HostConfigAiAssistancePerformanceAgent,
   devToolsAiAssistanceAccessibilityAgent: HostConfigAiAssistanceAccessibilityAgent,
+  devToolsAiAssistanceStorageAgent: HostConfigAiAssistanceStorageAgent,
   devToolsAiAssistanceV2: HostConfigAiAssistanceV2,
   devToolsAiCodeCompletion: HostConfigAiCodeCompletion,
   devToolsAiCodeGeneration: HostConfigAiCodeGeneration,

package/front_end/entrypoints/device_mode_emulation_frame/device_mode_emulation_frame.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import '../../core/dom_extension/dom_extension.js';
+import '../../ui/dom_extension/dom_extension.js';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore: tsc 6.0 does not support side-effect imports without a type definition.
 // We cannot use `@ts-expect-error` here because the import is correctly resolved

package/front_end/entrypoints/greendev_floaty/FloatyEntrypoint.ts

@@ -7,8 +7,11 @@ import '../../core/sdk/sdk-meta.js';
 import '../../models/workspace/workspace-meta.js';
 import '../../models/logs/logs-meta.js';
 import '../../panels/sensors/sensors-meta.js';
+import '../../panels/sources/sources-meta.js';
 import '../../entrypoints/inspector_main/inspector_main-meta.js';
 import '../../entrypoints/main/main-meta.js';
+import '../../ui/legacy/components/source_frame/source_frame-meta.js';
+import '../../ui/components/markdown_view/markdown_view.js';
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
@@ -22,6 +25,8 @@ import type * as Protocol from '../../generated/protocol.js';
 import * as AiAssistance from '../../models/ai_assistance/ai_assistance.js';
 import * as Greendev from '../../models/greendev/greendev.js';
 import type {SyncMessage} from '../../panels/greendev/GreenDevShared.js';
+import * as Marked from '../../third_party/marked/marked.js';
+import * as MarkdownView from '../../ui/components/markdown_view/markdown_view.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as ThemeSupport from '../../ui/legacy/theme_support/theme_support.js';
 
@@ -294,6 +299,8 @@ class GreenDevFloaty {
       nodeDescription: document.querySelector('.green-dev-floaty-dialog-node-description')?.textContent,
     });
 
+    let agentFinished = false;
+    let steps = 0;
     try {
       let results;
       if (useGreenDevAgent && this.#agent instanceof AiAssistance.GreenDevAgent.GreenDevAgent) {
@@ -302,7 +309,7 @@ class GreenDevFloaty {
           return;
         }
 
-        // --- Add the Accessibility Tree ---
+        // --- Get the Accessibility Tree ---
         const accessibilityModel = target.model(SDK.AccessibilityModel.AccessibilityModel);
         let axTree = '';
         if (accessibilityModel) {
@@ -315,7 +322,7 @@ class GreenDevFloaty {
           }
         }
 
-        // --- Add the most recent network requests ---
+        // --- Get the most recent network requests ---
         const allNetworkRequests = await AiAssistance.GreenDevAgent.GreenDevAgent.getNetworkContextData(target);
         const networkResourcesMax = 50;
         const startNetworkIndex = Math.max(0, allNetworkRequests.length - networkResourcesMax);
@@ -330,13 +337,13 @@ class GreenDevFloaty {
                   allNetworkRequests.length -
                   lastNetworkRequests.length} additional requests are available (network requests shown are capped at ${
                   networkResourcesMax} requests).` :
-              'No further network requests have been issued.';
+              'No further network requests are available.';
 
           formattedNetworkContext = `Showing network requests with indices ${startNetworkIndex}-${
               startNetworkIndex + lastNetworkRequests.length - 1}:\n\n${formattedNetworkContext}\n\n${footer}`;
         }
 
-        // --- Add the most recent console messages ---
+        // --- Get the most recent console messages ---
         const consoleModel = target.model(SDK.ConsoleModel.ConsoleModel);
         const allConsoleMessages = consoleModel ? consoleModel.messages() : [];
         const consoleMsgLimit = 50;
@@ -358,7 +365,7 @@ class GreenDevFloaty {
                   allConsoleMessages.length -
                   lastConsoleMessages.length} additional messages are available (errors shown are capped at ${
                   consoleMsgLimit} most recent).` :
-              'No further console messages have been emitted.';
+              'No further console messages are available.';
 
           formattedConsoleMessages = `Showing console messages with indices ${startIndex}-${
               startIndex + lastConsoleMessages.length - 1}:\n\n${formattedConsoleMessages}\n\n${footer}`;
@@ -366,8 +373,15 @@ class GreenDevFloaty {
 
         const mainUrl = target.inspectedURL();
 
-        // --- Add some context information about the selected node ---
+        // --- Get the React Props for the selected node (if available) ---
+        const reactComponentProps = this.#backendNodeId ?
+            await this.#agent.getReactComponentProps(this.#backendNodeId, false) :
+            'Could not get the backendNodeId for the selected element.';
+
+        // --- Get some context information about the selected node ---
         const elementContext = await AiAssistance.StylingAgent.StylingAgent.describeElement(this.#node);
+
+        // Now construct the full context.
         const context = `# Page URL
 
 ${mainUrl}
@@ -376,6 +390,10 @@ ${mainUrl}
 
 ${elementContext}
 
+# React component props:
+
+${reactComponentProps}
+
 # Recent network requests
 
 ${formattedNetworkContext}
@@ -401,15 +419,53 @@ ${axTree}`;
 
       for await (const result of results) {
         switch (result.type) {
-          case ResponseType.ANSWER:
-            aiContent.textContent = result.text;
+          case ResponseType.QUERYING:
+            steps++;
+            break;
+          case ResponseType.ANSWER: {
+            aiContent.textContent = '';
+            // Add a space in the protocol, which prevents links from being linkified in
+            // the markup. Why? Because there's an exception thrown if the links don't match the
+            // allowlist in getMarkdownLink(). Need to figure out later.
+            let sanitizedText = result.text.replace(/https:\/\//g, 'https: //');
+            sanitizedText = sanitizedText.replace(/http:\/\//g, 'http: //');
+            const markdown = new MarkdownView.MarkdownView.MarkdownView();
+            markdown.data = {
+              tokens: Marked.Marked.lexer(sanitizedText),
+            };
+            aiContent.append(markdown);
+            void new Promise(resolve => setTimeout(resolve, 0)).then(() => {
+              const style = document.createElement('style');
+              style.textContent =
+                  '.message { font-size: 1.0rem; } .message code { font-size: 1.0rem; font-family: \'Roboto Mono\', ' +
+                  'monospace; color: green; } .message ul { margin-left: 20px; }';
+              markdown.shadowRoot?.appendChild(style);
+
+              const codeBlocks = markdown.shadowRoot?.querySelectorAll('devtools-code-block');
+              if (codeBlocks) {
+                for (const codeBlock of codeBlocks) {
+                  const style = document.createElement('style');
+                  style.textContent = `
+.heading { color: black; background-color: #f2f6ff; font-family: 'Roboto Mono', monospace; padding: 2px 4px;
+           border-top-left-radius: 8px; border-top-right-radius: 8px; margin-bottom: 3px; }
+.code { background-color: #f8f9fa; font-family: 'Roboto Mono', monospace; padding: 5px;
+        border-bottom-left-radius: 8px; border-bottom-right-radius: 8px; }
+.editor-wrapper { margin-left: 20px; }
+                  `;
+                  codeBlock.shadowRoot?.appendChild(style);
+                }
+              }
+            });
             this.#syncChannel.postMessage(
                 {type: 'update-last-message', text: result.text, sessionId: this.#backendNodeId});
+            agentFinished = true;
             break;
+          }
           case ResponseType.ERROR:
             aiContent.textContent = this.#formatError(result.error);
             this.#syncChannel.postMessage(
                 {type: 'update-last-message', text: this.#formatError(result.error), sessionId: this.#backendNodeId});
+            agentFinished = true;
             break;
           case ResponseType.SIDE_EFFECT:
             result.confirm(true);
@@ -423,6 +479,14 @@ ${axTree}`;
       }
     } catch (e) {
       aiContent.textContent = `Exception: ${e instanceof Error ? e.message : String(e)}`;
+      agentFinished = true;
+    }
+
+    const MAX_AGENT_STEPS = AiAssistance.AiAgent.MAX_STEPS;
+    if (!agentFinished && steps >= MAX_AGENT_STEPS) {
+      aiContent.textContent = `The agent has reached its internal limit of ${MAX_AGENT_STEPS} steps per turn before
+      finding an answer. Please try again with a more specific query or say 'continue' (to get ${MAX_AGENT_STEPS}
+      more steps and continue trying).`;
     }
   };
 

package/front_end/entrypoints/greendev_floaty/floaty.html

@@ -20,7 +20,7 @@
       <div class="green-dev-floaty-dialog-blue-card">
         <div class="green-dev-floaty-dialog-node-description"></div>
         <div class="input-row">
-          <input type="text" class="green-dev-floaty-dialog-text-field" placeholder="Why is this not centered?">
+          <input type="text" class="green-dev-floaty-dialog-text-field" placeholder="Why is this hanging?">
           <button class="green-dev-floaty-dialog-play-button"></button>
         </div>
         <div class="green-dev-floaty-disclaimer">

package/front_end/entrypoints/shell/shell.ts

@@ -7,7 +7,7 @@
 // We cannot use `@ts-expect-error` here because the import is correctly resolved
 // when bundling the application (which doesn't error) and only errors in unbundled builds.
 import '../../Images/Images.js';
-import '../../core/dom_extension/dom_extension.js';
+import '../../ui/dom_extension/dom_extension.js';
 import '../../panels/sources/sources-meta.js';
 import '../../panels/profiler/profiler-meta.js';
 import '../../panels/console/console-meta.js';

package/front_end/generated/Deprecation.ts

@@ -210,6 +210,10 @@ export const UIStrings = {
    * @description Standard message when one web API is deprecated in favor of another.
    */
   PrefixedVideoSupportsFullscreen: "HTMLVideoElement.webkitSupportsFullscreen is deprecated. Please use Document.fullscreenEnabled instead.",
+  /**
+   * @description Warning displayed to developers when an SVG filter is applied to a disallowed content type.
+   */
+  PreventSvgFilterPaint: "SVG filters cannot be applied to cross-origin iframes, restricted iframes (e.g., sandboxed), or plugins.",
   /**
    * @description Standard message when one web API is deprecated in favor of another.
    */
@@ -390,6 +394,9 @@ export const DEPRECATIONS_METADATA: Partial<Record<string, DeprecationDescriptor
     "chromeStatusFeature": 5176235376246784,
     "milestone": 106
   },
+  "PreventSvgFilterPaint": {
+    "chromeStatusFeature": 5117170452398080
+  },
   "RTCConstraintEnableDtlsSrtpFalse": {
     "milestone": 97
   },

package/front_end/generated/InspectorBackendCommands.ts

@@ -1032,7 +1032,7 @@ inspectorBackend.registerEnum("Page.AdFrameExplanation", {ParentIsAd: "ParentIsA
 inspectorBackend.registerEnum("Page.SecureContextType", {Secure: "Secure", SecureLocalhost: "SecureLocalhost", InsecureScheme: "InsecureScheme", InsecureAncestor: "InsecureAncestor"});
 inspectorBackend.registerEnum("Page.CrossOriginIsolatedContextType", {Isolated: "Isolated", NotIsolated: "NotIsolated", NotIsolatedFeatureDisabled: "NotIsolatedFeatureDisabled"});
 inspectorBackend.registerEnum("Page.GatedAPIFeatures", {SharedArrayBuffers: "SharedArrayBuffers", SharedArrayBuffersTransferAllowed: "SharedArrayBuffersTransferAllowed", PerformanceMeasureMemory: "PerformanceMeasureMemory", PerformanceProfile: "PerformanceProfile"});
-inspectorBackend.registerEnum("Page.PermissionsPolicyFeature", {Accelerometer: "accelerometer", AllScreensCapture: "all-screens-capture", AmbientLightSensor: "ambient-light-sensor", AriaNotify: "aria-notify", AttributionReporting: "attribution-reporting", Autofill: "autofill", Autoplay: "autoplay", Bluetooth: "bluetooth", BrowsingTopics: "browsing-topics", Camera: "camera", CapturedSurfaceControl: "captured-surface-control", ChDpr: "ch-dpr", ChDeviceMemory: "ch-device-memory", ChDownlink: "ch-downlink", ChEct: "ch-ect", ChPrefersColorScheme: "ch-prefers-color-scheme", ChPrefersReducedMotion: "ch-prefers-reduced-motion", ChPrefersReducedTransparency: "ch-prefers-reduced-transparency", ChRtt: "ch-rtt", ChSaveData: "ch-save-data", ChUa: "ch-ua", ChUaArch: "ch-ua-arch", ChUaBitness: "ch-ua-bitness", ChUaHighEntropyValues: "ch-ua-high-entropy-values", ChUaPlatform: "ch-ua-platform", ChUaModel: "ch-ua-model", ChUaMobile: "ch-ua-mobile", ChUaFormFactors: "ch-ua-form-factors", ChUaFullVersion: "ch-ua-full-version", ChUaFullVersionList: "ch-ua-full-version-list", ChUaPlatformVersion: "ch-ua-platform-version", ChUaWow64: "ch-ua-wow64", ChViewportHeight: "ch-viewport-height", ChViewportWidth: "ch-viewport-width", ChWidth: "ch-width", ClipboardRead: "clipboard-read", ClipboardWrite: "clipboard-write", ComputePressure: "compute-pressure", ControlledFrame: "controlled-frame", CrossOriginIsolated: "cross-origin-isolated", DeferredFetch: "deferred-fetch", DeferredFetchMinimal: "deferred-fetch-minimal", DeviceAttributes: "device-attributes", DigitalCredentialsCreate: "digital-credentials-create", DigitalCredentialsGet: "digital-credentials-get", DirectSockets: "direct-sockets", DirectSocketsMulticast: "direct-sockets-multicast", DirectSocketsPrivate: "direct-sockets-private", DisplayCapture: "display-capture", DocumentDomain: "document-domain", EncryptedMedia: "encrypted-media", ExecutionWhileOutOfViewport: "execution-while-out-of-viewport", ExecutionWhileNotRendered: "execution-while-not-rendered", FocusWithoutUserActivation: "focus-without-user-activation", Fullscreen: "fullscreen", Frobulate: "frobulate", Gamepad: "gamepad", Geolocation: "geolocation", Gyroscope: "gyroscope", Hid: "hid", IdentityCredentialsGet: "identity-credentials-get", IdleDetection: "idle-detection", InterestCohort: "interest-cohort", JoinAdInterestGroup: "join-ad-interest-group", KeyboardMap: "keyboard-map", LanguageDetector: "language-detector", LanguageModel: "language-model", LocalFonts: "local-fonts", LocalNetwork: "local-network", LocalNetworkAccess: "local-network-access", LoopbackNetwork: "loopback-network", Magnetometer: "magnetometer", ManualText: "manual-text", MediaPlaybackWhileNotVisible: "media-playback-while-not-visible", Microphone: "microphone", Midi: "midi", OnDeviceSpeechRecognition: "on-device-speech-recognition", OtpCredentials: "otp-credentials", Payment: "payment", PictureInPicture: "picture-in-picture", PrivateAggregation: "private-aggregation", PrivateStateTokenIssuance: "private-state-token-issuance", PrivateStateTokenRedemption: "private-state-token-redemption", PublickeyCredentialsCreate: "publickey-credentials-create", PublickeyCredentialsGet: "publickey-credentials-get", RecordAdAuctionEvents: "record-ad-auction-events", Rewriter: "rewriter", RunAdAuction: "run-ad-auction", ScreenWakeLock: "screen-wake-lock", Serial: "serial", SharedStorage: "shared-storage", SharedStorageSelectUrl: "shared-storage-select-url", SmartCard: "smart-card", SpeakerSelection: "speaker-selection", StorageAccess: "storage-access", SubApps: "sub-apps", Summarizer: "summarizer", SyncXhr: "sync-xhr", Translator: "translator", Unload: "unload", Usb: "usb", UsbUnrestricted: "usb-unrestricted", VerticalScroll: "vertical-scroll", WebAppInstallation: "web-app-installation", WebPrinting: "web-printing", WebShare: "web-share", WindowManagement: "window-management", Writer: "writer", XrSpatialTracking: "xr-spatial-tracking"});
+inspectorBackend.registerEnum("Page.PermissionsPolicyFeature", {Accelerometer: "accelerometer", AllScreensCapture: "all-screens-capture", AmbientLightSensor: "ambient-light-sensor", AriaNotify: "aria-notify", AttributionReporting: "attribution-reporting", Autofill: "autofill", Autoplay: "autoplay", Bluetooth: "bluetooth", BrowsingTopics: "browsing-topics", Camera: "camera", CapturedSurfaceControl: "captured-surface-control", ChDpr: "ch-dpr", ChDeviceMemory: "ch-device-memory", ChDownlink: "ch-downlink", ChEct: "ch-ect", ChPrefersColorScheme: "ch-prefers-color-scheme", ChPrefersReducedMotion: "ch-prefers-reduced-motion", ChPrefersReducedTransparency: "ch-prefers-reduced-transparency", ChRtt: "ch-rtt", ChSaveData: "ch-save-data", ChUa: "ch-ua", ChUaArch: "ch-ua-arch", ChUaBitness: "ch-ua-bitness", ChUaHighEntropyValues: "ch-ua-high-entropy-values", ChUaPlatform: "ch-ua-platform", ChUaModel: "ch-ua-model", ChUaMobile: "ch-ua-mobile", ChUaFormFactors: "ch-ua-form-factors", ChUaFullVersion: "ch-ua-full-version", ChUaFullVersionList: "ch-ua-full-version-list", ChUaPlatformVersion: "ch-ua-platform-version", ChUaWow64: "ch-ua-wow64", ChViewportHeight: "ch-viewport-height", ChViewportWidth: "ch-viewport-width", ChWidth: "ch-width", ClipboardRead: "clipboard-read", ClipboardWrite: "clipboard-write", ComputePressure: "compute-pressure", ControlledFrame: "controlled-frame", CrossOriginIsolated: "cross-origin-isolated", DeferredFetch: "deferred-fetch", DeferredFetchMinimal: "deferred-fetch-minimal", DeviceAttributes: "device-attributes", DigitalCredentialsCreate: "digital-credentials-create", DigitalCredentialsGet: "digital-credentials-get", DirectSockets: "direct-sockets", DirectSocketsMulticast: "direct-sockets-multicast", DirectSocketsPrivate: "direct-sockets-private", DisplayCapture: "display-capture", DocumentDomain: "document-domain", EncryptedMedia: "encrypted-media", ExecutionWhileOutOfViewport: "execution-while-out-of-viewport", ExecutionWhileNotRendered: "execution-while-not-rendered", FocusWithoutUserActivation: "focus-without-user-activation", Fullscreen: "fullscreen", Frobulate: "frobulate", Gamepad: "gamepad", Geolocation: "geolocation", Gyroscope: "gyroscope", Hid: "hid", IdentityCredentialsGet: "identity-credentials-get", IdleDetection: "idle-detection", InterestCohort: "interest-cohort", JoinAdInterestGroup: "join-ad-interest-group", KeyboardMap: "keyboard-map", LanguageDetector: "language-detector", LanguageModel: "language-model", LocalFonts: "local-fonts", LocalNetwork: "local-network", LocalNetworkAccess: "local-network-access", LoopbackNetwork: "loopback-network", Magnetometer: "magnetometer", ManualText: "manual-text", MediaPlaybackWhileNotVisible: "media-playback-while-not-visible", Microphone: "microphone", Midi: "midi", OnDeviceSpeechRecognition: "on-device-speech-recognition", OtpCredentials: "otp-credentials", Payment: "payment", PictureInPicture: "picture-in-picture", PrivateAggregation: "private-aggregation", PrivateStateTokenIssuance: "private-state-token-issuance", PrivateStateTokenRedemption: "private-state-token-redemption", PublickeyCredentialsCreate: "publickey-credentials-create", PublickeyCredentialsGet: "publickey-credentials-get", RecordAdAuctionEvents: "record-ad-auction-events", Rewriter: "rewriter", RunAdAuction: "run-ad-auction", ScreenWakeLock: "screen-wake-lock", Serial: "serial", SharedStorage: "shared-storage", SharedStorageSelectUrl: "shared-storage-select-url", SmartCard: "smart-card", SpeakerSelection: "speaker-selection", StorageAccess: "storage-access", SubApps: "sub-apps", Summarizer: "summarizer", SyncXhr: "sync-xhr", Tools: "tools", Translator: "translator", Unload: "unload", Usb: "usb", UsbUnrestricted: "usb-unrestricted", VerticalScroll: "vertical-scroll", WebAppInstallation: "web-app-installation", WebPrinting: "web-printing", WebShare: "web-share", WindowManagement: "window-management", Writer: "writer", XrSpatialTracking: "xr-spatial-tracking"});
 inspectorBackend.registerEnum("Page.PermissionsPolicyBlockReason", {Header: "Header", IframeAttribute: "IframeAttribute", InFencedFrameTree: "InFencedFrameTree", InIsolatedApp: "InIsolatedApp"});
 inspectorBackend.registerEnum("Page.OriginTrialTokenStatus", {Success: "Success", NotSupported: "NotSupported", Insecure: "Insecure", Expired: "Expired", WrongOrigin: "WrongOrigin", InvalidSignature: "InvalidSignature", Malformed: "Malformed", WrongVersion: "WrongVersion", FeatureDisabled: "FeatureDisabled", TokenDisabled: "TokenDisabled", FeatureDisabledForUser: "FeatureDisabledForUser", UnknownTrial: "UnknownTrial"});
 inspectorBackend.registerEnum("Page.OriginTrialStatus", {Enabled: "Enabled", ValidTokenNotProvided: "ValidTokenNotProvided", OSNotSupported: "OSNotSupported", TrialNotAllowed: "TrialNotAllowed"});

package/front_end/generated/SupportedCSSProperties.js

@@ -1076,7 +1076,7 @@ export const generatedProperties = [
  {
   "inherited": true,
   "keywords": [
-   "auto",
+   "ellipsis",
    "no-ellipsis"
   ],
   "name": "block-ellipsis"
@@ -1945,7 +1945,7 @@ export const generatedProperties = [
  },
  {
   "keywords": [
-   "auto",
+   "normal",
    "collapse",
    "-webkit-legacy"
   ],
@@ -3950,7 +3950,7 @@ export const generatedProperties = [
   "inherited": true,
   "keywords": [
    "auto",
-   "none"
+   "spaces"
   ],
   "name": "ruby-overhang"
  },
@@ -5324,7 +5324,7 @@ export const generatedPropertyValues = {
  },
  "block-ellipsis": {
   "values": [
-   "auto",
+   "ellipsis",
    "no-ellipsis"
   ]
  },
@@ -5767,7 +5767,7 @@ export const generatedPropertyValues = {
  },
  "continue": {
   "values": [
-   "auto",
+   "normal",
    "collapse",
    "-webkit-legacy"
   ]
@@ -6885,7 +6885,7 @@ export const generatedPropertyValues = {
  "ruby-overhang": {
   "values": [
    "auto",
-   "none"
+   "spaces"
   ]
  },
  "ruby-position": {