chrome-devtools-frontend 1.0.1615539 → 1.0.1616061

package/front_end/third_party/puppeteer/package/src/bidi/Frame.ts

@@ -29,12 +29,8 @@ import {
   type WaitForOptions,
 } from '../api/Frame.js';
 import {PageEvent, type WaitTimeoutOptions} from '../api/Page.js';
+import type {Realm} from '../api/Realm.js';
 import {Accessibility} from '../cdp/Accessibility.js';
-import type {ConsoleMessageType} from '../common/ConsoleMessage.js';
-import {
-  ConsoleMessage,
-  type ConsoleMessageLocation,
-} from '../common/ConsoleMessage.js';
 import {TargetCloseError, UnsupportedOperation} from '../common/Errors.js';
 import type {TimeoutSettings} from '../common/TimeoutSettings.js';
 import type {Awaitable, HandleFor} from '../common/types.js';
@@ -50,34 +46,22 @@ import {BidiCdpSession} from './CDPSession.js';
 import type {BrowsingContext} from './core/BrowsingContext.js';
 import type {Navigation} from './core/Navigation.js';
 import type {Request} from './core/Request.js';
-import {BidiDeserializer} from './Deserializer.js';
 import {BidiDialog} from './Dialog.js';
 import {BidiElementHandle} from './ElementHandle.js';
 import {ExposableFunction} from './ExposedFunction.js';
 import {BidiHTTPRequest, requests} from './HTTPRequest.js';
 import type {BidiHTTPResponse} from './HTTPResponse.js';
-import {BidiJSHandle} from './JSHandle.js';
 import type {BidiPage} from './Page.js';
 import type {BidiRealm} from './Realm.js';
 import {BidiFrameRealm} from './Realm.js';
-import {rewriteNavigationError} from './util.js';
+import {
+  getConsoleMessage,
+  isConsoleLogEntry,
+  isJavaScriptLogEntry,
+  rewriteNavigationError,
+} from './util.js';
 import {BidiWebWorker} from './WebWorker.js';
 
-// TODO: Remove this and map CDP the correct method.
-// Requires breaking change.
-function convertConsoleMessageLevel(method: string): ConsoleMessageType {
-  switch (method) {
-    case 'group':
-      return 'startGroup';
-    case 'groupCollapsed':
-      return 'startGroupCollapsed';
-    case 'groupEnd':
-      return 'endGroup';
-    default:
-      return method as ConsoleMessageType;
-  }
-}
-
 export class BidiFrame extends Frame {
   static from(
     parent: BidiPage | BidiFrame,
@@ -178,30 +162,16 @@ export class BidiFrame extends Frame {
         return;
       }
       if (isConsoleLogEntry(entry)) {
+        if (!this.page().listenerCount(PageEvent.Console)) {
+          return;
+        }
         const args = entry.args.map(arg => {
           return this.mainRealm().createHandle(arg);
         });
 
-        const text = args
-          .reduce((value, arg) => {
-            const parsedValue =
-              arg instanceof BidiJSHandle && arg.isPrimitiveValue
-                ? BidiDeserializer.deserialize(arg.remoteValue())
-                : arg.toString();
-            return `${value} ${parsedValue}`;
-          }, '')
-          .slice(1);
-
         this.page().trustedEmitter.emit(
           PageEvent.Console,
-          new ConsoleMessage(
-            convertConsoleMessageLevel(entry.method),
-            text,
-            args,
-            getStackTraceLocations(entry.stackTrace),
-            this,
-            undefined,
-          ),
+          getConsoleMessage(entry, args, this),
         );
       } else if (isJavaScriptLogEntry(entry)) {
         const error = new Error(entry.text ?? '');
@@ -638,32 +608,8 @@ export class BidiFrame extends Frame {
       [element.remoteValue() as Bidi.Script.SharedReference],
     );
   }
-}
-
-function isConsoleLogEntry(
-  event: Bidi.Log.Entry,
-): event is Bidi.Log.ConsoleLogEntry {
-  return event.type === 'console';
-}
 
-function isJavaScriptLogEntry(
-  event: Bidi.Log.Entry,
-): event is Bidi.Log.JavascriptLogEntry {
-  return event.type === 'javascript';
-}
-
-function getStackTraceLocations(
-  stackTrace?: Bidi.Script.StackTrace,
-): ConsoleMessageLocation[] {
-  const stackTraceLocations: ConsoleMessageLocation[] = [];
-  if (stackTrace) {
-    for (const callFrame of stackTrace.callFrames) {
-      stackTraceLocations.push({
-        url: callFrame.url,
-        lineNumber: callFrame.lineNumber,
-        columnNumber: callFrame.columnNumber,
-      });
-    }
+  override extensionRealms(): Realm[] {
+    throw new UnsupportedOperation();
   }
-  return stackTraceLocations;
 }

package/front_end/third_party/puppeteer/package/src/bidi/Input.ts

@@ -732,7 +732,6 @@ export class BidiTouchscreen extends Touchscreen {
       width: 0.5 * 2, // 2 times default touch radius.
       height: 0.5 * 2, // 2 times default touch radius.
       pressure: 0.5,
-      altitudeAngle: Math.PI / 2,
     };
     const touch = new BidiTouchHandle(this.#page, this, id, x, y, properties);
     await touch.start(options);

package/front_end/third_party/puppeteer/package/src/bidi/Page.ts

@@ -13,6 +13,7 @@ import type {WindowId} from '../api/Browser.js';
 import type {CDPSession} from '../api/CDPSession.js';
 import type {DeviceRequestPrompt} from '../api/DeviceRequestPrompt.js';
 import type {BoundingBox} from '../api/ElementHandle.js';
+import type {Extension} from '../api/Extension.js';
 import type {WaitForOptions} from '../api/Frame.js';
 import type {HTTPResponse} from '../api/HTTPResponse.js';
 import type {
@@ -30,6 +31,7 @@ import {
   type NewDocumentScriptEvaluation,
   type ScreenshotOptions,
 } from '../api/Page.js';
+import type {Target} from '../api/Target.js';
 import {Coverage} from '../cdp/Coverage.js';
 import {EmulationManager} from '../cdp/EmulationManager.js';
 import type {
@@ -37,6 +39,7 @@ import type {
   NetworkConditions,
 } from '../cdp/NetworkManager.js';
 import {Tracing} from '../cdp/Tracing.js';
+import type {WebMCP} from '../cdp/WebMCP.js';
 import type {
   CookiePartitionKey,
   Cookie,
@@ -51,6 +54,7 @@ import type {PDFOptions} from '../common/PDFOptions.js';
 import type {Awaitable} from '../common/types.js';
 import {evaluationString, parsePDFOptions, timeout} from '../common/util.js';
 import type {Viewport} from '../common/Viewport.js';
+import type {Realm} from '../puppeteer-core.js';
 import {assert} from '../util/assert.js';
 import {bubble} from '../util/decorators.js';
 import {Deferred} from '../util/Deferred.js';
@@ -95,6 +99,9 @@ export class BidiPage extends Page {
   readonly mouse: BidiMouse;
   readonly touchscreen: BidiTouchscreen;
   readonly tracing: Tracing;
+  override get webmcp(): WebMCP {
+    throw new UnsupportedOperation();
+  }
   readonly coverage: Coverage;
   readonly #cdpEmulationManager: EmulationManager;
 
@@ -217,6 +224,10 @@ export class BidiPage extends Page {
     return this.#frame;
   }
 
+  override async triggerExtensionAction(_extension: Extension): Promise<void> {
+    throw new UnsupportedOperation();
+  }
+
   override async emulateFocusedPage(enabled: boolean): Promise<void> {
     return await this.#cdpEmulationManager.emulateFocus(enabled);
   }
@@ -661,8 +672,12 @@ export class BidiPage extends Page {
     throw new UnsupportedOperation();
   }
 
-  override target(): never {
-    throw new UnsupportedOperation();
+  override target(): Target {
+    const target = this.browserContext().getTargetForPage(this);
+    if (!target) {
+      throw new Error('Target not found for page');
+    }
+    return target;
   }
 
   override async waitForFileChooser(
@@ -1005,6 +1020,10 @@ export class BidiPage extends Page {
   override get bluetooth(): BluetoothEmulation {
     return this.mainFrame().browsingContext.bluetooth;
   }
+
+  override extensionRealms(): Realm[] {
+    throw new UnsupportedOperation();
+  }
 }
 
 // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type

package/front_end/third_party/puppeteer/package/src/bidi/Realm.ts

@@ -5,8 +5,10 @@
  */
 import * as Bidi from 'webdriver-bidi-protocol';
 
+import type {Extension} from '../api/Extension.js';
 import type {JSHandle} from '../api/JSHandle.js';
 import {Realm} from '../api/Realm.js';
+import {WebWorkerEvent} from '../api/WebWorker.js';
 import {ARIAQueryHandler} from '../common/AriaQueryHandler.js';
 import {LazyArg} from '../common/LazyArg.js';
 import {scriptInjector} from '../common/ScriptInjector.js';
@@ -20,6 +22,7 @@ import {
   PuppeteerURL,
   SOURCE_URL_REGEX,
 } from '../common/util.js';
+import {UnsupportedOperation} from '../index-browser.js';
 import type {PuppeteerInjectedUtil} from '../injected/injected.js';
 import {AsyncIterableUtil} from '../util/AsyncIterableUtil.js';
 import {stringifyFunction} from '../util/Function.js';
@@ -36,7 +39,12 @@ import {ExposableFunction} from './ExposedFunction.js';
 import type {BidiFrame} from './Frame.js';
 import {BidiJSHandle} from './JSHandle.js';
 import {BidiSerializer} from './Serializer.js';
-import {createEvaluationError, rewriteEvaluationError} from './util.js';
+import {
+  createEvaluationError,
+  getConsoleMessage,
+  isConsoleLogEntry,
+  rewriteEvaluationError,
+} from './util.js';
 import type {BidiWebWorker} from './WebWorker.js';
 
 /**
@@ -281,6 +289,14 @@ export abstract class BidiRealm extends Realm {
     await handle.dispose();
     return await transferredHandle;
   }
+
+  extension(): Promise<Extension | null> {
+    throw new UnsupportedOperation();
+  }
+
+  override get origin(): string {
+    throw new UnsupportedOperation();
+  }
 }
 
 /**
@@ -400,6 +416,28 @@ export class BidiWorkerRealm extends BidiRealm {
     this.#worker = frame;
   }
 
+  override initialize(): void {
+    super.initialize();
+    this.realm.on('log', entry => {
+      if (
+        isConsoleLogEntry(entry) &&
+        this.#worker.listenerCount(WebWorkerEvent.Console)
+      ) {
+        const args = entry.args.map(arg => {
+          return this.createHandle(arg);
+        });
+
+        const message = getConsoleMessage(
+          entry,
+          args,
+          undefined,
+          this.realm.id,
+        );
+        this.#worker.emit(WebWorkerEvent.Console, message);
+      }
+    });
+  }
+
   override get environment(): BidiWebWorker {
     return this.#worker;
   }

package/front_end/third_party/puppeteer/package/src/bidi/Target.ts

@@ -63,10 +63,7 @@ export class BidiPageTarget extends Target {
     return this.#page;
   }
   override async asPage(): Promise<BidiPage> {
-    return BidiPage.from(
-      this.browserContext(),
-      this.#page.mainFrame().browsingContext,
-    );
+    return await this.page();
   }
   override url(): string {
     return this.#page.url();
@@ -110,7 +107,7 @@ export class BidiFrameTarget extends Target {
     return this.#page;
   }
   override async asPage(): Promise<BidiPage> {
-    return BidiPage.from(this.browserContext(), this.#frame.browsingContext);
+    return await this.page();
   }
   override url(): string {
     return this.#frame.url();

package/front_end/third_party/puppeteer/package/src/bidi/core/Realm.ts

@@ -43,6 +43,8 @@ export abstract class Realm extends EventEmitter<{
   worker: DedicatedWorkerRealm;
   /** Emitted when a shared worker is created in the realm. */
   sharedworker: SharedWorkerRealm;
+  /** Emitted whenever a log entry is added to the realm. */
+  log: Bidi.Log.Entry;
 }> {
   #reason?: string;
   protected readonly disposables = new DisposableStack();
@@ -207,6 +209,13 @@ export class WindowRealm extends Realm {
 
       this.emit('worker', realm);
     });
+
+    sessionEmitter.on('log.entryAdded', entry => {
+      if (entry.source.realm !== this.id) {
+        return;
+      }
+      this.emit('log', entry);
+    });
   }
 
   override get session(): Session {
@@ -278,6 +287,13 @@ export class DedicatedWorkerRealm extends Realm {
 
       this.emit('worker', realm);
     });
+
+    sessionEmitter.on('log.entryAdded', entry => {
+      if (entry.source.realm !== this.id) {
+        return;
+      }
+      this.emit('log', entry);
+    });
   }
 
   override get session(): Session {
@@ -330,6 +346,13 @@ export class SharedWorkerRealm extends Realm {
 
       this.emit('worker', realm);
     });
+
+    sessionEmitter.on('log.entryAdded', entry => {
+      if (entry.source.realm !== this.id) {
+        return;
+      }
+      this.emit('log', entry);
+    });
   }
 
   override get session(): Session {

package/front_end/third_party/puppeteer/package/src/bidi/util.ts

@@ -6,10 +6,104 @@
 
 import type * as Bidi from 'webdriver-bidi-protocol';
 
+import type {Frame} from '../api/Frame.js';
+import {ConsoleMessage} from '../common/ConsoleMessage.js';
+import type {
+  ConsoleMessageLocation,
+  ConsoleMessageType,
+} from '../common/ConsoleMessage.js';
 import {ProtocolError, TimeoutError} from '../common/Errors.js';
 import {PuppeteerURL} from '../common/util.js';
 
+import type {BidiElementHandle} from './bidi.js';
 import {BidiDeserializer} from './Deserializer.js';
+import {BidiJSHandle} from './JSHandle.js';
+
+/**
+ * @internal
+ *
+ * TODO: Remove this and map CDP the correct method.
+ * Requires breaking change.
+ */
+export function convertConsoleMessageLevel(method: string): ConsoleMessageType {
+  switch (method) {
+    case 'group':
+      return 'startGroup';
+    case 'groupCollapsed':
+      return 'startGroupCollapsed';
+    case 'groupEnd':
+      return 'endGroup';
+    default:
+      return method as ConsoleMessageType;
+  }
+}
+
+/**
+ * @internal
+ */
+export function getStackTraceLocations(
+  stackTrace?: Bidi.Script.StackTrace,
+): ConsoleMessageLocation[] {
+  const stackTraceLocations: ConsoleMessageLocation[] = [];
+  if (stackTrace) {
+    for (const callFrame of stackTrace.callFrames) {
+      stackTraceLocations.push({
+        url: callFrame.url,
+        lineNumber: callFrame.lineNumber,
+        columnNumber: callFrame.columnNumber,
+      });
+    }
+  }
+  return stackTraceLocations;
+}
+
+/**
+ * @internal
+ */
+export function getConsoleMessage(
+  entry: Bidi.Log.ConsoleLogEntry,
+  args: Array<BidiJSHandle<unknown> | BidiElementHandle<Node>>,
+  frame?: Frame,
+  targetId?: string,
+): ConsoleMessage {
+  const text = args
+    .reduce((value, arg) => {
+      const parsedValue =
+        arg instanceof BidiJSHandle && arg.isPrimitiveValue
+          ? BidiDeserializer.deserialize(arg.remoteValue())
+          : arg.toString();
+      return `${value} ${parsedValue}`;
+    }, '')
+    .slice(1);
+
+  return new ConsoleMessage(
+    convertConsoleMessageLevel(entry.method),
+    text,
+    args,
+    getStackTraceLocations(entry.stackTrace),
+    frame,
+    undefined,
+    targetId,
+  );
+}
+
+/**
+ * @internal
+ */
+export function isConsoleLogEntry(
+  event: Bidi.Log.Entry,
+): event is Bidi.Log.ConsoleLogEntry {
+  return event.type === 'console';
+}
+
+/**
+ * @internal
+ */
+export function isJavaScriptLogEntry(
+  event: Bidi.Log.Entry,
+): event is Bidi.Log.JavascriptLogEntry {
+  return event.type === 'javascript';
+}
 
 /**
  * @internal

package/front_end/third_party/puppeteer/package/src/cdp/Browser.ts

@@ -23,6 +23,7 @@ import {
 } from '../api/Browser.js';
 import {BrowserContextEvent} from '../api/BrowserContext.js';
 import {CDPSessionEvent} from '../api/CDPSession.js';
+import type {Extension} from '../api/Extension.js';
 import type {Page} from '../api/Page.js';
 import type {Target} from '../api/Target.js';
 import type {DownloadBehavior} from '../common/DownloadBehavior.js';
@@ -31,6 +32,7 @@ import type {Viewport} from '../common/Viewport.js';
 import {CdpBrowserContext} from './BrowserContext.js';
 import type {CdpCDPSession} from './CdpSession.js';
 import type {Connection} from './Connection.js';
+import {CdpExtension} from './Extension.js';
 import {
   DevToolsTarget,
   InitializationStatus,
@@ -67,6 +69,7 @@ export class CdpBrowser extends BrowserBase {
     isPageTargetCallback?: IsPageTargetCallback,
     waitForInitiallyDiscoveredTargets = true,
     networkEnabled = true,
+    issuesEnabled = true,
     handleDevToolsAsPage = false,
   ): Promise<CdpBrowser> {
     const browser = new CdpBrowser(
@@ -79,6 +82,7 @@ export class CdpBrowser extends BrowserBase {
       isPageTargetCallback,
       waitForInitiallyDiscoveredTargets,
       networkEnabled,
+      issuesEnabled,
       handleDevToolsAsPage,
     );
     if (acceptInsecureCerts) {
@@ -98,8 +102,10 @@ export class CdpBrowser extends BrowserBase {
   #defaultContext: CdpBrowserContext;
   #contexts = new Map<string, CdpBrowserContext>();
   #networkEnabled = true;
+  #issuesEnabled = true;
   #targetManager: TargetManager;
   #handleDevToolsAsPage = false;
+  #extensions = new Map<string, Extension>();
 
   constructor(
     connection: Connection,
@@ -111,10 +117,12 @@ export class CdpBrowser extends BrowserBase {
     isPageTargetCallback?: IsPageTargetCallback,
     waitForInitiallyDiscoveredTargets = true,
     networkEnabled = true,
+    issuesEnabled = true,
     handleDevToolsAsPage = false,
   ) {
     super();
     this.#networkEnabled = networkEnabled;
+    this.#issuesEnabled = issuesEnabled;
     this.#defaultViewport = defaultViewport;
     this.#process = process;
     this.#connection = connection;
@@ -442,11 +450,38 @@ export class CdpBrowser extends BrowserBase {
 
   override async installExtension(path: string): Promise<string> {
     const {id} = await this.#connection.send('Extensions.loadUnpacked', {path});
+    this.#extensions.delete(id);
     return id;
   }
 
-  override uninstallExtension(id: string): Promise<void> {
-    return this.#connection.send('Extensions.uninstall', {id});
+  override async uninstallExtension(id: string): Promise<void> {
+    await this.#connection.send('Extensions.uninstall', {id});
+
+    // Currently sending the Extensions.uninstall command does not trigger
+    // the Target.targetDestroyed event for service workers. This causes
+    // flakiness in the extension tests.
+    // TODO(nroscino): Remove this once the event is correctly emitted.
+    const targetDestroyedPromises = [];
+    for (const [targetId, targetInfo] of this._targetManager()
+      .getDiscoveredTargetInfos()
+      .entries()) {
+      if (targetInfo.url.includes(id) && targetInfo.type === 'service_worker') {
+        this._targetManager().addToIgnoreTarget(targetId);
+        targetDestroyedPromises.push(
+          new Promise(resolve => {
+            return setTimeout(() => {
+              this.#connection.emit('Target.targetDestroyed', {
+                targetId: targetId,
+              });
+              resolve(null);
+            }, 0);
+          }),
+        );
+      }
+    }
+    await Promise.all(targetDestroyedPromises);
+
+    this.#extensions.delete(id);
   }
 
   override async screens(): Promise<ScreenInfo[]> {
@@ -528,6 +563,13 @@ export class CdpBrowser extends BrowserBase {
     return Promise.resolve();
   }
 
+  /**
+   * @internal
+   */
+  get _connection(): Connection {
+    return this.#connection;
+  }
+
   override get connected(): boolean {
     return !this.#connection._closed;
   }
@@ -545,4 +587,35 @@ export class CdpBrowser extends BrowserBase {
   override isNetworkEnabled(): boolean {
     return this.#networkEnabled;
   }
+
+  override async extensions(): Promise<Map<string, Extension>> {
+    const response = await this.#connection.send('Extensions.getExtensions');
+
+    const extensionsMap = new Map<string, Extension>();
+
+    for (const currExtension of response.extensions) {
+      if (this.#extensions.has(currExtension.id)) {
+        extensionsMap.set(
+          currExtension.id,
+          this.#extensions.get(currExtension.id)!,
+        );
+      } else {
+        const newExtension = new CdpExtension(
+          currExtension.id,
+          currExtension.version,
+          currExtension.name,
+          this,
+        );
+
+        extensionsMap.set(currExtension.id, newExtension);
+      }
+    }
+
+    this.#extensions = extensionsMap;
+    return this.#extensions;
+  }
+
+  override isIssuesEnabled(): boolean {
+    return this.#issuesEnabled;
+  }
 }

package/front_end/third_party/puppeteer/package/src/cdp/BrowserConnector.ts

@@ -26,6 +26,7 @@ export async function _connectToCdpBrowser(
   const {
     acceptInsecureCerts = false,
     networkEnabled = true,
+    issuesEnabled = true,
     defaultViewport = DEFAULT_VIEWPORT,
     downloadBehavior,
     targetFilter,
@@ -62,6 +63,7 @@ export async function _connectToCdpBrowser(
     isPageTarget,
     undefined,
     networkEnabled,
+    issuesEnabled,
     handleDevToolsAsPage,
   );
   return browser;

package/front_end/third_party/puppeteer/package/src/cdp/CdpIssue.ts

@@ -0,0 +1,30 @@
+/**
+ * @license
+ * Copyright 2026 Google Inc.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import type {Protocol} from 'devtools-protocol';
+
+import type {Issue} from '../api/Issue.js';
+
+/**
+ * @internal
+ */
+export class CdpIssue implements Issue {
+  #code: Protocol.Audits.InspectorIssueCode;
+  #details: Protocol.Audits.InspectorIssueDetails;
+
+  constructor(issue: Protocol.Audits.InspectorIssue) {
+    this.#code = issue.code;
+    this.#details = issue.details;
+  }
+
+  get code(): Protocol.Audits.InspectorIssueCode {
+    return this.#code;
+  }
+
+  get details(): Protocol.Audits.InspectorIssueDetails {
+    return this.#details;
+  }
+}