chrome-devtools-frontend 1.0.1611099 → 1.0.1611825

package/front_end/panels/application/WebMCPView.ts

@@ -433,19 +433,23 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
                   @click=${() => input.onCallSelect(null)}
                 ></devtools-button>
                 <devtools-widget
-                  id="details"
+                  id="webmcp.tool-details"
                   title=${i18nString(UIStrings.toolDetails)}
                   ${widget(ToolDetailsWidget, {tool: input.selectedCall?.tool})}>
                 </devtools-widget>
                 <devtools-widget
-                  id="inputs"
+                  id="webmcp.call-inputs"
                   title=${i18nString(UIStrings.input)}
                   ${widget(PayloadWidget, parsePayload(input.selectedCall?.input))}>
                 </devtools-widget>
                 <devtools-widget
-                  id="outputs"
+                  id="webmcp.call-outputs"
                   title=${i18nString(UIStrings.output)}
-                  ${widget(PayloadWidget, parsePayload(input.selectedCall?.result?.output))}>
+                  ${widget(PayloadWidget, {
+                          valueObject: input.selectedCall?.result?.output,
+                          errorText: input.selectedCall?.result?.errorText,
+                          exceptionDetails: input.selectedCall?.result?.exceptionDetails,
+                  })}>
                 </devtools-widget>
               </devtools-tabbed-pane>
             </div>
@@ -685,10 +689,12 @@ export class WebMCPView extends UI.Widget.VBox {
 export interface PayloadViewInput {
   valueObject?: unknown;
   valueString?: string;
+  errorText?: string;
+  exceptionDetails?: WebMCP.WebMCPModel.ExceptionDetails;
 }
 
 export const PAYLOAD_DEFAULT_VIEW = (input: PayloadViewInput, output: object, target: HTMLElement): void => {
-  if (input.valueObject === undefined && input.valueString === undefined) {
+  if (!input.valueObject && !input.valueString && !input.errorText && !input.exceptionDetails) {
     render(nothing, target);
     return;
   }
@@ -715,6 +721,52 @@ export const PAYLOAD_DEFAULT_VIEW = (input: PayloadViewInput, output: object, ta
   };
 
   const createSourceText = (text: string): TemplateResult => html`<div class="payload-value source-code">${text}</div>`;
+  const createErrorText = (text: string): TemplateResult =>
+      html`<div class="payload-value source-code error-text">${text}</div>`;
+
+  const createException = (
+      details: WebMCP.WebMCPModel.ExceptionDetails,
+      linkifier: Components.Linkifier.Linkifier = new Components.Linkifier.Linkifier(),
+      ): TemplateResult => {
+    const renderFrame = (
+        frame: StackTrace.ErrorStackParser.ParsedErrorFrame,
+        index: number,
+        array: StackTrace.ErrorStackParser.ParsedErrorFrame[],
+        ): TemplateResult => {
+      const newline = index < array.length - 1 ? '\n' : '';
+      const {line, link, isCallFrame} = frame;
+
+      if (!isCallFrame) {
+        return html`<span>${line}${newline}</span>`;
+      }
+
+      if (!link) {
+        return html`<span class="formatted-builtin-stack-frame">${line}${newline}</span>`;
+      }
+
+      const scriptLocationLink = linkifier.linkifyScriptLocation(
+          details.error.runtimeModel().target(),
+          link.scriptId || null,
+          link.url,
+          link.lineNumber,
+          {
+            columnNumber: link.columnNumber,
+            inlineFrameIndex: 0,
+            showColumnNumber: true,
+          },
+      );
+      scriptLocationLink.tabIndex = -1;
+
+      return html`<span class="formatted-stack-frame">${link.prefix}${scriptLocationLink}${link.suffix}${
+          newline}</span>`;
+    };
+
+    return html`
+      <div class="payload-value source-code error-text">
+        ${details.frames.length === 0 && details.description ? html`<span>${details.description}\n</span>` : nothing}
+        <div>${details.frames.map(renderFrame)}</div>
+        ${details.cause ? html`\nCaused by:\n${createException(details.cause, linkifier)}` : nothing}</div>`;
+  };
 
   render(
       html`
@@ -723,7 +775,10 @@ export const PAYLOAD_DEFAULT_VIEW = (input: PayloadViewInput, output: object, ta
       <div class="call-payload-content">
             ${
           isParsable ? createPayload(input.valueObject) :
-                       (input.valueString !== undefined ? createSourceText(input.valueString) : nothing)}
+                       (input.valueString !== undefined ?
+                            createSourceText(input.valueString) :
+                            (input.exceptionDetails ? createException(input.exceptionDetails) :
+                                                      (input.errorText ? createErrorText(input.errorText) : nothing)))}
       </div>
     </div>
   `,
@@ -733,6 +788,9 @@ export const PAYLOAD_DEFAULT_VIEW = (input: PayloadViewInput, output: object, ta
 export class PayloadWidget extends UI.Widget.Widget {
   #valueObject?: unknown;
   #valueString?: string;
+  #errorText?: string;
+  #exceptionDetailsPromise?: Promise<WebMCP.WebMCPModel.ExceptionDetails|undefined>;
+  #exceptionDetails?: WebMCP.WebMCPModel.ExceptionDetails;
   #view: typeof PAYLOAD_DEFAULT_VIEW;
 
   constructor(element?: HTMLElement, view = PAYLOAD_DEFAULT_VIEW) {
@@ -758,6 +816,37 @@ export class PayloadWidget extends UI.Widget.Widget {
     return this.#valueString;
   }
 
+  set errorText(errorText: string|undefined) {
+    this.#errorText = errorText;
+    this.requestUpdate();
+  }
+
+  get errorText(): string|undefined {
+    return this.#errorText;
+  }
+
+  async #updateExceptionDetails(
+      exceptionDetailsPromise: Promise<WebMCP.WebMCPModel.ExceptionDetails|undefined>|undefined): Promise<void> {
+    if (this.#exceptionDetailsPromise === exceptionDetailsPromise) {
+      return;
+    }
+    this.#exceptionDetailsPromise = exceptionDetailsPromise;
+    this.#exceptionDetails = undefined;
+    this.requestUpdate();
+    const exceptionDetails = await exceptionDetailsPromise;
+    if (this.#exceptionDetailsPromise === exceptionDetailsPromise) {
+      this.#exceptionDetails = exceptionDetails;
+      this.requestUpdate();
+    }
+  }
+
+  set exceptionDetails(exceptionDetailsPromise: Promise<WebMCP.WebMCPModel.ExceptionDetails|undefined>|undefined) {
+    void this.#updateExceptionDetails(exceptionDetailsPromise);
+  }
+
+  get exceptionDetails(): Promise<WebMCP.WebMCPModel.ExceptionDetails|undefined>|undefined {
+    return this.#exceptionDetailsPromise;
+  }
   override wasShown(): void {
     super.wasShown();
     this.requestUpdate();
@@ -767,6 +856,8 @@ export class PayloadWidget extends UI.Widget.Widget {
     const input: PayloadViewInput = {
       valueObject: this.#valueObject,
       valueString: this.#valueString,
+      errorText: this.#errorText,
+      exceptionDetails: this.#exceptionDetails,
     };
     this.#view(input, {}, this.contentElement);
   }

package/front_end/panels/application/webMCPView.css

@@ -48,7 +48,8 @@
         background-color: var(--sys-color-tonal-container);
       }
 
-      tr.selected.status-error {
+      tbody tr.selected.status-error,
+      tbody tr.selected.status-error.revealed {
         background-color: var(--sys-color-error-container);
         color: var(--sys-color-error);
       }
@@ -210,4 +211,9 @@
         flex: auto;
         overflow: auto;
     }
+
+    .payload-value.error-text {
+      color: var(--sys-color-error);
+      white-space: pre-wrap;
+    }
 }

package/front_end/panels/console/ConsolePinPane.ts

@@ -19,7 +19,7 @@ import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
 import consolePinPaneStyles from './consolePinPane.css.js';
 
-const {createRef, ref} = Directives;
+const {createRef, ref, repeat} = Directives;
 const {widget} = UI.Widget;
 
 const UIStrings = {
@@ -72,7 +72,7 @@ export const DEFAULT_PANE_VIEW = (input: PaneViewInput, _output: object, target:
   render(html`
     <style>${consolePinPaneStyles}</style>
     <div class='console-pins monospace' jslog=${VisualLogging.pane('console-pins')} @contextmenu=${input.onContextMenu}>
-    ${input.pins.map(pin => widget(ConsolePinPresenter, {
+    ${repeat(input.pins, pin => pin, pin => widget(ConsolePinPresenter, {
           pin,
           focusOut: input.focusOut,
           onRemove: () => input.onRemove(pin),
@@ -298,6 +298,10 @@ export class ConsolePinPresenter extends UI.Widget.Widget {
   set pin(pin: ConsolePin) {
     this.#pin?.removeEventListener(ConsolePinEvent.EVALUATE_RESULT_READY, this.requestUpdate, this);
     this.#pin = pin;
+    // Clear the existing editor reference so `performUpdate()` creates
+    // a new EditorState with the new pin's text, rather than reusing
+    // the stale one from the previous pin.
+    this.#editor = undefined;
     this.#pin.setEditor(this.#pinEditor);
     this.#pin.addEventListener(ConsolePinEvent.EVALUATE_RESULT_READY, this.requestUpdate, this);
     this.requestUpdate();

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -208,6 +208,12 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
     this.requestUpdate();
   }
 
+  override focus(): void {
+    void this.updateComplete.then(() => {
+      this.#editor?.focus();
+    });
+  }
+
   override performUpdate(): void {
     const input: ViewInput = {
       state: this.#getEditorState(),

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: Internal
 Version: N/A
-Revision: 295046833fe5ffe7765e09abf4e9c15980d09e76
+Revision: ba9b7fcecd6da792b29305cac5a406adc76fc1e5
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/third_party/lighthouse/README.chromium

@@ -1,7 +1,7 @@
 Name: Lighthouse
 Short Name: lighthouse
-Version: 13.0.2
-Revision: 440f8bf87117ef61dc970c3ce4cebf91d46eb181
+Version: 13.1.0
+Revision: 0248afea9c9443c9fddd73e705256e38e8c6e042
 Update Mechanism: Manual
 URL: https://github.com/GoogleChrome/lighthouse
 License: Apache-2.0