chrome-devtools-frontend 1.0.1609381 → 1.0.1611099

package/eslint.config.mjs

@@ -552,7 +552,9 @@ export default defineConfig([
         },
       ],
 
-      '@typescript-eslint/prefer-optional-chain': 'error',
+      // Broke in 8.58.0, waiting for a fix
+      // https://github.com/typescript-eslint/typescript-eslint/issues/12204
+      '@typescript-eslint/prefer-optional-chain': 'off',
 
       '@typescript-eslint/no-unsafe-function-type': 'error',
 

package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts

@@ -2779,16 +2779,6 @@ export abstract class HeapSnapshot {
     return null;
   }
 
-  idsOfObjectsWithName(name: string): number[] {
-    const ids = [];
-    for (let it = this.allNodes(); it.hasNext(); it.next()) {
-      if (it.item().name() === name) {
-        ids.push(it.item().id());
-      }
-    }
-    return ids;
-  }
-
   createEdgesProvider(nodeIndex: number): HeapSnapshotEdgesProvider {
     const node = this.createNode(nodeIndex);
     const filter = this.containmentEdgesFilter();

package/front_end/generated/SupportedCSSProperties.js

@@ -512,6 +512,7 @@ export const generatedProperties = [
    "grid-template-areas",
    "grid-template-columns",
    "grid-template-rows",
+   "hanging-punctuation",
    "hash",
    "height",
    "hostname",
@@ -1823,7 +1824,7 @@ export const generatedProperties = [
   "inherited": false,
   "keywords": [
    "all",
-   "auto",
+   "normal",
    "around",
    "between"
   ],
@@ -2778,6 +2779,16 @@ export const generatedProperties = [
   ],
   "name": "grid-template-rows"
  },
+ {
+  "inherited": true,
+  "keywords": [
+   "none",
+   "first",
+   "last",
+   "allow-end"
+  ],
+  "name": "hanging-punctuation"
+ },
  {
   "name": "hash"
  },
@@ -3904,7 +3915,7 @@ export const generatedProperties = [
   "inherited": false,
   "keywords": [
    "all",
-   "auto",
+   "normal",
    "around",
    "between"
   ],
@@ -5663,7 +5674,7 @@ export const generatedPropertyValues = {
  "column-rule-visibility-items": {
   "values": [
    "all",
-   "auto",
+   "normal",
    "around",
    "between"
   ]
@@ -6244,6 +6255,14 @@ export const generatedPropertyValues = {
    "none"
   ]
  },
+ "hanging-punctuation": {
+  "values": [
+   "none",
+   "first",
+   "last",
+   "allow-end"
+  ]
+ },
  "height": {
   "values": [
    "auto",
@@ -6824,7 +6843,7 @@ export const generatedPropertyValues = {
  "row-rule-visibility-items": {
   "values": [
    "all",
-   "auto",
+   "normal",
    "around",
    "between"
   ]

package/front_end/models/ai_assistance/agents/AccessibilityAgent.ts

@@ -62,6 +62,7 @@ Your role is to help users understand and fix accessibility issues found in Ligh
 # Constraints
 * **CRITICAL**: ALWAYS call a tool before providing an answer if an element path is available.
 * **CRITICAL**: You are an accessibility agent. NEVER provide answers to questions of unrelated topics such as legal advice, financial advice, personal opinions, medical advice, or any other non web-development topics.
+* **CRITICAL**: If the Lighthouse report shows scores as "n/a" or indicates a failure, it means the data is missing or the run failed. Do NOT assume that the page passed or has no issues.
 
 ## Response Structure
 
@@ -462,7 +463,13 @@ export class AccessibilityAgent extends AiAgent<LHModel.ReporterTypes.ReportJSON
   #getInitialPayload(context: ConversationContext<LHModel.ReporterTypes.ReportJSON>): string {
     const report = context.getItem();
     const formatter = new LighthouseFormatter();
-    return `# Lighthouse Report:\n${formatter.summary(report)}\n${formatter.audits(report, 'accessibility')}\n`;
+    const summary = formatter.summary(report);
+    const audits = formatter.audits(report, 'accessibility');
+    const allFailed = Object.values(report.categories).every(category => category.score === null);
+    if (allFailed) {
+      return '**CRITICAL**: The Lighthouse report failed to record or all category scores are error/unavailable (n/a). This indicates a failed run or missing data.';
+    }
+    return `# Lighthouse Report:\n${summary}\n${audits}`;
   }
 
   override async enhanceQuery(query: string, lhr: ConversationContext<LHModel.ReporterTypes.ReportJSON>|null):

package/front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.ts

@@ -17,7 +17,7 @@ const MAX_BODY_SIZE = 10000;
 /**
  * Sanitizes the set of headers, removing values that are not on the allow-list and replacing them with '<redacted>'.
  */
-function sanitizeHeaders(headers: Array<{name: string, value: string}>): Array<{name: string, value: string}> {
+export function sanitizeHeaders(headers: Array<{name: string, value: string}>): Array<{name: string, value: string}> {
   return headers.map(header => {
     if (NetworkRequestFormatter.allowHeader(header.name)) {
       return header;
@@ -69,11 +69,16 @@ export class NetworkRequestFormatter {
   }
 
   static formatInitiatorUrl(initiatorUrl: string, allowedOrigin: string): string {
-    const initiatorOrigin = new URL(initiatorUrl).origin;
-    if (initiatorOrigin === allowedOrigin) {
-      return initiatorUrl;
+    try {
+      // Some scheme or URLs might cause errors depending on the runtime environment.
+      const initiatorOrigin = new URL(initiatorUrl).origin;
+      if (initiatorOrigin === allowedOrigin) {
+        return initiatorUrl;
+      }
+      return '<redacted cross-origin initiator URL>';
+    } catch {
+      return '<redacted cross-origin initiator URL>';
     }
-    return '<redacted cross-origin initiator URL>';
   }
 
   static formatStatus(status: {

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -7100,6 +7100,10 @@ export const NativeFunctions = [
     name: "getElementTransform",
     signatures: [["element","draw_transform"]]
   },
+  {
+    name: "captureElementImage",
+    signatures: [["element"]]
+  },
   {
     name: "configureHighDynamicRange",
     signatures: [["options"]]
@@ -7735,18 +7739,14 @@ export const NativeFunctions = [
     name: "drawMesh",
     signatures: [["vertex_buffer","uv_buffer","index_buffer","image"]]
   },
-  {
-    name: "CanvasFilter",
-    signatures: [["init"]]
-  },
-  {
-    name: "drawElement",
-    signatures: [["element","dx","dy","?dwidth","?dheight"]]
-  },
   {
     name: "drawElementImage",
     signatures: [["element","dx","dy","?dwidth","?dheight"],["element","sx","sy","swidth","sheight","dx","dy","?dwidth","?dheight"]]
   },
+  {
+    name: "CanvasFilter",
+    signatures: [["init"]]
+  },
   {
     name: "Path2D",
     signatures: [["?path"]]
@@ -9073,10 +9073,6 @@ export const NativeFunctions = [
     name: "texElementImage2D",
     signatures: [["target","level","internalformat","format","type","element"],["target","level","internalformat","width","height","format","type","element"],["target","level","internalformat","sx","sy","swidth","sheight","format","type","element"],["target","level","internalformat","sx","sy","swidth","sheight","width","height","format","type","element"]]
   },
-  {
-    name: "texElement2D",
-    signatures: [["target","level","internalformat","format","type","element"],["target","level","internalformat","width","height","format","type","element"],["target","level","internalformat","sx","sy","swidth","sheight","format","type","element"],["target","level","internalformat","sx","sy","swidth","sheight","width","height","format","type","element"]]
-  },
   {
     name: "drawingBufferStorage",
     signatures: [["sizedformat","width","height"]]

package/front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -539,15 +539,13 @@ function defaultView(input: ViewInput, output: PanelViewOutput, target: HTMLElem
           <div slot="main" class="main-view">
             ${renderState()}
           </div>
-          <div slot="sidebar" class="sidebar-view">
-            ${shouldShowWalkthrough ? html`
-              <devtools-widget ${widget(WalkthroughView, {
-                message: input.props.walkthrough.activeSidebarMessage,
-                isLoading: input.props.isLoading && walkthroughIsForLastMessage,
-                markdownRenderer: input.props.markdownRenderer,
-                onToggle: input.props.walkthrough.onToggle,
-              })}></devtools-widget>` : Lit.nothing}
-          </div>
+          ${shouldShowWalkthrough ? html`
+            <devtools-widget slot="sidebar" ${widget(WalkthroughView, {
+              message: input.props.walkthrough.activeSidebarMessage,
+              isLoading: input.props.isLoading && walkthroughIsForLastMessage,
+              markdownRenderer: input.props.markdownRenderer,
+              onToggle: input.props.walkthrough.onToggle,
+            })}></devtools-widget>` : Lit.nothing}
         </devtools-split-view>
       </div>
     `, target);

package/front_end/panels/ai_assistance/components/ChatMessage.ts

@@ -199,7 +199,7 @@ const UIStringsNotTranslate = {
   /**
    * @description The title of the button that allows exporting the conversation for agents.
    */
-  exportForAgents: 'Copy for your coding agent',
+  exportForAgents: 'Copy to coding agent',
   /**
    * @description Title for the bottom up thread activity widget.
    */
@@ -417,6 +417,7 @@ export const DEFAULT_VIEW = (input: ChatMessageViewInput, output: ViewOutput, ta
         ` : Lit.nothing}
         ${input.showActions ? renderActions(input, output) : Lit.nothing}
       </div>
+      ${hasAiV2 ? renderSideEffectStepsUI(input, steps) : Lit.nothing}
     </section>
   `, target);
   // clang-format on
@@ -609,7 +610,6 @@ function renderWalkthroughUI(input: ChatMessageViewInput, steps: Step[]): Lit.Li
     // No steps = no walkthrough UI in the chat view.
     return Lit.nothing;
   }
-  const sideEffectSteps = steps.filter(s => s.requestApproval);
   // If the walkthrough is in the sidebar, we render a button into the
   // ChatView to open it.
   const openWalkThroughSidebarButton =
@@ -622,22 +622,6 @@ function renderWalkthroughUI(input: ChatMessageViewInput, steps: Step[]): Lit.Li
       input.walkthrough.inlineExpandedMessages.includes(input.message as ModelChatMessage) :
       (input.walkthrough.isExpanded && input.walkthrough.activeSidebarMessage === input.message);
 
-  // When a side-effect step is present and needs user approval, it's
-  // shown in the main chat UI, regardless of if the walkthrough is
-  // open or closed.
-  // Once the user has approved/denied it, it goes back into the sidebar.
-  // clang-format off
-  const sideEffectStepsUI = sideEffectSteps.length > 0 ? sideEffectSteps.map(step => html`
-    <div class="side-effect-container">
-      ${renderStep({
-         step,
-         isLoading: input.isLoading,
-         markdownRenderer: input.markdownRenderer,
-         isLast: true
-      })}
-    </div> `) : Lit.nothing;
-  // clang-format on
-
   // clang-format off
   const walkthroughInline = input.walkthrough.isInlined ? html`
     <div class="walkthrough-container">
@@ -656,7 +640,26 @@ function renderWalkthroughUI(input: ChatMessageViewInput, steps: Step[]): Lit.Li
   return html`
     ${openWalkThroughSidebarButton}
     ${walkthroughInline}
-    ${sideEffectStepsUI}
+  `;
+  // clang-format on
+}
+
+function renderSideEffectStepsUI(input: ChatMessageViewInput, steps: Step[]): Lit.LitTemplate {
+  const sideEffectSteps = steps.filter(s => s.requestApproval);
+  if (sideEffectSteps.length === 0) {
+    return Lit.nothing;
+  }
+  // clang-format off
+  return html`
+    ${sideEffectSteps.map(step => html`
+      <div class="side-effect-container">
+        ${renderStep({
+           step,
+           isLoading: input.isLoading,
+           markdownRenderer: input.markdownRenderer,
+           isLast: true
+        })}
+      </div> `)}
   `;
   // clang-format on
 }

package/front_end/panels/ai_assistance/components/ExportForAgentsDialog.ts

@@ -19,7 +19,7 @@ const UIStrings = {
   /**
    * @description Title for the export for agents dialog.
    */
-  exportForAgents: 'Copy for your coding agent',
+  exportForAgents: 'Copy to coding agent',
   /**
    * @description Button text for copying to clipboard.
    */

package/front_end/panels/ai_assistance/components/WalkthroughView.ts

@@ -246,6 +246,7 @@ export class WalkthroughView extends UI.Widget.Widget {
   constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
     super(element);
     this.#view = view;
+    this.setMinimumSize(330, 0);
   }
 
   override wasShown(): void {

package/front_end/panels/ai_assistance/components/chatMessage.css

@@ -13,6 +13,8 @@
     align-items: center;
     margin-block: calc(-1 * var(--sys-size-3));
     margin-top: var(--sys-size-5);
+    overflow: hidden;
+    mask-image: linear-gradient(to right, var(--ref-palette-neutral0) calc(100% - var(--sys-size-15)), transparent 100%);
 
     &.not-v2 {
       /* Can be removed when AIv2 ships */

package/front_end/panels/ai_assistance/components/walkthroughView.css

@@ -99,23 +99,24 @@
 
   .inline-wrapper {
     display: flex;
-    /* Note: no gap here; the gap is dealt with in padding on the text */
-    align-items: flex-start;
+    align-items: center;
+    gap: var(--sys-size-2);
     justify-content: flex-start;
 
     .inline-icon {
       display: block;
-      margin-top: var(--sys-size-2);
+    margin-top: var(--sys-size-2);
     }
   }
 
   .walkthrough-inline {
-    border-radius: var(--sys-size-5);
+    border-radius: var(--sys-shape-corner-full);
     overflow: hidden;
     width: fit-content;
     max-width: 100%;
 
     &[open] {
+      border-radius: var(--sys-size-5);
       width: auto;
       background-color: var(--sys-color-surface1);
       margin-left: calc(var(--sys-size-6) / 2);

package/front_end/panels/lighthouse/LighthousePanel.ts

@@ -159,7 +159,6 @@ export class LighthousePanel extends UI.Panel.Panel {
       this.renderStatusView();
       const {lhr, artifacts} = await this.controller.collectLighthouseResults();
       this.buildReportUI(lhr, artifacts);
-      UI.Context.Context.instance().setFlavor(ActiveLighthouseReport, new ActiveLighthouseReport(lhr));
       return {report: lhr};
     } catch (err) {
       this.handleError(err);
@@ -278,6 +277,7 @@ export class LighthousePanel extends UI.Panel.Panel {
     this.statusView.hide();
 
     this.reportSelector.selectNewReport();
+    UI.Context.Context.instance().setFlavor(ActiveLighthouseReport, null);
     this.contentElement.classList.toggle('in-progress', false);
 
     this.startView.show(this.contentElement);
@@ -324,6 +324,8 @@ export class LighthousePanel extends UI.Panel.Panel {
     this.newButton.setEnabled(true);
     this.refreshToolbarUI();
 
+    UI.Context.Context.instance().setFlavor(ActiveLighthouseReport, new ActiveLighthouseReport(lighthouseResult));
+
     const cachedRenderedReport = this.cachedRenderedReports.get(lighthouseResult);
     if (cachedRenderedReport) {
       this.auditResultsElement.appendChild(cachedRenderedReport);

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: Internal
 Version: N/A
-Revision: 5b539f63dc636f6b69d9c294a65bc5aff0bea3de
+Revision: 295046833fe5ffe7765e09abf4e9c15980d09e76
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -1850,6 +1850,7 @@ export const knownContextValues = new Set([
   'gu',
   'gutter',
   'gzip',
+  'hanging-punctuation',
   'hardware-concurrency',
   'hardware-concurrency-reset',
   'hardware-concurrency-selector',

package/mcp/mcp.ts

@@ -28,6 +28,7 @@ export {Target} from '../front_end/core/sdk/Target.js';
 export {TargetManager} from '../front_end/core/sdk/TargetManager.js';
 export * as Foundation from '../front_end/foundation/foundation.js';
 export * as Protocol from '../front_end/generated/protocol.js';
+export {NetworkRequestFormatter} from '../front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.js';
 export {
   PerformanceInsightFormatter
 } from '../front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.js';

package/package.json

@@ -49,8 +49,8 @@
     "@types/webidl2": "24.4.3",
     "@types/yargs": "17.0.35",
     "@types/yargs-unparser": "2.0.3",
-    "@typescript-eslint/rule-tester": "8.47.0",
-    "@typescript-eslint/utils": "8.47.0",
+    "@typescript-eslint/rule-tester": "8.58.0",
+    "@typescript-eslint/utils": "8.58.0",
     "@web/rollup-plugin-import-meta-assets": "2.3.0",
     "chai": "4.3.4",
     "cssnano": "7.1.2",
@@ -90,14 +90,13 @@
     "terser": "5.44.1",
     "ts-lit-plugin": "2.0.2",
     "typescript": "5.9.3",
-    "typescript-eslint": "8.47.0",
+    "typescript-eslint": "8.58.0",
     "uuid": "13.0.0",
     "webidl2": "24.5.0",
     "yargs": "17.7.2",
     "js-rouge": "3.2.0"
   },
   "overrides": {
-    "@typescript-eslint/types": "8.47.0",
     "baseline-browser-mapping": "2.8.25",
     "electron-to-chromium": "1.5.248",
     "caniuse-lite": "1.0.30001754",
@@ -105,5 +104,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1609381"
+  "version": "1.0.1611099"
 }