chrome-devtools-frontend 1.0.1606789 → 1.0.1608868

package/front_end/panels/profiler/HeapSnapshotGridNodes.ts

@@ -17,7 +17,6 @@ import * as UI from '../../ui/legacy/legacy.js';
 import {Directives, html, render} from '../../ui/lit/lit.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
-import type {ChildrenProvider} from './ChildrenProvider.js';
 import {
   type AllocationDataGrid,
   type HeapSnapshotConstructorsDataGrid,
@@ -25,7 +24,6 @@ import {
   type HeapSnapshotSortableDataGrid,
   HeapSnapshotSortableDataGridEvents,
 } from './HeapSnapshotDataGrids.js';
-import type {HeapSnapshotProviderProxy, HeapSnapshotProxy} from './HeapSnapshotProxy.js';
 import type {DataDisplayDelegate} from './ProfileHeader.js';
 
 const UIStrings = {
@@ -144,7 +142,7 @@ export class HeapSnapshotGridNode extends
     from: number,
     to: number,
   }>;
-  providerObject: ChildrenProvider|null;
+  providerObject: HeapSnapshotModel.ChildrenProvider.ChildrenProvider|null;
   reachableFromWindow: boolean;
   populated?: boolean;
 
@@ -169,7 +167,7 @@ export class HeapSnapshotGridNode extends
     return undefined;
   }
 
-  createProvider(): ChildrenProvider {
+  createProvider(): HeapSnapshotModel.ChildrenProvider.ChildrenProvider {
     throw new Error('Not implemented.');
   }
 
@@ -186,14 +184,14 @@ export class HeapSnapshotGridNode extends
   }
 
   retainersDataSource(): {
-    snapshot: HeapSnapshotProxy,
+    snapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy,
     snapshotNodeIndex: number,
     snapshotNodeId: number|undefined,
   }|null {
     return null;
   }
 
-  provider(): ChildrenProvider {
+  provider(): HeapSnapshotModel.ChildrenProvider.ChildrenProvider {
     if (!this.providerObject) {
       this.providerObject = this.createProvider();
     }
@@ -560,7 +558,7 @@ export abstract class HeapSnapshotGenericObjectNode extends HeapSnapshotGridNode
       this.detachedDOMTreeNode = true;
     }
 
-    const snapshot = (dataGrid.snapshot as HeapSnapshotProxy);
+    const snapshot = (dataGrid.snapshot as HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy);
     const shallowSizePercent = this.shallowSize / snapshot.totalSize * 100.0;
     const retainedSizePercent = this.retainedSize / snapshot.totalSize * 100.0;
 
@@ -578,12 +576,12 @@ export abstract class HeapSnapshotGenericObjectNode extends HeapSnapshotGridNode
   }
 
   override retainersDataSource(): {
-    snapshot: HeapSnapshotProxy,
+    snapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy,
     snapshotNodeIndex: number,
     snapshotNodeId: number|undefined,
   }|null {
     return this.snapshotNodeIndex === undefined ? null : {
-      snapshot: (this.dataGridInternal.snapshot as HeapSnapshotProxy),
+      snapshot: (this.dataGridInternal.snapshot as HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy),
       snapshotNodeIndex: this.snapshotNodeIndex,
       snapshotNodeId: this.snapshotNodeId,
     };
@@ -799,12 +797,12 @@ export class HeapSnapshotObjectNode extends HeapSnapshotGenericObjectNode {
   override referenceName: string;
   readonly referenceType: string;
   readonly edgeIndex: number;
-  readonly snapshot: HeapSnapshotProxy;
+  readonly snapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy;
   parentObjectNode: HeapSnapshotObjectNode|null;
   readonly cycledWithAncestorGridNode: HeapSnapshotObjectNode|null;
 
   constructor(
-      dataGrid: HeapSnapshotSortableDataGrid, snapshot: HeapSnapshotProxy,
+      dataGrid: HeapSnapshotSortableDataGrid, snapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy,
       edge: HeapSnapshotModel.HeapSnapshotModel.Edge, parentObjectNode: HeapSnapshotObjectNode|null) {
     super(dataGrid, edge.node);
     this.referenceName = edge.name;
@@ -829,7 +827,7 @@ export class HeapSnapshotObjectNode extends HeapSnapshotGenericObjectNode {
   }
 
   override retainersDataSource(): {
-    snapshot: HeapSnapshotProxy,
+    snapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy,
     snapshotNodeIndex: number,
     snapshotNodeId: number|undefined,
   }|null {
@@ -838,7 +836,7 @@ export class HeapSnapshotObjectNode extends HeapSnapshotGenericObjectNode {
         {snapshot: this.snapshot, snapshotNodeIndex: this.snapshotNodeIndex, snapshotNodeId: this.snapshotNodeId};
   }
 
-  override createProvider(): HeapSnapshotProviderProxy {
+  override createProvider(): HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProviderProxy {
     if (this.snapshotNodeIndex === undefined) {
       throw new Error('Cannot create a provider on a root node');
     }
@@ -925,7 +923,7 @@ export class HeapSnapshotObjectNode extends HeapSnapshotGenericObjectNode {
 export class HeapSnapshotRetainingObjectNode extends HeapSnapshotObjectNode {
   #ignored: boolean;
   constructor(
-      dataGrid: HeapSnapshotSortableDataGrid, snapshot: HeapSnapshotProxy,
+      dataGrid: HeapSnapshotSortableDataGrid, snapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy,
       edge: HeapSnapshotModel.HeapSnapshotModel.Edge, parentRetainingObjectNode: HeapSnapshotRetainingObjectNode|null) {
     super(dataGrid, snapshot, edge, parentRetainingObjectNode);
     this.#ignored = edge.node.ignored;
@@ -934,7 +932,7 @@ export class HeapSnapshotRetainingObjectNode extends HeapSnapshotObjectNode {
     }
   }
 
-  override createProvider(): HeapSnapshotProviderProxy {
+  override createProvider(): HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProviderProxy {
     if (this.snapshotNodeIndex === undefined) {
       throw new Error('Cannot create providers on root nodes');
     }
@@ -1021,10 +1019,10 @@ export class HeapSnapshotRetainingObjectNode extends HeapSnapshotObjectNode {
 }
 
 export class HeapSnapshotInstanceNode extends HeapSnapshotGenericObjectNode {
-  readonly baseSnapshotOrSnapshot: HeapSnapshotProxy;
+  readonly baseSnapshotOrSnapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy;
   readonly isDeletedNode: boolean;
   constructor(
-      dataGrid: HeapSnapshotSortableDataGrid, snapshot: HeapSnapshotProxy,
+      dataGrid: HeapSnapshotSortableDataGrid, snapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy,
       node: HeapSnapshotModel.HeapSnapshotModel.Node, isDeletedNode: boolean) {
     super(dataGrid, node);
     this.baseSnapshotOrSnapshot = snapshot;
@@ -1049,7 +1047,7 @@ export class HeapSnapshotInstanceNode extends HeapSnapshotGenericObjectNode {
   }
 
   override retainersDataSource(): {
-    snapshot: HeapSnapshotProxy,
+    snapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy,
     snapshotNodeIndex: number,
     snapshotNodeId: number|undefined,
   }|null {
@@ -1060,7 +1058,7 @@ export class HeapSnapshotInstanceNode extends HeapSnapshotGenericObjectNode {
     };
   }
 
-  override createProvider(): HeapSnapshotProviderProxy {
+  override createProvider(): HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProviderProxy {
     if (this.snapshotNodeIndex === undefined) {
       throw new Error('Cannot create providers on root nodes');
     }
@@ -1131,7 +1129,7 @@ export class HeapSnapshotConstructorNode extends HeapSnapshotGridNode {
     this.retainedSize = aggregate.maxRet;
     this.classKey = classKey;
 
-    const snapshot = (dataGrid.snapshot as HeapSnapshotProxy);
+    const snapshot = (dataGrid.snapshot as HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy);
     const retainedSizePercent = this.retainedSize / snapshot.totalSize * 100.0;
     const shallowSizePercent = this.shallowSize / snapshot.totalSize * 100.0;
     this.data = {
@@ -1149,8 +1147,8 @@ export class HeapSnapshotConstructorNode extends HeapSnapshotGridNode {
     return this.nameInternal;
   }
 
-  override createProvider(): HeapSnapshotProviderProxy {
-    return (this.dataGridInternal.snapshot as HeapSnapshotProxy)
+  override createProvider(): HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProviderProxy {
+    return (this.dataGridInternal.snapshot as HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy)
         .createNodesProviderForClass(this.classKey, this.nodeFilter);
   }
 
@@ -1186,7 +1184,8 @@ export class HeapSnapshotConstructorNode extends HeapSnapshotGridNode {
   override createChildNode(item: HeapSnapshotModel.HeapSnapshotModel.Node|HeapSnapshotModel.HeapSnapshotModel.Edge):
       HeapSnapshotInstanceNode {
     return new HeapSnapshotInstanceNode(
-        this.dataGridInternal, (this.dataGridInternal.snapshot as HeapSnapshotProxy),
+        this.dataGridInternal,
+        (this.dataGridInternal.snapshot as HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy),
         (item as HeapSnapshotModel.HeapSnapshotModel.Node), false);
   }
 
@@ -1209,14 +1208,15 @@ export class HeapSnapshotConstructorNode extends HeapSnapshotGridNode {
   }
 }
 
-export class HeapSnapshotDiffNodesProvider implements ChildrenProvider {
-  addedNodesProvider: HeapSnapshotProviderProxy;
-  deletedNodesProvider: HeapSnapshotProviderProxy;
+export class HeapSnapshotDiffNodesProvider implements HeapSnapshotModel.ChildrenProvider.ChildrenProvider {
+  addedNodesProvider: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProviderProxy;
+  deletedNodesProvider: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProviderProxy;
   addedCount: number;
   removedCount: number;
   constructor(
-      addedNodesProvider: HeapSnapshotProviderProxy, deletedNodesProvider: HeapSnapshotProviderProxy,
-      addedCount: number, removedCount: number) {
+      addedNodesProvider: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProviderProxy,
+      deletedNodesProvider: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProviderProxy, addedCount: number,
+      removedCount: number) {
     this.addedNodesProvider = addedNodesProvider;
     this.deletedNodesProvider = deletedNodesProvider;
     this.addedCount = addedCount;
@@ -1424,8 +1424,8 @@ export class AllocationGridNode extends HeapSnapshotGridNode {
   async doPopulate(): Promise<void> {
     this.populated = true;
 
-    const callers =
-        await (this.dataGridInternal.snapshot as HeapSnapshotProxy).allocationNodeCallers(this.allocationNode.id);
+    const callers = await (this.dataGridInternal.snapshot as HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy)
+                        .allocationNodeCallers(this.allocationNode.id);
 
     const callersChain = callers.nodesWithSingleCaller;
     let parentNode: AllocationGridNode = this;

package/front_end/panels/profiler/HeapSnapshotView.ts

@@ -34,7 +34,6 @@ import {
   HeapSnapshotGenericObjectNode,
   type HeapSnapshotGridNode,
 } from './HeapSnapshotGridNodes.js';
-import {type HeapSnapshotProxy, HeapSnapshotWorkerProxy} from './HeapSnapshotProxy.js';
 import {Events, HeapTimelineOverview, type IdsRangeChangedEvent, Samples} from './HeapTimelineOverview.js';
 import * as ModuleUIStrings from './ModuleUIStrings.js';
 import {
@@ -586,7 +585,7 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     }
   }
 
-  async retrieveStatistics(heapSnapshotProxy: HeapSnapshotProxy):
+  async retrieveStatistics(heapSnapshotProxy: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy):
       Promise<HeapSnapshotModel.HeapSnapshotModel.Statistics> {
     const statistics = await heapSnapshotProxy.getStatistics();
     const {v8heap, native} = statistics;
@@ -1646,11 +1645,12 @@ export interface TrackingHeapSnapshotProfileTypeEventTypes {
 export class HeapProfileHeader extends ProfileHeader {
   readonly heapProfilerModelInternal: SDK.HeapProfilerModel.HeapProfilerModel|null;
   maxJSObjectId = -1;
-  workerProxy: HeapSnapshotWorkerProxy|null = null;
+  workerProxy: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotWorkerProxy|null = null;
   receiver: Common.StringOutputStream.OutputStream|null = null;
-  snapshotProxy: HeapSnapshotProxy|null = null;
-  readonly loadPromise: Promise<HeapSnapshotProxy>;
-  fulfillLoad: (value: HeapSnapshotProxy|PromiseLike<HeapSnapshotProxy>) => void;
+  snapshotProxy: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy|null = null;
+  readonly loadPromise: Promise<HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy>;
+  fulfillLoad: (value: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy|
+                PromiseLike<HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy>) => void;
   totalNumberOfChunks = 0;
   bufferedWriter: Bindings.TempFile.TempFile|null = null;
   onTempFileReady: (() => void)|null = null;
@@ -1665,7 +1665,7 @@ export class HeapProfileHeader extends ProfileHeader {
   ) {
     super(type, title || i18nString(UIStrings.snapshotD, {PH1: type.nextProfileUid()}));
     this.heapProfilerModelInternal = heapProfilerModel;
-    const {promise, resolve} = Promise.withResolvers<HeapSnapshotProxy>();
+    const {promise, resolve} = Promise.withResolvers<HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy>();
     this.loadPromise = promise;
     this.fulfillLoad = resolve;
   }
@@ -1716,10 +1716,12 @@ export class HeapProfileHeader extends ProfileHeader {
 
   setupWorker(): void {
     console.assert(!this.workerProxy, 'HeapSnapshotWorkerProxy already exists');
-    this.workerProxy = new HeapSnapshotWorkerProxy(this.handleWorkerEvent.bind(this));
-    this.workerProxy.addEventListener(HeapSnapshotWorkerProxy.Events.WAIT, event => {
-      this.updateStatus(null, event.data);
-    }, this);
+    this.workerProxy =
+        new HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotWorkerProxy(this.handleWorkerEvent.bind(this));
+    this.workerProxy.addEventListener(
+        HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotWorkerProxy.Events.WAIT, event => {
+          this.updateStatus(null, event.data);
+        }, this);
     this.receiver = this.workerProxy.createLoader(this.uid, this.snapshotReceived.bind(this));
   }
 
@@ -1765,7 +1767,7 @@ export class HeapProfileHeader extends ProfileHeader {
     }
   }
 
-  snapshotReceived(snapshotProxy: HeapSnapshotProxy): void {
+  snapshotReceived(snapshotProxy: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy): void {
     if (this.wasDisposed) {
       return;
     }
@@ -1945,7 +1947,8 @@ export class HeapAllocationStackView extends UI.Widget.Widget {
     event.consume(true);
   }
 
-  async setAllocatedObject(snapshot: HeapSnapshotProxy, snapshotNodeIndex: number): Promise<void> {
+  async setAllocatedObject(snapshot: HeapSnapshotModel.HeapSnapshotProxy.HeapSnapshotProxy, snapshotNodeIndex: number):
+      Promise<void> {
     this.clear();
     const frames = await snapshot.allocationStack(snapshotNodeIndex);
 

package/front_end/panels/profiler/profiler.ts

@@ -3,12 +3,10 @@
 // found in the LICENSE file.
 
 import * as BottomUpProfileDataGrid from './BottomUpProfileDataGrid.js';
-import * as ChildrenProvider from './ChildrenProvider.js';
 import * as HeapProfilerPanel from './HeapProfilerPanel.js';
 import * as HeapProfileView from './HeapProfileView.js';
 import * as HeapSnapshotDataGrids from './HeapSnapshotDataGrids.js';
 import * as HeapSnapshotGridNodes from './HeapSnapshotGridNodes.js';
-import * as HeapSnapshotProxy from './HeapSnapshotProxy.js';
 import * as HeapSnapshotView from './HeapSnapshotView.js';
 import * as HeapTimelineOverview from './HeapTimelineOverview.js';
 import * as IsolateSelector from './IsolateSelector.js';
@@ -25,12 +23,10 @@ import * as TopDownProfileDataGrid from './TopDownProfileDataGrid.js';
 
 export {
   BottomUpProfileDataGrid,
-  ChildrenProvider,
   HeapProfilerPanel,
   HeapProfileView,
   HeapSnapshotDataGrids,
   HeapSnapshotGridNodes,
-  HeapSnapshotProxy,
   HeapSnapshotView,
   HeapTimelineOverview,
   IsolateSelector,

package/front_end/panels/snippets/SnippetsQuickOpen.ts

@@ -39,10 +39,10 @@ let snippetsQuickOpenInstance: SnippetsQuickOpen;
 export class SnippetsQuickOpen extends QuickOpen.FilteredListWidget.Provider {
   private snippets: Workspace.UISourceCode.UISourceCode[] = [];
 
-  static instance(opts: {forceNew: boolean|null, jslogContext: string}): SnippetsQuickOpen {
-    const {forceNew, jslogContext} = opts;
+  static instance(opts: {forceNew: boolean|null} = {forceNew: null}): SnippetsQuickOpen {
+    const {forceNew} = opts;
     if (!snippetsQuickOpenInstance || forceNew) {
-      snippetsQuickOpenInstance = new SnippetsQuickOpen(jslogContext);
+      snippetsQuickOpenInstance = new SnippetsQuickOpen();
     }
 
     return snippetsQuickOpenInstance;
@@ -98,9 +98,9 @@ export class SnippetsQuickOpen extends QuickOpen.FilteredListWidget.Provider {
 QuickOpen.FilteredListWidget.registerProvider({
   prefix: '!',
   iconName: 'exclamation',
-  provider: jslogContext => Promise.resolve(SnippetsQuickOpen.instance({forceNew: null, jslogContext})),
+  provider: () => Promise.resolve(SnippetsQuickOpen.instance()),
   helpTitle: i18nLazyString(UIStrings.runSnippet),
   titlePrefix: i18nLazyString(UIStrings.run),
   titleSuggestion: i18nLazyString(UIStrings.snippet),
-  jslogContext: 'snippet'
+  jslogContext: 'snippet',
 });

package/front_end/panels/sources/FilteredUISourceCodeListProvider.ts

@@ -37,8 +37,8 @@ export class FilteredUISourceCodeListProvider extends QuickOpen.FilteredListWidg
   private uiSourceCodes: Workspace.UISourceCode.UISourceCode[];
   private readonly uiSourceCodeIds: Set<string>;
   private query!: string;
-  constructor(jslogContext: string) {
-    super(jslogContext);
+  constructor() {
+    super();
 
     this.queryLineNumberAndColumnNumber = '';
     this.defaultScores = null;

package/front_end/panels/sources/sources-meta.ts

@@ -2010,22 +2010,22 @@ UI.ContextMenu.registerItem({
 QuickOpen.FilteredListWidget.registerProvider({
   prefix: '@',
   iconName: 'symbol',
-  async provider(jslogContext: string) {
+  async provider() {
     const Sources = await loadSourcesModule();
-    return new Sources.OutlineQuickOpen.OutlineQuickOpen(jslogContext);
+    return new Sources.OutlineQuickOpen.OutlineQuickOpen();
   },
   helpTitle: i18nLazyString(UIStrings.goToSymbol),
   titlePrefix: i18nLazyString(UIStrings.goTo),
   titleSuggestion: i18nLazyString(UIStrings.symbol),
-  jslogContext: 'source-symbol'
+  jslogContext: 'source-symbol',
 });
 
 QuickOpen.FilteredListWidget.registerProvider({
   prefix: ':',
   iconName: 'colon',
-  async provider(jslogContext: string) {
+  async provider() {
     const Sources = await loadSourcesModule();
-    return new Sources.GoToLineQuickOpen.GoToLineQuickOpen(jslogContext);
+    return new Sources.GoToLineQuickOpen.GoToLineQuickOpen();
   },
   helpTitle: i18nLazyString(UIStrings.goToLine),
   titlePrefix: i18nLazyString(UIStrings.goTo),
@@ -2036,9 +2036,9 @@ QuickOpen.FilteredListWidget.registerProvider({
 QuickOpen.FilteredListWidget.registerProvider({
   prefix: '',
   iconName: 'document',
-  async provider(jslogContext: string) {
+  async provider() {
     const Sources = await loadSourcesModule();
-    return new Sources.OpenFileQuickOpen.OpenFileQuickOpen(jslogContext);
+    return new Sources.OpenFileQuickOpen.OpenFileQuickOpen();
   },
   helpTitle: i18nLazyString(UIStrings.openFile),
   titlePrefix: i18nLazyString(UIStrings.open),

package/front_end/panels/timeline/CompatibilityTracksAppender.ts

@@ -6,7 +6,6 @@
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
 import * as Trace from '../../models/trace/trace.js';
 import * as SourceMapsResolver from '../../models/trace_source_maps_resolver/trace_source_maps_resolver.js';
 import type * as PerfUI from '../../ui/legacy/components/perf_ui/perf_ui.js';
@@ -314,8 +313,7 @@ export class CompatibilityTracksAppender {
       }
     };
     const threads = Trace.Handlers.Threads.threadsInTrace(this.#parsedTrace.data);
-    const showAllEvents =
-        Root.Runtime.experiments.isEnabled(Root.ExperimentNames.ExperimentName.TIMELINE_SHOW_ALL_EVENTS);
+    const showAllEvents = Common.Settings.Settings.instance().moduleSetting('timeline-show-all-events').get();
 
     for (const {pid, tid, name, type, entries, tree} of threads) {
       if (this.#parsedTrace.data.Meta.traceIsGeneric) {

package/front_end/panels/timeline/ThirdPartyTreeView.ts

@@ -258,7 +258,12 @@ export class ThirdPartyTreeViewWidget extends TimelineTreeView.TimelineTreeView
     return Boolean(entity) && entity?.category === 'Chrome Extension';
   }
 
-  set maxRows(maxRows: number) {
+  override get maxRows(): number|undefined {
+    return super.maxRows;
+  }
+
+  override set maxRows(maxRows: number) {
+    super.maxRows = maxRows;
     this.element.style.setProperty('--max-rows', String(maxRows));
     this.element.classList.toggle('has-max-rows', Boolean(maxRows));
   }

package/front_end/panels/timeline/ThreadAppender.ts

@@ -4,7 +4,6 @@
 import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
-import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import * as Trace from '../../models/trace/trace.js';
@@ -151,8 +150,7 @@ export class ThreadAppender implements TrackAppender {
   #headerAppended = false;
   readonly threadType: Trace.Handlers.Threads.ThreadType = Trace.Handlers.Threads.ThreadType.MAIN_THREAD;
   readonly isOnMainFrame: boolean;
-  #showAllEventsEnabled =
-      Root.Runtime.experiments.isEnabled(Root.ExperimentNames.ExperimentName.TIMELINE_SHOW_ALL_EVENTS);
+  #showAllEventsEnabled = Common.Settings.Settings.instance().moduleSetting('timeline-show-all-events').get();
   #url = '';
   #headerNestingLevel: number|null = null;
   constructor(

package/front_end/panels/timeline/TimelineController.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import type * as Common from '../../core/common/common.js';
+import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
@@ -229,7 +229,7 @@ export class TimelineController implements Tracing.TracingManager.TracingManager
     // 'disabled-by-default-v8.cpu_profiler'
     //   └ default: on, option: enableJSSampling
     const categoriesArray = [
-      Root.Runtime.experiments.isEnabled(Root.ExperimentNames.ExperimentName.TIMELINE_SHOW_ALL_EVENTS) ? '*' : '-*',
+      Common.Settings.Settings.instance().moduleSetting('timeline-show-all-events').get() ? '*' : '-*',
       Trace.Types.Events.Categories.Console,
       Trace.Types.Events.Categories.Loading,
       Trace.Types.Events.Categories.UserTiming,

package/front_end/panels/timeline/TimelinePanel.ts

@@ -739,8 +739,7 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
 
   #instantiateNewModel(): Trace.TraceModel.Model {
     const config = Trace.Types.Configuration.defaults();
-    config.showAllEvents =
-        Root.Runtime.experiments.isEnabled(Root.ExperimentNames.ExperimentName.TIMELINE_SHOW_ALL_EVENTS);
+    config.showAllEvents = Common.Settings.Settings.instance().moduleSetting('timeline-show-all-events').get();
     config.debugMode = Root.Runtime.experiments.isEnabled(Root.ExperimentNames.ExperimentName.TIMELINE_DEBUG_MODE);
 
     const traceEngineModel = Trace.TraceModel.Model.createWithAllHandlers(config);
@@ -2072,8 +2071,7 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
 
   #applyActiveFilters(traceIsGeneric: boolean, exclusiveFilter: Trace.Extras.TraceFilter.TraceFilter|null = null):
       void {
-    if (traceIsGeneric ||
-        Root.Runtime.experiments.isEnabled(Root.ExperimentNames.ExperimentName.TIMELINE_SHOW_ALL_EVENTS)) {
+    if (traceIsGeneric || Common.Settings.Settings.instance().moduleSetting('timeline-show-all-events').get()) {
       return;
     }
 

package/front_end/panels/timeline/TimelineTreeView.ts

@@ -201,6 +201,7 @@ export class TimelineTreeView extends
   // suitable for AI assistance widgets. It removes sidebars and toolbars.
   #compactMode = false;
   #maxLinkLength: number|undefined = undefined;
+  #maxRows: number|undefined = undefined;
 
   /**
    * Determines if the first child in the data grid will be selected
@@ -281,6 +282,18 @@ export class TimelineTreeView extends
     this.#maxLinkLength = maxLinkLength;
   }
 
+  get maxRows(): number|undefined {
+    return this.#maxRows;
+  }
+
+  set maxRows(maxRows: number|undefined) {
+    if (this.#maxRows === maxRows) {
+      return;
+    }
+    this.#maxRows = maxRows;
+    this.refreshTree();
+  }
+
   #applyCompactMode(): void {
     if (this.#compactMode && this.dataGrid) {
       this.splitWidget?.detach();
@@ -516,15 +529,32 @@ export class TimelineTreeView extends
       maxSelfTime = Math.max(maxSelfTime, child.selfTime);
       maxTotalTime = Math.max(maxTotalTime, child.totalTime);
     }
+
+    const gridNodes: GridNode[] = [];
     for (const child of children.values()) {
-      // Exclude the idle time off the total calculation.
       const gridNode = new TreeGridNode(child, totalUsedTime, maxSelfTime, maxTotalTime, this);
       for (const e of child.events) {
         this.eventToTreeNode.set(e, child);
       }
-      this.dataGrid.insertChild(gridNode);
+      gridNodes.push(gridNode);
     }
+
+    const columnId = this.dataGrid.sortColumnId() || 'self';
+    const sortFunction = this.getSortingFunction(columnId);
+    if (sortFunction) {
+      gridNodes.sort((a, b) => {
+        const res = sortFunction(a, b);
+        return this.dataGrid.isSortOrderAscending() ? res : -res;
+      });
+    }
+
+    const countToInsert = this.#maxRows !== undefined ? Math.min(this.#maxRows, gridNodes.length) : gridNodes.length;
+    for (let i = 0; i < countToInsert; i++) {
+      this.dataGrid.insertChild(gridNodes[i]);
+    }
+
     this.sortingChanged();
+
     this.updateDetailsForSelection();
     if (this.searchableView) {
       this.searchableView.refreshSearch();