chrome-devtools-frontend 1.0.1603822 → 1.0.1604514

package/front_end/generated/SupportedCSSProperties.js

@@ -1747,10 +1747,16 @@ export const generatedProperties = [
  },
  {
   "inherited": false,
+  "keywords": [
+   "overlap-join"
+  ],
   "name": "column-rule-edge-inset-end"
  },
  {
   "inherited": false,
+  "keywords": [
+   "overlap-join"
+  ],
   "name": "column-rule-edge-inset-start"
  },
  {
@@ -1785,10 +1791,16 @@ export const generatedProperties = [
  },
  {
   "inherited": false,
+  "keywords": [
+   "overlap-join"
+  ],
   "name": "column-rule-interior-inset-end"
  },
  {
   "inherited": false,
+  "keywords": [
+   "overlap-join"
+  ],
   "name": "column-rule-interior-inset-start"
  },
  {
@@ -2805,7 +2817,8 @@ export const generatedProperties = [
   "keywords": [
    "normal",
    "running",
-   "paused"
+   "paused",
+   "stopped"
   ],
   "name": "image-animation"
  },
@@ -3814,10 +3827,16 @@ export const generatedProperties = [
  },
  {
   "inherited": false,
+  "keywords": [
+   "overlap-join"
+  ],
   "name": "row-rule-edge-inset-end"
  },
  {
   "inherited": false,
+  "keywords": [
+   "overlap-join"
+  ],
   "name": "row-rule-edge-inset-start"
  },
  {
@@ -3852,10 +3871,16 @@ export const generatedProperties = [
  },
  {
   "inherited": false,
+  "keywords": [
+   "overlap-join"
+  ],
   "name": "row-rule-interior-inset-end"
  },
  {
   "inherited": false,
+  "keywords": [
+   "overlap-join"
+  ],
   "name": "row-rule-interior-inset-start"
  },
  {
@@ -5598,6 +5623,26 @@ export const generatedPropertyValues = {
    "currentcolor"
   ]
  },
+ "column-rule-edge-inset-end": {
+  "values": [
+   "overlap-join"
+  ]
+ },
+ "column-rule-edge-inset-start": {
+  "values": [
+   "overlap-join"
+  ]
+ },
+ "column-rule-interior-inset-end": {
+  "values": [
+   "overlap-join"
+  ]
+ },
+ "column-rule-interior-inset-start": {
+  "values": [
+   "overlap-join"
+  ]
+ },
  "column-rule-style": {
   "values": [
    "none",
@@ -6220,7 +6265,8 @@ export const generatedPropertyValues = {
   "values": [
    "normal",
    "running",
-   "paused"
+   "paused",
+   "stopped"
   ]
  },
  "image-rendering": {
@@ -6737,6 +6783,26 @@ export const generatedPropertyValues = {
    "currentcolor"
   ]
  },
+ "row-rule-edge-inset-end": {
+  "values": [
+   "overlap-join"
+  ]
+ },
+ "row-rule-edge-inset-start": {
+  "values": [
+   "overlap-join"
+  ]
+ },
+ "row-rule-interior-inset-end": {
+  "values": [
+   "overlap-join"
+  ]
+ },
+ "row-rule-interior-inset-start": {
+  "values": [
+   "overlap-join"
+  ]
+ },
  "row-rule-style": {
   "values": [
    "none",

package/front_end/generated/protocol-mapping.d.ts

@@ -1892,6 +1892,13 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.Cast.StopCastingRequest];
       returnType: void;
     };
+    /**
+     * Returns all entries in the CrashReportContext across all frames in the page.
+     */
+    'CrashReportContext.getEntries': {
+      paramsType: [];
+      returnType: Protocol.CrashReportContext.GetEntriesResponse;
+    };
     /**
      * Collects class names for the node with given id and all of it's child nodes.
      */

package/front_end/generated/protocol-proxy-api.d.ts

@@ -38,6 +38,8 @@ declare namespace ProtocolProxyApi {
 
     Cast: CastApi;
 
+    CrashReportContext: CrashReportContextApi;
+
     DOM: DOMApi;
 
     DOMDebugger: DOMDebuggerApi;
@@ -149,6 +151,8 @@ declare namespace ProtocolProxyApi {
 
     Cast: CastDispatcher;
 
+    CrashReportContext: CrashReportContextDispatcher;
+
     DOM: DOMDispatcher;
 
     DOMDebugger: DOMDebuggerDispatcher;
@@ -1046,6 +1050,16 @@ declare namespace ProtocolProxyApi {
 
   }
 
+  export interface CrashReportContextApi {
+    /**
+     * Returns all entries in the CrashReportContext across all frames in the page.
+     */
+    invoke_getEntries(): Promise<Protocol.CrashReportContext.GetEntriesResponse>;
+
+  }
+  export interface CrashReportContextDispatcher {
+  }
+
   export interface DOMApi {
     /**
      * Collects class names for the node with given id and all of it's child nodes.

package/front_end/generated/protocol.ts

@@ -4525,6 +4525,28 @@ export namespace Cast {
   }
 }
 
+/**
+ * This domain exposes the current state of the CrashReportContext API.
+ */
+export namespace CrashReportContext {
+
+  /**
+   * Key-value pair in CrashReportContext.
+   */
+  export interface CrashReportContextEntry {
+    key: string;
+    value: string;
+    /**
+     * The ID of the frame where the key-value pair was set.
+     */
+    frameId: Page.FrameId;
+  }
+
+  export interface GetEntriesResponse extends ProtocolResponseWithError {
+    entries: CrashReportContextEntry[];
+  }
+}
+
 /**
  * This domain exposes DOM read/write operations. Each DOM Node is represented with its mirror object
  * that has an `id`. This `id` can be used to get additional information on the Node, resolve it into

package/front_end/models/bindings/TempFile.ts

@@ -7,10 +7,7 @@ import * as Common from '../../core/common/common.js';
 import {ChunkedFileReader, type ChunkedReader} from './FileUtils.js';
 
 export class TempFile {
-  #lastBlob: Blob|null;
-  constructor() {
-    this.#lastBlob = null;
-  }
+  #lastBlob: Blob|null = null;
 
   write(pieces: Array<string|Blob>): void {
     if (this.#lastBlob) {

package/front_end/models/extensions/ExtensionAPI.ts

@@ -616,7 +616,7 @@ self.injectedExtensionAPI = function(
           entries[i].__proto__ = new (Constructor(Request))(entries[i]._requestId as number);
           delete entries[i]._requestId;
         }
-        callback?.(result as Object);
+        callback?.(result);
       }
       extensionServer.sendRequest({command: PrivateAPI.Commands.GetHAR}, callback && callbackWrapper);
     },

package/front_end/models/heap_snapshot_model/HeapSnapshotModel.ts

@@ -71,13 +71,19 @@ export class Node {
   retainedSize: number;
   selfSize: number;
   type: string;
-  canBeQueried: boolean;
-  detachedDOMTreeNode: boolean;
-  isAddedNotRemoved: boolean|null;
-  ignored: boolean;
+  canBeQueried = false;
+  detachedDOMTreeNode = false;
+  isAddedNotRemoved: boolean|null = null;
+  ignored = false;
   constructor(
-      id: number, name: string, distance: number, nodeIndex: number, retainedSize: number, selfSize: number,
-      type: string) {
+      id: number,
+      name: string,
+      distance: number,
+      nodeIndex: number,
+      retainedSize: number,
+      selfSize: number,
+      type: string,
+  ) {
     this.id = id;
     this.name = name;
     this.distance = distance;
@@ -85,11 +91,6 @@ export class Node {
     this.retainedSize = retainedSize;
     this.selfSize = selfSize;
     this.type = type;
-
-    this.canBeQueried = false;
-    this.detachedDOMTreeNode = false;
-    this.isAddedNotRemoved = null;
-    this.ignored = false;
   }
 }
 
@@ -98,13 +99,12 @@ export class Edge {
   node: Node;
   type: string;
   edgeIndex: number;
-  isAddedNotRemoved: boolean|null;
+  isAddedNotRemoved: boolean|null = null;
   constructor(name: string, node: Node, type: string, edgeIndex: number) {
     this.name = name;
     this.node = node;
     this.type = type;
     this.edgeIndex = edgeIndex;
-    this.isAddedNotRemoved = null;
   }
 }
 
@@ -132,37 +132,19 @@ export class AggregateForDiff {
 
 export class Diff {
   name: string;
-  addedCount: number;
-  removedCount: number;
-  addedSize: number;
-  removedSize: number;
-  deletedIndexes: number[];
-  addedIndexes: number[];
+  addedCount = 0;
+  removedCount = 0;
+  addedSize = 0;
+  removedSize = 0;
+  deletedIndexes: number[] = [];
+  addedIndexes: number[] = [];
   countDelta!: number;
   sizeDelta!: number;
   constructor(name: string) {
     this.name = name;
-    this.addedCount = 0;
-    this.removedCount = 0;
-    this.addedSize = 0;
-    this.removedSize = 0;
-    this.deletedIndexes = [];
-    this.addedIndexes = [];
   }
 }
 
-export class DiffForClass {
-  name!: string;
-  addedCount!: number;
-  removedCount!: number;
-  addedSize!: number;
-  removedSize!: number;
-  deletedIndexes!: number[];
-  addedIndexes!: number[];
-  countDelta!: number;
-  sizeDelta!: number;
-}
-
 export class ComparatorConfig {
   fieldName1: string;
   ascending1: boolean;
@@ -176,16 +158,16 @@ export class ComparatorConfig {
   }
 }
 
-export class WorkerCommand {
-  callId!: number;
-  disposition!: string;
-  objectId!: number;
-  newObjectId!: number;
-  methodName!: string;
+export interface WorkerCommand {
+  callId: number;
+  disposition: string;
+  objectId: number;
+  newObjectId: number;
+  methodName: string;
   // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  methodArguments!: any[];
-  source!: string;
+  methodArguments: any[];
+  source: string;
 }
 
 export class ItemsRange {
@@ -244,8 +226,13 @@ export class SearchConfig {
   shouldJump: boolean;
   jumpBackward: boolean;
   constructor(
-      query: string, caseSensitive: boolean, wholeWord: boolean, isRegex: boolean, shouldJump: boolean,
-      jumpBackward: boolean) {
+      query: string,
+      caseSensitive: boolean,
+      wholeWord: boolean,
+      isRegex: boolean,
+      shouldJump: boolean,
+      jumpBackward: boolean,
+  ) {
     this.query = query;
     this.caseSensitive = caseSensitive;
     this.wholeWord = wholeWord;

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -6606,16 +6606,12 @@ export const NativeFunctions = [
     name: "replaceWithHTMLUnsafe",
     signatures: [["html","?options"]]
   },
-  {
-    name: "streamBeforeHTMLUnsafe",
-    signatures: [["?options"]]
-  },
   {
     name: "streamBeforeHTML",
     signatures: [["?options"]]
   },
   {
-    name: "streamAfterHTMLUnsafe",
+    name: "streamBeforeHTMLUnsafe",
     signatures: [["?options"]]
   },
   {
@@ -6623,13 +6619,17 @@ export const NativeFunctions = [
     signatures: [["?options"]]
   },
   {
-    name: "streamReplaceWithHTMLUnsafe",
+    name: "streamAfterHTMLUnsafe",
     signatures: [["?options"]]
   },
   {
     name: "streamReplaceWithHTML",
     signatures: [["?options"]]
   },
+  {
+    name: "streamReplaceWithHTMLUnsafe",
+    signatures: [["?options"]]
+  },
   {
     name: "Comment",
     signatures: [["?data"]]

package/front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -383,7 +383,9 @@ interface ToolbarViewInput {
   walkthrough: {
     isExpanded: boolean,
     isInlined: boolean,
-    onToggle: (isOpen: boolean) => void,
+    onToggle: (isOpen: boolean, message: ModelChatMessage) => void,
+    activeSidebarMessage: ModelChatMessage|null,
+    inlineExpandedMessages: ModelChatMessage[],
   };
 }
 
@@ -521,7 +523,7 @@ function defaultView(input: ViewInput, output: PanelViewOutput, target: HTMLElem
     let walkthroughIsForLastMessage = false;
     if(input.state === ViewState.CHAT_VIEW) {
       const lastMessage = input.props.messages.at(-1);
-      if(lastMessage && input.props.walkthrough.activeMessage === lastMessage) {
+      if(lastMessage && input.props.walkthrough.activeSidebarMessage === lastMessage) {
         walkthroughIsForLastMessage = true;
       }
     }
@@ -542,7 +544,7 @@ function defaultView(input: ViewInput, output: PanelViewOutput, target: HTMLElem
           <div slot="sidebar" class="sidebar-view">
             ${shouldShowWalkthrough ? html`
               <devtools-widget ${widget(WalkthroughView, {
-                message: input.props.walkthrough.activeMessage,
+                message: input.props.walkthrough.activeSidebarMessage,
                 isLoading: input.props.isLoading && walkthroughIsForLastMessage,
                 markdownRenderer: input.props.markdownRenderer,
                 onToggle: input.props.walkthrough.onToggle,
@@ -610,10 +612,15 @@ function createPerformanceTraceContext(focus: AiAssistanceModel.AIContext.AgentF
 
 /**
  * State relating to the visibility of the Walkthrough.
- * Note that we have to track the active message and the visibility as distinct
- * state, because you can toggle the walkthrough via the sidebar, in which case
- * we need to make it visible/hidden but keep track of the active message for
- * when the user expands it again.
+ *
+ * We track both an `activeSidebarMessage` and a list of `inlineExpandedMessages` because:
+ * 1. In Narrow (inline) mode, multiple walkthroughs can be expanded at once,
+ *    so we need to track them all to render them correctly in the chat.
+ * 2. In Wide (sidebar) mode, only one walkthrough can be visible at a time.
+ *    The `activeSidebarMessage` tracks which one is shown in the sidebar.
+ * 3. When transitioning from Narrow to Wide, we use the last message in
+ *    `inlineExpandedMessages` to determine which one should stay expanded
+ *    in the sidebar.
  */
 interface WalkthroughState {
   /**
@@ -625,11 +632,15 @@ interface WalkthroughState {
    */
   isExpanded: boolean;
   /**
-   * The message that the walkthrough is showing all the steps for. A
-   * conversation can have many Model messages (1 per each user prompt) so we
-   * need to track which one we are showing for the walkthrough.
+   * The message that the walkthrough is showing all the steps for. In Wide mode,
+   * this is the message shown in the sidebar. In Narrow mode, it tracks the
+   * most recently interacted message.
    */
-  activeMessage: ModelChatMessage|null;
+  activeSidebarMessage: ModelChatMessage|null;
+  /**
+   * Tracks which messages are expanded in inline mode.
+   */
+  inlineExpandedMessages: ModelChatMessage[];
 }
 
 let panelInstance: AiAssistancePanel;
@@ -667,7 +678,8 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   #walkthrough: WalkthroughState = {
     isInlined: false,
     isExpanded: false,
-    activeMessage: null,
+    activeSidebarMessage: null,
+    inlineExpandedMessages: [],
   };
 
   constructor(private view: View = defaultView, {aidaClient, aidaAvailability}: {
@@ -708,6 +720,8 @@ export class AiAssistancePanel extends UI.Panel.Panel {
         isExpanded: this.#walkthrough.isExpanded,
         isInlined: this.#walkthrough.isInlined,
         onToggle: this.#toggleWalkthrough.bind(this),
+        activeSidebarMessage: this.#walkthrough.activeSidebarMessage,
+        inlineExpandedMessages: this.#walkthrough.inlineExpandedMessages,
       }
     };
   }
@@ -796,7 +810,8 @@ export class AiAssistancePanel extends UI.Panel.Panel {
             onOpen: this.#openWalkthrough.bind(this),
             isExpanded: this.#walkthrough.isExpanded,
             isInlined: this.#walkthrough.isInlined,
-            activeMessage: this.#walkthrough.activeMessage,
+            activeSidebarMessage: this.#walkthrough.activeSidebarMessage,
+            inlineExpandedMessages: this.#walkthrough.inlineExpandedMessages,
           },
         }
       };
@@ -820,20 +835,73 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     if (isNarrow === this.#walkthrough.isInlined) {
       return;
     }
-    // If the UI changed, we reset the visibility of the AI Walkthrough.
-    this.#resetWalkthrough();
+
     this.#walkthrough.isInlined = isNarrow;
+
+    if (!this.#walkthrough.isExpanded) {
+      // If nothing was expanded, we just ensure the state is clean.
+      this.#walkthrough.activeSidebarMessage = null;
+      this.#walkthrough.inlineExpandedMessages = [];
+      this.requestUpdate();
+      return;
+    }
+
+    if (isNarrow) {
+      // Wide -> Inline: the walkthrough that was open stays expanded
+      this.#walkthrough.inlineExpandedMessages =
+          this.#walkthrough.activeSidebarMessage ? [this.#walkthrough.activeSidebarMessage] : [];
+    } else {
+      // Inline -> Wide: the last walkthrough that the user opened stays expanded
+      this.#walkthrough.activeSidebarMessage = this.#walkthrough.inlineExpandedMessages.at(-1) ?? null;
+    }
+
     this.requestUpdate();
   }
 
   #openWalkthrough(message: ModelChatMessage): void {
-    this.#walkthrough.activeMessage = message;
+    if (!this.#walkthrough.inlineExpandedMessages.includes(message)) {
+      this.#walkthrough.inlineExpandedMessages.push(message);
+    }
+    this.#walkthrough.activeSidebarMessage = message;
     this.#walkthrough.isExpanded = true;
     this.requestUpdate();
   }
 
-  #toggleWalkthrough(isOpen: boolean): void {
-    this.#walkthrough.isExpanded = isOpen;
+  /**
+   * Toggles the expanded state of a walkthrough.
+   *
+   * In Wide (sidebar) mode:
+   * - Opening a message's walkthrough shows the sidebar for that message.
+   * - Closing the sidebar hides the walkthrough for the currently active message.
+   *
+   * In Narrow (inline) mode:
+   * - Any number of walkthroughs can be open at once.
+   * - Opening/closing a message's walkthrough only affects that message's inline display.
+   */
+  #toggleWalkthrough(isOpen: boolean, message: ModelChatMessage): void {
+    if (isOpen) {  // If we are opening a walkthrough, ensure it's in our list of expanded messages.
+      this.#openWalkthrough(message);
+      return;
+    }
+
+    // If we are closing a walkthrough, remove it from the list of expanded messages.
+    this.#walkthrough.inlineExpandedMessages = this.#walkthrough.inlineExpandedMessages.filter(m => m !== message);
+
+    if (this.#walkthrough.isInlined) {
+      // In Narrow mode, the global expanded state tracks if at least one walkthrough is open.
+      this.#walkthrough.isExpanded = this.#walkthrough.inlineExpandedMessages.length > 0;
+      // If the message we just closed was the active one, we pick a new active message
+      // from the remaining open ones (if any). This ensures that if the user
+      // re-opens the sidebar later, it shows the most recently opened walkthrough.
+      if (this.#walkthrough.activeSidebarMessage === message) {
+        this.#walkthrough.activeSidebarMessage = this.#walkthrough.inlineExpandedMessages.at(-1) ?? null;
+      }
+    } else {
+      // In Wide mode, closing the sidebar means we are no longer expanded globally.
+      this.#walkthrough.isExpanded = false;
+      this.#walkthrough.activeSidebarMessage = null;
+    }
+
     this.requestUpdate();
   }
 
@@ -1565,7 +1633,8 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
   #resetWalkthrough(): void {
     this.#walkthrough.isExpanded = false;
-    this.#walkthrough.activeMessage = null;
+    this.#walkthrough.activeSidebarMessage = null;
+    this.#walkthrough.inlineExpandedMessages = [];
   }
 
   #onDeleteClicked(): void {