chrome-devtools-frontend 1.0.1597624 → 1.0.1599001

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -8,9 +8,12 @@ import * as i18n from '../../../core/i18n/i18n.js';
 import * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
+import type * as Protocol from '../../../generated/protocol.js';
 import * as Tracing from '../../../services/tracing/tracing.js';
 import * as Annotations from '../../annotations/annotations.js';
+import * as Logs from '../../logs/logs.js';
 import * as SourceMapScopes from '../../source_map_scopes/source_map_scopes.js';
+import * as TextUtils from '../../text_utils/text_utils.js';
 import * as Trace from '../../trace/trace.js';
 import {
   PerformanceInsightFormatter,
@@ -34,10 +37,6 @@ import {
 } from './AiAgent.js';
 
 const UIStringsNotTranslated = {
-  /**
-   *@description Shown when the agent is investigating a trace
-   */
-  analyzingTrace: 'Analyzing trace',
   /**
    * @description Shown when the agent is investigating network activity
    */
@@ -317,7 +316,6 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
   #formatter: PerformanceTraceFormatter|null = null;
   #lastEventForEnhancedQuery: Trace.Types.Events.Event|undefined;
   #lastInsightForEnhancedQuery: Trace.Insights.Types.InsightModel|undefined;
-  #hasShownAnalyzeTraceContext = false;
 
   /**
    * Cache of all function calls made by the agent. This allows us to include (as a
@@ -378,10 +376,6 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       return;
     }
 
-    if (this.#hasShownAnalyzeTraceContext) {
-      return;
-    }
-
     const widgets: AiWidget[] = [];
     const primaryInsightSet = context.getItem().primaryInsightSet;
     if (primaryInsightSet) {
@@ -396,7 +390,6 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
 
     yield {
       type: ResponseType.CONTEXT,
-      title: lockedString(UIStringsNotTranslated.analyzingTrace),
       details: [
         {
           title: 'Trace',
@@ -405,8 +398,6 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       ],
       widgets,
     };
-
-    this.#hasShownAnalyzeTraceContext = true;
   }
 
   #callTreeContextSet = new WeakSet();
@@ -700,6 +691,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
   #declareFunctions(context: PerformanceTraceContext): void {
     const focus = context.getItem();
     const {parsedTrace} = focus;
+    const processedNodeIds = new Set<Protocol.DOM.BackendNodeId>();
 
     this.declareFunction<{insightSetId: string, insightName: string}, {details: string}>('getInsightDetails', {
       description:
@@ -749,9 +741,60 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
 
         const details = new PerformanceInsightFormatter(focus, insight).formatInsight();
 
+        const widgets: AiWidget[] = [];
+        if (Trace.Insights.Models.LCPDiscovery.isLCPDiscoveryInsight(insight) ||
+            Trace.Insights.Models.LCPBreakdown.isLCPBreakdownInsight(insight)) {
+          const lcpMetric = Trace.Insights.Common.getLCP(insightSet);
+          const lcpEvent = lcpMetric?.event;
+          if (lcpEvent && Trace.Types.Events.isAnyLargestContentfulPaintCandidate(lcpEvent)) {
+            const nodeId = lcpEvent.args.data?.nodeId;
+            // We want to show only one DOM tree widget per walkthrough per node.
+            // We do want to show the widget for the same node again, if it's within a new walkthrough.
+            if (nodeId && !processedNodeIds.has(nodeId)) {
+              const target = SDK.TargetManager.TargetManager.instance().primaryPageTarget();
+              const domModel = target?.model(SDK.DOMModel.DOMModel);
+              if (domModel) {
+                const nodeMap = await domModel.pushNodesByBackendIdsToFrontend(new Set([nodeId]));
+                const node = nodeMap?.get(nodeId);
+                if (node) {
+                  const snapshot = await node.takeSnapshot();
+                  let networkRequest;
+                  const lcpSyntheticRequest = insight.lcpRequest;
+                  if (lcpSyntheticRequest) {
+                    networkRequest = {
+                      url: lcpSyntheticRequest.args.data.url,
+                      size: lcpSyntheticRequest.args.data.decodedBodyLength ??
+                          lcpSyntheticRequest.args.data.encodedDataLength ?? 0,
+                      resourceType: lcpSyntheticRequest.args.data.resourceType,
+                      mimeType: lcpSyntheticRequest.args.data.mimeType ?? '',
+                      imageUrl: await this.#getNetworkRequestImageData(lcpSyntheticRequest),
+                    };
+                  }
+                  widgets.push({
+                    name: 'DOM_TREE',
+                    data: {
+                      root: snapshot,
+                      networkRequest,
+                    },
+                  });
+                  processedNodeIds.add(nodeId);
+                }
+              }
+            }
+          }
+          if (params.insightName === 'LCPBreakdown') {
+            widgets.push({
+              name: 'LCP_BREAKDOWN',
+              data: {
+                lcpData: insight as Trace.Insights.Models.LCPBreakdown.LCPBreakdownInsightModel,
+              },
+            });
+          }
+        }
+
         const key = `getInsightDetails('${params.insightSetId}', '${params.insightName}')`;
         this.#cacheFunctionResult(focus, key, details);
-        return {result: {details}};
+        return {result: {details}, widgets};
       },
     });
 
@@ -1229,4 +1272,24 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
     Annotations.AnnotationRepository.instance().addNetworkRequestAnnotation(annotationMessage, requestId);
     return {result: {success: true}};
   }
+
+  async #getNetworkRequestImageData(lcpRequest: Trace.Types.Events.SyntheticNetworkRequest): Promise<string|undefined> {
+    const target = SDK.TargetManager.TargetManager.instance().primaryPageTarget();
+    const networkManager = target?.model(SDK.NetworkManager.NetworkManager);
+    if (!target || !networkManager) {
+      return undefined;
+    }
+
+    const networkLog = Logs.NetworkLog.NetworkLog.instance();
+    const requestId = lcpRequest.args.data.requestId;
+    const sdkRequest = networkLog.requestByManagerAndId(networkManager, requestId);
+
+    if (sdkRequest?.contentType().isImage()) {
+      const contentData = await sdkRequest.requestContentData();
+      if (!TextUtils.ContentData.ContentData.isError(contentData)) {
+        return contentData.asDataUrl() ?? undefined;
+      }
+    }
+    return undefined;
+  }
 }

package/front_end/models/ai_assistance/agents/PerformanceAnnotationsAgent.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as Host from '../../../core/host/host.js';
-import * as i18n from '../../../core/i18n/i18n.js';
 import * as Root from '../../../core/root/root.js';
 import type {AICallTree} from '../performance/AICallTree.js';
 import type {AgentFocus} from '../performance/AIContext.js';
@@ -11,14 +10,6 @@ import type {AgentFocus} from '../performance/AIContext.js';
 import {AiAgent, type ContextResponse, type ConversationContext, type RequestOptions, ResponseType} from './AiAgent.js';
 import {PerformanceTraceContext} from './PerformanceAgent.js';
 
-const UIStringsNotTranslated = {
-  analyzingCallTree: 'Analyzing call tree',
-  /**
-   * @description Shown when the agent is investigating network activity
-   */
-} as const;
-const lockedString = i18n.i18n.lockedString;
-
 /**
  * Preamble clocks in at ~970 tokens.
  *   The prose is around 4.5 chars per token.
@@ -124,7 +115,6 @@ export class PerformanceAnnotationsAgent extends AiAgent<AgentFocus> {
 
     yield {
       type: ResponseType.CONTEXT,
-      title: lockedString(UIStringsNotTranslated.analyzingCallTree),
       details: [
         {
           title: 'Selected call tree',

package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt

@@ -216,7 +216,6 @@ Content:
 [
   {
     "type": "context",
-    "title": "Analyzing the prompt",
     "details": [
       {
         "title": "Data used",
@@ -296,7 +295,6 @@ Content:
 [
   {
     "type": "context",
-    "title": "Analyzing the prompt",
     "details": [
       {
         "title": "Data used",
@@ -321,7 +319,6 @@ Content:
 [
   {
     "type": "context",
-    "title": "Analyzing the prompt",
     "details": [
       {
         "title": "Data used",
@@ -349,7 +346,6 @@ Content:
 [
   {
     "type": "context",
-    "title": "Analyzing the prompt",
     "details": [
       {
         "title": "Data used",
@@ -374,7 +370,6 @@ Content:
 [
   {
     "type": "context",
-    "title": "Analyzing the prompt",
     "details": [
       {
         "title": "Data used",
@@ -397,7 +392,6 @@ Content:
 [
   {
     "type": "context",
-    "title": "Analyzing the prompt",
     "details": [
       {
         "title": "Data used",

package/front_end/models/ai_assistance/agents/StylingAgent.ts

@@ -37,10 +37,6 @@ import {
 * Strings that don't need to be translated at this time.
 */
 const UIStringsNotTranslate = {
-  /**
-   * @description Title for context details for Freestyler.
-   */
-  analyzingThePrompt: 'Analyzing the prompt',
   /**
    * @description Heading text for context details of Freestyler agent.
    */
@@ -1045,7 +1041,6 @@ const data = {
     }
     yield {
       type: ResponseType.CONTEXT,
-      title: lockedString(UIStringsNotTranslate.analyzingThePrompt),
       details: [{
         title: lockedString(UIStringsNotTranslate.dataUsed),
         text: await StylingAgent.describeElement(selectedElement.getItem()),

package/front_end/models/ai_assistance/ai_assistance.ts

@@ -7,6 +7,7 @@ import * as AccessibilityAgent from './agents/AccessibilityAgent.js';
 import * as AiAgent from './agents/AiAgent.js';
 import * as BreakpointDebuggerAgent from './agents/BreakpointDebuggerAgent.js';
 import * as ContextSelectionAgent from './agents/ContextSelectionAgent.js';
+import * as ConversationSummaryAgent from './agents/ConversationSummaryAgent.js';
 import * as FileAgent from './agents/FileAgent.js';
 import * as NetworkAgent from './agents/NetworkAgent.js';
 import * as PatchAgent from './agents/PatchAgent.js';
@@ -47,6 +48,7 @@ export {
   ChangeManager,
   ContextSelectionAgent,
   ConversationHandler,
+  ConversationSummaryAgent,
   Debug,
   EvaluateAction,
   ExtensionScope,

package/front_end/models/emulation/DeviceModeModel.ts

@@ -680,7 +680,11 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
   }
 
   private applyUserAgent(userAgent: string, userAgentMetadata: Protocol.Emulation.UserAgentMetadata|null): void {
-    SDK.NetworkManager.MultitargetNetworkManager.instance().setUserAgentOverride(userAgent, userAgentMetadata);
+    // When the user agent string is empty (e.g. custom desktop device without
+    // a UA override), metadata must also be cleared. The backend rejects
+    // setUserAgentOverride calls that provide metadata without a UA string.
+    SDK.NetworkManager.MultitargetNetworkManager.instance().setUserAgentOverride(
+        userAgent, userAgent ? userAgentMetadata : null);
   }
 
   private applyDeviceMetrics(

package/front_end/models/emulation/EmulatedDevices.ts

@@ -201,7 +201,8 @@ export class EmulatedDevice {
       const rawUserAgent = (parseValue(json, 'user-agent', 'string') as string);
       result.userAgent = SDK.NetworkManager.MultitargetNetworkManager.patchUserAgentWithChromeVersion(rawUserAgent);
 
-      result.userAgentMetadata = parseValue(json, 'user-agent-metadata', 'object', null);
+      const userAgentMetadata = parseValue(json, 'user-agent-metadata', 'object', null);
+      result.userAgentMetadata = result.userAgent ? userAgentMetadata : null;
 
       const capabilities = parseValue(json, 'capabilities', 'object', []);
       if (!Array.isArray(capabilities)) {
@@ -366,7 +367,7 @@ export class EmulatedDevice {
     json['foldable-screen'] = this.isFoldableScreen;
     json['show'] = this.#show;
 
-    if (this.userAgentMetadata) {
+    if (this.userAgent && this.userAgentMetadata) {
       json['user-agent-metadata'] = this.userAgentMetadata;
     }
 

package/front_end/models/issues_manager/SharedDictionaryIssue.ts

@@ -23,7 +23,7 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/SharedDictionary
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 export const enum IssueCode {
-  USE_ERROR_CROSS_ORIGIN_NO_CORS_REQUEST = 'SharedDictionaryIssue::UseErrorCrossOriginNoCorsRequest',
+  USE_ERROR_NO_CORP_CROSS_ORIGIN_NO_CORS_REQUEST = 'SharedDictionaryIssue::UseErrorNoCorpCrossOriginNoCorsRequest',
   USE_ERROR_DICTIONARY_LOAD_FAILURE = 'SharedDictionaryIssue::UseErrorDictionaryLoadFailure',
   USE_ERROR_MATCHING_DICTIONARY_NOT_USED = 'SharedDictionaryIssue::UseErrorMatchingDictionaryNotUsed',
   USE_ERROR_UNEXPECTED_CONTENT_DICTIONARY_HEADER = 'SharedDictionaryIssue::UseErrorUnexpectedContentDictionaryHeader',
@@ -36,6 +36,7 @@ export const enum IssueCode {
   WRITE_ERROR_INVALID_STRUCTURED_HEADER = 'SharedDictionaryIssue::WriteErrorInvalidStructuredHeader',
   WRITE_ERROR_INVALID_TTL_FIELD = 'SharedDictionaryIssue::WriteErrorInvalidTTLField',
   WRITE_ERROR_NAVIGATION_REQUEST = 'SharedDictionaryIssue::WriteErrorNavigationRequest',
+  WRITE_ERROR_NO_CORP_COSS_ORIGIN_NO_CORS_REQUEST = 'SharedDictionaryIssue::WriteErrorNoCorpCossOriginNoCorsRequest',
   WRITE_ERROR_NO_MATCH_FIELD = 'SharedDictionaryIssue::WriteErrorNoMatchField',
   WRITE_ERROR_NON_INTEGER_TTL_FIELD = 'SharedDictionaryIssue::WriteErrorNonIntegerTTLField',
   WRITE_ERROR_NON_LIST_MATCH_DEST_FIELD = 'SharedDictionaryIssue::WriteErrorNonListMatchDestField',
@@ -53,8 +54,8 @@ export const enum IssueCode {
 
 function getIssueCode(details: Protocol.Audits.SharedDictionaryIssueDetails): IssueCode {
   switch (details.sharedDictionaryError) {
-    case Protocol.Audits.SharedDictionaryError.UseErrorCrossOriginNoCorsRequest:
-      return IssueCode.USE_ERROR_CROSS_ORIGIN_NO_CORS_REQUEST;
+    case Protocol.Audits.SharedDictionaryError.UseErrorNoCorpCrossOriginNoCorsRequest:
+      return IssueCode.USE_ERROR_NO_CORP_CROSS_ORIGIN_NO_CORS_REQUEST;
     case Protocol.Audits.SharedDictionaryError.UseErrorDictionaryLoadFailure:
       return IssueCode.USE_ERROR_DICTIONARY_LOAD_FAILURE;
     case Protocol.Audits.SharedDictionaryError.UseErrorMatchingDictionaryNotUsed:
@@ -79,6 +80,8 @@ function getIssueCode(details: Protocol.Audits.SharedDictionaryIssueDetails): Is
       return IssueCode.WRITE_ERROR_INVALID_TTL_FIELD;
     case Protocol.Audits.SharedDictionaryError.WriteErrorNavigationRequest:
       return IssueCode.WRITE_ERROR_NAVIGATION_REQUEST;
+    case Protocol.Audits.SharedDictionaryError.WriteErrorNoCorpCossOriginNoCorsRequest:
+      return IssueCode.WRITE_ERROR_NO_CORP_COSS_ORIGIN_NO_CORS_REQUEST;
     case Protocol.Audits.SharedDictionaryError.WriteErrorNoMatchField:
       return IssueCode.WRITE_ERROR_NO_MATCH_FIELD;
     case Protocol.Audits.SharedDictionaryError.WriteErrorNonIntegerTTLField:
@@ -168,9 +171,9 @@ const specLinks = [{
 const issueDescriptions = new Map<Protocol.Audits.SharedDictionaryError, LazyMarkdownIssueDescription>([
 
   [
-    Protocol.Audits.SharedDictionaryError.UseErrorCrossOriginNoCorsRequest,
+    Protocol.Audits.SharedDictionaryError.UseErrorNoCorpCrossOriginNoCorsRequest,
     {
-      file: 'sharedDictionaryUseErrorCrossOriginNoCorsRequest.md',
+      file: 'sharedDictionaryUseErrorNoCorpCrossOriginNoCorsRequest.md',
       links: specLinks,
     },
   ],
@@ -258,6 +261,13 @@ const issueDescriptions = new Map<Protocol.Audits.SharedDictionaryError, LazyMar
       links: specLinks,
     },
   ],
+  [
+    Protocol.Audits.SharedDictionaryError.WriteErrorNoCorpCossOriginNoCorsRequest,
+    {
+      file: 'sharedDictionaryWriteErrorNoCorpCossOriginNoCorsRequest.md',
+      links: specLinks,
+    },
+  ],
   [
     Protocol.Audits.SharedDictionaryError.WriteErrorNoMatchField,
     {

package/front_end/models/issues_manager/descriptions/sharedDictionaryUseErrorNoCorpCrossOriginNoCorsRequest.md

@@ -0,0 +1,3 @@
+# Dictionary compression cannot be used for cross-origin no-cors requests without a Cross-Origin-Resource-Policy response header
+
+To use dictionary compression for a cross-origin no-cors request, the response must have a `Cross-Origin-Resource-Policy: cross-origin` header. Without it, the response can not be decoded and will fail.

package/front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorNoCorpCossOriginNoCorsRequest.md

@@ -0,0 +1,3 @@
+# A cross-origin no-cors response cannot be stored as a shared dictionary for future requests without a Cross-Origin-Resource-Policy response header
+
+To store a response from a cross-origin no-cors request as a shared dictionary for future requests, the response must have a `Cross-Origin-Resource-Policy: cross-origin` header. Without it, the response will not be stored as a dictionary.

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -8785,6 +8785,14 @@ export const NativeFunctions = [
     name: "SpeechSynthesisUtterance",
     signatures: [["?text"]]
   },
+  {
+    name: "addWords",
+    signatures: [["words"]]
+  },
+  {
+    name: "removeWords",
+    signatures: [["words"]]
+  },
   {
     name: "requestStorageAccessFor",
     signatures: [["requestedOrigin"]]

package/front_end/models/lighthouse/RunTypes.ts

@@ -0,0 +1,41 @@
+// Copyright 2026 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+import type * as Common from '../../core/common/common.js';
+import type * as Host from '../../core/host/host.js';
+import type * as Platform from '../../core/platform/platform.js';
+
+export type CategoryId = 'performance'|'accessibility'|'best-practices'|'seo';
+
+export interface Preset {
+  setting: Common.Settings.Setting<boolean>;
+  configID: CategoryId;
+  title: () => Common.UIString.LocalizedString;
+  description: () => Common.UIString.LocalizedString;
+  supportedModes: string[];
+  userMetric: Host.UserMetrics.LighthouseCategoryUsed;
+}
+export interface RuntimeSetting {
+  setting: Common.Settings.Setting<string|boolean>;
+  description: () => Common.UIString.LocalizedString;
+  setFlags: (flags: Flags, value: string|boolean) => void;
+  options?: Array<{
+    label: () => Common.UIString.LocalizedString,
+    value: string,
+    tooltip?: () => Common.UIString.LocalizedString,
+  }>;
+  title?: () => Common.UIString.LocalizedString;
+  learnMore?: Platform.DevToolsPath.UrlString;
+}
+
+export interface Flags {
+  additionalTraceCategories?: string;
+  disableStorageReset?: boolean;
+  throttlingMethod?: string;
+  formFactor?: string|boolean;
+  mode?: string|boolean;
+}
+
+export interface RunOverrides {
+  categoryIds: CategoryId[];
+}

package/front_end/models/lighthouse/lighthouse.ts

@@ -3,7 +3,9 @@
 // found in the LICENSE file.
 
 import * as ReporterTypes from './LighthouseReporterTypes.js';
+import * as RunTypes from './RunTypes.js';
 
 export {
   ReporterTypes,
+  RunTypes,
 };

package/front_end/models/trace/ModelImpl.ts

@@ -173,6 +173,10 @@ export class Model extends EventTarget {
     this.#recordingsAvailable.splice(recordingIndex, 1);
   }
 
+  indexForTrace(trace: ParsedTrace): number {
+    return this.#traces.indexOf(trace);
+  }
+
   getRecordingsAvailable(): string[] {
     return this.#recordingsAvailable;
   }

package/front_end/models/trace/helpers/SamplesIntegrator.ts

@@ -477,20 +477,13 @@ export class SamplesIntegrator {
     if (showAllEvents) {
       return;
     }
-    let previousNativeFrameName: string|null = null;
     let j = 0;
     for (let i = 0; i < stack.length; ++i) {
       const frame = stack[i].callFrame;
       const nativeRuntimeFrame = SamplesIntegrator.isNativeRuntimeFrame(frame);
-      if (nativeRuntimeFrame &&
-          !SamplesIntegrator.showNativeName(frame.functionName, engineConfig.includeRuntimeCallStats)) {
+      if (nativeRuntimeFrame) {
         continue;
       }
-      const nativeFrameName = nativeRuntimeFrame ? SamplesIntegrator.nativeGroup(frame.functionName) : null;
-      if (previousNativeFrameName && previousNativeFrameName === nativeFrameName) {
-        continue;
-      }
-      previousNativeFrameName = nativeFrameName;
       stack[j++] = stack[i];
     }
     stack.length = j;

package/front_end/models/trace/types/Configuration.ts

@@ -11,10 +11,6 @@ import type * as File from './File.js';
 import type {Milli} from './Timing.js';
 
 export interface Configuration {
-  /**
-   * Include V8 RCS functions in the JS stacks
-   */
-  includeRuntimeCallStats: boolean;
   /**
    * Show all events: disable the default filtering which hides and excludes some events.
    */
@@ -49,7 +45,6 @@ export interface Configuration {
 }
 
 export const defaults = (): Configuration => ({
-  includeRuntimeCallStats: false,
   showAllEvents: false,
   debugMode: false,
   maxInvalidationEventsPerEvent: 20,