chrome-devtools-frontend 1.0.1592362 → 1.0.1593959

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (143) hide show
  1. package/docs/contributing/settings-experiments-features.md +75 -100
  2. package/front_end/Images/src/tab-move.svg +1 -0
  3. package/front_end/application_tokens.css +4 -4
  4. package/front_end/core/host/UserMetrics.ts +1 -2
  5. package/front_end/core/root/ExperimentNames.ts +0 -1
  6. package/front_end/entrypoints/main/MainImpl.ts +0 -6
  7. package/front_end/generated/InspectorBackendCommands.ts +8 -5
  8. package/front_end/generated/SupportedCSSProperties.js +2 -2
  9. package/front_end/generated/protocol-mapping.d.ts +14 -0
  10. package/front_end/generated/protocol-proxy-api.d.ts +10 -0
  11. package/front_end/generated/protocol.ts +106 -0
  12. package/front_end/models/ai_assistance/agents/AiAgent.ts +24 -1
  13. package/front_end/models/ai_assistance/agents/BreakpointDebuggerAgent.ts +26 -86
  14. package/front_end/models/ai_assistance/agents/ContextSelectionAgent.ts +14 -4
  15. package/front_end/models/ai_assistance/agents/StylingAgent.ts +16 -2
  16. package/front_end/models/ai_code_completion/AiCodeCompletion.ts +1 -0
  17. package/front_end/models/issues_manager/IssueAggregator.ts +0 -9
  18. package/front_end/models/issues_manager/IssuesManager.ts +0 -5
  19. package/front_end/models/issues_manager/issues_manager.ts +0 -4
  20. package/front_end/models/javascript_metadata/NativeFunctions.js +10 -6
  21. package/front_end/models/lighthouse/lighthouse.ts +9 -0
  22. package/front_end/panels/accessibility/AXBreadcrumbsPane.ts +5 -3
  23. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +29 -6
  24. package/front_end/panels/ai_assistance/README.md +61 -0
  25. package/front_end/panels/ai_assistance/components/ChatMessage.ts +141 -27
  26. package/front_end/panels/ai_assistance/components/ChatView.ts +5 -1
  27. package/front_end/panels/ai_assistance/components/WalkthroughView.ts +19 -7
  28. package/front_end/panels/ai_assistance/components/chatMessage.css +30 -0
  29. package/front_end/panels/ai_assistance/components/walkthroughView.css +12 -7
  30. package/front_end/panels/animation/AnimationGroupPreviewUI.ts +1 -1
  31. package/front_end/panels/application/ServiceWorkerUpdateCycleView.ts +1 -0
  32. package/front_end/panels/application/components/BackForwardCacheView.ts +4 -2
  33. package/front_end/panels/autofill/AutofillView.ts +1 -1
  34. package/front_end/panels/browser_debugger/DOMBreakpointsSidebarPane.ts +161 -154
  35. package/front_end/panels/browser_debugger/XHRBreakpointsSidebarPane.ts +1 -0
  36. package/front_end/panels/browser_debugger/domBreakpointsSidebarPane.css +58 -36
  37. package/front_end/panels/common/AiCodeCompletionDisclaimer.ts +3 -0
  38. package/front_end/panels/common/AiCodeGenerationTeaser.ts +3 -0
  39. package/front_end/panels/console/ConsoleViewMessage.ts +1 -0
  40. package/front_end/panels/console/consoleView.css +7 -2
  41. package/front_end/panels/elements/ComputedStyleWidget.ts +5 -1
  42. package/front_end/panels/elements/ElementsTreeElement.ts +1 -0
  43. package/front_end/panels/elements/LayoutPane.ts +8 -7
  44. package/front_end/panels/elements/StandaloneStylesContainer.ts +254 -0
  45. package/front_end/panels/elements/StylesAiCodeCompletionProvider.ts +1 -6
  46. package/front_end/panels/elements/StylesSidebarPane.ts +79 -0
  47. package/front_end/panels/elements/components/ComputedStyleTrace.ts +4 -0
  48. package/front_end/panels/elements/components/ElementsBreadcrumbs.ts +1 -1
  49. package/front_end/panels/elements/components/StylePropertyEditor.ts +2 -1
  50. package/front_end/panels/elements/components/computedStyleProperty.css +1 -1
  51. package/front_end/panels/elements/elements.ts +2 -0
  52. package/front_end/panels/emulation/DeviceModeToolbar.ts +181 -66
  53. package/front_end/panels/issues/HiddenIssuesRow.ts +1 -1
  54. package/front_end/panels/issues/IssueKindView.ts +2 -1
  55. package/front_end/panels/issues/IssueView.ts +2 -4
  56. package/front_end/panels/issues/IssuesPane.ts +2 -2
  57. package/front_end/panels/lighthouse/LighthouseController.ts +3 -3
  58. package/front_end/panels/lighthouse/LighthousePanel.ts +9 -5
  59. package/front_end/panels/lighthouse/LighthouseProtocolService.ts +5 -5
  60. package/front_end/panels/lighthouse/LighthouseReportRenderer.ts +7 -8
  61. package/front_end/panels/lighthouse/LighthouseReportSelector.ts +4 -3
  62. package/front_end/panels/lighthouse/lighthouse.ts +0 -2
  63. package/front_end/panels/linear_memory_inspector/components/LinearMemoryValueInterpreter.ts +1 -1
  64. package/front_end/panels/linear_memory_inspector/components/ValueInterpreterDisplay.ts +1 -1
  65. package/front_end/panels/media/PlayerListView.ts +1 -1
  66. package/front_end/panels/network/NetworkLogViewColumns.ts +2 -1
  67. package/front_end/panels/network/components/RequestHeaderSection.ts +1 -1
  68. package/front_end/panels/protocol_monitor/JSONEditor.ts +1 -1
  69. package/front_end/panels/recorder/components/RecordingListView.ts +1 -1
  70. package/front_end/panels/recorder/components/StepEditor.ts +3 -3
  71. package/front_end/panels/settings/KeybindsSettingsTab.ts +2 -1
  72. package/front_end/panels/sources/components/HeadersView.ts +2 -2
  73. package/front_end/panels/timeline/components/BreadcrumbsUI.ts +1 -1
  74. package/front_end/panels/timeline/components/SidebarAnnotationsTab.ts +1 -1
  75. package/front_end/third_party/chromium/README.chromium +1 -1
  76. package/front_end/third_party/puppeteer/README.chromium +2 -2
  77. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/bidi/core/Navigation.d.ts.map +1 -1
  78. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/bidi/core/Navigation.js +1 -0
  79. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/bidi/core/Navigation.js.map +1 -1
  80. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/cdp/BrowserContext.js +1 -1
  81. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/cdp/BrowserContext.js.map +1 -1
  82. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/cdp/Page.js +1 -1
  83. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/cdp/Page.js.map +1 -1
  84. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/injected/injected.d.ts +1 -1
  85. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/ChromeLauncher.d.ts.map +1 -1
  86. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/ChromeLauncher.js +1 -0
  87. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/ChromeLauncher.js.map +1 -1
  88. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/revisions.d.ts +3 -3
  89. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/revisions.js +3 -3
  90. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/revisions.js.map +1 -1
  91. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/util/Mutex.d.ts +2 -2
  92. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/util/version.d.ts +1 -1
  93. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/util/version.js +1 -1
  94. package/front_end/third_party/puppeteer/package/lib/es5-iife/puppeteer-core-browser.js +6 -6
  95. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/bidi/core/Navigation.d.ts.map +1 -1
  96. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/bidi/core/Navigation.js +1 -0
  97. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/bidi/core/Navigation.js.map +1 -1
  98. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/BrowserContext.js +1 -1
  99. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/BrowserContext.js.map +1 -1
  100. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/Page.js +1 -1
  101. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/cdp/Page.js.map +1 -1
  102. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/ChromeLauncher.d.ts.map +1 -1
  103. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/ChromeLauncher.js +1 -0
  104. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/ChromeLauncher.js.map +1 -1
  105. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/revisions.d.ts +3 -3
  106. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/revisions.js +3 -3
  107. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/revisions.js.map +1 -1
  108. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/util/version.d.ts +1 -1
  109. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/util/version.js +1 -1
  110. package/front_end/third_party/puppeteer/package/package.json +4 -4
  111. package/front_end/third_party/puppeteer/package/src/bidi/core/Navigation.ts +1 -0
  112. package/front_end/third_party/puppeteer/package/src/cdp/BrowserContext.ts +1 -1
  113. package/front_end/third_party/puppeteer/package/src/cdp/Page.ts +1 -1
  114. package/front_end/third_party/puppeteer/package/src/node/ChromeLauncher.ts +1 -0
  115. package/front_end/third_party/puppeteer/package/src/revisions.ts +3 -3
  116. package/front_end/third_party/puppeteer/package/src/util/version.ts +1 -1
  117. package/front_end/third_party/source-map-scopes-codec/package/deno.json +1 -1
  118. package/front_end/third_party/source-map-scopes-codec/package/package.json +1 -1
  119. package/front_end/third_party/source-map-scopes-codec/package/src/decode/decode.js +1 -1
  120. package/front_end/third_party/source-map-scopes-codec/package/src/decode/decode.js.map +1 -1
  121. package/front_end/third_party/source-map-scopes-codec/package/src/decode/decode.ts +1 -1
  122. package/front_end/third_party/source-map-scopes-codec/package/src/encode/encoder.js +1 -1
  123. package/front_end/third_party/source-map-scopes-codec/package/src/encode/encoder.js.map +1 -1
  124. package/front_end/third_party/source-map-scopes-codec/package/src/encode/encoder.ts +2 -2
  125. package/front_end/ui/components/suggestion_input/SuggestionInput.ts +7 -12
  126. package/front_end/ui/components/tree_outline/TreeOutline.ts +6 -2
  127. package/front_end/ui/components/tree_outline/treeOutline.css +5 -0
  128. package/front_end/ui/legacy/ListControl.ts +5 -3
  129. package/front_end/ui/legacy/ListWidget.ts +1 -1
  130. package/front_end/ui/legacy/SoftContextMenu.ts +2 -1
  131. package/front_end/ui/legacy/SuggestBox.ts +4 -0
  132. package/front_end/ui/legacy/TextPrompt.ts +1 -1
  133. package/front_end/ui/legacy/Treeoutline.ts +1 -0
  134. package/front_end/ui/legacy/components/data_grid/DataGrid.ts +4 -2
  135. package/front_end/ui/legacy/components/quick_open/FilteredListWidget.ts +1 -1
  136. package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts +31 -0
  137. package/front_end/ui/visual_logging/KnownContextValues.ts +16 -0
  138. package/inspector_overlay/highlight_grid_common.ts +11 -8
  139. package/package.json +1 -1
  140. package/front_end/models/issues_manager/ContrastCheckTrigger.ts +0 -78
  141. package/front_end/models/issues_manager/LowTextContrastIssue.ts +0 -63
  142. package/front_end/panels/issues/AffectedElementsWithLowContrastView.ts +0 -91
  143. /package/front_end/{panels → models}/lighthouse/LighthouseReporterTypes.ts +0 -0
@@ -10,6 +10,7 @@ import * as Host from '../../core/host/host.js';
10
10
  import * as i18n from '../../core/i18n/i18n.js';
11
11
  import * as Platform from '../../core/platform/platform.js';
12
12
  import * as EmulationModel from '../../models/emulation/emulation.js';
13
+ import * as uiI18n from '../../ui/i18n/i18n.js';
13
14
  import * as UI from '../../ui/legacy/legacy.js';
14
15
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
15
16
  import * as MobileThrottling from '../mobile_throttling/mobile_throttling.js';
@@ -19,8 +20,14 @@ const UIStrings = {
19
20
  /**
20
21
  * @description Title of the device dimensions selection item in the Device Mode Toolbar.
21
22
  * webpage in pixels.
23
+ * @example {Responsive} PH1
22
24
  */
23
- dimensions: 'Dimensions',
25
+ dimensions: 'Dimensions: {PH1}',
26
+ /**
27
+ * @description Title of the device pixel ratio selection item in the Device Mode Toolbar.
28
+ * @example {2.0} PH1
29
+ */
30
+ dpr: 'DPR: {PH1}',
24
31
  /**
25
32
  * @description Title of the width input textbox in the Device Mode Toolbar, for the width of the
26
33
  * webpage in pixels.
@@ -53,12 +60,12 @@ const UIStrings = {
53
60
  */
54
61
  moreOptions: 'More options',
55
62
  /**
56
- * @description A context menu item in the Device Mode Toolbar. This is a command to resize the
57
- * webpage preview to fit the current window. The placeholder is the percentage of full-size that
58
- * will be displayed after fitting.
63
+ * @description A menu item in the drop-down box that allows the user to select the zoom level.
64
+ * Labels the value which corresponds to the 'fit to window' zoom level, represented by the
65
+ * placeholder, which is a number. In the Device Mode Toolbar.
59
66
  * @example {30.0} PH1
60
67
  */
61
- fitToWindowF: 'Fit to window ({PH1}%)',
68
+ fitToWindowPercentage: '{PH1}% (fit to window)',
62
69
  /**
63
70
  * @description A checkbox setting that appears in the context menu for the zoom level, in the
64
71
  * Device Mode Toolbar.
@@ -70,7 +77,7 @@ const UIStrings = {
70
77
  * placeholder, which is a number. In the Device Mode Toolbar.
71
78
  * @example {4.3} PH1
72
79
  */
73
- defaultF: 'Default: {PH1}',
80
+ defaultF: '{PH1} (default)',
74
81
  /**
75
82
  * @description Command to hide the frame (like a picture frame) around the mobile device screen.
76
83
  */
@@ -289,6 +296,9 @@ export class DeviceModeToolbar {
289
296
  new UI.Toolbar.ToolbarMenuButton(this.appendDeviceMenuItems.bind(this), undefined, undefined, 'device');
290
297
  this.deviceSelectItem.turnShrinkable();
291
298
  this.deviceSelectItem.setDarkText();
299
+ const dimensionsSpan =
300
+ uiI18n.getFormatLocalizedString(str_, UIStrings.dimensions, {PH1: this.deviceSelectItem.element});
301
+ mainToolbar.append(...dimensionsSpan.childNodes);
292
302
  mainToolbar.appendToolbarItem(this.deviceSelectItem);
293
303
 
294
304
  this.widthInput.addEventListener('sizechanged', ({size: width}) => {
@@ -320,6 +330,11 @@ export class DeviceModeToolbar {
320
330
  this.scaleItem.turnShrinkable();
321
331
  this.scaleItem.setDarkText();
322
332
  mainToolbar.appendToolbarItem(this.scaleItem);
333
+
334
+ const autoAdjustScaleButton = new UI.Toolbar.ToolbarSettingToggle(
335
+ this.autoAdjustScaleSetting, 'center-focus-weak', i18nString(UIStrings.autoadjustZoom));
336
+ mainToolbar.appendToolbarItem(autoAdjustScaleButton);
337
+
323
338
  mainToolbar.appendToolbarItem(new UI.Toolbar.ToolbarItem(this.createEmptyToolbarElement()));
324
339
 
325
340
  this.deviceScaleItem = new UI.Toolbar.ToolbarMenuButton(
@@ -328,6 +343,8 @@ export class DeviceModeToolbar {
328
343
  this.deviceScaleItem.setVisible(this.showDeviceScaleFactorSetting.get());
329
344
  setTitleForButton(this.deviceScaleItem, i18nString(UIStrings.devicePixelRatio));
330
345
  this.deviceScaleItem.setDarkText();
346
+ const deviceScaleSpan = uiI18n.getFormatLocalizedString(str_, UIStrings.dpr, {PH1: this.deviceScaleItem.element});
347
+ mainToolbar.append(...deviceScaleSpan.childNodes);
331
348
  mainToolbar.appendToolbarItem(this.deviceScaleItem);
332
349
  mainToolbar.appendToolbarItem(new UI.Toolbar.ToolbarItem(this.createEmptyToolbarElement()));
333
350
  this.uaItem =
@@ -379,11 +396,16 @@ export class DeviceModeToolbar {
379
396
  return optionsToolbar;
380
397
  }
381
398
 
399
+ private getDevicePostureOptions(): Array<{title: string, value: string, selected: boolean}> {
400
+ const currentPosture = this.currentDevicePosture();
401
+ return ['Continuous', 'Folded'].map(title => ({title, value: title, selected: currentPosture === title}));
402
+ }
403
+
382
404
  private appendDevicePostureItems(contextMenu: UI.ContextMenu.ContextMenu): void {
383
- for (const title of ['Continuous', 'Folded']) {
405
+ for (const option of this.getDevicePostureOptions()) {
384
406
  contextMenu.defaultSection().appendCheckboxItem(
385
- title, this.spanClicked.bind(this),
386
- {checked: title === this.currentDevicePosture(), jslogContext: title.toLowerCase()});
407
+ option.title, this.spanClicked.bind(this),
408
+ {checked: option.selected, jslogContext: option.title.toLowerCase()});
387
409
  }
388
410
  }
389
411
 
@@ -397,27 +419,43 @@ export class DeviceModeToolbar {
397
419
  return 'Continuous';
398
420
  }
399
421
 
400
- private appendScaleMenuItems(contextMenu: UI.ContextMenu.ContextMenu): void {
422
+ private getScaleOptions(): Array<{title: string, value: number, selected: boolean, jslogContext: string}> {
423
+ const values = [0.5, 0.75, 1, 1.25, 1.5, 2];
424
+ let fitValue: number|null = null;
401
425
  if (this.model.type() === EmulationModel.DeviceModeModel.Type.Device) {
402
- contextMenu.footerSection().appendItem(
403
- i18nString(UIStrings.fitToWindowF, {PH1: this.getPrettyFitZoomPercentage()}),
404
- this.onScaleMenuChanged.bind(this, this.model.fitScale()), {jslogContext: 'fit-to-window'});
405
- }
406
- contextMenu.footerSection().appendCheckboxItem(
407
- i18nString(UIStrings.autoadjustZoom), this.onAutoAdjustScaleChanged.bind(this),
408
- {checked: this.autoAdjustScaleSetting.get(), jslogContext: 'auto-adjust-zoom'});
409
- const boundAppendScaleItem = appendScaleItem.bind(this);
410
- boundAppendScaleItem('50%', 0.5);
411
- boundAppendScaleItem('75%', 0.75);
412
- boundAppendScaleItem('100%', 1);
413
- boundAppendScaleItem('125%', 1.25);
414
- boundAppendScaleItem('150%', 1.5);
415
- boundAppendScaleItem('200%', 2);
416
-
417
- function appendScaleItem(this: DeviceModeToolbar, title: string, value: number): void {
426
+ fitValue = this.model.fitScale();
427
+ const fitValuePct = (fitValue * 100).toFixed(0);
428
+ let found = false;
429
+ for (let i = 0; i < values.length; ++i) {
430
+ if ((values[i] * 100).toFixed(0) === fitValuePct) {
431
+ found = true;
432
+ values[i] = fitValue;
433
+ break;
434
+ }
435
+ }
436
+ if (!found) {
437
+ values.push(fitValue);
438
+ values.sort((a, b) => a - b);
439
+ }
440
+ }
441
+
442
+ const currentScale = this.model.scaleSetting().get();
443
+ return values.map(value => {
444
+ let title = (value * 100).toFixed(0) + '%';
445
+ let jslogContext = title;
446
+ if (value === fitValue) {
447
+ title = i18nString(UIStrings.fitToWindowPercentage, {PH1: (value * 100).toFixed(0)});
448
+ jslogContext = 'fit-to-window';
449
+ }
450
+ return {title, value, selected: currentScale === value, jslogContext};
451
+ });
452
+ }
453
+
454
+ private appendScaleMenuItems(contextMenu: UI.ContextMenu.ContextMenu): void {
455
+ for (const option of this.getScaleOptions()) {
418
456
  contextMenu.defaultSection().appendCheckboxItem(
419
- title, this.onScaleMenuChanged.bind(this, value),
420
- {checked: this.model.scaleSetting().get() === value, jslogContext: title});
457
+ option.title, this.onScaleMenuChanged.bind(this, option.value),
458
+ {checked: option.selected, jslogContext: option.jslogContext});
421
459
  }
422
460
  }
423
461
 
@@ -425,41 +463,68 @@ export class DeviceModeToolbar {
425
463
  this.model.scaleSetting().set(value);
426
464
  }
427
465
 
428
- private onAutoAdjustScaleChanged(): void {
429
- this.autoAdjustScaleSetting.set(!this.autoAdjustScaleSetting.get());
430
- }
431
-
432
- private appendDeviceScaleMenuItems(contextMenu: UI.ContextMenu.ContextMenu): void {
466
+ private getDeviceScaleFactorOptions():
467
+ Array<{title: string, value: number, selected: boolean, jslogContext: string}> {
433
468
  const deviceScaleFactorSetting = this.model.deviceScaleFactorSetting();
434
469
  const defaultValue = this.model.uaSetting().get() === EmulationModel.DeviceModeModel.UA.MOBILE ||
435
470
  this.model.uaSetting().get() === EmulationModel.DeviceModeModel.UA.MOBILE_NO_TOUCH ?
436
471
  EmulationModel.DeviceModeModel.defaultMobileScaleFactor :
437
472
  window.devicePixelRatio;
438
- appendDeviceScaleFactorItem(
439
- contextMenu.headerSection(), i18nString(UIStrings.defaultF, {PH1: defaultValue}), 0, 'dpr-default');
440
- appendDeviceScaleFactorItem(contextMenu.defaultSection(), '1', 1, 'dpr-1');
441
- appendDeviceScaleFactorItem(contextMenu.defaultSection(), '2', 2, 'dpr-2');
442
- appendDeviceScaleFactorItem(contextMenu.defaultSection(), '3', 3, 'dpr-3');
473
+ const values = [1, 2, 3];
474
+ if (!values.includes(defaultValue)) {
475
+ values.push(defaultValue);
476
+ values.sort((a, b) => a - b);
477
+ }
478
+
479
+ const currentDPR = deviceScaleFactorSetting.get();
480
+ return values.map(value => {
481
+ let title = String(value);
482
+ let jslogContext = `dpr-${value}`;
483
+ if (value === defaultValue) {
484
+ title = i18nString(UIStrings.defaultF, {PH1: value});
485
+ jslogContext = 'dpr-default';
486
+ }
487
+ return {
488
+ title,
489
+ value: value === defaultValue ? 0 : value,
490
+ selected: currentDPR === value || (value === defaultValue && currentDPR === 0),
491
+ jslogContext
492
+ };
493
+ });
494
+ }
443
495
 
444
- function appendDeviceScaleFactorItem(
445
- section: UI.ContextMenu.Section, title: string, value: number, jslogContext: string): void {
446
- section.appendCheckboxItem(
447
- title, deviceScaleFactorSetting.set.bind(deviceScaleFactorSetting, value),
448
- {checked: deviceScaleFactorSetting.get() === value, jslogContext});
496
+ private appendDeviceScaleMenuItems(contextMenu: UI.ContextMenu.ContextMenu): void {
497
+ const deviceScaleFactorSetting = this.model.deviceScaleFactorSetting();
498
+ for (const option of this.getDeviceScaleFactorOptions()) {
499
+ contextMenu.defaultSection().appendCheckboxItem(
500
+ option.title, deviceScaleFactorSetting.set.bind(deviceScaleFactorSetting, option.value),
501
+ {checked: option.selected, jslogContext: option.jslogContext});
449
502
  }
450
503
  }
451
504
 
452
- private appendUserAgentMenuItems(contextMenu: UI.ContextMenu.ContextMenu): void {
505
+ private getUserAgentOptions():
506
+ Array<{title: string, value: EmulationModel.DeviceModeModel.UA, selected: boolean, jslogContext: string}> {
453
507
  const uaSetting = this.model.uaSetting();
454
- appendUAItem(EmulationModel.DeviceModeModel.UA.MOBILE, EmulationModel.DeviceModeModel.UA.MOBILE);
455
- appendUAItem(EmulationModel.DeviceModeModel.UA.MOBILE_NO_TOUCH, EmulationModel.DeviceModeModel.UA.MOBILE_NO_TOUCH);
456
- appendUAItem(EmulationModel.DeviceModeModel.UA.DESKTOP, EmulationModel.DeviceModeModel.UA.DESKTOP);
457
- appendUAItem(EmulationModel.DeviceModeModel.UA.DESKTOP_TOUCH, EmulationModel.DeviceModeModel.UA.DESKTOP_TOUCH);
508
+ const currentUserAgent = uaSetting.get();
509
+ return [
510
+ EmulationModel.DeviceModeModel.UA.MOBILE,
511
+ EmulationModel.DeviceModeModel.UA.MOBILE_NO_TOUCH,
512
+ EmulationModel.DeviceModeModel.UA.DESKTOP,
513
+ EmulationModel.DeviceModeModel.UA.DESKTOP_TOUCH,
514
+ ].map(value => ({
515
+ title: value,
516
+ value,
517
+ selected: currentUserAgent === value,
518
+ jslogContext: Platform.StringUtilities.toKebabCase(value)
519
+ }));
520
+ }
458
521
 
459
- function appendUAItem(title: string, value: EmulationModel.DeviceModeModel.UA): void {
522
+ private appendUserAgentMenuItems(contextMenu: UI.ContextMenu.ContextMenu): void {
523
+ const uaSetting = this.model.uaSetting();
524
+ for (const option of this.getUserAgentOptions()) {
460
525
  contextMenu.defaultSection().appendCheckboxItem(
461
- title, uaSetting.set.bind(uaSetting, value),
462
- {checked: uaSetting.get() === value, jslogContext: Platform.StringUtilities.toKebabCase(value)});
526
+ option.title, uaSetting.set.bind(uaSetting, option.value),
527
+ {checked: option.selected, jslogContext: option.jslogContext});
463
528
  }
464
529
  }
465
530
 
@@ -544,25 +609,75 @@ export class DeviceModeToolbar {
544
609
  return this.standardDevices().concat(this.customDevices());
545
610
  }
546
611
 
612
+ private getDeviceModeOptions(): {
613
+ responsive: {title: string, selected: boolean, jslogContext: string},
614
+ standard: Array<{
615
+ device: EmulationModel.EmulatedDevices.EmulatedDevice,
616
+ title: string,
617
+ selected: boolean,
618
+ jslogContext: string,
619
+ }>,
620
+ custom: Array<{
621
+ device: EmulationModel.EmulatedDevices.EmulatedDevice,
622
+ title: string,
623
+ selected: boolean,
624
+ jslogContext: string,
625
+ }>,
626
+ edit: {title: string, jslogContext: string},
627
+ } {
628
+ return {
629
+ responsive: {
630
+ title: i18nString(UIStrings.responsive),
631
+ selected: this.model.type() === EmulationModel.DeviceModeModel.Type.Responsive,
632
+ jslogContext: 'responsive'
633
+ },
634
+ standard: this.standardDevices().map(device => ({
635
+ device,
636
+ title: device.title,
637
+ selected: this.model.device() === device,
638
+ jslogContext: Platform.StringUtilities.toKebabCase(device.title)
639
+ })),
640
+ custom: this.customDevices().map(device => ({
641
+ device,
642
+ title: device.title,
643
+ selected: this.model.device() === device,
644
+ jslogContext: Platform.StringUtilities.toKebabCase(device.title)
645
+ })),
646
+ edit: {
647
+ title: i18nString(UIStrings.edit),
648
+ jslogContext: 'edit',
649
+ }
650
+ };
651
+ }
652
+
547
653
  private appendDeviceMenuItems(contextMenu: UI.ContextMenu.ContextMenu): void {
654
+ const options = this.getDeviceModeOptions();
655
+
548
656
  contextMenu.headerSection().appendCheckboxItem(
549
- i18nString(UIStrings.responsive), this.switchToResponsive.bind(this),
550
- {checked: this.model.type() === EmulationModel.DeviceModeModel.Type.Responsive, jslogContext: 'responsive'});
551
- appendGroup.call(this, this.standardDevices());
552
- appendGroup.call(this, this.customDevices());
553
- contextMenu.footerSection().appendItem(
554
- i18nString(UIStrings.edit), this.emulatedDevicesList.revealCustomSetting.bind(this.emulatedDevicesList),
555
- {jslogContext: 'edit'});
657
+ options.responsive.title, this.switchToResponsive.bind(this),
658
+ {checked: options.responsive.selected, jslogContext: options.responsive.jslogContext});
556
659
 
557
- function appendGroup(this: DeviceModeToolbar, devices: EmulationModel.EmulatedDevices.EmulatedDevice[]): void {
558
- if (!devices.length) {
660
+ appendGroup.call(this, options.standard);
661
+ appendGroup.call(this, options.custom);
662
+
663
+ contextMenu.footerSection().appendItem(
664
+ options.edit.title, this.emulatedDevicesList.revealCustomSetting.bind(this.emulatedDevicesList),
665
+ {jslogContext: options.edit.jslogContext});
666
+
667
+ function appendGroup(this: DeviceModeToolbar, group: Array<{
668
+ device: EmulationModel.EmulatedDevices.EmulatedDevice,
669
+ title: string,
670
+ selected: boolean,
671
+ jslogContext: string,
672
+ }>): void {
673
+ if (!group.length) {
559
674
  return;
560
675
  }
561
676
  const section = contextMenu.section();
562
- for (const device of devices) {
563
- section.appendCheckboxItem(device.title, this.emulateDevice.bind(this, device), {
564
- checked: this.model.device() === device,
565
- jslogContext: Platform.StringUtilities.toKebabCase(device.title),
677
+ for (const item of group) {
678
+ section.appendCheckboxItem(item.title, this.emulateDevice.bind(this, item.device), {
679
+ checked: item.selected,
680
+ jslogContext: item.jslogContext,
566
681
  });
567
682
  }
568
683
  }
@@ -745,7 +860,7 @@ export class DeviceModeToolbar {
745
860
 
746
861
  const deviceScale = this.model.appliedDeviceScaleFactor();
747
862
  if (deviceScale !== this.cachedDeviceScale) {
748
- this.deviceScaleItem.setText(`DPR: ${deviceScale.toFixed(1)}`);
863
+ this.deviceScaleItem.setText(`${deviceScale.toFixed(1)}`);
749
864
  this.cachedDeviceScale = deviceScale;
750
865
  }
751
866
 
@@ -763,7 +878,7 @@ export class DeviceModeToolbar {
763
878
  if (this.model.type() === EmulationModel.DeviceModeModel.Type.Device && device) {
764
879
  deviceItemTitle = device.title;
765
880
  }
766
- this.deviceSelectItem.setText(`${i18nString(UIStrings.dimensions)}: ${deviceItemTitle}`);
881
+ this.deviceSelectItem.setText(deviceItemTitle);
767
882
 
768
883
  if (this.model.device() !== this.cachedModelDevice) {
769
884
  const device = this.model.device();
@@ -66,7 +66,7 @@ export class HiddenIssuesRow extends UI.TreeOutline.TreeElement {
66
66
  #view: View;
67
67
 
68
68
  constructor(view: View = DEFAULT_VIEW) {
69
- super(undefined, true);
69
+ super(undefined, true, 'hidden-issues');
70
70
  this.#view = view;
71
71
  this.toggleOnClick = true;
72
72
  this.listItemElement.classList.add('issue-category', 'hidden-issues');
@@ -5,6 +5,7 @@
5
5
 
6
6
  import * as Common from '../../core/common/common.js';
7
7
  import * as i18n from '../../core/i18n/i18n.js';
8
+ import * as Platform from '../../core/platform/platform.js';
8
9
  import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
9
10
  import * as Adorners from '../../ui/components/adorners/adorners.js';
10
11
  import * as IssueCounter from '../../ui/components/issue_counter/issue_counter.js';
@@ -64,7 +65,7 @@ export class IssueKindView extends UI.TreeOutline.TreeElement {
64
65
  #issueCount: HTMLElement;
65
66
 
66
67
  constructor(kind: IssuesManager.Issue.IssueKind) {
67
- super(undefined, true);
68
+ super(undefined, true, Platform.StringUtilities.toKebabCase(kind));
68
69
  this.#kind = kind;
69
70
  this.#issueCount = document.createElement('span');
70
71
 
@@ -6,7 +6,7 @@
6
6
  import * as Common from '../../core/common/common.js';
7
7
  import * as Host from '../../core/host/host.js';
8
8
  import * as i18n from '../../core/i18n/i18n.js';
9
- import type * as Platform from '../../core/platform/platform.js';
9
+ import * as Platform from '../../core/platform/platform.js';
10
10
  import * as Protocol from '../../generated/protocol.js';
11
11
  import type {AggregatedIssue} from '../../models/issues_manager/IssueAggregator.js';
12
12
  import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
@@ -24,7 +24,6 @@ import {AffectedDescendantsWithinSelectElementView} from './AffectedDescendantsW
24
24
  import {AffectedDirectivesView} from './AffectedDirectivesView.js';
25
25
  import {AffectedDocumentsInQuirksModeView} from './AffectedDocumentsInQuirksModeView.js';
26
26
  import {AffectedElementsView} from './AffectedElementsView.js';
27
- import {AffectedElementsWithLowContrastView} from './AffectedElementsWithLowContrastView.js';
28
27
  import {AffectedHeavyAdView} from './AffectedHeavyAdView.js';
29
28
  import {AffectedMetadataAllowedSitesView} from './AffectedMetadataAllowedSitesView.js';
30
29
  import {AffectedPartitioningBlobURLView} from './AffectedPartitioningBlobURLView.js';
@@ -230,7 +229,7 @@ export class IssueView extends UI.TreeOutline.TreeElement {
230
229
  #contentCreated = false;
231
230
 
232
231
  constructor(issue: AggregatedIssue, description: IssuesManager.MarkdownIssueDescription.IssueDescription) {
233
- super();
232
+ super(undefined, undefined, Platform.StringUtilities.toKebabCase(issue.getCategory()));
234
233
  this.#issue = issue;
235
234
  this.#description = description;
236
235
  this.#throttle = new Common.Throttler.Throttler(250);
@@ -251,7 +250,6 @@ export class IssueView extends UI.TreeOutline.TreeElement {
251
250
  new AffectedDirectivesView(this, this.#issue, 'directives-details'),
252
251
  new AffectedBlockedByResponseView(this, this.#issue, 'blocked-by-response-details'),
253
252
  new AffectedSharedArrayBufferIssueDetailsView(this, this.#issue, 'sab-details'),
254
- new AffectedElementsWithLowContrastView(this, this.#issue, 'low-contrast-details'),
255
253
  new CorsIssueDetailsView(this, this.#issue, 'cors-details'),
256
254
  new GenericIssueDetailsView(this, this.#issue, 'generic-details'),
257
255
  new AffectedDocumentsInQuirksModeView(this, this.#issue, 'affected-documents'),
@@ -7,7 +7,7 @@ import '../../ui/legacy/legacy.js';
7
7
 
8
8
  import * as Common from '../../core/common/common.js';
9
9
  import * as i18n from '../../core/i18n/i18n.js';
10
- import type * as Platform from '../../core/platform/platform.js';
10
+ import * as Platform from '../../core/platform/platform.js';
11
11
  import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
12
12
  import * as IssueCounter from '../../ui/components/issue_counter/issue_counter.js';
13
13
  import * as UI from '../../ui/legacy/legacy.js';
@@ -121,7 +121,7 @@ class IssueCategoryView extends UI.TreeOutline.TreeElement {
121
121
  #category: IssuesManager.Issue.IssueCategory;
122
122
 
123
123
  constructor(category: IssuesManager.Issue.IssueCategory) {
124
- super();
124
+ super(undefined, undefined, Platform.StringUtilities.toKebabCase(category));
125
125
  this.#category = category;
126
126
 
127
127
  this.toggleOnClick = true;
@@ -9,10 +9,10 @@ import type * as Platform from '../../core/platform/platform.js';
9
9
  import * as SDK from '../../core/sdk/sdk.js';
10
10
  import * as Protocol from '../../generated/protocol.js';
11
11
  import * as EmulationModel from '../../models/emulation/emulation.js';
12
+ import type * as LighthouseModel from '../../models/lighthouse/lighthouse.js';
12
13
  import * as Emulation from '../emulation/emulation.js';
13
14
 
14
15
  import type {LighthouseRun as LighthouseRunType, ProtocolService} from './LighthouseProtocolService.js';
15
- import type {RunnerResult} from './LighthouseReporterTypes.js';
16
16
 
17
17
  const UIStrings = {
18
18
  /**
@@ -236,7 +236,7 @@ class LighthouseRun {
236
236
  }
237
237
  }
238
238
 
239
- async collect(): Promise<RunnerResult> {
239
+ async collect(): Promise<LighthouseModel.ReporterTypes.RunnerResult> {
240
240
  try {
241
241
  const lighthouseResponse = await this.protocolService.collectLighthouseResults(
242
242
  {inspectedURL: this.inspectedURL, categoryIDs: this.categoryIDs, flags: this.flags});
@@ -663,7 +663,7 @@ export class LighthouseController extends Common.ObjectWrapper.ObjectWrapper<Eve
663
663
  return await this.lastAction;
664
664
  }
665
665
 
666
- async collectLighthouseResults(): Promise<RunnerResult> {
666
+ async collectLighthouseResults(): Promise<LighthouseModel.ReporterTypes.RunnerResult> {
667
667
  if (!this.currentLighthouseRun) {
668
668
  throw new Error('Lighthouse is not started');
669
669
  }
@@ -7,6 +7,7 @@ import '../../ui/legacy/legacy.js';
7
7
 
8
8
  import * as Common from '../../core/common/common.js';
9
9
  import * as i18n from '../../core/i18n/i18n.js';
10
+ import type * as LighthouseModel from '../../models/lighthouse/lighthouse.js';
10
11
  import * as UI from '../../ui/legacy/legacy.js';
11
12
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
12
13
 
@@ -19,7 +20,6 @@ import {
19
20
  } from './LighthouseController.js';
20
21
  import lighthousePanelStyles from './lighthousePanel.css.js';
21
22
  import {ProtocolService} from './LighthouseProtocolService.js';
22
- import type {ReportJSON, RunnerResultArtifacts} from './LighthouseReporterTypes.js';
23
23
  import {LighthouseReportRenderer} from './LighthouseReportRenderer.js';
24
24
  import {Item, ReportSelector} from './LighthouseReportSelector.js';
25
25
  import {StartView} from './LighthouseStartView.js';
@@ -69,7 +69,7 @@ export class LighthousePanel extends UI.Panel.Panel {
69
69
  private readonly timespanView: TimespanView;
70
70
  private warningText: Nullable<string>;
71
71
  private unauditableExplanation: Nullable<string>;
72
- private readonly cachedRenderedReports: Map<ReportJSON, HTMLElement>;
72
+ private readonly cachedRenderedReports: Map<LighthouseModel.ReporterTypes.ReportJSON, HTMLElement>;
73
73
  private readonly dropTarget: UI.DropTarget.DropTarget;
74
74
  private readonly auditResultsElement: HTMLElement;
75
75
  private clearButton!: UI.Toolbar.ToolbarButton;
@@ -296,7 +296,9 @@ export class LighthousePanel extends UI.Panel.Panel {
296
296
  this.statusView.toggleCancelButton(true);
297
297
  }
298
298
 
299
- private renderReport(lighthouseResult: ReportJSON, artifacts?: RunnerResultArtifacts): void {
299
+ private renderReport(
300
+ lighthouseResult: LighthouseModel.ReporterTypes.ReportJSON,
301
+ artifacts?: LighthouseModel.ReporterTypes.RunnerResultArtifacts): void {
300
302
  this.toggleSettingsDisplay(false);
301
303
  this.contentElement.classList.toggle('in-progress', false);
302
304
  this.startView.hideWidget();
@@ -319,7 +321,9 @@ export class LighthousePanel extends UI.Panel.Panel {
319
321
  this.cachedRenderedReports.set(lighthouseResult, reportContainer);
320
322
  }
321
323
 
322
- private buildReportUI(lighthouseResult: ReportJSON, artifacts?: RunnerResultArtifacts): void {
324
+ private buildReportUI(
325
+ lighthouseResult: LighthouseModel.ReporterTypes.ReportJSON,
326
+ artifacts?: LighthouseModel.ReporterTypes.RunnerResultArtifacts): void {
323
327
  if (lighthouseResult === null) {
324
328
  return;
325
329
  }
@@ -355,7 +359,7 @@ export class LighthousePanel extends UI.Panel.Panel {
355
359
  if (!data['lighthouseVersion']) {
356
360
  return;
357
361
  }
358
- this.buildReportUI(data as ReportJSON);
362
+ this.buildReportUI(data as LighthouseModel.ReporterTypes.ReportJSON);
359
363
  }
360
364
 
361
365
  override elementsToRestoreScrollPositionsFor(): Element[] {
@@ -7,8 +7,7 @@ import type * as Platform from '../../core/platform/platform.js';
7
7
  import type * as ProtocolClient from '../../core/protocol_client/protocol_client.js';
8
8
  import * as SDK from '../../core/sdk/sdk.js';
9
9
  import type * as Protocol from '../../generated/protocol.js';
10
-
11
- import type * as ReportRenderer from './LighthouseReporterTypes.js';
10
+ import type * as LighthouseModel from '../../models/lighthouse/lighthouse.js';
12
11
 
13
12
  /**
14
13
  * @file
@@ -149,7 +148,8 @@ export class ProtocolService implements ProtocolClient.CDPConnection.CDPConnecti
149
148
  });
150
149
  }
151
150
 
152
- async collectLighthouseResults(currentLighthouseRun: LighthouseRun): Promise<ReportRenderer.RunnerResult> {
151
+ async collectLighthouseResults(currentLighthouseRun: LighthouseRun):
152
+ Promise<LighthouseModel.ReporterTypes.RunnerResult> {
153
153
  const {inspectedURL, categoryIDs, flags} = currentLighthouseRun;
154
154
 
155
155
  if (!this.mainSessionId || !this.rootTargetId) {
@@ -289,10 +289,10 @@ export class ProtocolService implements ProtocolClient.CDPConnection.CDPConnecti
289
289
 
290
290
  /** sendWithResponse currently only handles the original startLighthouse request and LHR-filled response. */
291
291
  private async sendWithResponse(action: string, args: Record<string, string|string[]|object|undefined> = {}):
292
- Promise<ReportRenderer.RunnerResult> {
292
+ Promise<LighthouseModel.ReporterTypes.RunnerResult> {
293
293
  const worker = await this.ensureWorkerExists();
294
294
  const messageId = lastId++;
295
- const messageResult = new Promise<ReportRenderer.RunnerResult>(resolve => {
295
+ const messageResult = new Promise<LighthouseModel.ReporterTypes.RunnerResult>(resolve => {
296
296
  const workerListener = (event: MessageEvent): void => {
297
297
  const lighthouseMessage = event.data;
298
298
 
@@ -6,6 +6,7 @@ import * as Common from '../../core/common/common.js';
6
6
  import * as Host from '../../core/host/host.js';
7
7
  import * as Platform from '../../core/platform/platform.js';
8
8
  import * as SDK from '../../core/sdk/sdk.js';
9
+ import type * as LighthouseModel from '../../models/lighthouse/lighthouse.js';
9
10
  import * as TextUtils from '../../models/text_utils/text_utils.js';
10
11
  import * as Workspace from '../../models/workspace/workspace.js';
11
12
  import * as LighthouseReport from '../../third_party/lighthouse/report/report.js';
@@ -15,9 +16,6 @@ import * as ThemeSupport from '../../ui/legacy/theme_support/theme_support.js';
15
16
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
16
17
  import * as PanelsCommon from '../common/common.js';
17
18
 
18
- import type {
19
- NodeDetailsJSON, ReportJSON, RunnerResultArtifacts, SourceLocationDetailsJSON} from './LighthouseReporterTypes.js';
20
-
21
19
  const MaxLengthForLinks = 40;
22
20
 
23
21
  interface RenderReportOpts {
@@ -26,8 +24,9 @@ interface RenderReportOpts {
26
24
  }
27
25
 
28
26
  export class LighthouseReportRenderer {
29
- static renderLighthouseReport(lhr: ReportJSON, artifacts?: RunnerResultArtifacts, opts?: RenderReportOpts):
30
- HTMLElement {
27
+ static renderLighthouseReport(
28
+ lhr: LighthouseModel.ReporterTypes.ReportJSON, artifacts?: LighthouseModel.ReporterTypes.RunnerResultArtifacts,
29
+ opts?: RenderReportOpts): HTMLElement {
31
30
  let onViewTrace: (() => Promise<void>)|undefined = undefined;
32
31
  if (artifacts) {
33
32
  onViewTrace = async () => {
@@ -134,7 +133,7 @@ export class LighthouseReportRenderer {
134
133
 
135
134
  for (const origElement of el.getElementsByClassName('lh-node')) {
136
135
  const origHTMLElement = origElement as HTMLElement;
137
- const detailsItem = origHTMLElement.dataset as unknown as NodeDetailsJSON;
136
+ const detailsItem = origHTMLElement.dataset as unknown as LighthouseModel.ReporterTypes.NodeDetailsJSON;
138
137
  if (!detailsItem.path) {
139
138
  continue;
140
139
  }
@@ -165,7 +164,7 @@ export class LighthouseReportRenderer {
165
164
  static async linkifySourceLocationDetails(el: Element): Promise<void> {
166
165
  for (const origElement of el.getElementsByClassName('lh-source-location')) {
167
166
  const origHTMLElement = origElement as HTMLElement;
168
- const detailsItem = origHTMLElement.dataset as SourceLocationDetailsJSON;
167
+ const detailsItem = origHTMLElement.dataset as LighthouseModel.ReporterTypes.SourceLocationDetailsJSON;
169
168
  if (!detailsItem.sourceUrl || !detailsItem.sourceLine || !detailsItem.sourceColumn) {
170
169
  continue;
171
170
  }
@@ -197,7 +196,7 @@ export class LighthouseReportRenderer {
197
196
  continue;
198
197
  }
199
198
 
200
- auditEl.setAttribute('jslog', `${VisualLogging.item(`lighthouse.audit.${id}`)}`);
199
+ auditEl.setAttribute('jslog', `${VisualLogging.item(`lighthouse.audit.${id}`).track({resize: true})}`);
201
200
 
202
201
  let state: string|undefined;
203
202
  for (const className of auditEl.classList) {
@@ -5,10 +5,9 @@
5
5
 
6
6
  import * as Common from '../../core/common/common.js';
7
7
  import * as i18n from '../../core/i18n/i18n.js';
8
+ import type * as LighthouseModel from '../../models/lighthouse/lighthouse.js';
8
9
  import * as UI from '../../ui/legacy/legacy.js';
9
10
 
10
- import type * as ReportRenderer from './LighthouseReporterTypes.js';
11
-
12
11
  const UIStrings = {
13
12
  /**
14
13
  * @description Title of combo box in audits report selector
@@ -102,7 +101,9 @@ export class Item {
102
101
  private readonly showLandingCallback: () => void;
103
102
  private readonly element: HTMLOptionElement;
104
103
 
105
- constructor(lighthouseResult: ReportRenderer.ReportJSON, renderReport: () => void, showLandingCallback: () => void) {
104
+ constructor(
105
+ lighthouseResult: LighthouseModel.ReporterTypes.ReportJSON, renderReport: () => void,
106
+ showLandingCallback: () => void) {
106
107
  this.renderReport = renderReport;
107
108
  this.showLandingCallback = showLandingCallback;
108
109