chrome-devtools-frontend 1.0.1592129 → 1.0.1593518

package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts

@@ -183,26 +183,26 @@ export interface CookiesTableData {
 }
 
 export class CookiesTable extends UI.Widget.VBox {
-  private saveCallback?: ((arg0: SDK.Cookie.Cookie, arg1: SDK.Cookie.Cookie|null) => Promise<boolean>);
-  private readonly refreshCallback?: (() => void);
-  private readonly selectedCallback?: (() => void);
-  private readonly deleteCallback?: ((arg0: SDK.Cookie.Cookie, arg1: () => void) => void);
+  #saveCallback?: ((arg0: SDK.Cookie.Cookie, arg1: SDK.Cookie.Cookie|null) => Promise<boolean>);
+  #refreshCallback?: (() => void);
+  #selectedCallback?: ((arg0: SDK.Cookie.Cookie|null) => void);
+  #deleteCallback?: ((arg0: SDK.Cookie.Cookie, arg1: () => void) => void);
   private lastEditedColumnId: string|null;
   private data: CookieData[] = [];
   private cookies: SDK.Cookie.Cookie[] = [];
-  private cookieDomain: string;
+  #cookieDomain: string;
   private cookieToBlockedReasons: ReadonlyMap<SDK.Cookie.Cookie, SDK.CookieModel.BlockedReason[]>|null;
   private cookieToExemptionReason: ReadonlyMap<SDK.Cookie.Cookie, SDK.CookieModel.ExemptionReason>|null;
   private readonly view: ViewFunction;
   private selectedKey?: string;
-  private readonly editable: boolean;
+  #editable: boolean;
   private renderInline: boolean;
   private readonly schemeBindingEnabled: boolean;
   private readonly portBindingEnabled: boolean;
   constructor(
       element?: HTMLElement, renderInline?: boolean,
       saveCallback?: ((arg0: SDK.Cookie.Cookie, arg1: SDK.Cookie.Cookie|null) => Promise<boolean>),
-      refreshCallback?: (() => void), selectedCallback?: (() => void),
+      refreshCallback?: (() => void), selectedCallback?: ((arg0: SDK.Cookie.Cookie|null) => void),
       deleteCallback?: ((arg0: SDK.Cookie.Cookie, arg1: () => void) => void), view?: ViewFunction) {
     super(element);
     if (!view) {
@@ -302,11 +302,11 @@ export class CookiesTable extends UI.Widget.VBox {
 
     this.element.classList.add('cookies-table');
 
-    this.saveCallback = saveCallback;
-    this.refreshCallback = refreshCallback;
-    this.deleteCallback = deleteCallback;
+    this.#saveCallback = saveCallback;
+    this.#refreshCallback = refreshCallback;
+    this.#deleteCallback = deleteCallback;
 
-    this.editable = Boolean(saveCallback);
+    this.#editable = Boolean(saveCallback);
     const {devToolsEnableOriginBoundCookies} = Root.Runtime.hostConfig;
 
     this.schemeBindingEnabled = Boolean(devToolsEnableOriginBoundCookies?.schemeBindingEnabled);
@@ -316,13 +316,13 @@ export class CookiesTable extends UI.Widget.VBox {
 
     this.renderInline = Boolean(renderInline);
 
-    this.selectedCallback = selectedCallback;
+    this.#selectedCallback = selectedCallback;
 
     this.lastEditedColumnId = null;
 
     this.data = [];
 
-    this.cookieDomain = '';
+    this.#cookieDomain = '';
 
     this.cookieToBlockedReasons = null;
 
@@ -335,6 +335,26 @@ export class CookiesTable extends UI.Widget.VBox {
     this.setCookies(data.cookies, data.cookieToBlockedReasons, data.cookieToExemptionReason);
   }
 
+  set saveCallback(callback: (arg0: SDK.Cookie.Cookie, arg1: SDK.Cookie.Cookie|null) => Promise<boolean>) {
+    this.#saveCallback = callback;
+  }
+
+  set refreshCallback(callback: () => void) {
+    this.#refreshCallback = callback;
+  }
+
+  set selectedCallback(callback: (arg0: SDK.Cookie.Cookie|null) => void) {
+    this.#selectedCallback = callback;
+  }
+
+  set deleteCallback(callback: (arg0: SDK.Cookie.Cookie, arg1: () => void) => void) {
+    this.#deleteCallback = callback;
+  }
+
+  set editable(value: boolean) {
+    this.#editable = value;
+  }
+
   set inline(value: boolean) {
     this.renderInline = value;
     this.requestUpdate();
@@ -357,8 +377,8 @@ export class CookiesTable extends UI.Widget.VBox {
     this.requestUpdate();
   }
 
-  setCookieDomain(cookieDomain: string): void {
-    this.cookieDomain = cookieDomain;
+  set cookieDomain(cookieDomain: string) {
+    this.#cookieDomain = cookieDomain;
   }
 
   selectedCookie(): SDK.Cookie.Cookie|null {
@@ -374,7 +394,7 @@ export class CookiesTable extends UI.Widget.VBox {
     const input: ViewInput = {
       data: this.data,
       selectedKey: this.selectedKey,
-      editable: this.editable,
+      editable: this.#editable,
       renderInline: this.renderInline,
       schemeBindingEnabled: this.schemeBindingEnabled,
       portBindingEnabled: this.portBindingEnabled,
@@ -391,13 +411,13 @@ export class CookiesTable extends UI.Widget.VBox {
 
   private onSelect(key: string|undefined): void {
     this.selectedKey = key;
-    this.selectedCallback?.();
+    this.#selectedCallback?.(this.selectedCookie());
   }
 
   private onDeleteCookie(data: CookieData): void {
     const cookie = this.cookies.find(cookie => cookie.key() === data.key);
-    if (cookie && this.deleteCallback) {
-      this.deleteCallback(cookie, () => this.refresh());
+    if (cookie && this.#deleteCallback) {
+      this.#deleteCallback(cookie, () => this.refresh());
     }
   }
 
@@ -434,7 +454,7 @@ export class CookiesTable extends UI.Widget.VBox {
       data[SDK.Cookie.Attribute.VALUE] = '';
     }
     if (data[SDK.Cookie.Attribute.DOMAIN] === undefined) {
-      data[SDK.Cookie.Attribute.DOMAIN] = this.cookieDomain;
+      data[SDK.Cookie.Attribute.DOMAIN] = this.#cookieDomain;
     }
     if (data[SDK.Cookie.Attribute.PATH] === undefined) {
       data[SDK.Cookie.Attribute.PATH] = '/';
@@ -448,11 +468,11 @@ export class CookiesTable extends UI.Widget.VBox {
   }
 
   private saveCookie(newCookieData: CookieData, oldCookie?: SDK.Cookie.Cookie): void {
-    if (!this.saveCallback) {
+    if (!this.#saveCallback) {
       return;
     }
     const newCookie = this.createCookieFromData(newCookieData);
-    void this.saveCallback(newCookie, oldCookie ?? null).then(success => {
+    void this.#saveCallback(newCookie, oldCookie ?? null).then(success => {
       if (!success) {
         newCookieData.dirty = true;
       }
@@ -591,8 +611,8 @@ export class CookiesTable extends UI.Widget.VBox {
   }
 
   private refresh(): void {
-    if (this.refreshCallback) {
-      this.refreshCallback();
+    if (this.#refreshCallback) {
+      this.#refreshCallback();
     }
   }
 

package/front_end/ui/legacy/components/data_grid/DataGrid.ts

@@ -1766,8 +1766,10 @@ export class DataGridNode<T> {
 
   protected createElement(): HTMLElement {
     this.elementInternal = document.createElement('tr');
-    this.elementInternal.setAttribute(
-        'jslog', `${VisualLogging.tableRow().track({keydown: 'ArrowUp|ArrowDown|ArrowLeft|ArrowRight|Enter|Space'})}`);
+    this.elementInternal.setAttribute('jslog', `${VisualLogging.tableRow().track({
+                                        resize: true,
+                                        keydown: 'ArrowUp|ArrowDown|ArrowLeft|ArrowRight|Enter|Space'
+                                      })}`);
     this.elementInternal.classList.add('data-grid-data-grid-node');
     if (this.dataGrid) {
       this.dataGrid.elementToDataGridNode.set(this.elementInternal, this);

package/front_end/ui/legacy/components/quick_open/FilteredListWidget.ts

@@ -280,7 +280,7 @@ export class FilteredListWidget extends Common.ObjectWrapper.eventMixin<EventTyp
     if (this.provider) {
       render(this.provider.renderItem(item, this.cleanValue()), wrapperElement);
       wrapperElement.setAttribute(
-          'jslog', `${VisualLogging.item(this.provider.jslogContextAt(item)).track({click: true})}`);
+          'jslog', `${VisualLogging.item(this.provider.jslogContextAt(item)).track({click: true, resize: true})}`);
     }
     UI.ARIAUtils.markAsOption(wrapperElement);
     return wrapperElement;

package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts

@@ -34,6 +34,7 @@
  */
 
 import * as i18n from '../../../../core/i18n/i18n.js';
+import * as Root from '../../../../core/root/root.js';
 import * as SDK from '../../../../core/sdk/sdk.js';
 import * as StackTrace from '../../../../models/stack_trace/stack_trace.js';
 import * as Workspace from '../../../../models/workspace/workspace.js';
@@ -242,6 +243,36 @@ export class StackTracePreviewContent extends UI.Widget.Widget {
       onShowLess: this.#onShowMoreLess.bind(this, false),
     };
     this.#view(input, {}, this.contentElement);
+    this.#updateHasNonIgnoredLinks();
+  }
+
+  // Propagate ignore-list state to the host element so that CSS outside the
+  // shadow DOM can coordinate ignore-list toggling across multiple stack
+  // traces (e.g. Error inline stack + console.error call stack).
+  // See crbug.com/379788109.
+  #updateHasNonIgnoredLinks = (): void => {
+    const hasNonIgnoredLinks = this.linkElements.some(link => {
+      const uiLocation = Linkifier.uiLocation(link);
+      if (uiLocation) {
+        return !uiLocation.isIgnoreListed();
+      }
+      return !link.classList.contains('ignore-list-link');
+    });
+    this.element.classList.toggle('has-non-ignored-links', hasNonIgnoredLinks);
+  };
+
+  override wasShown(): void {
+    super.wasShown();
+    if (Root.DevToolsContext.globalInstance().has(Workspace.IgnoreListManager.IgnoreListManager)) {
+      Workspace.IgnoreListManager.IgnoreListManager.instance().addChangeListener(this.#updateHasNonIgnoredLinks);
+    }
+  }
+
+  override willHide(): void {
+    if (Root.DevToolsContext.globalInstance().has(Workspace.IgnoreListManager.IgnoreListManager)) {
+      Workspace.IgnoreListManager.IgnoreListManager.instance().removeChangeListener(this.#updateHasNonIgnoredLinks);
+    }
+    super.willHide();
   }
 
   get linkElements(): readonly HTMLElement[] {

package/front_end/ui/visual_logging/Debugging.ts

@@ -878,6 +878,10 @@ function checkPendingEventExpectation(): void {
     }
     if (!found) {
       processMissingEvents(pendingEventExpectation, expectedEventIndex, matchedImpressions);
+      if (!pendingEventExpectation.missingEvents?.length) {
+        numMatchedEvents = actualEventIndex;
+        pendingEventExpectation.success();
+      }
       return;
     }
   }

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -2058,6 +2058,7 @@ export const knownContextValues = new Set([
   'java-script-disabled-true',
   'javascript',
   'javascript-context',
+  'jpeg-xl',
   'jpeg-xl-format-disabled',
   'jpeg-xl-format-disabled-true',
   'jpg-header',
@@ -3720,6 +3721,7 @@ export const knownContextValues = new Set([
   'srgb',
   'stack-trace',
   'stalled',
+  'standalone-styles',
   'standard-emulated-device-list',
   'start',
   'start-conversation-drjones-file',

package/package.json

@@ -105,5 +105,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1592129"
+  "version": "1.0.1593518"
 }