chrome-devtools-frontend 1.0.1583146 → 1.0.1585664

package/front_end/panels/network/RequestConditionsDrawer.ts

@@ -183,6 +183,109 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
       target);
 };
 
+function renderItem(
+    condition: SDK.NetworkManager.RequestCondition, editable: boolean, index: number,
+    onToggle: (condition: SDK.NetworkManager.RequestCondition) => void,
+    onConditionsChanged: (
+        condition: SDK.NetworkManager.RequestCondition, conditions: SDK.NetworkManager.ThrottlingConditions) => void,
+    onIncreasePriority: (condition: SDK.NetworkManager.RequestCondition) => void,
+    onDecreasePriority: (condition: SDK.NetworkManager.RequestCondition) => void,
+    lookUpRequestCount: (condition: SDK.NetworkManager.RequestCondition) => number): LitTemplate {
+  const {enabled, originalOrUpgradedURLPattern, constructorStringOrWildcardURL, wildcardURL} = condition;
+  const toggle = (e: Event): void => {
+    e.consume(true);
+    onToggle(condition);
+  };
+
+  const moveUp = (e: Event): void => {
+    e.consume(true);
+    onIncreasePriority(condition);
+  };
+
+  const moveDown = (e: Event): void => {
+    e.consume(true);
+    onDecreasePriority(condition);
+  };
+
+  // clang-format off
+  return html`
+    <input class=blocked-url-checkbox
+      @change=${toggle}
+      type=checkbox
+      title=${i18nString(UIStrings.enableThrottlingToggleLabel, {PH1: constructorStringOrWildcardURL})}
+      .checked=${live(enabled)}
+      .disabled=${!editable || !originalOrUpgradedURLPattern}
+      jslog=${VisualLogging.toggle().track({ change: true })}>
+    <devtools-button
+      .iconName=${'arrow-up'}
+      .variant=${Buttons.Button.Variant.ICON}
+      .title=${i18nString(UIStrings.increasePriority, {PH1: constructorStringOrWildcardURL})}
+      .jslogContext=${'decrease-priority'}
+      ?disabled=${!editable || !originalOrUpgradedURLPattern}
+      @click=${moveUp}>
+    </devtools-button>
+    <devtools-button
+      .iconName=${'arrow-down'}
+      .variant=${Buttons.Button.Variant.ICON}
+      .title=${i18nString(UIStrings.decreasePriority, {PH1: constructorStringOrWildcardURL})}
+      .jslogContext=${'increase-priority'}
+      ?disabled=${!editable || !originalOrUpgradedURLPattern}
+      @click=${moveDown}></devtools-button>
+    ${originalOrUpgradedURLPattern ? html`
+      <devtools-tooltip variant=rich jslogcontext=url-pattern id=url-pattern-${index}>
+        <div>hash: ${originalOrUpgradedURLPattern.hash}</div>
+        <div>hostname: ${originalOrUpgradedURLPattern.hostname}</div>
+        <div>password: ${originalOrUpgradedURLPattern.password}</div>
+        <div>pathname: ${originalOrUpgradedURLPattern.pathname}</div>
+        <div>port: ${originalOrUpgradedURLPattern.port}</div>
+        <div>protocol: ${originalOrUpgradedURLPattern.protocol}</div>
+        <div>search: ${originalOrUpgradedURLPattern.search}</div>
+        <div>username: ${originalOrUpgradedURLPattern.username}</div>
+        <hr />
+        ${learnMore()}
+      </devtools-tooltip>` : nothing}
+    ${wildcardURL ? html`
+      <devtools-icon name=warning-filled class="small warning" aria-details=url-pattern-warning-${index}>
+      </devtools-icon>
+      <devtools-tooltip variant=rich jslogcontext=url-pattern-warning id=url-pattern-warning-${index}>
+        ${i18nString(UIStrings.patternWasUpgraded, {PH1: wildcardURL})}
+      </devtools-tooltip>
+      `: nothing}
+    ${!originalOrUpgradedURLPattern ? html`
+      <devtools-icon name=cross-circle-filled class=small aria-details=url-pattern-error-${index}>
+      </devtools-icon>
+      <devtools-tooltip variant=rich jslogcontext=url-pattern-warning id=url-pattern-error-${index}>
+        ${SDK.NetworkManager.RequestURLPattern.isValidPattern(constructorStringOrWildcardURL) ===
+            SDK.NetworkManager.RequestURLPatternValidity.HAS_REGEXP_GROUPS
+            ? i18nString(UIStrings.patternFailedWithRegExpGroups)
+            : i18nString(UIStrings.patternFailedToParse)}
+        ${learnMore()}
+      </devtools-tooltip>`: nothing}
+    <div
+      @click=${toggle}
+      ?disabled=${!editable || !originalOrUpgradedURLPattern}
+      class=blocked-url-label
+      aria-details=url-pattern-${index}>
+        ${constructorStringOrWildcardURL}
+    </div>
+    <devtools-widget
+       class=conditions-selector
+       title=${i18nString(UIStrings.requestConditionsLabel)}
+       .widgetConfig=${UI.Widget.widgetConfig(
+         MobileThrottling.NetworkThrottlingSelector.NetworkThrottlingSelectorWidget, {
+           variant:
+             MobileThrottling.NetworkThrottlingSelector.NetworkThrottlingSelect.Variant.INDIVIDUAL_REQUEST_CONDITIONS,
+           jslogContext: 'request-conditions',
+           disabled: !editable,
+           onConditionsChanged: conditions => onConditionsChanged(condition, conditions),
+           currentConditions: condition.conditions,
+         })}></devtools-widget>
+    <devtools-widget
+      ?disabled=${!editable || !originalOrUpgradedURLPattern}
+      .widgetConfig=${widgetConfig(AffectedCountWidget, {condition, lookUpRequestCount})}></devtools-widget>`;
+  // clang-format on
+}
+
 interface AffectedCountViewInput {
   count: number;
 }
@@ -198,39 +301,36 @@ function matchesUrl(conditions: SDK.NetworkManager.RequestCondition, url: string
 export class AffectedCountWidget extends UI.Widget.Widget {
   readonly #view: AffectedCountView;
   #condition?: SDK.NetworkManager.RequestCondition;
-  #drawer?: RequestConditionsDrawer;
+  #lookUpRequestCount?: (condition: SDK.NetworkManager.RequestCondition) => number;
+
   constructor(target?: HTMLElement, view = AFFECTED_COUNT_DEFAULT_VIEW) {
     super(target, {classes: ['blocked-url-count']});
     this.#view = view;
   }
 
-  get condition(): SDK.NetworkManager.RequestCondition|undefined {
-    return this.#condition;
+  get lookUpRequestCount(): ((condition: SDK.NetworkManager.RequestCondition) => number)|undefined {
+    return this.#lookUpRequestCount;
   }
 
-  set condition(conditions: SDK.NetworkManager.RequestCondition) {
-    this.#condition = conditions;
-    this.requestUpdate();
+  set lookUpRequestCount(val: (condition: SDK.NetworkManager.RequestCondition) => number) {
+    this.#lookUpRequestCount = val;
   }
 
-  get drawer(): RequestConditionsDrawer|undefined {
-    return this.#drawer;
+  get condition(): SDK.NetworkManager.RequestCondition|undefined {
+    return this.#condition;
   }
 
-  set drawer(drawer: RequestConditionsDrawer) {
-    this.#drawer = drawer;
+  set condition(conditions: SDK.NetworkManager.RequestCondition) {
+    this.#condition = conditions;
     this.requestUpdate();
   }
 
   override performUpdate(): void {
-    if (!this.#condition || !this.#drawer) {
+    if (!this.#condition || !this.#lookUpRequestCount) {
       return;
     }
 
-    const count = this.#condition.isBlocking ? this.#drawer.blockedRequestsCount(this.#condition) :
-                                               this.#drawer.throttledRequestsCount(this.#condition);
-
-    this.#view({count}, {}, this.element);
+    this.#view({count: this.#lookUpRequestCount(this.#condition)}, {}, this.element);
   }
 
   override wasShown(): void {
@@ -342,112 +442,38 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
 
   updateItem(element: HTMLElement, condition: SDK.NetworkManager.RequestCondition, editable: boolean, index: number):
       void {
-    const toggle = (e: Event): void => {
+    const onToggle = (condition: {enabled: boolean}): void => {
       if (editable) {
-        e.consume(true);
         condition.enabled = !condition.enabled;
       }
     };
-    const onConditionsChanged = (conditions: SDK.NetworkManager.ThrottlingConditions): void => {
-      if (editable) {
-        condition.conditions = conditions;
-      }
-    };
 
-    const {enabled, originalOrUpgradedURLPattern, constructorStringOrWildcardURL, wildcardURL} = condition;
+    const onConditionsChanged =
+        (condition: {conditions: SDK.NetworkManager.ThrottlingConditions},
+         conditions: SDK.NetworkManager.ThrottlingConditions): void => {
+          if (editable) {
+            condition.conditions = conditions;
+          }
+        };
 
-    const moveUp = (e: Event): void => {
+    const onIncreasePriority = (condition: SDK.NetworkManager.RequestCondition): void => {
       if (this.manager.requestConditions.conditionsEnabled) {
         UI.ARIAUtils.LiveAnnouncer.status(i18nString(UIStrings.patternMovedUp));
-        e.consume(true);
         this.manager.requestConditions.increasePriority(condition);
       }
     };
-    const moveDown = (e: Event): void => {
+
+    const onDecreasePriority = (condition: SDK.NetworkManager.RequestCondition): void => {
       if (this.manager.requestConditions.conditionsEnabled) {
         UI.ARIAUtils.LiveAnnouncer.status(i18nString(UIStrings.patternMovedDown));
-        e.consume(true);
         this.manager.requestConditions.decreasePriority(condition);
       }
     };
+
     render(
-        // clang-format off
-        html`
-    <input class=blocked-url-checkbox
-      @change=${toggle}
-      type=checkbox
-      title=${i18nString(UIStrings.enableThrottlingToggleLabel, {PH1: constructorStringOrWildcardURL})}
-      .checked=${live(enabled)}
-      .disabled=${!editable || !originalOrUpgradedURLPattern}
-      jslog=${VisualLogging.toggle().track({ change: true })}>
-    <devtools-button
-      .iconName=${'arrow-up'}
-      .variant=${Buttons.Button.Variant.ICON}
-      .title=${i18nString(UIStrings.increasePriority, {PH1: constructorStringOrWildcardURL})}
-      .jslogContext=${'decrease-priority'}
-      ?disabled=${!editable || !originalOrUpgradedURLPattern}
-      @click=${moveUp}>
-    </devtools-button>
-    <devtools-button
-      .iconName=${'arrow-down'}
-      .variant=${Buttons.Button.Variant.ICON}
-      .title=${i18nString(UIStrings.decreasePriority, {PH1: constructorStringOrWildcardURL})}
-      .jslogContext=${'increase-priority'}
-      ?disabled=${!editable || !originalOrUpgradedURLPattern}
-      @click=${moveDown}></devtools-button>
-    ${originalOrUpgradedURLPattern ? html`
-      <devtools-tooltip variant=rich jslogcontext=url-pattern id=url-pattern-${index}>
-        <div>hash: ${originalOrUpgradedURLPattern.hash}</div>
-        <div>hostname: ${originalOrUpgradedURLPattern.hostname}</div>
-        <div>password: ${originalOrUpgradedURLPattern.password}</div>
-        <div>pathname: ${originalOrUpgradedURLPattern.pathname}</div>
-        <div>port: ${originalOrUpgradedURLPattern.port}</div>
-        <div>protocol: ${originalOrUpgradedURLPattern.protocol}</div>
-        <div>search: ${originalOrUpgradedURLPattern.search}</div>
-        <div>username: ${originalOrUpgradedURLPattern.username}</div>
-        <hr />
-        ${learnMore()}
-      </devtools-tooltip>` : nothing}
-    ${wildcardURL ? html`
-      <devtools-icon name=warning-filled class="small warning" aria-details=url-pattern-warning-${index}>
-      </devtools-icon>
-      <devtools-tooltip variant=rich jslogcontext=url-pattern-warning id=url-pattern-warning-${index}>
-        ${i18nString(UIStrings.patternWasUpgraded, {PH1: wildcardURL})}
-      </devtools-tooltip>
-      `: nothing}
-    ${!originalOrUpgradedURLPattern ? html`
-      <devtools-icon name=cross-circle-filled class=small aria-details=url-pattern-error-${index}>
-      </devtools-icon>
-      <devtools-tooltip variant=rich jslogcontext=url-pattern-warning id=url-pattern-error-${index}>
-        ${SDK.NetworkManager.RequestURLPattern.isValidPattern(constructorStringOrWildcardURL) ===
-            SDK.NetworkManager.RequestURLPatternValidity.HAS_REGEXP_GROUPS
-            ? i18nString(UIStrings.patternFailedWithRegExpGroups)
-            : i18nString(UIStrings.patternFailedToParse)}
-        ${learnMore()}
-      </devtools-tooltip>`: nothing}
-    <div
-      @click=${toggle}
-      ?disabled=${!editable || !originalOrUpgradedURLPattern}
-      class=blocked-url-label
-      aria-details=url-pattern-${index}>
-        ${constructorStringOrWildcardURL}
-    </div>
-    <devtools-widget
-       class=conditions-selector
-       title=${i18nString(UIStrings.requestConditionsLabel)}
-       .widgetConfig=${UI.Widget.widgetConfig(
-         MobileThrottling.NetworkThrottlingSelector.NetworkThrottlingSelectorWidget, {
-           variant:
-             MobileThrottling.NetworkThrottlingSelector.NetworkThrottlingSelect.Variant.INDIVIDUAL_REQUEST_CONDITIONS,
-           jslogContext: 'request-conditions',
-           disabled: !editable,
-           onConditionsChanged,
-           currentConditions: condition.conditions,
-         })}></devtools-widget>
-    <devtools-widget
-      ?disabled=${!editable || !originalOrUpgradedURLPattern}
-      .widgetConfig=${widgetConfig(AffectedCountWidget, {condition, drawer: this})}></devtools-widget>`,
-        // clang-format on
+        renderItem(
+            condition, editable, index, onToggle, onConditionsChanged, onIncreasePriority, onDecreasePriority,
+            this.#getRequestCount.bind(this)),
         element);
   }
 
@@ -546,17 +572,17 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
     this.requestUpdate();
   }
 
-  blockedRequestsCount(condition: SDK.NetworkManager.RequestCondition): number {
-    let result = 0;
-    for (const blockedUrl of this.blockedCountForUrl.keys()) {
-      if (matchesUrl(condition, blockedUrl)) {
-        result += (this.blockedCountForUrl.get(blockedUrl) as number);
+  #getRequestCount(condition: SDK.NetworkManager.RequestCondition): number {
+    if (condition.isBlocking) {
+      let result = 0;
+      for (const blockedUrl of this.blockedCountForUrl.keys()) {
+        if (matchesUrl(condition, blockedUrl)) {
+          result += (this.blockedCountForUrl.get(blockedUrl) as number);
+        }
       }
+      return result;
     }
-    return result;
-  }
 
-  throttledRequestsCount(condition: SDK.NetworkManager.RequestCondition): number {
     let result = 0;
     for (const ruleId of condition.ruleIds) {
       result += this.#throttledCount.get(ruleId) ?? 0;

package/front_end/panels/network/RequestInitiatorView.ts

@@ -39,8 +39,6 @@ export interface ViewInput {
   initiatorGraph: Logs.NetworkLog.InitiatorGraph;
   stackTrace: StackTrace.StackTrace.StackTrace|null;
   request: SDK.NetworkRequest.NetworkRequest;
-  linkifier: Components.Linkifier.Linkifier;
-  target?: SDK.Target.Target;
 }
 
 export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLElement): void => {
@@ -68,8 +66,6 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
         <ul role="group">
           <li role="treeitem">
             <devtools-widget .widgetConfig=${widgetConfig(Components.JSPresentationUtils.StackTracePreviewContent, {
-      target: input.target,
-      linkifier: input.linkifier,
       options: {tabStops: true},
       stackTrace: input.stackTrace,
     })}></devtools-widget>
@@ -165,7 +161,6 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
 type View = typeof DEFAULT_VIEW;
 
 export class RequestInitiatorView extends UI.Widget.VBox {
-  private readonly linkifier: Components.Linkifier.Linkifier;
   private readonly request: SDK.NetworkRequest.NetworkRequest;
   #view: View;
 
@@ -173,7 +168,6 @@ export class RequestInitiatorView extends UI.Widget.VBox {
     super({jslog: `${VisualLogging.pane('initiator').track({resize: true})}`});
 
     this.element.classList.add('request-initiator-view');
-    this.linkifier = new Components.Linkifier.Linkifier();
     this.request = request;
     this.#view = view;
   }
@@ -192,8 +186,8 @@ export class RequestInitiatorView extends UI.Widget.VBox {
     const networkManager = SDK.NetworkManager.NetworkManager.forRequest(request);
     const target = networkManager?.target() ?? targetManager.primaryPageTarget() ?? targetManager.rootTarget();
     let stackTrace: StackTrace.StackTrace.StackTrace|null = null;
-    const preview = new Components.JSPresentationUtils.StackTracePreviewContent(
-        undefined, target ?? undefined, linkifier, {tabStops: focusableLink});
+    const preview = new Components.JSPresentationUtils.StackTracePreviewContent();
+    preview.options = {tabStops: focusableLink};
     if (target) {
       stackTrace = await Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance()
                        .createStackTraceFromProtocolRuntime(initiator.stack, target);
@@ -219,8 +213,6 @@ export class RequestInitiatorView extends UI.Widget.VBox {
       initiatorGraph,
       stackTrace,
       request: this.request,
-      linkifier: this.linkifier,
-      target: target || undefined,
     };
 
     this.#view(viewInput, undefined, this.contentElement);

package/front_end/panels/settings/SettingsScreen.ts

@@ -60,6 +60,10 @@ const UIStrings = {
    * @description Message to display if a setting change requires a reload of DevTools
    */
   settingsChangedReloadDevTools: 'Settings changed. To apply, reload DevTools.',
+  /**
+   * @description Message to display if a setting change requires a reload of DevTools
+   */
+  settingsChangedRestartChrome: 'Settings changed. To apply, restart Chrome.',
   /**
    * @description Warning text shown when the user has entered text to filter the
    * list of experiments, but no experiments match the filter.
@@ -464,8 +468,13 @@ export class ExperimentsSettingsTab extends UI.Widget.VBox implements SettingsTa
       }
       experiment.setEnabled(checkbox.checked);
       Host.userMetrics.experimentChanged(experiment.name, experiment.isEnabled());
-      UI.InspectorView.InspectorView.instance().displayReloadRequiredWarning(
-          i18nString(UIStrings.settingsChangedReloadDevTools));
+      if (experiment instanceof Root.Runtime.HostExperiment && experiment.requiresChromeRestart) {
+        UI.InspectorView.InspectorView.instance().displayChromeRestartRequiredWarning(
+            i18nString(UIStrings.settingsChangedRestartChrome));
+      } else {
+        UI.InspectorView.InspectorView.instance().displayReloadRequiredWarning(
+            i18nString(UIStrings.settingsChangedReloadDevTools));
+      }
     }
     checkbox.addEventListener('click', listener, false);
 
@@ -628,7 +637,7 @@ const GREENDEV_VIEW: View = (input, _output, target) => {
               <span>${i18nString(UIStrings.greenDevUnstable)}</span>
              </div>
              <div class="settings-experiments-block">
-               ${renderPrototypeCheckboxes(input.settings, ['aiAnnotations', 'inDevToolsFloaty', 'copyToGemini'])}
+               ${renderPrototypeCheckboxes(input.settings, ['aiAnnotations', 'copyToGemini'])}
              </div>
            </devtools-card>
          </div>
@@ -637,7 +646,6 @@ const GREENDEV_VIEW: View = (input, _output, target) => {
 };
 
 const GREENDEV_PROTOTYPE_NAMES: Record<keyof GreenDev.GreenDevSettings, string> = {
-  inDevToolsFloaty: 'In DevTools context picker',
   aiAnnotations: 'AI auto-annotations',
   copyToGemini: 'Copy changes to AI Prompt'
 };

package/front_end/panels/snippets/SnippetsQuickOpen.ts

@@ -37,16 +37,12 @@ const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined
 let snippetsQuickOpenInstance: SnippetsQuickOpen;
 
 export class SnippetsQuickOpen extends QuickOpen.FilteredListWidget.Provider {
-  private snippets: Workspace.UISourceCode.UISourceCode[];
-  private constructor() {
-    super('snippet');
-    this.snippets = [];
-  }
+  private snippets: Workspace.UISourceCode.UISourceCode[] = [];
 
-  static instance(opts: {forceNew: boolean|null} = {forceNew: null}): SnippetsQuickOpen {
-    const {forceNew} = opts;
+  static instance(opts: {forceNew: boolean|null, jslogContext: string}): SnippetsQuickOpen {
+    const {forceNew, jslogContext} = opts;
     if (!snippetsQuickOpenInstance || forceNew) {
-      snippetsQuickOpenInstance = new SnippetsQuickOpen();
+      snippetsQuickOpenInstance = new SnippetsQuickOpen(jslogContext);
     }
 
     return snippetsQuickOpenInstance;
@@ -102,8 +98,9 @@ export class SnippetsQuickOpen extends QuickOpen.FilteredListWidget.Provider {
 QuickOpen.FilteredListWidget.registerProvider({
   prefix: '!',
   iconName: 'exclamation',
-  provider: () => Promise.resolve(SnippetsQuickOpen.instance()),
+  provider: jslogContext => Promise.resolve(SnippetsQuickOpen.instance({forceNew: null, jslogContext})),
   helpTitle: i18nLazyString(UIStrings.runSnippet),
   titlePrefix: i18nLazyString(UIStrings.run),
   titleSuggestion: i18nLazyString(UIStrings.snippet),
+  jslogContext: 'snippet'
 });

package/front_end/panels/sources/CallStackSidebarPane.ts

@@ -33,7 +33,7 @@ import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
-import * as SDK from '../../core/sdk/sdk.js';
+import type * as SDK from '../../core/sdk/sdk.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import * as Persistence from '../../models/persistence/persistence.js';
 import * as StackTrace from '../../models/stack_trace/stack_trace.js';
@@ -231,7 +231,6 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
       this.ignoreListMessageElement.classList.add('hidden');
       this.showMoreMessageElement.classList.add('hidden');
       this.items.replaceAll([]);
-      UI.Context.Context.instance().setFlavor(SDK.DebuggerModel.CallFrame, null);
       UI.Context.Context.instance().setFlavor(StackTrace.StackTrace.DebuggableFrameFlavor, null);
       return;
     }
@@ -424,7 +423,6 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
     const oldItem = this.activeCallFrameItem();
     if (debuggerCallFrame) {
       debuggerCallFrame.sdkFrame.debuggerModel.setSelectedCallFrame(debuggerCallFrame.sdkFrame);
-      UI.Context.Context.instance().setFlavor(SDK.DebuggerModel.CallFrame, debuggerCallFrame.sdkFrame);
       UI.Context.Context.instance().setFlavor(
           StackTrace.StackTrace.DebuggableFrameFlavor,
           StackTrace.StackTrace.DebuggableFrameFlavor.for(debuggerCallFrame));
@@ -440,9 +438,9 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
   }
 
   activeCallFrameItem(): Item|null {
-    const callFrame = UI.Context.Context.instance().flavor(SDK.DebuggerModel.CallFrame);
-    if (callFrame) {
-      return this.items.find(callFrameItem => callFrameItem.frame?.sdkFrame === callFrame) || null;
+    const frameFlavor = UI.Context.Context.instance().flavor(StackTrace.StackTrace.DebuggableFrameFlavor);
+    if (frameFlavor) {
+      return this.items.find(callFrameItem => callFrameItem.frame === frameFlavor.frame) || null;
     }
     return null;
   }

package/front_end/panels/sources/DebuggerPlugin.ts

@@ -1741,7 +1741,8 @@ export class DebuggerPlugin extends Plugin {
     // still running or scheduled will early return and not do any work.
     this.editor = undefined;
 
-    UI.Context.Context.instance().removeFlavorChangeListener(SDK.DebuggerModel.CallFrame, this.callFrameChanged, this);
+    UI.Context.Context.instance().removeFlavorChangeListener(
+        StackTrace.StackTrace.DebuggableFrameFlavor, this.callFrameChanged, this);
   }
 
   /**

package/front_end/panels/sources/GoToLineQuickOpen.ts

@@ -59,10 +59,6 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 export class GoToLineQuickOpen extends QuickOpen.FilteredListWidget.Provider {
   #goToLineStrings: string[] = [];
 
-  constructor() {
-    super('source-line');
-  }
-
   override selectItem(_itemIndex: number|null, promptValue: string): void {
     const sourceFrame = this.currentSourceFrame();
     if (!sourceFrame) {

package/front_end/panels/sources/OpenFileQuickOpen.ts

@@ -16,10 +16,6 @@ import {SourcesView} from './SourcesView.js';
 const {styleMap} = Directives;
 
 export class OpenFileQuickOpen extends FilteredUISourceCodeListProvider {
-  constructor() {
-    super('source-file');
-  }
-
   override attach(): void {
     this.setDefaultScores(SourcesView.defaultUISourceCodeScores());
     super.attach();

package/front_end/panels/sources/OutlineQuickOpen.ts

@@ -298,10 +298,6 @@ export class OutlineQuickOpen extends QuickOpen.FilteredListWidget.Provider {
   private items: OutlineItem[] = [];
   private active = false;
 
-  constructor() {
-    super('source-symbol');
-  }
-
   override attach(): void {
     const sourceFrame = this.currentSourceFrame();
     if (sourceFrame) {

package/front_end/panels/sources/WatchExpressionsSidebarPane.ts

@@ -41,6 +41,7 @@ import * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as Formatter from '../../models/formatter/formatter.js';
 import * as SourceMapScopes from '../../models/source_map_scopes/source_map_scopes.js';
+import * as StackTrace from '../../models/stack_trace/stack_trace.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as TextEditor from '../../ui/components/text_editor/text_editor.js';
 import * as ObjectUI from '../../ui/legacy/components/object_ui/object_ui.js';
@@ -140,7 +141,8 @@ export class WatchExpressionsSidebarPane extends UI.Widget.VBox implements
         new ObjectUI.ObjectPropertiesSection.ObjectPropertiesSectionsTreeExpandController(this.treeOutline);
 
     UI.Context.Context.instance().addFlavorChangeListener(SDK.RuntimeModel.ExecutionContext, this.requestUpdate, this);
-    UI.Context.Context.instance().addFlavorChangeListener(SDK.DebuggerModel.CallFrame, this.requestUpdate, this);
+    UI.Context.Context.instance().addFlavorChangeListener(
+        StackTrace.StackTrace.DebuggableFrameFlavor, this.requestUpdate, this);
     this.linkifier = new Components.Linkifier.Linkifier();
     this.requestUpdate();
   }

package/front_end/panels/sources/sources-meta.ts

@@ -2008,37 +2008,40 @@ UI.ContextMenu.registerItem({
 QuickOpen.FilteredListWidget.registerProvider({
   prefix: '@',
   iconName: 'symbol',
-  async provider() {
+  async provider(jslogContext: string) {
     const Sources = await loadSourcesModule();
-    return new Sources.OutlineQuickOpen.OutlineQuickOpen();
+    return new Sources.OutlineQuickOpen.OutlineQuickOpen(jslogContext);
   },
   helpTitle: i18nLazyString(UIStrings.goToSymbol),
   titlePrefix: i18nLazyString(UIStrings.goTo),
   titleSuggestion: i18nLazyString(UIStrings.symbol),
+  jslogContext: 'source-symbol'
 });
 
 QuickOpen.FilteredListWidget.registerProvider({
   prefix: ':',
   iconName: 'colon',
-  async provider() {
+  async provider(jslogContext: string) {
     const Sources = await loadSourcesModule();
-    return new Sources.GoToLineQuickOpen.GoToLineQuickOpen();
+    return new Sources.GoToLineQuickOpen.GoToLineQuickOpen(jslogContext);
   },
   helpTitle: i18nLazyString(UIStrings.goToLine),
   titlePrefix: i18nLazyString(UIStrings.goTo),
   titleSuggestion: i18nLazyString(UIStrings.line),
+  jslogContext: 'source-line',
 });
 
 QuickOpen.FilteredListWidget.registerProvider({
   prefix: '',
   iconName: 'document',
-  async provider() {
+  async provider(jslogContext: string) {
     const Sources = await loadSourcesModule();
-    return new Sources.OpenFileQuickOpen.OpenFileQuickOpen();
+    return new Sources.OpenFileQuickOpen.OpenFileQuickOpen(jslogContext);
   },
   helpTitle: i18nLazyString(UIStrings.openFile),
   titlePrefix: i18nLazyString(UIStrings.open),
   titleSuggestion: i18nLazyString(UIStrings.file),
+  jslogContext: 'source-file',
 });
 
 UI.ContextMenu.registerProvider({

package/front_end/panels/timeline/TimelineFlameChartView.ts

@@ -1708,18 +1708,6 @@ export class TimelineFlameChartView extends Common.ObjectWrapper.eventMixin<Even
   #onEntryInvoked(
       dataProvider: TimelineFlameChartDataProvider|TimelineFlameChartNetworkDataProvider,
       event: Common.EventTarget.EventTargetEvent<number>): void {
-    const selectedEvent = dataProvider.eventByIndex(event.data);
-    if (this.#parsedTrace && selectedEvent) {
-      const handledByFloaty = UI.Floaty.onFloatyClick({
-        type: UI.Floaty.FloatyContextTypes.PERFORMANCE_EVENT,
-        data: {event: selectedEvent, traceStartTime: this.#parsedTrace.data.Meta.traceBounds.min}
-      });
-      if (handledByFloaty) {
-        // If this was added to the Floaty context, we do not need to actually
-        // select the event.
-        return;
-      }
-    }
     this.#updateSelectedEntryStatus(dataProvider, event);
 
     const entryIndex = event.data;