chrome-devtools-frontend 1.0.1582745 → 1.0.1583146

package/front_end/panels/network/network-meta.ts

@@ -23,18 +23,10 @@ const UIStrings = {
    * @description Title of the Network tool
    */
   network: 'Network',
-  /**
-   * @description Command for showing the 'Network request blocking' tool
-   */
-  showNetworkRequestBlocking: 'Show Network request blocking',
   /**
    * @description Command for showing the 'Network request blocking' tool
    */
   showRequestConditions: 'Show Request conditions',
-  /**
-   * @description Title of the 'Network request blocking' tool in the bottom drawer
-   */
-  networkRequestBlocking: 'Network request blocking',
   /**
    * @description Title of the 'Request conditions' tool in the bottom drawer
    */
@@ -123,14 +115,6 @@ const UIStrings = {
    * @description Title of a button for clearing the network log
    */
   clear: 'Clear network log',
-  /**
-   * @description Title of an action in the Network request blocking panel to add a new URL pattern to the blocklist.
-   */
-  addNetworkRequestBlockingPattern: 'Add network request blocking pattern',
-  /**
-   * @description Title of an action in the Network request blocking panel to clear all URL patterns.
-   */
-  removeAllNetworkRequestBlockingPatterns: 'Remove all network request blocking patterns',
   /**
    * @description Title of an action in the Network request blocking panel to add a new URL pattern to the blocklist.
    */
@@ -190,15 +174,11 @@ UI.ViewManager.registerViewExtension({
   },
 });
 
-const individualThrottlingEnabled = (): boolean =>
-    Boolean(Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled);
 UI.ViewManager.registerViewExtension({
   location: UI.ViewManager.ViewLocationValues.DRAWER_VIEW,
   id: 'network.blocked-urls',
-  commandPrompt: () => individualThrottlingEnabled() ? i18nString(UIStrings.showRequestConditions) :
-                                                       i18nString(UIStrings.showNetworkRequestBlocking),
-  title: () => individualThrottlingEnabled() ? i18nString(UIStrings.networkRequestConditions) :
-                                               i18nString(UIStrings.networkRequestBlocking),
+  commandPrompt: () => i18nString(UIStrings.showRequestConditions),
+  title: () => i18nString(UIStrings.networkRequestConditions),
   persistence: UI.ViewManager.ViewPersistence.CLOSEABLE,
   order: 60,
   async loadView() {
@@ -350,8 +330,7 @@ UI.ActionRegistration.registerActionExtension({
 UI.ActionRegistration.registerActionExtension({
   actionId: 'network.add-network-request-blocking-pattern',
   category: UI.ActionRegistration.ActionCategory.NETWORK,
-  title: () => individualThrottlingEnabled() ? i18nString(UIStrings.addNetworkRequestBlockingOrThrottlingPattern) :
-                                               i18nString(UIStrings.addNetworkRequestBlockingPattern),
+  title: () => i18nString(UIStrings.addNetworkRequestBlockingOrThrottlingPattern),
   iconClass: UI.ActionRegistration.IconClass.PLUS,
   contextTypes() {
     return maybeRetrieveContextTypes(Network => [Network.RequestConditionsDrawer.RequestConditionsDrawer]);
@@ -365,9 +344,7 @@ UI.ActionRegistration.registerActionExtension({
 UI.ActionRegistration.registerActionExtension({
   actionId: 'network.remove-all-network-request-blocking-patterns',
   category: UI.ActionRegistration.ActionCategory.NETWORK,
-  title: () => individualThrottlingEnabled() ?
-      i18nString(UIStrings.removeAllNetworkRequestBlockingOrThrottlingPatterns) :
-      i18nString(UIStrings.removeAllNetworkRequestBlockingPatterns),
+  title: () => i18nString(UIStrings.removeAllNetworkRequestBlockingOrThrottlingPatterns),
   iconClass: UI.ActionRegistration.IconClass.CLEAR,
   contextTypes() {
     return maybeRetrieveContextTypes(Network => [Network.RequestConditionsDrawer.RequestConditionsDrawer]);

package/front_end/panels/settings/WorkspaceSettingsTab.ts

@@ -61,7 +61,7 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
             <input
               class="harmony-input"
               jslog=${VisualLogging.textField().track({keydown: 'Enter', change: true}).context(input.excludePatternSetting.name)}
-              ${UI.UIUtils.bindToSetting(input.excludePatternSetting)}
+              ${UI.UIUtils.bindToSetting(input.excludePatternSetting, {jslog: false})}
               id="workspace-setting-folder-exclude-pattern"></input>
           </div>
           <div class="mappings-info">${i18nString(UIStrings.mappingsAreInferredAutomatically)}</div>

package/front_end/panels/sources/CallStackSidebarPane.ts

@@ -428,14 +428,14 @@ export class CallStackSidebarPane extends UI.View.SimpleView implements UI.Conte
       UI.Context.Context.instance().setFlavor(
           StackTrace.StackTrace.DebuggableFrameFlavor,
           StackTrace.StackTrace.DebuggableFrameFlavor.for(debuggerCallFrame));
+    } else {
+      void Common.Revealer.reveal(uiLocation);
     }
     if (oldItem !== item) {
       if (oldItem) {
         this.refreshItem(oldItem);
       }
       this.refreshItem(item);
-    } else {
-      void Common.Revealer.reveal(uiLocation);
     }
   }
 

package/front_end/ui/components/text_editor/AiCodeCompletionProvider.ts

@@ -18,6 +18,7 @@ import {
   acceptAiAutoCompleteSuggestion,
   aiAutoCompleteSuggestion,
   aiAutoCompleteSuggestionState,
+  AiSuggestionSource,
   hasActiveAiSuggestion,
   setAiAutoCompleteSuggestion,
   showCompletionHint,
@@ -201,6 +202,12 @@ export class AiCodeCompletionProvider {
           if (!this.#aiCodeCompletion || !this.#editor || !hasActiveAiSuggestion(this.#editor.state)) {
             return false;
           }
+          if (this.#editor.state.field(aiAutoCompleteSuggestionState)?.source === AiSuggestionSource.GENERATION) {
+            // If the suggestion is from code generation, we don't want to
+            // dismiss it here. The user should use the code generation
+            // provider's keymap to dismiss the suggestion.
+            return false;
+          }
           this.#editor.dispatch({
             effects: setAiAutoCompleteSuggestion.of(null),
           });
@@ -347,6 +354,7 @@ export class AiCodeCompletionProvider {
               startTime,
               clearCachedRequest: this.clearCache.bind(this),
               onImpression: this.#aiCodeCompletion?.registerUserImpression.bind(this.#aiCodeCompletion),
+              source: AiSuggestionSource.COMPLETION,
             })
           });
         }

package/front_end/ui/components/text_editor/AiCodeGenerationProvider.ts

@@ -19,6 +19,7 @@ import {
   acceptAiAutoCompleteSuggestion,
   aiAutoCompleteSuggestion,
   aiAutoCompleteSuggestionState,
+  AiSuggestionSource,
   hasActiveAiSuggestion,
   setAiAutoCompleteSuggestion,
 } from './config.js';
@@ -159,6 +160,12 @@ export class AiCodeGenerationProvider {
             return false;
           }
           if (hasActiveAiSuggestion(this.#editor.state)) {
+            if (this.#editor.state.field(aiAutoCompleteSuggestionState)?.source === AiSuggestionSource.COMPLETION) {
+              // If the suggestion is from code completion, we don't want to
+              // dismiss it here. The user should use the code completion
+              // provider's keymap to dismiss the suggestion.
+              return false;
+            }
             this.#dismissTeaserAndSuggestion();
             return true;
           }
@@ -341,6 +348,7 @@ export class AiCodeGenerationProvider {
             sampleId: topSample.sampleId,
             startTime,
             onImpression: this.#aiCodeGeneration?.registerUserImpression.bind(this.#aiCodeGeneration),
+            source: AiSuggestionSource.GENERATION,
           }),
           setAiCodeGenerationTeaserMode.of(AiCodeGenerationTeaserMode.ACTIVE)
         ]

package/front_end/ui/components/text_editor/config.ts

@@ -483,6 +483,11 @@ export function contentIncludingHint(view: CM.EditorView): string {
 
 export const setAiAutoCompleteSuggestion = CM.StateEffect.define<ActiveSuggestion|null>();
 
+export const enum AiSuggestionSource {
+  COMPLETION = 'completion',
+  GENERATION = 'generation',
+}
+
 export interface ActiveSuggestion {
   text: string;
   from: number;
@@ -491,6 +496,7 @@ export interface ActiveSuggestion {
   startTime: number;
   onImpression: (rpcGlobalId: Host.AidaClient.RpcGlobalId, latency: number, sampleId?: number) => void;
   clearCachedRequest?: () => void;
+  source: AiSuggestionSource;
 }
 
 export const aiAutoCompleteSuggestionState = CM.StateField.define<ActiveSuggestion|null>({

package/front_end/ui/legacy/Toolbar.ts

@@ -835,7 +835,7 @@ export class ToolbarInputElement extends HTMLElement {
 
   item?: ToolbarInput;
   datalist: HTMLDataListElement|null = null;
-  value: string|undefined = undefined;
+  #value: string|undefined = undefined;
   #disabled = false;
 
   connectedCallback(): void {
@@ -862,8 +862,8 @@ export class ToolbarInputElement extends HTMLElement {
           /* shrinkFactor=*/ undefined, tooltip, this.datalist ? this.#onAutocomplete.bind(this) : undefined,
           /* dynamicCompletions=*/ undefined, jslogContext, this);
     }
-    if (this.value) {
-      this.item.setValue(this.value);
+    if (this.#value) {
+      this.item.setValue(this.#value);
     }
     if (this.#disabled) {
       this.item.setEnabled(false);
@@ -894,7 +894,7 @@ export class ToolbarInputElement extends HTMLElement {
       if (this.item && this.item.value() !== newValue) {
         this.item.setValue(newValue, true);
       } else {
-        this.value = newValue;
+        this.#value = newValue;
       }
     } else if (name === 'disabled') {
       this.#disabled = typeof newValue === 'string';
@@ -904,6 +904,14 @@ export class ToolbarInputElement extends HTMLElement {
     }
   }
 
+  get value(): string {
+    return this.item ? this.item.value() : (this.#value ?? '');
+  }
+
+  set value(value: string) {
+    this.setAttribute('value', value);
+  }
+
   set disabled(disabled: boolean) {
     if (disabled) {
       this.setAttribute('disabled', '');

package/front_end/ui/legacy/UIUtils.ts

@@ -2193,13 +2193,29 @@ export const bindCheckboxImpl = function(
   };
 };
 
+export type BindToSettingOpts = ((newSettingValue: string) => boolean)|{
+  validator?: (newSettingValue: string) => boolean,
+  jslog?: boolean,
+};
 export const bindToSetting =
     (settingOrName: string|Common.Settings.Setting<boolean|string>|Common.Settings.RegExpSetting,
-     stringValidator?: (newSettingValue: string) => boolean): ReturnType<typeof Directives.ref> => {
+     optionsOrValidator?: BindToSettingOpts): ReturnType<typeof Directives.ref> => {
       const setting = typeof settingOrName === 'string' ?
           Common.Settings.Settings.instance().moduleSetting(settingOrName) :
           settingOrName;
 
+      let stringValidator: ((newSettingValue: string) => boolean)|undefined;
+      let jslog = true;
+      if (typeof optionsOrValidator === 'function') {
+        stringValidator = optionsOrValidator;
+      } else if (optionsOrValidator) {
+        stringValidator = optionsOrValidator.validator;
+        if (optionsOrValidator.jslog !== undefined) {
+          jslog = optionsOrValidator.jslog;
+        }
+      }
+
+      const jslogBuilder = jslog ? VisualLogging.toggle(setting.name).track({change: true}) : null;
       // We can't use `setValue` as the change listener directly, otherwise we won't
       // be able to remove it again.
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -2214,6 +2230,9 @@ export const bindToSetting =
             setting.removeChangeListener(settingChanged);
             return;
           }
+          if (jslogBuilder) {
+            e.setAttribute('jslog', jslogBuilder.toString());
+          }
 
           setting.addChangeListener(settingChanged);
           setValue =
@@ -2229,6 +2248,9 @@ export const bindToSetting =
             return;
           }
 
+          if (jslogBuilder) {
+            e.setAttribute('jslog', jslogBuilder.toString());
+          }
           setting.addChangeListener(settingChanged);
           setValue = bindInput(e as HTMLInputElement, setting.set.bind(setting), (value: string) => {
             try {
@@ -2249,6 +2271,9 @@ export const bindToSetting =
             return;
           }
 
+          if (jslogBuilder) {
+            e.setAttribute('jslog', jslogBuilder.toString());
+          }
           setting.addChangeListener(settingChanged);
           setValue = bindInput(
               e as HTMLInputElement, setting.set.bind(setting), stringValidator ?? (() => true), /* numeric */ false);

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -1271,6 +1271,7 @@ export const knownContextValues = new Set([
   'device-bound-sessions-empty',
   'device-bound-sessions-preserve-log',
   'device-bound-sessions-request',
+  'device-bound-sessions-root',
   'device-fold',
   'device-frame-enable',
   'device-mode',

package/package.json

@@ -105,5 +105,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1582745"
+  "version": "1.0.1583146"
 }

package/front_end/panels/elements/computedStyleSidebarPane.css

@@ -1,18 +0,0 @@
-/*
- * Copyright 2015 The Chromium Authors
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-.styles-sidebar-pane-toolbar {
-  border-bottom: 1px solid var(--sys-color-divider);
-  flex-shrink: 0;
-}
-
-.styles-sidebar-computed-style-widget {
-  min-height: auto;
-}
-
-.styles-pane-toolbar {
-  width: 100%;
-}