chrome-devtools-frontend 1.0.1581708 → 1.0.1582745

package/front_end/panels/timeline/TimelineUIUtils.ts

@@ -2502,24 +2502,21 @@ export class TimelineDetailsContentHelper {
       return null;
     }
 
-    let callFrameContents;
-    if (this.target) {
-      const stackTrace = await Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance()
-                             .createStackTraceFromProtocolRuntime(runtimeStackTrace, this.target);
-      callFrameContents = new LegacyComponents.JSPresentationUtils.StackTracePreviewContent(
-          undefined, this.target ?? undefined, this.#linkifier, {tabStops: true, showColumnNumber: true});
-      callFrameContents.stackTrace = stackTrace;
-    } else {
-      // I _think_ this only happens during tests.
-      // See "TimelineFlameChartView > shows the details for a selected main thread event".
-      // For now, just defer to the still-supported legacy runtime stack trace. When
-      // that is removed, we could instead create a stub StackTrace ourselves, even
-      // without a `target`.
-      callFrameContents = new LegacyComponents.JSPresentationUtils.StackTracePreviewContent(
-          undefined, this.target ?? undefined, this.#linkifier,
-          {runtimeStackTrace, tabStops: true, showColumnNumber: true});
+    // Fallback to the main page/root target. Maybe the main page has a source map we need.
+    // Worst case the stack is identity mapped.
+    const targetManager = SDK.TargetManager.TargetManager.instance();
+    const target = this.target ?? targetManager.primaryPageTarget() ?? targetManager.rootTarget();
+    if (!target) {
+      return null;
     }
 
+    const stackTrace =
+        await Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance().createStackTraceFromProtocolRuntime(
+            runtimeStackTrace, target);
+    const callFrameContents = new LegacyComponents.JSPresentationUtils.StackTracePreviewContent(
+        undefined, target, this.#linkifier, {tabStops: true, showColumnNumber: true});
+    callFrameContents.stackTrace = stackTrace;
+
     await callFrameContents.updateComplete;
     if (!callFrameContents.hasContent()) {
       return null;

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: https://chromium.googlesource.com/chromium/src
 Version: N/A
-Revision: eb058eb950a74d8f8ffe880684c8a41a4cea87f2
+Revision: 294287c423bbeff3981714f04e193960f503e773
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -58,9 +58,12 @@ export const markdownLinks = new Map<string, string>([
   ['signatureHeader', 'https://www.rfc-editor.org/rfc/rfc9421.html#name-the-signature-http-field'],
   ['signatureInputHeader', 'https://www.rfc-editor.org/rfc/rfc9421.html#name-the-signature-input-http-fi'],
   ['signatureParameters', 'https://www.rfc-editor.org/rfc/rfc9421.html#name-signature-parameters'],
-  ['sfDictionary', 'https://www.rfc-editor.org/rfc/rfc8941.html#name-dictionaries'],
   ['sfByteSequence', 'https://www.rfc-editor.org/rfc/rfc8941.html#name-byte-sequences'],
+  ['sfDictionary', 'https://www.rfc-editor.org/rfc/rfc8941.html#name-dictionaries'],
   ['sfInnerList', 'https://www.rfc-editor.org/rfc/rfc8941.html#name-inner-lists'],
+  ['sfList', 'https://www.rfc-editor.org/rfc/rfc8941.html#name-lists'],
+  ['sfString', 'https://www.rfc-editor.org/rfc/rfc8941.html#name-strings'],
+  ['sfToken', 'https://www.rfc-editor.org/rfc/rfc8941.html#name-tokens'],
   ['componentParameterSf', 'https://www.rfc-editor.org/rfc/rfc9421.html#name-strict-serialization-of-htt'],
   ['componentParameterReq', 'https://www.rfc-editor.org/rfc/rfc9421.html#content-request-response'],
   [
@@ -74,6 +77,7 @@ export const markdownLinks = new Map<string, string>([
     'https://privacysandbox.com/news/update-on-plans-for-privacy-sandbox-technologies/',
     'https://privacysandbox.com/news/update-on-plans-for-privacy-sandbox-technologies/'
   ],
+  ['urlPatternSpec', 'https://urlpattern.spec.whatwg.org/'],
 ]);
 
 export const getMarkdownLink = (key: string): string => {

package/front_end/ui/legacy/Toolbar.ts

@@ -1321,11 +1321,11 @@ export class ToolbarCheckbox extends ToolbarItem<void> {
   constructor(
       text: Common.UIString.LocalizedString, tooltip?: Common.UIString.LocalizedString,
       listener?: ((arg0: MouseEvent) => void), jslogContext?: string) {
-    const checkboxLabel = CheckboxLabel.create(text, undefined, undefined, jslogContext);
+    // Pass tooltip to CheckboxLabel.create so it's set on the inner input/text elements,
+    // rather than installing it on the wrapper element which causes screen readers to
+    // incorrectly announce it as a group name.
+    const checkboxLabel = CheckboxLabel.create(text, undefined, undefined, jslogContext, undefined, tooltip);
     super(checkboxLabel);
-    if (tooltip) {
-      Tooltip.install(this.element, tooltip);
-    }
     if (listener) {
       this.element.addEventListener('click', listener, false);
     }

package/front_end/ui/legacy/Treeoutline.ts

@@ -1704,7 +1704,7 @@ export class TreeViewElement extends HTMLElementWithLightDOMTemplate {
     super();
     this.#treeOutline.addEventListener(Events.ElementSelected, event => {
       if (event.data instanceof TreeViewTreeElement) {
-        this.dispatchEvent(new TreeViewElement.SelectEvent(event.data.configElement));
+        event.data.listItemElement.dispatchEvent(new TreeViewElement.SelectEvent());
       }
     });
     this.#treeOutline.addEventListener(Events.ElementExpanded, event => {
@@ -1859,9 +1859,9 @@ export class TreeViewElement extends HTMLElementWithLightDOMTemplate {
 }
 
 export namespace TreeViewElement {
-  export class SelectEvent extends CustomEvent<HTMLLIElement> {
-    constructor(detail: HTMLLIElement) {
-      super('select', {detail});
+  export class SelectEvent extends CustomEvent<void> {
+    constructor() {
+      super('select');
     }
   }
 

package/front_end/ui/legacy/UIUtils.ts

@@ -1173,7 +1173,7 @@ export class CheckboxLabel extends HTMLElement {
 
   static create(
       title?: Platform.UIString.LocalizedString, checked?: boolean, subtitle?: Platform.UIString.LocalizedString,
-      jslogContext?: string, small?: boolean): CheckboxLabel {
+      jslogContext?: string, small?: boolean, tooltip?: Platform.UIString.LocalizedString): CheckboxLabel {
     const element = document.createElement('devtools-checkbox');
     element.#checkboxElement.checked = Boolean(checked);
     if (jslogContext) {
@@ -1182,11 +1182,17 @@ export class CheckboxLabel extends HTMLElement {
     }
     if (title !== undefined) {
       element.#textElement.textContent = title;
-      element.#checkboxElement.title = title;
       if (subtitle !== undefined) {
         element.#textElement.createChild('div', 'devtools-checkbox-subtitle').textContent = subtitle;
       }
     }
+    // checkboxElement tooltip: tooltip first, then title (custom tooltip takes precedence for the input)
+    const inputTooltip = tooltip ?? title;
+    if (inputTooltip) {
+      element.#checkboxElement.title = inputTooltip;
+      // Set aria-description for screen reader announcement
+      element.#checkboxElement.setAttribute('aria-description', inputTooltip);
+    }
     element.#checkboxElement.classList.toggle('small', small);
     return element;
   }
@@ -2069,7 +2075,7 @@ export class HTMLElementWithLightDOMTemplate extends HTMLElement {
         HTMLElementWithLightDOMTemplate.patchLitTemplate(value);
         return value;
       }
-      if (Array.isArray(value)) {
+      if (Array.isArray(value) || value instanceof Iterator) {
         return value.map(patchValue);
       }
 

package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts

@@ -96,7 +96,7 @@ function populateContextMenu(link: Element, event: Event): void {
 }
 
 // TODO(crbug.com/456517732): remove when all usages of runtimeStackTrace are migrated.
-export function buildStackTraceRowsForLegacyRuntimeStackTrace(
+function buildStackTraceRowsForLegacyRuntimeStackTrace(
     stackTrace: Protocol.Runtime.StackTrace,
     target: SDK.Target.Target|null,
     linkifier: Linkifier,
@@ -159,7 +159,7 @@ export function buildStackTraceRowsForLegacyRuntimeStackTrace(
   return stackTraceRows;
 }
 
-export function buildStackTraceRows(
+function buildStackTraceRows(
     stackTrace: StackTrace.StackTrace.StackTrace,
     target: SDK.Target.Target|null,
     linkifier: Linkifier,
@@ -189,14 +189,9 @@ export function buildStackTraceRows(
         inlineFrameIndex: 0,
         revealBreakpoint: previousStackFrameWasBreakpointCondition,
       });
-      if (link) {
-        link.setAttribute('jslog', `${VisualLogging.link('stack-trace').track({click: true})}`);
-        link.addEventListener('contextmenu', populateContextMenu.bind(null, link));
+      link.setAttribute('jslog', `${VisualLogging.link('stack-trace').track({click: true})}`);
+      link.addEventListener('contextmenu', populateContextMenu.bind(null, link));
 
-        if (!link.textContent) {
-          link.textContent = i18nString(UIStrings.unknownSource);
-        }
-      }
       stackTraceRows.push({functionName, link});
       previousStackFrameWasBreakpointCondition = [
         SDK.DebuggerModel.COND_BREAKPOINT_SOURCE_URL,
@@ -306,12 +301,12 @@ export interface Options {
   expandable?: boolean;
 }
 
-export interface StackTraceRegularRow {
+interface StackTraceRegularRow {
   functionName: string;
   link: HTMLElement|null;
 }
 
-export interface StackTraceAsyncRow {
+interface StackTraceAsyncRow {
   asyncDescription: string;
 }
 

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -345,8 +345,7 @@ export class Linkifier extends Common.ObjectWrapper.ObjectWrapper<EventTypes> im
   }
 
   maybeLinkifyStackTraceFrame(
-      target: SDK.Target.Target|null, frame: StackTrace.StackTrace.Frame, options?: LinkifyOptions): HTMLElement|null {
-    let fallbackAnchor: HTMLElement|null = null;
+      target: SDK.Target.Target|null, frame: StackTrace.StackTrace.Frame, options?: LinkifyOptions): HTMLElement {
     const linkifyURLOptions: LinkifyURLOptions = {
       ...options,
       lineNumber: frame.line,
@@ -361,10 +360,8 @@ export class Linkifier extends Common.ObjectWrapper.ObjectWrapper<EventTypes> im
       omitOrigin: options?.omitOrigin,
     };
     const {className = ''} = linkifyURLOptions;
-    if (frame.url) {
-      fallbackAnchor = Linkifier.linkifyURL(frame.url as Platform.DevToolsPath.UrlString, linkifyURLOptions);
-    }
-    if (!target || target.isDisposed()) {
+    const fallbackAnchor = Linkifier.linkifyURL(frame.url as Platform.DevToolsPath.UrlString, linkifyURLOptions);
+    if (!target || target.isDisposed() || !frame.uiSourceCode) {
       return fallbackAnchor;
     }
 
@@ -383,7 +380,7 @@ export class Linkifier extends Common.ObjectWrapper.ObjectWrapper<EventTypes> im
       revealBreakpoint: options?.revealBreakpoint,
     };
 
-    const uiLocation = frame.uiSourceCode?.uiLocation(frame.line, frame.column) ?? null;
+    const uiLocation = frame.uiSourceCode.uiLocation(frame.line, frame.column) ?? null;
     this.updateAnchorFromUILocation(link, linkDisplayOptions, uiLocation);
 
     const anchors = (this.anchorsByTarget.get(target) as Element[]);

package/package.json

@@ -105,5 +105,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1581708"
+  "version": "1.0.1582745"
 }

package/front_end/models/issues_manager/descriptions/federatedAuthRequestClientMetadataHttpNotFound.md

@@ -1 +0,0 @@
-# The provider's client metadata endpoint cannot be found.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestClientMetadataInvalidResponse.md

@@ -1 +0,0 @@
-# Provider's client metadata is invalid.

package/front_end/models/issues_manager/descriptions/federatedAuthRequestClientMetadataNoResponse.md

@@ -1 +0,0 @@
-# The response body is empty when fetching the provider's client metadata.