chrome-devtools-frontend 1.0.1581449 → 1.0.1582745

package/front_end/panels/settings/SettingsScreen.ts

@@ -631,16 +631,6 @@ const GREENDEV_VIEW: View = (input, _output, target) => {
                ${renderPrototypeCheckboxes(input.settings, ['aiAnnotations', 'inDevToolsFloaty', 'copyToGemini'])}
              </div>
            </devtools-card>
-
-           <devtools-card .heading=${'GreenDev widgets'}>
-             <div class="experiments-warning-subsection">
-              <devtools-icon .name=${'warning'}></devtools-icon>
-              <span>${i18nString(UIStrings.greenDevUnstable)}</span>
-             </div>
-             <div class="settings-experiments-block greendev-widgets">
-               ${renderWidgetOptions(input.settings)}
-             </div>
-           </devtools-card>
          </div>
        `, target);
   // clang-format on
@@ -649,50 +639,9 @@ const GREENDEV_VIEW: View = (input, _output, target) => {
 const GREENDEV_PROTOTYPE_NAMES: Record<keyof GreenDev.GreenDevSettings, string> = {
   inDevToolsFloaty: 'In DevTools context picker',
   aiAnnotations: 'AI auto-annotations',
-  inlineWidgets: 'Inline widgets in AI Assistance',
-  artifactViewer: 'Widgets in the Artifact viewer',
   copyToGemini: 'Copy changes to AI Prompt'
 };
 
-function renderWidgetOptions(settings: GreenDev.GreenDevSettings): TemplateResult {
-  function onChange(nowActiveRadio: 'inlineWidgets'|'artifactViewer'|'none') {
-    return () => {
-      switch (nowActiveRadio) {
-        case 'inlineWidgets': {
-          settings.artifactViewer.set(false);
-          settings.inlineWidgets.set(true);
-          break;
-        }
-        case 'artifactViewer': {
-          settings.artifactViewer.set(true);
-          settings.inlineWidgets.set(false);
-          break;
-        }
-        case 'none': {
-          settings.artifactViewer.set(false);
-          settings.inlineWidgets.set(false);
-        }
-      }
-
-      UI.InspectorView.InspectorView.instance().displayReloadRequiredWarning(
-          i18nString(UIStrings.settingsChangedReloadDevTools));
-    };
-  }
-  // clang-format off
-  return html`
-    <p class="settings-experiment">
-      <label><input type="radio" name="widgets-choice" @change=${onChange('inlineWidgets')}>${GREENDEV_PROTOTYPE_NAMES['inlineWidgets']}</label>
-    </p>
-    <p class="settings-experiment">
-      <label><input type="radio" name="widgets-choice" @change=${onChange('artifactViewer')}>${GREENDEV_PROTOTYPE_NAMES['artifactViewer']}</label>
-    </p>
-    <p class="settings-experiment">
-      <label><input type="radio" name="widgets-choice" @change=${onChange('none')}>None</label>
-    </p>
-  `;
-  // clang-format on
-}
-
 function renderPrototypeCheckboxes(
     settings: GreenDev.GreenDevSettings,
     keys: Array<keyof GreenDev.GreenDevSettings>,

package/front_end/panels/sources/OutlineQuickOpen.ts

@@ -179,6 +179,25 @@ export function outline(state: CodeMirror.EditorState): OutlineItem[] {
             ])) {
           let title = state.sliceDoc(cursor.from, cursor.to);
           const {lineNumber, columnNumber} = toLineColumn(cursor.from);
+          let hasEquals = false;
+          let node: CodeMirror.SyntaxNode|null = cursor.node;
+          while (node && node.name !== 'AssignmentExpression' && node.name !== 'VariableDeclaration') {
+            let sibling = node.nextSibling;
+            while (sibling) {
+              if (sibling.name === 'Equals') {
+                hasEquals = true;
+                break;
+              }
+              sibling = sibling.nextSibling;
+            }
+            if (hasEquals) {
+              break;
+            }
+            node = node.parent;
+          }
+          if (!hasEquals) {
+            break;
+          }
           while (cursor.name as string !== 'Equals') {
             if (!cursor.next()) {
               return items;

package/front_end/panels/timeline/AnimationsTrackAppender.ts

@@ -48,7 +48,10 @@ export class AnimationsTrackAppender implements TrackAppender {
   }
 
   #appendTrackHeaderAtLevel(currentLevel: number, expanded?: boolean): void {
-    const style = buildGroupStyle({useFirstLineForOverview: false});
+    const style = buildGroupStyle({
+      useFirstLineForOverview: false,
+      collapsible: PerfUI.FlameChart.GroupCollapsibleState.IF_MULTI_ROW,
+    });
     const group = buildTrackHeader(
         VisualLoggingTrackName.ANIMATIONS, currentLevel, i18nString(UIStrings.animations), style,
         /* selectable= */ true, expanded);

package/front_end/panels/timeline/InteractionsTrackAppender.ts

@@ -71,7 +71,7 @@ export class InteractionsTrackAppender implements TrackAppender {
   #appendTrackHeaderAtLevel(currentLevel: number, expanded?: boolean): void {
     const trackIsCollapsible = this.#parsedTrace.data.UserInteractions.interactionEvents.length > 0;
     const style = buildGroupStyle({
-      collapsible: trackIsCollapsible ? PerfUI.FlameChart.GroupCollapsibleState.ALWAYS :
+      collapsible: trackIsCollapsible ? PerfUI.FlameChart.GroupCollapsibleState.IF_MULTI_ROW :
                                         PerfUI.FlameChart.GroupCollapsibleState.NEVER,
       useDecoratorsForOverview: true,
     });

package/front_end/panels/timeline/TimelinePanel.ts

@@ -3041,6 +3041,31 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
     this.#setActiveInsight({model: insightModel, insightSetKey}, {highlightInsight: true});
   }
 
+  static async executeRecordAndReload(): Promise<Trace.TraceModel.ParsedTrace> {
+    await UI.ViewManager.ViewManager.instance().showView('timeline');
+    const panelInstance = TimelinePanel.instance();
+
+    const result: EventTypes[Events.RECORDING_COMPLETED] = await new Promise(resolve => {
+      function listener(e: Common.EventTarget.EventTargetEvent<EventTypes[Events.RECORDING_COMPLETED]>): void {
+        resolve(e.data);
+        panelInstance.removeEventListener(Events.RECORDING_COMPLETED, listener);
+      }
+      panelInstance.addEventListener(Events.RECORDING_COMPLETED, listener);
+      panelInstance.recordReload();
+    });
+
+    if ('errorText' in result) {
+      throw new Error(result.errorText);
+    }
+
+    const trace = panelInstance.model.parsedTrace(result.traceIndex);
+    if (!trace) {
+      throw new Error('Failed to parse trace');
+    }
+
+    return trace;
+  }
+
   static async *
       handleExternalRecordRequest(): AsyncGenerator<
           AiAssistanceModel.AiAgent.ExternalRequestResponse, AiAssistanceModel.AiAgent.ExternalRequestResponse> {

package/front_end/panels/timeline/TimelineUIUtils.ts

@@ -2502,24 +2502,21 @@ export class TimelineDetailsContentHelper {
       return null;
     }
 
-    let callFrameContents;
-    if (this.target) {
-      const stackTrace = await Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance()
-                             .createStackTraceFromProtocolRuntime(runtimeStackTrace, this.target);
-      callFrameContents = new LegacyComponents.JSPresentationUtils.StackTracePreviewContent(
-          undefined, this.target ?? undefined, this.#linkifier, {tabStops: true, showColumnNumber: true});
-      callFrameContents.stackTrace = stackTrace;
-    } else {
-      // I _think_ this only happens during tests.
-      // See "TimelineFlameChartView > shows the details for a selected main thread event".
-      // For now, just defer to the still-supported legacy runtime stack trace. When
-      // that is removed, we could instead create a stub StackTrace ourselves, even
-      // without a `target`.
-      callFrameContents = new LegacyComponents.JSPresentationUtils.StackTracePreviewContent(
-          undefined, this.target ?? undefined, this.#linkifier,
-          {runtimeStackTrace, tabStops: true, showColumnNumber: true});
+    // Fallback to the main page/root target. Maybe the main page has a source map we need.
+    // Worst case the stack is identity mapped.
+    const targetManager = SDK.TargetManager.TargetManager.instance();
+    const target = this.target ?? targetManager.primaryPageTarget() ?? targetManager.rootTarget();
+    if (!target) {
+      return null;
     }
 
+    const stackTrace =
+        await Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance().createStackTraceFromProtocolRuntime(
+            runtimeStackTrace, target);
+    const callFrameContents = new LegacyComponents.JSPresentationUtils.StackTracePreviewContent(
+        undefined, target, this.#linkifier, {tabStops: true, showColumnNumber: true});
+    callFrameContents.stackTrace = stackTrace;
+
     await callFrameContents.updateComplete;
     if (!callFrameContents.hasContent()) {
       return null;

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: https://chromium.googlesource.com/chromium/src
 Version: N/A
-Revision: eb058eb950a74d8f8ffe880684c8a41a4cea87f2
+Revision: 294287c423bbeff3981714f04e193960f503e773
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/third_party/lighthouse/README.chromium

@@ -1,7 +1,7 @@
 Name: Lighthouse
 Short Name: lighthouse
-Version: 13.0.1
-Revision: 6ca156ba2950a5220f9f2c8468eee88842eff39a
+Version: 13.0.2
+Revision: 440f8bf87117ef61dc970c3ce4cebf91d46eb181
 Update Mechanism: Manual
 URL: https://github.com/GoogleChrome/lighthouse
 License: Apache-2.0