chrome-devtools-frontend 1.0.1575635 → 1.0.1576915

package/front_end/core/host/AidaClient.ts

@@ -656,6 +656,13 @@ export class AidaClient {
   }
 
   registerClientEvent(clientEvent: AidaRegisterClientEvent): Promise<AidaClientResult> {
+    // Disable logging for now.
+    // For context, see b/454563259#comment35.
+    // We should be able to remove this ~end of April.
+    if (Root.Runtime.hostConfig.devToolsGeminiRebranding?.enabled) {
+      clientEvent.disable_user_content_logging = true;
+    }
+
     const {promise, resolve} = Promise.withResolvers<AidaClientResult>();
     InspectorFrontendHostInstance.registerAidaClientEvent(
         JSON.stringify({
@@ -673,6 +680,14 @@ export class AidaClient {
     if (!InspectorFrontendHostInstance.aidaCodeComplete) {
       throw new Error('aidaCodeComplete is not available');
     }
+
+    // Disable logging for now.
+    // For context, see b/454563259#comment35.
+    // We should be able to remove this ~end of April.
+    if (Root.Runtime.hostConfig.devToolsGeminiRebranding?.enabled) {
+      request.metadata.disable_user_content_logging = true;
+    }
+
     const {promise, resolve} = Promise.withResolvers<AidaCodeCompleteResult>();
     InspectorFrontendHostInstance.aidaCodeComplete(JSON.stringify(request), resolve);
     const completeCodeResult = await promise;
@@ -718,6 +733,12 @@ export class AidaClient {
 
   async generateCode(request: GenerateCodeRequest, options?: {signal?: AbortSignal}):
       Promise<GenerateCodeResponse|null> {
+    // Disable logging for now.
+    // For context, see b/454563259#comment35.
+    // We should be able to remove this ~end of April.
+    if (Root.Runtime.hostConfig.devToolsGeminiRebranding?.enabled) {
+      request.metadata.disable_user_content_logging = true;
+    }
     const response = await DispatchHttpRequestClient.makeHttpRequest<GenerateCodeResponse>(
         {
           service: SERVICE_NAME,

package/front_end/core/sdk/DebuggerModel.ts

@@ -1186,11 +1186,21 @@ export interface MissingDebugFiles {
   initiator: PageResourceLoadInitiator;
 }
 
-export interface MissingDebugInfoDetails {
-  details: string;
-  resources: MissingDebugFiles[];
+export const enum MissingDebugInfoType {
+  /** No debug information at all for the call frame */
+  NO_INFO = 'NO_INFO',
+
+  /** Some debug information available, but it references files with debug information we were not able to retrieve */
+  PARTIAL_INFO = 'PARTIAL_INFO',
 }
 
+export type MissingDebugInfo = {
+  type: MissingDebugInfoType.NO_INFO,
+}|{
+  type: MissingDebugInfoType.PARTIAL_INFO,
+  missingDebugFiles: MissingDebugFiles[],
+};
+
 export class CallFrame {
   debuggerModel: DebuggerModel;
   readonly script: Script;
@@ -1202,7 +1212,7 @@ export class CallFrame {
   readonly functionName: string;
   readonly #functionLocation: Location|undefined;
   #returnValue: RemoteObject|null;
-  missingDebugInfoDetails: MissingDebugInfoDetails|null;
+  missingDebugInfoDetails: MissingDebugInfo|null;
   readonly exception: RemoteObject|null;
 
   readonly canBeRestarted: boolean;

package/front_end/core/sdk/NetworkManager.ts

@@ -1022,6 +1022,7 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
     requestId,
     associatedCookies,
     headers,
+    deviceBoundSessionUsages,
     clientSecurityState,
     connectTiming,
     siteHasCookieInOtherPartition,
@@ -1036,10 +1037,11 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
         blockedRequestCookies.push({blockedReasons, cookie: Cookie.fromProtocolCookie(cookie)});
       }
     }
-    const extraRequestInfo = {
+    const extraRequestInfo: ExtraRequestInfo = {
       blockedRequestCookies,
       includedRequestCookies,
       requestHeaders: this.headersMapToHeadersArray(headers),
+      deviceBoundSessionUsages,
       clientSecurityState,
       connectTiming,
       siteHasCookieInOtherPartition,

package/front_end/core/sdk/NetworkRequest.ts

@@ -258,6 +258,7 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
   #exemptedResponseCookies: ExemptedSetCookieWithReason[] = [];
   #responseCookiesPartitionKey: Protocol.Network.CookiePartitionKey|null = null;
   #responseCookiesPartitionKeyOpaque: boolean|null = null;
+  #deviceBoundSessionUsages: Protocol.Network.DeviceBoundSessionWithUsage[] = [];
   #siteHasCookieInOtherPartition = false;
   localizedFailDescription: string|null = null;
   #url!: Platform.DevToolsPath.UrlString;
@@ -1612,6 +1613,7 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
     this.setRequestHeaders(extraRequestInfo.requestHeaders);
     this.#hasExtraRequestInfo = true;
     this.setRequestHeadersText('');  // Mark request headers as non-provisional
+    this.#deviceBoundSessionUsages = extraRequestInfo.deviceBoundSessionUsages || [];
     this.#clientSecurityState = extraRequestInfo.clientSecurityState;
     this.#appliedNetworkConditionsId = extraRequestInfo.appliedNetworkConditionsId;
     if (extraRequestInfo.connectTiming) {
@@ -1630,6 +1632,10 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
     this.#appliedNetworkConditionsId = appliedNetworkConditionsId;
   }
 
+  getDeviceBoundSessionUsages(): Protocol.Network.DeviceBoundSessionWithUsage[] {
+    return this.#deviceBoundSessionUsages;
+  }
+
   hasExtraRequestInfo(): boolean {
     return this.#hasExtraRequestInfo;
   }
@@ -2151,6 +2157,7 @@ export interface ExtraRequestInfo {
   blockedRequestCookies: Array<{blockedReasons: Protocol.Network.CookieBlockedReason[], cookie: Cookie}>;
   requestHeaders: NameValue[];
   includedRequestCookies: IncludedCookieWithReason[];
+  deviceBoundSessionUsages?: Protocol.Network.DeviceBoundSessionWithUsage[];
   clientSecurityState?: Protocol.Network.ClientSecurityState;
   connectTiming: Protocol.Network.ConnectTiming;
   siteHasCookieInOtherPartition?: boolean;

package/front_end/core/sdk/SourceMapScopesInfo.ts

@@ -190,7 +190,8 @@ export class SourceMapScopesInfo {
   }
 
   isEmpty(): boolean {
-    return !this.#originalScopes.length && !this.#generatedRanges.length;
+    const noScopes = this.#originalScopes.every(scope => scope === null);
+    return noScopes && !this.#generatedRanges.length;
   }
 
   addOriginalScopesAtIndex(sourceIdx: number, scope: ScopesCodec.OriginalScope): void {

package/front_end/generated/SupportedCSSProperties.js

@@ -499,6 +499,7 @@ export const generatedProperties = [
    "font-variation-settings",
    "font-weight",
    "forced-color-adjust",
+   "frame-sizing",
    "gap-rule-overlap",
    "grid-auto-columns",
    "grid-auto-flow",
@@ -518,6 +519,7 @@ export const generatedProperties = [
    "hyphenate-character",
    "hyphenate-limit-chars",
    "hyphens",
+   "image-animation",
    "image-orientation",
    "image-rendering",
    "inherits",
@@ -2597,6 +2599,16 @@ export const generatedProperties = [
   ],
   "name": "forced-color-adjust"
  },
+ {
+  "keywords": [
+   "auto",
+   "content-width",
+   "content-height",
+   "content-block-size",
+   "content-inline-size"
+  ],
+  "name": "frame-sizing"
+ },
  {
   "longhands": [
    "row-gap",
@@ -2779,6 +2791,15 @@ export const generatedProperties = [
   ],
   "name": "hyphens"
  },
+ {
+  "inherited": true,
+  "keywords": [
+   "normal",
+   "running",
+   "paused"
+  ],
+  "name": "image-animation"
+ },
  {
   "inherited": true,
   "name": "image-orientation"
@@ -3925,6 +3946,13 @@ export const generatedProperties = [
   ],
   "name": "rule-style"
  },
+ {
+  "longhands": [
+   "column-rule-visibility-items",
+   "row-rule-visibility-items"
+  ],
+  "name": "rule-visibility-items"
+ },
  {
   "longhands": [
    "column-rule-width",
@@ -6027,6 +6055,15 @@ export const generatedPropertyValues = {
    "preserve-parent-color"
   ]
  },
+ "frame-sizing": {
+  "values": [
+   "auto",
+   "content-width",
+   "content-height",
+   "content-block-size",
+   "content-inline-size"
+  ]
+ },
  "gap-rule-overlap": {
   "values": [
    "row-over-column",
@@ -6123,6 +6160,13 @@ export const generatedPropertyValues = {
    "auto"
   ]
  },
+ "image-animation": {
+  "values": [
+   "normal",
+   "running",
+   "paused"
+  ]
+ },
  "image-rendering": {
   "values": [
    "auto",

package/front_end/models/ai_assistance/agents/AiAgent.ts

@@ -309,6 +309,12 @@ export abstract class AiAgent<T> {
   constructor(opts: AgentOptions) {
     this.#aidaClient = opts.aidaClient;
     this.#serverSideLoggingEnabled = opts.serverSideLoggingEnabled ?? false;
+    // Disable logging for now.
+    // For context, see b/454563259#comment35.
+    // We should be able to remove this ~end of April.
+    if (Root.Runtime.hostConfig.devToolsGeminiRebranding?.enabled) {
+      this.#serverSideLoggingEnabled = false;
+    }
     this.#sessionId = opts.sessionId ?? crypto.randomUUID();
     this.confirmSideEffect = opts.confirmSideEffectForTest ?? (() => Promise.withResolvers());
   }

package/front_end/models/ai_code_generation/AiCodeGeneration.ts

@@ -54,6 +54,12 @@ export class AiCodeGeneration {
   constructor(opts: Options) {
     this.#aidaClient = opts.aidaClient;
     this.#serverSideLoggingEnabled = opts.serverSideLoggingEnabled ?? false;
+    // Disable logging for now.
+    // For context, see b/454563259#comment35.
+    // We should be able to remove this ~end of April.
+    if (Root.Runtime.hostConfig.devToolsGeminiRebranding?.enabled) {
+      this.#serverSideLoggingEnabled = false;
+    }
   }
 
   #buildRequest(

package/front_end/models/bindings/DebuggerLanguagePlugins.ts

@@ -58,16 +58,6 @@ const UIStrings = {
    * @example {File not found} PH3
    */
   failedToLoadDebugSymbolsFor: '[{PH1}] Failed to load debug symbols for {PH2} ({PH3})',
-  /**
-   * @description Error message that is displayed in UI debugging information cannot be found for a call frame
-   * @example {main} PH1
-   */
-  failedToLoadDebugSymbolsForFunction: 'No debug information for function "{PH1}"',
-  /**
-   * @description Error message that is displayed in UI when a file needed for debugging information for a call frame is missing
-   * @example {mainp.debug.wasm.dwp} PH1
-   */
-  debugSymbolsIncomplete: 'The debug information for function {PH1} is incomplete',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('models/bindings/DebuggerLanguagePlugins.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -508,14 +498,12 @@ export class DebuggerLanguagePluginManager implements
               return functionInfo.frames.map(({name}, index) => callFrame.createVirtualCallFrame(index, name));
             }
             if ('missingSymbolFiles' in functionInfo && functionInfo.missingSymbolFiles.length) {
-              const resources = functionInfo.missingSymbolFiles;
-              const details = i18nString(UIStrings.debugSymbolsIncomplete, {PH1: callFrame.functionName});
-              callFrame.missingDebugInfoDetails = {details, resources};
-            } else {
               callFrame.missingDebugInfoDetails = {
-                details: i18nString(UIStrings.failedToLoadDebugSymbolsForFunction, {PH1: callFrame.functionName}),
-                resources: [],
+                type: SDK.DebuggerModel.MissingDebugInfoType.PARTIAL_INFO,
+                missingDebugFiles: functionInfo.missingSymbolFiles,
               };
+            } else {
+              callFrame.missingDebugInfoDetails = {type: SDK.DebuggerModel.MissingDebugInfoType.NO_INFO};
             }
           }
           return callFrame;
@@ -792,26 +780,18 @@ export class DebuggerLanguagePluginManager implements
         const rawLocation = new SDK.DebuggerModel.Location(
             script.debuggerModel, script.scriptId, frame.lineNumber, frame.columnNumber, index);
         const uiLocation = await this.rawLocationToUILocation(rawLocation);
-        return {
-          uiSourceCode: uiLocation?.uiSourceCode,
-          url: uiLocation ? undefined : frame.url,
-          name,
-          line: uiLocation?.lineNumber ?? frame.lineNumber,
-          column: uiLocation?.columnNumber ?? frame.columnNumber,
-        };
+        return translatedFromUILocation(uiLocation, name, frame);
       });
 
       translatedFrames.push(await Promise.all(framePromises));
       return true;
     }
 
-    // Identity map the frame, then add the missing debug info details.
-    const mappedFrame: (typeof translatedFrames)[number][number] = {
-      url: frame.url,
-      name: frame.functionName,
-      line: frame.lineNumber,
-      column: frame.columnNumber,
-    };
+    // Translate the location only. We go through via "DebuggerWorkspaceBinding". It'll still try the plugin
+    // first, but this way, we'll get a UISourceCode for the raw script if the plugin fails to translate.
+    const uiLocation = await this.#debuggerWorkspaceBinding.rawLocationToUILocation(
+        new SDK.DebuggerModel.Location(script.debuggerModel, script.scriptId, frame.lineNumber, frame.columnNumber));
+    const mappedFrame = translatedFromUILocation(uiLocation, frame.functionName, frame);
 
     if ('missingSymbolFiles' in functionInfo && functionInfo.missingSymbolFiles.length) {
       translatedFrames.push([{
@@ -831,6 +811,27 @@ export class DebuggerLanguagePluginManager implements
     }
 
     return true;
+
+    function translatedFromUILocation(
+        uiLocation: Workspace.UISourceCode.UILocation|null, name: string|undefined,
+        fallback: StackTraceImpl.Trie.RawFrame): (typeof translatedFrames)[number][number] {
+      if (uiLocation) {
+        return {
+          uiSourceCode: uiLocation.uiSourceCode,
+          url: undefined,
+          name,
+          line: uiLocation.lineNumber,
+          column: uiLocation.columnNumber ?? -1,
+        };
+      }
+      return {
+        uiSourceCode: undefined,
+        url: fallback.url,
+        name: fallback.functionName,
+        line: fallback.lineNumber,
+        column: fallback.columnNumber,
+      };
+    }
   }
 
   scriptsForUISourceCode(uiSourceCode: Workspace.UISourceCode.UISourceCode): SDK.Script.Script[] {
@@ -920,15 +921,13 @@ export class DebuggerLanguagePluginManager implements
       // for the DebuggerModel again, which may disappear
       // in the meantime...
       void rawModuleHandle.addRawModulePromise.then(sourceFileURLs => {
-        if (!('missingSymbolFiles' in sourceFileURLs)) {
-          // The script might have disappeared meanwhile...
-          if (script.debuggerModel.scriptForId(script.scriptId) === script) {
-            const modelData = this.#debuggerModelToData.get(script.debuggerModel);
-            if (modelData) {  // The DebuggerModel could have disappeared meanwhile...
-              modelData.addSourceFiles(script, sourceFileURLs);
-              void this.#debuggerWorkspaceBinding.updateLocations(script);
-            }
+        // The script might have disappeared meanwhile...
+        if (script.debuggerModel.scriptForId(script.scriptId) === script) {
+          const modelData = this.#debuggerModelToData.get(script.debuggerModel);
+          if (modelData && Array.isArray(sourceFileURLs)) {  // The DebuggerModel could have disappeared meanwhile...
+            modelData.addSourceFiles(script, sourceFileURLs);
           }
+          void this.#debuggerWorkspaceBinding.updateLocations(script);
         }
       });
       return;

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -7137,10 +7137,18 @@ export const NativeFunctions = [
     name: "intercept",
     signatures: [["?options"]]
   },
+  {
+    name: "deferPageSwap",
+    signatures: [["options"]]
+  },
   {
     name: "NavigationCurrentEntryChangeEvent",
     signatures: [["type","eventInit"]]
   },
+  {
+    name: "addRestoreCallback",
+    signatures: [["callback"]]
+  },
   {
     name: "addHandler",
     signatures: [["handler"]]
@@ -7189,6 +7197,10 @@ export const NativeFunctions = [
     name: "setMenuListOptionsBoundsInAXTree",
     signatures: [["options_bounds","children_updated"]]
   },
+  {
+    name: "debugLog",
+    signatures: [["message"]]
+  },
   {
     name: "allowsFeature",
     signatures: [["feature","?origin"]]

package/front_end/models/source_map_scopes/NamesResolver.ts

@@ -3,7 +3,6 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
-import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
 import * as Bindings from '../bindings/bindings.js';
@@ -366,17 +365,15 @@ const resolveScope = async(script: SDK.Script.Script, scopeChain: Formatter.Form
 export const resolveScopeChain =
     async function(callFrame: SDK.DebuggerModel.CallFrame): Promise<SDK.DebuggerModel.ScopeChainEntry[]> {
   const {pluginManager} = Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance();
-  let scopeChain: SDK.DebuggerModel.ScopeChainEntry[]|null|undefined = await pluginManager.resolveScopeChain(callFrame);
+  const scopeChain: SDK.DebuggerModel.ScopeChainEntry[]|null|undefined =
+      await pluginManager.resolveScopeChain(callFrame);
   if (scopeChain) {
     return scopeChain;
   }
 
-  scopeChain = Root.Runtime.experiments.isEnabled(Root.ExperimentNames.ExperimentName.USE_SOURCE_MAP_SCOPES) ?
-      callFrame.script.sourceMap()?.resolveScopeChain(callFrame) :
-      null;
-  if (scopeChain) {
-    return scopeChain;
-  }
+  // TODO(crbug.com/465968290): Re-enable creating the scope chain from the source map once:
+  //    1) We have a flag indicating whether the source map contained variable/binding information.
+  //    2) We have a chrome feature flag.
 
   if (callFrame.script.isWasm()) {
     return callFrame.scopeChain();

package/front_end/models/stack_trace/StackTrace.ts

@@ -65,29 +65,29 @@ export interface EventTypes {
 
 /**
  * A small wrapper around a DebuggableFrame usable as a UI.Context flavor.
- * This is necessary as Frame and DebuggableFrame are updated in place, but
- * for UI.Context we need a new instance.
+ * This is necessary as DebuggableFrame are just interfaces and the impl classes are hidden.
+ *
+ * Moreover, re-translation creates a new DebuggableFrame instance even though the
+ * translation result stays the same, in which case we don't need a new instance for the flavor.
  */
-export class DebuggableFrameFlavor implements DebuggableFrame {
+export class DebuggableFrameFlavor {
   static #last?: DebuggableFrameFlavor;
 
-  readonly url?: string;
-  readonly uiSourceCode?: Workspace.UISourceCode.UISourceCode;
-  readonly name?: string;
-  readonly line: number;
-  readonly column: number;
-  readonly missingDebugInfo?: MissingDebugInfo;
-  readonly sdkFrame: SDK.DebuggerModel.CallFrame;
+  readonly frame: DebuggableFrame;
+
+  // TODO(crbug.com/465879478): Remove once this is no longer part of SDK.CallFrame.
+  //     We need to stash this separately because DebuggerModel sets this on CallFrame after the
+  //     fact so we can't just check it in the `equals` below.
+  readonly #missingDebugInfo: SDK.DebuggerModel.MissingDebugInfo|null;
 
   /** Use the static {@link for}. Only public to satisfy the `setFlavor` Ctor type  */
   constructor(frame: DebuggableFrame) {
-    this.url = frame.url;
-    this.uiSourceCode = frame.uiSourceCode;
-    this.name = frame.name;
-    this.line = frame.line;
-    this.column = frame.column;
-    this.missingDebugInfo = frame.missingDebugInfo;
-    this.sdkFrame = frame.sdkFrame;
+    this.frame = frame;
+    this.#missingDebugInfo = frame.sdkFrame.missingDebugInfoDetails;
+  }
+
+  get sdkFrame(): SDK.DebuggerModel.CallFrame {
+    return this.frame.sdkFrame;
   }
 
   /** @returns the same instance of DebuggableFrameFlavor for repeated calls with the same (i.e. deep equal) DebuggableFrame */
@@ -97,7 +97,8 @@ export class DebuggableFrameFlavor implements DebuggableFrame {
           a.column === b.column && a.sdkFrame === b.sdkFrame;
     }
 
-    if (!DebuggableFrameFlavor.#last || !equals(DebuggableFrameFlavor.#last, frame)) {
+    if (!DebuggableFrameFlavor.#last || !equals(DebuggableFrameFlavor.#last.frame, frame) ||
+        DebuggableFrameFlavor.#last.#missingDebugInfo !== frame.sdkFrame.missingDebugInfoDetails) {
       DebuggableFrameFlavor.#last = new DebuggableFrameFlavor(frame);
     }
     return DebuggableFrameFlavor.#last;

package/front_end/panels/accessibility/AXBreadcrumbsPane.ts

@@ -452,9 +452,11 @@ export class AXBreadcrumb {
 
     this.#element = document.createElement('div');
     this.#element.classList.add('ax-breadcrumb');
-    this.#element.setAttribute(
-        'jslog',
-        `${VisualLogging.treeItem().track({click: true, keydown: 'ArrowUp|ArrowDown|ArrowLeft|ArrowRight|Enter'})}`);
+    this.#element.setAttribute('jslog', `${VisualLogging.treeItem().track({
+                                 click: true,
+                                 resize: true,
+                                 keydown: 'ArrowUp|ArrowDown|ArrowLeft|ArrowRight|Enter'
+                               })}`);
     elementsToAXBreadcrumb.set(this.#element, this);
 
     this.#nodeElement = document.createElement('div');

package/front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -204,7 +204,16 @@ const UIStringsNotTranslate = {
    */
   inputDisclaimerForPerformanceEnterpriseNoLogging:
       'Chat messages and data from your performance trace are sent to Google. The content you submit and that is generated by this feature will not be used to improve Google’s AI models. This is an experimental AI feature and won’t always get it right.',
-
+  /**
+   * @description Disclaimer text right after the chat input.
+   */
+  inputDisclaimerForNoContext:
+      'Chat messages, any data the inspected page can see using Web APIs, and the items you select such as files, network requests, and performance traces are sent to Google and may be seen by human reviewers to improve this feature. This is an experimental AI feature and won’t always get it right.',
+  /**
+   * @description Disclaimer text right after the chat input.
+   */
+  inputDisclaimerForNoContextEnterpriseNoLogging:
+      'Chat messages, any data the inspected page can see using Web APIs, and the items you select such as files, network requests, and performance traces are sent to Google. This data will not be used to improve Google’s AI models. This is an experimental AI feature and won’t always get it right.',
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('panels/ai_assistance/AiAssistancePanel.ts', UIStrings);
@@ -1037,7 +1046,10 @@ export class AiAssistancePanel extends UI.Panel.Panel {
         return lockedString(UIStringsNotTranslate.inputDisclaimerForPerformance);
 
       case AiAssistanceModel.AiHistoryStorage.ConversationType.NONE:
-        return lockedString(UIStringsNotTranslate.inputDisclaimerForPerformance);
+        if (noLogging) {
+          return lockedString(UIStringsNotTranslate.inputDisclaimerForNoContextEnterpriseNoLogging);
+        }
+        return lockedString(UIStringsNotTranslate.inputDisclaimerForNoContext);
     }
   }
 

package/front_end/panels/ai_assistance/components/ChatMessage.ts

@@ -110,6 +110,10 @@ const UIStringsNotTranslate = {
    * @description The generic name of the AI agent (do not translate)
    */
   ai: 'AI',
+  /**
+   * @description Gemini (do not translate)
+   */
+  gemini: 'Gemini',
   /**
    * @description The fallback text when we can't find the user full name
    */
@@ -306,7 +310,7 @@ export const DEFAULT_VIEW = (input: ChatMessageViewInput, output: ViewOutput, ta
       <div class="message-info">
         <devtools-icon name=${icon}></devtools-icon>
         <div class="message-name">
-          <h2>${lockedString(UIStringsNotTranslate.ai)}</h2>
+          <h2>${AiAssistanceModel.AiUtils.isGeminiBranding() ? lockedString(UIStringsNotTranslate.gemini) : lockedString(UIStringsNotTranslate.ai)}</h2>
         </div>
       </div>
       ${Lit.Directives.repeat(

package/front_end/panels/animation/AnimationGroupPreviewUI.ts

@@ -98,7 +98,7 @@ const DEFAULT_VIEW: View = (input, output, target) => {
   render(html`
     <div class="animation-group-preview-ui">
       <button
-        jslog=${VisualLogging.item(`animations.buffer-preview${input.isScrollDrivenAnimationGroup ? '-sda' : ''}`).track({click: true})}
+        jslog=${VisualLogging.item(`animations.buffer-preview${input.isScrollDrivenAnimationGroup ? '-sda' : ''}`).track({click: true, resize: true})}
         class=${classes}
         role="option"
         aria-label=${input.label}

package/front_end/panels/application/DeviceBoundSessionsTreeElement.ts

@@ -6,6 +6,7 @@ import type * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
 import {createIcon} from '../../ui/kit/kit.js';
+import * as UI from '../../ui/legacy/legacy.js';
 
 import {ApplicationPanelTreeElement} from './ApplicationPanelTreeElement.js';
 import {
@@ -46,6 +47,16 @@ const UIStrings = {
    * linked to a session.
    */
   noSession: 'No session',
+  /**
+   *@description Tooltip text for a terminated session.
+   *@example {session_1} sessionName
+   */
+  terminatedSession: '{sessionName}, Session terminated',
+  /**
+   *@description Tooltip text for a session with errors.
+   *@example {session_1} sessionName
+   */
+  sessionWithErrors: '{sessionName}, Session has errors',
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('panels/application/DeviceBoundSessionsTreeElement.ts', UIStrings);
@@ -122,13 +133,23 @@ export class RootTreeElement extends ApplicationPanelTreeElement {
 
   #updateElementIconAndStyling(
       sessionElement: ApplicationPanelTreeElement, isSessionTerminated: boolean, sessionHasErrors: boolean): void {
+    const title = sessionElement.title as string;
     if (isSessionTerminated) {
       sessionElement.listItemElement.classList.add('device-bound-session-terminated');
       sessionElement.setLeadingIcons([createIcon('database-off')]);
+      const terminatedTitle = i18nString(UIStrings.terminatedSession, {sessionName: title});
+      UI.ARIAUtils.setLabel(sessionElement.listItemElement, terminatedTitle);
       return;
     }
     sessionElement.listItemElement.classList.remove('device-bound-session-terminated');
-    sessionElement.setLeadingIcons([createIcon(sessionHasErrors ? 'warning' : 'database')]);
+    if (sessionHasErrors) {
+      sessionElement.setLeadingIcons([createIcon('warning')]);
+      const errorTitle = i18nString(UIStrings.sessionWithErrors, {sessionName: title});
+      UI.ARIAUtils.setLabel(sessionElement.listItemElement, errorTitle);
+    } else {
+      sessionElement.setLeadingIcons([createIcon('database')]);
+      UI.ARIAUtils.setLabel(sessionElement.listItemElement, title);
+    }
   }
 
   #updateIconAndStyling(site: string, sessionId: string|undefined): void {