chrome-devtools-frontend 1.0.1570343 → 1.0.1571007

package/docs/contributing/infrastructure.md

@@ -281,6 +281,28 @@ even if it consistently failed 4 times out of 5 runs for some time. Try to
 correlate your failure with a luci-analysis report on this test and skip it
 until the flakiness gets resolved.
 
+### Clobber a builder's cache
+
+Builder bots utilize caching for project checkouts to speed up updates. This
+cache includes the build output directory (`/out`). Occasionally, stale files
+within these directories can interfere with the build process or test execution.
+
+If you suspect a cache issue, you can clear (clobber) the cache for a specific
+builder. This requires a local Chromium checkout to access the necessary utility
+script.
+
+Run the following command from the root of your Chromium checkout:
+
+```bash
+./tools/infra/builder-cache-clobber.py -S https://chromium-swarm.appspot.com/ --builder "Stand-alone Mac-arm64" --bucket ci --project devtools-frontend
+```
+
+#### Note about caches on try bots:
+
+Try bots (CQ) operate in tester/compilator pairs. When clearing caches, ensure
+you target both builders in the pair. For example, if you clear the cache for
+`dtf_mac_arm64_rel`, you must also clear it for `dtf_mac_arm64_compile_rel`.
+
 ## Luci Analysis configuration
 
 [Luci Analysis](go/luci-analysis) is a tool that helps you understand the

package/front_end/core/host/AidaClient.ts

@@ -79,7 +79,7 @@ export interface FunctionObjectParam<T extends string|number|symbol = string> ex
   type: ParametersTypes.OBJECT;
   // TODO: this can be also be ObjectParams
   properties: Record<T, FunctionPrimitiveParams|FunctionArrayParam>;
-  required: string[];
+  required: T[];
 }
 
 /**

package/front_end/core/root/Runtime.ts

@@ -522,6 +522,11 @@ interface HostConfigAiAssistanceContextSelectionAgent {
   enabled: boolean;
 }
 
+interface ConsoleInsightsTeasers {
+  enabled: boolean;
+  allowWithoutGpu: boolean;
+}
+
 /**
  * The host configuration that we expect from the DevTools back-end.
  *
@@ -570,6 +575,7 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsAiPromptApi: AiPromptApi,
   devToolsEnableDurableMessages: DevToolsEnableDurableMessages,
   devToolsAiAssistanceContextSelectionAgent: HostConfigAiAssistanceContextSelectionAgent,
+  devToolsConsoleInsightsTeasers: ConsoleInsightsTeasers,
 }>;
 
 /**

package/front_end/core/sdk/DebuggerModel.ts

@@ -653,26 +653,6 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     if (this.#expandCallFramesCallback) {
       pausedDetails.callFrames = await this.#expandCallFramesCallback.call(null, pausedDetails.callFrames);
     }
-
-    if (!Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.USE_SOURCE_MAP_SCOPES)) {
-      return;
-    }
-
-    // TODO(crbug.com/40277685): Support attaching/detaching source maps after pausing.
-    // Expanding call frames via source maps here is only suitable for the experiment prototype because
-    // we block until all relevant source maps are loaded.
-    // We should change this so the "Debugger Plugin" and "Source Map" have a bottle neck where they expand
-    // call frames and that bottleneck should support attaching/detaching source maps while paused.
-    const finalFrames: CallFrame[] = [];
-    for (const frame of pausedDetails.callFrames) {
-      const sourceMap = await this.sourceMapManager().sourceMapForClientPromise(frame.script);
-      if (sourceMap?.hasScopeInfo()) {
-        finalFrames.push(...sourceMap.expandCallFrame(frame));
-      } else {
-        finalFrames.push(frame);
-      }
-    }
-    pausedDetails.callFrames = finalFrames;
   }
 
   resumedScript(): void {
@@ -707,7 +687,8 @@ export class DebuggerModel extends SDKModel<EventTypes> {
     this.registerScript(script);
     this.dispatchEventToListeners(Events.ParsedScriptSource, script);
 
-    if (script.sourceMapURL && !hasSyntaxError) {
+    if ((!selectedDebugSymbol || selectedDebugSymbol.type === Protocol.Debugger.DebugSymbolsType.SourceMap) &&
+        script.sourceMapURL && !hasSyntaxError) {
       this.#sourceMapManager.attachSourceMap(script, script.sourceURL, script.sourceMapURL);
     }
 

package/front_end/core/sdk/SourceMap.ts

@@ -770,15 +770,6 @@ export class SourceMap {
         this.hasIgnoreListHint(sourceURL) === other.hasIgnoreListHint(sourceURL);
   }
 
-  expandCallFrame(frame: CallFrame): CallFrame[] {
-    this.#ensureSourceMapProcessed();
-    if (this.#scopesInfo === null) {
-      return [frame];
-    }
-
-    return this.#scopesInfo.expandCallFrame(frame);
-  }
-
   resolveScopeChain(frame: CallFrame): ScopeChainEntry[]|null {
     this.#ensureSourceMapProcessed();
     if (this.#scopesInfo === null) {

package/front_end/core/sdk/SourceMapScopesInfo.ts

@@ -276,30 +276,6 @@ export class SourceMapScopesInfo {
     return result;
   }
 
-  /**
-   * Takes a V8 provided call frame and expands any inlined frames into virtual call frames.
-   *
-   * For call frames where nothing was inlined, the result contains only a single element,
-   * the provided frame but with the original name.
-   *
-   * For call frames where we are paused in inlined code, this function returns a list of
-   * call frames from "inner to outer". This is the call frame at index 0
-   * signifies the top of this stack trace fragment.
-   *
-   * The rest are "virtual" call frames and will have an "inlineFrameIndex" set in ascending
-   * order, so the condition `result[index] === result[index].inlineFrameIndex` always holds.
-   */
-  expandCallFrame(callFrame: CallFrame): CallFrame[] {
-    const {originalFunctionName, inlinedFunctions} =
-        this.findInlinedFunctions(callFrame.location().lineNumber, callFrame.location().columnNumber);
-    const result: CallFrame[] = [];
-    for (const [index, fn] of inlinedFunctions.entries()) {
-      result.push(callFrame.createVirtualCallFrame(index, fn.name));
-    }
-    result.push(callFrame.createVirtualCallFrame(result.length, originalFunctionName));
-    return result;
-  }
-
   /**
    * Given a generated position, this returns all the surrounding generated ranges from outer
    * to inner.

package/front_end/entrypoints/main/MainImpl.ts

@@ -58,6 +58,7 @@ import * as PanelCommon from '../../panels/common/common.js';
 import * as Snippets from '../../panels/snippets/snippets.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as Snackbar from '../../ui/components/snackbars/snackbars.js';
+import * as UIHelpers from '../../ui/helpers/helpers.js';
 import * as Components from '../../ui/legacy/components/utils/utils.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as ThemeSupport from '../../ui/legacy/theme_support/theme_support.js';
@@ -128,6 +129,10 @@ const UIStrings = {
    * @description Notification shown to the user whenever DevTools has finished downloading a local AI model.
    */
   aiModelDownloaded: 'AI model downloaded',
+  /**
+   * @description A title of the menu item in the main menu leading to https://github.com/ChromeDevTools/chrome-devtools-mcp.
+   */
+  getDevToolsMcp: 'Get `DevTools MCP`'
 } as const;
 const str_ = i18n.i18n.registerUIStrings('entrypoints/main/MainImpl.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -942,6 +947,15 @@ export class MainMenuItem implements UI.Toolbar.Provider {
 
     contextMenu.defaultSection().appendAction('freestyler.main-menu', undefined, /* optional */ true);
 
+    contextMenu.defaultSection().appendItem(i18nString(UIStrings.getDevToolsMcp), () => {
+      UIHelpers.openInNewTab('https://github.com/ChromeDevTools/chrome-devtools-mcp');
+    }, {
+      additionalElement: UI.UIUtils.maybeCreateNewBadge('get-devtools-mcp'),
+      jslogContext: 'get-devtools-mcp',
+    });
+
+    contextMenu.defaultSection().appendSeparator();
+
     if (dockController.dockSide() === UI.DockController.DockState.UNDOCKED) {
       const mainTarget = SDK.TargetManager.TargetManager.instance().primaryPageTarget();
       if (mainTarget && mainTarget.type() === SDK.Target.Type.FRAME) {

package/front_end/models/ai_assistance/BuiltInAi.ts

@@ -47,7 +47,8 @@ export class BuiltInAi extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   }
 
   async getLanguageModelAvailability(): Promise<LanguageModelAvailability> {
-    if (!Root.Runtime.hostConfig.devToolsAiPromptApi?.enabled) {
+    if (!Root.Runtime.hostConfig.devToolsConsoleInsightsTeasers?.enabled ||
+        (Root.Runtime.hostConfig.devToolsAiPromptApi && !Root.Runtime.hostConfig.devToolsAiPromptApi.enabled)) {
       this.#availability = LanguageModelAvailability.DISABLED;
       return this.#availability;
     }
@@ -74,7 +75,7 @@ export class BuiltInAi extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   }
 
   isEventuallyAvailable(): boolean {
-    if (!this.#hasGpu && !Boolean(Root.Runtime.hostConfig.devToolsAiPromptApi?.allowWithoutGpu)) {
+    if (!this.#hasGpu && !Boolean(Root.Runtime.hostConfig.devToolsConsoleInsightsTeasers?.allowWithoutGpu)) {
       return false;
     }
     return this.#availability === LanguageModelAvailability.AVAILABLE ||
@@ -92,7 +93,7 @@ export class BuiltInAi extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   }
 
   startDownloadingModel(): void {
-    if (!Root.Runtime.hostConfig.devToolsAiPromptApi?.allowWithoutGpu && !this.#hasGpu) {
+    if (!Root.Runtime.hostConfig.devToolsConsoleInsightsTeasers?.allowWithoutGpu && !this.#hasGpu) {
       return;
     }
     if (this.#availability !== LanguageModelAvailability.DOWNLOADABLE) {
@@ -132,7 +133,7 @@ export class BuiltInAi extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   }
 
   async initialize(): Promise<void> {
-    if (!Root.Runtime.hostConfig.devToolsAiPromptApi?.allowWithoutGpu && !this.#hasGpu) {
+    if (!Root.Runtime.hostConfig.devToolsConsoleInsightsTeasers?.allowWithoutGpu && !this.#hasGpu) {
       return;
     }
     if (this.#availability !== LanguageModelAvailability.AVAILABLE &&

package/front_end/panels/network/RequestConditionsDrawer.ts

@@ -181,7 +181,6 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
   render(
       // clang-format off
     html`
-    <style>${RequestConditionsDrawer}</style>
     <devtools-toolbar jslog=${VisualLogging.toolbar()}>
       <devtools-checkbox
         ?checked=${input.enabled}

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -1748,6 +1748,7 @@ export const knownContextValues = new Set([
   'geolocation.get-current-position',
   'geolocation.watch-position',
   'georgia',
+  'get-devtools-mcp',
   'gl',
   'global-ai-button',
   'global-ai-button-click-count',

package/package.json

@@ -104,5 +104,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1570343"
+  "version": "1.0.1571007"
 }