chrome-devtools-frontend 1.0.1568864 → 1.0.1569477

package/front_end/ui/components/text_editor/AiCodeGenerationProvider.ts

@@ -49,7 +49,10 @@ export interface AiCodeGenerationConfig {
 
 export class AiCodeGenerationProvider {
   #devtoolsLocale: string;
-  #aiCodeCompletionSetting = Common.Settings.Settings.instance().createSetting('ai-code-completion-enabled', false);
+  // 'ai-code-completion-enabled' setting controls both AI code completion and AI code generation.
+  // Since this provider deals with code generation, the field has been named `#aiCodeGenerationEnabledSetting`.
+  #aiCodeGenerationEnabledSetting =
+      Common.Settings.Settings.instance().createSetting('ai-code-completion-enabled', false);
   #generationTeaserCompartment = new CodeMirror.Compartment();
   #generationTeaser: PanelCommon.AiCodeGenerationTeaser.AiCodeGenerationTeaser;
   #editor?: TextEditor;
@@ -92,13 +95,16 @@ export class AiCodeGenerationProvider {
   dispose(): void {
     this.#controller.abort();
     this.#cleanupAiCodeGeneration();
+    this.#aiCodeGenerationEnabledSetting.removeChangeListener(this.#boundOnUpdateAiCodeGenerationState);
+    Host.AidaClient.HostConfigTracker.instance().removeEventListener(
+        Host.AidaClient.Events.AIDA_AVAILABILITY_CHANGED, this.#boundOnUpdateAiCodeGenerationState);
   }
 
   editorInitialized(editor: TextEditor): void {
     this.#editor = editor;
     Host.AidaClient.HostConfigTracker.instance().addEventListener(
         Host.AidaClient.Events.AIDA_AVAILABILITY_CHANGED, this.#boundOnUpdateAiCodeGenerationState);
-    this.#aiCodeCompletionSetting.addChangeListener(this.#boundOnUpdateAiCodeGenerationState);
+    this.#aiCodeGenerationEnabledSetting.addChangeListener(this.#boundOnUpdateAiCodeGenerationState);
     void this.#updateAiCodeGenerationState();
   }
 
@@ -126,7 +132,7 @@ export class AiCodeGenerationProvider {
   async #updateAiCodeGenerationState(): Promise<void> {
     const aidaAvailability = await Host.AidaClient.AidaClient.checkAccessPreconditions();
     const isAvailable = aidaAvailability === Host.AidaClient.AidaAccessPreconditions.AVAILABLE;
-    const isEnabled = this.#aiCodeCompletionSetting.get();
+    const isEnabled = this.#aiCodeGenerationEnabledSetting.get();
     if (isAvailable && isEnabled) {
       this.#setupAiCodeGeneration();
     } else {
@@ -309,6 +315,10 @@ export class AiCodeGenerationProvider {
       this.#aiCodeGenerationConfig?.onResponseReceived();
       return;
     } catch (e) {
+      if (e instanceof Host.DispatchHttpRequestClient.DispatchHttpRequestError &&
+          e.type === Host.DispatchHttpRequestClient.ErrorType.ABORT) {
+        return;
+      }
       AiCodeGeneration.debugLog('Error while fetching code generation suggestions from AIDA', e);
       this.#aiCodeGenerationConfig?.onResponseReceived();
       Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiCodeGenerationError);
@@ -347,10 +357,12 @@ function aiCodeGenerationTeaserExtension(teaser: PanelCommon.AiCodeGenerationTea
       const line = this.#view.state.doc.lineAt(cursorPosition);
 
       const isEmptyLine = line.length === 0;
+      const canShowDiscoveryState =
+          UI.UIUtils.PromotionManager.instance().canShowPromotion(PanelCommon.AiCodeGenerationTeaser.PROMOTION_ID);
       const isComment = Boolean(AiCodeGenerationParser.extractCommentText(this.#view.state, cursorPosition));
       const isCursorAtEndOfLine = cursorPosition >= line.to;
 
-      if ((isEmptyLine) || (isComment && isCursorAtEndOfLine)) {
+      if ((isEmptyLine && canShowDiscoveryState) || (isComment && isCursorAtEndOfLine)) {
         return CodeMirror.Decoration.set([
           CodeMirror.Decoration.widget({widget: new AccessiblePlaceholder(teaser), side: 1}).range(cursorPosition),
         ]);

package/front_end/ui/kit/link/Link.ts

@@ -39,6 +39,7 @@ export class Link extends HTMLElement {
       this.setAttribute('tabindex', '0');
     }
     this.#setDefaultTitle();
+    this.#onJslogContextChange();
 
     this.setAttribute('role', 'link');
     this.setAttribute('target', '_blank');
@@ -81,15 +82,20 @@ export class Link extends HTMLElement {
   }
 
   #onJslogContextChange(): void {
-    const href = this.href;
-    if (!href) {
-      throw new Error('`href` is a required attribute.');
+    let jslogContext = this.jslogContext;
+    if (!jslogContext) {
+      try {
+        if (!this.href) {
+          return;
+        }
+        const urlForContext = new URL(this.href);
+        urlForContext.search = '';
+        jslogContext = Platform.StringUtilities.toKebabCase(urlForContext.toString());
+      } catch {
+        return;
+      }
     }
-    const urlForContext = new URL(href);
-    urlForContext.search = '';
-    const jslogContext = Platform.StringUtilities.toKebabCase(
-        this.jslogContext ?? urlForContext.toString(),
-    );
+
     const jslog = VisualLogging.link().track({click: true, keydown: 'Enter|Space'}).context(jslogContext);
     this.setAttribute('jslog', jslog.toString());
   }

package/front_end/ui/kit/link/link.css

@@ -5,7 +5,7 @@
  */
 
 :host {
-  display: inline-block;
+  display: inline;
   cursor: pointer;
   text-decoration: underline;
   color: var(--text-link);

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -352,6 +352,7 @@ export const knownContextValues = new Set([
   'ai-code-completion-teaser-dismissed',
   'ai-code-completion-teaser.dismiss',
   'ai-code-completion-teaser.fre',
+  'ai-code-generation-disclaimer',
   'ai-code-generation-teaser.info-button',
   'ai-code-generation-upgrade-dialog.continue',
   'ai-code-generation-upgrade-dialog.manage-in-settings',
@@ -1626,6 +1627,7 @@ export const knownContextValues = new Set([
   'float-64-bit',
   'flood-color',
   'flood-opacity',
+  'flow-tolerance',
   'focus',
   'focus-visible',
   'focus-within',

package/package.json

@@ -104,5 +104,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1568864"
+  "version": "1.0.1569477"
 }