chrome-devtools-frontend 1.0.1562614 → 1.0.1563104

package/front_end/core/sdk/Target.ts

@@ -66,7 +66,9 @@ export class Target extends ProtocolClient.InspectorBackend.TargetBase {
         this.#capabilitiesMask = Capability.JS | Capability.LOG | Capability.NETWORK | Capability.TARGET |
             Capability.INSPECTOR | Capability.IO | Capability.EVENT_BREAKPOINTS;
         if (parentTarget?.type() !== Type.FRAME) {
-          this.#capabilitiesMask |= Capability.BROWSER | Capability.STORAGE;
+          // TODO(crbug.com/406991275): This should also grant the `STORAGE` capability, but first the
+          // crashers in https://crbug.com/466134219 have to be resolved.
+          this.#capabilitiesMask |= Capability.BROWSER;
         }
         break;
       case Type.SHARED_WORKER:

package/front_end/models/ai_code_generation/AiCodeGeneration.ts

@@ -13,9 +13,15 @@ Your role is to act as an expert pair programmer within the Chrome DevTools envi
 
 **Core Directives (Adhere to these strictly):**
 
-1.  **Language and Quality:**
-    *   Generate code that is modern, efficient, and idiomatic for the inferred language (e.g., modern JavaScript/ES6+, semantic HTML5, efficient CSS).
-    *   Where appropriate, include basic error handling (e.g., for API calls).
+1. **Language and Quality:**
+    * Generate code that is modern, efficient, and idiomatic for the inferred language (e.g., modern JavaScript/ES6+, semantic HTML5, efficient CSS).
+    * Where appropriate, include basic error handling (e.g., for API calls).
+    * Determine the programming language from the user's prompt.
+
+2.  **Output Format (Strict):**
+    * **Return ONLY code blocks.** * Do NOT include any introductory text, explanations, or concluding remarks.
+    * Do NOT provide step-by-step guides or descriptions of how the code works.
+    * Inline comments within the code are permitted and encouraged for clarity.
 `;
 
 export const additionalContextForConsole = `
@@ -59,6 +65,10 @@ export class AiCodeGeneration {
     function validTemperature(temperature: number|undefined): number|undefined {
       return typeof temperature === 'number' && temperature >= 0 ? temperature : undefined;
     }
+
+    // Workaround: Combine preamble and target language into the main prompt to enforce instructions.
+    // The API and model ignores system-level instructions provided in the preamble field of the request.
+    prompt = preamble + prompt + '\n**Target Language:** ' + inferenceLanguage;
     return {
       client: Host.AidaClient.CLIENT_NAME,
       preamble,
@@ -70,10 +80,8 @@ export class AiCodeGeneration {
       },
       use_case: Host.AidaClient.UseCase.CODE_GENERATION,
       options: {
-        inference_language: inferenceLanguage,
         temperature: validTemperature(this.#options.temperature),
         model_id: this.#options.modelId || undefined,
-        expect_code_output: true,
       },
       metadata: {
         disable_user_content_logging: !(this.#serverSideLoggingEnabled ?? false),

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -6663,18 +6663,6 @@ export const NativeFunctions = [
     name: "moveBefore",
     signatures: [["node","child"]]
   },
-  {
-    name: "patchBetween",
-    signatures: [["prev_child","next_child"]]
-  },
-  {
-    name: "patchAfter",
-    signatures: [["ref"]]
-  },
-  {
-    name: "patchBefore",
-    signatures: [["ref"]]
-  },
   {
     name: "QuotaExceededError",
     signatures: [["?message","?options"]]
@@ -7193,10 +7181,6 @@ export const NativeFunctions = [
     name: "setMenuListOptionsBoundsInAXTree",
     signatures: [["options_bounds","children_updated"]]
   },
-  {
-    name: "PatchEvent",
-    signatures: [["type","init"]]
-  },
   {
     name: "allowsFeature",
     signatures: [["feature","?origin"]]
@@ -9088,7 +9072,7 @@ export const NativeFunctions = [
   },
   {
     name: "copyElementImageToTexture",
-    signatures: [["source","destination"],["source","width","height","destination"]]
+    signatures: [["source","destination"],["source","width","height","destination"],["source","sx","sy","swidth","sheight","destination"]]
   },
   {
     name: "setIndexBuffer",

package/front_end/panels/common/AiCodeGenerationTeaser.ts

@@ -1,11 +1,16 @@
 // Copyright 2025 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
+import '../../ui/components/tooltips/tooltips.js';
 
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as Root from '../../core/root/root.js';
+import * as AiCodeCompletion from '../../models/ai_code_completion/ai_code_completion.js';
+import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as UI from '../../ui/legacy/legacy.js';
-import {html, nothing, render} from '../../ui/lit/lit.js';
+import {Directives, html, nothing, render} from '../../ui/lit/lit.js';
+import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
 import styles from './aiCodeGenerationTeaser.css.js';
 
@@ -13,11 +18,11 @@ const UIStringsNotTranslate = {
   /**
    * @description Text for teaser to generate code.
    */
-  ctrlItoGenerateCode: 'ctrl-i to generate code',
+  ctrlItoGenerateCode: 'Ctrl+I to generate code',
   /**
    * @description Text for teaser to generate code in Mac.
    */
-  cmdItoGenerateCode: 'cmd-i to generate code',
+  cmdItoGenerateCode: 'Cmd+I to generate code',
   /**
    * Text for teaser when generating suggestion.
    */
@@ -26,6 +31,34 @@ const UIStringsNotTranslate = {
    * Text for teaser for discoverability.
    */
   writeACommentToGenerateCode: 'Write a comment to generate code',
+  /**
+   * @description Text for tooltip shown on hovering over "Relevant Data" in the disclaimer text for AI code generation in Console panel.
+   */
+  tooltipDisclaimerTextForAiCodeGenerationInConsole:
+      'To generate code suggestions, your console input and the history of your current console session are shared with Google. This data may be seen by human reviewers to improve this feature.',
+  /**
+   * @description Text for tooltip shown on hovering over "Relevant Data" in the disclaimer text for AI code generation in Console panel.
+   */
+  tooltipDisclaimerTextForAiCodeGenerationNoLoggingInConsole:
+      'To generate code suggestions, your console input and the history of your current console session are shared with Google. This data will not be used to improve Google’s AI models. Your organization may change these settings at any time.',
+  /**
+   * @description Text for tooltip shown on hovering over "Relevant Data" in the disclaimer text for AI code generation in Sources panel.
+   */
+  tooltipDisclaimerTextForAiCodeGenerationInSources:
+      'To generate code suggestions, the contents of the currently open file are shared with Google. This data may be seen by human reviewers to improve this feature.',
+  /**
+   * @description Text for tooltip shown on hovering over "Relevant Data" in the disclaimer text for AI code generation in Sources panel.
+   */
+  tooltipDisclaimerTextForAiCodeGenerationNoLoggingInSources:
+      'To generate code suggestions, the contents of the currently open file are shared with Google. This data will not be used to improve Google’s AI models. Your organization may change these settings at any time.',
+  /**
+   * @description Text for tooltip button which redirects to AI settings
+   */
+  manageInSettings: 'Manage in settings',
+  /**
+   * @description Title for disclaimer info button in the teaser to generate code.
+   */
+  learnMoreAboutHowYourDataIsBeingUsed: 'Learn more about how your data is being used',
 } as const;
 
 const lockedString = i18n.i18n.lockedString;
@@ -37,15 +70,92 @@ export enum AiCodeGenerationTeaserDisplayState {
   LOADING = 'loading',
 }
 
+function getTooltipDisclaimerText(noLogging: boolean, panel: AiCodeCompletion.AiCodeCompletion.ContextFlavor): string {
+  switch (panel) {
+    case AiCodeCompletion.AiCodeCompletion.ContextFlavor.CONSOLE:
+      return noLogging ?
+          lockedString(UIStringsNotTranslate.tooltipDisclaimerTextForAiCodeGenerationNoLoggingInConsole) :
+          lockedString(UIStringsNotTranslate.tooltipDisclaimerTextForAiCodeGenerationInConsole);
+    case AiCodeCompletion.AiCodeCompletion.ContextFlavor.SOURCES:
+      return noLogging ?
+          lockedString(UIStringsNotTranslate.tooltipDisclaimerTextForAiCodeGenerationNoLoggingInSources) :
+          lockedString(UIStringsNotTranslate.tooltipDisclaimerTextForAiCodeGenerationInSources);
+  }
+}
+
 export interface ViewInput {
   displayState: AiCodeGenerationTeaserDisplayState;
+  disclaimerTooltipId?: string;
+  noLogging: boolean;
+  onManageInSettingsTooltipClick: (event: Event) => void;
+  // TODO(b/472268298): Remove ContextFlavor explicitly and pass required values
+  panel?: AiCodeCompletion.AiCodeCompletion.ContextFlavor;
 }
 
-export type View = (input: ViewInput, output: object, target: HTMLElement) => void;
+export interface ViewOutput {
+  hideTooltip?: () => void;
+}
+
+export type View = (input: ViewInput, output: ViewOutput, target: HTMLElement) => void;
+
+export const DEFAULT_VIEW: View = (input, output, target) => {
+  if (!input.panel) {
+    render(nothing, target);
+    return;
+  }
 
-export const DEFAULT_VIEW: View = (input, _output, target) => {
   let teaserLabel;
   switch (input.displayState) {
+    case AiCodeGenerationTeaserDisplayState.TRIGGER: {
+      if (!input.disclaimerTooltipId) {
+        render(nothing, target);
+        return;
+      }
+      const toGenerateCode = Host.Platform.isMac() ? lockedString(UIStringsNotTranslate.cmdItoGenerateCode) :
+                                                     lockedString(UIStringsNotTranslate.ctrlItoGenerateCode);
+      const tooltipDisclaimerText = getTooltipDisclaimerText(input.noLogging, input.panel);
+      // TODO(b/472291834): Disclaimer icon should match the placeholder's color
+      // clang-format off
+      teaserLabel = html`<div class="ai-code-generation-teaser-trigger">
+        ${toGenerateCode}&nbsp;<devtools-button
+          .data=${{
+              title: lockedString(UIStringsNotTranslate.learnMoreAboutHowYourDataIsBeingUsed),
+              size: Buttons.Button.Size.MICRO,
+              iconName: 'info',
+              variant: Buttons.Button.Variant.ICON,
+              jslogContext: 'ai-code-generation-teaser.info-button',
+            } as Buttons.Button.ButtonData}
+            aria-details=${input.disclaimerTooltipId}
+            aria-describedby=${input.disclaimerTooltipId}
+          ></devtools-button>
+          <devtools-tooltip
+              id=${input.disclaimerTooltipId}
+              variant="rich"
+              jslogContext="ai-code-generation-disclaimer"
+              ${Directives.ref(el => {
+                if (el instanceof HTMLElement) {
+                  output.hideTooltip = () => {
+                    el.hidePopover();
+                  };
+                }
+              })}>
+            <div class="disclaimer-tooltip-container"><div class="tooltip-text">
+                ${tooltipDisclaimerText}
+                </div>
+                <span
+                    tabIndex="0"
+                    class="link"
+                    role="link"
+                    jslog=${VisualLogging.link('open-ai-settings').track({
+                      click: true,
+                    })}
+                    @click=${input.onManageInSettingsTooltipClick}
+                >${lockedString(UIStringsNotTranslate.manageInSettings)}</span></div></devtools-tooltip>
+                  </div>`;
+      // clang-format on
+      break;
+    }
+
     case AiCodeGenerationTeaserDisplayState.DISCOVERY: {
       const newBadge = UI.UIUtils.maybeCreateNewBadge(PROMOTION_ID);
       teaserLabel = newBadge ?
@@ -58,13 +168,6 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
       teaserLabel = html`${lockedString(UIStringsNotTranslate.generating)}`;
       break;
     }
-
-    case AiCodeGenerationTeaserDisplayState.TRIGGER: {
-      const toGenerateCode = Host.Platform.isMac() ? lockedString(UIStringsNotTranslate.cmdItoGenerateCode) :
-                                                     lockedString(UIStringsNotTranslate.ctrlItoGenerateCode);
-      teaserLabel = html`${toGenerateCode}`;
-      break;
-    }
   }
 
   // clang-format off
@@ -73,7 +176,7 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
           <style>${styles}</style>
           <style>@scope to (devtools-widget > *) { ${UI.inspectorCommonStyles} }</style>
           <div class="ai-code-generation-teaser">
-            &nbsp;${teaserLabel}
+            ${teaserLabel}
           </div>
         `, target
       );
@@ -83,23 +186,32 @@ export const DEFAULT_VIEW: View = (input, _output, target) => {
 // TODO(b/448063927): Add "Dont show again" for discovery teaser.
 export class AiCodeGenerationTeaser extends UI.Widget.Widget {
   readonly #view: View;
+  #viewOutput: ViewOutput = {};
 
   #displayState = AiCodeGenerationTeaserDisplayState.TRIGGER;
+  #disclaimerTooltipId?: string;
+  #noLogging: boolean;  // Whether the enterprise setting is `ALLOW_WITHOUT_LOGGING` or not.
+  #panel?: AiCodeCompletion.AiCodeCompletion.ContextFlavor;
 
   constructor(view?: View) {
     super();
     this.markAsExternallyManaged();
+    this.#noLogging = Root.Runtime.hostConfig.aidaAvailability?.enterprisePolicyValue ===
+        Root.Runtime.GenAiEnterprisePolicyValue.ALLOW_WITHOUT_LOGGING;
     this.#view = view ?? DEFAULT_VIEW;
     this.requestUpdate();
   }
 
   override performUpdate(): void {
-    const output = {};
     this.#view(
         {
           displayState: this.#displayState,
+          onManageInSettingsTooltipClick: this.#onManageInSettingsTooltipClick.bind(this),
+          disclaimerTooltipId: this.#disclaimerTooltipId,
+          noLogging: this.#noLogging,
+          panel: this.#panel,
         },
-        output, this.contentElement);
+        this.#viewOutput, this.contentElement);
   }
 
   get displayState(): AiCodeGenerationTeaserDisplayState {
@@ -113,4 +225,21 @@ export class AiCodeGenerationTeaser extends UI.Widget.Widget {
     this.#displayState = displayState;
     this.requestUpdate();
   }
+
+  set disclaimerTooltipId(disclaimerTooltipId: string) {
+    this.#disclaimerTooltipId = disclaimerTooltipId;
+    this.requestUpdate();
+  }
+
+  set panel(panel: AiCodeCompletion.AiCodeCompletion.ContextFlavor) {
+    this.#panel = panel;
+    this.requestUpdate();
+  }
+
+  #onManageInSettingsTooltipClick(event: Event): void {
+    event.stopPropagation();
+    this.#viewOutput.hideTooltip?.();
+    void UI.ViewManager.ViewManager.instance().showView('chrome-ai');
+    event.consume(true);
+  }
 }

package/front_end/panels/common/aiCodeGenerationTeaser.css

@@ -6,9 +6,43 @@
 
 @scope to (devtools-widget > *) {
     .ai-code-generation-teaser {
+        pointer-events: all;
+        font-style: italic;
+        padding-left: var(--sys-size-3);
+        line-height: var(--sys-size-7);
+
+        .ai-code-generation-teaser-trigger {
+            display: inline-flex;
+            align-items: center;
+        }
+
         .new-badge {
             font-style: normal;
             display: inline-block;
         }
+
+        devtools-tooltip:popover-open {
+            display: flex;
+            flex-direction: column;
+            align-items: center;
+
+            .disclaimer-tooltip-container {
+                padding: var(--sys-size-4) 0;
+                max-width: var(--sys-size-30);
+                white-space: normal;
+
+                .tooltip-text {
+                    color: var(--sys-color-on-surface-subtle);
+                    padding: 0 var(--sys-size-5);
+                    align-items: flex-start;
+                    gap: 10px;
+                }
+
+                .link {
+                    margin: var(--sys-size-5) var(--sys-size-8) 0 var(--sys-size-5);
+                    display: inline-block;
+                }
+            }
+        }
     }
 }

package/front_end/panels/event_listeners/EventListenersView.ts

@@ -347,7 +347,8 @@ export class ObjectEventListenerBar extends UI.TreeOutline.TreeElement {
     }
 
     const subtitle = title.createChild('span', 'event-listener-tree-subtitle');
-    const linkElement = linkifier.linkifyRawLocation(this.#eventListener.location(), this.#eventListener.sourceURL());
+    const linkElement = linkifier.linkifyRawLocation(
+        this.#eventListener.location(), this.#eventListener.sourceURL(), undefined, {tabStop: true});
     subtitle.appendChild(linkElement);
 
     this.listItemElement.addEventListener('contextmenu', event => {

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: https://chromium.googlesource.com/chromium/src
 Version: N/A
-Revision: 142ca60f39457730eafcdd7058a4f812f9aa63dc
+Revision: e3edb4435f06ac3de39688c44cc50378c47e35e8
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/ui/components/text_editor/AiCodeCompletionTeaserPlaceholder.ts

@@ -71,6 +71,10 @@ export class AiCodeCompletionTeaserPlaceholder extends CM.WidgetType {
     super.destroy(dom);
     this.teaser?.hideWidget();
   }
+
+  override eq(other: AiCodeCompletionTeaserPlaceholder): boolean {
+    return this.teaser === other.teaser;
+  }
 }
 
 export function aiCodeCompletionTeaserPlaceholder(teaser: UI.Widget.Widget): CM.Extension {

package/front_end/ui/components/text_editor/AiCodeGenerationProvider.ts

@@ -5,6 +5,7 @@
 import * as Common from '../../../core/common/common.js';
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as AiCodeCompletion from '../../../models/ai_code_completion/ai_code_completion.js';
 import * as AiCodeGeneration from '../../../models/ai_code_generation/ai_code_generation.js';
 import * as PanelCommon from '../../../panels/common/common.js';
 import * as CodeMirror from '../../../third_party/codemirror.next/codemirror.next.js';
@@ -43,6 +44,7 @@ export interface AiCodeGenerationConfig {
   onRequestTriggered: () => void;
   // TODO(b/445394511): Move exposing citations to onSuggestionAccepted
   onResponseReceived: (citations: Host.AidaClient.Citation[]) => void;
+  panel: AiCodeCompletion.AiCodeCompletion.ContextFlavor;
 }
 
 export class AiCodeGenerationProvider {
@@ -64,6 +66,9 @@ export class AiCodeGenerationProvider {
       throw new Error('AI code generation feature is not enabled.');
     }
     this.#generationTeaser = new PanelCommon.AiCodeGenerationTeaser.AiCodeGenerationTeaser();
+    this.#generationTeaser.disclaimerTooltipId =
+        aiCodeGenerationConfig.panel + '-ai-code-generation-disclaimer-tooltip';
+    this.#generationTeaser.panel = aiCodeGenerationConfig.panel;
     this.#aiCodeGenerationConfig = aiCodeGenerationConfig;
   }
 
@@ -265,9 +270,13 @@ export class AiCodeGenerationProvider {
         return;
       }
 
+      const backtickRegex = /^```(?:\w+)?\n([\s\S]*?)\n```$/;
+      const matchArray = topSample.generationString.match(backtickRegex);
+      const suggestionText = matchArray ? matchArray[1].trim() : topSample.generationString;
+
       this.#editor.dispatch({
         effects: setAiAutoCompleteSuggestion.of({
-          text: '\n' + topSample.generationString,
+          text: '\n' + suggestionText,
           from: cursor,
           rpcGlobalId: generationResponse.metadata.rpcGlobalId,
           sampleId: topSample.sampleId,
@@ -276,7 +285,7 @@ export class AiCodeGenerationProvider {
         })
       });
 
-      AiCodeGeneration.debugLog('Suggestion dispatched to the editor', topSample.generationString);
+      AiCodeGeneration.debugLog('Suggestion dispatched to the editor', suggestionText);
       const citations = topSample.attributionMetadata?.citations ?? [];
       this.#aiCodeGenerationConfig?.onResponseReceived(citations);
     } catch (e) {
@@ -348,5 +357,15 @@ function aiCodeGenerationTeaserExtension(teaser: PanelCommon.AiCodeGenerationTea
     }
   }, {
     decorations: v => v.decorations,
+    eventHandlers: {
+      mousemove(event: MouseEvent): boolean {
+        // Required for mouse hover to propagate to the info button in teaser.
+        return (event.target instanceof Node && teaser.contentElement.contains(event.target));
+      },
+      mousedown(event: MouseEvent): boolean {
+        // Required for mouse click to propagate to the info tooltip in teaser.
+        return (event.target instanceof Node && teaser.contentElement.contains(event.target));
+      },
+    },
   });
 }

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -320,13 +320,14 @@ export class Linkifier extends Common.ObjectWrapper.ObjectWrapper<EventTypes> im
   }
 
   linkifyRawLocation(
-      rawLocation: SDK.DebuggerModel.Location, fallbackUrl: Platform.DevToolsPath.UrlString,
-      className?: string): HTMLElement {
+      rawLocation: SDK.DebuggerModel.Location, fallbackUrl: Platform.DevToolsPath.UrlString, className?: string,
+      options?: LinkifyOptions): HTMLElement {
     return this.linkifyScriptLocation(
         rawLocation.debuggerModel.target(), rawLocation.scriptId, fallbackUrl, rawLocation.lineNumber, {
           columnNumber: rawLocation.columnNumber,
           className,
           inlineFrameIndex: rawLocation.inlineFrameIndex,
+          tabStop: options?.tabStop,
         });
   }
 

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -352,6 +352,7 @@ export const knownContextValues = new Set([
   'ai-code-completion-teaser-dismissed',
   'ai-code-completion-teaser.dismiss',
   'ai-code-completion-teaser.fre',
+  'ai-code-generation-teaser.info-button',
   'ai-explorer',
   'ai_assistance',
   'align-content',

package/package.json

@@ -105,5 +105,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1562614"
+  "version": "1.0.1563104"
 }