chrome-devtools-frontend 1.0.1558690 → 1.0.1561080

package/front_end/generated/protocol-mapping.d.ts

@@ -3351,6 +3351,15 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.Network.EnableRequest?];
       returnType: void;
     };
+    /**
+     * Configures storing response bodies outside of renderer, so that these survive
+     * a cross-process navigation.
+     * If maxTotalBufferSize is not set, durable messages are disabled.
+     */
+    'Network.configureDurableMessages': {
+      paramsType: [Protocol.Network.ConfigureDurableMessagesRequest?];
+      returnType: void;
+    };
     /**
      * Returns all browser cookies. Depending on the backend support, will return detailed cookie
      * information in the `cookies` field.
@@ -4880,6 +4889,13 @@ export namespace ProtocolMapping {
       paramsType: [];
       returnType: Protocol.Tracing.GetCategoriesResponse;
     };
+    /**
+     * Return a descriptor for all available tracing categories.
+     */
+    'Tracing.getTrackEventDescriptor': {
+      paramsType: [];
+      returnType: Protocol.Tracing.GetTrackEventDescriptorResponse;
+    };
     /**
      * Record a clock sync marker in the trace.
      */

package/front_end/generated/protocol-proxy-api.d.ts

@@ -2538,6 +2538,13 @@ declare namespace ProtocolProxyApi {
      */
     invoke_enable(params: Protocol.Network.EnableRequest): Promise<Protocol.ProtocolResponseWithError>;
 
+    /**
+     * Configures storing response bodies outside of renderer, so that these survive
+     * a cross-process navigation.
+     * If maxTotalBufferSize is not set, durable messages are disabled.
+     */
+    invoke_configureDurableMessages(params: Protocol.Network.ConfigureDurableMessagesRequest): Promise<Protocol.ProtocolResponseWithError>;
+
     /**
      * Returns all browser cookies. Depending on the backend support, will return detailed cookie
      * information in the `cookies` field.
@@ -4293,6 +4300,11 @@ declare namespace ProtocolProxyApi {
      */
     invoke_getCategories(): Promise<Protocol.Tracing.GetCategoriesResponse>;
 
+    /**
+     * Return a descriptor for all available tracing categories.
+     */
+    invoke_getTrackEventDescriptor(): Promise<Protocol.Tracing.GetTrackEventDescriptorResponse>;
+
     /**
      * Record a clock sync marker in the trace.
      */

package/front_end/generated/protocol.ts

@@ -10001,6 +10001,17 @@ export namespace Network {
     VeryHigh = 'VeryHigh',
   }
 
+  /**
+   * The render blocking behavior of a resource request.
+   */
+  export const enum RenderBlockingBehavior {
+    Blocking = 'Blocking',
+    InBodyParserBlocking = 'InBodyParserBlocking',
+    NonBlocking = 'NonBlocking',
+    NonBlockingDynamic = 'NonBlockingDynamic',
+    PotentiallyBlocking = 'PotentiallyBlocking',
+  }
+
   /**
    * Post data entry for HTTP request
    */
@@ -11571,11 +11582,24 @@ export namespace Network {
     /**
      * Enable storing response bodies outside of renderer, so that these survive
      * a cross-process navigation. Requires maxTotalBufferSize to be set.
-     * Currently defaults to false.
+     * Currently defaults to false. This field is being deprecated in favor of the dedicated
+     * configureDurableMessages command, due to the possibility of deadlocks when awaiting
+     * Network.enable before issuing Runtime.runIfWaitingForDebugger.
      */
     enableDurableMessages?: boolean;
   }
 
+  export interface ConfigureDurableMessagesRequest {
+    /**
+     * Buffer size in bytes to use when preserving network payloads (XHRs, etc).
+     */
+    maxTotalBufferSize?: integer;
+    /**
+     * Per-resource buffer size in bytes to use when preserving network payloads (XHRs, etc).
+     */
+    maxResourceBufferSize?: integer;
+  }
+
   export interface GetAllCookiesResponse extends ProtocolResponseWithError {
     /**
      * Array of cookie objects.
@@ -12143,6 +12167,10 @@ export namespace Network {
      * Whether the request is initiated by a user gesture. Defaults to false.
      */
     hasUserGesture?: boolean;
+    /**
+     * The render blocking behavior of the request.
+     */
+    renderBlockingBehavior?: RenderBlockingBehavior;
   }
 
   /**
@@ -13738,7 +13766,9 @@ export namespace Page {
     LanguageDetector = 'language-detector',
     LanguageModel = 'language-model',
     LocalFonts = 'local-fonts',
+    LocalNetwork = 'local-network',
     LocalNetworkAccess = 'local-network-access',
+    LoopbackNetwork = 'loopback-network',
     Magnetometer = 'magnetometer',
     ManualText = 'manual-text',
     MediaPlaybackWhileNotVisible = 'media-playback-while-not-visible',
@@ -18826,6 +18856,13 @@ export namespace Tracing {
     categories: string[];
   }
 
+  export interface GetTrackEventDescriptorResponse extends ProtocolResponseWithError {
+    /**
+     * Base64-encoded serialized perfetto.protos.TrackEventDescriptor protobuf message.
+     */
+    descriptor: binary;
+  }
+
   export interface RecordClockSyncMarkerRequest {
     /**
      * The ID of this clock sync marker

package/front_end/models/ai_assistance/agents/StylingAgent.ts

@@ -219,7 +219,7 @@ export class NodeContext extends ConversationContext<SDK.DOMModel.DOMNode> {
         {title: 'Why does this element scroll?', jslogContext: 'scroll-why'},
       ];
     }
-    if (layoutProps.isContainer) {
+    if (layoutProps.containerType) {
       return [
         {title: 'What are container queries?', jslogContext: 'container-what'},
         {title: 'How do I use container-type?', jslogContext: 'container-how'},

package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.ts

@@ -13,12 +13,13 @@ import {bytes, millis} from './UnitFormatters.js';
 /**
  * For a given frame ID and navigation ID, returns the LCP Event and the LCP Request, if the resource was an image.
  */
-function getLCPData(parsedTrace: Trace.TraceModel.ParsedTrace, frameId: string, navigationId: string): {
+function getLCPData(
+    parsedTrace: Trace.TraceModel.ParsedTrace, frameId: string, navigation: Trace.Types.Events.NavigationStart): {
   lcpEvent: Trace.Types.Events.LargestContentfulPaintCandidate,
   metricScore: Trace.Handlers.ModelHandlers.PageLoadMetrics.LCPMetricScore,
   lcpRequest?: Trace.Types.Events.SyntheticNetworkRequest,
 }|null {
-  const navMetrics = parsedTrace.data.PageLoadMetrics.metricScoresByFrameId.get(frameId)?.get(navigationId);
+  const navMetrics = parsedTrace.data.PageLoadMetrics.metricScoresByFrameId.get(frameId)?.get(navigation);
   if (!navMetrics) {
     return null;
   }
@@ -28,13 +29,16 @@ function getLCPData(parsedTrace: Trace.TraceModel.ParsedTrace, frameId: string,
     return null;
   }
   const lcpEvent = metric?.event;
-  if (!lcpEvent || !Trace.Types.Events.isLargestContentfulPaintCandidate(lcpEvent)) {
+  if (!lcpEvent || !Trace.Types.Events.isAnyLargestContentfulPaintCandidate(lcpEvent)) {
     return null;
   }
 
+  const navigationId = navigation.args.data?.navigationId;
+
   return {
     lcpEvent,
-    lcpRequest: parsedTrace.data.LargestImagePaint.lcpRequestByNavigationId.get(navigationId),
+    lcpRequest: navigationId ? parsedTrace.data.LargestImagePaint.lcpRequestByNavigationId.get(navigationId) :
+                               undefined,
     metricScore: metric,
   };
 }
@@ -89,15 +93,15 @@ export class PerformanceInsightFormatter {
    * Information about LCP which we pass to the LLM for all insights that relate to LCP.
    */
   #lcpMetricSharedContext(): string {
-    if (!this.#insight.navigationId) {
+    if (!this.#insight.navigation) {
       // No navigation ID = no LCP.
       return '';
     }
-    if (!this.#insight.frameId || !this.#insight.navigationId) {
+    if (!this.#insight.frameId || !this.#insight.navigation) {
       return '';
     }
 
-    const data = getLCPData(this.#parsedTrace, this.#insight.frameId, this.#insight.navigationId);
+    const data = getLCPData(this.#parsedTrace, this.#insight.frameId, this.#insight.navigation);
     if (!data) {
       return '';
     }

package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.snapshot.txt

@@ -374,17 +374,17 @@ This is the bottom-up summary for the entire trace. Only the top 20 activities (
 - self: 29 ms, total: 32 ms, source: clearTimeout
 - self: 27 ms, total: 50 ms, source: Parse HTML
 - self: 18 ms, total: 19 ms, source: aC (url: https://s.yimg.com/aaq/f10d509c/d1irmdsmbztlvx.js, line: 0, column: 19068)
-- self: 18 ms, total: 186 ms, source: (anonymous) (url: https://s.yimg.com/aaq/prebid/prebid-2.0.js, line: 5, column: 1)
 - self: 16 ms, total: 226 ms, source: Function call
-- self: 12 ms, total: 163 ms, source: (anonymous) (url: https://s.yimg.com/aaq/f10d509c/d1irmdsmbztlvx.js, line: 0, column: 0)
-- self: 12 ms, total: 83 ms, source: (anonymous) (url: https://cdn.taboola.com/libtrc/yahooweb-network/loader.js, line: 0, column: 9)
 - self: 11 ms, total: 12 ms, source: fetch
 - self: 11 ms, total: 12 ms, source: evaluate
 - self: 10 ms, total: 212 ms, source: Run microtasks
-- self: 9 ms, total: 19 ms, source: (anonymous) (url: https://s.yimg.com/du/ay/wnsrvbjmeprtfrnfx.js, line: 0, column: 0)
 - self: 9 ms, total: 10 ms, source: Minor GC
 - self: 8 ms, total: 226 ms, source: Evaluate script
-- self: 7 ms, total: 109 ms, source: n (url: https://s.yimg.com/aaq/prebid/prebid-2.0.js, line: 11, column: 4263)
+- self: 7 ms, total: 7 ms, source: (anonymous) (url: https://s.yimg.com/du/ay/wnsrvbjmeprtfrnfx.js, line: 111, column: 4705)
+- self: 7 ms, total: 9 ms, source: appendChild
+- self: 6 ms, total: 8 ms, source: Ei (url: https://s.yimg.com/aaq/benji/benji-2.2.99.js, line: 0, column: 24493)
+- self: 6 ms, total: 6 ms, source: Il (url: https://securepubads.g.doubleclick.net/pagead/managed/js/gpt/m202503250101/pubads_impl.js, line: 32, column: 58003)
+- self: 5 ms, total: 7 ms, source: n (url: https://s.yimg.com/aaq/prebid/prebid-2.0.js, line: 11, column: 3881)
 
 # Third parties
 
@@ -970,28 +970,29 @@ Content:
 4;p-73704-775-2074-419;(anonymous);7.2;0.1;0;5;0;9
 5;p-73704-775-2075-420;(anonymous);7.1;;0;6;0;200
 6;p-73704-775-2075-421;(anonymous);7.1;2.6;0;7;0;231
-7;p-73704-775-2095-422;(anonymous);4.5;1.3;0;8-19;0;292
-8;p-73704-775-2095-423;(anonymous);0.5;0.1;0;19-21;0;756
+7;p-73704-775-2095-422;(anonymous);4.5;1.3;0;8-20;0;292
+8;p-73704-775-2095-423;(anonymous);0.1;0.1;0;;0;756
 9;p-73704-775-2097-424;Et;0.1;0.1;0;;0;10766
-10;p-73704-775-2098-425;St;0.4;0.2;0;21;0;10904
+10;p-73704-775-2098-425;St;0.4;0.2;0;20;0;10904
 11;p-73704-775-2105-427;k;0.4;0.4;0;;0;5125
-12;p-73704-775-2108-428;Go;0.1;;0;22;0;68523
-13;p-73704-775-2109-430;Oi;0.4;0.2;0;23;0;38264
+12;p-73704-775-2108-428;Go;0.1;;0;21;0;68523
+13;p-73704-775-2109-430;Oi;0.4;0.2;0;22;0;38264
 14;p-73704-775-2115-432;tl;0.3;0.3;0;;0;154217
-15;p-73704-775-2118-433;ul;0.6;0.5;0;24;0;155034
+15;p-73704-775-2118-433;ul;0.6;0.5;0;23;0;155034
 16;p-73704-775-2121-435;cl;0.1;0.1;0;;0;155107
-17;p-73704-775-2123-436;hl;0.1;;0;25;0;155309
+17;p-73704-775-2123-436;hl;0.1;;0;24;0;155309
 18;p-73704-775-2124-439;sl;0.1;0.1;0;;0;154927
-19;p-73704-775-2127-441;hl;0.1;0.1;0;;0;155309
-20;p-73704-775-2128-442;registerService;0.2;;1;26-28;0;9441
-21;p-73704-775-2099-426;vt;0.2;0.2;0;;0;10155
-22;p-73704-775-2108-429;Mo;0.1;0.1;0;;0;66493
-23;p-73704-775-2111-431;vi;0.1;0.1;0;;0;37138
-24;p-73704-775-2118-434;ll;0.1;0.1;0;;0;155345
-25;p-73704-775-2123-437;ll;0.1;;0;28;0;155345
-26;p-73704-775-2128-443;u;0.1;0.1;1;;0;10091
-27;p-73704-775-2129-444;d;0.1;0.1;1;;0;595
-28;p-73704-775-2123-438;get prototype;0.1;0.1;;;;
+19;p-73704-775-2127-440;(anonymous);0.3;;0;25-27;0;161805
+20;p-73704-775-2099-426;vt;0.2;0.2;0;;0;10155
+21;p-73704-775-2108-429;Mo;0.1;0.1;0;;0;66493
+22;p-73704-775-2111-431;vi;0.1;0.1;0;;0;37138
+23;p-73704-775-2118-434;ll;0.1;0.1;0;;0;155345
+24;p-73704-775-2123-437;ll;0.1;;0;27;0;155345
+25;p-73704-775-2127-441;hl;0.1;0.1;0;;0;155309
+26;p-73704-775-2128-442;registerService;0.2;;1;28-30;0;9441
+27;p-73704-775-2123-438;get prototype;0.1;0.1;;;;
+28;p-73704-775-2128-443;u;0.1;0.1;1;;0;10091
+29;p-73704-775-2129-444;d;0.1;0.1;1;;0;595
 
 IMPORTANT: Never show eventKey to the user.
 

package/front_end/models/badges/UserBadges.ts

@@ -14,12 +14,18 @@ import {StarterBadge} from './StarterBadge.js';
 
 type BadgeClass = new (badgeContext: BadgeContext) => Badge;
 
+export const enum BadgeTriggerReason {
+  AWARD = 'Award',
+  STARTER_BADGE_SETTINGS_NUDGE = 'StarterBadgeSettingsNudge',
+  STARTER_BADGE_PROFILE_NUDGE = 'StarterBadgeProfileNudge',
+}
+
 export const enum Events {
   BADGE_TRIGGERED = 'BadgeTriggered',
 }
 
 export interface EventTypes {
-  [Events.BADGE_TRIGGERED]: Badge;
+  [Events.BADGE_TRIGGERED]: {badge: Badge, reason: BadgeTriggerReason};
 }
 
 const SNOOZE_TIME_MS = 24 * 60 * 60 * 1000;  // 24 hours
@@ -97,24 +103,50 @@ export class UserBadges extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
     this.#badgeActionEventTarget.dispatchEventToListeners(action);
   }
 
+  async #resolveBadgeTriggerReason(badge: Badge): Promise<BadgeTriggerReason|undefined> {
+    if (!badge.isStarterBadge) {
+      return BadgeTriggerReason.AWARD;
+    }
+
+    const getProfileResponse = await Host.GdpClient.GdpClient.instance().getProfile();
+    // The `getProfile` call failed and returned a `null`.
+    // For that case, we don't show anything.
+    if (!getProfileResponse) {
+      return;
+    }
+
+    const hasGdpProfile = Boolean(getProfileResponse.profile);
+    const receiveBadgesSettingEnabled = Boolean(this.#receiveBadgesSetting.get());
+
+    // If the user already has a GDP profile and the receive badges setting enabled,
+    // starter badge behaves as if it's an activity based badge.
+    if (hasGdpProfile && receiveBadgesSettingEnabled) {
+      return BadgeTriggerReason.AWARD;
+    }
+
+    if (this.#isStarterBadgeDismissed() || this.#isStarterBadgeSnoozed()) {
+      return;
+    }
+
+    // If the user already has a GDP profile and the receive badges setting disabled,
+    // starter badge behaves as a nudge for opting into receiving badges.
+    if (hasGdpProfile && !receiveBadgesSettingEnabled) {
+      return BadgeTriggerReason.STARTER_BADGE_SETTINGS_NUDGE;
+    }
+
+    // The user does not have a GDP profile, starter badge acts as a nudge for creating a GDP profile.
+    return BadgeTriggerReason.STARTER_BADGE_PROFILE_NUDGE;
+  }
+
   async #onTriggerBadge(badge: Badge, opts?: TriggerOptions): Promise<void> {
     const triggerTime = Date.now();
-    let shouldAwardBadge = false;
-    // By default, we award non-starter badges directly when they are triggered.
-    if (!badge.isStarterBadge) {
-      shouldAwardBadge = true;
-    } else {
-      const getProfileResponse = await Host.GdpClient.GdpClient.instance().getProfile();
-      const receiveBadgesSettingEnabled = Boolean(this.#receiveBadgesSetting.get());
-      // If there is a GDP profile and the user has enabled receiving badges, we award the starter badge as well.
-      if (getProfileResponse?.profile && receiveBadgesSettingEnabled && !this.#isStarterBadgeDismissed() &&
-          !this.#isStarterBadgeSnoozed()) {
-        shouldAwardBadge = true;
-      }
+    const reason = await this.#resolveBadgeTriggerReason(badge);
+
+    if (!reason) {
+      return;
     }
 
-    // Awarding was needed and not successful, we don't show the notification
-    if (shouldAwardBadge) {
+    if (reason === BadgeTriggerReason.AWARD) {
       const result = await Host.GdpClient.GdpClient.instance().createAward({name: badge.name});
       if (!result) {
         return;
@@ -125,7 +157,7 @@ export class UserBadges extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
     // We want to add exactly 1.5 second delay between the trigger action & the notification.
     const delay = opts?.immediate ? 0 : Math.max(DELAY_BEFORE_TRIGGER - timeElapsedAfterTriggerCall, 0);
     setTimeout(() => {
-      this.dispatchEventToListeners(Events.BADGE_TRIGGERED, badge);
+      this.dispatchEventToListeners(Events.BADGE_TRIGGERED, {badge, reason});
     }, delay);
   }
 

package/front_end/models/greendev/Prototypes.ts

@@ -12,6 +12,7 @@ export interface GreenDevSettings {
   inlineWidgets: Common.Settings.Setting<boolean>;
   artifactViewer: Common.Settings.Setting<boolean>;
   aiAnnotations: Common.Settings.Setting<boolean>;
+  copyToGemini: Common.Settings.Setting<boolean>;
 }
 
 export class Prototypes {
@@ -51,6 +52,10 @@ export class Prototypes {
 
     const artifactViewer =
         settings.createSetting('greendev-artifact-viewer-enabled', false, Common.Settings.SettingStorageType.LOCAL);
-    return {inDevToolsFloaty, inlineWidgets, aiAnnotations, artifactViewer};
+
+    const copyToGemini =
+        settings.createSetting('greendev-copy-to-gemini-enabled', false, Common.Settings.SettingStorageType.LOCAL);
+
+    return {inDevToolsFloaty, inlineWidgets, aiAnnotations, artifactViewer, copyToGemini};
   }
 }

package/front_end/models/trace/LanternComputationData.ts

@@ -10,14 +10,15 @@ import type * as Types from './types/types.js';
 
 type NetworkRequest = Lantern.Types.NetworkRequest<Types.Events.SyntheticNetworkRequest>;
 
-function createProcessedNavigation(data: Handlers.Types.HandlerData, frameId: string, navigationId: string):
-    Lantern.Types.Simulation.ProcessedNavigation {
+function createProcessedNavigation(
+    data: Handlers.Types.HandlerData, frameId: string,
+    navigation: Types.Events.NavigationStart): Lantern.Types.Simulation.ProcessedNavigation {
   const scoresByNav = data.PageLoadMetrics.metricScoresByFrameId.get(frameId);
   if (!scoresByNav) {
     throw new Lantern.Core.LanternError('missing metric scores for frame');
   }
 
-  const scores = scoresByNav.get(navigationId);
+  const scores = scoresByNav.get(navigation);
   if (!scores) {
     throw new Lantern.Core.LanternError('missing metric scores for specified navigation');
   }

package/front_end/models/trace/Processor.ts

@@ -268,7 +268,8 @@ export class TraceProcessor extends EventTarget {
 
   #createLanternContext(
       data: Handlers.Types.HandlerData, traceEvents: readonly Types.Events.Event[], frameId: string,
-      navigationId: string, options: Types.Configuration.ParseOptions): Insights.Types.LanternContext|undefined {
+      navigation: Types.Events.NavigationStart,
+      options: Types.Configuration.ParseOptions): Insights.Types.LanternContext|undefined {
     // Check for required handlers.
     if (!data.NetworkRequests || !data.Workers || !data.PageLoadMetrics) {
       return;
@@ -278,7 +279,7 @@ export class TraceProcessor extends EventTarget {
     }
 
     const navStarts = data.Meta.navigationsByFrameId.get(frameId);
-    const navStartIndex = navStarts?.findIndex(n => n.args.data?.navigationId === navigationId);
+    const navStartIndex = navStarts?.findIndex(n => n === navigation);
     if (!navStarts || navStartIndex === undefined || navStartIndex === -1) {
       throw new Lantern.Core.LanternError('Could not find navigation start');
     }
@@ -295,7 +296,7 @@ export class TraceProcessor extends EventTarget {
 
     const requests = LanternComputationData.createNetworkRequests(trace, data, startTime, endTime);
     const graph = LanternComputationData.createGraph(requests, trace, data);
-    const processedNavigation = LanternComputationData.createProcessedNavigation(data, frameId, navigationId);
+    const processedNavigation = LanternComputationData.createProcessedNavigation(data, frameId, navigation);
 
     const networkAnalysis = Lantern.Core.NetworkAnalyzer.analyze(requests);
     if (!networkAnalysis) {
@@ -455,7 +456,7 @@ export class TraceProcessor extends EventTarget {
         model.frameId = context.frameId;
         const navId = context.navigation?.args.data?.navigationId;
         if (navId) {
-          model.navigationId = navId;
+          model.navigation = context.navigation;
         }
         model.createOverlays = () => {
           // @ts-expect-error: model is a union of all possible insight model types.
@@ -571,7 +572,7 @@ export class TraceProcessor extends EventTarget {
     let lantern: Insights.Types.LanternContext|undefined;
     try {
       options.logger?.start('insights:createLanternContext');
-      lantern = this.#createLanternContext(data, traceEvents, frameId, navigationId, options);
+      lantern = this.#createLanternContext(data, traceEvents, frameId, navigation, options);
     } catch (e) {
       // Handle Lantern errors gracefully
       // Don't allow an error in constructing the Lantern graphs to break the rest of the trace processor.

package/front_end/models/trace/Styles.ts

@@ -879,6 +879,11 @@ export function maybeInitSylesMap(): EventStylesMap {
         defaultCategoryStyles.rendering,
         true,
         ),
+    [Types.Events.Name.MARK_LCP_CANDIDATE_FOR_SOFT_NAVIGATION]: new TimelineRecordStyle(
+        i18nString(UIStrings.largestContentfulPaint),
+        defaultCategoryStyles.rendering,
+        true,
+        ),
 
     [Types.Events.Name.TIME_STAMP]:
         new TimelineRecordStyle(i18nString(UIStrings.timestamp), defaultCategoryStyles.scripting),
@@ -1118,7 +1123,7 @@ export function markerDetailsForEvent(event: Types.Events.Event): {
     color = 'var(--sys-color-green-bright)';
     title = Handlers.ModelHandlers.PageLoadMetrics.MetricName.FCP;
   }
-  if (Types.Events.isLargestContentfulPaintCandidate(event)) {
+  if (Types.Events.isAnyLargestContentfulPaintCandidate(event)) {
     color = 'var(--sys-color-green)';
     title = Handlers.ModelHandlers.PageLoadMetrics.MetricName.LCP;
   }
@@ -1126,6 +1131,10 @@ export function markerDetailsForEvent(event: Types.Events.Event): {
     color = 'var(--color-text-primary)';
     title = Handlers.ModelHandlers.PageLoadMetrics.MetricName.NAV;
   }
+  if (Types.Events.isSoftNavigationStart(event)) {
+    color = 'var(--sys-color-blue)';
+    title = Handlers.ModelHandlers.PageLoadMetrics.MetricName.SOFT_NAV;
+  }
   if (Types.Events.isMarkDOMContent(event)) {
     color = 'var(--color-text-disabled)';
     title = Handlers.ModelHandlers.PageLoadMetrics.MetricName.DCL;

package/front_end/models/trace/extras/TraceTree.ts

@@ -687,7 +687,7 @@ export function generateEventID(event: Types.Events.Event): string {
         SamplesIntegrator.nativeGroup(event.callFrame.functionName) :
         event.callFrame.functionName;
     const location = event.callFrame.scriptId || event.callFrame.url || '';
-    return `f:${name}@${location}`;
+    return `f:${name}@${location}:${event.callFrame.lineNumber}:${event.callFrame.columnNumber}`;
   }
 
   if (Types.Events.isConsoleTimeStamp(event) && event.args.data) {

package/front_end/models/trace/handlers/LargestImagePaintHandler.ts

@@ -55,9 +55,9 @@ export async function finalize(): Promise<void> {
   const metricScoresByFrameId = pageLoadMetricsData().metricScoresByFrameId;
 
   for (const [navigationId, navigation] of navigationsByNavigationId) {
-    const lcpMetric = metricScoresByFrameId.get(navigation.args.frame)?.get(navigationId)?.get(MetricName.LCP);
+    const lcpMetric = metricScoresByFrameId.get(navigation.args.frame)?.get(navigation)?.get(MetricName.LCP);
     const lcpEvent = lcpMetric?.event;
-    if (!lcpEvent || !Types.Events.isLargestContentfulPaintCandidate(lcpEvent)) {
+    if (!lcpEvent || !Types.Events.isAnyLargestContentfulPaintCandidate(lcpEvent)) {
       continue;
     }
 

package/front_end/models/trace/handlers/MetaHandler.ts

@@ -59,6 +59,7 @@ let traceBounds: Types.Timing.TraceWindowMicro = makeNewTraceBounds();
  */
 let navigationsByFrameId = new Map<string, Types.Events.NavigationStart[]>();
 let navigationsByNavigationId = new Map<string, Types.Events.NavigationStart>();
+let softNavigationsById = new Map<number, Types.Events.SoftNavigationStart>();
 let finalDisplayUrlByNavigationId = new Map<string, string>();
 let mainFrameNavigations: Types.Events.NavigationStart[] = [];
 
@@ -92,6 +93,7 @@ const CHROME_WEB_TRACE_EVENTS = new Set([
 export function reset(): void {
   navigationsByFrameId = new Map();
   navigationsByNavigationId = new Map();
+  softNavigationsById = new Map();
   finalDisplayUrlByNavigationId = new Map();
   processNames = new Map();
   mainFrameNavigations = [];
@@ -324,6 +326,10 @@ export function handleEvent(event: Types.Events.Event): void {
     return;
   }
 
+  if (Types.Events.isSoftNavigationStart(event)) {
+    softNavigationsById.set(event.args.context.performanceTimelineNavigationId, event);
+  }
+
   // Update `finalDisplayUrlByNavigationId` to reflect the latest redirect for each navigation.
   if (Types.Events.isResourceSendRequest(event)) {
     if (event.args.data.resourceType !== 'Document') {
@@ -445,7 +451,14 @@ export interface MetaHandlerData {
   browserThreadId: Types.Events.ThreadID;
   gpuProcessId: Types.Events.ProcessID;
   navigationsByFrameId: Map<string, Types.Events.NavigationStart[]>;
+  /**
+   * This does not include soft navigations.
+   *
+   * TODO(crbug.com/414468047): include soft navs here, so that
+   * PageLoadMetricsHandler and insights can use this map for all navigation types.
+   */
   navigationsByNavigationId: Map<string, Types.Events.NavigationStart>;
+  softNavigationsById: Map<number, Types.Events.SoftNavigationStart>;
   /**
    * The user-visible URL displayed to users in the address bar.
    * This captures:
@@ -514,6 +527,7 @@ export function data(): MetaHandlerData {
     mainFrameURL,
     navigationsByFrameId,
     navigationsByNavigationId,
+    softNavigationsById,
     finalDisplayUrlByNavigationId,
     threadsInProcess,
     rendererProcessesByFrame: rendererProcessesByFrameId,