chrome-devtools-frontend 1.0.1555430 → 1.0.1558690

package/front_end/panels/linear_memory_inspector/components/LinearMemoryValueInterpreter.ts

@@ -1,7 +1,6 @@
 // Copyright 2020 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable @devtools/no-lit-render-outside-of-view */
 
 import '../../../ui/kit/kit.js';
 
@@ -35,42 +34,149 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const {render, html} = Lit;
 const {widgetConfig} = UI.Widget;
 
-export interface LinearMemoryValueInterpreterData {
-  value: ArrayBuffer;
-  valueTypes: Set<ValueType>;
+export interface ViewInput {
   endianness: Endianness;
-  valueTypeModes?: Map<ValueType, ValueTypeMode>;
+  buffer: ArrayBuffer;
+  valueTypes: Set<ValueType>;
+  valueTypeModes: Map<ValueType, ValueTypeMode>;
   memoryLength: number;
+  showSettings: boolean;
   onValueTypeModeChange: (type: ValueType, mode: ValueTypeMode) => void;
   onJumpToAddressClicked: (address: number) => void;
   onEndiannessChanged: (endianness: Endianness) => void;
   onValueTypeToggled: (type: ValueType, checked: boolean) => void;
+  onSettingsToggle: () => void;
 }
 
-export class LinearMemoryValueInterpreter extends HTMLElement {
-  readonly #shadow = this.attachShadow({mode: 'open'});
-  #onValueTypeModeChange: (type: ValueType, mode: ValueTypeMode) => void = () => {};
-  #onJumpToAddressClicked: (address: number) => void = () => {};
-  #onEndiannessChanged: (endianness: Endianness) => void = () => {};
-  #onValueTypeToggled: (type: ValueType, checked: boolean) => void = () => {};
+function renderEndiannessSetting(
+    onEndiannessChanged: (endianness: Endianness) => void, currentEndiannes: Endianness): Lit.TemplateResult {
+  // Disabled until https://crbug.com/1079231 is fixed.
+  // clang-format off
+    return html`
+    <label data-endianness-setting="true" title=${i18nString(UIStrings.changeEndianness)}>
+      <select
+        jslog=${VisualLogging.dropDown('linear-memory-inspector.endianess').track({change: true})}
+        style="border: none;"
+        data-endianness="true" @change=${(e: Event) => onEndiannessChanged((e.target as HTMLSelectElement).value as Endianness)}>
+        ${[Endianness.LITTLE, Endianness.BIG].map(endianness => {
+            return html`<option value=${endianness} .selected=${currentEndiannes === endianness}
+            jslog=${VisualLogging.item(Platform.StringUtilities.toKebabCase(endianness)).track({click: true})}>${
+                i18n.i18n.lockedString(endianness)}</option>`;
+        })}
+      </select>
+    </label>
+    `;
+  // clang-format on
+}
+
+export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLElement): void => {
+  // Disabled until https://crbug.com/1079231 is fixed.
+  // clang-format off
+  render(html`
+    <style>${UI.inspectorCommonStyles}</style>
+    <style>${linearMemoryValueInterpreterStyles}</style>
+    <div class="value-interpreter">
+      <div class="settings-toolbar">
+        ${renderEndiannessSetting(input.onEndiannessChanged, input.endianness)}
+        <devtools-button data-settings="true" class="toolbar-button ${input.showSettings ? '' : 'disabled'}"
+            title=${i18nString(UIStrings.toggleValueTypeSettings)} @click=${input.onSettingsToggle}
+            jslog=${VisualLogging.toggleSubpane('linear-memory-inspector.toggle-value-settings').track({ click: true })}
+            .iconName=${'gear'}
+            .toggledIconName=${'gear-filled'}
+            .toggleType=${Buttons.Button.ToggleType.PRIMARY}
+            .variant=${Buttons.Button.Variant.ICON_TOGGLE}
+        ></devtools-button>
+      </div>
+      <span class="divider"></span>
+      <div>
+        ${input.showSettings ?
+      html`
+            <devtools-widget .widgetConfig=${widgetConfig(ValueInterpreterSettings, {
+              valueTypes: input.valueTypes, onToggle: input.onValueTypeToggled
+            })}>
+            </devtools-widget>` :
+      html`
+            <devtools-widget .widgetConfig=${widgetConfig(ValueInterpreterDisplay, {
+              buffer: input.buffer,
+              valueTypes: input.valueTypes,
+              endianness: input.endianness,
+              valueTypeModes: input.valueTypeModes,
+              memoryLength: input.memoryLength,
+              onValueTypeModeChange: input.onValueTypeModeChange,
+              onJumpToAddressClicked: input.onJumpToAddressClicked,
+            })}>
+            </devtools-widget>`}
+      </div>
+    </div>
+  `,
+    target,
+  );
+  // clang-format on
+};
+
+export type View = typeof DEFAULT_VIEW;
+
+export class LinearMemoryValueInterpreter extends UI.Widget.Widget {
+  readonly #view: View;
   #endianness = Endianness.LITTLE;
   #buffer = new ArrayBuffer(0);
   #valueTypes = new Set<ValueType>();
   #valueTypeModeConfig = new Map<ValueType, ValueTypeMode>();
   #memoryLength = 0;
   #showSettings = false;
+  #onValueTypeModeChange: (type: ValueType, mode: ValueTypeMode) => void = () => {};
+  #onJumpToAddressClicked: (address: number) => void = () => {};
+  #onEndiannessChanged: (endianness: Endianness) => void = () => {};
+  #onValueTypeToggled: (type: ValueType, checked: boolean) => void = () => {};
+
+  constructor(element?: HTMLElement, view: View = DEFAULT_VIEW) {
+    super(element);
+    this.#view = view;
+  }
+
+  set buffer(value: ArrayBuffer) {
+    this.#buffer = value;
+    this.requestUpdate();
+  }
 
-  set data(data: LinearMemoryValueInterpreterData) {
-    this.#endianness = data.endianness;
-    this.#buffer = data.value;
-    this.#valueTypes = data.valueTypes;
-    this.#valueTypeModeConfig = data.valueTypeModes || new Map();
-    this.#memoryLength = data.memoryLength;
-    this.#onValueTypeModeChange = data.onValueTypeModeChange;
-    this.#onJumpToAddressClicked = data.onJumpToAddressClicked;
-    this.#onEndiannessChanged = data.onEndiannessChanged;
-    this.#onValueTypeToggled = data.onValueTypeToggled;
-    this.#render();
+  get buffer(): ArrayBuffer {
+    return this.#buffer;
+  }
+
+  set valueTypes(value: Set<ValueType>) {
+    this.#valueTypes = value;
+    this.requestUpdate();
+  }
+
+  get valueTypes(): Set<ValueType> {
+    return this.#valueTypes;
+  }
+
+  set valueTypeModes(value: Map<ValueType, ValueTypeMode>) {
+    this.#valueTypeModeConfig = value;
+    this.requestUpdate();
+  }
+
+  get valueTypeModes(): Map<ValueType, ValueTypeMode> {
+    return this.#valueTypeModeConfig;
+  }
+
+  set endianness(value: Endianness) {
+    this.#endianness = value;
+    this.requestUpdate();
+  }
+
+  get endianness(): Endianness {
+    return this.#endianness;
+  }
+
+  set memoryLength(value: number) {
+    this.#memoryLength = value;
+    this.requestUpdate();
+  }
+
+  get memoryLength(): number {
+    return this.#memoryLength;
   }
 
   get onValueTypeModeChange(): (type: ValueType, mode: ValueTypeMode) => void {
@@ -79,7 +185,7 @@ export class LinearMemoryValueInterpreter extends HTMLElement {
 
   set onValueTypeModeChange(value: (type: ValueType, mode: ValueTypeMode) => void) {
     this.#onValueTypeModeChange = value;
-    this.#render();
+    this.requestUpdate();
   }
 
   get onJumpToAddressClicked(): (address: number) => void {
@@ -88,7 +194,7 @@ export class LinearMemoryValueInterpreter extends HTMLElement {
 
   set onJumpToAddressClicked(value: (address: number) => void) {
     this.#onJumpToAddressClicked = value;
-    this.#render();
+    this.requestUpdate();
   }
 
   get onEndiannessChanged(): (endianness: Endianness) => void {
@@ -97,7 +203,7 @@ export class LinearMemoryValueInterpreter extends HTMLElement {
 
   set onEndiannessChanged(value: (endianness: Endianness) => void) {
     this.#onEndiannessChanged = value;
-    this.#render();
+    this.performUpdate();
   }
 
   get onValueTypeToggled(): (type: ValueType, checked: boolean) => void {
@@ -106,83 +212,28 @@ export class LinearMemoryValueInterpreter extends HTMLElement {
 
   set onValueTypeToggled(value: (type: ValueType, checked: boolean) => void) {
     this.#onValueTypeToggled = value;
-    this.#render();
-  }
-
-  #render(): void {
-    // Disabled until https://crbug.com/1079231 is fixed.
-    // clang-format off
-    render(html`
-      <style>${UI.inspectorCommonStyles}</style>
-      <style>${linearMemoryValueInterpreterStyles}</style>
-      <div class="value-interpreter">
-        <div class="settings-toolbar">
-          ${this.#renderEndiannessSetting()}
-          <devtools-button data-settings="true" class="toolbar-button ${this.#showSettings ? '' : 'disabled'}"
-              title=${i18nString(UIStrings.toggleValueTypeSettings)} @click=${this.#onSettingsToggle}
-              jslog=${VisualLogging.toggleSubpane('linear-memory-inspector.toggle-value-settings').track({click: true})}
-              .iconName=${'gear'}
-              .toggledIconName=${'gear-filled'}
-              .toggleType=${Buttons.Button.ToggleType.PRIMARY}
-              .variant=${Buttons.Button.Variant.ICON_TOGGLE}
-          ></devtools-button>
-        </div>
-        <span class="divider"></span>
-        <div>
-          ${this.#showSettings ?
-            html`
-              <devtools-widget .widgetConfig=${widgetConfig(ValueInterpreterSettings, {
-                valueTypes: this.#valueTypes, onToggle: this.#onValueTypeToggled })}>
-              </devtools-widget>` :
-            html`
-              <devtools-widget .widgetConfig=${widgetConfig(ValueInterpreterDisplay, {
-                  buffer: this.#buffer,
-                  valueTypes: this.#valueTypes,
-                  endianness: this.#endianness,
-                  valueTypeModes: this.#valueTypeModeConfig,
-                  memoryLength: this.#memoryLength,
-                  onValueTypeModeChange: this.#onValueTypeModeChange,
-                  onJumpToAddressClicked: this.#onJumpToAddressClicked,
-                })}>
-              </devtools-widget>`}
-        </div>
-      </div>
-    `,
-      this.#shadow, { host: this },
-    );
-    // clang-format on
+    this.performUpdate();
   }
 
-  #renderEndiannessSetting(): Lit.TemplateResult {
-    // Disabled until https://crbug.com/1079231 is fixed.
-    // clang-format off
-    return html`
-    <label data-endianness-setting="true" title=${i18nString(UIStrings.changeEndianness)}>
-      <select
-        jslog=${VisualLogging.dropDown('linear-memory-inspector.endianess').track({change: true})}
-        style="border: none;"
-        data-endianness="true" @change=${(e: Event) => this.#onEndiannessChanged((e.target as HTMLSelectElement).value as Endianness)}>
-        ${[Endianness.LITTLE, Endianness.BIG].map(endianness => {
-            return html`<option value=${endianness} .selected=${this.#endianness === endianness}
-            jslog=${VisualLogging.item(Platform.StringUtilities.toKebabCase(endianness)).track({click: true})}>${
-                i18n.i18n.lockedString(endianness)}</option>`;
-        })}
-      </select>
-    </label>
-    `;
-    // clang-format on
+  override performUpdate(): void {
+    const viewInput: ViewInput = {
+      endianness: this.#endianness,
+      buffer: this.#buffer,
+      valueTypes: this.#valueTypes,
+      valueTypeModes: this.#valueTypeModeConfig,
+      memoryLength: this.#memoryLength,
+      showSettings: this.#showSettings,
+      onValueTypeModeChange: this.#onValueTypeModeChange,
+      onJumpToAddressClicked: this.#onJumpToAddressClicked,
+      onEndiannessChanged: this.#onEndiannessChanged,
+      onValueTypeToggled: this.#onValueTypeToggled,
+      onSettingsToggle: this.#onSettingsToggle.bind(this),
+    };
+    this.#view(viewInput, undefined, this.contentElement);
   }
 
   #onSettingsToggle(): void {
     this.#showSettings = !this.#showSettings;
-    this.#render();
-  }
-}
-
-customElements.define('devtools-linear-memory-inspector-interpreter', LinearMemoryValueInterpreter);
-
-declare global {
-  interface HTMLElementTagNameMap {
-    'devtools-linear-memory-inspector-interpreter': LinearMemoryValueInterpreter;
+    this.requestUpdate();
   }
 }

package/front_end/panels/linear_memory_inspector/components/LinearMemoryViewer.ts

@@ -47,7 +47,7 @@ const BYTE_GROUP_SIZE = 4;
 export class LinearMemoryViewer extends HTMLElement {
   readonly #shadow = this.attachShadow({mode: 'open'});
 
-  readonly #resizeObserver = new ResizeObserver(() => this.#resize());
+  readonly #resizeObserver = new ResizeObserver(() => requestAnimationFrame(this.#resize.bind(this)));
   #isObservingResize = false;
 
   #memory = new Uint8Array();

package/front_end/panels/linear_memory_inspector/components/linearMemoryValueInterpreter.css

@@ -4,44 +4,46 @@
  * found in the LICENSE file.
  */
 
-:host {
-  flex: auto;
-  display: flex;
-}
+@scope to (devtools-widget > *) {
+  :scope {
+    flex: auto;
+    display: flex;
+  }
 
-.value-interpreter {
-  border: 1px solid var(--sys-color-divider);
-  background-color: var(--sys-color-cdt-base-container);
-  overflow: hidden;
-  width: 400px;
-}
+  .value-interpreter {
+    border: 1px solid var(--sys-color-divider);
+    background-color: var(--sys-color-cdt-base-container);
+    overflow: hidden;
+    width: 400px;
+  }
 
-.settings-toolbar {
-  min-height: 26px;
-  display: flex;
-  flex-wrap: nowrap;
-  justify-content: space-between;
-  padding-left: var(--sys-size-3);
-  padding-right: var(--sys-size-3);
-  align-items: center;
-}
+  .settings-toolbar {
+    min-height: 26px;
+    display: flex;
+    flex-wrap: nowrap;
+    justify-content: space-between;
+    padding-left: var(--sys-size-3);
+    padding-right: var(--sys-size-3);
+    align-items: center;
+  }
 
-.settings-toolbar-button {
-  padding: 0;
-  width: 20px;
-  height: 20px;
-  border: none;
-  outline: none;
-  background-color: transparent;
-}
+  .settings-toolbar-button {
+    padding: 0;
+    width: 20px;
+    height: 20px;
+    border: none;
+    outline: none;
+    background-color: transparent;
+  }
 
-.settings-toolbar-button.active devtools-icon {
-  color: var(--icon-toggled);
-}
+  .settings-toolbar-button.active devtools-icon {
+    color: var(--icon-toggled);
+  }
 
-.divider {
-  display: block;
-  height: 1px;
-  margin-bottom: 12px;
-  background-color: var(--sys-color-divider);
+  .divider {
+    display: block;
+    height: 1px;
+    margin-bottom: 12px;
+    background-color: var(--sys-color-divider);
+  }
 }

package/front_end/panels/network/NetworkLogViewColumns.ts

@@ -31,11 +31,11 @@ const UIStrings = {
   /**
    * @description A context menu item in the Network Log View Columns of the Network panel
    */
-  responseHeaders: 'Response Headers',
+  responseHeaders: 'Response headers',
   /**
    * @description A context menu item in the Network Log View Columns of the Network panel
    */
-  requestHeaders: 'Request Headers',
+  requestHeaders: 'Request headers',
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
@@ -43,19 +43,19 @@ const UIStrings = {
   /**
    * @description Text for the start time of an activity
    */
-  startTime: 'Start Time',
+  startTime: 'Start time',
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  responseTime: 'Response Time',
+  responseTime: 'Response time',
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  endTime: 'End Time',
+  endTime: 'End time',
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  totalDuration: 'Total Duration',
+  totalDuration: 'Total duration',
   /**
    * @description Text for the latency of a task
    */
@@ -99,7 +99,7 @@ const UIStrings = {
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  remoteAddress: 'Remote Address',
+  remoteAddress: 'Remote address',
   /**
    * @description Text that refers to some types
    */
@@ -115,7 +115,7 @@ const UIStrings = {
   /**
    * @description Column header in the Network log view of the Network panel
    */
-  initiatorAddressSpace: 'Initiator Address Space',
+  initiatorAddressSpace: 'Initiator address space',
   /**
    * @description Text for web cookies
    */
@@ -147,7 +147,7 @@ const UIStrings = {
   /**
    * @description Text in Network Log View Columns of the Network panel
    */
-  remoteAddressSpace: 'Remote Address Space',
+  remoteAddressSpace: 'Remote address space',
   /**
    * @description Text to show whether a request is ad-related
    */