chrome-devtools-frontend 1.0.1555174 → 1.0.1555430

package/front_end/panels/timeline/components/insights/BaseInsightComponent.ts

@@ -1,7 +1,6 @@
 // Copyright 2024 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable @devtools/no-imperative-dom-api */
 
 import '../../../../ui/components/markdown_view/markdown_view.js';
 
@@ -70,7 +69,7 @@ interface ViewInput {
   model: InsightModel;
   selected: boolean;
   isAIAssistanceContext: boolean;
-  canShowAskAI: boolean;
+  showAskAI: boolean;
   estimatedSavingsString: string|null;
   estimatedSavingsAriaLabel: string|null;
   renderContent: () => Lit.LitTemplate;
@@ -89,7 +88,7 @@ const DEFAULT_VIEW: View = (input, output, target) => {
     estimatedSavingsString,
     estimatedSavingsAriaLabel,
     isAIAssistanceContext,
-    canShowAskAI,
+    showAskAI,
     dispatchInsightToggle,
     renderContent,
     onHeaderKeyDown,
@@ -122,7 +121,7 @@ const DEFAULT_VIEW: View = (input, output, target) => {
       <div class="insight-body">
         <div class="insight-description">${md(model.description)}</div>
         <div class="insight-content">${content}</div>
-        ${canShowAskAI ? html`
+        ${showAskAI ? html`
           <div class="ask-ai-btn-wrap">
             <devtools-button class="ask-ai"
               .variant=${Buttons.Button.Variant.OUTLINED}
@@ -206,9 +205,6 @@ export abstract class BaseInsightComponent<T extends InsightModel> extends UI.Wi
   #view: View;
   abstract internalName: string;
 
-  // This flag tracks if the Insights AI feature is enabled within Chrome for
-  // the active user.
-  #askAiEnabled = false;
   // Tracks if this component is rendered withing the AI assistance panel.
   // Currently only relevant to GreenDev.
   #isAIAssistanceContext = false;
@@ -246,16 +242,6 @@ export abstract class BaseInsightComponent<T extends InsightModel> extends UI.Wi
     return false;
   }
 
-  override wasShown(): void {
-    super.wasShown();
-
-    // Used for unit test purposes when querying the DOM.
-    this.element.dataset.insightName = this.internalName;
-
-    const {devToolsAiAssistancePerformanceAgent} = Root.Runtime.hostConfig;
-    this.#askAiEnabled = Boolean(devToolsAiAssistancePerformanceAgent?.enabled);
-  }
-
   set isAIAssistanceContext(isAIAssistanceContext: boolean) {
     this.#isAIAssistanceContext = isAIAssistanceContext;
     this.requestUpdate();
@@ -300,11 +286,11 @@ export abstract class BaseInsightComponent<T extends InsightModel> extends UI.Wi
     this.requestUpdate();
   }
 
-  set agentFocus(agentFocus: AIAssistance.AIContext.AgentFocus) {
+  set agentFocus(agentFocus: AIAssistance.AIContext.AgentFocus|null) {
     this.#agentFocus = agentFocus;
   }
 
-  set fieldMetrics(fieldMetrics: Trace.Insights.Common.CrUXFieldMetricResults) {
+  set fieldMetrics(fieldMetrics: Trace.Insights.Common.CrUXFieldMetricResults|null) {
     this.#fieldMetrics = fieldMetrics;
   }
 
@@ -422,7 +408,7 @@ export abstract class BaseInsightComponent<T extends InsightModel> extends UI.Wi
       estimatedSavingsString: this.getEstimatedSavingsString(),
       estimatedSavingsAriaLabel: this.#getEstimatedSavingsAriaLabel(),
       isAIAssistanceContext: this.#isAIAssistanceContext,
-      canShowAskAI: this.#canShowAskAI(),
+      showAskAI: this.#canShowAskAI(),
       dispatchInsightToggle: () => this.#dispatchInsightToggle(),
       renderContent: () => this.renderContent(),
       onHeaderKeyDown: () => this.#onHeaderKeyDown,
@@ -527,14 +513,19 @@ export abstract class BaseInsightComponent<T extends InsightModel> extends UI.Wi
   }
 
   #canShowAskAI(): boolean {
-    if (this.#isAIAssistanceContext) {
+    if (this.#isAIAssistanceContext || !this.hasAskAiSupport()) {
       return false;
     }
 
-    const aiAvailable = Root.Runtime.hostConfig.aidaAvailability?.enterprisePolicyValue !==
-            Root.Runtime.GenAiEnterprisePolicyValue.DISABLE &&
-        this.#askAiEnabled && Root.Runtime.hostConfig.aidaAvailability?.enabled === true;
+    // Check if the Insights AI feature enabled within Chrome for the active user.
+    const {devToolsAiAssistancePerformanceAgent} = Root.Runtime.hostConfig;
+    const askAiEnabled = Boolean(devToolsAiAssistancePerformanceAgent?.enabled);
+    if (!askAiEnabled) {
+      return false;
+    }
 
-    return aiAvailable && this.hasAskAiSupport();
+    const {aidaAvailability} = Root.Runtime.hostConfig;
+    return aidaAvailability?.enterprisePolicyValue !== Root.Runtime.GenAiEnterprisePolicyValue.DISABLE &&
+        aidaAvailability?.enabled === true;
   }
 }

package/front_end/panels/timeline/components/insights/Cache.ts

@@ -7,15 +7,17 @@ import './Table.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
 import type {CacheInsightModel} from '../../../../models/trace/insights/Cache.js';
 import * as Trace from '../../../../models/trace/trace.js';
+import * as UI from '../../../../ui/legacy/legacy.js';
 import * as Lit from '../../../../ui/lit/lit.js';
 
 import {BaseInsightComponent} from './BaseInsightComponent.js';
 import {eventRef} from './EventRef.js';
-import {createLimitedRows, renderOthersLabel, type TableData, type TableDataRow} from './Table.js';
+import {createLimitedRows, renderOthersLabel, Table, type TableDataRow} from './Table.js';
 
 const {UIStrings, i18nString, createOverlayForRequest} = Trace.Insights.Models.Cache;
 
 const {html} = Lit;
+const {widgetConfig} = UI.Widget;
 
 export class Cache extends BaseInsightComponent<CacheInsightModel> {
   override internalName = 'cache';
@@ -56,13 +58,15 @@ export class Cache extends BaseInsightComponent<CacheInsightModel> {
     // clang-format off
     return html`
       <div class="insight-section">
-        <devtools-performance-table
-          .data=${{
-            insight: this,
-            headers: [i18nString(UIStrings.requestColumn), i18nString(UIStrings.cacheTTL)],
-            rows,
-          } as TableData}>
-        </devtools-performance-table>
+        <devtools-widget
+          .widgetConfig=${widgetConfig(Table, {
+            data: {
+              insight: this,
+              headers: [i18nString(UIStrings.requestColumn), i18nString(UIStrings.cacheTTL)],
+              rows,
+            },
+          })}>
+        </devtools-widget>
       </div>`;
     // clang-format on
   }

package/front_end/panels/timeline/components/insights/DOMSize.ts

@@ -8,17 +8,19 @@ import './Table.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
 import type {DOMSizeInsightModel} from '../../../../models/trace/insights/DOMSize.js';
 import * as Trace from '../../../../models/trace/trace.js';
+import * as UI from '../../../../ui/legacy/legacy.js';
 import * as Lit from '../../../../ui/lit/lit.js';
 
 import {BaseInsightComponent} from './BaseInsightComponent.js';
 import {eventRef} from './EventRef.js';
 import {md} from './Helpers.js';
 import {nodeLink} from './NodeLink.js';
-import type {TableData, TableDataRow} from './Table.js';
+import {Table, type TableDataRow} from './Table.js';
 
 const {UIStrings, i18nString} = Trace.Insights.Models.DOMSize;
 
 const {html} = Lit;
+const {widgetConfig} = UI.Widget;
 
 export class DOMSize extends BaseInsightComponent<DOMSizeInsightModel> {
   override internalName = 'dom-size';
@@ -28,7 +30,7 @@ export class DOMSize extends BaseInsightComponent<DOMSizeInsightModel> {
   }
 
   #renderNodeTable(domStatsData: Trace.Types.Events.DOMStats['args']['data']): Lit.LitTemplate {
-    const rows: TableData['rows'] = [];
+    const rows: TableDataRow[] = [];
 
     if (domStatsData.maxDepth) {
       const {nodeId, nodeName} = domStatsData.maxDepth;
@@ -56,13 +58,13 @@ export class DOMSize extends BaseInsightComponent<DOMSizeInsightModel> {
 
     // clang-format off
     return html`<div class="insight-section">
-      <devtools-performance-table
-        .data=${{
+      <devtools-widget .widgetConfig=${widgetConfig(Table, {
+        data: {
           insight: this,
           headers: [i18nString(UIStrings.statistic), i18nString(UIStrings.element)],
           rows,
-        } as TableData}>
-      </devtools-performance-table>
+        }})}>
+      </devtools-widget>
     </div>`;
     // clang-format on
   }
@@ -86,13 +88,13 @@ export class DOMSize extends BaseInsightComponent<DOMSizeInsightModel> {
     // clang-format off
     return html`<div class="insight-section">
       <div class="insight-description">${md(i18nString(UIStrings.topUpdatesDescription))}</div>
-      <devtools-performance-table
-        .data=${{
+      <devtools-widget .widgetConfig=${widgetConfig(Table, {
+        data: {
           insight: this,
           headers: ['', i18nString(UIStrings.duration)],
           rows,
-        } as TableData}>
-      </devtools-performance-table>
+        }})}>
+      </devtools-widget>
     </div>`;
     // clang-format on
   }
@@ -109,17 +111,19 @@ export class DOMSize extends BaseInsightComponent<DOMSizeInsightModel> {
 
     // clang-format off
     return html`<div class="insight-section">
-      <devtools-performance-table
-        .data=${{
-          insight: this,
-          headers: [i18nString(UIStrings.statistic), i18nString(UIStrings.value)],
-          rows: [
-            {values: [i18nString(UIStrings.totalElements), domStatsData.totalElements]},
-            {values: [i18nString(UIStrings.maxDOMDepth), domStatsData.maxDepth?.depth ?? 0]},
-            {values: [i18nString(UIStrings.maxChildren), domStatsData.maxChildren?.numChildren ?? 0]},
-          ],
-        } as TableData}>
-      </devtools-performance-table>
+      <devtools-widget
+        .widgetConfig=${widgetConfig(Table, {
+          data: {
+            insight: this,
+            headers: [i18nString(UIStrings.statistic), i18nString(UIStrings.value)],
+            rows: [
+              {values: [i18nString(UIStrings.totalElements), domStatsData.totalElements]},
+              {values: [i18nString(UIStrings.maxDOMDepth), domStatsData.maxDepth?.depth ?? 0]},
+              {values: [i18nString(UIStrings.maxChildren), domStatsData.maxChildren?.numChildren ?? 0]},
+            ],
+          },
+        })}>
+      </devtools-widget>
     </div>
     ${this.#renderNodeTable(domStatsData)}
     ${this.#renderLargeUpdatesTable()}

package/front_end/panels/timeline/components/insights/DuplicatedJavaScript.ts

@@ -2,23 +2,23 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import './Table.js';
-
 import * as i18n from '../../../../core/i18n/i18n.js';
 import type {DuplicatedJavaScriptInsightModel} from '../../../../models/trace/insights/DuplicatedJavaScript.js';
 import * as Trace from '../../../../models/trace/trace.js';
 import * as Buttons from '../../../../ui/components/buttons/buttons.js';
+import * as UI from '../../../../ui/legacy/legacy.js';
 import * as Lit from '../../../../ui/lit/lit.js';
 import * as VisualLogging from '../../../../ui/visual_logging/visual_logging.js';
 import * as Utils from '../../utils/utils.js';
 
 import {BaseInsightComponent} from './BaseInsightComponent.js';
 import {scriptRef} from './ScriptRef.js';
-import type {TableData, TableDataRow} from './Table.js';
+import {Table, type TableDataRow} from './Table.js';
 
 const {UIStrings, i18nString} = Trace.Insights.Models.DuplicatedJavaScript;
 
 const {html} = Lit;
+const {widgetConfig} = UI.Widget;
 
 export class DuplicatedJavaScript extends BaseInsightComponent<DuplicatedJavaScriptInsightModel> {
   override internalName = 'duplicated-javascript';
@@ -105,13 +105,13 @@ export class DuplicatedJavaScript extends BaseInsightComponent<DuplicatedJavaScr
     return html`
       ${treemapButton}
       <div class="insight-section">
-        <devtools-performance-table
-          .data=${{
+        <devtools-widget .widgetConfig=${widgetConfig(Table, {
+           data: {
             insight: this,
             headers: [i18nString(UIStrings.columnSource), i18nString(UIStrings.columnDuplicatedBytes)],
             rows,
-          } as TableData}>
-        </devtools-performance-table>
+          }})}>
+        </devtools-widget>
       </div>
     `;
     // clang-format on

package/front_end/panels/timeline/components/insights/FontDisplay.ts

@@ -7,15 +7,17 @@ import './Table.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
 import type {FontDisplayInsightModel} from '../../../../models/trace/insights/FontDisplay.js';
 import * as Trace from '../../../../models/trace/trace.js';
+import * as UI from '../../../../ui/legacy/legacy.js';
 import * as Lit from '../../../../ui/lit/lit.js';
 
 import {BaseInsightComponent} from './BaseInsightComponent.js';
 import {eventRef} from './EventRef.js';
-import {createLimitedRows, renderOthersLabel, type TableData, type TableDataRow} from './Table.js';
+import {createLimitedRows, renderOthersLabel, Table, type TableDataRow} from './Table.js';
 
 const {UIStrings, i18nString} = Trace.Insights.Models.FontDisplay;
 
 const {html} = Lit;
+const {widgetConfig} = UI.Widget;
 
 export class FontDisplay extends BaseInsightComponent<FontDisplayInsightModel> {
   override internalName = 'font-display';
@@ -76,13 +78,13 @@ export class FontDisplay extends BaseInsightComponent<FontDisplayInsightModel> {
     // clang-format off
     return html`
       <div class="insight-section">
-        ${html`<devtools-performance-table
-          .data=${{
+        ${html`<devtools-widget .widgetConfig=${widgetConfig(Table, {
+           data: {
             insight: this,
             headers: [i18nString(UIStrings.fontColumn), i18nString(UIStrings.wastedTimeColumn)],
             rows,
-          } as TableData}>
-        </devtools-performance-table>`}
+          }})}>
+        </devtools-widget>`}
       </div>`;
     // clang-format on
   }

package/front_end/panels/timeline/components/insights/ForcedReflow.ts

@@ -9,14 +9,16 @@ import type * as Protocol from '../../../../generated/protocol.js';
 import type {ForcedReflowInsightModel} from '../../../../models/trace/insights/ForcedReflow.js';
 import * as Trace from '../../../../models/trace/trace.js';
 import * as LegacyComponents from '../../../../ui/legacy/components/utils/utils.js';
+import * as UI from '../../../../ui/legacy/legacy.js';
 import * as Lit from '../../../../ui/lit/lit.js';
 
 import {BaseInsightComponent} from './BaseInsightComponent.js';
-import {createLimitedRows, renderOthersLabel, type TableData, type TableDataRow} from './Table.js';
+import {createLimitedRows, renderOthersLabel, Table, type TableDataRow} from './Table.js';
 
 const {UIStrings, i18nString, createOverlayForEvents} = Trace.Insights.Models.ForcedReflow;
 
 const {html, nothing} = Lit;
+const {widgetConfig} = UI.Widget;
 
 export class ForcedReflow extends BaseInsightComponent<ForcedReflowInsightModel> {
   override internalName = 'forced-reflow';
@@ -85,8 +87,8 @@ export class ForcedReflow extends BaseInsightComponent<ForcedReflowInsightModel>
     return html`
       ${topLevelFunctionCallData ? html`
         <div class="insight-section">
-          <devtools-performance-table
-            .data=${{
+          <devtools-widget .widgetConfig=${widgetConfig(Table, {
+           data: {
               insight: this,
               headers: [i18nString(UIStrings.topTimeConsumingFunctionCall), i18nString(UIStrings.totalReflowTime)],
               rows: [{
@@ -96,18 +98,18 @@ export class ForcedReflow extends BaseInsightComponent<ForcedReflowInsightModel>
                 ],
                 overlays: createOverlayForEvents(topLevelFunctionCallData.topLevelFunctionCallEvents, 'INFO'),
               }],
-            } as TableData}>
-          </devtools-performance-table>
+            }})}>
+          </devtools-widget>
         </div>
       ` : nothing}
       <div class="insight-section">
-        <devtools-performance-table
-          .data=${{
+        <devtools-widget .widgetConfig=${widgetConfig(Table, {
+           data: {
             insight: this,
             headers: [i18nString(UIStrings.reflowCallFrames)],
             rows,
-        } as TableData}>
-        </devtools-performance-table>
+        }})}>
+        </devtools-widget>
       </div>`;
     // clang-format on
   }

package/front_end/panels/timeline/components/insights/INPBreakdown.ts

@@ -2,19 +2,20 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import './Table.js';
-
 import * as i18n from '../../../../core/i18n/i18n.js';
 import * as Platform from '../../../../core/platform/platform.js';
 import type {INPBreakdownInsightModel} from '../../../../models/trace/insights/INPBreakdown.js';
 import * as Trace from '../../../../models/trace/trace.js';
+import * as UI from '../../../../ui/legacy/legacy.js';
 import * as Lit from '../../../../ui/lit/lit.js';
 
 import {BaseInsightComponent} from './BaseInsightComponent.js';
+import {Table} from './Table.js';
 
 const {UIStrings, i18nString, createOverlaysForSubpart} = Trace.Insights.Models.INPBreakdown;
 
 const {html} = Lit;
+const {widgetConfig} = UI.Widget;
 
 export class INPBreakdown extends BaseInsightComponent<INPBreakdownInsightModel> {
   override internalName = 'inp';
@@ -35,8 +36,8 @@ export class INPBreakdown extends BaseInsightComponent<INPBreakdownInsightModel>
     // clang-format off
     return html`
       <div class="insight-section">
-        ${html`<devtools-performance-table
-          .data=${{
+        ${html`<devtools-widget .widgetConfig=${widgetConfig(Table, {
+           data: {
             insight: this,
             headers: [i18nString(UIStrings.subpart), i18nString(UIStrings.duration)],
             rows: [
@@ -53,8 +54,8 @@ export class INPBreakdown extends BaseInsightComponent<INPBreakdownInsightModel>
                 overlays: createOverlaysForSubpart(event, 2),
               },
             ],
-          }}>
-        </devtools-performance-table>`}
+          }})}>
+        </devtools-widget>`}
       </div>`;
     // clang-format on
   }

package/front_end/panels/timeline/components/insights/ImageDelivery.ts

@@ -6,15 +6,17 @@ import '../../../../ui/kit/kit.js';
 
 import type {ImageDeliveryInsightModel} from '../../../../models/trace/insights/ImageDelivery.js';
 import * as Trace from '../../../../models/trace/trace.js';
+import * as UI from '../../../../ui/legacy/legacy.js';
 import * as Lit from '../../../../ui/lit/lit.js';
 
 import {BaseInsightComponent} from './BaseInsightComponent.js';
 import {imageRef} from './ImageRef.js';
-import {createLimitedRows, renderOthersLabel, type TableDataRow} from './Table.js';
+import {createLimitedRows, renderOthersLabel, Table, type TableDataRow} from './Table.js';
 
 const {UIStrings, i18nString, createOverlayForRequest} = Trace.Insights.Models.ImageDelivery;
 
 const {html} = Lit;
+const {widgetConfig} = UI.Widget;
 
 export class ImageDelivery extends BaseInsightComponent<ImageDeliveryInsightModel> {
   override internalName = 'image-delivery';
@@ -56,13 +58,13 @@ export class ImageDelivery extends BaseInsightComponent<ImageDeliveryInsightMode
     // clang-format off
     return html`
       <div class="insight-section">
-        <devtools-performance-table
-          .data=${{
+        <devtools-widget .widgetConfig=${widgetConfig(Table, {
+           data: {
             insight: this,
             headers: [i18nString(UIStrings.optimizeFile)],
             rows,
-          }}>
-        </devtools-performance-table>
+          }})}>
+        </devtools-widget>
       </div>
     `;
     // clang-format on

package/front_end/panels/timeline/components/insights/InsightRenderer.ts

@@ -61,30 +61,32 @@ export class InsightRenderer {
   renderInsightToWidgetElement(
       parsedTrace: Trace.TraceModel.ParsedTrace, insightSet: Trace.Insights.Types.InsightSet,
       model: Trace.Insights.Types.InsightModel, insightName: string,
-      options: Partial<BaseInsightComponent<Trace.Insights.Types.InsightModel>>): InsightWidgetElement {
+      options: Partial<Pick<
+          BaseInsightComponent<Trace.Insights.Types.InsightModel>,
+          'selected'|'agentFocus'|'fieldMetrics'|'isAIAssistanceContext'>>): InsightWidgetElement {
     let widgetElement = this.#insightWidgetCache.get(model);
     if (!widgetElement) {
       widgetElement = document.createElement('devtools-widget') as InsightWidgetElement;
-
-      const componentClass = INSIGHT_NAME_TO_COMPONENT[insightName as keyof typeof INSIGHT_NAME_TO_COMPONENT];
-      const widget = new componentClass(widgetElement) as BaseInsightComponent<Trace.Insights.Types.InsightModel>;
-      widget.selected = false;
-      widget.parsedTrace = parsedTrace;
-      widget.model = model;
-      widget.bounds = insightSet.bounds;
-      widget.insightSetKey = insightSet.id;
-      Object.assign(widget, options);
-      widgetElement.widgetConfig = widgetConfig(() => {
-        return widget;
-      });
-
+      widgetElement.classList.add('insight-component-widget');
       this.#insightWidgetCache.set(model, widgetElement);
     }
 
-    const widget = widgetElement.getWidget();
-    if (widget) {
-      Object.assign(widget, options);
-    }
+    const componentClass = INSIGHT_NAME_TO_COMPONENT[insightName as keyof typeof INSIGHT_NAME_TO_COMPONENT];
+    widgetElement.widgetConfig = widgetConfig(componentClass, {
+      selected: options.selected ?? false,
+      parsedTrace,
+      // The `model` passed in as a parameter is the base type, but since
+      // `componentClass` is the union of every derived insight component, the
+      // `model` for the widget config is the union of every model. That can't be
+      // satisfied, so disable typescript.
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      model: model as any,
+      bounds: insightSet.bounds,
+      insightSetKey: insightSet.id,
+      agentFocus: options.agentFocus ?? null,
+      fieldMetrics: options.fieldMetrics ?? null,
+      isAIAssistanceContext: options.isAIAssistanceContext ?? false,
+    });
 
     return widgetElement;
   }

package/front_end/panels/timeline/components/insights/LCPBreakdown.ts

@@ -2,20 +2,20 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import './Table.js';
-
 import * as i18n from '../../../../core/i18n/i18n.js';
 import type {LCPBreakdownInsightModel} from '../../../../models/trace/insights/LCPBreakdown.js';
 import * as Trace from '../../../../models/trace/trace.js';
+import * as UI from '../../../../ui/legacy/legacy.js';
 import * as Lit from '../../../../ui/lit/lit.js';
 import type * as Overlays from '../../overlays/overlays.js';
 
 import {BaseInsightComponent} from './BaseInsightComponent.js';
-import type {TableData} from './Table.js';
+import {Table, type TableDataRow} from './Table.js';
 
 const {UIStrings, i18nString} = Trace.Insights.Models.LCPBreakdown;
 
 const {html} = Lit;
+const {widgetConfig} = UI.Widget;
 
 export class LCPBreakdown extends BaseInsightComponent<LCPBreakdownInsightModel> {
   override internalName = 'lcp-by-phase';
@@ -69,13 +69,13 @@ export class LCPBreakdown extends BaseInsightComponent<LCPBreakdownInsightModel>
     // clang-format off
     return html`
       <div class="insight-section">
-        <devtools-performance-table
-          .data=${{
+        <devtools-widget .widgetConfig=${widgetConfig(Table, {
+           data: {
             insight: this,
             headers: [i18nString(UIStrings.subpart), i18nString(UIStrings.fieldDuration)],
             rows,
-          } as TableData}>
-        </devtools-performance-table>
+          }})}>
+        </devtools-widget>
       </div>
     `;
     // clang-format on
@@ -101,7 +101,7 @@ export class LCPBreakdown extends BaseInsightComponent<LCPBreakdownInsightModel>
       return html`<div class="insight-section">${i18nString(UIStrings.noLcp)}</div>`;
     }
 
-    const rows = Object.values(subparts).map((subpart: Trace.Insights.Models.LCPBreakdown.Subpart) => {
+    const rows: TableDataRow[] = Object.values(subparts).map((subpart: Trace.Insights.Models.LCPBreakdown.Subpart) => {
       const section = this.#overlay?.sections.find(section => subpart.label === section.label);
       const timing = Trace.Helpers.Timing.microToMilli(subpart.range);
       return {
@@ -116,13 +116,13 @@ export class LCPBreakdown extends BaseInsightComponent<LCPBreakdownInsightModel>
     // clang-format off
     const sections: Lit.LitTemplate[] = [html`
       <div class="insight-section">
-        <devtools-performance-table
-          .data=${{
+        <devtools-widget .widgetConfig=${widgetConfig(Table, {
+           data: {
             insight: this,
             headers: [i18nString(UIStrings.subpart), i18nString(UIStrings.duration)],
             rows,
-          } as TableData}>
-        </devtools-performance-table>
+          }})}>
+        </devtools-widget>
       </div>`
     ];
     // clang-format on

package/front_end/panels/timeline/components/insights/LegacyJavaScript.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import './Table.js';
-
 import * as Common from '../../../../core/common/common.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
 import * as SDK from '../../../../core/sdk/sdk.js';
@@ -11,15 +9,17 @@ import * as Bindings from '../../../../models/bindings/bindings.js';
 import type {
   LegacyJavaScriptInsightModel, PatternMatchResult} from '../../../../models/trace/insights/LegacyJavaScript.js';
 import * as Trace from '../../../../models/trace/trace.js';
+import * as UI from '../../../../ui/legacy/legacy.js';
 import * as Lit from '../../../../ui/lit/lit.js';
 
 import {BaseInsightComponent} from './BaseInsightComponent.js';
 import {scriptRef} from './ScriptRef.js';
-import type {TableData, TableDataRow} from './Table.js';
+import {Table, type TableDataRow} from './Table.js';
 
 const {UIStrings, i18nString} = Trace.Insights.Models.LegacyJavaScript;
 
 const {html} = Lit;
+const {widgetConfig} = UI.Widget;
 
 export class LegacyJavaScript extends BaseInsightComponent<LegacyJavaScriptInsightModel> {
   override internalName = 'legacy-javascript';
@@ -85,13 +85,13 @@ export class LegacyJavaScript extends BaseInsightComponent<LegacyJavaScriptInsig
     // clang-format off
     return html`
       <div class="insight-section">
-        <devtools-performance-table
-          .data=${{
+        <devtools-widget .widgetConfig=${widgetConfig(Table, {
+           data: {
             insight: this,
             headers: [i18nString(UIStrings.columnScript), i18nString(UIStrings.columnWastedBytes)],
             rows,
-          } as TableData}>
-        </devtools-performance-table>
+          }})}>
+        </devtools-widget>
       </div>
     `;
     // clang-format on