chrome-devtools-frontend 1.0.1549484 → 1.0.1550444

package/front_end/models/issues_manager/ElementAccessibilityIssue.ts

@@ -12,9 +12,7 @@ import {
   resolveLazyDescription
 } from './MarkdownIssueDescription.js';
 
-export class ElementAccessibilityIssue extends Issue {
-  private issueDetails: Protocol.Audits.ElementAccessibilityIssueDetails;
-
+export class ElementAccessibilityIssue extends Issue<Protocol.Audits.ElementAccessibilityIssueDetails> {
   constructor(
       issueDetails: Protocol.Audits.ElementAccessibilityIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null,
       issueId?: Protocol.Audits.IssueId) {
@@ -22,12 +20,11 @@ export class ElementAccessibilityIssue extends Issue {
       Protocol.Audits.InspectorIssueCode.ElementAccessibilityIssue,
       issueDetails.elementAccessibilityIssueReason,
     ].join('::');
-    super(issueCode, issuesModel, issueId);
-    this.issueDetails = issueDetails;
+    super(issueCode, issueDetails, issuesModel, issueId);
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.details());
   }
 
   getDescription(): MarkdownIssueDescription|null {
@@ -37,7 +34,7 @@ export class ElementAccessibilityIssue extends Issue {
         links: [],
       };
     }
-    const description = issueDescriptions.get(this.issueDetails.elementAccessibilityIssueReason);
+    const description = issueDescriptions.get(this.details().elementAccessibilityIssueReason);
     if (!description) {
       return null;
     }
@@ -52,15 +49,11 @@ export class ElementAccessibilityIssue extends Issue {
     return IssueCategory.OTHER;
   }
 
-  details(): Protocol.Audits.ElementAccessibilityIssueDetails {
-    return this.issueDetails;
-  }
-
   isInteractiveContentAttributesSelectDescendantIssue(): boolean {
-    return this.issueDetails.hasDisallowedAttributes &&
-        (this.issueDetails.elementAccessibilityIssueReason !==
+    return this.details().hasDisallowedAttributes &&
+        (this.details().elementAccessibilityIssueReason !==
              Protocol.Audits.ElementAccessibilityIssueReason.InteractiveContentOptionChild &&
-         this.issueDetails.elementAccessibilityIssueReason !==
+         this.details().elementAccessibilityIssueReason !==
              Protocol.Audits.ElementAccessibilityIssueReason.InteractiveContentSummaryDescendant);
   }
 

package/front_end/models/issues_manager/FederatedAuthRequestIssue.ts

@@ -22,9 +22,7 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/FederatedAuthRequestIssue.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
-export class FederatedAuthRequestIssue extends Issue {
-  readonly #issueDetails: Protocol.Audits.FederatedAuthRequestIssueDetails;
-
+export class FederatedAuthRequestIssue extends Issue<Protocol.Audits.FederatedAuthRequestIssueDetails> {
   constructor(
       issueDetails: Protocol.Audits.FederatedAuthRequestIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
     super(
@@ -35,20 +33,15 @@ export class FederatedAuthRequestIssue extends Issue {
             issueDetails.federatedAuthRequestIssueReason,
           ].join('::'),
         },
-        issuesModel);
-    this.#issueDetails = issueDetails;
+        issueDetails, issuesModel);
   }
 
   getCategory(): IssueCategory {
     return IssueCategory.OTHER;
   }
 
-  details(): Protocol.Audits.FederatedAuthRequestIssueDetails {
-    return this.#issueDetails;
-  }
-
   getDescription(): MarkdownIssueDescription|null {
-    const description = issueDescriptions.get(this.#issueDetails.federatedAuthRequestIssueReason);
+    const description = issueDescriptions.get(this.details().federatedAuthRequestIssueReason);
     if (!description) {
       return null;
     }
@@ -56,7 +49,7 @@ export class FederatedAuthRequestIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.#issueDetails);
+    return JSON.stringify(this.details());
   }
 
   getKind(): IssueKind {

package/front_end/models/issues_manager/FederatedAuthUserInfoRequestIssue.ts

@@ -22,9 +22,7 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/FederatedAuthUserInfoRequestIssue.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
-export class FederatedAuthUserInfoRequestIssue extends Issue {
-  readonly #issueDetails: Protocol.Audits.FederatedAuthUserInfoRequestIssueDetails;
-
+export class FederatedAuthUserInfoRequestIssue extends Issue<Protocol.Audits.FederatedAuthUserInfoRequestIssueDetails> {
   constructor(
       issueDetails: Protocol.Audits.FederatedAuthUserInfoRequestIssueDetails,
       issuesModel: SDK.IssuesModel.IssuesModel) {
@@ -36,20 +34,15 @@ export class FederatedAuthUserInfoRequestIssue extends Issue {
             issueDetails.federatedAuthUserInfoRequestIssueReason,
           ].join('::'),
         },
-        issuesModel);
-    this.#issueDetails = issueDetails;
+        issueDetails, issuesModel);
   }
 
   getCategory(): IssueCategory {
     return IssueCategory.OTHER;
   }
 
-  details(): Protocol.Audits.FederatedAuthUserInfoRequestIssueDetails {
-    return this.#issueDetails;
-  }
-
   getDescription(): MarkdownIssueDescription|null {
-    const description = issueDescriptions.get(this.#issueDetails.federatedAuthUserInfoRequestIssueReason);
+    const description = issueDescriptions.get(this.details().federatedAuthUserInfoRequestIssueReason);
     if (!description) {
       return null;
     }
@@ -57,7 +50,7 @@ export class FederatedAuthUserInfoRequestIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.#issueDetails);
+    return JSON.stringify(this.details());
   }
 
   getKind(): IssueKind {

package/front_end/models/issues_manager/GenericIssue.ts

@@ -48,9 +48,7 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/GenericIssue.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
-export class GenericIssue extends Issue {
-  #issueDetails: Protocol.Audits.GenericIssueDetails;
-
+export class GenericIssue extends Issue<Protocol.Audits.GenericIssueDetails> {
   constructor(
       issueDetails: Protocol.Audits.GenericIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null,
       issueId?: Protocol.Audits.IssueId) {
@@ -58,13 +56,13 @@ export class GenericIssue extends Issue {
       Protocol.Audits.InspectorIssueCode.GenericIssue,
       issueDetails.errorType,
     ].join('::');
-    super(issueCode, issuesModel, issueId);
-    this.#issueDetails = issueDetails;
+    super(issueCode, issueDetails, issuesModel, issueId);
   }
 
   override requests(): Iterable<Protocol.Audits.AffectedRequest> {
-    if (this.#issueDetails.request) {
-      return [this.#issueDetails.request];
+    const details = this.details();
+    if (details.request) {
+      return [details.request];
     }
     return [];
   }
@@ -74,25 +72,22 @@ export class GenericIssue extends Issue {
   }
 
   primaryKey(): string {
-    const requestId = this.#issueDetails.request ? this.#issueDetails.request.requestId : 'no-request';
-    return `${this.code()}-(${this.#issueDetails.frameId})-(${this.#issueDetails.violatingNodeId})-(${
-        this.#issueDetails.violatingNodeAttribute})-(${requestId})`;
+    const details = this.details();
+    const requestId = details.request ? details.request.requestId : 'no-request';
+    return `${this.code()}-(${details.frameId})-(${details.violatingNodeId})-(${details.violatingNodeAttribute})-(${
+        requestId})`;
   }
 
   getDescription(): MarkdownIssueDescription|null {
-    const description = issueDescriptions.get(this.#issueDetails.errorType);
+    const description = issueDescriptions.get(this.details().errorType);
     if (!description) {
       return null;
     }
     return resolveLazyDescription(description);
   }
 
-  details(): Protocol.Audits.GenericIssueDetails {
-    return this.#issueDetails;
-  }
-
   getKind(): IssueKind {
-    return issueTypes.get(this.#issueDetails.errorType) || IssueKind.IMPROVEMENT;
+    return issueTypes.get(this.details().errorType) || IssueKind.IMPROVEMENT;
   }
 
   static fromInspectorIssue(

package/front_end/models/issues_manager/HeavyAdIssue.ts

@@ -18,21 +18,14 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/HeavyAdIssue.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export class HeavyAdIssue extends Issue {
-  #issueDetails: Protocol.Audits.HeavyAdIssueDetails;
-
+export class HeavyAdIssue extends Issue<Protocol.Audits.HeavyAdIssueDetails> {
   constructor(issueDetails: Protocol.Audits.HeavyAdIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
     const umaCode = [Protocol.Audits.InspectorIssueCode.HeavyAdIssue, issueDetails.reason].join('::');
-    super({code: Protocol.Audits.InspectorIssueCode.HeavyAdIssue, umaCode}, issuesModel);
-    this.#issueDetails = issueDetails;
-  }
-
-  details(): Protocol.Audits.HeavyAdIssueDetails {
-    return this.#issueDetails;
+    super({code: Protocol.Audits.InspectorIssueCode.HeavyAdIssue, umaCode}, issueDetails, issuesModel);
   }
 
   primaryKey(): string {
-    return `${Protocol.Audits.InspectorIssueCode.HeavyAdIssue}-${JSON.stringify(this.#issueDetails)}`;
+    return `${Protocol.Audits.InspectorIssueCode.HeavyAdIssue}-${JSON.stringify(this.details())}`;
   }
 
   getDescription(): MarkdownIssueDescription {
@@ -52,7 +45,7 @@ export class HeavyAdIssue extends Issue {
   }
 
   getKind(): IssueKind {
-    switch (this.#issueDetails.resolution) {
+    switch (this.details().resolution) {
       case Protocol.Audits.HeavyAdResolutionStatus.HeavyAdBlocked:
         return IssueKind.PAGE_ERROR;
       case Protocol.Audits.HeavyAdResolutionStatus.HeavyAdWarning:

package/front_end/models/issues_manager/Issue.ts

@@ -119,17 +119,21 @@ export interface AffectedElement {
   nodeName: string;
   target: SDK.Target.Target|null;
 }
-
-export abstract class Issue<IssueCode extends string = string> {
+export type ValidIssueDetails =
+    NonNullable<Protocol.Audits.InspectorIssueDetails[keyof Protocol.Audits.InspectorIssueDetails]>;
+export abstract class Issue<IssueDetails extends ValidIssueDetails|null = ValidIssueDetails | null,
+                                                 IssueCode extends string = string> {
   #issueCode: IssueCode;
   #issuesModel: SDK.IssuesModel.IssuesModel|null;
   protected issueId: Protocol.Audits.IssueId|undefined = undefined;
+  #issueDetails: IssueDetails;
   #hidden: boolean;
 
   constructor(
-      code: IssueCode|{code: IssueCode, umaCode: string}, issuesModel: SDK.IssuesModel.IssuesModel|null = null,
-      issueId?: Protocol.Audits.IssueId) {
+      code: IssueCode|{code: IssueCode, umaCode: string}, issueDetails: IssueDetails,
+      issuesModel: SDK.IssuesModel.IssuesModel|null = null, issueId?: Protocol.Audits.IssueId) {
     this.#issueCode = typeof code === 'object' ? code.code : code;
+    this.#issueDetails = issueDetails;
     this.#issuesModel = issuesModel;
     this.issueId = issueId;
     Host.userMetrics.issueCreated(typeof code === 'string' ? code : code.umaCode);
@@ -145,6 +149,10 @@ export abstract class Issue<IssueCode extends string = string> {
   abstract getCategory(): IssueCategory;
   abstract getKind(): IssueKind;
 
+  details(): IssueDetails {
+    return this.#issueDetails;
+  }
+
   getBlockedByResponseDetails(): Iterable<Protocol.Audits.BlockedByResponseIssueDetails> {
     return [];
   }

package/front_end/models/issues_manager/IssueAggregator.ts

@@ -47,6 +47,7 @@ export type AggregationKey = {
  * of all resources that are affected by the aggregated issues.
  */
 export class AggregatedIssue extends Issue {
+  #allIssues = new Set<Issue>();
   #affectedCookies = new Map<string, {
     cookie: Protocol.Audits.AffectedCookie,
     hasRequest: boolean,
@@ -76,7 +77,7 @@ export class AggregatedIssue extends Issue {
   #key: AggregationKey;
 
   constructor(code: string, aggregationKey: AggregationKey) {
-    super(code);
+    super(code, null);
     this.#key = aggregationKey;
   }
 
@@ -203,6 +204,7 @@ export class AggregatedIssue extends Issue {
     if (!this.#representative) {
       this.#representative = issue;
     }
+    this.#allIssues.add(issue);
     this.#issueKind = unionIssueKind(this.#issueKind, issue.getKind());
     let hasRequest = false;
     for (const request of issue.requests()) {
@@ -286,6 +288,10 @@ export class AggregatedIssue extends Issue {
     return this.#issueKind;
   }
 
+  getAllIssues(): Issue[] {
+    return Array.from(this.#allIssues);
+  }
+
   override isHidden(): boolean {
     return this.#representative?.isHidden() || false;
   }
@@ -374,7 +380,7 @@ export class IssueAggregator extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     return this.#hiddenAggregatedIssuesByKey.size;
   }
 
-  keyForIssue(issue: Issue<string>): AggregationKey {
+  keyForIssue(issue: Issue): AggregationKey {
     return issue.code() as unknown as AggregationKey;
   }
 }

package/front_end/models/issues_manager/LowTextContrastIssue.ts

@@ -18,29 +18,22 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/LowTextContrastIssue.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export class LowTextContrastIssue extends Issue {
-  #issueDetails: Protocol.Audits.LowTextContrastIssueDetails;
-
+export class LowTextContrastIssue extends Issue<Protocol.Audits.LowTextContrastIssueDetails> {
   constructor(
       issueDetails: Protocol.Audits.LowTextContrastIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
-    super('LowTextContrastIssue', issuesModel);
-    this.#issueDetails = issueDetails;
+    super('LowTextContrastIssue', issueDetails, issuesModel);
   }
 
   primaryKey(): string {
     // We intend to keep only one issue per element so other issues for the element will be discarded even
     // if the issue content is slightly different.
-    return `${this.code()}-(${this.#issueDetails.violatingNodeId})`;
+    return `${this.code()}-(${this.details().violatingNodeId})`;
   }
 
   getCategory(): IssueCategory {
     return IssueCategory.LOW_TEXT_CONTRAST;
   }
 
-  details(): Protocol.Audits.LowTextContrastIssueDetails {
-    return this.#issueDetails;
-  }
-
   getDescription(): MarkdownIssueDescription {
     return {
       file: 'LowTextContrast.md',

package/front_end/models/issues_manager/MixedContentIssue.ts

@@ -18,25 +18,19 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/MixedContentIssue.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export class MixedContentIssue extends Issue {
-  #issueDetails: Protocol.Audits.MixedContentIssueDetails;
-
+export class MixedContentIssue extends Issue<Protocol.Audits.MixedContentIssueDetails> {
   constructor(issueDetails: Protocol.Audits.MixedContentIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
-    super(Protocol.Audits.InspectorIssueCode.MixedContentIssue, issuesModel);
-    this.#issueDetails = issueDetails;
+    super(Protocol.Audits.InspectorIssueCode.MixedContentIssue, issueDetails, issuesModel);
   }
 
   override requests(): Iterable<Protocol.Audits.AffectedRequest> {
-    if (this.#issueDetails.request) {
-      return [this.#issueDetails.request];
+    const details = this.details();
+    if (details.request) {
+      return [details.request];
     }
     return [];
   }
 
-  getDetails(): Protocol.Audits.MixedContentIssueDetails {
-    return this.#issueDetails;
-  }
-
   getCategory(): IssueCategory {
     return IssueCategory.MIXED_CONTENT;
   }
@@ -50,11 +44,11 @@ export class MixedContentIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.#issueDetails);
+    return JSON.stringify(this.details());
   }
 
   getKind(): IssueKind {
-    switch (this.#issueDetails.resolutionStatus) {
+    switch (this.details().resolutionStatus) {
       case Protocol.Audits.MixedContentResolutionStatus.MixedContentAutomaticallyUpgraded:
         return IssueKind.IMPROVEMENT;
       case Protocol.Audits.MixedContentResolutionStatus.MixedContentBlocked:

package/front_end/models/issues_manager/PartitioningBlobURLIssue.ts

@@ -23,13 +23,10 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/PartitioningBlobURLIssue.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export class PartitioningBlobURLIssue extends Issue {
-  readonly #issueDetails: Protocol.Audits.PartitioningBlobURLIssueDetails;
-
+export class PartitioningBlobURLIssue extends Issue<Protocol.Audits.PartitioningBlobURLIssueDetails> {
   constructor(
       issueDetails: Protocol.Audits.PartitioningBlobURLIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
-    super(Protocol.Audits.InspectorIssueCode.PartitioningBlobURLIssue, issuesModel);
-    this.#issueDetails = issueDetails;
+    super(Protocol.Audits.InspectorIssueCode.PartitioningBlobURLIssue, issueDetails, issuesModel);
   }
 
   getCategory(): IssueCategory {
@@ -37,7 +34,7 @@ export class PartitioningBlobURLIssue extends Issue {
   }
 
   getDescription(): MarkdownIssueDescription {
-    const fileName = this.#issueDetails.partitioningBlobURLInfo ===
+    const fileName = this.details().partitioningBlobURLInfo ===
             Protocol.Audits.PartitioningBlobURLInfo.BlockedCrossPartitionFetching ?
         'fetchingPartitionedBlobURL.md' :
         'navigatingPartitionedBlobURL.md';
@@ -56,16 +53,12 @@ export class PartitioningBlobURLIssue extends Issue {
     };
   }
 
-  details(): Protocol.Audits.PartitioningBlobURLIssueDetails {
-    return this.#issueDetails;
-  }
-
   getKind(): IssueKind {
     return IssueKind.BREAKING_CHANGE;
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.#issueDetails);
+    return JSON.stringify(this.details());
   }
 
   static fromInspectorIssue(

package/front_end/models/issues_manager/PropertyRuleIssue.ts

@@ -8,22 +8,16 @@ import * as Protocol from '../../generated/protocol.js';
 import {Issue, IssueCategory, IssueKind} from './Issue.js';
 import type {MarkdownIssueDescription} from './MarkdownIssueDescription.js';
 
-export class PropertyRuleIssue extends Issue {
-  readonly #issueDetails: Protocol.Audits.PropertyRuleIssueDetails;
+export class PropertyRuleIssue extends Issue<Protocol.Audits.PropertyRuleIssueDetails> {
   readonly #primaryKey: string;
   constructor(issueDetails: Protocol.Audits.PropertyRuleIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
     const code = JSON.stringify(issueDetails);
-    super(code, issuesModel);
+    super(code, issueDetails, issuesModel);
     this.#primaryKey = code;
-    this.#issueDetails = issueDetails;
   }
 
   override sources(): Protocol.Audits.SourceCodeLocation[] {
-    return [this.#issueDetails.sourceCodeLocation];
-  }
-
-  details(): Protocol.Audits.PropertyRuleIssueDetails {
-    return this.#issueDetails;
+    return [this.details().sourceCodeLocation];
   }
 
   primaryKey(): string {
@@ -31,7 +25,7 @@ export class PropertyRuleIssue extends Issue {
   }
 
   getPropertyName(): string {
-    switch (this.#issueDetails.propertyRuleIssueReason) {
+    switch (this.details().propertyRuleIssueReason) {
       case Protocol.Audits.PropertyRuleIssueReason.InvalidInherits:
         return 'inherits';
       case Protocol.Audits.PropertyRuleIssueReason.InvalidInitialValue:
@@ -43,13 +37,13 @@ export class PropertyRuleIssue extends Issue {
   }
 
   getDescription(): MarkdownIssueDescription {
-    if (this.#issueDetails.propertyRuleIssueReason === Protocol.Audits.PropertyRuleIssueReason.InvalidName) {
+    if (this.details().propertyRuleIssueReason === Protocol.Audits.PropertyRuleIssueReason.InvalidName) {
       return {
         file: 'propertyRuleInvalidNameIssue.md',
         links: [],
       };
     }
-    const value = this.#issueDetails.propertyValue ? `: ${this.#issueDetails.propertyValue}` : '';
+    const value = this.details().propertyValue ? `: ${this.details().propertyValue}` : '';
     const property = `${this.getPropertyName()}${value}`;
     return {
       file: 'propertyRuleIssue.md',

package/front_end/models/issues_manager/QuirksModeIssue.ts

@@ -18,28 +18,21 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/QuirksModeIssue.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export class QuirksModeIssue extends Issue {
-  #issueDetails: Protocol.Audits.QuirksModeIssueDetails;
-
+export class QuirksModeIssue extends Issue<Protocol.Audits.QuirksModeIssueDetails> {
   constructor(issueDetails: Protocol.Audits.QuirksModeIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
     const mode = issueDetails.isLimitedQuirksMode ? 'LimitedQuirksMode' : 'QuirksMode';
     const umaCode = [Protocol.Audits.InspectorIssueCode.QuirksModeIssue, mode].join('::');
-    super({code: Protocol.Audits.InspectorIssueCode.QuirksModeIssue, umaCode}, issuesModel);
-    this.#issueDetails = issueDetails;
+    super({code: Protocol.Audits.InspectorIssueCode.QuirksModeIssue, umaCode}, issueDetails, issuesModel);
   }
 
   primaryKey(): string {
-    return `${this.code()}-(${this.#issueDetails.documentNodeId})-(${this.#issueDetails.url})`;
+    return `${this.code()}-(${this.details().documentNodeId})-(${this.details().url})`;
   }
 
   getCategory(): IssueCategory {
     return IssueCategory.QUIRKS_MODE;
   }
 
-  details(): Protocol.Audits.QuirksModeIssueDetails {
-    return this.#issueDetails;
-  }
-
   getDescription(): MarkdownIssueDescription {
     return {
       file: 'CompatibilityModeQuirks.md',

package/front_end/models/issues_manager/SRIMessageSignatureIssue.ts

@@ -41,9 +41,7 @@ function generateGroupingIssueCode(details: Protocol.Audits.SRIMessageSignatureI
   return issueCode;
 }
 
-export class SRIMessageSignatureIssue extends Issue<string> {
-  readonly #issueDetails: Protocol.Audits.SRIMessageSignatureIssueDetails;
-
+export class SRIMessageSignatureIssue extends Issue<Protocol.Audits.SRIMessageSignatureIssueDetails, string> {
   constructor(
       issueDetails: Protocol.Audits.SRIMessageSignatureIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
     super(
@@ -51,12 +49,7 @@ export class SRIMessageSignatureIssue extends Issue<string> {
           code: generateGroupingIssueCode(issueDetails),
           umaCode: `${Protocol.Audits.InspectorIssueCode.SRIMessageSignatureIssue}::${issueDetails.error}`,
         },
-        issuesModel);
-    this.#issueDetails = issueDetails;
-  }
-
-  details(): Protocol.Audits.SRIMessageSignatureIssueDetails {
-    return this.#issueDetails;
+        issueDetails, issuesModel);
   }
 
   // Overriding `Issue<String>`:
@@ -65,8 +58,9 @@ export class SRIMessageSignatureIssue extends Issue<string> {
   }
 
   override getDescription(): MarkdownIssueDescription|null {
+    const details = this.details();
     const description: LazyMarkdownIssueDescription = {
-      file: `sri${this.details().error}.md`,
+      file: `sri${details.error}.md`,
       links: [
         {
           link: 'https://www.rfc-editor.org/rfc/rfc9421.html',
@@ -79,10 +73,10 @@ export class SRIMessageSignatureIssue extends Issue<string> {
       ],
       substitutions: new Map()
     };
-    if (this.#issueDetails.error === Protocol.Audits.SRIMessageSignatureError.ValidationFailedSignatureMismatch) {
-      description.substitutions?.set('PLACEHOLDER_signatureBase', () => this.#issueDetails.signatureBase);
+    if (details.error === Protocol.Audits.SRIMessageSignatureError.ValidationFailedSignatureMismatch) {
+      description.substitutions?.set('PLACEHOLDER_signatureBase', () => details.signatureBase);
     }
-    if (this.#issueDetails.error === Protocol.Audits.SRIMessageSignatureError.ValidationFailedIntegrityMismatch) {
+    if (details.error === Protocol.Audits.SRIMessageSignatureError.ValidationFailedIntegrityMismatch) {
       description.substitutions?.set('PLACEHOLDER_integrityAssertions', () => {
         const prefix = '\n* ';
         return prefix + this.details().integrityAssertions.join(prefix);

package/front_end/models/issues_manager/SharedArrayBufferIssue.ts

@@ -19,24 +19,17 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/SharedArrayBufferIssue.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export class SharedArrayBufferIssue extends Issue {
-  #issueDetails: Protocol.Audits.SharedArrayBufferIssueDetails;
-
+export class SharedArrayBufferIssue extends Issue<Protocol.Audits.SharedArrayBufferIssueDetails> {
   constructor(
       issueDetails: Protocol.Audits.SharedArrayBufferIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
     const umaCode = [Protocol.Audits.InspectorIssueCode.SharedArrayBufferIssue, issueDetails.type].join('::');
-    super({code: Protocol.Audits.InspectorIssueCode.SharedArrayBufferIssue, umaCode}, issuesModel);
-    this.#issueDetails = issueDetails;
+    super({code: Protocol.Audits.InspectorIssueCode.SharedArrayBufferIssue, umaCode}, issueDetails, issuesModel);
   }
 
   getCategory(): IssueCategory {
     return IssueCategory.OTHER;
   }
 
-  details(): Protocol.Audits.SharedArrayBufferIssueDetails {
-    return this.#issueDetails;
-  }
-
   getDescription(): MarkdownIssueDescription {
     return {
       file: 'sharedArrayBuffer.md',
@@ -48,11 +41,11 @@ export class SharedArrayBufferIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.#issueDetails);
+    return JSON.stringify(this.details());
   }
 
   getKind(): IssueKind {
-    if (this.#issueDetails.isWarning) {
+    if (this.details().isWarning) {
       return IssueKind.BREAKING_CHANGE;
     }
     return IssueKind.PAGE_ERROR;

package/front_end/models/issues_manager/SharedDictionaryIssue.ts

@@ -108,9 +108,7 @@ function getIssueCode(details: Protocol.Audits.SharedDictionaryIssueDetails): Is
   }
 }
 
-export class SharedDictionaryIssue extends Issue {
-  readonly #issueDetails: Protocol.Audits.SharedDictionaryIssueDetails;
-
+export class SharedDictionaryIssue extends Issue<Protocol.Audits.SharedDictionaryIssueDetails, IssueCode> {
   constructor(
       issueDetails: Protocol.Audits.SharedDictionaryIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel|null) {
     super(
@@ -121,13 +119,12 @@ export class SharedDictionaryIssue extends Issue {
             issueDetails.sharedDictionaryError,
           ].join('::'),
         },
-        issuesModel);
-    this.#issueDetails = issueDetails;
+        issueDetails, issuesModel);
   }
 
   override requests(): Iterable<Protocol.Audits.AffectedRequest> {
-    if (this.#issueDetails.request) {
-      return [this.#issueDetails.request];
+    if (this.details().request) {
+      return [this.details().request];
     }
     return [];
   }
@@ -136,12 +133,8 @@ export class SharedDictionaryIssue extends Issue {
     return IssueCategory.OTHER;
   }
 
-  details(): Protocol.Audits.SharedDictionaryIssueDetails {
-    return this.#issueDetails;
-  }
-
   getDescription(): MarkdownIssueDescription|null {
-    const description = issueDescriptions.get(this.#issueDetails.sharedDictionaryError);
+    const description = issueDescriptions.get(this.details().sharedDictionaryError);
     if (!description) {
       return null;
     }
@@ -149,7 +142,7 @@ export class SharedDictionaryIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.#issueDetails);
+    return JSON.stringify(this.details());
   }
 
   getKind(): IssueKind {